[GitHub] [mynewt-core] robertlipe closed pull request #2560: Update fe310_hal.h
robertlipe closed pull request #2560: URL: https://github.com/apache/mynewt-core/pull/2560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] robertlipe commented on pull request #2559: SiFive Typo Fix
robertlipe commented on pull request #2559: URL: https://github.com/apache/mynewt-core/pull/2559#issuecomment-818490464 Thanx, Jerzy. I'd forgotten what a disaster the "edit file" web interface makes of a multiple file change. There was no renaming. I don't know what kind of drugs git is on. I just checked it out locally and fixed it in my tree. There isn't a "hello, blinky" for RISC-V targets, so I'm still working out how to actually build it. I'll drop these in favor of https://github.com/apache/mynewt-core/pull/2565 Thanx for the gentle nudge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] robertlipe closed pull request #2559: SiFive Typo Fix
robertlipe closed pull request #2559: URL: https://github.com/apache/mynewt-core/pull/2559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] robertlipe opened a new pull request #2565: mcu/fe310: Fix typo
robertlipe opened a new pull request #2565: URL: https://github.com/apache/mynewt-core/pull/2565 Fix typo and duplicated function prototype. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #960: Align logo, grammar updates
apache-mynewt-bot removed a comment on pull request #960:
URL: https://github.com/apache/mynewt-nimble/pull/960#issuecomment-814329724
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #960: Align logo, grammar updates
apache-mynewt-bot commented on pull request #960:
URL: https://github.com/apache/mynewt-nimble/pull/960#issuecomment-818450200
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
apache-mynewt-bot commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-818402096
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] fredster33 commented on a change in pull request #960: Align logo, grammar updates
fredster33 commented on a change in pull request #960: URL: https://github.com/apache/mynewt-nimble/pull/960#discussion_r612090238 ## File path: README.md ## @@ -19,22 +19,26 @@ # --> + Review comment: All right, dealigned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-site] 02/02: asf-site update Mon Apr 12 23:45:39 UTC 2021
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/mynewt-site.git commit bfea1a383da5efb4b6146363e57624b60b9dfdc0 Author: jenkins AuthorDate: Mon Apr 12 23:45:39 2021 + asf-site update Mon Apr 12 23:45:39 UTC 2021 --- sitemap.xml.gz| Bin 283 -> 283 bytes v0_9_0/sitemap.xml.gz | Bin 2216 -> 2216 bytes v1_0_0/sitemap.xml.gz | Bin 3238 -> 3238 bytes v1_1_0/sitemap.xml.gz | Bin 3464 -> 3464 bytes v1_2_0/sitemap.xml.gz | Bin 3487 -> 3487 bytes v1_3_0/sitemap.xml.gz | Bin 3483 -> 3483 bytes 6 files changed, 0 insertions(+), 0 deletions(-) diff --git a/sitemap.xml.gz b/sitemap.xml.gz index 16e9fb3..bbfe295 100644 Binary files a/sitemap.xml.gz and b/sitemap.xml.gz differ diff --git a/v0_9_0/sitemap.xml.gz b/v0_9_0/sitemap.xml.gz index 0a511ca..8316dbb 100644 Binary files a/v0_9_0/sitemap.xml.gz and b/v0_9_0/sitemap.xml.gz differ diff --git a/v1_0_0/sitemap.xml.gz b/v1_0_0/sitemap.xml.gz index e7931dd..63f5067 100644 Binary files a/v1_0_0/sitemap.xml.gz and b/v1_0_0/sitemap.xml.gz differ diff --git a/v1_1_0/sitemap.xml.gz b/v1_1_0/sitemap.xml.gz index dcb3ca4..31d92ca 100644 Binary files a/v1_1_0/sitemap.xml.gz and b/v1_1_0/sitemap.xml.gz differ diff --git a/v1_2_0/sitemap.xml.gz b/v1_2_0/sitemap.xml.gz index a8ec373..55d47f6 100644 Binary files a/v1_2_0/sitemap.xml.gz and b/v1_2_0/sitemap.xml.gz differ diff --git a/v1_3_0/sitemap.xml.gz b/v1_3_0/sitemap.xml.gz index 26934a0..6f85461 100644 Binary files a/v1_3_0/sitemap.xml.gz and b/v1_3_0/sitemap.xml.gz differ
[GitHub] [mynewt-core] vrahane opened a new pull request #2564: nRF5340: Add BUS Driver dep & instr/data cache
vrahane opened a new pull request #2564: URL: https://github.com/apache/mynewt-core/pull/2564 - Add syscfg for controlling instruction/data cache and add dependency for BUS driver -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] utzig commented on a change in pull request #960: Align logo, grammar updates
utzig commented on a change in pull request #960: URL: https://github.com/apache/mynewt-nimble/pull/960#discussion_r612004169 ## File path: README.md ## @@ -19,22 +19,26 @@ # --> + Review comment: I don't like very much the idea of changing the alignment of the logo, and also it won't be the same as for mynewt-core in this PR is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-core] branch master updated: mcu/nrf5340: Add trng to netcore. Use existing trng_nrf52 driver (#2563)
This is an automated email from the ASF dual-hosted git repository.
vipulrahane pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new d288b3b mcu/nrf5340: Add trng to netcore. Use existing trng_nrf52
driver (#2563)
d288b3b is described below
commit d288b3ba4de2739fe0938b666b84f1fbd584d43a
Author: Vikrant <76705748+vikrant-pr...@users.noreply.github.com>
AuthorDate: Mon Apr 12 14:50:01 2021 -0700
mcu/nrf5340: Add trng to netcore. Use existing trng_nrf52 driver (#2563)
- Add nrfx header to trng_nrf52.c
---
hw/drivers/trng/trng_nrf52/src/trng_nrf52.c| 1 +
hw/mcu/nordic/nrf5340_net/pkg.yml | 3 +++
hw/mcu/nordic/nrf5340_net/src/nrf5340_net_periph.c | 25 ++
3 files changed, 29 insertions(+)
diff --git a/hw/drivers/trng/trng_nrf52/src/trng_nrf52.c
b/hw/drivers/trng/trng_nrf52/src/trng_nrf52.c
index ed9594e..0369128 100644
--- a/hw/drivers/trng/trng_nrf52/src/trng_nrf52.c
+++ b/hw/drivers/trng/trng_nrf52/src/trng_nrf52.c
@@ -18,6 +18,7 @@
*/
#include
+#include "nrfx.h"
#include "mcu/cmsis_nvic.h"
#include "trng/trng.h"
#include "trng_nrf52/trng_nrf52.h"
diff --git a/hw/mcu/nordic/nrf5340_net/pkg.yml
b/hw/mcu/nordic/nrf5340_net/pkg.yml
index 0e62a03..f95e2e3 100644
--- a/hw/mcu/nordic/nrf5340_net/pkg.yml
+++ b/hw/mcu/nordic/nrf5340_net/pkg.yml
@@ -46,5 +46,8 @@ pkg.deps.SPI_0_MASTER:
pkg.deps.I2C_0':
- "@apache-mynewt-core/hw/bus/drivers/i2c_nrf5340"
+pkg.deps.TRNG:
+- "@apache-mynewt-core/hw/drivers/trng/trng_nrf52"
+
pkg.deps.BLE_CONTROLLER:
- "@apache-mynewt-nimble/nimble/drivers/nrf5340"
diff --git a/hw/mcu/nordic/nrf5340_net/src/nrf5340_net_periph.c
b/hw/mcu/nordic/nrf5340_net/src/nrf5340_net_periph.c
index fa38f36..15822e3 100644
--- a/hw/mcu/nordic/nrf5340_net/src/nrf5340_net_periph.c
+++ b/hw/mcu/nordic/nrf5340_net/src/nrf5340_net_periph.c
@@ -39,6 +39,11 @@
#include
#endif
+#if MYNEWT_VAL(TRNG)
+#include "trng/trng.h"
+#include "trng_nrf52/trng_nrf52.h"
+#endif
+
#if MYNEWT_VAL(UART_0)
static struct uart_dev os_bsp_uart0;
static const struct nrf5340_net_uart_cfg os_bsp_uart0_cfg = {
@@ -76,6 +81,10 @@ static const struct bus_i2c_dev_cfg i2c0_cfg = {
static struct bus_i2c_dev i2c0_bus;
#endif
+#if MYNEWT_VAL(TRNG)
+static struct trng_dev os_bsp_trng;
+#endif
+
static void
nrf5340_net_periph_create_timers(void)
{
@@ -153,6 +162,21 @@ nrf5340_net_periph_create_i2c(void)
#endif
}
+static void
+nrf5340_net_periph_create_trng(void)
+{
+int rc;
+
+(void)rc;
+
+#if MYNEWT_VAL(TRNG)
+rc = os_dev_create(&os_bsp_trng.dev, "trng",
+ OS_DEV_INIT_KERNEL, OS_DEV_INIT_PRIO_DEFAULT,
+ nrf52_trng_dev_init, NULL);
+assert(rc == 0);
+#endif
+}
+
void
nrf5340_net_periph_create(void)
{
@@ -160,4 +184,5 @@ nrf5340_net_periph_create(void)
nrf5340_net_periph_create_uart();
nrf5340_net_periph_create_spi();
nrf5340_net_periph_create_i2c();
+nrf5340_net_periph_create_trng();
}
[GitHub] [mynewt-core] vrahane merged pull request #2563: mcu/nrf5340: Add trng to netcore. Use existing trng_nrf52 driver
vrahane merged pull request #2563: URL: https://github.com/apache/mynewt-core/pull/2563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2563: mcu/nrf5340: Add trng to netcore. Use existing trng_nrf52 driver
apache-mynewt-bot commented on pull request #2563:
URL: https://github.com/apache/mynewt-core/pull/2563#issuecomment-818243116
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] kasjer commented on a change in pull request #2562: hw/ipc_nrf5340: Allow sending data in fragments
kasjer commented on a change in pull request #2562:
URL: https://github.com/apache/mynewt-core/pull/2562#discussion_r611901932
##
File path: hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c
##
@@ -212,17 +204,39 @@ ipc_nrf5340_recv(int channel, ipc_nrf5340_recv_cb cb,
void *user_data)
int
ipc_nrf5340_send(int channel, const void *data, uint16_t len)
{
-int rc = 0;
+struct ipc_shm *shm;
+uint16_t frag_len;
+uint16_t space;
assert(channel < IPC_MAX_CHANS);
+shm = &shms[channel];
if (data && len) {
-rc = ipc_nrf5340_shm_write(&shms[channel], data, len);
-}
+while (len) {
+do {
+space = IPC_BUF_SIZE - 1;
+space -= ipc_nrf5340_shm_get_data_length(shm->head, shm->tail);
+#if !MYNEWT_VAL(IPC_NRF5340_BLOCKING_WRITE)
+/* assert since that will always fail for non-blocking write
indicating
+ * use error
+ */
+assert(data_len <= IPC_BUF_SIZE);
Review comment:
there is no **data_len** in this scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] vikrant-proxy opened a new pull request #2563: mcu/nrf5340: Add trng to netcore. Use existing trng_nrf52 driver
vikrant-proxy opened a new pull request #2563: URL: https://github.com/apache/mynewt-core/pull/2563 - Add nrfx header to trng_nrf52.c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on a change in pull request #2562: hw/ipc_nrf5340: Allow sending data in fragments
vrahane commented on a change in pull request #2562:
URL: https://github.com/apache/mynewt-core/pull/2562#discussion_r611818635
##
File path: hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c
##
@@ -212,17 +204,39 @@ ipc_nrf5340_recv(int channel, ipc_nrf5340_recv_cb cb,
void *user_data)
int
ipc_nrf5340_send(int channel, const void *data, uint16_t len)
{
-int rc = 0;
+struct ipc_shm *shm;
+uint16_t frag_len;
+uint16_t space;
assert(channel < IPC_MAX_CHANS);
+shm = &shms[channel];
if (data && len) {
-rc = ipc_nrf5340_shm_write(&shms[channel], data, len);
-}
+while (len) {
+do {
+space = IPC_BUF_SIZE - 1;
+space -= ipc_nrf5340_shm_get_data_length(shm->head, shm->tail);
+#if !MYNEWT_VAL(IPC_NRF5340_BLOCKING_WRITE)
+/* assert since that will always fail for non-blocking write
indicating
+ * use error
+ */
+assert(data_len <= IPC_BUF_SIZE);
+if (data_len > space) {
+return -ENOMEM;
Review comment:
I think we should be using `SYS_ENOMEM` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2562: hw/ipc_nrf5340: Allow sending data in fragments
apache-mynewt-bot commented on pull request #2562:
URL: https://github.com/apache/mynewt-core/pull/2562#issuecomment-817956464
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #968: nimble/transport: Optimise nrf5340 transport
apache-mynewt-bot commented on pull request #968:
URL: https://github.com/apache/mynewt-nimble/pull/968#issuecomment-817951700
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] fredster33 commented on issue #961: Wiki is blank, but enabled
fredster33 commented on issue #961: URL: https://github.com/apache/mynewt-nimble/issues/961#issuecomment-817949116 All right, closing this as resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] fredster33 commented on pull request #960: Align logo, grammar updates
fredster33 commented on pull request #960: URL: https://github.com/apache/mynewt-nimble/pull/960#issuecomment-817948962 Hi, bumping this, any updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] fredster33 closed issue #961: Wiki is blank, but enabled
fredster33 closed issue #961: URL: https://github.com/apache/mynewt-nimble/issues/961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] sjanc opened a new pull request #2562: hw/ipc_nrf5340: Allow sending data in fragments
sjanc opened a new pull request #2562: URL: https://github.com/apache/mynewt-core/pull/2562 This allows to send data over IPC in fragments. Previously data size was limited to IPC buffer size. In extreme case IPC buffer can now have size of 2, although this may result in excessive number of interrupts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] sjanc opened a new pull request #968: nimble/transport: Optimise nrf5340 transport
sjanc opened a new pull request #968: URL: https://github.com/apache/mynewt-nimble/pull/968 This allows to use it regardless of IPC buffer size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-newt] branch master updated: docs: update Linux install instructions for 1.9.0
This is an automated email from the ASF dual-hosted git repository. utzig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git The following commit(s) were added to refs/heads/master by this push: new b9d54f0 docs: update Linux install instructions for 1.9.0 b9d54f0 is described below commit b9d54f0e5da10a8311937b3c6aef683340238411 Author: Fabio Utzig AuthorDate: Sun Apr 11 20:30:52 2021 -0300 docs: update Linux install instructions for 1.9.0 Signed-off-by: Fabio Utzig --- docs/install/newt_linux.rst | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/install/newt_linux.rst b/docs/install/newt_linux.rst index 917b428..cfb11de 100644 --- a/docs/install/newt_linux.rst +++ b/docs/install/newt_linux.rst @@ -1,7 +1,7 @@ Installing Newt on Linux -You can install the latest release (1.7.0) of the newt tool from a Debian binary package (amd64). You can also download +You can install the latest release (1.9.0) of the newt tool from a Debian binary package (amd64). You can also download and build the latest release version of newt from source. This page shows you how to: @@ -101,8 +101,8 @@ Download and install the package manually. .. code-block:: console -$ wget https://raw.githubusercontent.com/JuulLabs-OSS/binary-releases/master/mynewt-newt-tools_1.7.0/newt_1.7.0-1_amd64.deb -$ sudo dpkg -i newt_1.7.0-1_amd64.deb +$ wget https://raw.githubusercontent.com/JuulLabs-OSS/binary-releases/master/mynewt-newt-tools_1.9.0/newt_1.9.0-1_amd64.deb +$ sudo dpkg -i newt_1.9.0-1_amd64.deb See `Checking the Installed Version of Newt`_ to verify that you are using the installed version of newt. @@ -119,16 +119,16 @@ installed on your system. Please visit the Golang website for more information o .. code-block:: console -$ wget -P /tmp https://github.com/apache/mynewt-newt/archive/mynewt_1_8_0_tag.tar.gz -$ tar -xzf /tmp/mynewt_1_8_0_tag.tar.gz +$ wget -P /tmp https://github.com/apache/mynewt-newt/archive/mynewt_1_9_0_tag.tar.gz +$ tar -xzf /tmp/mynewt_1_9_0_tag.tar.gz #. Run the build.sh to build the newt tool. .. code-block:: console -$ cd mynewt-newt-mynewt_1_8_0_tag +$ cd mynewt-newt-mynewt_1_9_0_tag $ ./build.sh -$ rm /tmp/mynewt_1_8_0_tag.tar.gz +$ rm /tmp/mynewt_1_9_0_tag.tar.gz #. You should see the ``newt/newt`` executable. Move the executable to a bin directory in your PATH: @@ -155,7 +155,7 @@ Checking the Installed Version of Newt $ which newt /usr/bin/newt $ newt version -Apache Newt version: 1.8.0 +Apache Newt version: 1.9.0 2. Get information about newt:
[GitHub] [mynewt-newt] utzig merged pull request #434: docs: update Linux install instructions for 1.9.0
utzig merged pull request #434: URL: https://github.com/apache/mynewt-newt/pull/434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] utzig merged pull request #2542: kinetis/hal_gpio.c: Fix hal_gpio_init_out
utzig merged pull request #2542: URL: https://github.com/apache/mynewt-core/pull/2542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] utzig commented on pull request #2542: kinetis/hal_gpio.c: Fix hal_gpio_init_out
utzig commented on pull request #2542: URL: https://github.com/apache/mynewt-core/pull/2542#issuecomment-817898457 For some reason the CI also run on the branch (seems like a branch was pushed upstream). I just went forward and merged because I had to actually fix the same issue this morning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-core] branch master updated: kinetis/hal_gpio.c: Fix hal_gpio_init_out, to make it set the pin to given initial value.
This is an automated email from the ASF dual-hosted git repository.
utzig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new 361d21a kinetis/hal_gpio.c: Fix hal_gpio_init_out, to make it set the
pin to given initial value.
new 207b3bd Merge pull request #2542 from mlaz/kinetis_fixes
361d21a is described below
commit 361d21a9ed4abf29f3db6ab4c7bc8551d5a8a162
Author: Miguel Azevedo
AuthorDate: Mon Mar 22 15:22:47 2021 +
kinetis/hal_gpio.c: Fix hal_gpio_init_out, to make it set the pin to given
initial value.
---
hw/mcu/nxp/kinetis/src/hal_gpio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/mcu/nxp/kinetis/src/hal_gpio.c
b/hw/mcu/nxp/kinetis/src/hal_gpio.c
index e1d69e5..e328745 100644
--- a/hw/mcu/nxp/kinetis/src/hal_gpio.c
+++ b/hw/mcu/nxp/kinetis/src/hal_gpio.c
@@ -84,14 +84,13 @@ int
hal_gpio_init_out(int pin, int val)
{
gpio_pin_config_t gconfig;
-port_pin_config_t pconfig;
gconfig.pinDirection = kGPIO_DigitalOutput;
-pconfig.mux = kPORT_MuxAsGpio;
+gconfig.outputLogic = (uint8_t) val;
CLOCK_EnableClock(s_portClocks[GPIO_PORT(pin)]);
-PORT_SetPinConfig(s_portBases[GPIO_PORT(pin)], GPIO_INDEX(pin), &pconfig);
GPIO_PinInit(s_gpioBases[GPIO_PORT(pin)], GPIO_INDEX(pin), &gconfig);
+PORT_SetPinMux(s_portBases[GPIO_PORT(pin)], GPIO_INDEX(pin),
kPORT_MuxAsGpio);
return 0;
}
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2561: hw/mcu/cmac: Fix os_cputime wrap around handling
apache-mynewt-bot commented on pull request #2561:
URL: https://github.com/apache/mynewt-core/pull/2561#issuecomment-817863242
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
hw/mcu/dialog/cmac/src/cmac_timer.c
```diff
@@ -507,7 +507,8 @@
#endif
}
-void cmac_timer_wrap_llt(void)
+void
+cmac_timer_wrap_llt(void)
{
uint32_t new_ll_timer_36;
uint32_t new_ll_timer_09;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-core] andrzej-kaczmarek opened a new pull request #2561: hw/mcu/cmac: Fix os_cputime wrap around handling
andrzej-kaczmarek opened a new pull request #2561: URL: https://github.com/apache/mynewt-core/pull/2561 os_cputime uses LLT internally which is a 37-bit timer at 1MHz and thus it wraps around later than 32-bit os_cputime at 32768Hz. This mean safter os_cputime wraps back to 0 any comparison between LLT value converted from os_cputime and an actual LLT value will fail. This fixes the problem by wrapping LLT at the same time as os_cputime. LLT value at which os_cputime wraps back to 0 is 0x1e8480 so once LLT hits that value we also wrap it back to 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #967: npl/riot: rework to use RIOTs ztimer
apache-mynewt-bot commented on pull request #967:
URL: https://github.com/apache/mynewt-nimble/pull/967#issuecomment-817832209
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen opened a new pull request #967: npl/riot: rework to use RIOTs ztimer
haukepetersen opened a new pull request #967: URL: https://github.com/apache/mynewt-nimble/pull/967 ztimer is a new high-level timer API in RIOT that was introcuced a while ago to be the successor of xtimer. This commit reworks the RIOT NPL implementation to use ztimer instead of xtimer. This simplifies the NPL implementation and it allows for significant energy savings. For the xtimer switch the implemenation further switches from RIOTs `posix_semaphore` module to the slimmer `sema` module, as the prior indirectly pulls in xtimer as dependency. When running the `examples/nimble_gatt` application from RIOTs examples for the `nrf52dk` and compiling it without STDIO (so UART is not enabled), the average power consumption drops **from 430µA down to 72µA** while maintaining a BLE connection to a smartphone using the default connection interval :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on issue #961: Wiki is blank, but enabled
sjanc commented on issue #961: URL: https://github.com/apache/mynewt-nimble/issues/961#issuecomment-817688367 I've added link to wiki on apache.org -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-core] branch master updated: sys/console: Add TCP console
This is an automated email from the ASF dual-hosted git repository.
jerzy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new 5653927 sys/console: Add TCP console
5653927 is described below
commit 5653927da2c24546049d5e116af9125ebc90cda2
Author: Jerzy Kasenberg
AuthorDate: Wed Mar 31 19:48:37 2021 +0200
sys/console: Add TCP console
This adds TCP console implementation.
---
sys/console/full/pkg.yml | 2 +
sys/console/full/src/console.c | 3 +
sys/console/full/src/console_priv.h| 1 +
sys/console/full/syscfg.yml| 3 +
sys/console/full/{ => tcp_console}/pkg.yml | 25 +--
sys/console/full/tcp_console/src/tcp_console.c | 201 +
sys/console/full/tcp_console/syscfg.yml| 23 +++
7 files changed, 240 insertions(+), 18 deletions(-)
diff --git a/sys/console/full/pkg.yml b/sys/console/full/pkg.yml
index cda20d9..c0d44f3 100644
--- a/sys/console/full/pkg.yml
+++ b/sys/console/full/pkg.yml
@@ -34,6 +34,8 @@ pkg.deps.CONSOLE_SEMIHOSTING:
- "@apache-mynewt-core/hw/drivers/semihosting"
pkg.deps.CONSOLE_USB:
- "@apache-mynewt-core/hw/usb/tinyusb/cdc_console"
+pkg.deps.CONSOLE_TCP:
+- "@apache-mynewt-core/sys/console/full/tcp_console"
pkg.deps.'CONSOLE_HISTORY == "ram"':
- "@apache-mynewt-core/sys/console/full/history_ram"
pkg.deps.'CONSOLE_HISTORY == "log"':
diff --git a/sys/console/full/src/console.c b/sys/console/full/src/console.c
index b271c08..346941c 100644
--- a/sys/console/full/src/console.c
+++ b/sys/console/full/src/console.c
@@ -1251,6 +1251,9 @@ console_is_init(void)
#if MYNEWT_VAL(CONSOLE_USB)
return usb_cdc_console_is_init();
#endif
+#if MYNEWT_VAL(CONSOLE_TCP)
+return tcp_console_is_init();
+#endif
return 0;
}
diff --git a/sys/console/full/src/console_priv.h
b/sys/console/full/src/console_priv.h
index abcef5f..cf6be3a 100644
--- a/sys/console/full/src/console_priv.h
+++ b/sys/console/full/src/console_priv.h
@@ -34,6 +34,7 @@ int rtt_console_init(void);
int semihosting_console_is_init(void);
int ble_monitor_console_is_init(void);
int usb_cdc_console_is_init(void);
+int tcp_console_is_init(void);
#ifdef __cplusplus
}
diff --git a/sys/console/full/syscfg.yml b/sys/console/full/syscfg.yml
index ee81710..756d5cc 100644
--- a/sys/console/full/syscfg.yml
+++ b/sys/console/full/syscfg.yml
@@ -29,6 +29,9 @@ syscfg.defs:
CONSOLE_USB:
description: 'Set console to USB'
value: 0
+CONSOLE_TCP:
+description: 'Set console to TCP socket'
+value: 0
CONSOLE_BLE_MONITOR:
description: 'Set console output to BLE Monitor'
value: 0
diff --git a/sys/console/full/pkg.yml b/sys/console/full/tcp_console/pkg.yml
similarity index 57%
copy from sys/console/full/pkg.yml
copy to sys/console/full/tcp_console/pkg.yml
index cda20d9..60fc9c7 100644
--- a/sys/console/full/pkg.yml
+++ b/sys/console/full/tcp_console/pkg.yml
@@ -6,7 +6,7 @@
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
-#
+#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
@@ -17,28 +17,17 @@
# under the License.
#
-pkg.name: sys/console/full
-pkg.description: Text-based IO interface.
+pkg.name: sys/console/full/tcp_console
+pkg.description: Console over TCP LWIP socket.
pkg.author: "Apache Mynewt "
pkg.homepage: "http://mynewt.apache.org/";
pkg.keywords:
pkg.deps:
-- "@apache-mynewt-core/hw/hal"
-- "@apache-mynewt-core/kernel/os"
-pkg.deps.CONSOLE_UART:
-- "@apache-mynewt-core/hw/drivers/uart"
-pkg.deps.CONSOLE_RTT:
-- "@apache-mynewt-core/hw/drivers/rtt"
-pkg.deps.CONSOLE_SEMIHOSTING:
-- "@apache-mynewt-core/hw/drivers/semihosting"
-pkg.deps.CONSOLE_USB:
-- "@apache-mynewt-core/hw/usb/tinyusb/cdc_console"
-pkg.deps.'CONSOLE_HISTORY == "ram"':
-- "@apache-mynewt-core/sys/console/full/history_ram"
-pkg.deps.'CONSOLE_HISTORY == "log"':
-- "@apache-mynewt-core/sys/console/full/history_log"
+- "@apache-mynewt-core/sys/console/full"
+- "@apache-mynewt-core/net/ip/mn_socket"
+
pkg.apis: console
pkg.init:
-console_pkg_init: 'MYNEWT_VAL(CONSOLE_SYSINIT_STAGE)'
+tcp_console_pkg_init: 'MYNEWT_VAL(IP_SYSINIT_STAGE)'
diff --git a/sys/console/full/tcp_console/src/tcp_console.c
b/sys/console/full/tcp_console/src/tcp_console.c
new file mode 100644
index 000..f2b4fad
--- /dev/null
+++ b/sys/console/full/tcp_console/src/tcp_console.c
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownershi
[GitHub] [mynewt-core] kasjer merged pull request #2551: sys/console: Add TCP console
kasjer merged pull request #2551: URL: https://github.com/apache/mynewt-core/pull/2551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] kasjer merged pull request #2557: mcu/nrf5340: Fix flash erase
kasjer merged pull request #2557: URL: https://github.com/apache/mynewt-core/pull/2557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-core] branch master updated: mcu/nrf5340: Fix flash erase
This is an automated email from the ASF dual-hosted git repository.
jerzy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new 4c5550d mcu/nrf5340: Fix flash erase
4c5550d is described below
commit 4c5550dbac6da3058ea65530f9ae3f2c08616f4b
Author: Jerzy Kasenberg
AuthorDate: Fri Apr 9 11:05:38 2021 +0200
mcu/nrf5340: Fix flash erase
Flash erase was settings wrong value to CONFIG register so
erase procedure never started on both cores.
Now nrf5340_[net_]flash_erase_sector() is not sharing code with
write any more.
Additionally nrf5340_[net_]flash_erase() was added to that can
speed up erase a little bit.
---
hw/mcu/nordic/nrf5340/src/hal_flash.c | 51 +--
hw/mcu/nordic/nrf5340_net/src/hal_flash.c | 51 +--
2 files changed, 96 insertions(+), 6 deletions(-)
diff --git a/hw/mcu/nordic/nrf5340/src/hal_flash.c
b/hw/mcu/nordic/nrf5340/src/hal_flash.c
index cb25451..659dda1 100644
--- a/hw/mcu/nordic/nrf5340/src/hal_flash.c
+++ b/hw/mcu/nordic/nrf5340/src/hal_flash.c
@@ -121,9 +121,53 @@ out:
static int
nrf5340_flash_erase_sector(const struct hal_flash *dev, uint32_t
sector_address)
{
-uint32_t val = 0x;
+int sr;
+int rc;
+
+sector_address &= ~(NRF5340_FLASH_SECTOR_SZ - 1);
+
+if (nrf5340_flash_wait_ready()) {
+return -1;
+}
+__HAL_DISABLE_INTERRUPTS(sr);
-return nrf5340_flash_write(dev, sector_address, &val, sizeof(val));
+NRF_NVMC_S->CONFIG = NVMC_CONFIG_WEN_Een; /* Enable erase OP */
+*(uint32_t *)sector_address = 0x;
+
+rc = nrf5340_flash_wait_ready();
+
+NRF_NVMC_S->CONFIG = NVMC_CONFIG_WEN_Ren;
+__HAL_ENABLE_INTERRUPTS(sr);
+
+return rc;
+}
+
+static int
+nrf5340_flash_erase(const struct hal_flash *dev, uint32_t address,
+uint32_t num_bytes)
+{
+uint32_t sector_address;
+
+if (address + num_bytes < dev->hf_base_addr ||
+address > dev->hf_base_addr + dev->hf_size) {
+return -1;
+}
+
+sector_address = address & ~(NRF5340_FLASH_SECTOR_SZ - 1);
+num_bytes += address - sector_address;
+num_bytes = (num_bytes + NRF5340_FLASH_SECTOR_SZ - 1) &
~(NRF5340_FLASH_SECTOR_SZ - 1);
+if (sector_address < dev->hf_base_addr) {
+num_bytes -= dev->hf_base_addr - sector_address;
+sector_address = dev->hf_base_addr;
+}
+
+while (num_bytes > 0 && sector_address < dev->hf_base_addr + dev->hf_size)
{
+nrf5340_flash_erase_sector(dev, sector_address);
+num_bytes -= NRF5340_FLASH_SECTOR_SZ;
+sector_address += NRF5340_FLASH_SECTOR_SZ;
+}
+
+return 0;
}
static int
@@ -147,7 +191,8 @@ static const struct hal_flash_funcs nrf5340_flash_funcs = {
.hff_write = nrf5340_flash_write,
.hff_erase_sector = nrf5340_flash_erase_sector,
.hff_sector_info = nrf5340_flash_sector_info,
-.hff_init = nrf5340_flash_init
+.hff_init = nrf5340_flash_init,
+.hff_erase = nrf5340_flash_erase,
};
const struct hal_flash nrf5340_flash_dev = {
diff --git a/hw/mcu/nordic/nrf5340_net/src/hal_flash.c
b/hw/mcu/nordic/nrf5340_net/src/hal_flash.c
index ccc771c..dfbe38b 100644
--- a/hw/mcu/nordic/nrf5340_net/src/hal_flash.c
+++ b/hw/mcu/nordic/nrf5340_net/src/hal_flash.c
@@ -121,9 +121,53 @@ out:
static int
nrf5340_net_flash_erase_sector(const struct hal_flash *dev, uint32_t
sector_address)
{
-uint32_t val = 0x;
+int sr;
+int rc;
+
+sector_address &= ~(NRF5340_NET_FLASH_SECTOR_SZ - 1);
+
+if (nrf5340_net_flash_wait_ready()) {
+return -1;
+}
+__HAL_DISABLE_INTERRUPTS(sr);
-return nrf5340_net_flash_write(dev, sector_address, &val, sizeof(val));
+NRF_NVMC_NS->CONFIG = NVMC_CONFIG_WEN_Een; /* Enable erase OP */
+*(uint32_t *)sector_address = 0x;
+
+rc = nrf5340_net_flash_wait_ready();
+
+NRF_NVMC_NS->CONFIG = NVMC_CONFIG_WEN_Ren;
+__HAL_ENABLE_INTERRUPTS(sr);
+
+return rc;
+}
+
+static int
+nrf5340_net_flash_erase(const struct hal_flash *dev, uint32_t address,
+uint32_t num_bytes)
+{
+uint32_t sector_address;
+
+if (address + num_bytes < dev->hf_base_addr ||
+address > dev->hf_base_addr + dev->hf_size) {
+return -1;
+}
+
+sector_address = address & ~(NRF5340_NET_FLASH_SECTOR_SZ - 1);
+num_bytes += address - sector_address;
+num_bytes = (num_bytes + NRF5340_NET_FLASH_SECTOR_SZ - 1) &
~(NRF5340_NET_FLASH_SECTOR_SZ - 1);
+if (sector_address < dev->hf_base_addr) {
+num_bytes -= dev->hf_base_addr - sector_address;
+sector_address = dev->hf_base_addr;
+}
+
+while (num_bytes > 0 && sector_address < dev->hf_base_addr + dev->hf_size)
{
+nrf5340_net_flash_erase_sector(dev, sector_address);
+num_bytes -= NRF5340_NET_FLASH_SEC
[GitHub] [mynewt-nimble] sjanc merged pull request #966: porting: Fix mempool initialization
sjanc merged pull request #966: URL: https://github.com/apache/mynewt-nimble/pull/966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[mynewt-nimble] branch master updated (250cd70 -> dd7ebf1)
This is an automated email from the ASF dual-hosted git repository. janc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git. from 250cd70 Apache NimBLE 1.4.0 release add dd7ebf1 porting: Fix mempool initialization No new revisions were added by this update. Summary of changes: porting/examples/linux/main.c | 2 +- porting/examples/linux_blemesh/main.c | 2 +- porting/examples/nuttx/main.c | 5 +++-- porting/nimble/src/nimble_port.c | 2 ++ 4 files changed, 7 insertions(+), 4 deletions(-)
