[GitHub] [mynewt-nimble] novumdun opened a new issue, #1294: Func "nimble_port_init" has a err.
novumdun opened a new issue, #1294:
URL: https://github.com/apache/mynewt-nimble/issues/1294
```c
void
nimble_port_init(void)
{
/* Initialize default event queue */
ble_npl_eventq_init(_eventq_dflt);
/* Initialize the global memory pool */
os_mempool_module_init();
os_msys_init();
/* Initialize transport */
ble_transport_init();
/* Initialize the host */
ble_transport_hs_init();
#if NIMBLE_CFG_CONTROLLER
#ifndef RIOT_VERSION
hal_timer_init(5, NULL);
os_cputime_init(32768);
#endif
ble_transport_ll_init();
#endif
}
```
In "ble_transport_ll_init", "ble_transport_hs_init" should swap places with
"ble_transport_ll_init".
"NIMBLE_CFG_CONTROLLER" could be placed by MYNEWT_VAL(BLE_CONTROLLER), and
add MYNEWT_VAL(BLE_HOST). ==>
```c
void
nimble_port_init(void)
{
/* Initialize default event queue */
ble_npl_eventq_init(_eventq_dflt);
/* Initialize the global memory pool */
os_mempool_module_init();
os_msys_init();
/* Initialize transport */
ble_transport_init();
/* Initialize the host */
#if MYNEWT_VAL(BLE_HOST)
ble_transport_ll_init();
#endif
#if MYNEWT_VAL(BLE_CONTROLLER)
#ifndef RIOT_VERSION
hal_timer_init(5, NULL);
os_cputime_init(32768);
#endif
ble_transport_hs_init();
#endif
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU
apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1176104776
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU
apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1176098876
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/host/src/ble_l2cap_coc.c
```diff
@@ -231,7 +231,7 @@
BLE_HS_LOG(DEBUG, "sdu_len=%d, received LE frame=%d, credits=%d\n",
sdu_len, om_total, rx->credits);
-os_mbuf_adj(*om , BLE_L2CAP_SDU_SIZE);
+os_mbuf_adj(*om, BLE_L2CAP_SDU_SIZE);
rc = os_mbuf_appendfrom(rx_sdu, *om, 0, om_total -
BLE_L2CAP_SDU_SIZE);
if (rc != 0) {
@@ -257,7 +257,7 @@
ble_l2cap_disconnect(chan);
return BLE_HS_EBADDATA;
}
-rc = os_mbuf_appendfrom(rx_sdu, *om, 0, om_total);
+rc = os_mbuf_appendfrom(rx_sdu, *om, 0, om_total);
if (rc != 0) {
/* FIXME: need to handle it better */
BLE_HS_LOG(DEBUG, "Could not append data rc=%d\n", rc);
@@ -337,7 +337,7 @@
chan->rx_fn = ble_l2cap_coc_rx_fn;
chan->coc_rx.mtu = mtu;
chan->coc_rx.sdus[0] = sdu_rx;
-for(int i = 1; i < BLE_L2CAP_SDU_BUFF_CNT; i++) {
+for (int i = 1; i < BLE_L2CAP_SDU_BUFF_CNT; i++) {
chan->coc_rx.sdus[i] = NULL;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-newtmgr] niclas-ats commented on pull request #191: nmp decode: allow registration of custom response handlers
niclas-ats commented on PR #191: URL: https://github.com/apache/mynewt-newtmgr/pull/191#issuecomment-1175880195 @all I'd like to get some feedback on this PR. Do I need to create an issue first and reference the pull request or did I miss to mention the maintainer? Thx in advance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
