[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-29 Thread GitBox 


apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1199173904

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1309: nimble/ll: Fix privacy handling when connecting to a new device

2022-07-29 Thread GitBox 


apache-mynewt-bot commented on PR #1309:
URL: https://github.com/apache/mynewt-nimble/pull/1309#issuecomment-1199143777

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/controller/src/ble_ll_scan.c
   
   
   ```diff
   @@ -1285,7 +1284,7 @@
break;
}

   -/* fall-through */
   +/* fall-through */
case BLE_LL_ADDR_SUBTYPE_IDENTITY:
/* If AdvA is an identity address, we need to check if that device 
was
 * added to RL in order to use proper privacy mode.
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1309: nimble/ll: Fix privacy handling when connecting to a new device

2022-07-29 Thread GitBox 


andrzej-kaczmarek opened a new pull request, #1309:
URL: https://github.com/apache/mynewt-nimble/pull/1309

   Using LL Privacy to initiate a connection to a new device (i.e. use 0x02
   or 0x03 as own address type, peer is using an RPA) requires host to add
   peer RPA and our IRK to resolving list. In this case we should allow to
   match that RPA as an identity address on resolving list so we can use
   proper privacy settings.
   
   Note that this is a bit of an unspecified behavior, i.e. HCI LE Add
   Device To Resolving List command parameters indicates that only identity
   addresses shall be added to resolving list, but this does not seem to be
   specified anywhere and there is no handling for non-identity address
   specified. So basically we allow RPA-as-an-identity to be added to
   resolving list, then if AdvA RPA does not match resolving list we just
   fall through to see if corresponding entry in resolving list exists and
   use it as identity address.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org