Re: [PR] nimble/host:Handled error return value BLE_ERR_UNK_CONN_ID when encryption is enabled without distributing IRK. [mynewt-nimble]
abhi152 commented on code in PR #1620: URL: https://github.com/apache/mynewt-nimble/pull/1620#discussion_r1363844340 ## nimble/host/src/ble_gap.c: ## @@ -6062,6 +6063,9 @@ ble_gap_unpair(const ble_addr_t *peer_addr) ble_hs_pvcy_remove_entry(peer_addr->type, Review Comment: Thanks for your suggestion. So I have made further changes including above mentioned in this API and will update this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] nimble/host:Handled error return value BLE_ERR_UNK_CONN_ID when encryption is enabled without distributing IRK. [mynewt-nimble]
sjanc commented on code in PR #1620: URL: https://github.com/apache/mynewt-nimble/pull/1620#discussion_r1363830318 ## nimble/host/src/ble_gap.c: ## @@ -6062,6 +6063,9 @@ ble_gap_unpair(const ble_addr_t *peer_addr) ble_hs_pvcy_remove_entry(peer_addr->type, Review Comment: looks like return value from ble_hs_pvcy_remove_entry() is never stored in rc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added periodic adv feature updates in ble 5.3 [mynewt-nimble]
RoshanESP commented on code in PR #1537: URL: https://github.com/apache/mynewt-nimble/pull/1537#discussion_r1363642484 ## nimble/host/src/ble_gap.c: ## @@ -3817,7 +3846,9 @@ ble_gap_periodic_adv_set_data_validate(uint8_t instance, } int -ble_gap_periodic_adv_set_data(uint8_t instance, struct os_mbuf *data) +ble_gap_periodic_adv_set_data(uint8_t instance, + struct os_mbuf *data, + struct ble_gap_periodic_adv_set_data_params *params) Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added periodic adv feature updates in ble 5.3 [mynewt-nimble]
RoshanESP commented on code in PR #1537: URL: https://github.com/apache/mynewt-nimble/pull/1537#discussion_r1363638673 ## nimble/host/include/host/ble_gap.h: ## @@ -1767,10 +1802,14 @@ int ble_gap_periodic_adv_stop(uint8_t instance); * * @param instanceInstance ID * @param dataChain containing the periodic advertising data. + * @param params Additional arguments specifying the particulars + of periodic advertising data. * * @return 0 on success or error code on failure. */ -int ble_gap_periodic_adv_set_data(uint8_t instance, struct os_mbuf *data); +int ble_gap_periodic_adv_set_data(uint8_t instance, + struct os_mbuf *data, + struct ble_gap_periodic_adv_set_data_params *params); Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Image upload does not work over UDP - Zephyr smp_svr sample [mynewt-mcumgr-cli]
L1amaGod commented on issue #29: URL: https://github.com/apache/mynewt-mcumgr-cli/issues/29#issuecomment-1767860028 Could I ask which method do you use to connect to the IP 192.168.1.71? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
