(mynewt-core) branch master updated: compiler/riscv64: Rename to make it more explicit
This is an automated email from the ASF dual-hosted git repository.
jerzy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new c68ddf0d4 compiler/riscv64: Rename to make it more explicit
c68ddf0d4 is described below
commit c68ddf0d4a8def8044aed2dfbcbe80c7e8294b24
Author: Jerzy Kasenberg
AuthorDate: Fri Mar 8 15:05:26 2024 +0100
compiler/riscv64: Rename to make it more explicit
Compiler name was to generic and could lead to misunderstanding
of which compiler to use.
Current setting -march=rv32imac selects works with SiFive provided
compiler only.
To use this with more strict version one should use
-march=rv32imaczicsr in comman line to enable support to enable
required extension that SiFive compiler implies.
---
compiler/{riscv64 => riscv64-unknown-elf-sifive}/compiler.yml | 0
compiler/{riscv64 => riscv64-unknown-elf-sifive}/pkg.yml | 2 +-
hw/bsp/hifive1/bsp.yml| 2 +-
3 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/compiler/riscv64/compiler.yml
b/compiler/riscv64-unknown-elf-sifive/compiler.yml
similarity index 100%
rename from compiler/riscv64/compiler.yml
rename to compiler/riscv64-unknown-elf-sifive/compiler.yml
diff --git a/compiler/riscv64/pkg.yml
b/compiler/riscv64-unknown-elf-sifive/pkg.yml
similarity index 95%
rename from compiler/riscv64/pkg.yml
rename to compiler/riscv64-unknown-elf-sifive/pkg.yml
index f4481b9c3..9d01e24c4 100644
--- a/compiler/riscv64/pkg.yml
+++ b/compiler/riscv64-unknown-elf-sifive/pkg.yml
@@ -17,7 +17,7 @@
# under the License.
#
-pkg.name: compiler/riscv64
+pkg.name: compiler/riscv64-unknown-elf-sifive
pkg.type: compiler
pkg.description: Compiler definition for riscv64 gcc compiler.
pkg.author: "Apache Mynewt "
diff --git a/hw/bsp/hifive1/bsp.yml b/hw/bsp/hifive1/bsp.yml
index 855076762..46b480594 100644
--- a/hw/bsp/hifive1/bsp.yml
+++ b/hw/bsp/hifive1/bsp.yml
@@ -21,7 +21,7 @@ bsp.name: "HiFive1"
bsp.url: https://www.sifive.com/boards/hifive1
bsp.maker: "SiFive"
bsp.arch: rv32imac
-bsp.compiler: compiler/riscv64
+bsp.compiler: compiler/riscv64-unknown-elf-sifive
bsp.linkerscript:
- "hw/bsp/hifive1/hifive1_app.ld"
- "hw/bsp/hifive1/hifive1.ld"
Re: [PR] compiler/riscv64: Rename to make it more explicit [mynewt-core]
kasjer merged PR #3162: URL: https://github.com/apache/mynewt-core/pull/3162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] compiler/riscv64: Rename to make it more explicit [mynewt-core]
kasjer opened a new pull request, #3162: URL: https://github.com/apache/mynewt-core/pull/3162 Compiler name was to generic and could lead to misunderstanding of which compiler to use. Current setting -march=rv32imac selects works with SiFive provided compiler only. To use this with more strict version one should use -march=rv32imaczicsr in comman line to enable support to enable required extension that SiFive compiler implies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] mcu/fe310: Update to stock compiler [mynewt-core]
kasjer closed pull request #3160: mcu/fe310: Update to stock compiler URL: https://github.com/apache/mynewt-core/pull/3160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] apps: blestress: Perform all tests [mynewt-nimble]
piotrnarajowski opened a new pull request, #1725: URL: https://github.com/apache/mynewt-nimble/pull/1725 Edit for loop to run all tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] apps: blestress: Perform all tests [mynewt-nimble]
piotrnarajowski commented on PR #1725: URL: https://github.com/apache/mynewt-nimble/pull/1725#issuecomment-1985759689 @KKopyscinski please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] nimble/host: Zero initialize buffer after allocation [mynewt-nimble]
rahult-github commented on PR #1687: URL: https://github.com/apache/mynewt-nimble/pull/1687#issuecomment-1985516657 > Hi, > > Does this fix any use of uninitialized memory or is just a precaution? > > As for style, please use sizeof(*foo) syntax Currently , just precaution, since i didn't find any issue as such during my testing. But in many places in nimble, such memset is already existing, hence added at places where it is missing. For style, sure, will change and re-push -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(mynewt-core) branch master updated: hw/bsp: Default to nrfjprog downloader for supported Nordic boards
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new df5e8c28e hw/bsp: Default to nrfjprog downloader for supported Nordic boards df5e8c28e is described below commit df5e8c28e291562333ed16bc3c084a36a7355a36 Author: Szymon Janc AuthorDate: Thu Mar 7 08:53:38 2024 +0100 hw/bsp: Default to nrfjprog downloader for supported Nordic boards nrfjprog is recommended tool by Nordic and is causing less issues. --- hw/bsp/nordic_pca10040/syscfg.yml | 2 +- hw/bsp/nordic_pca10095/syscfg.yml | 2 +- hw/bsp/nordic_pca10095_net/syscfg.yml | 2 +- hw/bsp/nordic_thingy53/syscfg.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/bsp/nordic_pca10040/syscfg.yml b/hw/bsp/nordic_pca10040/syscfg.yml index 9bf07fb6a..0d1384dd7 100644 --- a/hw/bsp/nordic_pca10040/syscfg.yml +++ b/hw/bsp/nordic_pca10040/syscfg.yml @@ -62,7 +62,7 @@ syscfg.vals: BOOT_SERIAL_DETECT_PIN: 13 # Button 1 # Flasher parameters -MYNEWT_DOWNLOADER: jlink +MYNEWT_DOWNLOADER: nrfjprog MYNEWT_DOWNLOADER_MFG_IMAGE_FLASH_OFFSET: 0x0 PYOCD_TARGET: nrf52 JLINK_TARGET: nRF52832_xxAA diff --git a/hw/bsp/nordic_pca10095/syscfg.yml b/hw/bsp/nordic_pca10095/syscfg.yml index 5d49afb2b..33292f7e8 100644 --- a/hw/bsp/nordic_pca10095/syscfg.yml +++ b/hw/bsp/nordic_pca10095/syscfg.yml @@ -92,7 +92,7 @@ syscfg.vals: FLASH_MAP_SYSINIT_STAGE: 15 # Flasher parameters -MYNEWT_DOWNLOADER: jlink +MYNEWT_DOWNLOADER: nrfjprog JLINK_TARGET: NRF5340_XXAA_APP MYNEWT_DOWNLOADER_MFG_IMAGE_FLASH_OFFSET: 0x0 diff --git a/hw/bsp/nordic_pca10095_net/syscfg.yml b/hw/bsp/nordic_pca10095_net/syscfg.yml index f8cf6537d..915b502cf 100644 --- a/hw/bsp/nordic_pca10095_net/syscfg.yml +++ b/hw/bsp/nordic_pca10095_net/syscfg.yml @@ -31,7 +31,7 @@ syscfg.defs: value: 0 syscfg.vals: -MYNEWT_DOWNLOADER: jlink +MYNEWT_DOWNLOADER: nrfjprog JLINK_TARGET: NRF5340_XXAA_NET NRFJPROG_COPROCESSOR: CP_NETWORK # Set default pins for peripherals diff --git a/hw/bsp/nordic_thingy53/syscfg.yml b/hw/bsp/nordic_thingy53/syscfg.yml index 45c023fd7..c4b6ad4e9 100644 --- a/hw/bsp/nordic_thingy53/syscfg.yml +++ b/hw/bsp/nordic_thingy53/syscfg.yml @@ -80,7 +80,7 @@ syscfg.vals: FLASH_MAP_SYSINIT_STAGE: 15 # Flasher parameters -MYNEWT_DOWNLOADER: jlink +MYNEWT_DOWNLOADER: nrfjprog JLINK_TARGET: NRF5340_XXAA_APP MYNEWT_DOWNLOADER_MFG_IMAGE_FLASH_OFFSET: 0x0
Re: [PR] hw/bsp: Default to nrfjprog downloader for supported Nordic boards [mynewt-core]
sjanc merged PR #3159: URL: https://github.com/apache/mynewt-core/pull/3159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] nimble/host: Zero initialize buffer after allocation [mynewt-nimble]
sjanc commented on PR #1687: URL: https://github.com/apache/mynewt-nimble/pull/1687#issuecomment-1985497307 Hi, Does this fix any use of uninitialized memory or is just a precaution? As for style, please use sizeof(*foo) syntax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(mynewt-core) branch master updated: mcu/nrf51: Fix low frequency clock selection
This is an automated email from the ASF dual-hosted git repository.
jerzy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new fbff3aaba mcu/nrf51: Fix low frequency clock selection
fbff3aaba is described below
commit fbff3aaba5eaf80c76354e8aa363b9667ac488ac
Author: Jerzy Kasenberg
AuthorDate: Fri Mar 8 10:27:31 2024 +0100
mcu/nrf51: Fix low frequency clock selection
When XTAL_32768/XTAL_RC/XTAL_32768_SYNTH were deprecated
and MCU_LFCLK_SOURCE was chosen to be used instead, code
that actually enabled clocks still depended on syscfg values
that were never set.
This only changes preprocessor conditions to use MCU_LFCLK_SEOURCE.
---
hw/mcu/nordic/nrf51xxx/src/hal_system.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/hw/mcu/nordic/nrf51xxx/src/hal_system.c
b/hw/mcu/nordic/nrf51xxx/src/hal_system.c
index a4aa34c46..03e2eb489 100644
--- a/hw/mcu/nordic/nrf51xxx/src/hal_system.c
+++ b/hw/mcu/nordic/nrf51xxx/src/hal_system.c
@@ -69,8 +69,7 @@ hal_debugger_connected(void)
void
hal_system_clock_start(void)
{
-#if MYNEWT_VAL(XTAL_32768) || MYNEWT_VAL(XTAL_RC) || \
- MYNEWT_VAL(XTAL_32768_SYNTH)
+#if MYNEWT_VAL(MCU_LFCLK_SOURCE)
uint32_t regmsk;
uint32_t regval;
uint32_t clksrc;
@@ -78,23 +77,20 @@ hal_system_clock_start(void)
regmsk = CLOCK_LFCLKSTAT_STATE_Msk | CLOCK_LFCLKSTAT_SRC_Msk;
regval = CLOCK_LFCLKSTAT_STATE_Running << CLOCK_LFCLKSTAT_STATE_Pos;
-#if MYNEWT_VAL(XTAL_32768)
+#if MYNEWT_VAL_CHOICE(MCU_LFCLK_SOURCE, LFXO)
regval |= CLOCK_LFCLKSTAT_SRC_Xtal << CLOCK_LFCLKSTAT_SRC_Pos;
clksrc = CLOCK_LFCLKSRC_SRC_Xtal;
-#endif
-
-#if MYNEWT_VAL(XTAL_32768_SYNTH)
+#elif MYNEWT_VAL_CHOICE(MCU_LFCLK_SOURCE, LFSYNTH)
regval |= CLOCK_LFCLKSTAT_SRC_Synth << CLOCK_LFCLKSTAT_SRC_Pos;
clksrc = CLOCK_LFCLKSRC_SRC_Synth;
-#endif
-
- #if MYNEWT_VAL(XTAL_RC)
+#elif MYNEWT_VAL_CHOICE(MCU_LFCLK_SOURCE, LFRC)
regval |= CLOCK_LFCLKSTAT_SRC_RC << CLOCK_LFCLKSTAT_SRC_Pos;
clksrc = CLOCK_LFCLKSRC_SRC_RC;
+#else
+#error Unknown LFCLK source selected
#endif
-
-#if MYNEWT_VAL(XTAL_32768_SYNTH)
+#if MYNEWT_VAL_CHOICE(MCU_LFCLK_SOURCE, LFSYNTH)
/* Must turn on HFLCK for synthesized 32768 crystal */
if ((NRF_CLOCK->HFCLKSTAT & CLOCK_HFCLKSTAT_STATE_Msk) !=
(CLOCK_HFCLKSTAT_STATE_Running << CLOCK_HFCLKSTAT_STATE_Pos)) {
Re: [PR] mcu/nrf51: Fix low frequency clock selection [mynewt-core]
kasjer merged PR #3161: URL: https://github.com/apache/mynewt-core/pull/3161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] mcu/nrf51: Fix low frequency clock selection [mynewt-core]
kasjer opened a new pull request, #3161: URL: https://github.com/apache/mynewt-core/pull/3161 When XTAL_32768/XTAL_RC/XTAL_32768_SYNTH were deprecated and MCU_LFCLK_SOURCE was chosen to be used instead, code that actually enabled clocks still depended on syscfg values that were never set. This only changes preprocessor conditions to use MCU_LFCLK_SEOURCE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
