[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2203: Adding bsp/stm32f411discovery

2020-02-24 Thread GitBox 
apache-mynewt-bot commented on issue #2203: Adding  bsp/stm32f411discovery 
URL: https://github.com/apache/mynewt-core/pull/2203#issuecomment-590486161
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/bsp/stm32f411discovery/include/bsp/stm32f4xx_hal_conf.h
   
   
   ```diff
   @@ -1,39 +1,39 @@
/**
   -  
**
   -  * @filestm32f4xx_hal_conf.h
   -  * @author  MCD Application Team
   -  * @version V1.2.4
   -  * @date06-May-2016
   -  * @brief   HAL configuration file
   -  
**
   -  * @attention
   -  *
   -  * © COPYRIGHT(c) 2016 STMicroelectronics
   -  *
   -  * Redistribution and use in source and binary forms, with or without 
modification,
   -  * are permitted provided that the following conditions are met:
   -  *   1. Redistributions of source code must retain the above copyright 
notice,
   -  *  this list of conditions and the following disclaimer.
   -  *   2. Redistributions in binary form must reproduce the above copyright 
notice,
   -  *  this list of conditions and the following disclaimer in the 
documentation
   -  *  and/or other materials provided with the distribution.
   -  *   3. Neither the name of STMicroelectronics nor the names of its 
contributors
   -  *  may be used to endorse or promote products derived from this 
software
   -  *  without specific prior written permission.
   -  *
   -  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
IS"
   -  * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
THE
   -  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE ARE
   -  * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
LIABLE
   -  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 
CONSEQUENTIAL
   -  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS 
OR
   -  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) 
HOWEVER
   -  * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 
LIABILITY,
   -  * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF 
THE USE
   -  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   -  *
   -  
**
   -  */
   + 
**
   + * @filestm32f4xx_hal_conf.h
   + * @author  MCD Application Team
   + * @version V1.2.4
   + * @date06-May-2016
   + * @brief   HAL configuration file
   + 
**
   + * @attention
   + *
   + * © COPYRIGHT(c) 2016 STMicroelectronics
   + *
   + * Redistribution and use in source and binary forms, with or without 
modification,
   + * are permitted provided that the following conditions are met:
   + *   1. Redistributions of source code must retain the above copyright 
notice,
   + *  this list of conditions and the following disclaimer.
   + *   2. Redistributions in binary form must reproduce the above copyright 
notice,
   + *  this list of conditions and the following disclaimer in the 
documentation
   + *  and/or other materials provided with the distribution.
   + *   3. Neither the name of STMicroelectronics nor the names of its 
contributors
   + *  may be used to endorse or promote products derived from this 
software
   + *  without specific prior written permission.
   + *
   + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
IS"
   + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
   + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE ARE
   + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
LIABLE
   + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 
CONSEQUENTIAL
   + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS 
OR
   + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) 
HOWEVER
   + * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 
LIABILITY,
   + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF 
THE USE
   + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   + *
   + 
**
   + */

/* Define to prevent recursive inclusion 
-*/
#ifndef __STM32F4xx_HAL_CONF_H
   @@ -42,7 +42,7 @@
#include 

#ifdef __cplusplus
   - extern "C" {
   +extern "C" {
#endif

/* Exported types

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2203: Adding bsp/stm32f411discovery

2020-02-24 Thread GitBox 
apache-mynewt-bot commented on issue #2203: Adding  bsp/stm32f411discovery 
URL: https://github.com/apache/mynewt-core/pull/2203#issuecomment-590486413
 
 
   
   
   
   ## RAT Report (2020-02-24 18:43:18)
   
   ## New files with unknown licenses
   
   * https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/include/bsp/stm32f4xx_hal_conf.h";>hw/bsp/stm32f411discovery/include/bsp/stm32f4xx_hal_conf.h
   * https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/src/arch/cortex_m4/startup_STM32F411.s";>hw/bsp/stm32f411discovery/src/arch/cortex_m4/startup_STM32F411.s
   
   
 Detailed analysis
   
   ## New files in this PR
   
   | License | File |
   |-|--|
   | AL | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/boot-stm32f411discovery.ld";>hw/bsp/stm32f411discovery/boot-stm32f411discovery.ld
 |
   | AL | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/bsp.yml";>hw/bsp/stm32f411discovery/bsp.yml
 |
   | AL | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/include/bsp/bsp.h";>hw/bsp/stm32f411discovery/include/bsp/bsp.h
 |
   | ?  | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/include/bsp/stm32f4xx_hal_conf.h";>hw/bsp/stm32f411discovery/include/bsp/stm32f4xx_hal_conf.h
 |
   | AL | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/pkg.yml";>hw/bsp/stm32f411discovery/pkg.yml
 |
   | ?  | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/src/arch/cortex_m4/startup_STM32F411.s";>hw/bsp/stm32f411discovery/src/arch/cortex_m4/startup_STM32F411.s
 |
   | AL | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/src/hal_bsp.c";>hw/bsp/stm32f411discovery/src/hal_bsp.c
 |
   | AL | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/stm32f411discovery.ld";>hw/bsp/stm32f411discovery/stm32f411discovery.ld
 |
   | AL | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/stm32f411discovery_debug.cmd";>hw/bsp/stm32f411discovery/stm32f411discovery_debug.cmd
 |
   | AL | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/stm32f411discovery_debug.sh";>hw/bsp/stm32f411discovery/stm32f411discovery_debug.sh
 |
   | AL | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/stm32f411discovery_download.cmd";>hw/bsp/stm32f411discovery/stm32f411discovery_download.cmd
 |
   | AL | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/stm32f411discovery_download.sh";>hw/bsp/stm32f411discovery/stm32f411discovery_download.sh
 |
   | AL | https://github.com/apache/mynewt-core/blob/2ca1a49c962790cf6d845caa997302d1710b40b2/hw/bsp/stm32f411discovery/syscfg.yml";>hw/bsp/stm32f411discovery/syscfg.yml
 |
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2203: Adding bsp/stm32f411discovery

2020-02-25 Thread GitBox 
apache-mynewt-bot commented on issue #2203: Adding  bsp/stm32f411discovery 
URL: https://github.com/apache/mynewt-core/pull/2203#issuecomment-590866225
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/bsp/stm32f411discovery/include/bsp/stm32f4xx_hal_conf.h
   
   
   ```diff
   @@ -1,39 +1,39 @@
/**
   -  
**
   -  * @filestm32f4xx_hal_conf.h
   -  * @author  MCD Application Team
   -  * @version V1.2.4
   -  * @date06-May-2016
   -  * @brief   HAL configuration file
   -  
**
   -  * @attention
   -  *
   -  * © COPYRIGHT(c) 2016 STMicroelectronics
   -  *
   -  * Redistribution and use in source and binary forms, with or without 
modification,
   -  * are permitted provided that the following conditions are met:
   -  *   1. Redistributions of source code must retain the above copyright 
notice,
   -  *  this list of conditions and the following disclaimer.
   -  *   2. Redistributions in binary form must reproduce the above copyright 
notice,
   -  *  this list of conditions and the following disclaimer in the 
documentation
   -  *  and/or other materials provided with the distribution.
   -  *   3. Neither the name of STMicroelectronics nor the names of its 
contributors
   -  *  may be used to endorse or promote products derived from this 
software
   -  *  without specific prior written permission.
   -  *
   -  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
IS"
   -  * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
THE
   -  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE ARE
   -  * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
LIABLE
   -  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 
CONSEQUENTIAL
   -  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS 
OR
   -  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) 
HOWEVER
   -  * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 
LIABILITY,
   -  * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF 
THE USE
   -  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   -  *
   -  
**
   -  */
   + 
**
   + * @filestm32f4xx_hal_conf.h
   + * @author  MCD Application Team
   + * @version V1.2.4
   + * @date06-May-2016
   + * @brief   HAL configuration file
   + 
**
   + * @attention
   + *
   + * © COPYRIGHT(c) 2016 STMicroelectronics
   + *
   + * Redistribution and use in source and binary forms, with or without 
modification,
   + * are permitted provided that the following conditions are met:
   + *   1. Redistributions of source code must retain the above copyright 
notice,
   + *  this list of conditions and the following disclaimer.
   + *   2. Redistributions in binary form must reproduce the above copyright 
notice,
   + *  this list of conditions and the following disclaimer in the 
documentation
   + *  and/or other materials provided with the distribution.
   + *   3. Neither the name of STMicroelectronics nor the names of its 
contributors
   + *  may be used to endorse or promote products derived from this 
software
   + *  without specific prior written permission.
   + *
   + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
IS"
   + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
   + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE ARE
   + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
LIABLE
   + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 
CONSEQUENTIAL
   + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS 
OR
   + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) 
HOWEVER
   + * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 
LIABILITY,
   + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF 
THE USE
   + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   + *
   + 
**
   + */

/* Define to prevent recursive inclusion 
-*/
#ifndef __STM32F4xx_HAL_CONF_H
   @@ -42,7 +42,7 @@
#include 

#ifdef __cplusplus
   - extern "C" {
   +extern "C" {
#endif

/* Exported types

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2203: Adding bsp/stm32f411discovery

2020-02-25 Thread GitBox 
apache-mynewt-bot commented on issue #2203: Adding  bsp/stm32f411discovery 
URL: https://github.com/apache/mynewt-core/pull/2203#issuecomment-590866090
 
 
   
   
   
   ## RAT Report (2020-02-25 13:27:54)
   
   ## New files with unknown licenses
   
   * https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/include/bsp/stm32f4xx_hal_conf.h";>hw/bsp/stm32f411discovery/include/bsp/stm32f4xx_hal_conf.h
   * https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/src/arch/cortex_m4/startup_STM32F411.s";>hw/bsp/stm32f411discovery/src/arch/cortex_m4/startup_STM32F411.s
   
   
 Detailed analysis
   
   ## New files in this PR
   
   | License | File |
   |-|--|
   | AL | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/boot-stm32f411discovery.ld";>hw/bsp/stm32f411discovery/boot-stm32f411discovery.ld
 |
   | AL | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/bsp.yml";>hw/bsp/stm32f411discovery/bsp.yml
 |
   | AL | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/include/bsp/bsp.h";>hw/bsp/stm32f411discovery/include/bsp/bsp.h
 |
   | ?  | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/include/bsp/stm32f4xx_hal_conf.h";>hw/bsp/stm32f411discovery/include/bsp/stm32f4xx_hal_conf.h
 |
   | AL | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/pkg.yml";>hw/bsp/stm32f411discovery/pkg.yml
 |
   | ?  | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/src/arch/cortex_m4/startup_STM32F411.s";>hw/bsp/stm32f411discovery/src/arch/cortex_m4/startup_STM32F411.s
 |
   | AL | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/src/hal_bsp.c";>hw/bsp/stm32f411discovery/src/hal_bsp.c
 |
   | AL | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/stm32f411discovery.ld";>hw/bsp/stm32f411discovery/stm32f411discovery.ld
 |
   | AL | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/stm32f411discovery_debug.cmd";>hw/bsp/stm32f411discovery/stm32f411discovery_debug.cmd
 |
   | AL | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/stm32f411discovery_debug.sh";>hw/bsp/stm32f411discovery/stm32f411discovery_debug.sh
 |
   | AL | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/stm32f411discovery_download.cmd";>hw/bsp/stm32f411discovery/stm32f411discovery_download.cmd
 |
   | AL | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/stm32f411discovery_download.sh";>hw/bsp/stm32f411discovery/stm32f411discovery_download.sh
 |
   | AL | https://github.com/apache/mynewt-core/blob/ebeadf97aa7b8ba7a73bcf540cd4284ba48bc44e/hw/bsp/stm32f411discovery/syscfg.yml";>hw/bsp/stm32f411discovery/syscfg.yml
 |
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services