[GitHub] [mynewt-core] utzig commented on issue #2175: da1469x: add initial crypto driver
utzig commented on issue #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-598616618 > Minor nit: CBC and CTR cases can be rearranged for better readability - mask is 0, 2 and 3 Done! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] utzig commented on issue #2175: da1469x: add initial crypto driver
utzig commented on issue #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-598388555 This was updated with all findings by @nkaje (thanks a lot!); it now works correctly with `crypto_test` app but still have the limitation that the input buffer must be located in RAM (to be fixed!). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] utzig commented on issue #2175: da1469x: add initial crypto driver
utzig commented on issue #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-590942894 @agross-korg @nkaje What would be the best way to get this in? Does one of you want to take over, or should I merge and fix after testing is done? I am open to suggestions! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] utzig commented on issue #2175: da1469x: add initial crypto driver
utzig commented on issue #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-581932252 > one mutex to rule them... :rofl: yeah, that is one approach, but the `crypto` driver's idea is to add a lower layer that handles the HW crypto providing an abstraction that higher level drivers would use. There is still a mutex but higher levels don't see it and there are other advantages like mbedTLS AES calls being automatically routed to HW, etc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] utzig commented on issue #2175: da1469x: add initial crypto driver
utzig commented on issue #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-581547425 > @agross-korg @nkaje This would be incompatible with using the enc_flash driver for da1469x at the same time; to test this you would need to use `hw/drivers/flash/enc_flash/ef_crypto`. That enc_flash for da1469x is better written as well, so I will pick some of that code... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] utzig commented on issue #2175: da1469x: add initial crypto driver
utzig commented on issue #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-581547071 @agross-korg @nkaje This would be incompatible with using the enc_flash driver for da1469x at the same time; to test this you would need to use `hw/drivers/flash/enc_flash/ef_crypto`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] utzig commented on issue #2175: da1469x: add initial crypto driver
utzig commented on issue #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-581494641 > We need to make sure there aren't any other possible conflicts where people are using the crypto driver somewhere else. I know we use the secure OTP keys in the bootloader, but that's self contained. The encrypted flash driver is not and could conflict with this. Ok, I haven't seen there was an encrypted flash already, my bad. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] utzig commented on issue #2175: da1469x: add initial crypto driver
utzig commented on issue #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-581180409 Fixed review issues; added the driver initialization to MCU code which I had forgotten to do; fixed style issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
