[GitHub] [mynewt-nimble] IshaESP commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.

[GitBox]

IshaESP commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1066725095


##
nimble/host/include/host/ble_hs.h:
##
@@ -184,6 +184,22 @@ extern "C" {
 
 /** CSRK distibution and LinkKey are not supported */
 
+/**
+ * @}
+ */
+
+/**
+ * @brief LE deprecate warning
+ *
+ * @{
+ */
+
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] IshaESP commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.

[GitBox]

IshaESP commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1044153414


##
nimble/host/include/host/ble_gatt.h:
##
@@ -476,8 +477,15 @@ int ble_gatts_notify_custom(uint16_t conn_handle, uint16_t 
att_handle,
 /**
  * Deprecated. Should not be used. Use ble_gatts_notify_custom instead.
  */
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)

Review Comment:
   For this - NIMBLE_DEPRECATED("use bar") void foo(void);   CI always fails. 
Tried the other way around too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] IshaESP commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.

[GitBox]

IshaESP commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1044152797


##
nimble/host/include/host/ble_hs.h:
##
@@ -184,6 +184,22 @@ extern "C" {
 
 /** CSRK distibution and LinkKey are not supported */
 
+/**
+ * @}
+ */
+
+/**
+ * @brief LE deprecate warning
+ *
+ * @{
+ */
+
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)
+#define NIMBLE_DEPRECATED(_msg) __attribute__((deprecated("Deprecated. Should 
not be used. " _msg)))

Review Comment:
   It's default value is set to 0, if someone wants to opt in they can set it 
to 1.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org