[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #508: npl/riot: strip down the default configuration
andrzej-kaczmarek commented on a change in pull request #508: npl/riot: strip down the default configuration URL: https://github.com/apache/mynewt-nimble/pull/508#discussion_r300707183 ## File path: porting/npl/riot/include/syscfg/syscfg.h ## @@ -830,7 +830,8 @@ #endif #ifndef MYNEWT_VAL_BLE_L2CAP_MAX_CHANS -#define MYNEWT_VAL_BLE_L2CAP_MAX_CHANS (3*MYNEWT_VAL_BLE_MAX_CONNECTIONS) +#define MYNEWT_VAL_BLE_L2CAP_MAX_CHANS ((2 + MYNEWT_VAL_BLE_SM_SC) * \ Review comment: And yes, SM is not compiled in when LE SC and LE legacy pairing are both disabled. There's just a simple handler for L2CAP channel to reply with an error on any received signalling. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #508: npl/riot: strip down the default configuration
andrzej-kaczmarek commented on a change in pull request #508: npl/riot: strip down the default configuration URL: https://github.com/apache/mynewt-nimble/pull/508#discussion_r300705983 ## File path: porting/npl/riot/include/syscfg/syscfg.h ## @@ -830,7 +830,8 @@ #endif #ifndef MYNEWT_VAL_BLE_L2CAP_MAX_CHANS -#define MYNEWT_VAL_BLE_L2CAP_MAX_CHANS (3*MYNEWT_VAL_BLE_MAX_CONNECTIONS) +#define MYNEWT_VAL_BLE_L2CAP_MAX_CHANS ((2 + MYNEWT_VAL_BLE_SM_SC) * \ Review comment: We simply create all 3 channels in `ble_hs_conn_alloc` and failure to create at least one means connection is not allocated in the host. Even if both LE SC and LE legacy pairing are disabled, SM channel has to be allocated in order to be compliant with spec [1] that is so we can reply on signalling with an error as otherwise remote has no way to know that we do not support pairing. [1] Core 5.1, Vol 3, Part A, section 2.1 > At a minimum, the L2CAP Signaling channel (fixed channel 0x0001) or the > L2CAP LE Signaling channel (fixed channel 0x0005) shall be supported. **If > fixed channel 0x0005 is supported, then fixed channels 0x0004 and 0x0006 > shall be supported** (see Table 2.2). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #508: npl/riot: strip down the default configuration
andrzej-kaczmarek commented on a change in pull request #508: npl/riot: strip down the default configuration URL: https://github.com/apache/mynewt-nimble/pull/508#discussion_r300697476 ## File path: porting/npl/riot/include/syscfg/syscfg.h ## @@ -830,7 +830,8 @@ #endif #ifndef MYNEWT_VAL_BLE_L2CAP_MAX_CHANS -#define MYNEWT_VAL_BLE_L2CAP_MAX_CHANS (3*MYNEWT_VAL_BLE_MAX_CONNECTIONS) +#define MYNEWT_VAL_BLE_L2CAP_MAX_CHANS ((2 + MYNEWT_VAL_BLE_SM_SC) * \ Review comment: we always need 3 channels per connection (ATT, signalling and SM) - this is mandatory in spec This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
