[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU
apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1213031513
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU
apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1199173904
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU
apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1195381681
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU
apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1192501851
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU
apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1192468699
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/host/src/ble_l2cap_coc.c
```diff
@@ -191,7 +191,7 @@
rx_sdu = rx->sdus[current_sdu];
-//DFLT_LOG_CRITICAL("current_sdu: %d\n", current_sdu);
+/*DFLT_LOG_CRITICAL("current_sdu: %d\n", current_sdu); */
om_total = OS_MBUF_PKTLEN(*om);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU
apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1176104776
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU
apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1176098876
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/host/src/ble_l2cap_coc.c
```diff
@@ -231,7 +231,7 @@
BLE_HS_LOG(DEBUG, "sdu_len=%d, received LE frame=%d, credits=%d\n",
sdu_len, om_total, rx->credits);
-os_mbuf_adj(*om , BLE_L2CAP_SDU_SIZE);
+os_mbuf_adj(*om, BLE_L2CAP_SDU_SIZE);
rc = os_mbuf_appendfrom(rx_sdu, *om, 0, om_total -
BLE_L2CAP_SDU_SIZE);
if (rc != 0) {
@@ -257,7 +257,7 @@
ble_l2cap_disconnect(chan);
return BLE_HS_EBADDATA;
}
-rc = os_mbuf_appendfrom(rx_sdu, *om, 0, om_total);
+rc = os_mbuf_appendfrom(rx_sdu, *om, 0, om_total);
if (rc != 0) {
/* FIXME: need to handle it better */
BLE_HS_LOG(DEBUG, "Could not append data rc=%d\n", rc);
@@ -337,7 +337,7 @@
chan->rx_fn = ble_l2cap_coc_rx_fn;
chan->coc_rx.mtu = mtu;
chan->coc_rx.sdus[0] = sdu_rx;
-for(int i = 1; i < BLE_L2CAP_SDU_BUFF_CNT; i++) {
+for (int i = 1; i < BLE_L2CAP_SDU_BUFF_CNT; i++) {
chan->coc_rx.sdus[i] = NULL;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU
apache-mynewt-bot commented on PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1142433422
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/host/src/ble_l2cap_coc.c
```diff
@@ -193,7 +193,7 @@
BLE_HS_DBG_ASSERT(rx != NULL);
rx_sdu = rx->sdu[current_sdu];
-//rx->sdu[current_sdu] = rx_sdu;
+/*rx->sdu[current_sdu] = rx_sdu; */
DFLT_LOG_CRITICAL("current_sdu: %d\n", current_sdu);
@@ -235,7 +235,7 @@
BLE_HS_LOG(DEBUG, "sdu_len=%d, received LE frame=%d, credits=%d\n",
sdu_len, om_total, rx->credits);
-os_mbuf_adj(*om , BLE_L2CAP_SDU_SIZE);
+os_mbuf_adj(*om, BLE_L2CAP_SDU_SIZE);
rc = os_mbuf_appendfrom(rx_sdu, *om, 0, om_total -
BLE_L2CAP_SDU_SIZE);
if (rc != 0) {
@@ -261,7 +261,7 @@
ble_l2cap_disconnect(chan);
return BLE_HS_EBADDATA;
}
-rc = os_mbuf_appendfrom(rx_sdu, *om, 0, om_total);
+rc = os_mbuf_appendfrom(rx_sdu, *om, 0, om_total);
if (rc != 0) {
/* FIXME: need to handle it better */
BLE_HS_LOG(DEBUG, "Could not append data rc=%d\n", rc);
@@ -287,7 +287,7 @@
} else {
current_sdu = 0;
}
-//rx_sdu = rx_sdu_list[current_sdu];
+/*rx_sdu = rx_sdu_list[current_sdu]; */
rx->data_offset = 0;
ble_l2cap_event_coc_received_data(chan, sdu_rx);
@@ -345,12 +345,12 @@
chan->rx_fn = ble_l2cap_coc_rx_fn;
chan->coc_rx.mtu = mtu;
rx_sdu_list[0] = sdu_rx;
-for(int i = 1; i < BLE_L2CAP_SDU_BUFF_CNT; i++) {
+for (int i = 1; i < BLE_L2CAP_SDU_BUFF_CNT; i++) {
rx_sdu_list[i] = NULL;
}
chan->coc_rx.sdu = rx_sdu_list;
chan->coc_tx.sdu = tx_sdu_list;
-//chan->coc_rx.sdu = sdu_rx;
+/*chan->coc_rx.sdu = sdu_rx; */
/* Number of credits should allow to send full SDU with on given
@@ -617,8 +617,10 @@
break;
}
}
-//assert(chan->coc_rx.sdu[0] || chan->coc_rx.sdu[1]);
-//chan->coc_rx.sdu = sdu_rx;
+/*
+ assert(chan->coc_rx.sdu[0] || chan->coc_rx.sdu[1]);
+ chan->coc_rx.sdu = sdu_rx;
+ */
ble_hs_lock();
conn = ble_hs_conn_find_assert(chan->conn_handle);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
