[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1418: nimble/fem: Add runtime default antenna selection to SKY66112

2022-12-13 Thread GitBox 


apache-mynewt-bot commented on PR #1418:
URL: https://github.com/apache/mynewt-nimble/pull/1418#issuecomment-134653

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1418: nimble/fem: Add runtime default antenna selection to SKY66112

2022-12-12 Thread GitBox 


apache-mynewt-bot commented on PR #1418:
URL: https://github.com/apache/mynewt-nimble/pull/1418#issuecomment-1347775742

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1418: nimble/fem: Add runtime default antenna selection to SKY66112

2022-12-08 Thread GitBox 


apache-mynewt-bot commented on PR #1418:
URL: https://github.com/apache/mynewt-nimble/pull/1418#issuecomment-1342827087

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1418: nimble/fem: Add runtime default antenna selection to SKY66112

2022-12-08 Thread GitBox 


apache-mynewt-bot commented on PR #1418:
URL: https://github.com/apache/mynewt-nimble/pull/1418#issuecomment-1342801099

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/drivers/fem/sky66112/src/sky66112.c
   
   
   ```diff
   @@ -150,7 +150,8 @@
}

#if !MYNEWT_VAL_CHOICE(SKY66112_ANTENNA_PORT, runtime)
   -uint8_t sky66112_default_antenna(void)
   +uint8_t
   +sky66112_default_antenna(void)
{
if (MYNEWT_VAL_CHOICE(SKY66112_ANTENNA_PORT, ANT1)) {
return 1;
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org