[jira] [Updated] (NETBEANS-346) Right Margin does not line up with text position using monospace

2018-01-29 Thread Austin Stephens (JIRA)

 [ 
https://issues.apache.org/jira/browse/NETBEANS-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Austin Stephens updated NETBEANS-346:
-
Description: 
When the Right Margin is set at 80 chars, it is drawn at 8*2* chars. This is 
annoying because I have a 1440x900 screen that I split vertically in to two. 
This results in two editing areas that are about 80 chars wide. I could see the 
margin line in both editors when scrolled all the way to the left. Since 
Netbeans (9.0 beta) is now drawing them at char 8*2,* it is not possible to 
size those editors so I can see the line in both windows and it is driving me 
crazy.

This is a first world issue at the moment, but you might find code coming from 
mac programmers coming in two or more chars too wide in the Netbeans source 
code.

  was:
When the Right Margin is set at 80 chars, it is drawn at 8*2* chars. This is 
annoying because I have a 1440x900 screen that I split vertically in to two. 
This results in two editing areas that are about 80 chars wide. I could see the 
margin line in both editors when scrolled all the way to the left. Since 
Netbeans (9.0 beta) is now drawing them at char 8*2,* it is not possible to 
size those editors so I can see the line in both windows and it is driving me 
crazy.

This is a first world issue at the moment, but you might find code coming from 
mac programmers coming in two chars too wide in the Netbeans source code.


> Right Margin does not line up with text position using monospace
> 
>
> Key: NETBEANS-346
> URL: https://issues.apache.org/jira/browse/NETBEANS-346
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Other
>Affects Versions: 9.0
> Environment: Mac OS 10.10 (at least)
>Reporter: Austin Stephens
>Priority: Minor
> Attachments: Screen Shot 2018-01-29 at 4.58.35 PM.png
>
>
> When the Right Margin is set at 80 chars, it is drawn at 8*2* chars. This is 
> annoying because I have a 1440x900 screen that I split vertically in to two. 
> This results in two editing areas that are about 80 chars wide. I could see 
> the margin line in both editors when scrolled all the way to the left. Since 
> Netbeans (9.0 beta) is now drawing them at char 8*2,* it is not possible to 
> size those editors so I can see the line in both windows and it is driving me 
> crazy.
> This is a first world issue at the moment, but you might find code coming 
> from mac programmers coming in two or more chars too wide in the Netbeans 
> source code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-346) Right Margin does not line up with text position using monospace

2018-01-29 Thread Austin Stephens (JIRA)
Austin Stephens created NETBEANS-346:


 Summary: Right Margin does not line up with text position using 
monospace
 Key: NETBEANS-346
 URL: https://issues.apache.org/jira/browse/NETBEANS-346
 Project: NetBeans
  Issue Type: Bug
  Components: editor - Other
Affects Versions: 9.0
 Environment: Mac OS 10.10 (at least)
Reporter: Austin Stephens
 Attachments: Screen Shot 2018-01-29 at 4.58.35 PM.png

When the Right Margin is set at 80 chars, it is drawn at 8*2* chars. This is 
annoying because I have a 1440x900 screen that I split vertically in to two. 
This results in two editing areas that are about 80 chars wide. I could see the 
margin line in both editors when scrolled all the way to the left. Since 
Netbeans (9.0 beta) is now drawing them at char 8*2,* it is not possible to 
size those editors so I can see the line in both windows and it is driving me 
crazy.

This is a first world issue at the moment, but you might find code coming from 
mac programmers coming in two chars too wide in the Netbeans source code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-345) "Move Inner to Outer Level" refactoring adds erroneous "" to the new outer class' source

2018-01-29 Thread Daniel Trebbien (JIRA)
Daniel Trebbien created NETBEANS-345:


 Summary: "Move Inner to Outer Level" refactoring adds erroneous 
"" to the new outer class' source
 Key: NETBEANS-345
 URL: https://issues.apache.org/jira/browse/NETBEANS-345
 Project: NetBeans
  Issue Type: Bug
  Components: java - Refactoring
Affects Versions: Next
Reporter: Daniel Trebbien


Steps to reproduce:
 # Open the following source file:
{code:java}
package bugs;

import java.util.List;
import java.util.concurrent.RunnableFuture;

public class MoveInnerToOuterTest {

public static class Inner {
public Inner(List runnables) {
assert runnables.stream()
.noneMatch((r) -> r instanceof RunnableFuture);
}
}
}
{code}
 # Right click on {{class Inner}} and select *Refactor > Move Inner to Outer 
Level…*
 # Click the "Refactor" button on the dialog.

The newly-generated {{Inner.java}} has the following contents:
{code:java}
package bugs;

import java.util.List;
import java.util.concurrent.RunnableFuture;

public class Inner {

public Inner(List runnables) {
assert runnables.stream().noneMatch(( r) -> r 
instanceof RunnableFuture);
}
}
{code}

Notice the invalid "".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-239) Build failure: org-netbeans-modules-websvc-saas-api.jar is not a module with Fedora Ant package

2018-01-29 Thread Peter Hull (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343362#comment-16343362
 ] 

Peter Hull commented on NETBEANS-239:
-

I've looked into this a bit more and I think the problem comes from running the 
'xjc' task. By cutting bits out of the Netbeans build.xml I created a minimal 
example:
{code:java}


  

  

  
  


  

{code}
where 'test.xsd' is just because the task requires a 'schema' attribute
{code:java}
http://www.w3.org/2001/XMLSchema;>
  

{code}
and into the 'external' directory I copied the jars from 
netbeans/libs.jaxb/external/

This runs OK on Windows (not been able to verify on Debian or Macos) but on 
Fedora (FC27, 64-bit) I get
{noformat}
Buildfile: .../build.xml

fail:
  [xjc] Consider using / so that XJC won't do 
unnecessary compilation
  [xjc] Compiling file:/media/sf_Share/tru/test.xsd
  [xjc] Writing output to .
Caught an exception while logging the end of the build.  Exception was:
java.lang.NoClassDefFoundError: org/apache/tools/ant/util/DateUtils
    at org.apache.tools.ant.DefaultLogger.formatTime(DefaultLogger.java:328)
    at 
org.apache.tools.ant.DefaultLogger.buildFinished(DefaultLogger.java:177)
    at org.apache.tools.ant.Project.fireBuildFinished(Project.java:2110)
    at org.apache.tools.ant.Main.runBuild(Main.java:878)
    at org.apache.tools.ant.Main.startAnt(Main.java:236)
    at org.apache.tools.ant.launch.Launcher.run(Launcher.java:287)
    at org.apache.tools.ant.launch.Launcher.main(Launcher.java:113)
Caused by: java.lang.ClassNotFoundException: org.apache.tools.ant.util.DateUtils
    at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
    at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
    ... 7 more
{noformat}
This is not the same error as reported above, I admit, but I believe it is the 
same cause, ie. ant failing to find something that ought to be on its classpath.

The provided jaxb jars are quite old (2.2.5 is from 2013, current version is 
2.3.0) - maybe these are built in a way which is not compatible with Fedora's 
ant? 

> Build failure: org-netbeans-modules-websvc-saas-api.jar is not a module with 
> Fedora Ant package
> ---
>
> Key: NETBEANS-239
> URL: https://issues.apache.org/jira/browse/NETBEANS-239
> Project: NetBeans
>  Issue Type: Bug
> Environment: - Environment 1: Fedora release 25 (Twenty Five), javac 
> 1.8.0_151, Apache Ant(TM) version 1.9.6 compiled on February 3 2016 (Expected 
> failure as Ant 1.9.9 or above required): fails
> - Environment 2: Fedora release 26 (Twenty Six), javac 1.8.0_151, Apache 
> Ant(TM) version 1.10.1 compiled on March 1 2017: Fails
> - Environment 3: Fedora release 26 (Twenty Six), javac 1.8.0_151, Apache 
> Ant(TM) version 1.10.1 compiled on February 2 2017 (downloaded from 
> ant.apache.org): works
> - Environment 4: Debian 9.3 (Stretch), javac 1.8.0_151, Apache Ant(TM) 
> version 1.9.9 compiled on March 1 2017: works
>Reporter: Markus Kilås
>Priority: Minor
> Attachments: ant-output-environment-2.txt, ant-output.txt
>
>
> I just cloned the [incubator-netbeans git 
> repo|https://github.com/apache/incubator-netbeans] and tried running {{ant}} 
> to build NetBeans. However the build fails complaining on no manifest for the 
> all-websvc.saas.api. Am I missing something that needs to be configured for 
> the build to succeed?
> {noformat}
> [user@dev-disp incubator-netbeans]$ git pull
> Already up-to-date.
> [user@dev-disp incubator-netbeans]$ git rev-parse HEAD
> f8b6323b690b5edafe91bae750f79db4247dd23c
> [user@dev-disp incubator-netbeans]$ ant
> Buildfile: 
> /home/user/VersionControlled/github/apache/incubator-netbeans/build.xml
> ... snip ...
> projectized-common.release:
>  [copy] Copying 1 file to 
> /home/user/VersionControlled/github/apache/incubator-netbeans/nbbuild/netbeans/websvccommon
> release:
> -init-startlevel:
> module-xml-regular:
>   [nbmerge] Failed to build target: all-websvc.saas.api
> BUILD FAILED
> /home/user/VersionControlled/github/apache/incubator-netbeans/nbbuild/build.xml:469:
>  The following error occurred while executing this line:
> /home/user/VersionControlled/github/apache/incubator-netbeans/nbbuild/build.xml:464:
>  The following error occurred while executing this line:
> /home/user/VersionControlled/github/apache/incubator-netbeans/nbbuild/build.xml:511:
>  The following error occurred while executing this line:
> /home/user/VersionControlled/github/apache/incubator-netbeans/nbbuild/templates/common.xml:267:
>  Missing manifest tag OpenIDE-Module; 
> 

[jira] [Created] (NETBEANS-343) Possible Null dereference hint works bad with overrides

2018-01-29 Thread Svatopluk Dedic (JIRA)
Svatopluk Dedic created NETBEANS-343:


 Summary: Possible Null dereference hint works bad with overrides
 Key: NETBEANS-343
 URL: https://issues.apache.org/jira/browse/NETBEANS-343
 Project: NetBeans
  Issue Type: Bug
  Components: java - Hints
Affects Versions: 8.2
Reporter: Svatopluk Dedic


I have an interface and implementing class:

 
{code:java}
public interface Builder {
  @CheckForNull
  Properties getNodeProperties(int nodeId);
}

public class ModelBuilder implements Builder {
  // ...
  @Override
  public Properties getNodeProperties(int nodeId) { /* ... */ }

  protected boolean updateNodeBlock(int nodeId, String name) {
final Properties properties = getNodeProperties(nodeId);
final String oldBlock = properties.get(PROPNAME_BLOCK, String.class);
  
  }
  // ...
}{code}
Even though the overriden method is marked with  CheckForNull, the hint for 
possible null dereference at properties.get will not show up unless the 
overriden method is also annotated.

This is IMHO bad, the inherited contract allows to return null, and unless the 
overriden method is annotated with different flag (i.e. NonNull), the inherited 
info should be used.

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists