[incubator-netbeans] branch master updated: [NETBEANS-1074] Module Review glassfish.tooling (#818)

2018-08-30 Thread junichi11
This is an automated email from the ASF dual-hosted git repository.

junichi11 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 80df40f  [NETBEANS-1074] Module Review glassfish.tooling (#818)
80df40f is described below

commit 80df40f8d649ae3df795b57d4e4da961b5a620d0
Author: Josh Juneau 
AuthorDate: Thu Aug 30 22:03:23 2018 -0500

[NETBEANS-1074] Module Review glassfish.tooling (#818)

- No external libraries
- Checked Rat report:  everything now licensed to Apache
- Skimmed module...no additional problems found
- Added licenseinfo.xml to capture licensing for included json files
---
 glassfish.tooling/licenseinfo.xml  | 29 
 .../glassfish/tooling/GlassFish.properties-dist| 16 +++
 .../tooling/GlassFishHttp.properties-dist  | 16 +++
 .../tooling/GlassFishRest.properties-dist  | 16 +++
 .../modules/glassfish/tooling/Java.properties-dist | 16 +++
 .../tooling/admin/response/list-jdbc-resources.xml | 22 -
 .../glassfish/tooling/admin/response/version.xml   | 22 -
 .../tooling/data/GlassFishVersionTest.java | 55 +++---
 8 files changed, 152 insertions(+), 40 deletions(-)

diff --git a/glassfish.tooling/licenseinfo.xml 
b/glassfish.tooling/licenseinfo.xml
new file mode 100644
index 000..7d1ecbc
--- /dev/null
+++ b/glassfish.tooling/licenseinfo.xml
@@ -0,0 +1,29 @@
+
+
+
+
+
test/unit/src/org/netbeans/modules/glassfish/tooling/admin/response/list-jdbc-resources.json
+
test/unit/src/org/netbeans/modules/glassfish/tooling/admin/response/location.json
+
+
+
+
diff --git 
a/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/GlassFish.properties-dist
 
b/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/GlassFish.properties-dist
index 4b51df2..09cf219 100644
--- 
a/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/GlassFish.properties-dist
+++ 
b/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/GlassFish.properties-dist
@@ -1,3 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
 host=localhost
 adminUser=admin
 adminPassword=admin123
diff --git 
a/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/GlassFishHttp.properties-dist
 
b/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/GlassFishHttp.properties-dist
index 8248675..dfec5dc 100644
--- 
a/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/GlassFishHttp.properties-dist
+++ 
b/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/GlassFishHttp.properties-dist
@@ -1,3 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
 name=GlassFish Server 3.1.2.2
 serverHome=/users/tomas/WS/gfr3122/glassfish
 domainsFolder=/users/tomas/WS/gfr3122/glassfish/domains
diff --git 
a/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/GlassFishRest.properties-dist
 
b/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/GlassFishRest.properties-dist
index 486da9f..cf65a3e 100644
--- 
a/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/GlassFishRest.properties-dist
+++ 
b/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/GlassFishRest.properties-dist
@@ 

[incubator-netbeans] branch master updated: [NETBEANS-1074] Module Review libs.plist (#817)

2018-08-30 Thread junichi11
This is an automated email from the ASF dual-hosted git repository.

junichi11 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 414a38b  [NETBEANS-1074] Module Review libs.plist (#817)
414a38b is described below

commit 414a38bdae8a6d02d8973b62e593388cb5d5befa
Author: Junichi Yamamoto 
AuthorDate: Fri Aug 31 05:10:11 2018 +0900

[NETBEANS-1074] Module Review libs.plist (#817)

- Add the license header to binaries-list
- Add maven coordinate (Change the version from 1.1-SNAPSHOT to 1.3)
- Add MIT-dd-plist to nbbuild/licenses
---
 libs.plist/external/binaries-list  | 18 +-
 .../{dd-plist-license.txt => dd-plist-1.3-license.txt} | 10 +-
 libs.plist/manifest.mf |  2 +-
 libs.plist/nbproject/project.properties|  2 +-
 .../licenses/MIT-dd-plist  | 10 ++
 nbbuild/licenses/names.properties  |  1 +
 6 files changed, 27 insertions(+), 16 deletions(-)

diff --git a/libs.plist/external/binaries-list 
b/libs.plist/external/binaries-list
index 09aeeb4..64e4343 100644
--- a/libs.plist/external/binaries-list
+++ b/libs.plist/external/binaries-list
@@ -1 +1,17 @@
-59631804B5A7FF3CEAA3F0E113584AF7E1BB6E9B dd-plist.jar
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+F1FFEA79B6034718AC4298D60F98F10B878EC476 com.googlecode.plist:dd-plist:1.3
diff --git a/libs.plist/external/dd-plist-license.txt 
b/libs.plist/external/dd-plist-1.3-license.txt
similarity index 85%
copy from libs.plist/external/dd-plist-license.txt
copy to libs.plist/external/dd-plist-1.3-license.txt
index b0ee971..c36b8c3 100644
--- a/libs.plist/external/dd-plist-license.txt
+++ b/libs.plist/external/dd-plist-1.3-license.txt
@@ -1,11 +1,11 @@
 Name: plist
-Version: 99
+Version: 1.3
 Description: An open source library to parse and generate property lists
-License: MIT-plist
-Origin: http://code.google.com/p/plist/
-Files: dd-plist.jar
+License: MIT-dd-plist
+Origin: https://github.com/3breadt/dd-plist
 
-Copyright (C) 2012 Daniel Dreibrodt
+dd-plist - An open source library to parse and generate property lists
+Copyright (C) 2016 Daniel Dreibrodt
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
diff --git a/libs.plist/manifest.mf b/libs.plist/manifest.mf
index 8d3960a..8469e99 100644
--- a/libs.plist/manifest.mf
+++ b/libs.plist/manifest.mf
@@ -1,5 +1,5 @@
 Manifest-Version: 1.0
 OpenIDE-Module: org.netbeans.libs.plist
 OpenIDE-Module-Localizing-Bundle: org/netbeans/libs/plist/Bundle.properties
-OpenIDE-Module-Specification-Version: 1.8
+OpenIDE-Module-Specification-Version: 1.9
 
diff --git a/libs.plist/nbproject/project.properties 
b/libs.plist/nbproject/project.properties
index ab2dd30..af16de0 100644
--- a/libs.plist/nbproject/project.properties
+++ b/libs.plist/nbproject/project.properties
@@ -17,7 +17,7 @@
 javac.source=1.6
 javac.compilerargs=-Xlint -Xlint:-serial
 is.autoload=true
-release.external/dd-plist.jar=modules/ext/dd-plist.jar
+release.external/dd-plist-1.3.jar=modules/ext/dd-plist.jar
 
 sigtest.gen.fail.on.error=false
 
diff --git a/libs.plist/external/dd-plist-license.txt 
b/nbbuild/licenses/MIT-dd-plist
similarity index 82%
rename from libs.plist/external/dd-plist-license.txt
rename to nbbuild/licenses/MIT-dd-plist
index b0ee971..ab9e466 100644
--- a/libs.plist/external/dd-plist-license.txt
+++ b/nbbuild/licenses/MIT-dd-plist
@@ -1,11 +1,5 @@
-Name: plist
-Version: 99
-Description: An open source library to parse and generate property lists
-License: MIT-plist
-Origin: http://code.google.com/p/plist/
-Files: dd-plist.jar
-
-Copyright (C) 2012 Daniel Dreibrodt
+dd-plist - An open source library to parse and generate property lists
+Copyright (C) 2016 Daniel Dreibrodt
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
diff --git a/nbbuild/licenses/names.properties 

[jira] [Updated] (NETBEANS-1201) Filter in sources tree

2018-08-30 Thread Antonio Marques (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Marques updated NETBEANS-1201:
--
Component/s: projects - Generic Projects UI

> Filter in sources tree
> --
>
> Key: NETBEANS-1201
> URL: https://issues.apache.org/jira/browse/NETBEANS-1201
> Project: NetBeans
>  Issue Type: New Feature
>  Components: projects - Generic Projects UI
>Reporter: Antonio Marques
>Priority: Minor
>
> It would be nice to have a filtering textfield for the sources tree, like 
> there is in Xcode, as it would allow showing at once all the files matching 
> the criteria in a view that doesn't go away while you're using the editor.
> Another interesting feature of Xcode's filter is to allow you to toggle to 
> see only the changed files (matching the criteria, or all the changed files 
> if there are no criteria).
> In both cases, the nodes are expanded by default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Closed] (NETBEANS-1198) Dead link for "Developer builds" in README.md

2018-08-30 Thread Zach Hoffman (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zach Hoffman closed NETBEANS-1198.
--
Resolution: Duplicate

Oh, okay. Thanks for letting me know. I am on the mailing list now. Closing...

> Dead link for "Developer builds" in README.md
> -
>
> Key: NETBEANS-1198
> URL: https://issues.apache.org/jira/browse/NETBEANS-1198
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: Next
> Environment: GitHub
>Reporter: Zach Hoffman
>Priority: Major
>
> The file in question (6a5e347 is the latest commit as of posting this issue): 
> [https://github.com/apache/incubator-netbeans/blob/6a5e347/README.md]
> It contains a link to developer builds:
>  >Developer builds can be downloaded from Developer builds can be downloaded 
> from 
> [https://builds.apache.org/job/incubator-netbeans-release/]
> That link does not work, so the README should be updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-1201) Filter in sources tree

2018-08-30 Thread Antonio Marques (JIRA)
Antonio Marques created NETBEANS-1201:
-

 Summary: Filter in sources tree
 Key: NETBEANS-1201
 URL: https://issues.apache.org/jira/browse/NETBEANS-1201
 Project: NetBeans
  Issue Type: New Feature
Reporter: Antonio Marques


It would be nice to have a filtering textfield for the sources tree, like there 
is in Xcode, as it would allow showing at once all the files matching the 
criteria in a view that doesn't go away while you're using the editor.

Another interesting feature of Xcode's filter is to allow you to toggle to see 
only the changed files (matching the criteria, or all the changed files if 
there are no criteria).

In both cases, the nodes are expanded by default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-1200) Allow skipping save actions on save

2018-08-30 Thread Antonio Marques (JIRA)
Antonio Marques created NETBEANS-1200:
-

 Summary: Allow skipping save actions on save
 Key: NETBEANS-1200
 URL: https://issues.apache.org/jira/browse/NETBEANS-1200
 Project: NetBeans
  Issue Type: Improvement
  Components: editor - Actions/Menu/Toolbar
Affects Versions: 8.2
Reporter: Antonio Marques


Every so often, it's undesirable to have the 'On Save' editor actions applied 
top the file we're saving. For instance,
 * we may not wish to format a file, or organise imports, if it's a special 
file that requires a different style
 * or we may have some issue with some save action that doesn't normally 
surface, but does happen, and we just want to save the file and skip the 
actions - which, after all, we can always apply on demand
 * or sometimes NB will fail to resolve my dependencies unless I build first, 
but by calling build it will save my files, and the save action will delete the 
imports it doesn't find, thereby making the build fail

I'm sure there are other cases. My proposal is to have a 'Save (Skip On Save 
Actions)' entry in the menu. It's not needed that frequently, so there's no 
need for all the possible combinations (like save as/save all).

Another possibility is to have an enable/disable 'On Save' button on the 
toolbar. That would even allow skipping the actions for a 'Save All'.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1198) Dead link for "Developer builds" in README.md

2018-08-30 Thread Geertjan Wielenga (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597752#comment-16597752
 ] 

Geertjan Wielenga commented on NETBEANS-1198:
-

It's really a good idea to be on the 'dev' mailing list, go here for details:

https://netbeans.apache.org/community/mailing-lists.html

On the list, you would have seen this today:

https://lists.apache.org/thread.html/5886bac6bbc92889d5455796ba500cba6e27a3bf1b21efcde76996d6@%3Cdev.netbeans.apache.org%3E

> Dead link for "Developer builds" in README.md
> -
>
> Key: NETBEANS-1198
> URL: https://issues.apache.org/jira/browse/NETBEANS-1198
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: Next
> Environment: GitHub
>Reporter: Zach Hoffman
>Priority: Major
>
> The file in question (6a5e347 is the latest commit as of posting this issue): 
> [https://github.com/apache/incubator-netbeans/blob/6a5e347/README.md]
> It contains a link to developer builds:
>  >Developer builds can be downloaded from Developer builds can be downloaded 
> from 
> [https://builds.apache.org/job/incubator-netbeans-release/]
> That link does not work, so the README should be updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-1199) Unwanted wrapping after annotation if before type

2018-08-30 Thread Antonio Marques (JIRA)
Antonio Marques created NETBEANS-1199:
-

 Summary: Unwanted wrapping after annotation if before type
 Key: NETBEANS-1199
 URL: https://issues.apache.org/jira/browse/NETBEANS-1199
 Project: NetBeans
  Issue Type: Bug
  Components: editor - Formatting  Indentation
Affects Versions: 8.2
Reporter: Antonio Marques


* Go to *Preferences \ Editor \ Formatting \ Java \ Wrapping*
 * Select *Annotations: {color:#FF}Never{color}*
 * Go to a file with a line like

{{    public @Nullable String middleName;}}
 * Format either the line or the file
 * The line becomes split:{{}}

{{    public @Nullable}}

{{    }}{{String middleName;}}
 * If the annotation is before public rather than String, then the newline 
isn't inserted.

This may look minor, but requires having our source not the way we want to, so 
it's quite annoying.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-1198) Dead link for "Developer builds" in README.md

2018-08-30 Thread Zach Hoffman (JIRA)
Zach Hoffman created NETBEANS-1198:
--

 Summary: Dead link for "Developer builds" in README.md
 Key: NETBEANS-1198
 URL: https://issues.apache.org/jira/browse/NETBEANS-1198
 Project: NetBeans
  Issue Type: Bug
Affects Versions: Next
 Environment: GitHub
Reporter: Zach Hoffman


The file in question (6a5e347 is the latest commit as of posting this issue): 
[https://github.com/apache/incubator-netbeans/blob/6a5e347/README.md]

It contains a link to developer builds:


 >Developer builds can be downloaded from Developer builds can be downloaded 
 >from 
[https://builds.apache.org/job/incubator-netbeans-release/]

That link does not work, so the README should be updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-1021) use explicit params type throws exception for invalid lambda params types

2018-08-30 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-1021:
-
Labels: JDK11-VarInLambda pull-request-available  (was: JDK11-VarInLambda)

> use explicit params type throws exception for invalid lambda params types
> -
>
> Key: NETBEANS-1021
> URL: https://issues.apache.org/jira/browse/NETBEANS-1021
> Project: NetBeans
>  Issue Type: Task
>Reporter: Reema Taneja
>Assignee: Reema Taneja
>Priority: Minor
>  Labels: JDK11-VarInLambda, pull-request-available
>
> Use explicit parameters type hint throws below exception if lambda expression 
> uses a mix of explicit and implicit var type((support added in jdk11)) params.
> Eg. IntBinaryOperator op = (int x, var y) -> x+ y;
> If lambda expr params are like (int x, y), i.e. mix of explicit and implicit 
> params, Convert to 
> explicit type hint is not shown. 
> Investigate if we can convert to explicit type for all mixed types params 
> containing var type or hide the hint.
> Exception:
> java.lang.AssertionError: unexpected type: 
> at 
> jdk.compiler/com.sun.tools.javac.tree.TreeMaker.Type(TreeMaker.java:788)
> at 
> org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:800)
> at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1083)
> at 
> org.netbeans.modules.java.hints.suggestions.Lambda$AddExplicitLambdaParameterTypes.performRewrite(Lambda.java:627)
> at org.netbeans.spi.java.hints.JavaFix$1.process(JavaFix.java:171)
> at 
> org.netbeans.modules.java.hints.spiimpl.JavaFixImpl$1.run(JavaFixImpl.java:80)
> at 
> org.netbeans.modules.java.hints.spiimpl.JavaFixImpl$1.run(JavaFixImpl.java:74)
> at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:672)
> at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:662)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-1021) use explicit params type throws exception for invalid lambda params types

2018-08-30 Thread Reema Taneja (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reema Taneja updated NETBEANS-1021:
---
Description: 
Use explicit parameters type hint throws below exception if lambda expression 
uses a mix of explicit and implicit var type((support added in jdk11)) params.
Eg. IntBinaryOperator op = (int x, var y) -> x+ y;

If lambda expr params are like (int x, y), i.e. mix of explicit and implicit 
params, Convert to 
explicit type hint is not shown. 

Investigate if we can convert to explicit type for all mixed types params 
containing var type or hide the hint.

Exception:

java.lang.AssertionError: unexpected type: 
at 
jdk.compiler/com.sun.tools.javac.tree.TreeMaker.Type(TreeMaker.java:788)
at 
org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:800)
at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1083)
at 
org.netbeans.modules.java.hints.suggestions.Lambda$AddExplicitLambdaParameterTypes.performRewrite(Lambda.java:627)
at org.netbeans.spi.java.hints.JavaFix$1.process(JavaFix.java:171)
at 
org.netbeans.modules.java.hints.spiimpl.JavaFixImpl$1.run(JavaFixImpl.java:80)
at 
org.netbeans.modules.java.hints.spiimpl.JavaFixImpl$1.run(JavaFixImpl.java:74)
at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:672)
at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:662)


  was:
Convert to explicit type hint throws below exception if lambda expression uses 
a mix of explicit and implicit var type((support added in jdk11)) params.
Eg. IntBinaryOperator op = (int x, var y) -> x+ y;

If lambda expr params are like (int x, y), i.e. mix of explicit and implicit 
params, Convert to 
explicit type hint is not shown. 

Investigate if we can convert to explicit type for all mixed types params 
containing var type or hide the hint.

Exception:

java.lang.AssertionError: unexpected type: 
at 
jdk.compiler/com.sun.tools.javac.tree.TreeMaker.Type(TreeMaker.java:788)
at 
org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:800)
at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1083)
at 
org.netbeans.modules.java.hints.suggestions.Lambda$AddExplicitLambdaParameterTypes.performRewrite(Lambda.java:627)
at org.netbeans.spi.java.hints.JavaFix$1.process(JavaFix.java:171)
at 
org.netbeans.modules.java.hints.spiimpl.JavaFixImpl$1.run(JavaFixImpl.java:80)
at 
org.netbeans.modules.java.hints.spiimpl.JavaFixImpl$1.run(JavaFixImpl.java:74)
at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:672)
at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:662)



> use explicit params type throws exception for invalid lambda params types
> -
>
> Key: NETBEANS-1021
> URL: https://issues.apache.org/jira/browse/NETBEANS-1021
> Project: NetBeans
>  Issue Type: Task
>Reporter: Reema Taneja
>Assignee: Reema Taneja
>Priority: Minor
>  Labels: JDK11-VarInLambda
>
> Use explicit parameters type hint throws below exception if lambda expression 
> uses a mix of explicit and implicit var type((support added in jdk11)) params.
> Eg. IntBinaryOperator op = (int x, var y) -> x+ y;
> If lambda expr params are like (int x, y), i.e. mix of explicit and implicit 
> params, Convert to 
> explicit type hint is not shown. 
> Investigate if we can convert to explicit type for all mixed types params 
> containing var type or hide the hint.
> Exception:
> java.lang.AssertionError: unexpected type: 
> at 
> jdk.compiler/com.sun.tools.javac.tree.TreeMaker.Type(TreeMaker.java:788)
> at 
> org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:800)
> at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1083)
> at 
> org.netbeans.modules.java.hints.suggestions.Lambda$AddExplicitLambdaParameterTypes.performRewrite(Lambda.java:627)
> at org.netbeans.spi.java.hints.JavaFix$1.process(JavaFix.java:171)
> at 
> org.netbeans.modules.java.hints.spiimpl.JavaFixImpl$1.run(JavaFixImpl.java:80)
> at 
> org.netbeans.modules.java.hints.spiimpl.JavaFixImpl$1.run(JavaFixImpl.java:74)
> at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:672)
> at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:662)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:

[jira] [Updated] (NETBEANS-1021) use explicit params type throws exception for invalid lambda params types

2018-08-30 Thread Reema Taneja (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reema Taneja updated NETBEANS-1021:
---
Summary: use explicit params type throws exception for invalid lambda 
params types  (was: Convert to explicit type hint throws exception for invalid 
lambda params types)

> use explicit params type throws exception for invalid lambda params types
> -
>
> Key: NETBEANS-1021
> URL: https://issues.apache.org/jira/browse/NETBEANS-1021
> Project: NetBeans
>  Issue Type: Task
>Reporter: Reema Taneja
>Assignee: Reema Taneja
>Priority: Minor
>  Labels: JDK11-VarInLambda
>
> Convert to explicit type hint throws below exception if lambda expression 
> uses a mix of explicit and implicit var type((support added in jdk11)) params.
> Eg. IntBinaryOperator op = (int x, var y) -> x+ y;
> If lambda expr params are like (int x, y), i.e. mix of explicit and implicit 
> params, Convert to 
> explicit type hint is not shown. 
> Investigate if we can convert to explicit type for all mixed types params 
> containing var type or hide the hint.
> Exception:
> java.lang.AssertionError: unexpected type: 
> at 
> jdk.compiler/com.sun.tools.javac.tree.TreeMaker.Type(TreeMaker.java:788)
> at 
> org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:800)
> at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1083)
> at 
> org.netbeans.modules.java.hints.suggestions.Lambda$AddExplicitLambdaParameterTypes.performRewrite(Lambda.java:627)
> at org.netbeans.spi.java.hints.JavaFix$1.process(JavaFix.java:171)
> at 
> org.netbeans.modules.java.hints.spiimpl.JavaFixImpl$1.run(JavaFixImpl.java:80)
> at 
> org.netbeans.modules.java.hints.spiimpl.JavaFixImpl$1.run(JavaFixImpl.java:74)
> at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:672)
> at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:662)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists