[incubator-netbeans] 01/02: Jesse suggests to remove pre-loading of deprecated classes

2019-01-01 Thread jtulach
This is an automated email from the ASF dual-hosted git repository.

jtulach pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git

commit d647a4fc070b0aecd2883862cfcb7885a9462cf6
Author: Jaroslav Tulach 
AuthorDate: Wed Jan 2 06:26:08 2019 +0100

Jesse suggests to remove pre-loading of deprecated classes
---
 .../core.osgi/src/org/netbeans/core/osgi/OSGiRepository.java  | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/platform/core.osgi/src/org/netbeans/core/osgi/OSGiRepository.java 
b/platform/core.osgi/src/org/netbeans/core/osgi/OSGiRepository.java
index 2b18598..0b3f7a2 100644
--- a/platform/core.osgi/src/org/netbeans/core/osgi/OSGiRepository.java
+++ b/platform/core.osgi/src/org/netbeans/core/osgi/OSGiRepository.java
@@ -118,17 +118,6 @@ class OSGiRepository extends Repository {
 private static final class SFS extends MultiFileSystem implements 
LookupListener {
 
 static {
-try {
-// FELIX-2128
-Object _1 = 
Class.forName("org.openide.filesystems.FileSystem$Environment"); // NOI18N
-} catch (ClassNotFoundException ex) {
-// ignore
-}
-try {
-Object _2 = 
Class.forName("org.openide.filesystems.FileSystemCapability"); // NOI18N
-} catch (ClassNotFoundException ex) {
-// ignore
-}
 Object _3 = FileStatusListener.class;
 Object _4 = LookupEvent.class; // FELIX-3477
 }


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[incubator-netbeans] 02/02: Bringing Felix601 into the master

2019-01-01 Thread jtulach
This is an automated email from the ASF dual-hosted git repository.

jtulach pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git

commit 3354ccf577881ac8ac18e9e907b0f906f6c007f8
Merge: c451e08 d647a4f
Author: Jaroslav Tulach 
AuthorDate: Wed Jan 2 06:58:02 2019 +0100

Bringing Felix601 into the master

 .travis.yml|  2 +-
 .../src/org/netbeans/junit/MockServices.java   |  6 +-
 .../travis/check-line-endings.sh   |  0
 .../netbeans/core/netigso/EnabledAutoloadTest.java |  1 -
 .../org/netbeans/core/netigso/IntegrationTest.java |  1 -
 .../core/netigso/NetigsoUsesSwingTest.java |  1 -
 .../src/org/netbeans/core/netigso/NetigsoUtil.java |  7 --
 platform/core.osgi/nbproject/project.properties|  4 ++--
 platform/core.osgi/nbproject/project.xml   |  8 ---
 .../src/org/netbeans/core/osgi/OSGiRepository.java |  3 ---
 platform/libs.felix/external/binaries-list |  2 +-
 ...txt => org.apache.felix.main-6.0.1-license.txt} |  4 ++--
 txt => org.apache.felix.main-6.0.1-notice.txt} |  0
 platform/libs.felix/manifest.mf|  1 +
 platform/libs.felix/nbproject/project.properties   |  2 +-
 platform/libs.felix/nbproject/project.xml  |  4 ++--
 platform/libs.osgi/build.xml   | 25 --
 platform/libs.osgi/external/binaries-list  |  4 ++--
 .../{osgi-5.0-license.txt => osgi-7.0-license.txt} |  6 +++---
 platform/libs.osgi/manifest.mf |  2 +-
 platform/libs.osgi/nbproject/project.properties|  4 ++--
 platform/libs.osgi/nbproject/project.xml   |  8 +++
 .../org/netbeans/modules/netbinox/Netbinox.java| 12 +++
 23 files changed, 39 insertions(+), 68 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[incubator-netbeans] branch master updated (c451e08 -> 3354ccf)

2019-01-01 Thread jtulach
This is an automated email from the ASF dual-hosted git repository.

jtulach pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git.


from c451e08  [NETBEANS-731] Rename AutoHidingMenuBarManualTest to avoid a 
test failure. (#1067)
 add a7ba74b  Updating to Felix 6.0.1
 add c7e15b7  Removing dependency on compat8 filesystem JAR
 add 4be0d81  Hiding the travis scripts into nbbuild directory
 add b95c732  JDK11 prevents changing context classloader for certain 
threads
 new d647a4f  Jesse suggests to remove pre-loading of deprecated classes
 new 3354ccf  Bringing Felix601 into the master

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .travis.yml|  2 +-
 .../src/org/netbeans/junit/MockServices.java   |  6 +-
 .../travis/check-line-endings.sh   |  0
 .../netbeans/core/netigso/EnabledAutoloadTest.java |  1 -
 .../org/netbeans/core/netigso/IntegrationTest.java |  1 -
 .../core/netigso/NetigsoUsesSwingTest.java |  1 -
 .../src/org/netbeans/core/netigso/NetigsoUtil.java |  7 --
 platform/core.osgi/nbproject/project.properties|  4 ++--
 platform/core.osgi/nbproject/project.xml   |  8 ---
 .../src/org/netbeans/core/osgi/OSGiRepository.java |  3 ---
 platform/libs.felix/external/binaries-list |  2 +-
 ...txt => org.apache.felix.main-6.0.1-license.txt} |  4 ++--
 txt => org.apache.felix.main-6.0.1-notice.txt} |  0
 platform/libs.felix/manifest.mf|  1 +
 platform/libs.felix/nbproject/project.properties   |  2 +-
 platform/libs.felix/nbproject/project.xml  |  4 ++--
 platform/libs.osgi/build.xml   | 25 --
 platform/libs.osgi/external/binaries-list  |  4 ++--
 .../{osgi-5.0-license.txt => osgi-7.0-license.txt} |  6 +++---
 platform/libs.osgi/manifest.mf |  2 +-
 platform/libs.osgi/nbproject/project.properties|  4 ++--
 platform/libs.osgi/nbproject/project.xml   |  8 +++
 .../org/netbeans/modules/netbinox/Netbinox.java| 12 +++
 23 files changed, 39 insertions(+), 68 deletions(-)
 rename travis-check-line-endings.sh => nbbuild/travis/check-line-endings.sh 
(100%)
 rename platform/libs.felix/external/{org.apache.felix.main-4.2.1-license.txt 
=> org.apache.felix.main-6.0.1-license.txt} (99%)
 rename platform/libs.felix/external/{org.apache.felix.main-4.2.1-notice.txt => 
org.apache.felix.main-6.0.1-notice.txt} (100%)
 rename platform/libs.osgi/external/{osgi-5.0-license.txt => 
osgi-7.0-license.txt} (98%)


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[incubator-netbeans] branch master updated: [NETBEANS-731] Rename AutoHidingMenuBarManualTest to avoid a test failure. (#1067)

2019-01-01 Thread ebakke
This is an automated email from the ASF dual-hosted git repository.

ebakke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new c451e08  [NETBEANS-731] Rename AutoHidingMenuBarManualTest to avoid a 
test failure. (#1067)
c451e08 is described below

commit c451e080ec1da0b84c1893f5400d65ab5b042098
Author: Eirik Bakke 
AuthorDate: Wed Jan 2 01:54:26 2019 +0100

[NETBEANS-731] Rename AutoHidingMenuBarManualTest to avoid a test failure. 
(#1067)

This avoids a "No runnable methods" error while running tests in the 
core.windows package, due to the AutoHidingMenuBarManualTest class having a 
name that ends with "Test" but no test methods in it. The class in question is 
kept around for manual testing purposes only, and is not intended to be run 
automatically. See https://github.com/apache/incubator-netbeans/pull/1060 .
---
 .../src/org/netbeans/core/windows/view/ui/AutoHidingMenuBar.java| 2 ++
 ...ngMenuBarManualTest.java => AutoHidingMenuBarManualTestApp.java} | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git 
a/platform/core.windows/src/org/netbeans/core/windows/view/ui/AutoHidingMenuBar.java
 
b/platform/core.windows/src/org/netbeans/core/windows/view/ui/AutoHidingMenuBar.java
index 0f78c5b..eb1f18d 100644
--- 
a/platform/core.windows/src/org/netbeans/core/windows/view/ui/AutoHidingMenuBar.java
+++ 
b/platform/core.windows/src/org/netbeans/core/windows/view/ui/AutoHidingMenuBar.java
@@ -44,6 +44,8 @@ import javax.swing.event.ChangeEvent;
 import javax.swing.event.ChangeListener;
 import org.openide.util.Utilities;
 
+/* Note to developers: To manually test the behavior of this class without 
running the entire IDE,
+run AutoHidingMenuBarManualTestApp.java in the test sources. */
 /**
  * Container for logic that allows a {@link JFrame}'s {@link JMenuBar} to be 
hidden by default in
  * full screen mode, but shown again if the user moves the mouse to the top of 
the screen or invokes
diff --git 
a/platform/core.windows/test/unit/src/org/netbeans/core/windows/view/ui/AutoHidingMenuBarManualTest.java
 
b/platform/core.windows/test/unit/src/org/netbeans/core/windows/view/ui/AutoHidingMenuBarManualTestApp.java
similarity index 96%
rename from 
platform/core.windows/test/unit/src/org/netbeans/core/windows/view/ui/AutoHidingMenuBarManualTest.java
rename to 
platform/core.windows/test/unit/src/org/netbeans/core/windows/view/ui/AutoHidingMenuBarManualTestApp.java
index bbf4d93..e3a91c4 100644
--- 
a/platform/core.windows/test/unit/src/org/netbeans/core/windows/view/ui/AutoHidingMenuBarManualTest.java
+++ 
b/platform/core.windows/test/unit/src/org/netbeans/core/windows/view/ui/AutoHidingMenuBarManualTestApp.java
@@ -37,7 +37,7 @@ import javax.swing.UnsupportedLookAndFeelException;
  * A standalone Swing app that can be used to manually test {@link 
AutoHidingMenuBar} without
  * launching the full IDE. Tested on Windows 10. Not applicable to MacOS.
  */
-public final class AutoHidingMenuBarManualTest {
+public final class AutoHidingMenuBarManualTestApp {
 private final JFrame frame = new JFrame();
 private final JMenuBar mainMenuBar = new JMenuBar();
 
@@ -52,12 +52,12 @@ public final class AutoHidingMenuBarManualTest {
 {
 e.printStackTrace();
 }
-new AutoHidingMenuBarManualTest().setVisible(true);
+new AutoHidingMenuBarManualTestApp().setVisible(true);
 }
 });
 }
 
-public AutoHidingMenuBarManualTest() {
+public AutoHidingMenuBarManualTestApp() {
 initComponents();
 }
 


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-1794) Launch failure Ubuntu 18.04 & Netbeans

2019-01-01 Thread Richard Steele (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard Steele resolved NETBEANS-1794.
--
Resolution: Fixed

completely remove Netbeans 8 and follow link https://snapcraft.io/netbeans to 
install Apache Netbeans version 10.

> Launch failure Ubuntu 18.04 & Netbeans
> --
>
> Key: NETBEANS-1794
> URL: https://issues.apache.org/jira/browse/NETBEANS-1794
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 9.0
>Reporter: Richard Steele
>Assignee: Richard Steele
>Priority: Major
>
> After install netbeans completed, then launch get messages:
> netbeans
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by 
> org.netbeans.ProxyURLStreamHandlerFactory 
> (file:/usr/share/netbeans/platform18/lib/boot.jar) to field 
> java.net.URL.handler
> WARNING: Please consider reporting this to the maintainers of 
> org.netbeans.ProxyURLStreamHandlerFactory
> WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> Is there a missing JAVA package to be installed?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1794) Launch failure Ubuntu 18.04 & Netbeans

2019-01-01 Thread Richard Steele (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731638#comment-16731638
 ] 

Richard Steele commented on NETBEANS-1794:
--

All vestiges of Netbeans 8.1 should be removed or "uninstall" and then perform 
"sudo snap install netbeans --classic" to download Apache Netbeans 10 which 
will work.

> Launch failure Ubuntu 18.04 & Netbeans
> --
>
> Key: NETBEANS-1794
> URL: https://issues.apache.org/jira/browse/NETBEANS-1794
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 9.0
>Reporter: Richard Steele
>Assignee: Richard Steele
>Priority: Major
>
> After install netbeans completed, then launch get messages:
> netbeans
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by 
> org.netbeans.ProxyURLStreamHandlerFactory 
> (file:/usr/share/netbeans/platform18/lib/boot.jar) to field 
> java.net.URL.handler
> WARNING: Please consider reporting this to the maintainers of 
> org.netbeans.ProxyURLStreamHandlerFactory
> WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> Is there a missing JAVA package to be installed?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[incubator-netbeans] 01/01: Merge pull request #1058 from rkeen-siemens/NETBEANS-1834/Possible-race-fix

2019-01-01 Thread matthiasblaesing
This is an automated email from the ASF dual-hosted git repository.

matthiasblaesing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git

commit 1b509e1b3d585fd661f1811e322ae12316957152
Merge: c1c5403 8196fee
Author: Matthias Bläsing 
AuthorDate: Tue Jan 1 18:03:16 2019 +0100

Merge pull request #1058 from rkeen-siemens/NETBEANS-1834/Possible-race-fix

[NETBEANS-1834] Fix possible race condition enabling actions in explorer

 .../modules/openide/explorer/ExplorerActionsImpl.java | 15 ++-
 1 file changed, 10 insertions(+), 5 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[incubator-netbeans] branch master updated (c1c5403 -> 1b509e1)

2019-01-01 Thread matthiasblaesing
This is an automated email from the ASF dual-hosted git repository.

matthiasblaesing pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git.


from c1c5403  LessVerboseCreateLicenseSummary was approved
 add 8196fee  [NETBEANS-1834] Fix possible race condition when enabling 
actions in the explorer.
 new 1b509e1  Merge pull request #1058 from 
rkeen-siemens/NETBEANS-1834/Possible-race-fix

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../modules/openide/explorer/ExplorerActionsImpl.java | 15 ++-
 1 file changed, 10 insertions(+), 5 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-1834) Possible race condition in ExplorerActionsImpl

2019-01-01 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated NETBEANS-1834:
-
Labels: pull-request-available  (was: )

> Possible race condition in ExplorerActionsImpl
> --
>
> Key: NETBEANS-1834
> URL: https://issues.apache.org/jira/browse/NETBEANS-1834
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Explorer
>Affects Versions: 8.2
>Reporter: Rangi Keen
>Assignee: Rangi Keen
>Priority: Minor
>  Labels: pull-request-available
> Attachments: ExplorerActionsImpl.Race.patch
>
>
> {{ExplorerActionsImpl}} uses a background thread to determine the enabled 
> state of its actions. The background thread calls 
> {{ExplorerActionsImpl.BaseAction.toEnabled(boolean)}} to set the target state 
> from the background thread and then queues up a call on the {{EventQueue}} to 
> be run on the EDT that calls {{ExplorerActionsImpl.BaseAction.syncEnable()}} 
> which calls {{setEnabled}} if {{toEnable}} is non-null.
> However, since the check for {{toEnable != null}}, the use of {{toEnable}} in 
> the call to {{setEnabled}}, and the set of {{toEnable = null}} are all on 
> separate lines there is the possibility that another call to 
> {{toEnabled(boolean)}} will set {{toEnable}} after the call to {{setEnabled}} 
> but before it is reset to null. The end result is that if the new value of 
> {{toEnable}} was different from the one being acted upon, the action may end 
> up in the wrong state.
> One solution (in [^ExplorerActionsImpl.Race.patch]) is to use an 
> {{AtomicInteger}} to get the value of {{toEnable}} and set it to null (or 
> {{NO_CHANGE}}) atomically, thus avoiding the race condition.
> I don't have a reproducible case in the NetBeans IDE, but we encountered this 
> in our custom application using the NetBeans platform. The attached patch 
> solved the issue in our case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1803) Suppress SmoothScrollPaneUI.java reference in License file

2019-01-01 Thread JIRA


[ 
https://issues.apache.org/jira/browse/NETBEANS-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731551#comment-16731551
 ] 

Matthias Bläsing commented on NETBEANS-1803:


A PR is ready. Could you please have a look at it?

[https://github.com/apache/incubator-netbeans/pull/1054|https://github.com/apache/incubator-netbeans/pull/1054]

> Suppress SmoothScrollPaneUI.java reference in License file
> --
>
> Key: NETBEANS-1803
> URL: https://issues.apache.org/jira/browse/NETBEANS-1803
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: Next
>Reporter: John McDonnell
>Assignee: Matthias Bläsing
>Priority: Blocker
>  Labels: license, pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As part of PR881[1] a file was introduced into the Netbeans sources that came 
> from IntelliJ.
> IntelliJ is licensed with Apache License 2.0[2] and so possibly shouldn't be 
> included in the License file.  The Notice though should and is included in 
> the license file as expect.
>  
> Not blocking for an Incubation release.
> [1]: [https://github.com/apache/incubator-netbeans/pull/881]
> [2]: 
> [https://github.com/JetBrains/intellij-community/blob/34b9dfd0585937c3731e06a89554d1dc86f7f235/LICENSE.txt]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists