[jira] [Updated] (NETBEANS-1872) Background scan stalls on specific PHP file
[ https://issues.apache.org/jira/browse/NETBEANS-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junichi Yamamoto updated NETBEANS-1872: --- Component/s: (was: php - Code Analysis) > Background scan stalls on specific PHP file > --- > > Key: NETBEANS-1872 > URL: https://issues.apache.org/jira/browse/NETBEANS-1872 > Project: NetBeans > Issue Type: Bug > Components: editor - Parsing Indexing, ide - Performance >Affects Versions: 8.2, 10.0 >Reporter: Mondane >Priority: Major > Labels: background-scanning, php7 > Attachments: slider.phtml > > > I've come across a PHP-file which stalls the background scanning process. > How to reproduce: > * Download the attached file > * Create a new PHP 7.1 project with existing sources > ** Select the folder containing that one file > The background scan initiates and never stops. > History: > http://mail-archives.apache.org/mod_mbox/netbeans-users/201901.mbox/%3CCAB8E-LGcfjm7_91gRvt%3D8zKij8Eon6yG4aMw%3D7jbEij10Pd4vg%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1872) Background scan stalls on specific PHP file
[
https://issues.apache.org/jira/browse/NETBEANS-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795681#comment-16795681
]
Junichi Yamamoto commented on NETBEANS-1872:
Maybe, the following code has a problem:
{code:php}
@media screen and (-ms-high-contrast: active), screen and
(-ms-high-contrast: none) {
# .swiper-brand .am-image-wrapper,
# .swiper-brand .am-image-wrapper
img {
max-width: px;
}
# .swiper-brand .am-image-wrapper,
# .swiper-brand .am-image-wrapper
img {
max-width: px;
max-height: px;
}
}
{code}
I added your code to unit tests of PHP parser in my local environment. However,
I can't find errors. So CSS may have a problem.
> Background scan stalls on specific PHP file
> ---
>
> Key: NETBEANS-1872
> URL: https://issues.apache.org/jira/browse/NETBEANS-1872
> Project: NetBeans
> Issue Type: Bug
> Components: editor - Parsing Indexing, ide - Performance, php
> - Code Analysis
>Affects Versions: 8.2, 10.0
>Reporter: Mondane
>Priority: Major
> Labels: background-scanning, php7
> Attachments: slider.phtml
>
>
> I've come across a PHP-file which stalls the background scanning process.
> How to reproduce:
> * Download the attached file
> * Create a new PHP 7.1 project with existing sources
> ** Select the folder containing that one file
> The background scan initiates and never stops.
> History:
> http://mail-archives.apache.org/mod_mbox/netbeans-users/201901.mbox/%3CCAB8E-LGcfjm7_91gRvt%3D8zKij8Eon6yG4aMw%3D7jbEij10Pd4vg%40mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2084) Inline type hint order
[
https://issues.apache.org/jira/browse/NETBEANS-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795655#comment-16795655
]
Junichi Yamamoto commented on NETBEANS-2084:
AFAIR, NetBeans provides support for not
{code:php}
/* @var Class $variable */
{code}
but
{code:php}
/** @var Class $variable */
{code}
So, I won't fix it.
> Inline type hint order
> --
>
> Key: NETBEANS-2084
> URL: https://issues.apache.org/jira/browse/NETBEANS-2084
> Project: NetBeans
> Issue Type: Improvement
> Components: php - Editor
>Affects Versions: 10.0
>Reporter: Bo Andersen
>Priority: Major
>
> I have reported this in the 8.2, and thought it was fixed in a dev branch.
> But the issue is in Netbeans 10 as well.
> It is about the order of type hinting in the code, it does not match other
> IDE's
> Netbeans way:
> {code:java}
> /* @var $variable Class */
> {code}
> Other IDE:
> {code:java}
> /* @var Class $variable */
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1863) Exception after Insert Code (Alt Insert) is clicked
[
https://issues.apache.org/jira/browse/NETBEANS-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junichi Yamamoto updated NETBEANS-1863:
---
Component/s: (was: php - Editor)
javascript - Editor
> Exception after Insert Code (Alt Insert) is clicked
> ---
>
> Key: NETBEANS-1863
> URL: https://issues.apache.org/jira/browse/NETBEANS-1863
> Project: NetBeans
> Issue Type: Bug
> Components: javascript - Editor
>Affects Versions: 10.0
>Reporter: Ales Seifert
>Priority: Major
>
> When PHP class file is edited some methods are for example removed, file is
> saved and than user clicks on Insert Code it display empty dialog with just
> Cancel button.
> After few minutes when one processor core seems to be busy user can
> successfully try to open Insert Code dialog again.
> At the time when emty dialog is opened an exception appears in message.log:
> {noformat}
> INFO [org.netbeans.modules.javascript2.editor.parser.SanitizingParser]:
> Exception during parsing
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.AbstractStringBuilder.charAt(AbstractStringBuilder.java:237)
> at java.lang.StringBuilder.charAt(StringBuilder.java:76)
> at
> org.netbeans.modules.javascript2.editor.parser.SanitizingParser.isParsable(SanitizingParser.java:179)
> at
> org.netbeans.modules.javascript2.editor.parser.SanitizingParser.parseSource(SanitizingParser.java:112)
> [catch] at
> org.netbeans.modules.javascript2.editor.parser.SanitizingParser.parse(SanitizingParser.java:78)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor.callParse(TaskProcessor.java:598)
> at
> org.netbeans.modules.parsing.impl.SourceCache.getResult(SourceCache.java:228)
> at
> org.netbeans.modules.parsing.api.ResultIterator.getParserResult(ResultIterator.java:115)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$2.run(RepositoryUpdater.java:3171)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
> at
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
> at
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
> at
> org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
> at
> org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
> at
> org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
> at
> org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
> at
> org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.indexEmbedding(RepositoryUpdater.java:3143)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.doIndex(RepositoryUpdater.java:2862)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.access$800(RepositoryUpdater.java:2154)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2636)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2634)
> at
> org.netbeans.modules.parsing.impl.indexing.errors.TaskCache.refreshTransaction(TaskCache.java:540)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.index(RepositoryUpdater.java:2634)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$3.call(RepositoryUpdater.java:3300)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$3.call(RepositoryUpdater.java:3255)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$4.run(RepositoryUpdater.java:2127)
> at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runInContext(RepositoryUpdater.java:2123)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runInContext(RepositoryUpdater.java:2104)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.access$1500(RepositoryUpdater.java:136)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.scanFiles(RepositoryUpdater.java:3255)
> at
>
[jira] [Commented] (NETBEANS-1863) Exception after Insert Code (Alt Insert) is clicked
[
https://issues.apache.org/jira/browse/NETBEANS-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795661#comment-16795661
]
Junichi Yamamoto commented on NETBEANS-1863:
Could you please provide example code to reproduce it? It seems that this is a
problem of JavaScript area.
> Exception after Insert Code (Alt Insert) is clicked
> ---
>
> Key: NETBEANS-1863
> URL: https://issues.apache.org/jira/browse/NETBEANS-1863
> Project: NetBeans
> Issue Type: Bug
> Components: php - Editor
>Affects Versions: 10.0
>Reporter: Ales Seifert
>Priority: Major
>
> When PHP class file is edited some methods are for example removed, file is
> saved and than user clicks on Insert Code it display empty dialog with just
> Cancel button.
> After few minutes when one processor core seems to be busy user can
> successfully try to open Insert Code dialog again.
> At the time when emty dialog is opened an exception appears in message.log:
> {noformat}
> INFO [org.netbeans.modules.javascript2.editor.parser.SanitizingParser]:
> Exception during parsing
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.AbstractStringBuilder.charAt(AbstractStringBuilder.java:237)
> at java.lang.StringBuilder.charAt(StringBuilder.java:76)
> at
> org.netbeans.modules.javascript2.editor.parser.SanitizingParser.isParsable(SanitizingParser.java:179)
> at
> org.netbeans.modules.javascript2.editor.parser.SanitizingParser.parseSource(SanitizingParser.java:112)
> [catch] at
> org.netbeans.modules.javascript2.editor.parser.SanitizingParser.parse(SanitizingParser.java:78)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor.callParse(TaskProcessor.java:598)
> at
> org.netbeans.modules.parsing.impl.SourceCache.getResult(SourceCache.java:228)
> at
> org.netbeans.modules.parsing.api.ResultIterator.getParserResult(ResultIterator.java:115)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$2.run(RepositoryUpdater.java:3171)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
> at
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
> at
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
> at
> org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
> at
> org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
> at
> org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
> at
> org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
> at
> org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.indexEmbedding(RepositoryUpdater.java:3143)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.doIndex(RepositoryUpdater.java:2862)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.access$800(RepositoryUpdater.java:2154)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2636)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$1.run(RepositoryUpdater.java:2634)
> at
> org.netbeans.modules.parsing.impl.indexing.errors.TaskCache.refreshTransaction(TaskCache.java:540)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.index(RepositoryUpdater.java:2634)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$3.call(RepositoryUpdater.java:3300)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work$3.call(RepositoryUpdater.java:3255)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$4.run(RepositoryUpdater.java:2127)
> at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runInContext(RepositoryUpdater.java:2123)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.runInContext(RepositoryUpdater.java:2104)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater.access$1500(RepositoryUpdater.java:136)
> at
> org.netbeans.modules.parsing.impl.indexing.RepositoryUpdater$Work.scanFiles(RepositoryUpdater.java:3255)
>
[jira] [Commented] (NETBEANS-1901) Display bug on a space followed by a tab
[ https://issues.apache.org/jira/browse/NETBEANS-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795658#comment-16795658 ] Junichi Yamamoto commented on NETBEANS-1901: Could you please write example code, an actual result, and an expected result? > Display bug on a space followed by a tab > > > Key: NETBEANS-1901 > URL: https://issues.apache.org/jira/browse/NETBEANS-1901 > Project: NetBeans > Issue Type: Bug > Components: php - Editor, php - Formatting Indentation >Affects Versions: 10.0 > Environment: MacOS Mojave, Netbeans 10, iMac 5k, PHP7.1 >Reporter: Admeen >Priority: Minor > Labels: editor, formatting > Fix For: 10.0 > > Attachments: editor_bug_space_tab.png, formatting_settings.png > > > There appears to be a bug in the editor when a space is followed by a tab. > The editor does not display the space and tab, but the space and tab > characters are present in the file. > The editor / code formatting does not appear to be functioning correctly here. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2128) Moving a class
[ https://issues.apache.org/jira/browse/NETBEANS-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junichi Yamamoto updated NETBEANS-2128: --- Issue Type: New Feature (was: Bug) > Moving a class > -- > > Key: NETBEANS-2128 > URL: https://issues.apache.org/jira/browse/NETBEANS-2128 > Project: NetBeans > Issue Type: New Feature > Components: php - Editor >Affects Versions: 10.0 >Reporter: Bo Andersen >Priority: Major > Attachments: image-2019-02-17-20-25-10-953.png > > > It would be nice if we could move classes in Netbeans, to another > folder/namespace while Netbeans keeps the namespaces updated while > moving/refactoring. > But for now, I can't even move a class: > !image-2019-02-17-20-25-10-953.png! > (The Move refactoring cannot be applied in this context.) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2274) Options Dialog - Panel "Fonts & Colors" - Syntax Pane relies on undocumented ActionEvent#getModifiers behavior
[
https://issues.apache.org/jira/browse/NETBEANS-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Bläsing updated NETBEANS-2274:
---
Attachment: Bildschirmfoto_2019-03-18_21-59-36.png
Description:
In the Options Dialog, the Panel "Fonts & Colors" and there the subpanel Syntax
Pane relies on undocumented ActionEvent#getModifiers behavior.
The constructor of ActionEvent:
[https://docs.oracle.com/javase/8/docs/api/java/awt/event/ActionEvent.html#ActionEvent-java.lang.Object-int-java.lang.String-int-]
Only talks about modifier keys as parameter options:
{quote}{{modifiers}} - The modifier keys down during event (shift, ctrl, alt,
meta). Passing negative parameter is not recommended. Zero value means that no
modifiers were passed
{quote}
The code in the panel checks for the mask for mouse button 1:
{code:java}
if(evt.getModifiers() == InputEvent.BUTTON1_MASK) { // mouse clicked
updateLanguageCombobox();
}{code}
On Ubuntu 18.10, OpenJDK 1.8u191:
{noformat}
openjdk version "1.8.0_191"
OpenJDK Runtime Environment (build 1.8.0_191-8u191-b12-2ubuntu0.18.10.1-b12)
OpenJDK 64-Bit Server VM (build 25.191-b12, mixed mode){noformat}
As the keyboard handling for the ComboBox is also explicitly coded in the panel:
{code:java}
cbLanguage.addKeyListener(new java.awt.event.KeyAdapter() {
@Override
public void keyReleased(KeyEvent evt) {
if (evt.getKeyCode() == KeyEvent.VK_ENTER || evt.getKeyCode()
== KeyEvent.VK_SPACE) {
updateLanguageCombobox();
}
}
});{code}
Both special cases should be removed and replaced with the default combobox
behavior.
The attached screenshot shows the broken state (combobox content for language
does not match displayed language).
was:
In the Options Dialog, the Panel "Fonts & Colors" and there the subpanel Syntax
Pane relies on undocumented ActionEvent#getModifiers behavior.
The constructor of ActionEvent:
[https://docs.oracle.com/javase/8/docs/api/java/awt/event/ActionEvent.html#ActionEvent-java.lang.Object-int-java.lang.String-int-]
Only talks about modifier keys as parameter options:
{quote}{{modifiers}} - The modifier keys down during event (shift, ctrl, alt,
meta). Passing negative parameter is not recommended. Zero value means that no
modifiers were passed
{quote}
The code in the panel checks for the mask for mouse button 1:
{code:java}
if(evt.getModifiers() == InputEvent.BUTTON1_MASK) { // mouse clicked
updateLanguageCombobox();
}{code}
On Ubuntu 18.10, OpenJDK 1.8u191:
{noformat}
openjdk version "1.8.0_191"
OpenJDK Runtime Environment (build 1.8.0_191-8u191-b12-2ubuntu0.18.10.1-b12)
OpenJDK 64-Bit Server VM (build 25.191-b12, mixed mode){noformat}
As the keyboard handling for the ComboBox is also explicitly coded in the panel:
{code:java}
cbLanguage.addKeyListener(new java.awt.event.KeyAdapter() {
@Override
public void keyReleased(KeyEvent evt) {
if (evt.getKeyCode() == KeyEvent.VK_ENTER || evt.getKeyCode()
== KeyEvent.VK_SPACE) {
updateLanguageCombobox();
}
}
});{code}
Both special cases should be removed and replaced with the default combobox
behavior.
> Options Dialog - Panel "Fonts & Colors" - Syntax Pane relies on undocumented
> ActionEvent#getModifiers behavior
> --
>
> Key: NETBEANS-2274
> URL: https://issues.apache.org/jira/browse/NETBEANS-2274
> Project: NetBeans
> Issue Type: Bug
> Components: editor - Options
>Affects Versions: 11.0
>Reporter: Matthias Bläsing
>Assignee: Matthias Bläsing
>Priority: Major
> Attachments: Bildschirmfoto_2019-03-18_21-59-36.png
>
>
> In the Options Dialog, the Panel "Fonts & Colors" and there the subpanel
> Syntax Pane relies on undocumented ActionEvent#getModifiers behavior.
> The constructor of ActionEvent:
> [https://docs.oracle.com/javase/8/docs/api/java/awt/event/ActionEvent.html#ActionEvent-java.lang.Object-int-java.lang.String-int-]
> Only talks about modifier keys as parameter options:
> {quote}{{modifiers}} - The modifier keys down during event (shift, ctrl, alt,
> meta). Passing negative parameter is not recommended. Zero value means that
> no modifiers were passed
> {quote}
> The code in the panel checks for the mask for mouse button 1:
> {code:java}
> if(evt.getModifiers() == InputEvent.BUTTON1_MASK) { // mouse
> clicked
> updateLanguageCombobox();
> }{code}
> On Ubuntu 18.10, OpenJDK 1.8u191:
> {noformat}
> openjdk version "1.8.0_191"
> OpenJDK Runtime Environment (build
[jira] [Created] (NETBEANS-2274) Options Dialog - Panel "Fonts & Colors" - Syntax Pane relies on undocumented ActionEvent#getModifiers behavior
Matthias Bläsing created NETBEANS-2274:
--
Summary: Options Dialog - Panel "Fonts & Colors" - Syntax Pane
relies on undocumented ActionEvent#getModifiers behavior
Key: NETBEANS-2274
URL: https://issues.apache.org/jira/browse/NETBEANS-2274
Project: NetBeans
Issue Type: Bug
Components: editor - Options
Affects Versions: 11.0
Reporter: Matthias Bläsing
Assignee: Matthias Bläsing
In the Options Dialog, the Panel "Fonts & Colors" and there the subpanel Syntax
Pane relies on undocumented ActionEvent#getModifiers behavior.
The constructor of ActionEvent:
[https://docs.oracle.com/javase/8/docs/api/java/awt/event/ActionEvent.html#ActionEvent-java.lang.Object-int-java.lang.String-int-]
Only talks about modifier keys as parameter options:
{quote}{{modifiers}} - The modifier keys down during event (shift, ctrl, alt,
meta). Passing negative parameter is not recommended. Zero value means that no
modifiers were passed
{quote}
The code in the panel checks for the mask for mouse button 1:
{code:java}
if(evt.getModifiers() == InputEvent.BUTTON1_MASK) { // mouse clicked
updateLanguageCombobox();
}{code}
On Ubuntu 18.10, OpenJDK 1.8u191:
{noformat}
openjdk version "1.8.0_191"
OpenJDK Runtime Environment (build 1.8.0_191-8u191-b12-2ubuntu0.18.10.1-b12)
OpenJDK 64-Bit Server VM (build 25.191-b12, mixed mode){noformat}
As the keyboard handling for the ComboBox is also explicitly coded in the panel:
{code:java}
cbLanguage.addKeyListener(new java.awt.event.KeyAdapter() {
@Override
public void keyReleased(KeyEvent evt) {
if (evt.getKeyCode() == KeyEvent.VK_ENTER || evt.getKeyCode()
== KeyEvent.VK_SPACE) {
updateLanguageCombobox();
}
}
});{code}
Both special cases should be removed and replaced with the default combobox
behavior.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-747) CSS Editor does not recognize variable syntax
[ https://issues.apache.org/jira/browse/NETBEANS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795296#comment-16795296 ] Jack J. Woehr commented on NETBEANS-747: Excellent! > CSS Editor does not recognize variable syntax > - > > Key: NETBEANS-747 > URL: https://issues.apache.org/jira/browse/NETBEANS-747 > Project: NetBeans > Issue Type: Bug > Components: web - CSS Editor >Affects Versions: 8.2, 9.0, 10.0, 11.0 >Reporter: Peter >Assignee: Matthias Bläsing >Priority: Trivial > Labels: css, variable > Attachments: Screen Shot 2018-04-30 at 1.10.32 AM.png > > > Netbeans reports my css has error but it should not -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2273) Default mysql delimiter when editing stored procedures breaks procedures
[ https://issues.apache.org/jira/browse/NETBEANS-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Dayhoff updated NETBEANS-2273: Description: Summary: The default delimiter used when selecting `edit` on a stored procedure is `@@`. This is unsafe, because this string is used natively in mysql to select session variables (and occasionally global variables). Any stored procedure that works with session variables using the typical shorthand `select @@session.varname` breaks when re-inserting the stored procedure as is, because netbeans inserts `DELIMITER @@` at the beginning automatically, and further instances of `@@` as delimiters to close the stored procedure. This should be changed to `$$`, which has no native sql functionality. Steps to reproduce: Create a simple stored procedure that references a session value: ``` DELIMITER $$ DROP PROCEDURE IF EXISTS test $$ CREATE PROCEDURE test () proc:begin SELECT @@session.group_concat_max_len; END $$ DELIMITER ; ``` Run it: ``` CALL test(); – Runs clean ``` Select `edit` from the dropdown menu in services referencing the mysql database: services > Databases > test_database > Procedures > test > edit Execute the generated stored procedure text as is without any edits in the IDE, replacing the original (which should retain exact functionality) Run the procedure again: ``` CALL test(); – broken. ``` was: Summary: The default delimiter used when selecting `edit` on a stored procedure is `@@`. This is unsafe, because this string is used natively in mysql to select session variables (and occasionally global variables). Any stored procedure that works with session variables using the typical shorthand `select @@session.varname` breaks when re-inserting the stored procedure as is, because netbeans inserts `DELIMITER @@` at the beginning automatically, and further instances of `@@` as delimiters to close the stored procedure. This should be changed to `$$`, which has no native sql functionality. Steps to reproduce: Create a simple stored procedure that references a session value: ``` DELIMITER $$ DROP PROCEDURE IF EXISTS test $$ CREATE PROCEDURE test () proc:begin SELECT @@session.group_concat_max_len; END $$ DELIMITER ; ``` Run it: ``` CALL test(); – Runs clean ``` Select `edit` from the dropdown menu in services referencing the mysql database: services > Databases > test_database > Procedures > test > edit Execute the generated stored procedure text as is, replacing the original (which should retain exact functionality) Run the provided stored procedure without editing anything. Run the procedure again: ``` CALL test(); – broken. ``` > Default mysql delimiter when editing stored procedures breaks procedures > > > Key: NETBEANS-2273 > URL: https://issues.apache.org/jira/browse/NETBEANS-2273 > Project: NetBeans > Issue Type: Bug > Components: db - MySQL >Affects Versions: 8.2, 9.0, Next > Environment: Any version of netbeans with any version of mysql >Reporter: Brian Dayhoff >Priority: Minor > > Summary: > The default delimiter used when selecting `edit` on a stored procedure is > `@@`. This is unsafe, because this string is used natively in mysql to select > session variables (and occasionally global variables). Any stored procedure > that works with session variables using the typical shorthand `select > @@session.varname` breaks when re-inserting the stored procedure as is, > because netbeans inserts `DELIMITER @@` at the beginning automatically, and > further instances of `@@` as delimiters to close the stored procedure. This > should be changed to `$$`, which has no native sql functionality. > > Steps to reproduce: > > Create a simple stored procedure that references a session value: > ``` > DELIMITER $$ > DROP PROCEDURE IF EXISTS test $$ > CREATE PROCEDURE test () > proc:begin > SELECT @@session.group_concat_max_len; > END $$ > DELIMITER ; > ``` > > Run it: > ``` > CALL test(); – Runs clean > ``` > > Select `edit` from the dropdown menu in services referencing the mysql > database: > services > Databases > test_database > Procedures > test > edit > > Execute the generated stored procedure text as is without any edits in the > IDE, replacing the original (which should retain exact functionality) > > > Run the procedure again: > ``` > CALL test(); – broken. > ``` -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit:
[jira] [Updated] (NETBEANS-2273) Default mysql delimiter when editing stored procedures breaks procedures
[ https://issues.apache.org/jira/browse/NETBEANS-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Dayhoff updated NETBEANS-2273: Description: Summary: The default delimiter used when selecting `edit` on a stored procedure is `@@`. This is unsafe, because this string is used natively in mysql to select session variables (and occasionally global variables). Any stored procedure that works with session variables using the typical shorthand `select @@session.varname` breaks when re-inserting the stored procedure as is, because netbeans inserts `DELIMITER @@` at the beginning automatically, and further instances of `@@` as delimiters to close the stored procedure. This should be changed to `$$`, which has no native sql functionality. Steps to reproduce: Create a simple stored procedure that references a session value: ``` DELIMITER $$ DROP PROCEDURE IF EXISTS test $$ CREATE PROCEDURE test () proc:begin SELECT @@session.group_concat_max_len; END $$ DELIMITER ; ``` Run it: ``` CALL test(); – Runs clean ``` Select `edit` from the dropdown menu in services referencing the mysql database: services > Databases > test_database > Procedures > test > edit Execute the generated stored procedure text as is, replacing the original (which should retain exact functionality) Run the provided stored procedure without editing anything. Run the procedure again: ``` CALL test(); – broken. ``` was: Summary: The default delimiter used when selecting `edit` on a stored procedure is `@@`. This is unsafe, because this string is used natively in mysql to select session variables (and occasionally global variables). Any stored procedure that works with session variables using the typical shorthand `select @@session.varname` breaks when re-inserting the stored procedure as is, because netbeans inserts `DELIMITER @@` at the beginning automatically, and further instances of `@@` as delimiters to close the stored procedure. This should be changed to `$$`, which has no native sql functionality. Steps to reproduce: Create a simple stored procedure that references a session value: ``` DELIMITER $$ DROP PROCEDURE IF EXISTS test $$ CREATE PROCEDURE test () proc:begin SELECT @@session.group_concat_max_len; END $$ DELIMITER ; ``` Run it: ``` CALL test(); – Runs clean ``` Select `edit` from the dropdown menu in services referencing the mysql database: services > Databases > test_database > Procedures > test > edit Run the provided stored procedure without editing anything. Run the procedure again: ``` CALL test(); – broken. ``` > Default mysql delimiter when editing stored procedures breaks procedures > > > Key: NETBEANS-2273 > URL: https://issues.apache.org/jira/browse/NETBEANS-2273 > Project: NetBeans > Issue Type: Bug > Components: db - MySQL >Affects Versions: 8.2, 9.0, Next > Environment: Any version of netbeans with any version of mysql >Reporter: Brian Dayhoff >Priority: Minor > > Summary: > The default delimiter used when selecting `edit` on a stored procedure is > `@@`. This is unsafe, because this string is used natively in mysql to select > session variables (and occasionally global variables). Any stored procedure > that works with session variables using the typical shorthand `select > @@session.varname` breaks when re-inserting the stored procedure as is, > because netbeans inserts `DELIMITER @@` at the beginning automatically, and > further instances of `@@` as delimiters to close the stored procedure. This > should be changed to `$$`, which has no native sql functionality. > > Steps to reproduce: > > Create a simple stored procedure that references a session value: > ``` > DELIMITER $$ > DROP PROCEDURE IF EXISTS test $$ > CREATE PROCEDURE test () > proc:begin > SELECT @@session.group_concat_max_len; > END $$ > DELIMITER ; > ``` > > Run it: > ``` > CALL test(); – Runs clean > ``` > > Select `edit` from the dropdown menu in services referencing the mysql > database: > services > Databases > test_database > Procedures > test > edit > > Execute the generated stored procedure text as is, replacing the original > (which should retain exact functionality) > > Run the provided stored procedure without editing anything. > > Run the procedure again: > ``` > CALL test(); – broken. > ``` -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit:
[jira] [Created] (NETBEANS-2273) Default mysql delimiter when editing stored procedures breaks procedures
Brian Dayhoff created NETBEANS-2273: --- Summary: Default mysql delimiter when editing stored procedures breaks procedures Key: NETBEANS-2273 URL: https://issues.apache.org/jira/browse/NETBEANS-2273 Project: NetBeans Issue Type: Bug Components: db - MySQL Affects Versions: 9.0, 8.2, Next Environment: Any version of netbeans with any version of mysql Reporter: Brian Dayhoff Summary: The default delimiter used when selecting `edit` on a stored procedure is `@@`. This is unsafe, because this string is used natively in mysql to select session variables (and occasionally global variables). Any stored procedure that works with session variables using the typical shorthand `select @@session.varname` breaks when re-inserting the stored procedure as is, because netbeans inserts `DELIMITER @@` at the beginning automatically, and further instances of `@@` as delimiters to close the stored procedure. This should be changed to `$$`, which has no native sql functionality. Steps to reproduce: Create a simple stored procedure that references a session value: ``` DELIMITER $$ DROP PROCEDURE IF EXISTS test $$ CREATE PROCEDURE test () proc:begin SELECT @@session.group_concat_max_len; END $$ DELIMITER ; ``` Run it: ``` CALL test(); – Runs clean ``` Select `edit` from the dropdown menu in services referencing the mysql database: services > Databases > test_database > Procedures > test > edit Run the provided stored procedure without editing anything. Run the procedure again: ``` CALL test(); – broken. ``` -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-2246) Finalize offering of registered update centers
[ https://issues.apache.org/jira/browse/NETBEANS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiří Kovalský resolved NETBEANS-2246. - Resolution: Fixed Assignee: Laszlo Kishalmi Fix Version/s: 11.0 Merged to release110 branch as part of [https://github.com/apache/incubator-netbeans/pull/1168] > Finalize offering of registered update centers > -- > > Key: NETBEANS-2246 > URL: https://issues.apache.org/jira/browse/NETBEANS-2246 > Project: NetBeans > Issue Type: Bug > Components: updatecenters - Pluginportal >Affects Versions: 11.0 >Reporter: Jiří Kovalský >Assignee: Laszlo Kishalmi >Priority: Blocker > Labels: pull-request-available > Fix For: 11.0 > > Attachments: Bundle.txt, mf-layer.txt > > Time Spent: 2h 20m > Remaining Estimate: 0h > > The latest VC3 of Apache NetBeans IDE 11.0 contains 5 registered update > centers while only 1 is correct. The GA build should only contain the > following two entried by default: > * NetBeans Distribution [1] > * Plugin Portal [2] > [1] https://netbeans.apache.org/nb/updates/11.0/updates.xml.gz > [2] http://plugins.netbeans.org/nbpluginportal/updates/11.0/catalog.xml.gz > Please remove all the others. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2272) Transition plan should have some estimated dates
[ https://issues.apache.org/jira/browse/NETBEANS-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794920#comment-16794920 ] Geertjan Wielenga commented on NETBEANS-2272: - https://cwiki.apache.org/confluence/display/NETBEANS/Apache+NetBeans+Release+Roadmap > Transition plan should have some estimated dates > > > Key: NETBEANS-2272 > URL: https://issues.apache.org/jira/browse/NETBEANS-2272 > Project: NetBeans > Issue Type: Wish > Environment: transition plans >Reporter: Birger Skogeng Pedersen >Priority: Major > > I mostly stick to C++. So I'm eagerly awaiting the cnd implementation of > Apache Netbeans. Got some stuff I even want to try to contribute with in cnd. > > I'd like to see some estimated dates for when stuff is going to be ready with > Apache Netbeans. When can I expect the cnd plugin(s) to be ready to use in > Apache Netbeans? > > This doesn't mean all things with the transition should have strict **due > dates**, it just means that people like myself can have some idea of when > things might be ready with the transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2272) Transition plan should have some estimated dates
Birger Skogeng Pedersen created NETBEANS-2272: - Summary: Transition plan should have some estimated dates Key: NETBEANS-2272 URL: https://issues.apache.org/jira/browse/NETBEANS-2272 Project: NetBeans Issue Type: Wish Environment: transition plans Reporter: Birger Skogeng Pedersen I mostly stick to C++. So I'm eagerly awaiting the cnd implementation of Apache Netbeans. Got some stuff I even want to try to contribute with in cnd. I'd like to see some estimated dates for when stuff is going to be ready with Apache Netbeans. When can I expect the cnd plugin(s) to be ready to use in Apache Netbeans? This doesn't mean all things with the transition should have strict **due dates**, it just means that people like myself can have some idea of when things might be ready with the transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2246) Finalize offering of registered update centers
[ https://issues.apache.org/jira/browse/NETBEANS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794887#comment-16794887 ] Jiří Kovalský commented on NETBEANS-2246: - For the record, Laslo's changes look good except the unnecessary white spaces. As for master, it should contain two records. I will prepare a pull request for that. * NetBeans Distribution [1] * NetBeans Plugin Portal [2] [1] [https://builds.apache.org/job/incubator-netbeans-linux/lastSuccessfulBuild/artifact/nbbuild/nbms/updates.xml.gz] [2] [http://plugins.netbeans.org/nbpluginportal/updates/11.0/catalog-experimental.xml.gz] > Finalize offering of registered update centers > -- > > Key: NETBEANS-2246 > URL: https://issues.apache.org/jira/browse/NETBEANS-2246 > Project: NetBeans > Issue Type: Bug > Components: updatecenters - Pluginportal >Affects Versions: 11.0 >Reporter: Jiří Kovalský >Priority: Blocker > Labels: pull-request-available > Attachments: Bundle.txt, mf-layer.txt > > Time Spent: 2h 20m > Remaining Estimate: 0h > > The latest VC3 of Apache NetBeans IDE 11.0 contains 5 registered update > centers while only 1 is correct. The GA build should only contain the > following two entried by default: > * NetBeans Distribution [1] > * Plugin Portal [2] > [1] https://netbeans.apache.org/nb/updates/11.0/updates.xml.gz > [2] http://plugins.netbeans.org/nbpluginportal/updates/11.0/catalog.xml.gz > Please remove all the others. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-2246) Finalize offering of registered update centers
[
https://issues.apache.org/jira/browse/NETBEANS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793832#comment-16793832
]
Jiří Kovalský edited comment on NETBEANS-2246 at 3/18/19 9:41 AM:
--
Your changeset is missing {$netbeans.hash.code} with unique identifier of
NetBeans installation without which we won't be able to measure active users.
Also you are using Plugin Portal description instead of Distribution. Finally,
both PR should go into release branch, not master.
was (Author: jkovalsky):
Your changeset is missing {$netbeans.hash.code} with unique identifier or
NetBeans installation without which we won't be able to measure active users.
Also you are using Plugin Portal description instead of Distribution. Finally,
both PR should go into release branch, not master.
> Finalize offering of registered update centers
> --
>
> Key: NETBEANS-2246
> URL: https://issues.apache.org/jira/browse/NETBEANS-2246
> Project: NetBeans
> Issue Type: Bug
> Components: updatecenters - Pluginportal
>Affects Versions: 11.0
>Reporter: Jiří Kovalský
>Priority: Blocker
> Labels: pull-request-available
> Attachments: Bundle.txt, mf-layer.txt
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The latest VC3 of Apache NetBeans IDE 11.0 contains 5 registered update
> centers while only 1 is correct. The GA build should only contain the
> following two entried by default:
> * NetBeans Distribution [1]
> * Plugin Portal [2]
> [1] https://netbeans.apache.org/nb/updates/11.0/updates.xml.gz
> [2] http://plugins.netbeans.org/nbpluginportal/updates/11.0/catalog.xml.gz
> Please remove all the others.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
