[jira] [Commented] (NETBEANS-2607) NullPointerException at com.junichi11.netbeans.modules.color.codes.preview.ui.DrawingPanel.preferenceChange
[ https://issues.apache.org/jira/browse/NETBEANS-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849283#comment-16849283 ] Junichi Yamamoto commented on NETBEANS-2607: I've submitted it here: https://github.com/junichi11/netbeans-color-codes-preview/issues/28 > NullPointerException at > com.junichi11.netbeans.modules.color.codes.preview.ui.DrawingPanel.preferenceChange > --- > > Key: NETBEANS-2607 > URL: https://issues.apache.org/jira/browse/NETBEANS-2607 > Project: NetBeans > Issue Type: Bug > Components: platform - OptionsSettings >Affects Versions: 11.0 > Environment: Windows 10, 10.0, amd64. Java HotSpot(TM) 64-Bit Server > VM, 12.0.1+12, Java(TM) SE Runtime Environment, 12.0.1+12. Apache NetBeans > IDE 11.0 (Build incubator-netbeans-release-404-on-20190319). >Reporter: Peter Froud >Priority: Major > Attachments: IDE log.txt, UI log.txt > > > *What I was doing:* > # Opened Tools > Options > # In the Filter text field on the top right, typed 'web browser' and hit > enter > # Saw that the filter result was already displayed because the General tab > was already open > # Clicked on the Web Browser dropdown menu, which was set to Browser> > # The Options window closed on its own > Since then, I have not been able to reproduce the problem. Hope the attached > logs contain enough information to be helpful. > *Stack trace from IDE log:* > {{java.lang.NullPointerException}} > {{ at > com.junichi11.netbeans.modules.color.codes.preview.ui.DrawingPanel.preferenceChange(DrawingPanel.java:348)}} > {{ at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method)}} > {{ at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)}} > {{ at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)}} > {{ at java.base/java.lang.reflect.Method.invoke(Method.java:567)}} > {{ at > org.openide.util.WeakListenerImpl$ProxyListener.invoke(WeakListenerImpl.java:462)}} > {{ at com.sun.proxy.$Proxy15.preferenceChange(Unknown Source)}} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2606) NetBeans overallocating FileObject(s), jams up GC, hangs
[ https://issues.apache.org/jira/browse/NETBEANS-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849270#comment-16849270 ] Shevek commented on NETBEANS-2606: -- Nothing unusual, to be honest. I have my usual set of gradle projects open, I went away from my laptop last night, came back to the IDE this morning, and this was the situation. No triggering event that I know of. I vaguely remember hearing the fan running high late last night, so I'm going to guess this happened last night, rather than this morning. So I grabbed as much JVM metadata as I could, then killed it. Potential fix: There can't be 22 million files in the queue without duplicates; I don't have 22 million files. Potential fix: There must be a crossover point where one discards the entire file-change queue and just walks from scratch? > NetBeans overallocating FileObject(s), jams up GC, hangs > > > Key: NETBEANS-2606 > URL: https://issues.apache.org/jira/browse/NETBEANS-2606 > Project: NetBeans > Issue Type: Bug >Affects Versions: 11.0 >Reporter: Shevek >Priority: Major > Attachments: histo.txt, temp.txt > > > Ubuntu 19.04 > JDK1.8 > JVM stuck in ergonomics, caused by too many FileObjects in memory. > 10 threads sitting at 99% CPU, presumably mostly GC threads. > GUI not responding. > Note that this IDE JVM runs with 2.5Gb heap, and normally uses about 1.5Gb of > that, so something has gone seriously wrong. > num #instances #bytes class name > -- >1: 8839529 424297392 > org.netbeans.modules.masterfs.filebasedfs.fileobjects.BaseFileObj$FileEventImpl >2: 12383724 297209376 > java.util.concurrent.ConcurrentLinkedQueue$Node >3: 5520360 220814400 > org.openide.util.WeakListenerImpl$ListenerReference >4: 7963905 191133720 > org.openide.filesystems.FCLSupport$DispatchEventWrapperSingle >5: 5608373 179467936 java.lang.ref.WeakReference >6: 5404854 172955328 > org.openide.util.WeakListenerImpl$ProxyListener >7:123474 111203424 [B >8: 4419767 106074408 > org.openide.filesystems.FCLSupport$DispatchEventWrapperMulti >9: 5378746 86059936 com.sun.proxy.$Proxy1 > 10: 1929065 77162600 > org.netbeans.modules.masterfs.filebasedfs.fileobjects.FileObj > 11: 1992178 74673680 [Ljava.lang.Object; > 12:576632 74309864 [C > 13: 1403506 33684144 > org.openide.filesystems.EventControl$AtomicActionLink > 14: 1940678 31050848 javax.swing.event.EventListenerList > 15: 1403503 22456048 > org.netbeans.modules.masterfs.filebasedfs.fileobjects.FileObjectFactory$AsyncRefreshAtomicAction > At the point where we have over 22 million atomic refresh actions on the > queue, something has gone VERY WRONG - See NETBEANS-2291 - this particular > project has only about 200,000 files in it, so where do we get 22 million > file-refresh actions from? Backpressure on the queue, anyone? > Log messages: > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@55b26cab > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > null > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@2768760d > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@63f25c86 > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@34933167 > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@75ba9419 > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@1c699d1e > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@12ae60e3 > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > null > jstack attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail:
[jira] [Commented] (NETBEANS-2334) Code generating tasks or switching git branches break NetBeans
[ https://issues.apache.org/jira/browse/NETBEANS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849269#comment-16849269 ] Shevek commented on NETBEANS-2334: -- I suspect the fundamental issue I reported: Changing a lot of files on disk breaks NetBeans, is specifically related to generated files, and NOT specifically to Gradle. All the behaviour seems to suggest that checking out a Maven project and doing a heavy git branch-switch will also break NetBeans. > Code generating tasks or switching git branches break NetBeans > -- > > Key: NETBEANS-2334 > URL: https://issues.apache.org/jira/browse/NETBEANS-2334 > Project: NetBeans > Issue Type: Bug >Affects Versions: 10.0, 11.0 > Environment: OpenJDK Runtime Environment (build > 1.8.0_191-8u191-b12-2ubuntu0.18.10.1-b12) >Reporter: Shevek >Priority: Major > > If I have a gradle task which generates code, e.g. grpc, protobuf, thrift, > xjc, antlr, custom template-driven tasks, they remove and recreate a large > number of files under NB. NB then breaks: It goes into the 'background > scanning of projects' / 'scanning for external changes' of death and needs a > restart. > Alternatively, switching git branches will do the same. > A peculiar, possibly related effect is that NB can't see new classes I create > even when it's not apparently scanning, e.g. I create a class in a package, > but fix imports in another package can't import it until I restart netbeans. > I've disabled auto-scanning of sources, will see if that helps. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Closed] (NETBEANS-2607) NullPointerException at com.junichi11.netbeans.modules.color.codes.preview.ui.DrawingPanel.preferenceChange
[ https://issues.apache.org/jira/browse/NETBEANS-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junichi Yamamoto closed NETBEANS-2607. -- Resolution: Won't Fix Thanks for reporting it. However, It is a third party plugin. So please report it to the GitHub Issues of the plugin: https://github.com/junichi11/netbeans-color-codes-preview/issues > NullPointerException at > com.junichi11.netbeans.modules.color.codes.preview.ui.DrawingPanel.preferenceChange > --- > > Key: NETBEANS-2607 > URL: https://issues.apache.org/jira/browse/NETBEANS-2607 > Project: NetBeans > Issue Type: Bug > Components: platform - OptionsSettings >Affects Versions: 11.0 > Environment: Windows 10, 10.0, amd64. Java HotSpot(TM) 64-Bit Server > VM, 12.0.1+12, Java(TM) SE Runtime Environment, 12.0.1+12. Apache NetBeans > IDE 11.0 (Build incubator-netbeans-release-404-on-20190319). >Reporter: Peter Froud >Priority: Major > Attachments: IDE log.txt, UI log.txt > > > *What I was doing:* > # Opened Tools > Options > # In the Filter text field on the top right, typed 'web browser' and hit > enter > # Saw that the filter result was already displayed because the General tab > was already open > # Clicked on the Web Browser dropdown menu, which was set to Browser> > # The Options window closed on its own > Since then, I have not been able to reproduce the problem. Hope the attached > logs contain enough information to be helpful. > *Stack trace from IDE log:* > {{java.lang.NullPointerException}} > {{ at > com.junichi11.netbeans.modules.color.codes.preview.ui.DrawingPanel.preferenceChange(DrawingPanel.java:348)}} > {{ at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method)}} > {{ at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)}} > {{ at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)}} > {{ at java.base/java.lang.reflect.Method.invoke(Method.java:567)}} > {{ at > org.openide.util.WeakListenerImpl$ProxyListener.invoke(WeakListenerImpl.java:462)}} > {{ at com.sun.proxy.$Proxy15.preferenceChange(Unknown Source)}} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2371) Gradle projects not properly loaded
[ https://issues.apache.org/jira/browse/NETBEANS-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849267#comment-16849267 ] Shevek commented on NETBEANS-2371: -- See NETBEANS-2608 for a screenshot of my typical situation. Lou Hamersly describes the situation perfectly. > Gradle projects not properly loaded > --- > > Key: NETBEANS-2371 > URL: https://issues.apache.org/jira/browse/NETBEANS-2371 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: 11.0 > Environment: Netbeans 11 > Gradle 5 > Java 11 >Reporter: Netbeans User 2019 >Assignee: Laszlo Kishalmi >Priority: Major > Attachments: org-netbeans-modules-gradle-java.nbm > > > - gradle module (plugin) has problem to resolve dependencies in multi project > as seems I can removed reds only if I go over each one subproject and do > clean and build (clean and build on root has no affects) and additionally it > seems that for some test resources even this was not enough, but it seems > that works old trick so creation folder and adding some new class (possible > even delete) and possibly with including "refresh" from Action items window. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2608) Graphics: Can't tell when a project has an error
Shevek created NETBEANS-2608: Summary: Graphics: Can't tell when a project has an error Key: NETBEANS-2608 URL: https://issues.apache.org/jira/browse/NETBEANS-2608 Project: NetBeans Issue Type: Bug Affects Versions: 11.0 Reporter: Shevek Attachments: nb-gradle-icons.png I care about only one thing in the project summary: Does a project have an error. Look at the attached image, and tell me at a glance which subprojects have errors? I can't see because there's too much other noise in confusing colours. Please can you remove all unnecessary noise from the project icon EXCEPT red for error, and something NOT-in-the-red-spectrum for OK. The kind of dark orange coffee cup makes the icon totally useless. Imagine 200 of these icons on a 4K screen. I don't care if it's a gradle project or a maven project, whether anyone thinks it contains XML or EJBs, or is upside down or written in greek. I KNOW that stuff anyway, it's not a rapidly changing property of a project. What I want the IDE to tell me is "Does this contain an error". There's no other useful information there. Please note, just for the record: None of these subprojects have errors, it's a NetBeans synchronization or source-rescanning bug that it thinks they do. When I ask it to compile, it's fine. But that's not what this ticket is about. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2607) NullPointerException at com.junichi11.netbeans.modules.color.codes.preview.ui.DrawingPanel.preferenceChange
Peter Froud created NETBEANS-2607: - Summary: NullPointerException at com.junichi11.netbeans.modules.color.codes.preview.ui.DrawingPanel.preferenceChange Key: NETBEANS-2607 URL: https://issues.apache.org/jira/browse/NETBEANS-2607 Project: NetBeans Issue Type: Bug Components: platform - OptionsSettings Affects Versions: 11.0 Environment: Windows 10, 10.0, amd64. Java HotSpot(TM) 64-Bit Server VM, 12.0.1+12, Java(TM) SE Runtime Environment, 12.0.1+12. Apache NetBeans IDE 11.0 (Build incubator-netbeans-release-404-on-20190319). Reporter: Peter Froud Attachments: IDE log.txt, UI log.txt *What I was doing:* # Opened Tools > Options # In the Filter text field on the top right, typed 'web browser' and hit enter # Saw that the filter result was already displayed because the General tab was already open # Clicked on the Web Browser dropdown menu, which was set to # The Options window closed on its own Since then, I have not been able to reproduce the problem. Hope the attached logs contain enough information to be helpful. *Stack trace from IDE log:* {{java.lang.NullPointerException}} {{ at com.junichi11.netbeans.modules.color.codes.preview.ui.DrawingPanel.preferenceChange(DrawingPanel.java:348)}} {{ at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)}} {{ at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)}} {{ at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)}} {{ at java.base/java.lang.reflect.Method.invoke(Method.java:567)}} {{ at org.openide.util.WeakListenerImpl$ProxyListener.invoke(WeakListenerImpl.java:462)}} {{ at com.sun.proxy.$Proxy15.preferenceChange(Unknown Source)}} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-39) No code completion in Jade files while typing
[ https://issues.apache.org/jira/browse/NETBEANS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pete Whelpton resolved NETBEANS-39. --- Resolution: Fixed Fix Version/s: Next Should be fixed by https://github.com/apache/netbeans/pull/1261 > No code completion in Jade files while typing > - > > Key: NETBEANS-39 > URL: https://issues.apache.org/jira/browse/NETBEANS-39 > Project: NetBeans > Issue Type: Bug > Components: javascript - Jade >Affects Versions: 8.2 >Reporter: Christian Lenz >Priority: Major > Labels: pull-request-available > Fix For: Next > > Attachments: jade-no-code-completion.gif > > Time Spent: 0.5h > Remaining Estimate: 0h > > As you can see it in my screencapture, there is no code completion while > typing. It only appears after using ctrl + space, but I don't have to use it > in other languages. It should appear right after hitting one character. Only > after using <, the code completion for html is comming up immediately. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: Interpret profiles and property definitions from .mvn/maven.config when present
This is an automated email from the ASF dual-hosted git repository. matthiasblaesing pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new 5843ac5 Interpret profiles and property definitions from .mvn/maven.config when present 5843ac5 is described below commit 5843ac53892acbd5b768c60ebf9c2e0d5ca5 Author: Jesse Glick AuthorDate: Mon May 27 16:12:52 2019 -0400 Interpret profiles and property definitions from .mvn/maven.config when present --- .../netbeans/modules/maven/NbMavenProjectImpl.java | 7 ++- .../maven/modelcache/MavenProjectCache.java| 45 +++- .../modules/maven/NbMavenProjectImplTest.java | 62 -- 3 files changed, 109 insertions(+), 5 deletions(-) diff --git a/java/maven/src/org/netbeans/modules/maven/NbMavenProjectImpl.java b/java/maven/src/org/netbeans/modules/maven/NbMavenProjectImpl.java index fafa8d2..6acaab0 100644 --- a/java/maven/src/org/netbeans/modules/maven/NbMavenProjectImpl.java +++ b/java/maven/src/org/netbeans/modules/maven/NbMavenProjectImpl.java @@ -231,7 +231,12 @@ public final class NbMavenProjectImpl implements Project { @Override public File[] getFiles() { File homeFile = FileUtil.normalizeFile(MavenCli.userMavenConfigurationHome); -return new File[] {new File(projectFile.getParentFile(), "nb-configuration.xml"), projectFile, new File(homeFile, "settings.xml")}; //NOI18N +return new File[] { +new File(projectFile.getParentFile(), "nb-configuration.xml"), //NOI18N +projectFile, +new File(new File(projectFile.getParentFile(), ".mvn"), "maven.config"), //NOI18N +new File(homeFile, "settings.xml"), //NOI18N +}; } }); problemReporter = new ProblemReporterImpl(this); diff --git a/java/maven/src/org/netbeans/modules/maven/modelcache/MavenProjectCache.java b/java/maven/src/org/netbeans/modules/maven/modelcache/MavenProjectCache.java index 364e0ec..9905a16 100644 --- a/java/maven/src/org/netbeans/modules/maven/modelcache/MavenProjectCache.java +++ b/java/maven/src/org/netbeans/modules/maven/modelcache/MavenProjectCache.java @@ -19,16 +19,20 @@ package org.netbeans.modules.maven.modelcache; import java.io.File; +import java.io.IOException; import java.lang.ref.WeakReference; import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; +import java.util.Collections; import java.util.HashSet; +import java.util.Iterator; import java.util.List; import java.util.Map; import java.util.Properties; import java.util.Set; import java.util.WeakHashMap; +import java.util.function.BiConsumer; import java.util.logging.Level; import java.util.logging.Logger; import javax.swing.SwingUtilities; @@ -146,8 +150,27 @@ public final class MavenProjectCache { M2Configuration active = config.getActiveConfiguration(); MavenExecutionResult res = null; try { +FileObject mavenConfig = projectDir.getFileObject(".mvn/maven.config"); +List mavenConfigOpts = Collections.emptyList(); +if (mavenConfig != null && mavenConfig.isData()) { +mavenConfigOpts = Arrays.asList(mavenConfig.asText().split("\\s+")); +} final MavenExecutionRequest req = projectEmbedder.createMavenExecutionRequest(); req.addActiveProfiles(active.getActivatedProfiles()); +BiConsumer addActiveProfiles = (opt, prefix) -> req.addActiveProfiles(Arrays.asList(opt.substring(prefix.length()).split(","))); +Iterator optIt = mavenConfigOpts.iterator(); +while (optIt.hasNext()) { +String opt = optIt.next(); +// Could try to write/integrate a more general option parser here, +// but some options like -amd anyway violate GNU style. +if (opt.equals("-P") || opt.equals("--activate-profiles")) { +addActiveProfiles.accept(optIt.next(), ""); +} else if (opt.startsWith("-P")) { +addActiveProfiles.accept(opt, "-P"); +} else if (opt.startsWith("--activate-profiles=")) { +addActiveProfiles.accept(opt, "--activate-profiles="); +} +} req.setPom(pomFile); req.setNoSnapshotUpdates(true); @@ -161,6 +184,26 @@ public final class MavenProjectCache { req.setOffline(true); //#238800 important to merge, not replace Properties uprops = req.getUserProperties(); +BiConsumer setProperty = (opt, prefix) -> { +String value = opt.substring(prefix.length()); +int equals = value.indexOf('='); +if
[jira] [Commented] (NETBEANS-2606) NetBeans overallocating FileObject(s), jams up GC, hangs
[ https://issues.apache.org/jira/browse/NETBEANS-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849165#comment-16849165 ] Geertjan Wielenga commented on NETBEANS-2606: - Under what specific conditions, what actions have you taken, which project types. > NetBeans overallocating FileObject(s), jams up GC, hangs > > > Key: NETBEANS-2606 > URL: https://issues.apache.org/jira/browse/NETBEANS-2606 > Project: NetBeans > Issue Type: Bug >Affects Versions: 11.0 >Reporter: Shevek >Priority: Major > Attachments: histo.txt, temp.txt > > > Ubuntu 19.04 > JDK1.8 > JVM stuck in ergonomics, caused by too many FileObjects in memory. > 10 threads sitting at 99% CPU, presumably mostly GC threads. > GUI not responding. > Note that this IDE JVM runs with 2.5Gb heap, and normally uses about 1.5Gb of > that, so something has gone seriously wrong. > num #instances #bytes class name > -- >1: 8839529 424297392 > org.netbeans.modules.masterfs.filebasedfs.fileobjects.BaseFileObj$FileEventImpl >2: 12383724 297209376 > java.util.concurrent.ConcurrentLinkedQueue$Node >3: 5520360 220814400 > org.openide.util.WeakListenerImpl$ListenerReference >4: 7963905 191133720 > org.openide.filesystems.FCLSupport$DispatchEventWrapperSingle >5: 5608373 179467936 java.lang.ref.WeakReference >6: 5404854 172955328 > org.openide.util.WeakListenerImpl$ProxyListener >7:123474 111203424 [B >8: 4419767 106074408 > org.openide.filesystems.FCLSupport$DispatchEventWrapperMulti >9: 5378746 86059936 com.sun.proxy.$Proxy1 > 10: 1929065 77162600 > org.netbeans.modules.masterfs.filebasedfs.fileobjects.FileObj > 11: 1992178 74673680 [Ljava.lang.Object; > 12:576632 74309864 [C > 13: 1403506 33684144 > org.openide.filesystems.EventControl$AtomicActionLink > 14: 1940678 31050848 javax.swing.event.EventListenerList > 15: 1403503 22456048 > org.netbeans.modules.masterfs.filebasedfs.fileobjects.FileObjectFactory$AsyncRefreshAtomicAction > At the point where we have over 22 million atomic refresh actions on the > queue, something has gone VERY WRONG - See NETBEANS-2291 - this particular > project has only about 200,000 files in it, so where do we get 22 million > file-refresh actions from? Backpressure on the queue, anyone? > Log messages: > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@55b26cab > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > null > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@2768760d > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@63f25c86 > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@34933167 > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@75ba9419 > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@1c699d1e > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@12ae60e3 > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > null > jstack attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2334) Code generating tasks or switching git branches break NetBeans
[ https://issues.apache.org/jira/browse/NETBEANS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849164#comment-16849164 ] Geertjan Wielenga commented on NETBEANS-2334: - So this is specifically related to Gradle. > Code generating tasks or switching git branches break NetBeans > -- > > Key: NETBEANS-2334 > URL: https://issues.apache.org/jira/browse/NETBEANS-2334 > Project: NetBeans > Issue Type: Bug >Affects Versions: 10.0, 11.0 > Environment: OpenJDK Runtime Environment (build > 1.8.0_191-8u191-b12-2ubuntu0.18.10.1-b12) >Reporter: Shevek >Priority: Major > > If I have a gradle task which generates code, e.g. grpc, protobuf, thrift, > xjc, antlr, custom template-driven tasks, they remove and recreate a large > number of files under NB. NB then breaks: It goes into the 'background > scanning of projects' / 'scanning for external changes' of death and needs a > restart. > Alternatively, switching git branches will do the same. > A peculiar, possibly related effect is that NB can't see new classes I create > even when it's not apparently scanning, e.g. I create a class in a package, > but fix imports in another package can't import it until I restart netbeans. > I've disabled auto-scanning of sources, will see if that helps. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2606) NetBeans overallocating FileObject(s), jams up GC, hangs
[ https://issues.apache.org/jira/browse/NETBEANS-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849162#comment-16849162 ] Shevek commented on NETBEANS-2606: -- S0 S1 E O M CCSYGC YGCTFGCFGCT GCT LGCC GCC 0.00 0.00 100.00 99.98 77.01 66.56 11586 163.728 1031 5911.903 6075.631 Allocation Failure Ergonomics > NetBeans overallocating FileObject(s), jams up GC, hangs > > > Key: NETBEANS-2606 > URL: https://issues.apache.org/jira/browse/NETBEANS-2606 > Project: NetBeans > Issue Type: Bug >Affects Versions: 11.0 >Reporter: Shevek >Priority: Major > Attachments: histo.txt, temp.txt > > > Ubuntu 19.04 > JDK1.8 > JVM stuck in ergonomics, caused by too many FileObjects in memory. > 10 threads sitting at 99% CPU, presumably mostly GC threads. > GUI not responding. > Note that this IDE JVM runs with 2.5Gb heap, and normally uses about 1.5Gb of > that, so something has gone seriously wrong. > num #instances #bytes class name > -- >1: 8839529 424297392 > org.netbeans.modules.masterfs.filebasedfs.fileobjects.BaseFileObj$FileEventImpl >2: 12383724 297209376 > java.util.concurrent.ConcurrentLinkedQueue$Node >3: 5520360 220814400 > org.openide.util.WeakListenerImpl$ListenerReference >4: 7963905 191133720 > org.openide.filesystems.FCLSupport$DispatchEventWrapperSingle >5: 5608373 179467936 java.lang.ref.WeakReference >6: 5404854 172955328 > org.openide.util.WeakListenerImpl$ProxyListener >7:123474 111203424 [B >8: 4419767 106074408 > org.openide.filesystems.FCLSupport$DispatchEventWrapperMulti >9: 5378746 86059936 com.sun.proxy.$Proxy1 > 10: 1929065 77162600 > org.netbeans.modules.masterfs.filebasedfs.fileobjects.FileObj > 11: 1992178 74673680 [Ljava.lang.Object; > 12:576632 74309864 [C > 13: 1403506 33684144 > org.openide.filesystems.EventControl$AtomicActionLink > 14: 1940678 31050848 javax.swing.event.EventListenerList > 15: 1403503 22456048 > org.netbeans.modules.masterfs.filebasedfs.fileobjects.FileObjectFactory$AsyncRefreshAtomicAction > At the point where we have over 22 million atomic refresh actions on the > queue, something has gone VERY WRONG - See NETBEANS-2291 - this particular > project has only about 200,000 files in it, so where do we get 22 million > file-refresh actions from? Backpressure on the queue, anyone? > Log messages: > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@55b26cab > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > null > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@2768760d > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@63f25c86 > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@34933167 > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@75ba9419 > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@1c699d1e > WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > org.netbeans.modules.sampler.InternalSampler@12ae60e3 > WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread > null > jstack attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2334) Code generating tasks or switching git branches break NetBeans
[ https://issues.apache.org/jira/browse/NETBEANS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849161#comment-16849161 ] Shevek commented on NETBEANS-2334: -- Related: NETBEANS-2606 ? > Code generating tasks or switching git branches break NetBeans > -- > > Key: NETBEANS-2334 > URL: https://issues.apache.org/jira/browse/NETBEANS-2334 > Project: NetBeans > Issue Type: Bug >Affects Versions: 10.0, 11.0 > Environment: OpenJDK Runtime Environment (build > 1.8.0_191-8u191-b12-2ubuntu0.18.10.1-b12) >Reporter: Shevek >Priority: Major > > If I have a gradle task which generates code, e.g. grpc, protobuf, thrift, > xjc, antlr, custom template-driven tasks, they remove and recreate a large > number of files under NB. NB then breaks: It goes into the 'background > scanning of projects' / 'scanning for external changes' of death and needs a > restart. > Alternatively, switching git branches will do the same. > A peculiar, possibly related effect is that NB can't see new classes I create > even when it's not apparently scanning, e.g. I create a class in a package, > but fix imports in another package can't import it until I restart netbeans. > I've disabled auto-scanning of sources, will see if that helps. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2291) NetBeans is unusably slow
[ https://issues.apache.org/jira/browse/NETBEANS-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849159#comment-16849159 ] Shevek commented on NETBEANS-2291: -- See NETBEANS-2606 ? > NetBeans is unusably slow > - > > Key: NETBEANS-2291 > URL: https://issues.apache.org/jira/browse/NETBEANS-2291 > Project: NetBeans > Issue Type: Bug > Components: projects - Gradle >Affects Versions: 8.2, 10.0, 11.0 > Environment: Ubuntu 18.10 > Linux 4.18.0 > 12 core Xeon E-2176M with 64Gb RAM > -Xmx2536m (2.5Gb for NB, of which it uses about 1.7G) > NetBeans 10vc2, 10vc5, 8.2 > JDK 11.0.1 > JDK 1.8 > G1GC, CMS GC, Serial GC >Reporter: Shevek >Assignee: Laszlo Kishalmi >Priority: Critical > Labels: performance, usability > Attachments: nb-11-slow-hotspots.png, > netbeans-10vc5-jdk8-hang-gototype.txt.tdump, > netbeans-10vc5-jdk8-hang-progressutils.txt.tdump, > netbeans-10vc5-jdk8-hang.txt.tdump, open-file-slow-01.txt.tdump, > open-file-slow-02.txt.tdump, open-file-slow-03.txt.tdump, slow-stack-00.txt > > > I used to use NetBeans 8 on JDK8, it was tolerable, but slow. > Now I have a new laptop, I've tried nb8, nb10 on jdk8, jdk11, with g1gc, > cmsgc, other gc. They are all UNUSABLY slow. By which I mean, it takes over a > minute just to open a file. > Mostly this is because things are waiting for things waiting for very > inefficiently implemnted file I/O, editor parsing, or things like that. I've > watched a 12-core Xeon chip spend over 4 hours just attempting to handle the > Active Reference Queue Daemon thread. > The slowdown is somewhat incremental - I can escape it as long as I'm happy > to restart NetBeans every hour or so (which I'm not happy to do). > Attached a stack dump to get you started, this took over a minute to open a > 284-line Java file from idle. > Please feel free to ask all the obvious questions, although I'm fairly sure > all the obvious things have been done. Mostly, I've got GC down to a > negligible amount. > If there's one or more features of NetBeans I can disable to get acceptable > behaviour while still being able to realistically edit Java code, please tell > me and I will disable them because I am at the end of my rope after using > (and developing for) NetBeans for nearly 10 years. If I can get IntelliJ to > load a Java/Gradle project neatly before this gets fixed, I'm gone. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2606) NetBeans overallocating FileObject(s), jams up GC, hangs
Shevek created NETBEANS-2606: Summary: NetBeans overallocating FileObject(s), jams up GC, hangs Key: NETBEANS-2606 URL: https://issues.apache.org/jira/browse/NETBEANS-2606 Project: NetBeans Issue Type: Bug Affects Versions: 11.0 Reporter: Shevek Attachments: histo.txt, temp.txt Ubuntu 19.04 JDK1.8 JVM stuck in ergonomics, caused by too many FileObjects in memory. 10 threads sitting at 99% CPU, presumably mostly GC threads. GUI not responding. Note that this IDE JVM runs with 2.5Gb heap, and normally uses about 1.5Gb of that, so something has gone seriously wrong. num #instances #bytes class name -- 1: 8839529 424297392 org.netbeans.modules.masterfs.filebasedfs.fileobjects.BaseFileObj$FileEventImpl 2: 12383724 297209376 java.util.concurrent.ConcurrentLinkedQueue$Node 3: 5520360 220814400 org.openide.util.WeakListenerImpl$ListenerReference 4: 7963905 191133720 org.openide.filesystems.FCLSupport$DispatchEventWrapperSingle 5: 5608373 179467936 java.lang.ref.WeakReference 6: 5404854 172955328 org.openide.util.WeakListenerImpl$ProxyListener 7:123474 111203424 [B 8: 4419767 106074408 org.openide.filesystems.FCLSupport$DispatchEventWrapperMulti 9: 5378746 86059936 com.sun.proxy.$Proxy1 10: 1929065 77162600 org.netbeans.modules.masterfs.filebasedfs.fileobjects.FileObj 11: 1992178 74673680 [Ljava.lang.Object; 12:576632 74309864 [C 13: 1403506 33684144 org.openide.filesystems.EventControl$AtomicActionLink 14: 1940678 31050848 javax.swing.event.EventListenerList 15: 1403503 22456048 org.netbeans.modules.masterfs.filebasedfs.fileobjects.FileObjectFactory$AsyncRefreshAtomicAction At the point where we have over 22 million atomic refresh actions on the queue, something has gone VERY WRONG - See NETBEANS-2291 - this particular project has only about 200,000 files in it, so where do we get 22 million file-refresh actions from? Backpressure on the queue, anyone? Log messages: WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread org.netbeans.modules.sampler.InternalSampler@55b26cab WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread null WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread org.netbeans.modules.sampler.InternalSampler@2768760d WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread org.netbeans.modules.sampler.InternalSampler@63f25c86 WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread org.netbeans.modules.sampler.InternalSampler@34933167 WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread org.netbeans.modules.sampler.InternalSampler@75ba9419 WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread org.netbeans.modules.sampler.InternalSampler@1c699d1e WARNING [org.netbeans.core.TimableEventQueue]: no snapshot taken WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread org.netbeans.modules.sampler.InternalSampler@12ae60e3 WARNING [org.netbeans.core.TimableEventQueue]: too much time in AWT thread null jstack attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2605) Prioritize icons to vectorize for HiDPI support
[ https://issues.apache.org/jira/browse/NETBEANS-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eirik Bakke updated NETBEANS-2605: -- Description: As part of the higher-level [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements] to support HiDPI for the NetBeans IDE and for NetBeans Platform applications, a commonly used subset of icons should be recreated using the scalable SVG format (see NETBEANS-2604). As of 2019-05-27, there are 2740 unique files with extension 'png' or 'gif' in non-test sources in the [NetBeans codebase's master branch|https://github.com/apache/netbeans]. The page at https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these images. When there are multiple files with the same SHA256 checksum, only one is shown. With some practice, it takes on average 30 minutes to create an SVG version of a typical icon in Adobe Illustrator. See the attached illustration (and [this Illustrator template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]). Thus it's infeasible to do this for every icon in the codebase. Instead, icons commonly seen on the screen during a typical NetBeans IDE session should be prioritized. This issue tracks the task of providing a prioritized list of icons (with file names) for which we should try to provide SVG versions. For example, in prioritized order: # Every icon in the editor toolbar # Every icon in the application toolbar, with default NetBeans settings. # Icons used in the menu bar menus. # Any other icon seen on the screen when a blank NetBeans IDE installation is started up. # Icons shown in the Projects pane when working with a simple Java project. # Icons shown in the Projects pane when working with a Java project in a git repository. # etc. was: As part of the higher-level [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements] to support HiDPI for the NetBeans IDE and for NetBeans Platform applications, a commonly used subset of icons should be recreated using the scalable SVG format (see NETBEANS-2604). As of 2019-05-27, there are 2740 unique files with extension 'png' or 'gif' in non-test sources in the [NetBeans codebase's master branch|https://github.com/apache/netbeans]. The page at https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these images. When there are multiple files with the same SHA256 checksum, only one is shown. With some practice, it takes on average 30 minutes to create an SVG version of a typical icon in Adobe Illustrator. See the attached illustration (and [this Illustrator template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]). Thus it's infeasible to do this for every icon in the codebase. Instead, icons commonly seen on the screen during a typical NetBeans IDE session should be prioritized. This issue tracks the task of providing a prioritized list of icons for which we should try to provide SVG versions. > Prioritize icons to vectorize for HiDPI support > --- > > Key: NETBEANS-2605 > URL: https://issues.apache.org/jira/browse/NETBEANS-2605 > Project: NetBeans > Issue Type: Improvement > Components: platform - Other >Affects Versions: 11.0 >Reporter: Eirik Bakke >Priority: Major > Labels: HiDPI > Attachments: effort_required.png > > > As part of the higher-level > [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements] > to support HiDPI for the NetBeans IDE and for NetBeans Platform > applications, a commonly used subset of icons should be recreated using the > scalable SVG format (see NETBEANS-2604). > As of 2019-05-27, there are 2740 unique files with extension 'png' or 'gif' > in non-test sources in the [NetBeans codebase's master > branch|https://github.com/apache/netbeans]. The page at > https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these > images. When there are multiple files with the same SHA256 checksum, only one > is shown. > With some practice, it takes on average 30 minutes to create an SVG version > of a typical icon in Adobe Illustrator. See the attached illustration (and > [this Illustrator > template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]). > Thus it's infeasible to do this for every icon in the codebase. Instead, > icons commonly seen on the screen during a typical NetBeans IDE session > should be prioritized. > This issue tracks the task of providing a prioritized list of icons (with > file names) for which we should try to provide SVG versions. For example, in > prioritized order: > # Every icon in the
[jira] [Commented] (NETBEANS-2398) Netbeans 11 + web.xml = Cannot find declaration of element 'web-app'
[ https://issues.apache.org/jira/browse/NETBEANS-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849076#comment-16849076 ] Pete Whelpton commented on NETBEANS-2398: - Should be / hopefully is fixed by: [https://github.com/apache/netbeans/pull/1266] > Netbeans 11 + web.xml = Cannot find declaration of element 'web-app' > > > Key: NETBEANS-2398 > URL: https://issues.apache.org/jira/browse/NETBEANS-2398 > Project: NetBeans > Issue Type: Bug > Components: javaee - Web Project >Affects Versions: 11.0 > Environment: Windows 10 64-Bit OpenJDK 11.0.2 (also tested with same > results using Oracle JDK 8). >Reporter: Ryan >Priority: Major > Attachments: Screenshot.png > > > I'm taking Netbeans 11 for a spin and now see my project web.xml file has red > x in bottom corner of Projects window icon. Everything seems to work fine > despite the validation error. If I open project in Netbeans 8.2 no issue. > The hover (tooltip) message is: > {quote} > cvc-elt.1.a: Cannot find the declaration of element 'web-app' > > {quote} > If I right click on web.xml file in Projects window and click Validate XML > the error is displayed in the Output window along with: > {quote}schema_reference.4: Failed to read schema document > 'nbres:/org/netbeans/modules/j2ee/ddloaders/catalog/resources/web-app_3_1.xsd', > because 1) could not find the document; 2) the document could not be read; > 3) the root element of the document is not > {quote} > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2605) Prioritize icons to vectorize for HiDPI support
[ https://issues.apache.org/jira/browse/NETBEANS-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eirik Bakke updated NETBEANS-2605: -- Description: As part of the higher-level [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements] to support HiDPI for the NetBeans IDE and for NetBeans Platform applications, a commonly used subset of icons should be recreated using the scalable SVG format (see NETBEANS-2604). As of 2019-05-27, there are 2740 unique files with extension 'png' or 'gif' in non-test sources in the NetBeans codebase's master branch. The page at https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these images. When there are multiple files with the same SHA256 checksum, only one is shown. With some practice, it takes on average 30 minutes to create an SVG version of a typical icon in Adobe Illustrator. See the attached illustration (and [this Illustrator template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]). Thus it's infeasible to do this for every icon in the codebase. Instead, icons commonly seen on the screen during a typical NetBeans IDE session should be prioritized. This issue tracks the task of providing a prioritized list of icons for which we should try to provide SVG versions. was: As part of the higher-level [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements] to support HiDPI for the NetBeans IDE and for NetBeans Platform applications, a commonly used subset of icons should be recreated using the scalable SVG format. As of 2019-05-27, there are 2740 unique files with extension 'png' or 'gif' in non-test sources in the NetBeans codebase's master branch. The page at https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these images. When there are multiple files with the same SHA256 checksum, only one is shown. With some practice, it takes on average 30 minutes to create an SVG version of a typical icon in Adobe Illustrator. See the attached illustration (and [this Illustrator template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]). Thus it's infeasible to do this for every icon in the codebase. Instead, icons commonly seen on the screen during a typical NetBeans IDE session should be prioritized. This issue tracks the task of providing a prioritized list of icons for which we should try to provide SVG versions. > Prioritize icons to vectorize for HiDPI support > --- > > Key: NETBEANS-2605 > URL: https://issues.apache.org/jira/browse/NETBEANS-2605 > Project: NetBeans > Issue Type: Improvement > Components: platform - Other >Affects Versions: 11.0 >Reporter: Eirik Bakke >Priority: Major > Labels: HiDPI > Attachments: effort_required.png > > > As part of the higher-level > [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements] > to support HiDPI for the NetBeans IDE and for NetBeans Platform > applications, a commonly used subset of icons should be recreated using the > scalable SVG format (see NETBEANS-2604). > As of 2019-05-27, there are 2740 unique files with extension 'png' or 'gif' > in non-test sources in the NetBeans codebase's master branch. The page at > https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these > images. When there are multiple files with the same SHA256 checksum, only one > is shown. > With some practice, it takes on average 30 minutes to create an SVG version > of a typical icon in Adobe Illustrator. See the attached illustration (and > [this Illustrator > template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]). > Thus it's infeasible to do this for every icon in the codebase. Instead, > icons commonly seen on the screen during a typical NetBeans IDE session > should be prioritized. > This issue tracks the task of providing a prioritized list of icons for which > we should try to provide SVG versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2605) Prioritize icons to vectorize for HiDPI support
[ https://issues.apache.org/jira/browse/NETBEANS-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eirik Bakke updated NETBEANS-2605: -- Description: As part of the higher-level [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements] to support HiDPI for the NetBeans IDE and for NetBeans Platform applications, a commonly used subset of icons should be recreated using the scalable SVG format. As of 2019-05-27, there are 2740 unique files with extension 'png' or 'gif' in non-test sources in the NetBeans codebase's master branch. The page at https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these images. When there are multiple files with the same SHA256 checksum, only one is shown. With some practice, it takes on average 30 minutes to create an SVG version of a typical icon in Adobe Illustrator. See the attached illustration (and [this Illustrator template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]). Thus it's infeasible to do this for every icon in the codebase. Instead, icons commonly seen on the screen during a typical NetBeans IDE session should be prioritized. This issue tracks the task of providing a prioritized list of icons for which we should try to provide SVG versions. was: As part of the higher-level [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements] to support HiDPI for the NetBeans IDE and for NetBeans Platform applications, a commonly used subset of icons should be recreated using the scalable SVG format. As of 2019-05-27, there are 2740 unique files named '*.png' or '*.gif' in non-test sources in the NetBeans codebase's master branch. The page at https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these images. When there are multiple files with the same SHA256 checksum, only one is shown. With some practice, it takes on average 30 minutes to create an SVG version of a typical icon in Adobe Illustrator. See the attached illustration (and [this Illustrator template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]). Thus it's infeasible to do this for every icon in the codebase. Instead, icons commonly seen on the screen during a typical NetBeans IDE session should be prioritized. This issue tracks the task of providing a prioritized list of icons for which we should try to provide SVG versions. > Prioritize icons to vectorize for HiDPI support > --- > > Key: NETBEANS-2605 > URL: https://issues.apache.org/jira/browse/NETBEANS-2605 > Project: NetBeans > Issue Type: Improvement > Components: platform - Other >Affects Versions: 11.0 >Reporter: Eirik Bakke >Priority: Major > Attachments: effort_required.png > > > As part of the higher-level > [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements] > to support HiDPI for the NetBeans IDE and for NetBeans Platform > applications, a commonly used subset of icons should be recreated using the > scalable SVG format. > As of 2019-05-27, there are 2740 unique files with extension 'png' or 'gif' > in non-test sources in the NetBeans codebase's master branch. The page at > https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these > images. When there are multiple files with the same SHA256 checksum, only one > is shown. > With some practice, it takes on average 30 minutes to create an SVG version > of a typical icon in Adobe Illustrator. See the attached illustration (and > [this Illustrator > template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]). > Thus it's infeasible to do this for every icon in the codebase. Instead, > icons commonly seen on the screen during a typical NetBeans IDE session > should be prioritized. > This issue tracks the task of providing a prioritized list of icons for which > we should try to provide SVG versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2605) Prioritize icons to vectorize for HiDPI support
[ https://issues.apache.org/jira/browse/NETBEANS-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eirik Bakke updated NETBEANS-2605: -- Labels: HiDPI (was: ) > Prioritize icons to vectorize for HiDPI support > --- > > Key: NETBEANS-2605 > URL: https://issues.apache.org/jira/browse/NETBEANS-2605 > Project: NetBeans > Issue Type: Improvement > Components: platform - Other >Affects Versions: 11.0 >Reporter: Eirik Bakke >Priority: Major > Labels: HiDPI > Attachments: effort_required.png > > > As part of the higher-level > [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements] > to support HiDPI for the NetBeans IDE and for NetBeans Platform > applications, a commonly used subset of icons should be recreated using the > scalable SVG format. > As of 2019-05-27, there are 2740 unique files with extension 'png' or 'gif' > in non-test sources in the NetBeans codebase's master branch. The page at > https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these > images. When there are multiple files with the same SHA256 checksum, only one > is shown. > With some practice, it takes on average 30 minutes to create an SVG version > of a typical icon in Adobe Illustrator. See the attached illustration (and > [this Illustrator > template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]). > Thus it's infeasible to do this for every icon in the codebase. Instead, > icons commonly seen on the screen during a typical NetBeans IDE session > should be prioritized. > This issue tracks the task of providing a prioritized list of icons for which > we should try to provide SVG versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2172) web.xml issue creating a webapp with java server faces
[ https://issues.apache.org/jira/browse/NETBEANS-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-2172: - Labels: pull-request-available (was: ) > web.xml issue creating a webapp with java server faces > -- > > Key: NETBEANS-2172 > URL: https://issues.apache.org/jira/browse/NETBEANS-2172 > Project: NetBeans > Issue Type: Bug > Components: javaee - Web Project >Affects Versions: 11.0 > Environment: Product Version: Apache NetBeans IDE Dev (Build > incubator-netbeans-release-384-on-20190213) > Java: 12; OpenJDK 64-Bit Server VM 12+32 > Runtime: OpenJDK Runtime Environment 12+32 > System: Windows 10 version 10.0 running on amd64; Cp1252; en_US (nb) >Reporter: Giuseppe Tino >Priority: Major > Labels: pull-request-available > > Steps to reproduce: > # Create a new "Maven / Web Application" project: > ** "Project Name": {{firstcup}} > ** "Server": {{GlassFish Server 5.0}} > ** "Java EE Version": {{Java EE 7 Web}} > ** "Context Path": {{/firstcup}} > # After the project is created, invoke pop-up menu on it's root node and > select *Properties*. > # Select the "Frameworks" category in the "Project Properties" manager. > # Push the *Add...* button and choose "JavaServer Faces" framework. > # In "Configuration" tab, set "JSF Servlet URL Pattern" to: > {{/firstcupWeb/*}} and push *OK*. > # Delete generated web pages. > Expected result: > * The project is created and no errors are displayed > Actual result: > * In the project panel the file Web pages > WEB-INF > web.xml is marked with > a red x. On mouse hover the following message is shown "cvc-elt.1.a: Cannot > find the declaration of element 'web-app'. " -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2605) Prioritize icons to vectorize for HiDPI support
Eirik Bakke created NETBEANS-2605: - Summary: Prioritize icons to vectorize for HiDPI support Key: NETBEANS-2605 URL: https://issues.apache.org/jira/browse/NETBEANS-2605 Project: NetBeans Issue Type: Improvement Components: platform - Other Affects Versions: 11.0 Reporter: Eirik Bakke Attachments: effort_required.png As part of the higher-level [effort|https://cwiki.apache.org/confluence/display/NETBEANS/HiDPI+%28Retina%29+improvements] to support HiDPI for the NetBeans IDE and for NetBeans Platform applications, a commonly used subset of icons should be recreated using the scalable SVG format. As of 2019-05-27, there are 2740 unique files named '*.png' or '*.gif' in non-test sources in the NetBeans codebase's master branch. The page at https://people.csail.mit.edu/ebakke/misc/netbeans-icons shows all of these images. When there are multiple files with the same SHA256 checksum, only one is shown. With some practice, it takes on average 30 minutes to create an SVG version of a typical icon in Adobe Illustrator. See the attached illustration (and [this Illustrator template|https://people.csail.mit.edu/ebakke/misc/netbeans-icons/netbeans_icons_illustrator_template.ai]). Thus it's infeasible to do this for every icon in the codebase. Instead, icons commonly seen on the screen during a typical NetBeans IDE session should be prioritized. This issue tracks the task of providing a prioritized list of icons for which we should try to provide SVG versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-1586) Make ImageUtilities.createDisabledIcon work with HiDPI icons
[ https://issues.apache.org/jira/browse/NETBEANS-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eirik Bakke reassigned NETBEANS-1586: - Assignee: Eirik Bakke > Make ImageUtilities.createDisabledIcon work with HiDPI icons > > > Key: NETBEANS-1586 > URL: https://issues.apache.org/jira/browse/NETBEANS-1586 > Project: NetBeans > Issue Type: Improvement > Components: platform - Other >Affects Versions: Next > Environment: Windows, Linux, MacOS >Reporter: Eirik Bakke >Assignee: Eirik Bakke >Priority: Major > Labels: HiDPI, pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > After the introduction of the org.openide.util.VectorIcon class in > https://github.com/apache/incubator-netbeans/pull/859 , > ImageUtilities.createDisabledIcon should be updated to work with such > resolution-independent icons, as well as ImageIcon instances that delegate to > a MultiResolutionImage. I have a patch ready that will fix this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-2604) Support SVG icon loading from ImageUtilities
[ https://issues.apache.org/jira/browse/NETBEANS-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eirik Bakke reassigned NETBEANS-2604: - Assignee: Eirik Bakke > Support SVG icon loading from ImageUtilities > > > Key: NETBEANS-2604 > URL: https://issues.apache.org/jira/browse/NETBEANS-2604 > Project: NetBeans > Issue Type: Improvement > Components: platform - Other >Affects Versions: 11.0 > Environment: Windows, MacOS, and Linux. >Reporter: Eirik Bakke >Assignee: Eirik Bakke >Priority: Major > Labels: HiDPI > > Support SVG image loading from ImageUtilities, primarily for icons. This > would be implemented as a special subclass of javax.swing.Icon, rather than > through MultiResolutionImage. Eirik Bakke already has most of this code ready. > Motivation: To look good on HiDPI/Retina displays, the NetBeans IDE, and > NetBeans Platform (RCP) applications, will eventually need to provide > high-resolution versions of various image asset (typically icons). Two > approaches are possible: (1) allow each icon to be supplied as multiple > bitmap (i.e. PNG) files, one for each resolution, or (2) allow each icon to > be supplied as a single SVG file. This issue deals with the latter approach. > (The multiple resolution approach is discussed in NETBEANS-1583 .) > On Windows, arbitrary HiDPI scaling factors may be specified, such as 150%, > 175%, 200%, or 250%. Additionally, MultiResolutionImage does not work > properly on Windows due to https://bugs.openjdk.java.net/browse/JDK-8212226 . > Thus, I now consider the SVG approach to be the most feasible one. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2172) web.xml issue creating a webapp with java server faces
[ https://issues.apache.org/jira/browse/NETBEANS-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849051#comment-16849051 ] Pete Whelpton commented on NETBEANS-2172: - Same root cause > web.xml issue creating a webapp with java server faces > -- > > Key: NETBEANS-2172 > URL: https://issues.apache.org/jira/browse/NETBEANS-2172 > Project: NetBeans > Issue Type: Bug > Components: javaee - Web Project >Affects Versions: 11.0 > Environment: Product Version: Apache NetBeans IDE Dev (Build > incubator-netbeans-release-384-on-20190213) > Java: 12; OpenJDK 64-Bit Server VM 12+32 > Runtime: OpenJDK Runtime Environment 12+32 > System: Windows 10 version 10.0 running on amd64; Cp1252; en_US (nb) >Reporter: Giuseppe Tino >Priority: Major > > Steps to reproduce: > # Create a new "Maven / Web Application" project: > ** "Project Name": {{firstcup}} > ** "Server": {{GlassFish Server 5.0}} > ** "Java EE Version": {{Java EE 7 Web}} > ** "Context Path": {{/firstcup}} > # After the project is created, invoke pop-up menu on it's root node and > select *Properties*. > # Select the "Frameworks" category in the "Project Properties" manager. > # Push the *Add...* button and choose "JavaServer Faces" framework. > # In "Configuration" tab, set "JSF Servlet URL Pattern" to: > {{/firstcupWeb/*}} and push *OK*. > # Delete generated web pages. > Expected result: > * The project is created and no errors are displayed > Actual result: > * In the project panel the file Web pages > WEB-INF > web.xml is marked with > a red x. On mouse hover the following message is shown "cvc-elt.1.a: Cannot > find the declaration of element 'web-app'. " -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1583) Support MultiResolutionImage loading from ImageUtilities
[ https://issues.apache.org/jira/browse/NETBEANS-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849040#comment-16849040 ] Eirik Bakke commented on NETBEANS-1583: --- I have concluded that it's better to support vectorized icons via SVG; see https://issues.apache.org/jira/browse/NETBEANS-2604 . While the MultiResolutionImage approach could be nice to support as well, SVG loading support would make the latter lower-priority. > Support MultiResolutionImage loading from ImageUtilities > - > > Key: NETBEANS-1583 > URL: https://issues.apache.org/jira/browse/NETBEANS-1583 > Project: NetBeans > Issue Type: Improvement > Components: platform - Other >Affects Versions: 10.0 > Environment: Windows, Linux, and MacOS >Reporter: Eirik Bakke >Priority: Minor > Labels: HiDPI > > To look good on HiDPI/Retina displays, the NetBeans IDE, and NetBeans > Platform (RCP) applications, will eventually need to provide high-resolution > versions of various image asset (typically icons). In Swing, multi-resolution > image assets are supported via the > [MultiResolutionImage|https://docs.oracle.com/javase/10/docs/api/java/awt/image/MultiResolutionImage.html] > class; such images are automatically loaded by methods such as > Toolkit.getImage based on a standard naming convention. For instance, on > MacOS, Toolkit.getImage("myicon.png") will also load the file "myi...@2x.png" > if present, returning a MultiResolutionImage (implemented in > [JDK-8011059|https://bugs.openjdk.java.net/browse/JDK-8011059]). NetBeans' > ImageUtilities.loadImage and friends should do the same. > The same naming convention for multi-resolution image assets should be used > as in the JDK. See Philip Race's comment on > [JDK-8151787|https://bugs.openjdk.java.net/browse/JDK-8151787] : > {quote}The proposed name convention for splash screens *and* other multi-res > images is @125pct @150pct @200pct @2x @250pct @300pct @3x > ie @2x and @3x are supported as synonyms for @200pct and @300pct respectively > and also because we already supported @2x on retina Mac. > {quote} > > On the naming convention, see also > [JDK-8090575|https://bugs.openjdk.java.net/browse/JDK-8090575]. Also make > sure to retain the ability to add a "_dark" suffix for dark LAFs. > As far as I know, only MacOS currently supports the automatic loading of such > assets via Toolkit.getImage, but both Windows and MacOS (and Linux?) support > the underlying MultiResolutionImage class. So it's already possible to > implement this on the latest JDK. Note, however, that we should probably wait > for [JDK-8212226|https://bugs.openjdk.java.net/browse/JDK-8212226] to be > fixed before enabling this on Windows. > As part of this patch, other ImageUtilities methods such as > createDisabledIcon, createDisabledImage, and mergeImages should also be > updated to support both MultiResolutionImage and the new > org.openide.util.VectorIcon class (introduced at > https://github.com/apache/incubator-netbeans/pull/859/files ). Emilian Bold > has done some work on this in the past; see > https://github.com/emilianbold/nextbeans/commit/0f99dba0c1b3e8e0bc4e7cec407b53d30e85ead1 > . Eirik Bakke also has a [Pull > Request|https://github.com/apache/incubator-netbeans/pull/998] for > createDisabledIcon in particular, which works with the VectorIcon class and > any other Icon instance. > Last, note that there are two ways to create icons that look good on HiDPI > displays: either by using MultiResolutionImage, or by hand-painting vector > graphics in a custom implementation of the Icon class. This issue deals with > the MultiResolutionImage approach; the vector painting approach is supported > via the existing helper class org.openide.util.VectorIcon. Both approaches > are valid and should be supported by the NetBeans Platform. (Update on > 2019-05-27: There's a third approach, which is to supply each icon as an SVG > file. That one is probably the better approach. See > https://issues.apache.org/jira/browse/NETBEANS-2604 .) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1583) Support MultiResolutionImage loading from ImageUtilities
[ https://issues.apache.org/jira/browse/NETBEANS-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eirik Bakke updated NETBEANS-1583: -- Priority: Minor (was: Major) > Support MultiResolutionImage loading from ImageUtilities > - > > Key: NETBEANS-1583 > URL: https://issues.apache.org/jira/browse/NETBEANS-1583 > Project: NetBeans > Issue Type: Improvement > Components: platform - Other >Affects Versions: 10.0 > Environment: Windows, Linux, and MacOS >Reporter: Eirik Bakke >Priority: Minor > Labels: HiDPI > > To look good on HiDPI/Retina displays, the NetBeans IDE, and NetBeans > Platform (RCP) applications, will eventually need to provide high-resolution > versions of various image asset (typically icons). In Swing, multi-resolution > image assets are supported via the > [MultiResolutionImage|https://docs.oracle.com/javase/10/docs/api/java/awt/image/MultiResolutionImage.html] > class; such images are automatically loaded by methods such as > Toolkit.getImage based on a standard naming convention. For instance, on > MacOS, Toolkit.getImage("myicon.png") will also load the file "myi...@2x.png" > if present, returning a MultiResolutionImage (implemented in > [JDK-8011059|https://bugs.openjdk.java.net/browse/JDK-8011059]). NetBeans' > ImageUtilities.loadImage and friends should do the same. > The same naming convention for multi-resolution image assets should be used > as in the JDK. See Philip Race's comment on > [JDK-8151787|https://bugs.openjdk.java.net/browse/JDK-8151787] : > {quote}The proposed name convention for splash screens *and* other multi-res > images is @125pct @150pct @200pct @2x @250pct @300pct @3x > ie @2x and @3x are supported as synonyms for @200pct and @300pct respectively > and also because we already supported @2x on retina Mac. > {quote} > > On the naming convention, see also > [JDK-8090575|https://bugs.openjdk.java.net/browse/JDK-8090575]. Also make > sure to retain the ability to add a "_dark" suffix for dark LAFs. > As far as I know, only MacOS currently supports the automatic loading of such > assets via Toolkit.getImage, but both Windows and MacOS (and Linux?) support > the underlying MultiResolutionImage class. So it's already possible to > implement this on the latest JDK. Note, however, that we should probably wait > for [JDK-8212226|https://bugs.openjdk.java.net/browse/JDK-8212226] to be > fixed before enabling this on Windows. > As part of this patch, other ImageUtilities methods such as > createDisabledIcon, createDisabledImage, and mergeImages should also be > updated to support both MultiResolutionImage and the new > org.openide.util.VectorIcon class (introduced at > https://github.com/apache/incubator-netbeans/pull/859/files ). Emilian Bold > has done some work on this in the past; see > https://github.com/emilianbold/nextbeans/commit/0f99dba0c1b3e8e0bc4e7cec407b53d30e85ead1 > . Eirik Bakke also has a [Pull > Request|https://github.com/apache/incubator-netbeans/pull/998] for > createDisabledIcon in particular, which works with the VectorIcon class and > any other Icon instance. > Last, note that there are two ways to create icons that look good on HiDPI > displays: either by using MultiResolutionImage, or by hand-painting vector > graphics in a custom implementation of the Icon class. This issue deals with > the MultiResolutionImage approach; the vector painting approach is supported > via the existing helper class org.openide.util.VectorIcon. Both approaches > are valid and should be supported by the NetBeans Platform. (Update on > 2019-05-27: There's a third approach, which is to supply each icon as an SVG > file. That one is probably the better approach. See > https://issues.apache.org/jira/browse/NETBEANS-2604 .) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1583) Support MultiResolutionImage loading from ImageUtilities
[ https://issues.apache.org/jira/browse/NETBEANS-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eirik Bakke updated NETBEANS-1583: -- Description: To look good on HiDPI/Retina displays, the NetBeans IDE, and NetBeans Platform (RCP) applications, will eventually need to provide high-resolution versions of various image asset (typically icons). In Swing, multi-resolution image assets are supported via the [MultiResolutionImage|https://docs.oracle.com/javase/10/docs/api/java/awt/image/MultiResolutionImage.html] class; such images are automatically loaded by methods such as Toolkit.getImage based on a standard naming convention. For instance, on MacOS, Toolkit.getImage("myicon.png") will also load the file "myi...@2x.png" if present, returning a MultiResolutionImage (implemented in [JDK-8011059|https://bugs.openjdk.java.net/browse/JDK-8011059]). NetBeans' ImageUtilities.loadImage and friends should do the same. The same naming convention for multi-resolution image assets should be used as in the JDK. See Philip Race's comment on [JDK-8151787|https://bugs.openjdk.java.net/browse/JDK-8151787] : {quote}The proposed name convention for splash screens *and* other multi-res images is @125pct @150pct @200pct @2x @250pct @300pct @3x ie @2x and @3x are supported as synonyms for @200pct and @300pct respectively and also because we already supported @2x on retina Mac. {quote} On the naming convention, see also [JDK-8090575|https://bugs.openjdk.java.net/browse/JDK-8090575]. Also make sure to retain the ability to add a "_dark" suffix for dark LAFs. As far as I know, only MacOS currently supports the automatic loading of such assets via Toolkit.getImage, but both Windows and MacOS (and Linux?) support the underlying MultiResolutionImage class. So it's already possible to implement this on the latest JDK. Note, however, that we should probably wait for [JDK-8212226|https://bugs.openjdk.java.net/browse/JDK-8212226] to be fixed before enabling this on Windows. As part of this patch, other ImageUtilities methods such as createDisabledIcon, createDisabledImage, and mergeImages should also be updated to support both MultiResolutionImage and the new org.openide.util.VectorIcon class (introduced at https://github.com/apache/incubator-netbeans/pull/859/files ). Emilian Bold has done some work on this in the past; see https://github.com/emilianbold/nextbeans/commit/0f99dba0c1b3e8e0bc4e7cec407b53d30e85ead1 . Eirik Bakke also has a [Pull Request|https://github.com/apache/incubator-netbeans/pull/998] for createDisabledIcon in particular, which works with the VectorIcon class and any other Icon instance. Last, note that there are two ways to create icons that look good on HiDPI displays: either by using MultiResolutionImage, or by hand-painting vector graphics in a custom implementation of the Icon class. This issue deals with the MultiResolutionImage approach; the vector painting approach is supported via the existing helper class org.openide.util.VectorIcon. Both approaches are valid and should be supported by the NetBeans Platform. (Update on 2019-05-27: There's a third approach, which is to supply each icon as an SVG file. That one is probably the better approach. See https://issues.apache.org/jira/browse/NETBEANS-2604 .) was: To look good on HiDPI/Retina displays, the NetBeans IDE, and NetBeans Platform (RCP) applications, will eventually need to provide high-resolution versions of various image asset (typically icons). In Swing, multi-resolution image assets are supported via the [MultiResolutionImage|https://docs.oracle.com/javase/10/docs/api/java/awt/image/MultiResolutionImage.html] class; such images are automatically loaded by methods such as Toolkit.getImage based on a standard naming convention. For instance, on MacOS, Toolkit.getImage("myicon.png") will also load the file "myi...@2x.png" if present, returning a MultiResolutionImage (implemented in [JDK-8011059|https://bugs.openjdk.java.net/browse/JDK-8011059]). NetBeans' ImageUtilities.loadImage and friends should do the same. The same naming convention for multi-resolution image assets should be used as in the JDK. See Philip Race's comment on [JDK-8151787|https://bugs.openjdk.java.net/browse/JDK-8151787] : {quote}The proposed name convention for splash screens *and* other multi-res images is @125pct @150pct @200pct @2x @250pct @300pct @3x ie @2x and @3x are supported as synonyms for @200pct and @300pct respectively and also because we already supported @2x on retina Mac. {quote} On the naming convention, see also [JDK-8090575|https://bugs.openjdk.java.net/browse/JDK-8090575]. Also make sure to retain the ability to add a "_dark" suffix for dark LAFs. As far as I know, only MacOS currently supports the automatic loading of such assets via Toolkit.getImage, but both Windows and MacOS (and Linux?) support the underlying
[jira] [Updated] (NETBEANS-2604) Support SVG icon loading from ImageUtilities
[ https://issues.apache.org/jira/browse/NETBEANS-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eirik Bakke updated NETBEANS-2604: -- Labels: HiDPI (was: ) > Support SVG icon loading from ImageUtilities > > > Key: NETBEANS-2604 > URL: https://issues.apache.org/jira/browse/NETBEANS-2604 > Project: NetBeans > Issue Type: Improvement > Components: platform - Other >Affects Versions: 11.0 > Environment: Windows, MacOS, and Linux. >Reporter: Eirik Bakke >Priority: Major > Labels: HiDPI > > Support SVG image loading from ImageUtilities, primarily for icons. This > would be implemented as a special subclass of javax.swing.Icon, rather than > through MultiResolutionImage. Eirik Bakke already has most of this code ready. > Motivation: To look good on HiDPI/Retina displays, the NetBeans IDE, and > NetBeans Platform (RCP) applications, will eventually need to provide > high-resolution versions of various image asset (typically icons). Two > approaches are possible: (1) allow each icon to be supplied as multiple > bitmap (i.e. PNG) files, one for each resolution, or (2) allow each icon to > be supplied as a single SVG file. This issue deals with the latter approach. > (The multiple resolution approach is discussed in NETBEANS-1583 .) > On Windows, arbitrary HiDPI scaling factors may be specified, such as 150%, > 175%, 200%, or 250%. Additionally, MultiResolutionImage does not work > properly on Windows due to https://bugs.openjdk.java.net/browse/JDK-8212226 . > Thus, I now consider the SVG approach to be the most feasible one. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2604) Support SVG icon loading from ImageUtilities
Eirik Bakke created NETBEANS-2604: - Summary: Support SVG icon loading from ImageUtilities Key: NETBEANS-2604 URL: https://issues.apache.org/jira/browse/NETBEANS-2604 Project: NetBeans Issue Type: Improvement Components: platform - Other Affects Versions: 11.0 Environment: Windows, MacOS, and Linux. Reporter: Eirik Bakke Support SVG image loading from ImageUtilities, primarily for icons. This would be implemented as a special subclass of javax.swing.Icon, rather than through MultiResolutionImage. Eirik Bakke already has most of this code ready. Motivation: To look good on HiDPI/Retina displays, the NetBeans IDE, and NetBeans Platform (RCP) applications, will eventually need to provide high-resolution versions of various image asset (typically icons). Two approaches are possible: (1) allow each icon to be supplied as multiple bitmap (i.e. PNG) files, one for each resolution, or (2) allow each icon to be supplied as a single SVG file. This issue deals with the latter approach. (The multiple resolution approach is discussed in NETBEANS-1583 .) On Windows, arbitrary HiDPI scaling factors may be specified, such as 150%, 175%, 200%, or 250%. Additionally, MultiResolutionImage does not work properly on Windows due to https://bugs.openjdk.java.net/browse/JDK-8212226 . Thus, I now consider the SVG approach to be the most feasible one. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2603) Paste in the Find window is CTRL + V instead of CMD + V on macOS
C. G. created NETBEANS-2603: --- Summary: Paste in the Find window is CTRL + V instead of CMD + V on macOS Key: NETBEANS-2603 URL: https://issues.apache.org/jira/browse/NETBEANS-2603 Project: NetBeans Issue Type: Improvement Environment: macOS 10.14.3 using Netbeans 11. Reporter: C. G. Using Netbeans on macOS, the shortcut to paste the clipboard contents is CTRL + V which goes against the standard CMD + V which is used everywhere else. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2602) Automated URL formatting includes final parentheses and so breaks the link
Jimmy Jeunemaître created NETBEANS-2602: --- Summary: Automated URL formatting includes final parentheses and so breaks the link Key: NETBEANS-2602 URL: https://issues.apache.org/jira/browse/NETBEANS-2602 Project: NetBeans Issue Type: Bug Affects Versions: 11.0 Environment: Windows 10, 64 bits, i7 Reporter: Jimmy Jeunemaître Attachments: URL link format automatically include last parenthesis.png When an URL link is followed by an end parenthese ")" it is included in the link and so it breaks the link when we CTRL + left click on it. E.g: Instead to have ([http://example.com|http://example.com]) we have ([http://example.com)|http://example.com)]. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2573) PHPUNIT update breaks running single test
[ https://issues.apache.org/jira/browse/NETBEANS-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848832#comment-16848832 ] Tomáš Myšík commented on NETBEANS-2573: --- You are welcome. > PHPUNIT update breaks running single test > - > > Key: NETBEANS-2573 > URL: https://issues.apache.org/jira/browse/NETBEANS-2573 > Project: NetBeans > Issue Type: Bug > Components: php - PHPUnit >Affects Versions: 11.0 > Environment: Netbeans 11.0, PHP 7.3 >Reporter: Alan Langford >Assignee: Tomáš Myšík >Priority: Major > Labels: pull-request-available > Fix For: 12.0 > > Attachments: image-2019-05-26-15-03-10-820.png, > image-2019-05-26-18-44-57-451.png > > Time Spent: 40m > Remaining Estimate: 0h > > When running a single test file and PHPUnit installed via composer, Netbeans > generates a command line of this general form: > php.exe "\{project}\vendor\phpunit\phpunit\phpunit" "--colors" "log-junit" > "\{temp}\nb-phpunit-log.xml" "configuration" "\{project}\phpunit.xml" > "coverage-clover" "\{temp}\nb-phpunit-coverage.xml" "C:\Program > Files\netbeans 11\php\phpunit\NetBeansSuite.php" "--" > "–run=\{project}\tests\SomeTest.php" > The "–" argument used to fool PHPUnit. PHPUnit would strip the dashes and > pass a empty string for the name of the test file. > NetBeansSuite.php would then extract the --run=argument and run the test. > The latest master for PHPUnit (a79e18fe27) has changed the way command lines > are parsed; the "–" is discarded. PHPUnit then reports an error: > Cannot open file "–run=\{project}\tests\SomeTest.php" > I believe passing > NetBeansSuite "C:\Program Files\netbeans 11\php\phpunit\NetBeansSuite.php" > instead of > "C:\Program Files\netbeans 11\php\phpunit\NetBeansSuite.php" "–" > Will resolve the problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-1851] PHPUnit java.lang.AssertionError: At least 2 lines must be found (message + stacktrace)
This is an automated email from the ASF dual-hosted git repository. tmysik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new 212a9c4 [NETBEANS-1851] PHPUnit java.lang.AssertionError: At least 2 lines must be found (message + stacktrace) new ac716ae Merge pull request #1265 from junichi11/netbeans-1851 212a9c4 is described below commit 212a9c411301000e2c3cd32c85c3c60a44b2b9bb Author: Junichi Yamamoto AuthorDate: Sat May 25 12:04:53 2019 +0900 [NETBEANS-1851] PHPUnit java.lang.AssertionError: At least 2 lines must be found (message + stacktrace) - stacktrace may be empty --- .../modules/php/phpunit/run/PhpUnitLogParser.java | 7 +++- .../test/unit/data/phpunit-log-netbeans1851.xml| 47 ++ .../php/phpunit/run/PhpUnitLogParserTest.java | 15 +++ 3 files changed, 68 insertions(+), 1 deletion(-) diff --git a/php/php.phpunit/src/org/netbeans/modules/php/phpunit/run/PhpUnitLogParser.java b/php/php.phpunit/src/org/netbeans/modules/php/phpunit/run/PhpUnitLogParser.java index 5b39d22..b7cf90d 100644 --- a/php/php.phpunit/src/org/netbeans/modules/php/phpunit/run/PhpUnitLogParser.java +++ b/php/php.phpunit/src/org/netbeans/modules/php/phpunit/run/PhpUnitLogParser.java @@ -190,10 +190,15 @@ public final class PhpUnitLogParser extends DefaultHandler { private void fillStacktrace() { String[] lines = buffer.toString().trim().split("\n"); // NOI18N -assert lines.length >= 2 : "At least 2 lines must be found (message + stacktrace)"; +// stacktrace may be empty, so check whether the new line is contained instead of lines.length >= 2 +assert buffer.toString().contains("\n") : "At least 2 lines must be found (message + stacktrace)"; // NOI18N buffer = new StringBuilder(200); boolean stacktraceStarted = false; +// NETBEANS-1851 stacktrace is empty +if (lines.length == 1) { +buffer.append(lines[0]); +} // 1st line is skipped for (int i = 1; i < lines.length; ++i) { String line = lines[i]; diff --git a/php/php.phpunit/test/unit/data/phpunit-log-netbeans1851.xml b/php/php.phpunit/test/unit/data/phpunit-log-netbeans1851.xml new file mode 100644 index 000..4521099 --- /dev/null +++ b/php/php.phpunit/test/unit/data/phpunit-log-netbeans1851.xml @@ -0,0 +1,47 @@ + + + + + + + + + + + + + + + + + + + + + + +Risky Test + + + + + diff --git a/php/php.phpunit/test/unit/src/org/netbeans/modules/php/phpunit/run/PhpUnitLogParserTest.java b/php/php.phpunit/test/unit/src/org/netbeans/modules/php/phpunit/run/PhpUnitLogParserTest.java index 6bdd885..9c467ea 100644 --- a/php/php.phpunit/test/unit/src/org/netbeans/modules/php/phpunit/run/PhpUnitLogParserTest.java +++ b/php/php.phpunit/test/unit/src/org/netbeans/modules/php/phpunit/run/PhpUnitLogParserTest.java @@ -280,6 +280,21 @@ public class PhpUnitLogParserTest extends NbTestCase { assertEquals(1465, tests); } +public void testParseLogNETBEANS1851() throws Exception { +Reader reader = createReader("phpunit-log-netbeans1851.xml"); +TestSessionVo testSession = new TestSessionVo(null); + +PhpUnitLogParser.parse(reader, testSession); + +assertSame(1, testSession.getTestSuites().size()); +TestSuiteVo testSuite = testSession.getTestSuites().get(0); +assertEquals("CalculatorTest", testSuite.getName()); +assertEquals("/tmp/Calculator-PHPUnit/test/src/CalculatorTest.php", testSuite.getFile()); +TestCaseVo testCase = testSuite.getTestCases().get(16); +assertTrue(testCase.isError()); +assertEquals("Risky Test", testCase.getStackTrace()[0]); +} + private Reader createReader(String filename) throws FileNotFoundException { return new BufferedReader(new FileReader(new File(getDataDir(), filename))); } - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1997) JaCoCo 0.8.2 breaks code coverage integration
[ https://issues.apache.org/jira/browse/NETBEANS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848766#comment-16848766 ] Mark Herkrath commented on NETBEANS-1997: - Hi Antonio, I am using Java 8. Please note that in the link you have sent, they are actually moving to JaCoCo 0.8.2 to support Java 11. JaCoCo 0.8.2 has experimental support, 0.8.3 has official support for Java 11: [https://github.com/jacoco/jacoco/releases/tag/v0.8.3] However, note that I may have hijacked this issue for another one. The other issue made me believe that 0.8.2 doesn't work. Details can be found here: [https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E] With the fix, at least I can run JaCoCo 0.8.1, 0.8.2, and 0.8.3 successfully. I haven't tested Java 11 though. > JaCoCo 0.8.2 breaks code coverage integration > - > > Key: NETBEANS-1997 > URL: https://issues.apache.org/jira/browse/NETBEANS-1997 > Project: NetBeans > Issue Type: Bug >Reporter: Philip Durbin >Assignee: John McDonnell >Priority: Minor > > I asked, "Does JaCoCo 0.8.2 break NetBeans code coverage?" on the users > mailing list: > [https://lists.apache.org/thread.html/509bfddb9273726a6e8dff1ca419790b40858d6a648b4413142e2abe@%3Cusers.netbeans.apache.org%3E] > Geertjan Wielenga said to go ahead and open an issue so I believe he agrees > that it does. > The main evidence seems to be in > [https://github.com/jacoco/jacoco/issues/772] where a JaCoCo developer, > Evgeny Mandrikov, said the following. > "AFAIK NetBeans integration reads XML Report, which was intentionally changed > in version 0.8.2 in a perfectly valid way by addition of new attribute - see > https://github.com/jacoco/jacoco/pull/702. NetBeans integration must be fixed > accordingly and ideally be less strict to cope with such updates in future. > This problem should reported to developers of NetBeans integration, since it > is not developed by us - as you can see on page > [https://www.jacoco.org/jacoco/trunk/doc/integrations.html] " > My workaround was to downgrade to JaCoCo 0.8.1, as I explained in > [https://github.com/IQSS/dataverse/issues/5483] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-188) Please add support for code completion while typing
[ https://issues.apache.org/jira/browse/NETBEANS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848677#comment-16848677 ] Christian Lenz commented on NETBEANS-188: - Yes, most of the time, code completion works after hittin '.' in all other languages, but in other languages you can say I want it always, not only after '.'. I can guess the reason. The problem with SQL files is, that if you hit ctrl + space to get the code completion and you didn't set a connection, the warning dialog comes up, which is annoying. So this is an other topic for sure, this warning should be not there anymore. More like a hint/notification: be aware, you didn't set a connection, if you want to have full code completion, add a connection. But this warning now prevents you from writing plain SQL. This must be handled in an other way and after this we can have code completion for everything without disturbing popups. > Please add support for code completion while typing > --- > > Key: NETBEANS-188 > URL: https://issues.apache.org/jira/browse/NETBEANS-188 > Project: NetBeans > Issue Type: Improvement > Components: db - SQL Editor >Affects Versions: Next >Reporter: Christian Lenz >Priority: Major > Attachments: sqlCodeCompletion.gif > > > Afaik, the SQL Editor, is the only one, where you don't have code completion, > while typing. It only appears after you hit ctrl + space, which is weird. It > should be there per default. If not, there should be an option that code > completion should always be possible, in any cases and you can deactivate it, > if you don't want it. > For each keyword, table, view whatever, I have to type a character and hit > ctrl + space. It would be very nice to have the same code completion feature > as in java or other languages, that the code completion comes up, while > typing. For example: > Type "S" -> code completion should come immediately and should show you the > results. Same for everything like tables, views, databases, aliases and > columns. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-39] Fix for no code completion in Jade files while typing (#1261)
This is an automated email from the ASF dual-hosted git repository. geertjan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new 4254693 [NETBEANS-39] Fix for no code completion in Jade files while typing (#1261) 4254693 is described below commit 4254693b47c6629cd56af2dbcb0087e0f8e3e6a6 Author: Pete Whelpton AuthorDate: Mon May 27 08:22:26 2019 +0100 [NETBEANS-39] Fix for no code completion in Jade files while typing (#1261) --- .../jade/editor/JadeCodeCompletion.java| 7 +++ .../jade/editor/JadeAutoCompletionTest.java| 58 ++ 2 files changed, 65 insertions(+) diff --git a/webcommon/javascript2.jade/src/org/netbeans/modules/javascript2/jade/editor/JadeCodeCompletion.java b/webcommon/javascript2.jade/src/org/netbeans/modules/javascript2/jade/editor/JadeCodeCompletion.java index 9d8b687..437aa82 100644 --- a/webcommon/javascript2.jade/src/org/netbeans/modules/javascript2/jade/editor/JadeCodeCompletion.java +++ b/webcommon/javascript2.jade/src/org/netbeans/modules/javascript2/jade/editor/JadeCodeCompletion.java @@ -159,6 +159,13 @@ public class JadeCodeCompletion implements CodeCompletionHandler2 { @Override public QueryType getAutoQuery(JTextComponent component, String typedText) { +if(typedText != null) { +int length = typedText.length(); +if(length > 0 && !Character.isWhitespace(typedText.charAt(length - 1))) { +return QueryType.COMPLETION; +} +} + return QueryType.NONE; } diff --git a/webcommon/javascript2.jade/test/unit/src/org/netbeans/modules/javascript2/jade/editor/JadeAutoCompletionTest.java b/webcommon/javascript2.jade/test/unit/src/org/netbeans/modules/javascript2/jade/editor/JadeAutoCompletionTest.java new file mode 100644 index 000..18b367d --- /dev/null +++ b/webcommon/javascript2.jade/test/unit/src/org/netbeans/modules/javascript2/jade/editor/JadeAutoCompletionTest.java @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.javascript2.jade.editor; + +import org.netbeans.modules.csl.api.CodeCompletionHandler.QueryType; + +/** + * + * @author peedeeboy + */ +public class JadeAutoCompletionTest extends JadeTestBase { + +public JadeAutoCompletionTest(String testName) { +super(testName); +} + +public void testAutoCompletion() { +QueryType expected = QueryType.COMPLETION; +assertAutoQuery(expected, "^ ", "B"); +} + +public void testAutoCompletionWhitespace() { +QueryType expected = QueryType.NONE; +assertAutoQuery(expected, "^ ", " "); +} + +public void testAutoCompletionEmptyString() { +QueryType expected = QueryType.NONE; +assertAutoQuery(expected, "^ ", ""); +} + +public void testAutoCompletionNull() { +QueryType expected = QueryType.NONE; +assertAutoQuery(expected, "^ ", null); +} + +public void testAutoCompletionNewLine() { +QueryType expected = QueryType.NONE; +String newline = System.lineSeparator(); +assertAutoQuery(expected, "^ ", newline); +} +} - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2601) Cannot get XSD Design view
[ https://issues.apache.org/jira/browse/NETBEANS-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848648#comment-16848648 ] Geertjan Wielenga commented on NETBEANS-2601: - You must have installed a plugin for that, XSD is not supported out of the box. > Cannot get XSD Design view > -- > > Key: NETBEANS-2601 > URL: https://issues.apache.org/jira/browse/NETBEANS-2601 > Project: NetBeans > Issue Type: Bug >Reporter: Mindaugas Lukosius >Priority: Major > Attachments: image-2019-05-27-08-07-29-560.png > > > Hello, > > I have downloaded latest NET Beans IDE and imported XSD document. However, > Design view is not available. How to debug and enable Design view. > I'm sure that XSD is valid, because it is successfully imported in Data > Integration tool like Informatica. > What I get > !image-2019-05-27-08-07-29-560.png! > What is expected > !https://xml.netbeans.org/images/screenshots/designView.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists