[jira] [Commented] (NETBEANS-2415) Bring back support for WildFly server
[ https://issues.apache.org/jira/browse/NETBEANS-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859118#comment-16859118 ] Rik Giepmann commented on NETBEANS-2415: Workaround available: Download from [http://plugins.netbeans.org/plugin/5/wildfly-application-server] and install manualy > Bring back support for WildFly server > - > > Key: NETBEANS-2415 > URL: https://issues.apache.org/jira/browse/NETBEANS-2415 > Project: NetBeans > Issue Type: Wish > Components: serverplugins - WildFly >Affects Versions: 11.0 > Environment: n.a. >Reporter: Dominik Derwiński >Priority: Minor > > NetBeans 8.2 had WildFly server module, which helped greatly in debugging > Java EE applications directly from IDE. NetBeans 11.0 does not contain this > module, despite boasting to be the first version of Apache NetBeans to offer > full support for developing Java EE applications. > I don't think it would be very hard to bring back WildFly server module > (currently it does not complile), because copying files of the module from > NetBeans 8.2 into NetBeans 11.0 installation, and recreating userdir is > enough to bring back that functionality (so the old module still works, but > for how long?). > The files I have copied (after removing references to localization files) are: > * enterprise/config/Modules/org-netbeans-modules-javaee-wildfly.xml > * enterprise/modules/org-netbeans-modules-javaee-wildfly.jar > * enterprise/update_tracking/org-netbeans-modules-javaee-wildfly.xml > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2622) gradle project seams always taken the default JDK
[
https://issues.apache.org/jira/browse/NETBEANS-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859094#comment-16859094
]
Laszlo Kishalmi commented on NETBEANS-2622:
---
Can you rest it with the recent patch for NETBEANS-2004?
You may get it installing the netbeans-dev Snap package (that keeps you on the
edge): sudo snap install netbeans-dev --classic
> gradle project seams always taken the default JDK
> -
>
> Key: NETBEANS-2622
> URL: https://issues.apache.org/jira/browse/NETBEANS-2622
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Gradle
>Affects Versions: 11.0
>Reporter: Andreas Eberhöfer
>Assignee: Laszlo Kishalmi
>Priority: Minor
> Attachments: JDKTest.tar.gz, netbeans_jdk.png
>
>
> Hi,
> I start netbeans with JDK 10, set in the `etc/netbeans.conf` the jdkhome
> path. Now I create a new gradle project and set in the `build.gradle`
> ```
> sourceCompatibility = 11
> targetCompatibility = 11
> ```
> In my code I use a JDK 11 API like
> ```
> Path p = Path.of(".");
> ```
> This won't compile.
> I added a JDK 11 to netbeans and change under
> `Properies->Build->Compile->Java Platform` to JDK 11. It still does not
> compile.
> After a restart, it still does not compile.
> I changed the jdkhome in `etc/netbeans.conf` to the JDK 11. After a restart
> it compiles.
> Not a big deal, but maybe you should have a look at it. To me it seams like
> gradle project always takes the default JDK.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2630) ArrayIndexOutOfBoundsException for many operations in gradle projects.
[ https://issues.apache.org/jira/browse/NETBEANS-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859092#comment-16859092 ] Laszlo Kishalmi commented on NETBEANS-2630: --- I'm asking as I can't reproduce that right now. > ArrayIndexOutOfBoundsException for many operations in gradle projects. > -- > > Key: NETBEANS-2630 > URL: https://issues.apache.org/jira/browse/NETBEANS-2630 > Project: NetBeans > Issue Type: Bug > Components: java - Refactoring >Affects Versions: 11.0 >Reporter: Deft Developer >Assignee: Laszlo Kishalmi >Priority: Major > Attachments: messages.log > > > The exception is thrown when finding usages, refactoring, and sometimes "Go > to" Symbol. The Exception is thrown in gradle projects.. > > SEVERE [org.openide.util.RequestProcessor]: Error in RequestProcessor > org.netbeans.modules.refactoring.spi.impl.RefactoringPanel$3 > java.lang.ArrayIndexOutOfBoundsException: arraycopy: last destination index > 8 out of bounds for object array[6] > at java.base/java.lang.System.arraycopy(Native Method) > at > org.netbeans.modules.refactoring.java.ui.tree.FolderTreeElement.getSourceGroup(FolderTreeElement.java:119) > at > org.netbeans.modules.refactoring.java.ui.tree.TreeElementFactoryImpl.getTreeElement(TreeElementFactoryImpl.java:55) > at > org.netbeans.modules.refactoring.spi.ui.TreeElementFactory.getTreeElement(TreeElementFactory.java:44) > at > org.netbeans.modules.refactoring.java.ui.tree.FileTreeElement.getParent(FileTreeElement.java:75) > at > org.netbeans.modules.refactoring.spi.impl.RefactoringPanel.createNode(RefactoringPanel.java:488) > at > org.netbeans.modules.refactoring.spi.impl.RefactoringPanel.createNode(RefactoringPanel.java:493) > at > org.netbeans.modules.refactoring.spi.impl.RefactoringPanel.createNode(RefactoringPanel.java:493) > at > org.netbeans.modules.refactoring.spi.impl.RefactoringPanel.createNode(RefactoringPanel.java:493) > at > org.netbeans.modules.refactoring.spi.impl.RefactoringPanel.access$1100(RefactoringPanel.java:80) > at > org.netbeans.modules.refactoring.spi.impl.RefactoringPanel$3.run(RefactoringPanel.java:765) > at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) > at > org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45) > at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278) > [catch] at > org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-2638) NullPointerException within GradleBaseProjectBuilder
[
https://issues.apache.org/jira/browse/NETBEANS-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859088#comment-16859088
]
Laszlo Kishalmi commented on NETBEANS-2638:
---
I'm having some android SDKs laying around, so instructions are welcome. Though
supporting Android development is not among my goals at the moment. This NPE
could occur in other (hopefully rare) cases as well.
Also I recommend adding a settings.gradle in the root of the sample project
even it is empty.
> NullPointerException within GradleBaseProjectBuilder
>
>
> Key: NETBEANS-2638
> URL: https://issues.apache.org/jira/browse/NETBEANS-2638
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Gradle
> Environment: Linux
>Reporter: Lou Hamersly
>Assignee: Laszlo Kishalmi
>Priority: Major
>
> Encountered this error reported by NetBeans 11 with Groovy/Gradle plugin
> 1.0.1:
> {noformat}
> java.lang.NullPointerException
> at java.base/java.util.AbstractCollection.addAll(AbstractCollection.java:351)
> at
> org.netbeans.modules.gradle.api.GradleBaseProjectBuilder.processDependencies(GradleBaseProjectBuilder.java:128)
> at
> org.netbeans.modules.gradle.api.GradleBaseProjectBuilder.build(GradleBaseProjectBuilder.java:75)
> at
> org.netbeans.modules.gradle.api.GradleBaseProjectBuilder$Extractor.extract(GradleBaseProjectBuilder.java:288)
> at
> org.netbeans.modules.gradle.GradleProjectCache.createGradleProject(GradleProjectCache.java:432)
> at
> org.netbeans.modules.gradle.GradleProjectCache.loadGradleProject(GradleProjectCache.java:257)
> at
> org.netbeans.modules.gradle.GradleProjectCache.access$100(GradleProjectCache.java:85)
> [catch] at
> org.netbeans.modules.gradle.GradleProjectCache$ProjectLoaderTask.call(GradleProjectCache.java:348)
> at
> org.netbeans.modules.gradle.GradleProjectCache$ProjectLoaderTask.call(GradleProjectCache.java:326)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
> at
> org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
> at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
> at
> org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033){noformat}
> This was encountered building the jme3-android-examples subproject located in
> this repository: [https://github.com/jMonkeyEngine/jmonkeyengine]
> Unfortunately some setup (Android SDK related) would be involved to reproduce
> (I may be able to help test), however since this appears to be "source set"
> related, glancing at the code I suspect it may have something to do with
> relative paths used in the build file. Build file used for the subproject is
> below.
> (Note - the version number on the 4th/5th line was changed from 23 to 27
> from the repo's version to bypass a compile issue. This NPE was encountered
> with the below build file.)
>
> {code:java}
> apply plugin: 'com.android.application'
> android {
> compileSdkVersion 27
> buildToolsVersion "27.0.3"
> lintOptions {
> // Fix nifty gui referencing "java.awt" package.
> disable 'InvalidPackage'
> abortOnError false
> }
> defaultConfig {
> applicationId "org.jmonkeyengine.jme3androidexamples"
> minSdkVersion 15 // Android 4.0.3 ICE CREAM SANDWICH
> targetSdkVersion 22 // Android 5.1 LOLLIPOP
> versionCode 1
> versionName "1.0" // TODO: from settings.gradle
> }
> buildTypes {
> release {
> minifyEnabled false
> proguardFiles getDefaultProguardFile('proguard-android.txt'),
> 'proguard-rules.pro'
> }
> }
> sourceSets {
> main {
> java {
> srcDir 'src/main/java'
> }
> assets {
> srcDir 'src/assets'
> srcDir '../jme3-testdata/src/main/resources'
> srcDir '../jme3-examples/src/main/resources'
> }
> }
> }
> }
> dependencies {
> compile fileTree(dir: 'libs', include: ['*.jar'])
> testCompile 'junit:junit:4.12'
> compile 'com.android.support:appcompat-v7:23.3.0'
> compile project(':jme3-core')
> compile project(':jme3-android')
> compile project(':jme3-android-native')
> compile project(':jme3-effects')
> compile project(':jme3-bullet')
> compile project(':jme3-bullet-native-android')
> compile project(':jme3-networking')
> compile project(':jme3-niftygui')
> compile project(':jme3-plugins')
> compile project(':jme3-terrain')
> compile fileTree(dir: '../jme3-examples/build/libs', include: ['*.jar'],
> exclude: ['*sources*.*'])
> // compile project(':jme3-examples')
> }
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbean
[netbeans] branch master updated: Trivial enhancement to have Gradle Sourcegroup presentation more informative.
This is an automated email from the ASF dual-hosted git repository.
lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 83ec9c9 Trivial enhancement to have Gradle Sourcegroup presentation
more informative.
83ec9c9 is described below
commit 83ec9c9cc61d3312088c467d049b277d4afea791
Author: Laszlo Kishalmi
AuthorDate: Fri Jun 7 20:03:00 2019 -0700
Trivial enhancement to have Gradle Sourcegroup presentation more
informative.
---
.../org/netbeans/modules/gradle/java/classpath/GradleSourcesImpl.java | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/classpath/GradleSourcesImpl.java
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/classpath/GradleSourcesImpl.java
index 5f1d236..6021d19 100644
---
a/groovy/gradle.java/src/org/netbeans/modules/gradle/java/classpath/GradleSourcesImpl.java
+++
b/groovy/gradle.java/src/org/netbeans/modules/gradle/java/classpath/GradleSourcesImpl.java
@@ -206,6 +206,9 @@ public class GradleSourcesImpl implements Sources,
SourceGroupModifierImplementa
}
String llang = lang.name().toLowerCase();
String ggroup = Utils.camelCaseToTitle(group);
+if (!unique && llang.equals(dir.getName())) {
+dir = dir.getParentFile() != null ? dir.getParentFile() : dir;
+}
return NbBundle.getMessage(GradleSourcesImpl.class, key.toString(),
ggroup, llang, dir.getName());
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-2652) JaCoCo Maven integration is broken in NB 11.0
[ https://issues.apache.org/jira/browse/NETBEANS-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Herkrath reassigned NETBEANS-2652: --- Assignee: (was: Mark Herkrath) > JaCoCo Maven integration is broken in NB 11.0 > - > > Key: NETBEANS-2652 > URL: https://issues.apache.org/jira/browse/NETBEANS-2652 > Project: NetBeans > Issue Type: Bug > Components: maven - codecoverage >Affects Versions: 11.0 >Reporter: Mark Herkrath >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > NETBEANS-1768 caused issues with JaCoCo Maven integration if the > outputDirectory isn't configured as part of the jacoco plugin configuration. > As a result the JaCoCo report file isn't reliably found. > Details can be found here: > [https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1997) JaCoCo 0.8.2 breaks code coverage integration
[ https://issues.apache.org/jira/browse/NETBEANS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859024#comment-16859024 ] Mark Herkrath commented on NETBEANS-1997: - I have created NETBEANS-2652 for the issue discovered by me, including a pull request. It may or may not be the same John ran into. > JaCoCo 0.8.2 breaks code coverage integration > - > > Key: NETBEANS-1997 > URL: https://issues.apache.org/jira/browse/NETBEANS-1997 > Project: NetBeans > Issue Type: Bug >Reporter: Philip Durbin >Assignee: John McDonnell >Priority: Minor > > I asked, "Does JaCoCo 0.8.2 break NetBeans code coverage?" on the users > mailing list: > [https://lists.apache.org/thread.html/509bfddb9273726a6e8dff1ca419790b40858d6a648b4413142e2abe@%3Cusers.netbeans.apache.org%3E] > Geertjan Wielenga said to go ahead and open an issue so I believe he agrees > that it does. > The main evidence seems to be in > [https://github.com/jacoco/jacoco/issues/772] where a JaCoCo developer, > Evgeny Mandrikov, said the following. > "AFAIK NetBeans integration reads XML Report, which was intentionally changed > in version 0.8.2 in a perfectly valid way by addition of new attribute - see > https://github.com/jacoco/jacoco/pull/702. NetBeans integration must be fixed > accordingly and ideally be less strict to cope with such updates in future. > This problem should reported to developers of NetBeans integration, since it > is not developed by us - as you can see on page > [https://www.jacoco.org/jacoco/trunk/doc/integrations.html] " > My workaround was to downgrade to JaCoCo 0.8.1, as I explained in > [https://github.com/IQSS/dataverse/issues/5483] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2652) JaCoCo Maven integration is broken in NB 11.0
[ https://issues.apache.org/jira/browse/NETBEANS-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Herkrath updated NETBEANS-2652: Description: NETBEANS-1768 caused issues with JaCoCo Maven integration if the outputDirectory isn't configured as part of the jacoco plugin configuration. As a result the JaCoCo report file isn't reliably found. Details can be found here: [https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E] was: NETBEANS-1768 caused issues with JaCoCo Maven integration if the outputDirectory isn't configured as part of the jacoco plugin report configuration. As a result the JaCoCo report file isn't reliably found. Details can be found here: https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E > JaCoCo Maven integration is broken in NB 11.0 > - > > Key: NETBEANS-2652 > URL: https://issues.apache.org/jira/browse/NETBEANS-2652 > Project: NetBeans > Issue Type: Bug > Components: maven - codecoverage >Affects Versions: 11.0 >Reporter: Mark Herkrath >Assignee: Mark Herkrath >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > NETBEANS-1768 caused issues with JaCoCo Maven integration if the > outputDirectory isn't configured as part of the jacoco plugin configuration. > As a result the JaCoCo report file isn't reliably found. > Details can be found here: > [https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2652) JaCoCo Maven integration is broken in NB 11.0
[ https://issues.apache.org/jira/browse/NETBEANS-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-2652: - Labels: pull-request-available (was: ) > JaCoCo Maven integration is broken in NB 11.0 > - > > Key: NETBEANS-2652 > URL: https://issues.apache.org/jira/browse/NETBEANS-2652 > Project: NetBeans > Issue Type: Bug > Components: maven - codecoverage >Affects Versions: 11.0 >Reporter: Mark Herkrath >Assignee: Mark Herkrath >Priority: Major > Labels: pull-request-available > > NETBEANS-1768 caused issues with JaCoCo Maven integration if the > outputDirectory isn't configured as part of the jacoco plugin report > configuration. As a result the JaCoCo report file isn't reliably found. > Details can be found here: > https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2652) JaCoCo Maven integration is broken in NB 11.0
[ https://issues.apache.org/jira/browse/NETBEANS-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Herkrath updated NETBEANS-2652: Description: NETBEANS-1768 caused issues with JaCoCo Maven integration if the outputDirectory isn't configured as part of the jacoco plugin report configuration. As a result the JaCoCo report file isn't reliably found. Details can be found here: https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E was:NETBEANS-1768 caused issues with JaCoCo Maven integration if the outputDirectory isn't configured as part of the jacoco plugin report configuration. As a result the JaCoCo report file isn't reliably found. > JaCoCo Maven integration is broken in NB 11.0 > - > > Key: NETBEANS-2652 > URL: https://issues.apache.org/jira/browse/NETBEANS-2652 > Project: NetBeans > Issue Type: Bug > Components: maven - codecoverage >Affects Versions: 11.0 >Reporter: Mark Herkrath >Assignee: Mark Herkrath >Priority: Major > > NETBEANS-1768 caused issues with JaCoCo Maven integration if the > outputDirectory isn't configured as part of the jacoco plugin report > configuration. As a result the JaCoCo report file isn't reliably found. > Details can be found here: > https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2652) JaCoCo Maven integration is broken in NB 11.0
Mark Herkrath created NETBEANS-2652: --- Summary: JaCoCo Maven integration is broken in NB 11.0 Key: NETBEANS-2652 URL: https://issues.apache.org/jira/browse/NETBEANS-2652 Project: NetBeans Issue Type: Bug Components: maven - codecoverage Affects Versions: 11.0 Reporter: Mark Herkrath Assignee: Mark Herkrath NETBEANS-1768 caused issues with JaCoCo Maven integration if the outputDirectory isn't configured as part of the jacoco plugin report configuration. As a result the JaCoCo report file isn't reliably found. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2313) Module ${related.module.name} not found for JUnit test
[
https://issues.apache.org/jira/browse/NETBEANS-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Neffenger updated NETBEANS-2313:
-
Description:
When I try to run a JUnit 4.12 test case in a non-modular project, I get the
following error:
{noformat}
Error occurred during initialization of boot layer
java.lang.module.FindException: Module ${related.module.name} not found
{noformat}
The full output with the Ant Verbosity Level set to _Verbose_ is attached below.
I worked around the issue by making the following two changes.
First, I changed the project's Run-time Test Libraries under Project Properties
> Libraries > Run Tests as follows:
*Before (default, fails)*
{noformat}
Modulepath
Modulepath for Compiling Tests
Classpath
Classpath for Compiling Tests
Compiled Tests
{noformat}
*After (works)*
{noformat}
Modulepath
Classpath
Modulepath for Compiling Tests
Classpath for Compiling Tests
Compiled Tests
{noformat}
Then I also created a new Run Configuration called "Tests" which did *not*
contain the VM Option "--add-modules=javafx.graphics".
With the "Tests" run configuration selected in the NetBeans toolbar, and the
change to the Run Tests Libraries, the unit tests ran without errors.
was:
When I try to run a JUnit 4.12 test case in a non-modular project, I get the
following error:
{noformat}
Error occurred during initialization of boot layer
java.lang.module.FindException: Module ${related.module.name} not found
{noformat}
The full output with the Ant Verbosity Level set to _Verbose_ is attached below.
I can work around the issue by changing the project's Run-time Test Libraries
under Project Properties > Libraries > Run Tests as follows.
*Before (default, fails)*
{noformat}
Modulepath
Modulepath for Compiling Tests
Classpath
Classpath for Compiling Tests
Compiled Tests
{noformat}
*After (works)*
{noformat}
Modulepath
Classpath
Modulepath for Compiling Tests
Classpath for Compiling Tests
Compiled Tests
{noformat}
> Module ${related.module.name} not found for JUnit test
> --
>
> Key: NETBEANS-2313
> URL: https://issues.apache.org/jira/browse/NETBEANS-2313
> Project: NetBeans
> Issue Type: Bug
> Components: java - JUnit
>Affects Versions: 11.0
> Environment: Product: Apache NetBeans IDE 11.0 (Build
> incubator-netbeans-release-404-on-20190319)
> Java: OpenJDK 64-Bit Server VM 12+33
> System: Linux version 4.15.0-46-generic running on amd64
>Reporter: John Neffenger
>Priority: Major
> Attachments: related-module-name.log
>
>
> When I try to run a JUnit 4.12 test case in a non-modular project, I get the
> following error:
> {noformat}
> Error occurred during initialization of boot layer
> java.lang.module.FindException: Module ${related.module.name} not found
> {noformat}
> The full output with the Ant Verbosity Level set to _Verbose_ is attached
> below.
> I worked around the issue by making the following two changes.
> First, I changed the project's Run-time Test Libraries under Project
> Properties > Libraries > Run Tests as follows:
> *Before (default, fails)*
> {noformat}
> Modulepath
> Modulepath for Compiling Tests
> Classpath
> Classpath for Compiling Tests
> Compiled Tests
> {noformat}
> *After (works)*
> {noformat}
> Modulepath
> Classpath
> Modulepath for Compiling Tests
> Classpath for Compiling Tests
> Compiled Tests
> {noformat}
> Then I also created a new Run Configuration called "Tests" which did *not*
> contain the VM Option "--add-modules=javafx.graphics".
> With the "Tests" run configuration selected in the NetBeans toolbar, and the
> change to the Run Tests Libraries, the unit tests ran without errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated (4a8d8bf -> ecb4599)
This is an automated email from the ASF dual-hosted git repository. ebakke pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git. from 4a8d8bf Merge pull request #1271 from sdedic/bugfix/2577-filtering_modules new 43e3197 Make ImageUtilities.loadImageIcon cache its result. new ecb4599 Fix missing revalidate after exiting Full Screen & Show Only Editor. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../netbeans/core/windows/EditorOnlyDisplayer.java | 3 +++ .../src/org/openide/util/ImageUtilities.java | 15 +++ .../src/org/openide/util/ImageUtilitiesTest.java | 22 +- 3 files changed, 31 insertions(+), 9 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] 02/02: Fix missing revalidate after exiting Full Screen & Show Only Editor.
This is an automated email from the ASF dual-hosted git repository.
ebakke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit ecb45997fed0b2e95b4103c6c1e4e102dbe2fbda
Author: Eirik Bakke
AuthorDate: Mon Jan 21 10:53:06 2019 -0500
Fix missing revalidate after exiting Full Screen & Show Only Editor.
This fixes a small bug that I observed in my NetBeans Platform application
when
running on Windows 10 with the NetBeans status bar disabled; it relates to
my
earlier patch for NETBEANS-731 "Hide (and auto-show) menu bar in full screen
mode". This patch has been working in my IDE without issue for 6 months.
---
.../src/org/netbeans/core/windows/EditorOnlyDisplayer.java | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/platform/core.windows/src/org/netbeans/core/windows/EditorOnlyDisplayer.java
b/platform/core.windows/src/org/netbeans/core/windows/EditorOnlyDisplayer.java
index 8c85262..884fd83 100644
---
a/platform/core.windows/src/org/netbeans/core/windows/EditorOnlyDisplayer.java
+++
b/platform/core.windows/src/org/netbeans/core/windows/EditorOnlyDisplayer.java
@@ -143,6 +143,9 @@ public class EditorOnlyDisplayer {
JFrame frame = ( JFrame )
WindowManagerImpl.getInstance().getMainWindow();
frame.setContentPane( originalContentPane );
originalContentPane = null;
+frame.invalidate();
+frame.revalidate();
+frame.repaint();
setShowEditorToolbar( originalShowEditorToolbar );
if( restoreFocus )
restoreFocus();
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] 01/02: Make ImageUtilities.loadImageIcon cache its result.
This is an automated email from the ASF dual-hosted git repository.
ebakke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
commit 43e319710e9263390601ce35f7cc2c4d1abdb76b
Author: Eirik Bakke
AuthorDate: Fri Jun 7 10:53:04 2019 -0400
Make ImageUtilities.loadImageIcon cache its result.
This fixes the test failures I just introduced in ActionsTest. It also
ensures
that everything that was cached in ImageUtilities before still remains
cached
after the recent changes.
Also use System.identityHashCode(image) rather than image.hashCode in
ImageUtilities' internal cache key classes, to be consistent with using
referential equality in equals() implementations.
---
.../src/org/openide/util/ImageUtilities.java | 15 +++
.../src/org/openide/util/ImageUtilitiesTest.java | 22 +-
2 files changed, 28 insertions(+), 9 deletions(-)
diff --git a/platform/openide.util.ui/src/org/openide/util/ImageUtilities.java
b/platform/openide.util.ui/src/org/openide/util/ImageUtilities.java
index 5171bd9..4af5cc8 100644
--- a/platform/openide.util.ui/src/org/openide/util/ImageUtilities.java
+++ b/platform/openide.util.ui/src/org/openide/util/ImageUtilities.java
@@ -216,7 +216,7 @@ public final class ImageUtilities {
if( image == null ) {
return null;
}
-return IconImageIcon.create(image);
+return image.asImageIcon();
}
private static boolean isDarkLaF() {
@@ -844,7 +844,7 @@ public final class ImageUtilities {
@Override
public int hashCode() {
int hash = ((x << 3) ^ y) << 4;
-hash = hash ^ baseImage.hashCode() ^ overlayImage.hashCode();
+hash = hash ^ System.identityHashCode(baseImage) ^
System.identityHashCode(overlayImage);
return hash;
}
@@ -878,8 +878,7 @@ public final class ImageUtilities {
@Override
public int hashCode() {
-int hash = image.hashCode() ^ str.hashCode();
-return hash;
+return System.identityHashCode(image) ^ str.hashCode();
}
@Override
@@ -943,6 +942,8 @@ public final class ImageUtilities {
// May be null.
final Icon delegateIcon;
final URL url;
+// May be null.
+ImageIcon imageIconVersion;
public static ToolTipImage createNew(String toolTipText, Image image,
URL url) {
ImageUtilities.ensureLoaded(image);
@@ -980,6 +981,12 @@ public final class ImageUtilities {
this.url = url;
}
+public synchronized ImageIcon asImageIcon() {
+ if (imageIconVersion == null)
+imageIconVersion = IconImageIcon.create(this);
+ return imageIconVersion;
+}
+
public ToolTipImage(Icon delegateIcon, String toolTipText, int
imageType) {
// BufferedImage must have width/height > 0.
super(Math.max(1, delegateIcon.getIconWidth()),
diff --git
a/platform/openide.util.ui/test/unit/src/org/openide/util/ImageUtilitiesTest.java
b/platform/openide.util.ui/test/unit/src/org/openide/util/ImageUtilitiesTest.java
index de8f537..be2eb29 100644
---
a/platform/openide.util.ui/test/unit/src/org/openide/util/ImageUtilitiesTest.java
+++
b/platform/openide.util.ui/test/unit/src/org/openide/util/ImageUtilitiesTest.java
@@ -242,6 +242,18 @@ public class ImageUtilitiesTest extends TestCase {
assertEquals("Tool tip text should be empty, but it is " + str,
expected, str);
}
+public void testLoadImageCached() {
+Image image1 =
ImageUtilities.loadImage("org/openide/util/testimage.png", false);
+Image image2 =
ImageUtilities.loadImage("org/openide/util/testimage.png", false);
+assertSame("Expected same instance", image1, image2);
+}
+
+public void testLoadImageIconCached() {
+ImageIcon icon1 =
ImageUtilities.loadImageIcon("org/openide/util/testimage.png", false);
+ImageIcon icon2 =
ImageUtilities.loadImageIcon("org/openide/util/testimage.png", false);
+assertSame("Expected same instance", icon1, icon2);
+}
+
public void testConversions() {
/* Note: these are rather implementation-oriented tests.
Implementation changes in
ImageUtilities (addition or removal of caches etc.) might require this
test to be
@@ -275,18 +287,18 @@ public class ImageUtilitiesTest extends TestCase {
/* An Icon/Image loaded via loadImage can be freely passed through
icon2Image/image2Icon
without a new instance being created. */
-assertEquals("Should be same instance",
+assertSame("Should be same instance",
image,
icon2Image(imageIcon));
-assertEquals("Should be same instance",
+assertSame("Should be same instance",
icon2Image(imag
[jira] [Commented] (NETBEANS-1204) Make Wicket generated Web-Apps work
[
https://issues.apache.org/jira/browse/NETBEANS-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858713#comment-16858713
]
Pete Whelpton commented on NETBEANS-1204:
-
I think this is really a bug/oversight with the Wicket Quickstart Archetype.
If you compile the quickstart generated application and try to deploy to
GlassFish via the GlassFish admin GUI, you will get the same error:
{{Error occurred during deployment: Exception while deploying the app
[myproject-1.0-SNAPSHOT] : org.xml.sax.SAXParseExceptionpublicId:
file:/C:/apps/glassfish51/glassfish/lib/schemas/web-app_3_1.xsd; lineNumber:
26; columnNumber: 27; Deployment descriptor file WEB-INF/web.xml in archive
[myproject-1.0-SNAPSHOT]. TargetNamespace.1: Expecting namespace
'http://java.sun.com/xml/ns/javaee', but the target namespace of the schema
document is 'http://xmlns.jcp.org/xml/ns/javaee'.. Please see server.log for
more details.}}
GlassFish appears to validate the web.xml before it will accept it. The
problem is that in the Wicket quickstart web.xml they have:
{{http://java.sun.com/xml/ns/javaee"}}
But as per [Java EE: XML Schemas for Java EE Deployment
Descriptors|[https://www.oracle.com/webfolder/technetwork/jsc/xml/ns/javaee/index.html]]:
{{All new schemas are in the [http://xmlns.jcp.org/xml/ns/javaee/] namespace.
Most older schemas remain in the [http://java.sun.com/xml/ns/javaee/]
namespace.}}
So any web.xml referencing web_app_3_1.xsd or web_app_4_0.xsd should be:
{{http://xmlns.jcp.org/xml/ns/javaee/]"}}
Making this simple change means GlassFish will accept the .war file for
deployment
> Make Wicket generated Web-Apps work
> ---
>
> Key: NETBEANS-1204
> URL: https://issues.apache.org/jira/browse/NETBEANS-1204
> Project: NetBeans
> Issue Type: Improvement
> Components: serverplugins - GlassFish
>Affects Versions: 8.2
>Reporter: Peter Nabbefeld
>Priority: Major
>
> Could not yet test with NB 9.0, so added only version 8.2.
> Added Glassfish 5 as a Glassfish server type, but when I try to run my
> project, I get the following error:
> java.io.IOException: org.xml.sax.SAXParseExceptionpublicId:
> [file:/opt/glassfish5/glassfish/lib/schemas/web-app_3_1.xsd|file:///opt/glassfish5/glassfish/lib/schemas/web-app_3_1.xsd];
> lineNumber: 8; columnNumber: 27; Deployment descriptor file WEB-INF/web.xml
> in archive [PrivateCookingReceipes-1.0-SNAPSHOT]. TargetNamespace.1:
> Namespace 'http://java.sun.com/xml/ns/javaee' wird erwartet, aber der
> Ziel-Namespace des Schemadokuments ist '[http://xmlns.jcp.org/xml/ns/javaee'.]
> Sorry for the German message. It says the target namespace of the web.xml
> schema does not fit, obviously this is checked by the glassfish plugin
> (expected 'http://java.sun.com/xml/ns/javaee' but found
> '[http://xmlns.jcp.org/xml/ns/javaee'|http://xmlns.jcp.org/xml/ns/javaee'.]).
> Probably it'd be sufficient to just test for both namespaces depending on
> glassfish version.
>
> While I first thought it's a problem with the Glassfish version, it turns out
> to be a problem with the web.xml generated by Wicket Quickstart. I replaced
> the schema declaration with another one copied from a web.xml generated by
> NetBeans, after this change I can start my web app.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-2649) Output tab name truncated
[
https://issues.apache.org/jira/browse/NETBEANS-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rangi Keen updated NETBEANS-2649:
-
Environment: Windows 10, JDK 11 (was: Windows 10)
> Output tab name truncated
> -
>
> Key: NETBEANS-2649
> URL: https://issues.apache.org/jira/browse/NETBEANS-2649
> Project: NetBeans
> Issue Type: Bug
> Components: platform - Window System
>Affects Versions: 8.2, 11.0
> Environment: Windows 10, JDK 11
>Reporter: Rangi Keen
>Priority: Trivial
> Attachments: Truncated Output Tab.png
>
>
> When running NetBeans with JDK 11 (specifically AdoptOpenJDK 11.0.3+7) on
> Windows 10, the Output tab name is truncated and appears as "Outp..." rather
> than "Output".
> The problem appears to be related to text antialiasing not being used in the
> offscreen graphics while it is used when actually rendering the tab contents.
> The widths of some characters, notably the wider capital letters such as "O",
> differ when "LCD HRGB antialiasing" (and perhaps others) is used.
> Adding the following to
> {{BasicScrollingTabDisplayerUI.getOffscreenGraphics()}} appears to resolve
> the issue:
> {code:java}
> public static Graphics2D getOffscreenGraphics() {
> ...
> Graphics2D graphics = (Graphics2D) result.getGraphics();
> graphics.setRenderingHint(RenderingHints.KEY_TEXT_ANTIALIASING,
> UIManager.getDefaults().get(RenderingHints.KEY_TEXT_ANTIALIASING));
> return graphics;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-2651) NPE from ArtificialFeaturesProvider.addVersion
Jesse Glick created NETBEANS-2651:
-
Summary: NPE from ArtificialFeaturesProvider.addVersion
Key: NETBEANS-2651
URL: https://issues.apache.org/jira/browse/NETBEANS-2651
Project: NetBeans
Issue Type: Bug
Reporter: Jesse Glick
Not sure what triggered this; I had been working with some Maven projects,
running priming builds, that sort of thing. Nothing unusual. I think I have
seen it before. Dev
20190604-[7b3a7bf2caac|https://github.com/jglick/incubator-netbeans/commit/7b3a7bf2caac]
{code:none}
SEVERE [org.openide.util.RequestProcessor]: Error in RequestProcessor
org.netbeans.modules.ide.ergonomics.fod.FindComponentModules$2
java.lang.NullPointerException
at
org.netbeans.modules.autoupdate.updateprovider.ArtificialFeaturesProvider.addVersion(ArtificialFeaturesProvider.java:206)
at
org.netbeans.modules.autoupdate.updateprovider.ArtificialFeaturesProvider.createFeatureItem(ArtificialFeaturesProvider.java:171)
at
org.netbeans.modules.autoupdate.services.FeatureUpdateUnitImpl.initializeFeature(FeatureUpdateUnitImpl.java:157)
at
org.netbeans.modules.autoupdate.services.FeatureUpdateUnitImpl.getInstalled(FeatureUpdateUnitImpl.java:52)
at
org.netbeans.api.autoupdate.UpdateUnit.getInstalled(UpdateUnit.java:59)
at
org.netbeans.modules.autoupdate.services.UpdateManagerImpl$Cache.createMaps(UpdateManagerImpl.java:329)
at
org.netbeans.modules.autoupdate.services.UpdateManagerImpl$Cache.createMapToken2InstalledProviders(UpdateManagerImpl.java:294)
at
org.netbeans.modules.autoupdate.services.UpdateManagerImpl.getInstalledProviders(UpdateManagerImpl.java:126)
at
org.netbeans.modules.autoupdate.services.DependencyAggregator.getRequested(DependencyAggregator.java:95)
at
org.netbeans.modules.autoupdate.services.Utilities.handleDependency(Utilities.java:936)
at
org.netbeans.modules.autoupdate.services.Utilities.processDependencies(Utilities.java:836)
at
org.netbeans.modules.autoupdate.services.Utilities.findRequiredUpdateElements(Utilities.java:623)
at
org.netbeans.modules.autoupdate.services.OperationValidator$InstallValidator.getRequiredElementsImpl(OperationValidator.java:190)
at
org.netbeans.modules.autoupdate.services.OperationValidator.getRequiredElements(OperationValidator.java:98)
at
org.netbeans.modules.autoupdate.services.OperationContainerImpl$OperationInfoImpl.getRequiredElements(OperationContainerImpl.java:441)
at
org.netbeans.api.autoupdate.OperationContainer$OperationInfo.getRequiredElements(OperationContainer.java:371)
at
org.netbeans.modules.ide.ergonomics.fod.FindComponentModules.getAllForInstall(FindComponentModules.java:432)
at
org.netbeans.modules.ide.ergonomics.fod.FindComponentModules.findComponentModules(FindComponentModules.java:283)
at
org.netbeans.modules.ide.ergonomics.fod.FindComponentModules.access$000(FindComponentModules.java:59)
at
org.netbeans.modules.ide.ergonomics.fod.FindComponentModules$2.run(FindComponentModules.java:235)
at
org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
at
org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
[catch] at
org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-2577) Maven library excluded because of disabling apache-commons module
[
https://issues.apache.org/jira/browse/NETBEANS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Svatopluk Dedic resolved NETBEANS-2577.
---
Resolution: Fixed
> Maven library excluded because of disabling apache-commons module
> --
>
> Key: NETBEANS-2577
> URL: https://issues.apache.org/jira/browse/NETBEANS-2577
> Project: NetBeans
> Issue Type: Bug
> Components: apisupport - Harness
>Affects Versions: 11.0
>Reporter: Svatopluk Dedic
>Priority: Major
> Labels: pull-request-available
> Fix For: Next
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Our NB-platform based app does the following in the *platform.properties* file
>
> {noformat}
> cluster.path=\
>${nbplatform.active.dir}/extide:\
>${nbplatform.active.dir}/harness:\
>${nbplatform.active.dir}/ide:\
> ${nbplatform.active.dir}/java
> #
> disabled.modules=\
> org.apache.commons.lang,\
> #
> {noformat}
>
> Whena I build a distribution, (*ant build-zip*), the file
> *java/maven/lib/commons-lang-2.6.jar* is excluded, because:
> * it is a OSGi bundle
> * it's *Bundle-Symbolic-Name* matches the excluded module's codename
> Despite the file is in a different directory, where NB modules shouldn't be
> placed, it's recognized as a module and excluded from the distribution.
> The bug causes *maven embedder* to fail during startup, since it can't link
> to **its libraries.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-2577] Prevent Maven libraries from being exluded
This is an automated email from the ASF dual-hosted git repository.
sdedic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new ee2ad24 [NETBEANS-2577] Prevent Maven libraries from being exluded
new 4a8d8bf Merge pull request #1271 from
sdedic/bugfix/2577-filtering_modules
ee2ad24 is described below
commit ee2ad247a45cc9d177a11a9c932cf27ade4f8b34
Author: Svata Dedic
AuthorDate: Thu May 30 15:01:01 2019 +0200
[NETBEANS-2577] Prevent Maven libraries from being exluded
---
.../org/netbeans/nbbuild/ModuleSelector.java | 36 +++---
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/nbbuild/antsrc/org/netbeans/nbbuild/ModuleSelector.java
b/nbbuild/antsrc/org/netbeans/nbbuild/ModuleSelector.java
index 321c156..fbe61a4 100644
--- a/nbbuild/antsrc/org/netbeans/nbbuild/ModuleSelector.java
+++ b/nbbuild/antsrc/org/netbeans/nbbuild/ModuleSelector.java
@@ -78,24 +78,6 @@ public final class ModuleSelector extends BaseExtendSelector
{
}
String module = null;
-if (file.getName().endsWith(".jar")) {
-try (JarFile jar = new JarFile(file)) {
-Manifest m = jar.getManifest();
-if (m != null) {
-module = m.getMainAttributes().getValue("OpenIDE-Module");
// NOI18N
-if (module == null && !isExt(file)) {
-module =
m.getMainAttributes().getValue("Bundle-SymbolicName"); // NOI18N
-int semicolon = module == null ? -1 :
module.indexOf(';');
-if (semicolon >= 0) {
-module = module.substring(0, semicolon);
-}
-}
-}
-} catch (IOException ex) {
-throw new BuildException("Problem with " + file + ": " + ex,
ex, getLocation());
-}
-}
-
String name = file.getName();
File p = file.getParentFile();
for(;;) {
@@ -124,6 +106,24 @@ public final class ModuleSelector extends
BaseExtendSelector {
name = p.getName() + '/' + name;
p = p.getParentFile();
}
+
+if (module == null && name.endsWith(".jar")) {
+try (JarFile jar = new JarFile(file)) {
+Manifest m = jar.getManifest();
+if (m != null) {
+module = m.getMainAttributes().getValue("OpenIDE-Module");
// NOI18N
+if (module == null && !isExt(file)) {
+module =
m.getMainAttributes().getValue("Bundle-SymbolicName"); // NOI18N
+int semicolon = module == null ? -1 :
module.indexOf(';');
+if (semicolon >= 0) {
+module = module.substring(0, semicolon);
+}
+}
+}
+} catch (IOException ex) {
+throw new BuildException("Problem with " + file + ": " + ex,
ex, getLocation());
+}
+}
if (module == null) {
log("No module in: " + file, Project.MSG_VERBOSE);
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
