[netbeans] branch master updated (735dcf7 -> 77cd083)

2021-11-14 Thread jlahoda
This is an automated email from the ASF dual-hosted git repository.

jlahoda pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git.


from 735dcf7  Merge pull request #3318 from 
matthiasblaesing/client_project_catch_exception
 add 77cd083  Dynamically switching from all-file processing to single-file 
processing of multi file JavaSources.

No new revisions were added by this update.

Summary of changes:
 ide/parsing.api/apichanges.xml |  15 +++
 .../modules/parsing/api/ParserManager.java |  12 +-
 .../modules/parsing/impl/ParserAccessor.java   |   1 +
 .../org/netbeans/modules/parsing/spi/Parser.java   |  22 +++-
 .../java/source/parsing/CompilationInfoImpl.java   |  93 +++---
 .../modules/java/source/parsing/JavacParser.java   | 136 +++--
 .../java/source/parsing/JavacParserResult.java |   5 +
 .../netbeans/api/java/source/JavaSourceTest.java   |   4 -
 .../java/source/parsing/JavacParserTest.java   | 135 ++--
 .../org/netbeans/lib/nbjavac/services/NBAttr.java  |   8 ++
 10 files changed, 333 insertions(+), 98 deletions(-)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-3042) can't see loggers (log4j2) created from apps deployed on Payara servers

2021-11-14 Thread jose luis romero (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443416#comment-17443416
 ] 

jose luis romero edited comment on NETBEANS-3042 at 11/14/21, 7:19 PM:
---

still happens on 12.5 and with Glassfish 5 too
PD: removing any %d formatting will make the log show up, it works
PD: the problem is HH, if you remove %d{{*}HH:{*}mm:ss} it also works, of 
course the |# is still there


was (Author: firuzzz):
still happens on 12.5 and with Glassfish 5 too
PD: removing any %d formatting will make the log show up, it works
PD: the problem is HH, if you remove %d{*HH:*mm:ss} it also works, of course 
the |# is still there

> can't see loggers (log4j2) created from apps deployed on Payara servers
> ---
>
> Key: NETBEANS-3042
> URL: https://issues.apache.org/jira/browse/NETBEANS-3042
> Project: NetBeans
>  Issue Type: Bug
>  Components: ide - Logger
>Affects Versions: 11.0, 12.0, 11.1, 11.2, 11.3, 12.1, 12.5
> Environment: Windows 10, jdk 1.8, CentOS 7.x with AdoptOpenJDK 8 and 
> 11, Windows 10 with AdoptOpenJDK 8 and 11.
>Reporter: jose luis romero
>Assignee: Robert Hoffmann
>Priority: Major
> Attachments: screenshot-1.png
>
>
> I can't see the logs (log4j2) generated by my apps deployed in Payara, they 
> are always empty.
> Tried to make a clean re-installation (no cache, no import config) but didn't 
> work
> Initially, I thought that I messed up some config file so I made a post 
> [https://stackoverflow.com/questions/57679272/i-cant-see-logs-from-apps-on-payara-4-1-just-on-netbeans-console-tab|stackOverflow]
>  but no, it is a Netbeans issue introduced in 11.1 version + payara 5



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-3042) can't see loggers (log4j2) created from apps deployed on Payara servers

2021-11-14 Thread jose luis romero (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443416#comment-17443416
 ] 

jose luis romero edited comment on NETBEANS-3042 at 11/14/21, 7:18 PM:
---

still happens on 12.5 and with Glassfish 5 too
PD: removing any %d formatting will make the log show up, it works
PD: the problem is HH, if you remove %d{*HH:*mm:ss} it also works, of course 
the |# is still there


was (Author: firuzzz):
still happens on 12.5 and with Glassfish 5 too
PD: removing any %d formatting will make the log show up, it works
PD: the problem is HH, if you remove %d{{color:red}*HH:*{color}mm:ss} it also 
works, of course the |# is still there

> can't see loggers (log4j2) created from apps deployed on Payara servers
> ---
>
> Key: NETBEANS-3042
> URL: https://issues.apache.org/jira/browse/NETBEANS-3042
> Project: NetBeans
>  Issue Type: Bug
>  Components: ide - Logger
>Affects Versions: 11.0, 12.0, 11.1, 11.2, 11.3, 12.1, 12.5
> Environment: Windows 10, jdk 1.8, CentOS 7.x with AdoptOpenJDK 8 and 
> 11, Windows 10 with AdoptOpenJDK 8 and 11.
>Reporter: jose luis romero
>Assignee: Robert Hoffmann
>Priority: Major
> Attachments: screenshot-1.png
>
>
> I can't see the logs (log4j2) generated by my apps deployed in Payara, they 
> are always empty.
> Tried to make a clean re-installation (no cache, no import config) but didn't 
> work
> Initially, I thought that I messed up some config file so I made a post 
> [https://stackoverflow.com/questions/57679272/i-cant-see-logs-from-apps-on-payara-4-1-just-on-netbeans-console-tab|stackOverflow]
>  but no, it is a Netbeans issue introduced in 11.1 version + payara 5



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-3042) can't see loggers (log4j2) created from apps deployed on Payara servers

2021-11-14 Thread jose luis romero (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443416#comment-17443416
 ] 

jose luis romero edited comment on NETBEANS-3042 at 11/14/21, 7:17 PM:
---

still happens on 12.5 and with Glassfish 5 too
PD: removing any %d formatting will make the log show up, it works
PD: the problem is HH, if you remove %d{{color:red}*HH:*{color}mm:ss} it also 
works, of course the |# is still there


was (Author: firuzzz):
still happens on 12.5 and with Glassfish 5 too
PD: removing any %d formatting will make the log show up, it works

> can't see loggers (log4j2) created from apps deployed on Payara servers
> ---
>
> Key: NETBEANS-3042
> URL: https://issues.apache.org/jira/browse/NETBEANS-3042
> Project: NetBeans
>  Issue Type: Bug
>  Components: ide - Logger
>Affects Versions: 11.0, 12.0, 11.1, 11.2, 11.3, 12.1, 12.5
> Environment: Windows 10, jdk 1.8, CentOS 7.x with AdoptOpenJDK 8 and 
> 11, Windows 10 with AdoptOpenJDK 8 and 11.
>Reporter: jose luis romero
>Assignee: Robert Hoffmann
>Priority: Major
> Attachments: screenshot-1.png
>
>
> I can't see the logs (log4j2) generated by my apps deployed in Payara, they 
> are always empty.
> Tried to make a clean re-installation (no cache, no import config) but didn't 
> work
> Initially, I thought that I messed up some config file so I made a post 
> [https://stackoverflow.com/questions/57679272/i-cant-see-logs-from-apps-on-payara-4-1-just-on-netbeans-console-tab|stackOverflow]
>  but no, it is a Netbeans issue introduced in 11.1 version + payara 5



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: Handle invalid package.json only containing a single string

2021-11-14 Thread matthiasblaesing
This is an automated email from the ASF dual-hosted git repository.

matthiasblaesing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 6b6b6f9  Handle invalid package.json only containing a single string
 new 735dcf7  Merge pull request #3318 from 
matthiasblaesing/client_project_catch_exception
6b6b6f9 is described below

commit 6b6b6f9d8e8fe3ab9c2f849f855f2095d21b500c
Author: Matthias Bläsing 
AuthorDate: Fri Nov 12 22:18:41 2021 +0100

Handle invalid package.json only containing a single string

If package.json is a string (invalid format) a ClassCastException is
raised and not a ParseException. The ClassCastException should be
handled identically to the other fatal exceptions.
---
 .../netbeans/modules/web/clientproject/ClientSideProjectConvertor.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/webcommon/web.clientproject/src/org/netbeans/modules/web/clientproject/ClientSideProjectConvertor.java
 
b/webcommon/web.clientproject/src/org/netbeans/modules/web/clientproject/ClientSideProjectConvertor.java
index f694a57..b2fc53e 100644
--- 
a/webcommon/web.clientproject/src/org/netbeans/modules/web/clientproject/ClientSideProjectConvertor.java
+++ 
b/webcommon/web.clientproject/src/org/netbeans/modules/web/clientproject/ClientSideProjectConvertor.java
@@ -109,7 +109,7 @@ public final class ClientSideProjectConvertor implements 
ProjectConvertor {
 if (name instanceof String) {
 return (String) name;
 }
-} catch (ParseException | IOException ex) {
+} catch (ParseException | IOException | ClassCastException ex) {
 LOGGER.log(Level.FINE, jsonFile.getPath(), ex);
 }
 return null;

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-3042) can't see loggers (log4j2) created from apps deployed on Payara servers

2021-11-14 Thread jose luis romero (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443416#comment-17443416
 ] 

jose luis romero edited comment on NETBEANS-3042 at 11/14/21, 6:32 PM:
---

still happens on 12.5 and with Glassfish 5 too
PD: removing any %d formatting will make the log show up, it works


was (Author: firuzzz):
still happens on 12.5 and with Glassfish 5 too

> can't see loggers (log4j2) created from apps deployed on Payara servers
> ---
>
> Key: NETBEANS-3042
> URL: https://issues.apache.org/jira/browse/NETBEANS-3042
> Project: NetBeans
>  Issue Type: Bug
>  Components: ide - Logger
>Affects Versions: 11.0, 12.0, 11.1, 11.2, 11.3, 12.1, 12.5
> Environment: Windows 10, jdk 1.8, CentOS 7.x with AdoptOpenJDK 8 and 
> 11, Windows 10 with AdoptOpenJDK 8 and 11.
>Reporter: jose luis romero
>Assignee: Robert Hoffmann
>Priority: Major
> Attachments: screenshot-1.png
>
>
> I can't see the logs (log4j2) generated by my apps deployed in Payara, they 
> are always empty.
> Tried to make a clean re-installation (no cache, no import config) but didn't 
> work
> Initially, I thought that I messed up some config file so I made a post 
> [https://stackoverflow.com/questions/57679272/i-cant-see-logs-from-apps-on-payara-4-1-just-on-netbeans-console-tab|stackOverflow]
>  but no, it is a Netbeans issue introduced in 11.1 version + payara 5



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3042) can't see loggers (log4j2) created from apps deployed on Payara servers

2021-11-14 Thread jose luis romero (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443416#comment-17443416
 ] 

jose luis romero commented on NETBEANS-3042:


still happens on 12.5 and with Glassfish 5 too

> can't see loggers (log4j2) created from apps deployed on Payara servers
> ---
>
> Key: NETBEANS-3042
> URL: https://issues.apache.org/jira/browse/NETBEANS-3042
> Project: NetBeans
>  Issue Type: Bug
>  Components: ide - Logger
>Affects Versions: 11.0, 12.0, 11.1, 11.2, 11.3, 12.1, 12.5
> Environment: Windows 10, jdk 1.8, CentOS 7.x with AdoptOpenJDK 8 and 
> 11, Windows 10 with AdoptOpenJDK 8 and 11.
>Reporter: jose luis romero
>Assignee: Robert Hoffmann
>Priority: Major
> Attachments: screenshot-1.png
>
>
> I can't see the logs (log4j2) generated by my apps deployed in Payara, they 
> are always empty.
> Tried to make a clean re-installation (no cache, no import config) but didn't 
> work
> Initially, I thought that I messed up some config file so I made a post 
> [https://stackoverflow.com/questions/57679272/i-cant-see-logs-from-apps-on-payara-4-1-just-on-netbeans-console-tab|stackOverflow]
>  but no, it is a Netbeans issue introduced in 11.1 version + payara 5



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-3042) can't see loggers (log4j2) created from apps deployed on Payara servers

2021-11-14 Thread jose luis romero (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jose luis romero updated NETBEANS-3042:
---
Affects Version/s: 12.5

> can't see loggers (log4j2) created from apps deployed on Payara servers
> ---
>
> Key: NETBEANS-3042
> URL: https://issues.apache.org/jira/browse/NETBEANS-3042
> Project: NetBeans
>  Issue Type: Bug
>  Components: ide - Logger
>Affects Versions: 11.0, 12.0, 11.1, 11.2, 11.3, 12.1, 12.5
> Environment: Windows 10, jdk 1.8, CentOS 7.x with AdoptOpenJDK 8 and 
> 11, Windows 10 with AdoptOpenJDK 8 and 11.
>Reporter: jose luis romero
>Assignee: Robert Hoffmann
>Priority: Major
> Attachments: screenshot-1.png
>
>
> I can't see the logs (log4j2) generated by my apps deployed in Payara, they 
> are always empty.
> Tried to make a clean re-installation (no cache, no import config) but didn't 
> work
> Initially, I thought that I messed up some config file so I made a post 
> [https://stackoverflow.com/questions/57679272/i-cant-see-logs-from-apps-on-payara-4-1-just-on-netbeans-console-tab|stackOverflow]
>  but no, it is a Netbeans issue introduced in 11.1 version + payara 5



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-2842) Using of deprecated pack200 tool in nbm packaging

2021-11-14 Thread Eric Bresie (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443406#comment-17443406
 ] 

Eric Bresie edited comment on NETBEANS-2842 at 11/14/21, 5:32 PM:
--

in OperationContainer, there is "setUnpack200" method with details mentioning 
the removal. 
Javadoc indicates

  /** Specifies location of unpack200 executable. {@code unpack200} has been
 * removed from JDK 14. As such it is not possible to unpack older NBM
 * files without providing alternative JDK implementation of this file.
 *
 * @param executable path to the executable
 * @since 1.65
 */

A lot of this appears to have been added as part of commit f6f2455


was (Author: ebresie):
in OperationContainer, there is "setUnpack200" method with details mentioning 
the removal. 
Javadoc indicates

  /** Specifies location of unpack200 executable. {@code unpack200} has been
 * removed from JDK 14. As such it is not possible to unpack older NBM
 * files without providing alternative JDK implementation of this file.
 *
 * @param executable path to the executable
 * @since 1.65
 */


> Using of deprecated pack200 tool in nbm packaging
> -
>
> Key: NETBEANS-2842
> URL: https://issues.apache.org/jira/browse/NETBEANS-2842
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Plugin Manager
>Affects Versions: 11.3
>Reporter: Benjamin Graf
>Priority: Critical
>
> Netbeans plugins are mostly compressed in size by the JDK internal pack200 
> tool which is deprecated since JDK 11 ([https://openjdk.java.net/jeps/336]). 
> It should be thought about an alternative as it might get removed in next JDK 
> releases.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2842) Using of deprecated pack200 tool in nbm packaging

2021-11-14 Thread Eric Bresie (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443406#comment-17443406
 ] 

Eric Bresie commented on NETBEANS-2842:
---

in OperationContainer, there is "setUnpack200" method with details mentioning 
the removal. 
Javadoc indicates

  /** Specifies location of unpack200 executable. {@code unpack200} has been
 * removed from JDK 14. As such it is not possible to unpack older NBM
 * files without providing alternative JDK implementation of this file.
 *
 * @param executable path to the executable
 * @since 1.65
 */


> Using of deprecated pack200 tool in nbm packaging
> -
>
> Key: NETBEANS-2842
> URL: https://issues.apache.org/jira/browse/NETBEANS-2842
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Plugin Manager
>Affects Versions: 11.3
>Reporter: Benjamin Graf
>Priority: Critical
>
> Netbeans plugins are mostly compressed in size by the JDK internal pack200 
> tool which is deprecated since JDK 11 ([https://openjdk.java.net/jeps/336]). 
> It should be thought about an alternative as it might get removed in next JDK 
> releases.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2842) Using of deprecated pack200 tool in nbm packaging

2021-11-14 Thread Eric Bresie (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443394#comment-17443394
 ] 

Eric Bresie commented on NETBEANS-2842:
---

[~peter.firmst...@zeus.net.au] you indicated earlier

{noformat}
The Apache Harmony version doesn't yet pass all OpenJDK pack 200 tests,
however the Apache Harmony code is easier to modify, so will be easier
to update to support later bytecode.
{noformat}

Is there any details on how the openjdk pack 200 tests are setup to run against 
Apache Harmony code?


> Using of deprecated pack200 tool in nbm packaging
> -
>
> Key: NETBEANS-2842
> URL: https://issues.apache.org/jira/browse/NETBEANS-2842
> Project: NetBeans
>  Issue Type: Bug
>  Components: platform - Plugin Manager
>Affects Versions: 11.3
>Reporter: Benjamin Graf
>Priority: Critical
>
> Netbeans plugins are mostly compressed in size by the JDK internal pack200 
> tool which is deprecated since JDK 11 ([https://openjdk.java.net/jeps/336]). 
> It should be thought about an alternative as it might get removed in next JDK 
> releases.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-4245) Cannot start Glass Fish 5 server

2021-11-14 Thread Josh Juneau (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443390#comment-17443390
 ] 

Josh Juneau commented on NETBEANS-4245:
---

Can someone please test to ensure that GlassFish 6 works okay with JDK 11?  I 
have no issues using that combination, but GlassFish 5 only works with JDK 8 so 
this is not really an issue with Apache NetBeans.  Another tester for GlassFish 
6/JDK 11 would be greatthanks.

> Cannot start Glass Fish 5 server 
> -
>
> Key: NETBEANS-4245
> URL: https://issues.apache.org/jira/browse/NETBEANS-4245
> Project: NetBeans
>  Issue Type: Bug
>  Components: serverplugins - GlassFish
>Affects Versions: 12.0
> Environment: Product Version: Apache NetBeans IDE 12.0-beta3
> Java: 11.0.6; OpenJDK 64-Bit Server VM 11.0.6+10
> Runtime: OpenJDK Runtime Environment 11.0.6+10
> System: Mac OS X version 10.15.3 running on x86_64; UTF-8; en_IN (nb)
>Reporter: Manikantan Narender Nath
>Assignee: Josh Juneau
>Priority: Major
>  Labels: netcat
> Attachments: cannot-start-gf510-server.m4v
>
>
> Steps
>  # Start NetBeans with clean user dir
>  # Activate Java SE and Java WEb & EE plugins
>  # Switch to services tab
>  # RMB on Servers Tab
>  # Select Glassfish from list of server types
>  # Select a folder which does not have Glassfish (so that we can install 
> fresh)
>  # Select Glassfish 510 from drop down & accept license agreement
>  # Click download button (wait for it to complete)
>  # Complete the wizard steps
>  # Verify that Glassfish is added to the Servers node
>  # Right click newly added Glassfish server and click Start server
> *Expected result* 
> Glassfish should start
> *Actual Result*
> Dialog displays with message "Cannot start glassfish with default Java 
> platform" (see attachment Cannot-start-gf10.m4v)
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-5781) Priming gradle build does not honor the gradle version set in Options/Java/Gradle

2021-11-14 Thread Laszlo Kishalmi (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laszlo Kishalmi resolved NETBEANS-5781.
---
Resolution: Not A Bug

> Priming gradle build does not honor the gradle version set in 
> Options/Java/Gradle
> -
>
> Key: NETBEANS-5781
> URL: https://issues.apache.org/jira/browse/NETBEANS-5781
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Gradle
>Affects Versions: 12.4
> Environment: Ubuntu 20.04, AdoptOpenjdk 16.0.1, Netbeans 12.4.  JDK 
> and Netbeans were installed by downloads, not by the Ubuntu package manager.
>  
>Reporter: Guntram Blohm
>Assignee: Laszlo Kishalmi
>Priority: Major
>  Labels: gradle, version
> Attachments: Screenshot_2021-06-15_11-31-49.png
>
>
> When opening a gradle project, Netbeans does not honor the gradle version set 
> in Tools/Options/Java/Gradle, instead, it seems to always use gradle 7.0.0.
> I have an older project that uses deprecated features, so it needs gradle 
> 4.10.2 to load. Even when I set "Use Standard Gradle Version" to "4.10.2", 
> Netbeans uses gradle 7 to load the project, decides it can't, and makes the 
> project unusable. Pressing the "hammer" button (F11) to build the project 
> correctly uses Gradle 4.10.2 and builds the project.
> Attached screenshot shows, after "reload project", how Netbeans uses Gradle 
> 7.0 even with gradle 4.10.2 selected in Options.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-6004) Gradle plugin should identify the gradle versions that it supports.

2021-11-14 Thread Laszlo Kishalmi (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laszlo Kishalmi resolved NETBEANS-6004.
---
Fix Version/s: NB13
   Resolution: Fixed

> Gradle plugin should identify the gradle versions that it supports.
> ---
>
> Key: NETBEANS-6004
> URL: https://issues.apache.org/jira/browse/NETBEANS-6004
> Project: NetBeans
>  Issue Type: Improvement
>  Components: projects - Gradle
>Affects Versions: 12.4, 12.5
>Reporter: Mark Flacy
>Assignee: Laszlo Kishalmi
>Priority: Major
>  Labels: pull-request-available
> Fix For: NB13
>
> Attachments: image-2021-11-13-12-20-54-228.png
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I have had issues opening gradle projects at work whose gradle versions 
> differed wildly between 2.10 and 6.9.  I would like to be able to examine the 
> gradle plugin's description to see what versions of gradle the plugin 
> actually supports.
>  
> None of my company's projects are at a gradle version greater than or equal 
> to 7.0.  However,  every time I attempt to build I always get an error 
> message telling me
> _Could not run build action using connection to Gradle installation 
> '/Users/me/.gradle/wrapper/dists/gradle-7.0-bin//gradle-7.0_
>  
> Maybe the message is misleading.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-6004] Give info when the IDE's Java is not compatible with Gradle

2021-11-14 Thread lkishalmi
This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 3878d56  [NETBEANS-6004] Give info when the IDE's Java is not 
compatible with Gradle
3878d56 is described below

commit 3878d562a1b88a700584eefe9f99b8c440550755
Author: Laszlo Kishalmi 
AuthorDate: Sat Nov 13 12:37:51 2021 -0800

[NETBEANS-6004] Give info when the IDE's Java is not compatible with Gradle
---
 .../gradle/GradleJavaCompatProblemsProvider.java   | 96 ++
 .../api/execute/GradleDistributionManager.java | 18 +++-
 2 files changed, 110 insertions(+), 4 deletions(-)

diff --git 
a/extide/gradle/src/org/netbeans/modules/gradle/GradleJavaCompatProblemsProvider.java
 
b/extide/gradle/src/org/netbeans/modules/gradle/GradleJavaCompatProblemsProvider.java
new file mode 100644
index 000..52c7d2e
--- /dev/null
+++ 
b/extide/gradle/src/org/netbeans/modules/gradle/GradleJavaCompatProblemsProvider.java
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.gradle;
+
+import java.beans.PropertyChangeEvent;
+import java.beans.PropertyChangeListener;
+import java.beans.PropertyChangeSupport;
+import java.util.Collection;
+import java.util.Collections;
+import org.netbeans.api.project.Project;
+import org.netbeans.modules.gradle.api.NbGradleProject;
+import org.netbeans.modules.gradle.api.execute.GradleDistributionManager;
+import 
org.netbeans.modules.gradle.api.execute.GradleDistributionManager.GradleDistribution;
+import org.netbeans.modules.gradle.spi.execute.GradleDistributionProvider;
+import org.netbeans.spi.project.ProjectServiceProvider;
+import org.netbeans.spi.project.ui.ProjectProblemsProvider;
+import static 
org.netbeans.spi.project.ui.ProjectProblemsProvider.PROP_PROBLEMS;
+import org.openide.util.NbBundle;
+import org.openide.util.NbBundle.Messages;
+
+/**
+ *
+ * @author lkishalmi
+ */
+@ProjectServiceProvider(service = ProjectProblemsProvider.class, projectType = 
NbGradleProject.GRADLE_PROJECT_TYPE)
+public final class GradleJavaCompatProblemsProvider implements 
ProjectProblemsProvider {
+
+private final PropertyChangeSupport support = new 
PropertyChangeSupport(this);
+private final Project project;
+private final PropertyChangeListener listener;
+
+public GradleJavaCompatProblemsProvider(Project project) {
+this.project = project;
+listener = (PropertyChangeEvent evt) -> {
+if 
(NbGradleProject.PROP_PROJECT_INFO.equals(evt.getPropertyName())) {
+support.firePropertyChange(PROP_PROBLEMS, null, null);
+}
+};
+NbGradleProject.addPropertyChangeListener(project, listener);
+}
+
+@Override
+public void addPropertyChangeListener(PropertyChangeListener listener) {
+support.addPropertyChangeListener(listener);
+}
+
+@Override
+public void removePropertyChangeListener(PropertyChangeListener listener) {
+support.removePropertyChangeListener(listener);
+}
+
+@Messages({
+"LBL_JavaVersionMismatch=Unsupported Java Runtime",
+"# {0} - Java Version",
+"# {1} - Supported Java Version",
+"# {2} - Required Gradle Version",
+"# {3} - Forced Gradle Version",
+"TXT_JavaVersionMismatch=The IDE is running on Java {0} that is not 
supported by Gradle {2}.\n"
++ "The IDE will attempt to use Gradle {3} to gather the 
project information.\n\n"
++ "Either upgrade your Gradle version on your project or run 
the IDE on "
++ "Java {1} to avoid this problem!"
+})
+@Override
+public Collection getProblems() {
+GradleDistributionProvider pvd = 
project.getLookup().lookup(GradleDistributionProvider.class);
+if (pvd != null) {
+GradleDistribution dist = pvd.getGradleDistribution();
+if ((dist != null) && !dist.isCompatibleWithSystemJava()) {
+String javaVersion = 
System.getProperty("java.specification.version",