[netbeans] branch master updated: Simplified cancelHandle test.
This is an automated email from the ASF dual-hosted git repository.
sdedic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new ab81d41 Simplified cancelHandle test.
new ae6389a Merge pull request #3441 from sdedic/lsp/cancel-handle
ab81d41 is described below
commit ab81d41234d9c6a2a5f2d341273c0d14273415a1
Author: Svata Dedic
AuthorDate: Tue Jan 11 17:45:38 2022 +0100
Simplified cancelHandle test.
---
.../java/lsp/server/protocol/ServerTest.java | 132 +
1 file changed, 107 insertions(+), 25 deletions(-)
diff --git
a/java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java
b/java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java
index a95ff42..44b8a55 100644
---
a/java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java
+++
b/java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java
@@ -36,7 +36,6 @@ import java.net.URL;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
-import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
@@ -59,6 +58,7 @@ import javax.swing.Icon;
import javax.swing.event.ChangeListener;
import javax.swing.text.Document;
import javax.swing.text.StyledDocument;
+import static junit.framework.TestCase.assertEquals;
import static junit.framework.TestCase.assertNotNull;
import static junit.framework.TestCase.assertNull;
import org.eclipse.lsp4j.ApplyWorkspaceEditParams;
@@ -117,6 +117,7 @@ import org.eclipse.lsp4j.TextDocumentItem;
import org.eclipse.lsp4j.TextEdit;
import org.eclipse.lsp4j.TypeDefinitionParams;
import org.eclipse.lsp4j.VersionedTextDocumentIdentifier;
+import org.eclipse.lsp4j.WorkDoneProgressBegin;
import org.eclipse.lsp4j.WorkDoneProgressCancelParams;
import org.eclipse.lsp4j.WorkDoneProgressCreateParams;
import org.eclipse.lsp4j.WorkDoneProgressKind;
@@ -137,6 +138,7 @@ import org.netbeans.api.java.project.JavaProjectConstants;
import org.netbeans.api.java.queries.AnnotationProcessingQuery.Result;
import org.netbeans.api.java.queries.AnnotationProcessingQuery.Trigger;
import org.netbeans.api.java.source.JavaSource;
+import org.netbeans.api.progress.ProgressHandle;
import org.netbeans.api.project.FileOwnerQuery;
import org.netbeans.api.project.Project;
import org.netbeans.api.project.ProjectUtils;
@@ -151,6 +153,7 @@ import
org.netbeans.modules.java.lsp.server.refactoring.ChangeMethodParameterUI;
import org.netbeans.modules.java.lsp.server.refactoring.ParameterUI;
import org.netbeans.modules.java.lsp.server.ui.MockHtmlViewer;
import org.netbeans.modules.java.source.BootClassPathUtil;
+import org.netbeans.modules.parsing.api.ResultIterator;
import org.netbeans.modules.parsing.impl.indexing.implspi.CacheFolderProvider;
import org.netbeans.spi.java.classpath.ClassPathProvider;
import org.netbeans.spi.java.classpath.support.ClassPathSupport;
@@ -4846,8 +4849,85 @@ public class ServerTest extends NbTestCase {
}
}
-public void testCancelProgressHandle() throws Exception {
+private static volatile ProgressCommand progressCommandInstance;
+
+@ServiceProvider(service = CodeActionsProvider.class)
+public static class ProgressCommand extends CodeActionsProvider {
+
+// command will block before checking for cancel (before return/
terminate)
+CountDownLatch beforeCancel = new CountDownLatch(1);
+
+CountDownLatch progressReported = new CountDownLatch(1);
+
+/**
+ * True, if the command has received a cancel
+ */
+AtomicBoolean cancel = new AtomicBoolean(false);
+
+/**
+ * True, if the command has finished (normally or abruptly)
+ */
+AtomicBoolean finished = new AtomicBoolean(false);
+
+
+volatile Throwable exception;
+
+public ProgressCommand() {
+progressCommandInstance = this;
+}
+
+@Override
+public List getCodeActions(ResultIterator resultIterator,
CodeActionParams params) throws Exception {
+return Collections.emptyList();
+}
+
+boolean cancel() {
+return !this.cancel.getAndSet(true);
+}
+@Override
+public CompletableFuture processCommand(NbCodeLanguageClient
client, String command, List arguments) {
+if (!command.equals("_progressCommand")) {
+return null;
+}
+
+return CompletableFuture.supplyAsync(() -> {
+ProgressHandle h = ProgressHandle.createHandle("Test Command",
this::cancel);
+try {
+h
[jira] [Commented] (NETBEANS-6268) NPE in TestClassInfoTask.java:104
[
https://issues.apache.org/jira/browse/NETBEANS-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474309#comment-17474309
]
Vlasta Ramik commented on NETBEANS-6268:
[~taps] I was not able to reproduce it since it's occurred. I was running or
debugging some tests when IDE notified me about that and offered to report the
issue. I think it can be closed as cannot reproduce for now and possibly
re-open in future. Thanks
> NPE in TestClassInfoTask.java:104
> -
>
> Key: NETBEANS-6268
> URL: https://issues.apache.org/jira/browse/NETBEANS-6268
> Project: NetBeans
> Issue Type: Bug
>Affects Versions: 12.5
>Reporter: Vlasta Ramik
>Priority: Major
>
> {noformat}
> SEVERE [org.openide.util.Exceptions]
> java.lang.NullPointerException
> at
> org.netbeans.modules.junit.ui.actions.TestClassInfoTask.computeTestMethods(TestClassInfoTask.java:104)
> at
> org.netbeans.modules.junit.ui.actions.TestClassInfoTask$ComputeTestMethodsImpl$TaskImpl.computeTestMethods(TestClassInfoTask.java:202)
> at
> org.netbeans.modules.java.testrunner.ui.ComputeTestMethodsImpl$TaskImpl.run(ComputeTestMethodsImpl.java:96)
> at
> org.netbeans.modules.java.testrunner.ui.ComputeTestMethodsImpl$TaskImpl.run(ComputeTestMethodsImpl.java:60)
> [catch] at
> org.netbeans.modules.java.source.JavaSourceAccessor$CancelableTaskWrapper.run(JavaSourceAccessor.java:273)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor.callParserResultTask(TaskProcessor.java:561)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.run(TaskProcessor.java:786)
> at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.execute(TaskProcessor.java:702)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor$CompilationJob.run(TaskProcessor.java:663)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
> at
> org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
> at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
> at
> org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] (NETBEANS-6367) NullPointerException: Cannot Invoke java.util.TreeSet.clear() because this.messageStore is null.
[ https://issues.apache.org/jira/browse/NETBEANS-6367 ] Gregory Sartucci deleted comment on NETBEANS-6367: was (Author: angularangel): Not sure if I filled this thing out right. Was I supposed to do this when I created the issue, or something? > NullPointerException: Cannot Invoke java.util.TreeSet.clear() because > this.messageStore is null. > > > Key: NETBEANS-6367 > URL: https://issues.apache.org/jira/browse/NETBEANS-6367 > Project: NetBeans > Issue Type: Bug >Affects Versions: 12.6 >Reporter: Gregory Sartucci >Priority: Major > Attachments: Netbeans Error Log > > > [^Netbeans Error Log] > I get this error upon loading Netbeans. I'm not sure precisely what causes > it, but it seems to go away temporarily if I clear the Netbeans data, though > it shows up again in a few days usually. I haven't figured out what all the > effects are, but it seems to disable automatic code completion and error > detection, which is a bit of a problem. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6163) Maven does not set generated source roots correctly
[
https://issues.apache.org/jira/browse/NETBEANS-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17473203#comment-17473203
]
Steven Swor commented on NETBEANS-6163:
---
[~taps] Is the maven plugin really behaving inappropriately here? Is it written
down somewhere how plugins that generate sources should behave, or is this just
"common knowledge" among plugin developers? The maven build seems to be fine
with how these plugins behave. It's only NetBeans that can't seem to make heads
or tails of it.
What's wrong with having NetBeans pick up the generated sources from maven
instead of making an assumption about how plugins are going to behave?
> Maven does not set generated source roots correctly
> ---
>
> Key: NETBEANS-6163
> URL: https://issues.apache.org/jira/browse/NETBEANS-6163
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Maven
>Reporter: Martin Entlicher
>Assignee: Martin Entlicher
>Priority: Major
> Labels: pull-request-available
> Fix For: Next
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Clone and build [https://github.com/dsyer/native-image-debug]
> Open the project in NetBeans and see that under {{Generated Sources}} there
> are packages like: {{src.main.java.org.springframework.aot}}, etc.
> The initial {{src/main/java}} should not be included in the source root.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: LSP: Change method parameters should refactor access modifier. (#3442)
This is an automated email from the ASF dual-hosted git repository.
dbalek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 3baf1c3 LSP: Change method parameters should refactor access
modifier. (#3442)
3baf1c3 is described below
commit 3baf1c366f7e3014488e82ca0f87d56a6e7d71fa
Author: Dusan Balek
AuthorDate: Tue Jan 11 21:22:28 2022 +0100
LSP: Change method parameters should refactor access modifier. (#3442)
---
.../ChangeMethodParametersRefactoring.java | 24 +++---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git
a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ChangeMethodParametersRefactoring.java
b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ChangeMethodParametersRefactoring.java
index 6175429..0e5edc8 100644
---
a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ChangeMethodParametersRefactoring.java
+++
b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ChangeMethodParametersRefactoring.java
@@ -25,6 +25,7 @@ import com.sun.source.util.Trees;
import java.io.IOException;
import java.util.Arrays;
import java.util.Collections;
+import java.util.HashSet;
import java.util.List;
import java.util.Set;
import java.util.concurrent.CompletableFuture;
@@ -208,6 +209,7 @@ public final class ChangeMethodParametersRefactoring
extends CodeRefactoring {
model.withName(method.getSimpleName().toString())
.withReturnType(Utilities.getTypeName(ci,
method.getReturnType(), true).toString())
.withSelectedModifier(mod)
+
.withIsStatic(method.getModifiers().contains(javax.lang.model.element.Modifier.STATIC))
.withParameters(params)
.assignData(client, file, TreePathHandle.from(handle,
ClasspathInfo.create(file)));
model.applyBindings();
@@ -221,6 +223,7 @@ public final class ChangeMethodParametersRefactoring
extends CodeRefactoring {
@Model(className = "ChangeMethodParameterUI", targetId = "", instance =
true, builder = "with", properties = {
@Property(name = "selectedModifier", type = Modifier.class),
+@Property(name = "isStatic", type = boolean.class),
@Property(name = "name", type = String.class),
@Property(name = "returnType", type = String.class),
@Property(name = "parameters", type = ParameterUI.class, array = true)
@@ -243,6 +246,17 @@ public final class ChangeMethodParametersRefactoring
extends CodeRefactoring {
void doRefactoring(ChangeMethodParameterUI ui) {
try {
ChangeParametersRefactoring refactoring = new
ChangeParametersRefactoring(handle);
+Modifier selectedModifier = ui.getSelectedModifier();
+if (selectedModifier != null) {
+Set modifiers = new
HashSet<>(1);
+switch (selectedModifier) {
+case PRIVATE:
modifiers.add(javax.lang.model.element.Modifier.PRIVATE);break;
+case PACKAGE_PRIVATE: break; /* no modifier */
+case PROTECTED:
modifiers.add(javax.lang.model.element.Modifier.PROTECTED); break;
+case PUBLIC:
modifiers.add(javax.lang.model.element.Modifier.PUBLIC); break;
+}
+refactoring.setModifiers(modifiers);
+}
String returnType = ui.getReturnType();
refactoring.setReturnType(returnType.length() > 0 ? returnType
: null);
List parameters = ui.getParameters();
@@ -310,15 +324,19 @@ public final class ChangeMethodParametersRefactoring
extends CodeRefactoring {
@ComputedProperty
static String preview(
-Modifier selectedModifier, String returnType, String name,
List parameters
+Modifier selectedModifier, boolean isStatic, String returnType,
String name, List parameters
) {
StringBuilder sb = new StringBuilder();
-sb.append(selectedModifier != null ? selectedModifier.javaName :
"").append(" ").append(returnType);
+sb.append(selectedModifier != null ? selectedModifier.javaName :
"").append(" ");
+if (isStatic) {
+sb.append("static ");
+}
+sb.append(returnType);
sb.append(" ").append(name).append("(");
String sep = "";
for (ParameterUI p : parameters) {
sb.append(sep);
-sb.append(p.getType()).append(" ").append(p.getName());
+sb.append(p.getType() != null ? p.getType() : "").append("
").append(p.getName() != null ? p.getName() : "");
sep = ", ";
}
sb.append(")");
-
[jira] [Created] (NETBEANS-6383) Copy relative path
Marvel Wild created NETBEANS-6383: - Summary: Copy relative path Key: NETBEANS-6383 URL: https://issues.apache.org/jira/browse/NETBEANS-6383 Project: NetBeans Issue Type: Wish Reporter: Marvel Wild Attachments: nb_fr.png Context menu already has "Copy File Path" item. I missing "copy relative path" feature from phpstorm. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Closed] (NETBEANS-6358) Font style regression: badly readable font style
[ https://issues.apache.org/jira/browse/NETBEANS-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] S. M. closed NETBEANS-6358. --- Resolution: Won't Fix Problem is caused by an OpenJDK bug - which is reported. > Font style regression: badly readable font style > > > Key: NETBEANS-6358 > URL: https://issues.apache.org/jira/browse/NETBEANS-6358 > Project: NetBeans > Issue Type: Bug > Components: editor - Navigation, ide - UI, java - Navigation >Affects Versions: 12.6 > Environment: NB 12.6 > Win10 >Reporter: S. M. >Assignee: Eirik Bakke >Priority: Minor > Attachments: ClearType Tahoma vs. Segoe.png, NetBeans 12.6 Project > Font on Windows 11.png, bold.png, regular.png > > > The font style changed in 12.6 in a way that makes it less readable. The > following fonts are bold now: > - The name of the source files in the source-code-tab > - The project names in the projects windows (and all its child nodes) > This bulky use of bold fonts makes the text badly readable. Please use a > regular font instead! The source-code names in the source-window-tab used to > be bold only when the file had unsaved changes, which seems to be a good > thing to me. > It might seem to be a 'minor' problem, but the font as part of the > ergonomically usability is quite important. > Thanks a lot! > Here the comparison: > Bulky and badly readable: New bold style > !bold.png! > Clear and readable: Old regular style > !regular.png! -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6358) Font style regression: badly readable font style
[ https://issues.apache.org/jira/browse/NETBEANS-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17473094#comment-17473094 ] S. M. commented on NETBEANS-6358: - I'am going to close the issue since it is no NB problem. > Font style regression: badly readable font style > > > Key: NETBEANS-6358 > URL: https://issues.apache.org/jira/browse/NETBEANS-6358 > Project: NetBeans > Issue Type: Bug > Components: editor - Navigation, ide - UI, java - Navigation >Affects Versions: 12.6 > Environment: NB 12.6 > Win10 >Reporter: S. M. >Assignee: Eirik Bakke >Priority: Minor > Attachments: ClearType Tahoma vs. Segoe.png, NetBeans 12.6 Project > Font on Windows 11.png, bold.png, regular.png > > > The font style changed in 12.6 in a way that makes it less readable. The > following fonts are bold now: > - The name of the source files in the source-code-tab > - The project names in the projects windows (and all its child nodes) > This bulky use of bold fonts makes the text badly readable. Please use a > regular font instead! The source-code names in the source-window-tab used to > be bold only when the file had unsaved changes, which seems to be a good > thing to me. > It might seem to be a 'minor' problem, but the font as part of the > ergonomically usability is quite important. > Thanks a lot! > Here the comparison: > Bulky and badly readable: New bold style > !bold.png! > Clear and readable: Old regular style > !regular.png! -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6367) NullPointerException: Cannot Invoke java.util.TreeSet.clear() because this.messageStore is null.
[ https://issues.apache.org/jira/browse/NETBEANS-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Sartucci updated NETBEANS-6367: --- Not sure if I filled this thing out right. Was I supposed to do this when I created the issue, or something? > NullPointerException: Cannot Invoke java.util.TreeSet.clear() because > this.messageStore is null. > > > Key: NETBEANS-6367 > URL: https://issues.apache.org/jira/browse/NETBEANS-6367 > Project: NetBeans > Issue Type: Bug >Affects Versions: 12.6 >Reporter: Gregory Sartucci >Priority: Major > Attachments: Netbeans Error Log > > > [^Netbeans Error Log] > I get this error upon loading Netbeans. I'm not sure precisely what causes > it, but it seems to go away temporarily if I clear the Netbeans data, though > it shows up again in a few days usually. I haven't figured out what all the > effects are, but it seems to disable automatic code completion and error > detection, which is a bit of a problem. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3433) Allow to edit the result when resolving merge conflicts
[ https://issues.apache.org/jira/browse/NETBEANS-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472935#comment-17472935 ] Antonio Marques commented on NETBEANS-3433: --- I can confirm this happens with `git`. As someone who is keen to use NB's conflict solver even for projects that have nothing to do with Java or NB, I miss this very much. I also think it must be a regression, because I'm sure it used to be possible to edit the result back in NB 8 (or maybe 7). With all the upheaval caused by Java9 and the migration to Apache, I haven't said anything about this, but now that things are stable it should be a priority - it makes one suspect that NB developers aren't using the conflict solver at all, or they'd run into this all the time. > Allow to edit the result when resolving merge conflicts > --- > > Key: NETBEANS-3433 > URL: https://issues.apache.org/jira/browse/NETBEANS-3433 > Project: NetBeans > Issue Type: Improvement >Affects Versions: 11.2 >Reporter: Lorenz Froihofer >Priority: Major > > The dialog that shows up when one selects "Subversion --> Resolve > Conflicts..." does not allow to edit the merge result. For a conflict, it is > only possible to choose the changed part of one file or from both files. > However, this is only sufficient for conflicts that are easy to solve. For > larger conflicts, it is necessary to be able to edit the result directly. > This corresponds to the following former NetBeans bugzilla bug: > [https://netbeans.org/bugzilla/show_bug.cgi?id=141198] - but it seems the > bugs from that former bug tracking instance have not been migrated to this > Jira project. > According to the following comment, this issue not restricted to Subversion > but happens for all VCSs supported by the IDE: > [https://netbeans.org/bugzilla/show_bug.cgi?id=141198#c1] > There is a workaround to this topic as one can select two of the temporary > files created by Subversion during an update and use "Tools --> Diff...". > This brings up a merge dialog where one side can be edited and the result > copied back to the main file. However, it is surprising that this issue is > still open in 2019 as it is a core feature of an IDE and I am not aware of > any other IDE that has such a restriction in resolving conflicts. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-6382) String Variables longer 100000 Characters are shown as in Debug
Wolfgang Kockwelp created NETBEANS-6382: --- Summary: String Variables longer 10 Characters are shown as in Debug Key: NETBEANS-6382 URL: https://issues.apache.org/jira/browse/NETBEANS-6382 Project: NetBeans Issue Type: Bug Components: debugger - Java Reporter: Wolfgang Kockwelp String Variables longer 10 Characters are shown in Debugger as instead of its content. Tested with Netbeans 12.0 and 12.6 with Amazon Corretto open-jdk11.0.12_7 64 Bit and Amazon Corretto open-jdk15.0.2_7 64 Bit and Oracle JDK 11.0.2 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6163) Maven does not set generated source roots correctly
[
https://issues.apache.org/jira/browse/NETBEANS-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472853#comment-17472853
]
Thomas Schapitz commented on NETBEANS-6163:
---
[~sworisbreathing] Incidentally, I've seen that too in the
openapi-generator-plugin. Unfortunately, there are two other aspects to this:
a.) This mode of operation of the plugin is intended to generate a complete
project, not just some source. So placing this into 'generated-sources' is
clearly inappropriate both from a Maven as well as a Netbeans point of view.
b.) The configuration of this specific plugin, which, in turn relies on
pluggable 'generators', that are specified by option , is
pretty messy. In some cases, it is possible to tweak the adapters, to generate
only specific sources, and also to place them appropriately, in others that
might prove difficult.
So, in this case:
* look up the configuration of the generator used. Look for options, that
allow the following:
* switch off generation of project support files
* specify output oft the source below
target/generated-sources/
* specify, that this should be included into the sources to compile (option:
{{{} - the openapi-generator-plugin mostly does this
by default, so you don't need the build helper)
After a priming build, this should result in Netbeans setting up the source
roots matching the one of Maven.
While it would be nice, if Netbeans supplied a bit of more support here, I also
don't think it is the business of Netbeans to fix goofy plugin configurations.
If the options I mentioned are not available, it would be more appropriate to
contact the author of the specific generator.
The case in point here is: this plugin is maintained by the openapi community,
that isn't exactly focussed on getting Maven things right.
> Maven does not set generated source roots correctly
> ---
>
> Key: NETBEANS-6163
> URL: https://issues.apache.org/jira/browse/NETBEANS-6163
> Project: NetBeans
> Issue Type: Bug
> Components: projects - Maven
>Reporter: Martin Entlicher
>Assignee: Martin Entlicher
>Priority: Major
> Labels: pull-request-available
> Fix For: Next
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Clone and build [https://github.com/dsyer/native-image-debug]
> Open the project in NetBeans and see that under {{Generated Sources}} there
> are packages like: {{src.main.java.org.springframework.aot}}, etc.
> The initial {{src/main/java}} should not be included in the source root.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans-jenkins-lib] branch master updated (fb42ce1 -> b9c2ec5)
This is an automated email from the ASF dual-hosted git repository. skygo pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/netbeans-jenkins-lib.git. from fb42ce1 Merge pull request #43 from JaroslavTulach/HtmlJava173 new 14430af add apidoc publish flag new ca24a5b fix jdk label + date new b9c2ec5 Merge pull request #45 from ebarboni/apipublishjson The 262 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: meta/netbeansrelease.json | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6358) Font style regression: badly readable font style
[ https://issues.apache.org/jira/browse/NETBEANS-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472796#comment-17472796 ] Eirik Bakke commented on NETBEANS-6358: --- The reported OpenJDK bug is now listed at https://bugs.openjdk.java.net/browse/JDK-8279666 > Font style regression: badly readable font style > > > Key: NETBEANS-6358 > URL: https://issues.apache.org/jira/browse/NETBEANS-6358 > Project: NetBeans > Issue Type: Bug > Components: editor - Navigation, ide - UI, java - Navigation >Affects Versions: 12.6 > Environment: NB 12.6 > Win10 >Reporter: S. M. >Assignee: Eirik Bakke >Priority: Minor > Attachments: ClearType Tahoma vs. Segoe.png, NetBeans 12.6 Project > Font on Windows 11.png, bold.png, regular.png > > > The font style changed in 12.6 in a way that makes it less readable. The > following fonts are bold now: > - The name of the source files in the source-code-tab > - The project names in the projects windows (and all its child nodes) > This bulky use of bold fonts makes the text badly readable. Please use a > regular font instead! The source-code names in the source-window-tab used to > be bold only when the file had unsaved changes, which seems to be a good > thing to me. > It might seem to be a 'minor' problem, but the font as part of the > ergonomically usability is quite important. > Thanks a lot! > Here the comparison: > Bulky and badly readable: New bold style > !bold.png! > Clear and readable: Old regular style > !regular.png! -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: Initial port and adapt of GitHub issue configuration from Airflow.
This is an automated email from the ASF dual-hosted git repository. neilcsmith pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new 7263cf2 Initial port and adapt of GitHub issue configuration from Airflow. new b306205 Merge pull request #3415 from neilcsmith-net/gh-issues 7263cf2 is described below commit 7263cf2ae78210d8c9ebd304d19afd3c5f3e9bf0 Author: Neil C Smith AuthorDate: Wed Jan 5 16:54:57 2022 + Initial port and adapt of GitHub issue configuration from Airflow. --- .asf.yaml | 4 +- .github/ISSUE_TEMPLATE/config.yml | 9 ++ .github/ISSUE_TEMPLATE/netbeans_bug_report.yml | 126 + .../ISSUE_TEMPLATE/netbeans_feature_request.yml| 57 ++ .github/ISSUE_TEMPLATE/~free_form.yml | 16 +++ .github/SECURITY.rst | 35 ++ 6 files changed, 245 insertions(+), 2 deletions(-) diff --git a/.asf.yaml b/.asf.yaml index cc9c65c..2626160 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -22,8 +22,8 @@ github: - hacktoberfest # Hacktoberfest topic features: wiki: false -issues: false -projects: false +issues: true +projects: true enabled_merge_buttons: squash: true merge: true diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 000..a07e114 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1,9 @@ +--- +blank_issues_enabled: false +contact_links: + - name: Ask a question (GitHub Discussions) +url: https://github.com/apache/netbeans/discussions/ +about: Ask a question or request support for using Apache NetBeans. + - name: Mailing lists +url: https://netbeans.apache.org/community/mailing-lists.html +about: Subscribe to the users, dev or announce mailing lists for Apache NetBeans. diff --git a/.github/ISSUE_TEMPLATE/netbeans_bug_report.yml b/.github/ISSUE_TEMPLATE/netbeans_bug_report.yml new file mode 100644 index 000..2fec6d3 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/netbeans_bug_report.yml @@ -0,0 +1,126 @@ +--- +name: Apache NetBeans bug report +description: Problems and issues with Apache NetBeans +labels: ["kind:bug", "needs:triage"] +body: + - type: markdown +attributes: + # yamllint disable rule:line-length + value: " + +Thank you for finding the time to report the problem! + +We really appreciate community efforts to improve Apache NetBeans. + +Note, that you do not need to create an issue if you have a change ready to submit! + +You can open a [Pull Request](https://github.com/apache/netbeans/pulls) immediately instead. +" + # yamllint enable rule:line-length + - type: dropdown +attributes: + label: Apache NetBeans version + description: > +Which Apache NetBeans version are you using? Only the latest release, latest +release candidate (if available), and latest daily build are supported for bugs. +If using an older version, please verify the bug is still valid before reporting. +Latest releases are always available from https://netbeans.apache.org/download/ + multiple: false + options: +- "Latest release" +- "Latest release candidate" +- "Latest daily build" +validations: + required: true + - type: textarea +attributes: + label: What happened + description: Describe what happened, what you expected to happen, and what went wrong. + placeholder: > +Please provide the context in which the problem occurred and explain what happened. +Explain why you think the behaviour is erroneous. It is extremely helpful if you copy&paste +the fragment of logs showing the exact error messages or wrong behaviour and screenshots for +UI problems or YouTube link to a video of you demonstrating the problem. You can include files by +dragging and dropping them here. +validations: + required: true + - type: textarea +attributes: + label: How to reproduce + description: > +What should we do to reproduce the problem? If you are not able to provide a reproducible case, +please open a [Discussion](https://github.com/apache/netbeans/discussions) instead. + placeholder: > +Please make sure you provide a reproducible step-by-step case of how to reproduce the problem +as minimally and precisely as possible. Remember that non-reproducible issues may be closed or +converted into discussions. If we cannot reproduce an issue we cannot fix it! + - type: checkboxes +attributes: + label: Did this work correctly in an earlier version? + description: > +It's important to know whether bugs have been int
[netbeans] branch infra/gradle-lsp-stabilization updated: Simplified handle cancel test.
This is an automated email from the ASF dual-hosted git repository.
sdedic pushed a commit to branch infra/gradle-lsp-stabilization
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/infra/gradle-lsp-stabilization
by this push:
new f434464 Simplified handle cancel test.
f434464 is described below
commit f4344646e61bbde38330361e47e61cd53a29063a
Author: Svata Dedic
AuthorDate: Tue Jan 11 14:30:59 2022 +0100
Simplified handle cancel test.
---
.../java/lsp/server/protocol/ServerTest.java | 141 -
1 file changed, 107 insertions(+), 34 deletions(-)
diff --git
a/java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java
b/java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java
index 1fd6762..e316db6 100644
---
a/java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java
+++
b/java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java
@@ -36,7 +36,6 @@ import java.net.URL;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
-import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
@@ -59,6 +58,7 @@ import javax.swing.Icon;
import javax.swing.event.ChangeListener;
import javax.swing.text.Document;
import javax.swing.text.StyledDocument;
+import static junit.framework.TestCase.assertEquals;
import static junit.framework.TestCase.assertNotNull;
import static junit.framework.TestCase.assertNull;
import org.eclipse.lsp4j.ApplyWorkspaceEditParams;
@@ -117,6 +117,7 @@ import org.eclipse.lsp4j.TextDocumentItem;
import org.eclipse.lsp4j.TextEdit;
import org.eclipse.lsp4j.TypeDefinitionParams;
import org.eclipse.lsp4j.VersionedTextDocumentIdentifier;
+import org.eclipse.lsp4j.WorkDoneProgressBegin;
import org.eclipse.lsp4j.WorkDoneProgressCancelParams;
import org.eclipse.lsp4j.WorkDoneProgressCreateParams;
import org.eclipse.lsp4j.WorkDoneProgressKind;
@@ -137,6 +138,7 @@ import org.netbeans.api.java.project.JavaProjectConstants;
import org.netbeans.api.java.queries.AnnotationProcessingQuery.Result;
import org.netbeans.api.java.queries.AnnotationProcessingQuery.Trigger;
import org.netbeans.api.java.source.JavaSource;
+import org.netbeans.api.progress.ProgressHandle;
import org.netbeans.api.project.FileOwnerQuery;
import org.netbeans.api.project.Project;
import org.netbeans.api.project.ProjectUtils;
@@ -151,6 +153,7 @@ import
org.netbeans.modules.java.lsp.server.refactoring.ChangeMethodParameterUI;
import org.netbeans.modules.java.lsp.server.refactoring.ParameterUI;
import org.netbeans.modules.java.lsp.server.ui.MockHtmlViewer;
import org.netbeans.modules.java.source.BootClassPathUtil;
+import org.netbeans.modules.parsing.api.ResultIterator;
import org.netbeans.modules.parsing.impl.indexing.implspi.CacheFolderProvider;
import org.netbeans.spi.java.classpath.ClassPathProvider;
import org.netbeans.spi.java.classpath.support.ClassPathSupport;
@@ -4846,8 +4849,87 @@ public class ServerTest extends NbTestCase {
}
}
-public void testCancelProgressHandle() throws Exception {
+private static volatile ProgressCommand progressCommandInstance;
+
+@ServiceProvider(service = CodeActionsProvider.class)
+public static class ProgressCommand extends CodeActionsProvider {
+
+// command will block before checking for cancel (before return/
terminate)
+CountDownLatch beforeCancel = new CountDownLatch(1);
+
+CountDownLatch progressReported = new CountDownLatch(1);
+
+/**
+ * True, if the command has received a cancel
+ */
+AtomicBoolean cancel = new AtomicBoolean(false);
+
+/**
+ * True, if the command has finished (normally or abruptly)
+ */
+AtomicBoolean finished = new AtomicBoolean(false);
+
+
+volatile Throwable exception;
+
+public ProgressCommand() {
+progressCommandInstance = this;
+}
+@Override
+public List getCodeActions(ResultIterator resultIterator,
CodeActionParams params) throws Exception {
+return Collections.emptyList();
+}
+
+boolean cancel() {
+return !this.cancel.getAndSet(true);
+}
+
+@Override
+public CompletableFuture processCommand(NbCodeLanguageClient
client, String command, List arguments) {
+if (!command.equals("_progressCommand")) {
+return null;
+}
+
+AtomicBoolean cancel = new AtomicBoolean(false);
+return CompletableFuture.supplyAsync(() -> {
+ProgressHandle h = ProgressHandle.createHandle("Test Command",
this::cancel);
+
[jira] [Updated] (NETBEANS-6381) Ctrl+Click on package name in import statement should browse classes
[
https://issues.apache.org/jira/browse/NETBEANS-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Balin updated NETBEANS-6381:
---
Description:
Compared to other Java IDE NetBeans is missing feature to allow browsing
classes in package when Ctrl+Click on package name in import statement. This
should expand package in dependencies and allow browsing. This will lead to
open the class selected similar to Ctrl+Click on class name in import statement.
See underlined {{runtime}} in screenshot
!Screenshot 2022-01-11 at 14.17.08.png!
Currently NB shows message that class runtime cannot be open - missing source.
There is no representation in NetBeans for jar file containing
io.micronaut.runtime.
was:
Compared to other Java IDE NetBeans is missing feature to allow browsing
classes in package when Ctrl+Click on package name in import statement. This
should expand package in dependencies and allow browsing. This will lead to
open the class selected similar to Ctrl+Click on class name in import statement.
See underlined {{runtime}} in screenshot
!Screenshot 2022-01-11 at 14.17.08.png!
Currently NB shows message that class runtime cannot be open - missing source
> Ctrl+Click on package name in import statement should browse classes
>
>
> Key: NETBEANS-6381
> URL: https://issues.apache.org/jira/browse/NETBEANS-6381
> Project: NetBeans
> Issue Type: Improvement
> Components: java - Navigation
>Affects Versions: 12.5
>Reporter: Martin Balin
>Assignee: Dusan Balek
>Priority: Major
> Attachments: Screenshot 2022-01-11 at 14.17.08.png
>
>
> Compared to other Java IDE NetBeans is missing feature to allow browsing
> classes in package when Ctrl+Click on package name in import statement. This
> should expand package in dependencies and allow browsing. This will lead to
> open the class selected similar to Ctrl+Click on class name in import
> statement.
> See underlined {{runtime}} in screenshot
> !Screenshot 2022-01-11 at 14.17.08.png!
> Currently NB shows message that class runtime cannot be open - missing source.
> There is no representation in NetBeans for jar file containing
> io.micronaut.runtime.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-6381) Ctrl+Click on package name in import statement should browse classes
Martin Balin created NETBEANS-6381:
--
Summary: Ctrl+Click on package name in import statement should
browse classes
Key: NETBEANS-6381
URL: https://issues.apache.org/jira/browse/NETBEANS-6381
Project: NetBeans
Issue Type: Improvement
Components: java - Navigation
Affects Versions: 12.5
Reporter: Martin Balin
Assignee: Dusan Balek
Attachments: Screenshot 2022-01-11 at 14.17.08.png
Compared to other Java IDE NetBeans is missing feature to allow browsing
classes in package when Ctrl+Click on package name in import statement. This
should expand package in dependencies and allow browsing. This will lead to
open the class selected similar to Ctrl+Click on class name in import statement.
See underlined {{runtime}} in screenshot
!Screenshot 2022-01-11 at 14.17.08.png!
Currently NB shows message that class runtime cannot be open - missing source
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Closed] (NETBEANS-5951) Referencing Groovy in Java class marked as cannot find symbol
[
https://issues.apache.org/jira/browse/NETBEANS-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petr Pisl closed NETBEANS-5951.
---
Fix Version/s: 12.6
Resolution: Fixed
This is already fixed. Shold now work.
> Referencing Groovy in Java class marked as cannot find symbol
> -
>
> Key: NETBEANS-5951
> URL: https://issues.apache.org/jira/browse/NETBEANS-5951
> Project: NetBeans
> Issue Type: Bug
> Components: groovy - Editor
>Affects Versions: 12.4
> Environment: NB 12.5 Beta2 build using JDK11 as Java platform. macOS
>Reporter: Martin Balin
>Assignee: Petr Pisl
>Priority: Major
> Fix For: 12.6
>
> Attachments: Screenshot 2021-08-27 at 15.06.09.png
>
>
> Using project [https://github.com/groovyfx-project/groovyfx]
> Class groovyx.javafx.GroovyFX line 41:
> {{closure.setDelegate(new SceneGraphBuilder(primaryStage));}}
> SceneGraphBuilder is marked as cannot find symbol, although
> {{groovyx.javafx.SceneGrpahBuilder.groovy}} is available in the same package.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-5951) Referencing Groovy in Java class marked as cannot find symbol
[
https://issues.apache.org/jira/browse/NETBEANS-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petr Pisl reassigned NETBEANS-5951:
---
Assignee: Petr Pisl (was: Svata Dedic)
> Referencing Groovy in Java class marked as cannot find symbol
> -
>
> Key: NETBEANS-5951
> URL: https://issues.apache.org/jira/browse/NETBEANS-5951
> Project: NetBeans
> Issue Type: Bug
> Components: groovy - Editor
>Affects Versions: 12.4
> Environment: NB 12.5 Beta2 build using JDK11 as Java platform. macOS
>Reporter: Martin Balin
>Assignee: Petr Pisl
>Priority: Major
> Attachments: Screenshot 2021-08-27 at 15.06.09.png
>
>
> Using project [https://github.com/groovyfx-project/groovyfx]
> Class groovyx.javafx.GroovyFX line 41:
> {{closure.setDelegate(new SceneGraphBuilder(primaryStage));}}
> SceneGraphBuilder is marked as cannot find symbol, although
> {{groovyx.javafx.SceneGrpahBuilder.groovy}} is available in the same package.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-6380) Add Default hint for Swithc Pattern matching
Sandeep Mishra created NETBEANS-6380:
Summary: Add Default hint for Swithc Pattern matching
Key: NETBEANS-6380
URL: https://issues.apache.org/jira/browse/NETBEANS-6380
Project: NetBeans
Issue Type: New Feature
Components: java - Hints
Reporter: Sandeep Mishra
Assignee: Sandeep Mishra
In switch pattern matching, the error "the switch statement does not cover all
possible input values" is thrown in the given case :
{code:java}
static void error2(Object o1) {
switch (o1) {
case null ->
System.out.println("null case");
case Integer i && i > 0 ->
System.out.println("2nd case"); // Positive integer cases
case Integer i ->
System.out.println("3rd case" + i); // All the
remaining integers
}
} {code}
The IDE can give a hint for the switch expression for adding a default to the
switch statement/expression which will fix the error as given below :
{code:java}
static void error2(Object o1) {
switch (o1) {
case null ->
System.out.println("null case");
case Integer i && i > 0 ->
System.out.println("2nd case"); // Positive integer cases
case Integer i ->
System.out.println("3rd case" + i); // All the
remaining integers
default -> throw new IllegalStateException("Unexpected value: " +
o1);
}
} {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5952) Sort Groovy class members correctly in code compl. suggestions
[
https://issues.apache.org/jira/browse/NETBEANS-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petr Pisl updated NETBEANS-5952:
Labels: groovy (was: )
> Sort Groovy class members correctly in code compl. suggestions
> --
>
> Key: NETBEANS-5952
> URL: https://issues.apache.org/jira/browse/NETBEANS-5952
> Project: NetBeans
> Issue Type: Improvement
> Components: groovy - Editor
>Affects Versions: 12.4
> Environment: NB 12.5 beta 2, JDK11, macOS.
>Reporter: Martin Balin
>Assignee: Svata Dedic
>Priority: Critical
> Labels: groovy
> Attachments: CC_Suggestions_IntelliJ.png, CC_Suggestions_NB.png
>
>
> Played a little with 2 Groovy classes from GroovyFX project opened in NB
> groovyx.javafx.animation.GTimeline.groovy was used as variable in
> TargetHolder.groovy same package.
> When invoking code completion for variable{{ timeline.}} (including the
> dot)or press Control+Space then suggestions are not sorted the way expected.
> I would expect members declared in GTimeline.groovy on top, then from super
> classes
> See screenshot for NB and IntelliJ.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-6361) Code completion for class fields doesn't work.
[
https://issues.apache.org/jira/browse/NETBEANS-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petr Pisl resolved NETBEANS-6361.
-
Fix Version/s: 12.6
Resolution: Fixed
Merged
> Code completion for class fields doesn't work.
> --
>
> Key: NETBEANS-6361
> URL: https://issues.apache.org/jira/browse/NETBEANS-6361
> Project: NetBeans
> Issue Type: New Feature
> Components: groovy - Editor
>Affects Versions: 12.5
>Reporter: Petr Pisl
>Assignee: Petr Pisl
>Priority: Major
> Labels: bug, groovy, pull-request-available
> Fix For: 12.6
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Have this simple code:
>
> {code:java}
> class B {
> int fieldInt;
> String fieldString;
>
> B instance;
>
> String getInfo() {
>return "Hello ${instance.}"
> }
> } {code}
> The code completion doesn't work after the dot in return statement.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-5945) Groovy StaticTypeCheckingVisitor evaluates String assignment as Object type
[
https://issues.apache.org/jira/browse/NETBEANS-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petr Pisl resolved NETBEANS-5945.
-
Resolution: Duplicate
This is the duplication of the mentioned class. My fould, I have created
another issue fro this and fix it.
> Groovy StaticTypeCheckingVisitor evaluates String assignment as Object type
> ---
>
> Key: NETBEANS-5945
> URL: https://issues.apache.org/jira/browse/NETBEANS-5945
> Project: NetBeans
> Issue Type: Bug
> Components: groovy - Editor
>Reporter: Svatopluk Dedic
>Assignee: Petr Pisl
>Priority: Major
>
> Conside the following Groovy completion testcase:
>
> {code:java}
> class Klazz {def fieldA = new String("Hello")
> def fieldA1 = "Hello"
> def fieldB = fieldA.c
> def fieldB1 = fieldA1.c
> def fieldC = fieldA.concat("b").c
> def fieldC1 = fieldA1.concat("b").c
> def fieldD = "hi"
> def fieldE = fieldA.concat(fieldD)
> def fieldE1 = fieldA1.concat(fieldD)
> def fieldF = fieldE.c
> def fieldF1 = fieldE1.c
>
> def m() {
>
> def localA = "Hello"
> localA.c
>
> localA.concat("b").c
> def localB = "hi"
> localA.concat(localB).c
> def localC = localA.concat(localB)
> localC.c
>}
> }
> {code}
> *fieldA* is inferred to be java.lang.Object; but it is String all the time.
> Maybe the parser uses Visitor in some screwed way, or the visitor must be
> somehow augmented or fixed to handle this case ?
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-5945) Groovy StaticTypeCheckingVisitor evaluates String assignment as Object type
[
https://issues.apache.org/jira/browse/NETBEANS-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petr Pisl reassigned NETBEANS-5945:
---
Assignee: Petr Pisl
> Groovy StaticTypeCheckingVisitor evaluates String assignment as Object type
> ---
>
> Key: NETBEANS-5945
> URL: https://issues.apache.org/jira/browse/NETBEANS-5945
> Project: NetBeans
> Issue Type: Bug
> Components: groovy - Editor
>Reporter: Svatopluk Dedic
>Assignee: Petr Pisl
>Priority: Major
>
> Conside the following Groovy completion testcase:
>
> {code:java}
> class Klazz {def fieldA = new String("Hello")
> def fieldA1 = "Hello"
> def fieldB = fieldA.c
> def fieldB1 = fieldA1.c
> def fieldC = fieldA.concat("b").c
> def fieldC1 = fieldA1.concat("b").c
> def fieldD = "hi"
> def fieldE = fieldA.concat(fieldD)
> def fieldE1 = fieldA1.concat(fieldD)
> def fieldF = fieldE.c
> def fieldF1 = fieldE1.c
>
> def m() {
>
> def localA = "Hello"
> localA.c
>
> localA.concat("b").c
> def localB = "hi"
> localA.concat(localB).c
> def localC = localA.concat(localB)
> localC.c
>}
> }
> {code}
> *fieldA* is inferred to be java.lang.Object; but it is String all the time.
> Maybe the parser uses Visitor in some screwed way, or the visitor must be
> somehow augmented or fixed to handle this case ?
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
