[netbeans-jenkins-lib] branch master updated: Add milestone for 13-rc2
This is an automated email from the ASF dual-hosted git repository.
neilcsmith pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans-jenkins-lib.git
The following commit(s) were added to refs/heads/master by this push:
new f230dc6 Add milestone for 13-rc2
new 6d15356 Merge pull request #50 from neilcsmith-net/nb130
f230dc6 is described below
commit f230dc63d4e4b6b419f364764445cfc5c981226e
Author: Neil C Smith
AuthorDate: Tue Jan 25 16:20:09 2022 +
Add milestone for 13-rc2
---
meta/netbeansrelease.json | 4
1 file changed, 4 insertions(+)
diff --git a/meta/netbeansrelease.json b/meta/netbeansrelease.json
index 7c6817d..1da3a7b 100644
--- a/meta/netbeansrelease.json
+++ b/meta/netbeansrelease.json
@@ -639,6 +639,10 @@
"d77f0692fbc94e546fba48454beca58765e6e93a": {
"version": "rc1",
"position": "1"
+},
+"321d779a21b1cc303f043f87d3ed7b5e4186ee7c": {
+"version": "rc2",
+"position": "2"
}
},
"releasedate": {
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch release130 updated (d77f069 -> 321d779)
This is an automated email from the ASF dual-hosted git repository. neilcsmith pushed a change to branch release130 in repository https://gitbox.apache.org/repos/asf/netbeans.git. from d77f069 Merge pull request #3473 from apache/delivery add 995df87 [NETBEANS-6117] Fix Gradle project load operation in Wizards add ced2db4 Merge pull request #3480 from lkishalmi/NETBEANS-6117 add 7be809f javafx ide.ergonomics config should not try to load the old nb-javac. add aca6ea1 Merge pull request #3488 from mbien/nb-javac-ergo-fix add 151a212 Fix Gradle popup menu Tasks.. action not functioning. add 67dac6a Merge pull request #3490 from neilcsmith-net/fix-gradle-custom-ui add 41a8292 set shift+enter as line break and add multi-line info message. add 83fe403 Merge pull request #3489 from mbien/use-the-mouse add 51e3aa8 Ensure BufferedInputStream is not initialized with a buffer size of 0 add a42b661 Merge pull request #3491 from matthiasblaesing/error_multiline_search add 4f1bbbf [#3494] Organize Imports inspection is not record aware. add 26e299c Merge pull request #3497 from mbien/keep-records add 4b74969 fix dependencies groupId for maven 3.8.4 add dd0b0b9 Merge pull request #3496 from ebarboni/maven384depfix add 82a0ab7 Fixes to LSP client/server related to semantic highlighting. add 8387f9f Merge pull request #3492 from jlahoda/LSP-client-semantic-fixes add 7d132ee Cache netbeanrelease.json for offline builds and source releases. add 5cf25fd Merge pull request #3500 from neilcsmith-net/ebarboni-offlinebuild add 738c656 Update README with JDK 11 requirement. add c9af6ea Merge pull request #3501 from neilcsmith-net/readme-nb13 new 321d779 Merge pull request #3483 from apache/delivery The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .gitignore | 1 + README.md | 5 +- ergonomics/ide.ergonomics/javafx.properties| 3 - .../modules/gradle/ActionProviderImpl.java | 3 +- .../gradle/loaders/AbstractProjectLoader.java | 2 +- .../gradle/spi/newproject/TemplateOperation.java | 40 + .../netbeans/modules/lsp/client/LSPBindings.java | 13 +++ .../client/bindings/CompletionProviderImpl.java| 6 +- .../lsp/client/bindings/SemanticHighlight.java | 73 ++-- .../textmate/lexer/resources/fontsColors.xml | 2 + .../modules/java/hints/OrganizeImports.java| 1 + .../netbeans/modules/java/lsp/server/Utils.java| 4 + .../server/protocol/TextDocumentServiceImpl.java | 7 +- .../java/lsp/server/protocol/ServerTest.java | 99 +- java/maven.embedder/external/binariesembedded-list | 4 +- .../netbeans/nbbuild/ReleaseJsonProperties.java| 2 +- nbbuild/build.xml | 85 +-- nbbuild/rat-exclusions.txt | 1 + .../netbeans/modules/search/BasicSearchForm.java | 19 - .../modules/search/BasicSearchProvider.java| 3 +- .../org/netbeans/modules/search/Bundle.properties | 1 + .../netbeans/modules/search/PatternSandbox.java| 2 +- .../search/matcher/BufferedCharSequence.java | 2 +- .../modules/search/ui/ShorteningCellRenderer.java | 2 +- 24 files changed, 267 insertions(+), 113 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] 01/01: Merge pull request #3483 from apache/delivery
This is an automated email from the ASF dual-hosted git repository. neilcsmith pushed a commit to branch release130 in repository https://gitbox.apache.org/repos/asf/netbeans.git commit 321d779a21b1cc303f043f87d3ed7b5e4186ee7c Merge: d77f069 c9af6ea Author: Neil C Smith AuthorDate: Tue Jan 25 16:14:34 2022 + Merge pull request #3483 from apache/delivery Sync delivery to release130 for 13-rc2 .gitignore | 1 + README.md | 5 +- ergonomics/ide.ergonomics/javafx.properties| 3 - .../modules/gradle/ActionProviderImpl.java | 3 +- .../gradle/loaders/AbstractProjectLoader.java | 2 +- .../gradle/spi/newproject/TemplateOperation.java | 40 + .../netbeans/modules/lsp/client/LSPBindings.java | 13 +++ .../client/bindings/CompletionProviderImpl.java| 6 +- .../lsp/client/bindings/SemanticHighlight.java | 73 ++-- .../textmate/lexer/resources/fontsColors.xml | 2 + .../modules/java/hints/OrganizeImports.java| 1 + .../netbeans/modules/java/lsp/server/Utils.java| 4 + .../server/protocol/TextDocumentServiceImpl.java | 7 +- .../java/lsp/server/protocol/ServerTest.java | 99 +- java/maven.embedder/external/binariesembedded-list | 4 +- .../netbeans/nbbuild/ReleaseJsonProperties.java| 2 +- nbbuild/build.xml | 85 +-- nbbuild/rat-exclusions.txt | 1 + .../netbeans/modules/search/BasicSearchForm.java | 19 - .../modules/search/BasicSearchProvider.java| 3 +- .../org/netbeans/modules/search/Bundle.properties | 1 + .../netbeans/modules/search/PatternSandbox.java| 2 +- .../search/matcher/BufferedCharSequence.java | 2 +- .../modules/search/ui/ShorteningCellRenderer.java | 2 +- 24 files changed, 267 insertions(+), 113 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch delivery updated: Update README with JDK 11 requirement.
This is an automated email from the ASF dual-hosted git repository. neilcsmith pushed a commit to branch delivery in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/delivery by this push: new 738c656 Update README with JDK 11 requirement. new c9af6ea Merge pull request #3501 from neilcsmith-net/readme-nb13 738c656 is described below commit 738c656cbdf43ed995ad10c5b553dc7d5d896d29 Author: Neil C Smith AuthorDate: Tue Jan 25 13:35:04 2022 + Update README with JDK 11 requirement. --- README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 244ff51..f3e9ea9 100644 --- a/README.md +++ b/README.md @@ -38,13 +38,12 @@ Apache NetBeans is an open source development environment, tooling platform, and * Git * Ant 1.9.9 or above - * JDK 8 or 11 (to build NetBeans) - * JDK 9 or above (to run NetBeans) + * JDK 11 (to build NetBeans) + * JDK 11 or above (to run NetBeans) * MinGW (optional), to build Windows Launchers Notes: -* NetBeans also runs with JDK 8, although then it will not include tools for the JDK 9 Shell. * NetBeans license violation checks are managed via the [rat-exclusions.txt](https://github.com/apache/netbeans/blob/master/nbbuild/rat-exclusions.txt) file. * Set JAVA_HOME and ANT_HOME appropriately or leave them undefined. - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch delivery updated: Cache netbeanrelease.json for offline builds and source releases.
This is an automated email from the ASF dual-hosted git repository.
neilcsmith pushed a commit to branch delivery
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/delivery by this push:
new 7d132ee Cache netbeanrelease.json for offline builds and source
releases.
new 5cf25fd Merge pull request #3500 from
neilcsmith-net/ebarboni-offlinebuild
7d132ee is described below
commit 7d132eeb0179187249527405db0115759d24537d
Author: Eric Barboni
AuthorDate: Mon Oct 5 18:10:46 2020 +0200
Cache netbeanrelease.json for offline builds and source releases.
Cache netbeansrelease.json in nbbuild/ - use -Dneedjsondownload=true to
force update.
Write netbeansrelease.json to same location in source release to ensure
source builds not
affected by future changes to file in repository.
---
.gitignore | 1 +
.../netbeans/nbbuild/ReleaseJsonProperties.java| 2 +-
nbbuild/build.xml | 85 +++---
nbbuild/rat-exclusions.txt | 1 +
4 files changed, 63 insertions(+), 26 deletions(-)
diff --git a/.gitignore b/.gitignore
index fea0457..60e508b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -32,6 +32,7 @@
/nbbuild/user.build.properties
/nbbuild/gitinfo.properties
/nbbuild/netbeansrelease.properties
+/nbbuild/netbeansrelease.json
/nbi/engine/native/*/*/dist/
/nb-javac/
/java.source.nbjavac/test/test-nb-javac/nbproject/private/
diff --git a/nbbuild/antsrc/org/netbeans/nbbuild/ReleaseJsonProperties.java
b/nbbuild/antsrc/org/netbeans/nbbuild/ReleaseJsonProperties.java
index ace6c4f..3a0bd09 100644
--- a/nbbuild/antsrc/org/netbeans/nbbuild/ReleaseJsonProperties.java
+++ b/nbbuild/antsrc/org/netbeans/nbbuild/ReleaseJsonProperties.java
@@ -134,7 +134,7 @@ public class ReleaseJsonProperties extends Task {
}
if (requiredbranchinfo == null) {
-throw new BuildException("No Release Information found for branch
'" + branch + "', update json file section");
+throw new BuildException("No Release Information found for branch
'" + branch + "', update json file section with ant -Dneedjsondownload=true");
}
List updateValues = new ArrayList<>();
for (ReleaseInfo releaseInfo : ri) {
diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index 887f735..401a0c1 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -109,30 +109,8 @@
-
-
-https://gitbox.apache.org/repos/asf?p=netbeans-jenkins-lib.git;a=blob_plain;f=meta/netbeansrelease.json;>
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
@@ -141,11 +119,64 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+https://gitbox.apache.org/repos/asf?p=netbeans-jenkins-lib.git;a=blob_plain;f=meta/netbeansrelease.json;>
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
@@ -190,11 +221,14 @@
metabuild.branch=${metabuild.branch}
metabuild.hash=${metabuild.hash}
+
+
+
Downloading external binaries (*/external/ directories)...
@@ -205,6 +239,7 @@ metabuild.hash=${metabuild.hash}
+
@@ -1690,8 +1725,8 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y
to start the system in d
-
+
diff --git a/nbbuild/rat-exclusions.txt b/nbbuild/rat-exclusions.txt
index 1a11e12..693571e 100644
--- a/nbbuild/rat-exclusions.txt
+++ b/nbbuild/rat-exclusions.txt
@@ -26,6 +26,7 @@ nbbuild/user.build.properties
## generated build artifacts
nbbuild/gitinfo.properties
nbbuild/netbeansrelease.properties
+nbbuild/netbeansrelease.json
enterprise/j2ee.dd/src/org/netbeans/modules/j2ee/dd/impl/application/model_1_4/*
enterprise/j2ee.dd/src/org/netbeans/modules/j2ee/dd/impl/application/model_5/*
enterprise/j2ee.dd/src/org/netbeans/modules/j2ee/dd/impl/application/model_6/*
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-4665) Upgrade Bouncy Castle from 1.64 to 1.68
[ https://issues.apache.org/jira/browse/NETBEANS-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-4665: - Labels: bcpg bcprov pull-request-available (was: bcpg bcprov) > Upgrade Bouncy Castle from 1.64 to 1.68 > --- > > Key: NETBEANS-4665 > URL: https://issues.apache.org/jira/browse/NETBEANS-4665 > Project: NetBeans > Issue Type: Improvement > Components: projects - Libraries >Affects Versions: 12.2, 12.3 >Reporter: José Contreras >Assignee: José Contreras >Priority: Minor > Labels: bcpg, bcprov, pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Notes: > - Many bug fixes and improvements > [Web Page|https://bouncycastle.org/latest_releases.html] > [Releases Notes|https://bouncycastle.org/releasenotes.html] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[
https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481735#comment-17481735
]
Martin Balin edited comment on NETBEANS-6384 at 1/25/22, 2:17 PM:
--
The fix works and both ext packs are running (kind of) alongside. When MS Java
was started before NBLS installed then it shows attached notifications.
!Screenshot 2022-01-25 at 11.59.09.png! \
Will be great to do something about this, although I don't think we can
suppress the {{Could not start client NB Java}} error. But we could extend the
message to say something like "{{{}Could not start client NB Java. Check if
another Java extension is not enabled".{}}} What do you think?
was (Author: mbalin):
The fix works and both ext packs are running (kind of) alongside. When MS Java
was started before NBLS installed then it shows attached notifications.
!Screenshot 2022-01-25 at 11.59.09.png! \
Will be great to do something about this, although I don't think we can
suppress the {{Could not start client NB Java}} error. But we could extend the
message to say something like "{{{}Could not start client NB Java. Check if
another Java extension is not running".{}}} What do you think?
> Detect another Java support ext and recommend to Disable one
>
>
> Key: NETBEANS-6384
> URL: https://issues.apache.org/jira/browse/NETBEANS-6384
> Project: NetBeans
> Issue Type: Task
> Components: vscode
>Affects Versions: 12.5
>Reporter: Martin Balin
>Assignee: Jaroslav Tulach
>Priority: Major
> Fix For: NB13
>
> Attachments: Screenshot 2022-01-25 at 11.59.09.png
>
>
> VSNetBeans currently detects installation of MS Java ext pack and informs
> user it will disable some services of it, code lenses and code completion.
> See
> [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284]
> {code:javascript}
> conf.update('java.test.editor.enableShortcuts', false, false).then(() => {},
> disablingFailed);
> conf.update('java.debug.settings.enableRunDebugCodeLens', false,
> false).then(() => {}, disablingFailed);
> {code}
> This behaviour should change to better coexist with MS Java ext.
> VSNetBeans needs to show user a dialog recommending to Enable per workspace
> one of the Java ext packs. Looking at VSCode API it seems there is still
> missing API to DISABLE extension programatically, while there is
> [uninstallExtension|https://code.visualstudio.com/api/references/commands]
> command?
> Proposed solution is not perfect:
> VSNetBeans will show dialog with text like: _Another Java support extension
> is already installed. It is recommended to use only one Java support per
> workspace. Please Disable one of Java ext for workspace._ *OK* button to open
> Extensions panel and user has to do it UX is TBD.
> Some context info:
> VSCode plans to stop recommend extensions see
> [https://github.com/microsoft/vscode/issues/136301] in Feb.
> And they are also working on extension sets per workspace
> [https://github.com/microsoft/vscode/issues/40239]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[
https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481735#comment-17481735
]
Martin Balin edited comment on NETBEANS-6384 at 1/25/22, 2:16 PM:
--
The fix works and both ext packs are running (kind of) alongside. When MS Java
was started before NBLS installed then it shows attached notifications.
!Screenshot 2022-01-25 at 11.59.09.png! \
Will be great to do something about this, although I don't think we can
suppress the {{Could not start client NB Java}} error. But we could extend the
message to say something like "{{{}Could not start client NB Java. Check if
another Java extension is not running".{}}} What do you thin?
was (Author: mbalin):
The fix works and both ext packs are running (kind of) alongside. When MS Java
was started before NBLS installed then it shows attached notifications.
!Screenshot 2022-01-25 at 11.59.09.png! \
Will be great to do something about this, although I don't think we can
suppress the Could not start client NB Java error.
> Detect another Java support ext and recommend to Disable one
>
>
> Key: NETBEANS-6384
> URL: https://issues.apache.org/jira/browse/NETBEANS-6384
> Project: NetBeans
> Issue Type: Task
> Components: vscode
>Affects Versions: 12.5
>Reporter: Martin Balin
>Assignee: Jaroslav Tulach
>Priority: Major
> Fix For: NB13
>
> Attachments: Screenshot 2022-01-25 at 11.59.09.png
>
>
> VSNetBeans currently detects installation of MS Java ext pack and informs
> user it will disable some services of it, code lenses and code completion.
> See
> [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284]
> {code:javascript}
> conf.update('java.test.editor.enableShortcuts', false, false).then(() => {},
> disablingFailed);
> conf.update('java.debug.settings.enableRunDebugCodeLens', false,
> false).then(() => {}, disablingFailed);
> {code}
> This behaviour should change to better coexist with MS Java ext.
> VSNetBeans needs to show user a dialog recommending to Enable per workspace
> one of the Java ext packs. Looking at VSCode API it seems there is still
> missing API to DISABLE extension programatically, while there is
> [uninstallExtension|https://code.visualstudio.com/api/references/commands]
> command?
> Proposed solution is not perfect:
> VSNetBeans will show dialog with text like: _Another Java support extension
> is already installed. It is recommended to use only one Java support per
> workspace. Please Disable one of Java ext for workspace._ *OK* button to open
> Extensions panel and user has to do it UX is TBD.
> Some context info:
> VSCode plans to stop recommend extensions see
> [https://github.com/microsoft/vscode/issues/136301] in Feb.
> And they are also working on extension sets per workspace
> [https://github.com/microsoft/vscode/issues/40239]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[
https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481735#comment-17481735
]
Martin Balin edited comment on NETBEANS-6384 at 1/25/22, 2:16 PM:
--
The fix works and both ext packs are running (kind of) alongside. When MS Java
was started before NBLS installed then it shows attached notifications.
!Screenshot 2022-01-25 at 11.59.09.png! \
Will be great to do something about this, although I don't think we can
suppress the {{Could not start client NB Java}} error. But we could extend the
message to say something like "{{{}Could not start client NB Java. Check if
another Java extension is not running".{}}} What do you think?
was (Author: mbalin):
The fix works and both ext packs are running (kind of) alongside. When MS Java
was started before NBLS installed then it shows attached notifications.
!Screenshot 2022-01-25 at 11.59.09.png! \
Will be great to do something about this, although I don't think we can
suppress the {{Could not start client NB Java}} error. But we could extend the
message to say something like "{{{}Could not start client NB Java. Check if
another Java extension is not running".{}}} What do you thin?
> Detect another Java support ext and recommend to Disable one
>
>
> Key: NETBEANS-6384
> URL: https://issues.apache.org/jira/browse/NETBEANS-6384
> Project: NetBeans
> Issue Type: Task
> Components: vscode
>Affects Versions: 12.5
>Reporter: Martin Balin
>Assignee: Jaroslav Tulach
>Priority: Major
> Fix For: NB13
>
> Attachments: Screenshot 2022-01-25 at 11.59.09.png
>
>
> VSNetBeans currently detects installation of MS Java ext pack and informs
> user it will disable some services of it, code lenses and code completion.
> See
> [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284]
> {code:javascript}
> conf.update('java.test.editor.enableShortcuts', false, false).then(() => {},
> disablingFailed);
> conf.update('java.debug.settings.enableRunDebugCodeLens', false,
> false).then(() => {}, disablingFailed);
> {code}
> This behaviour should change to better coexist with MS Java ext.
> VSNetBeans needs to show user a dialog recommending to Enable per workspace
> one of the Java ext packs. Looking at VSCode API it seems there is still
> missing API to DISABLE extension programatically, while there is
> [uninstallExtension|https://code.visualstudio.com/api/references/commands]
> command?
> Proposed solution is not perfect:
> VSNetBeans will show dialog with text like: _Another Java support extension
> is already installed. It is recommended to use only one Java support per
> workspace. Please Disable one of Java ext for workspace._ *OK* button to open
> Extensions panel and user has to do it UX is TBD.
> Some context info:
> VSCode plans to stop recommend extensions see
> [https://github.com/microsoft/vscode/issues/136301] in Feb.
> And they are also working on extension sets per workspace
> [https://github.com/microsoft/vscode/issues/40239]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[
https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481750#comment-17481750
]
Jaroslav Tulach commented on NETBEANS-6384:
---
Dušane, what do you think about {{command 'java.clean.workspace' already
exists}}?
> Detect another Java support ext and recommend to Disable one
>
>
> Key: NETBEANS-6384
> URL: https://issues.apache.org/jira/browse/NETBEANS-6384
> Project: NetBeans
> Issue Type: Task
> Components: vscode
>Affects Versions: 12.5
>Reporter: Martin Balin
>Assignee: Jaroslav Tulach
>Priority: Major
> Fix For: NB13
>
> Attachments: Screenshot 2022-01-25 at 11.59.09.png
>
>
> VSNetBeans currently detects installation of MS Java ext pack and informs
> user it will disable some services of it, code lenses and code completion.
> See
> [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284]
> {code:javascript}
> conf.update('java.test.editor.enableShortcuts', false, false).then(() => {},
> disablingFailed);
> conf.update('java.debug.settings.enableRunDebugCodeLens', false,
> false).then(() => {}, disablingFailed);
> {code}
> This behaviour should change to better coexist with MS Java ext.
> VSNetBeans needs to show user a dialog recommending to Enable per workspace
> one of the Java ext packs. Looking at VSCode API it seems there is still
> missing API to DISABLE extension programatically, while there is
> [uninstallExtension|https://code.visualstudio.com/api/references/commands]
> command?
> Proposed solution is not perfect:
> VSNetBeans will show dialog with text like: _Another Java support extension
> is already installed. It is recommended to use only one Java support per
> workspace. Please Disable one of Java ext for workspace._ *OK* button to open
> Extensions panel and user has to do it UX is TBD.
> Some context info:
> VSCode plans to stop recommend extensions see
> [https://github.com/microsoft/vscode/issues/136301] in Feb.
> And they are also working on extension sets per workspace
> [https://github.com/microsoft/vscode/issues/40239]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[
https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474644#comment-17474644
]
Jaroslav Tulach edited comment on NETBEANS-6384 at 1/25/22, 11:25 AM:
--
Code is at
[https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions
|https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions]
the newly rebuilt sample extension is [available as
well|https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/838/]
was (Author: jtulach):
Code is at
[https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions
|https://github.com/apache/netbeans/compare/master...JaroslavTulach:jtulach/DetectMultipleJavaExtensions]
sample extension is [available as
well|https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/808/]
> Detect another Java support ext and recommend to Disable one
>
>
> Key: NETBEANS-6384
> URL: https://issues.apache.org/jira/browse/NETBEANS-6384
> Project: NetBeans
> Issue Type: Task
> Components: vscode
>Affects Versions: 12.5
>Reporter: Martin Balin
>Assignee: Jaroslav Tulach
>Priority: Major
> Fix For: NB13
>
> Attachments: Screenshot 2022-01-25 at 11.59.09.png
>
>
> VSNetBeans currently detects installation of MS Java ext pack and informs
> user it will disable some services of it, code lenses and code completion.
> See
> [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284]
> {code:javascript}
> conf.update('java.test.editor.enableShortcuts', false, false).then(() => {},
> disablingFailed);
> conf.update('java.debug.settings.enableRunDebugCodeLens', false,
> false).then(() => {}, disablingFailed);
> {code}
> This behaviour should change to better coexist with MS Java ext.
> VSNetBeans needs to show user a dialog recommending to Enable per workspace
> one of the Java ext packs. Looking at VSCode API it seems there is still
> missing API to DISABLE extension programatically, while there is
> [uninstallExtension|https://code.visualstudio.com/api/references/commands]
> command?
> Proposed solution is not perfect:
> VSNetBeans will show dialog with text like: _Another Java support extension
> is already installed. It is recommended to use only one Java support per
> workspace. Please Disable one of Java ext for workspace._ *OK* button to open
> Extensions panel and user has to do it UX is TBD.
> Some context info:
> VSCode plans to stop recommend extensions see
> [https://github.com/microsoft/vscode/issues/136301] in Feb.
> And they are also working on extension sets per workspace
> [https://github.com/microsoft/vscode/issues/40239]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[
https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481735#comment-17481735
]
Martin Balin commented on NETBEANS-6384:
The fix works and both ext packs are running (kind of) alongside. When MS Java
was started before NBLS installed then it shows attached notifications.
!Screenshot 2022-01-25 at 11.59.09.png! \
Will be great to do something about this, although I don't think we can
suppress the Could not start client NB Java error.
> Detect another Java support ext and recommend to Disable one
>
>
> Key: NETBEANS-6384
> URL: https://issues.apache.org/jira/browse/NETBEANS-6384
> Project: NetBeans
> Issue Type: Task
> Components: vscode
>Affects Versions: 12.5
>Reporter: Martin Balin
>Assignee: Jaroslav Tulach
>Priority: Major
> Fix For: NB13
>
> Attachments: Screenshot 2022-01-25 at 11.59.09.png
>
>
> VSNetBeans currently detects installation of MS Java ext pack and informs
> user it will disable some services of it, code lenses and code completion.
> See
> [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284]
> {code:javascript}
> conf.update('java.test.editor.enableShortcuts', false, false).then(() => {},
> disablingFailed);
> conf.update('java.debug.settings.enableRunDebugCodeLens', false,
> false).then(() => {}, disablingFailed);
> {code}
> This behaviour should change to better coexist with MS Java ext.
> VSNetBeans needs to show user a dialog recommending to Enable per workspace
> one of the Java ext packs. Looking at VSCode API it seems there is still
> missing API to DISABLE extension programatically, while there is
> [uninstallExtension|https://code.visualstudio.com/api/references/commands]
> command?
> Proposed solution is not perfect:
> VSNetBeans will show dialog with text like: _Another Java support extension
> is already installed. It is recommended to use only one Java support per
> workspace. Please Disable one of Java ext for workspace._ *OK* button to open
> Extensions panel and user has to do it UX is TBD.
> Some context info:
> VSCode plans to stop recommend extensions see
> [https://github.com/microsoft/vscode/issues/136301] in Feb.
> And they are also working on extension sets per workspace
> [https://github.com/microsoft/vscode/issues/40239]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6384) Detect another Java support ext and recommend to Disable one
[
https://issues.apache.org/jira/browse/NETBEANS-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Balin updated NETBEANS-6384:
---
Attachment: Screenshot 2022-01-25 at 11.59.09.png
> Detect another Java support ext and recommend to Disable one
>
>
> Key: NETBEANS-6384
> URL: https://issues.apache.org/jira/browse/NETBEANS-6384
> Project: NetBeans
> Issue Type: Task
> Components: vscode
>Affects Versions: 12.5
>Reporter: Martin Balin
>Assignee: Jaroslav Tulach
>Priority: Major
> Fix For: NB13
>
> Attachments: Screenshot 2022-01-25 at 11.59.09.png
>
>
> VSNetBeans currently detects installation of MS Java ext pack and informs
> user it will disable some services of it, code lenses and code completion.
> See
> [https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L284]
> {code:javascript}
> conf.update('java.test.editor.enableShortcuts', false, false).then(() => {},
> disablingFailed);
> conf.update('java.debug.settings.enableRunDebugCodeLens', false,
> false).then(() => {}, disablingFailed);
> {code}
> This behaviour should change to better coexist with MS Java ext.
> VSNetBeans needs to show user a dialog recommending to Enable per workspace
> one of the Java ext packs. Looking at VSCode API it seems there is still
> missing API to DISABLE extension programatically, while there is
> [uninstallExtension|https://code.visualstudio.com/api/references/commands]
> command?
> Proposed solution is not perfect:
> VSNetBeans will show dialog with text like: _Another Java support extension
> is already installed. It is recommended to use only one Java support per
> workspace. Please Disable one of Java ext for workspace._ *OK* button to open
> Extensions panel and user has to do it UX is TBD.
> Some context info:
> VSCode plans to stop recommend extensions see
> [https://github.com/microsoft/vscode/issues/136301] in Feb.
> And they are also working on extension sets per workspace
> [https://github.com/microsoft/vscode/issues/40239]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch delivery updated: Fixes to LSP client/server related to semantic highlighting.
This is an automated email from the ASF dual-hosted git repository.
neilcsmith pushed a commit to branch delivery
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/delivery by this push:
new 82a0ab7 Fixes to LSP client/server related to semantic highlighting.
new 8387f9f Merge pull request #3492 from
jlahoda/LSP-client-semantic-fixes
82a0ab7 is described below
commit 82a0ab7d7bc5e4211710bcf754a5c751b3c6e22c
Author: Jan Lahoda
AuthorDate: Sat Jan 22 17:52:56 2022 +0100
Fixes to LSP client/server related to semantic highlighting.
---
.../netbeans/modules/lsp/client/LSPBindings.java | 13 +++
.../client/bindings/CompletionProviderImpl.java| 6 +-
.../lsp/client/bindings/SemanticHighlight.java | 73 ++--
.../textmate/lexer/resources/fontsColors.xml | 2 +
.../netbeans/modules/java/lsp/server/Utils.java| 4 +
.../server/protocol/TextDocumentServiceImpl.java | 7 +-
.../java/lsp/server/protocol/ServerTest.java | 99 +-
7 files changed, 150 insertions(+), 54 deletions(-)
diff --git
a/ide/lsp.client/src/org/netbeans/modules/lsp/client/LSPBindings.java
b/ide/lsp.client/src/org/netbeans/modules/lsp/client/LSPBindings.java
index b2f180d..2fcb1cd 100644
--- a/ide/lsp.client/src/org/netbeans/modules/lsp/client/LSPBindings.java
+++ b/ide/lsp.client/src/org/netbeans/modules/lsp/client/LSPBindings.java
@@ -37,6 +37,7 @@ import java.util.HashSet;
import java.util.IdentityHashMap;
import java.util.Iterator;
import java.util.LinkedHashMap;
+import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Set;
@@ -56,6 +57,8 @@ import org.eclipse.lsp4j.InitializeParams;
import org.eclipse.lsp4j.InitializeResult;
import org.eclipse.lsp4j.ResourceOperationKind;
import org.eclipse.lsp4j.SemanticTokens;
+import org.eclipse.lsp4j.SemanticTokensCapabilities;
+import org.eclipse.lsp4j.SemanticTokensClientCapabilitiesRequests;
import org.eclipse.lsp4j.SemanticTokensLegend;
import org.eclipse.lsp4j.ServerCapabilities;
import org.eclipse.lsp4j.SymbolCapabilities;
@@ -367,6 +370,7 @@ public class LSPBindings {
dsc.setHierarchicalDocumentSymbolSupport(true);
dsc.setSymbolKind(new
SymbolKindCapabilities(Arrays.asList(SymbolKind.values(;
tdcc.setDocumentSymbol(dsc);
+ tdcc.setSemanticTokens(new SemanticTokensCapabilities(new
SemanticTokensClientCapabilitiesRequests(true), KNOWN_TOKEN_TYPES,
KNOWN_TOKEN_MODIFIERS, Arrays.asList()));
WorkspaceClientCapabilities wcc = new WorkspaceClientCapabilities();
wcc.setWorkspaceEdit(new WorkspaceEditCapabilities());
wcc.getWorkspaceEdit().setDocumentChanges(true);
@@ -387,6 +391,15 @@ public class LSPBindings {
}
}
}
+private static final List KNOWN_TOKEN_TYPES =
Collections.unmodifiableList(Arrays.asList(
+"namespace", "package", "function", "method", "macro", "parameter",
+"variable", "struct", "enum", "class", "typeAlias",
"typeParameter",
+"field", "enumMember", "keyword"
+));
+
+private static final List KNOWN_TOKEN_MODIFIERS =
Collections.unmodifiableList(Arrays.asList(
+"static", "definition", "declaration"
+));
public static synchronized Set getAllBindings() {
Set allBindings = Collections.newSetFromMap(new
IdentityHashMap<>());
diff --git
a/ide/lsp.client/src/org/netbeans/modules/lsp/client/bindings/CompletionProviderImpl.java
b/ide/lsp.client/src/org/netbeans/modules/lsp/client/bindings/CompletionProviderImpl.java
index 0fba1fc..0869a66 100644
---
a/ide/lsp.client/src/org/netbeans/modules/lsp/client/bindings/CompletionProviderImpl.java
+++
b/ide/lsp.client/src/org/netbeans/modules/lsp/client/bindings/CompletionProviderImpl.java
@@ -42,6 +42,7 @@ import org.eclipse.lsp4j.CompletionList;
import org.eclipse.lsp4j.CompletionOptions;
import org.eclipse.lsp4j.CompletionParams;
import org.eclipse.lsp4j.InitializeResult;
+import org.eclipse.lsp4j.InsertReplaceEdit;
import org.eclipse.lsp4j.MarkupContent;
import org.eclipse.lsp4j.ParameterInformation;
import org.eclipse.lsp4j.ServerCapabilities;
@@ -189,13 +190,14 @@ public class CompletionProviderImpl implements
CompletionProvider {
commit("");
}
private void commit(String appendText) {
-if (i.getTextEdit().isRight()) {
+Either edit =
i.getTextEdit();
+if (edit != null && edit.isRight()) {
//TODO: the NetBeans client does not
current support InsertReplaceEdits, should not happen
Completion.get().hideDocumentation();
Completion.get().hideCompletion();
[netbeans] branch delivery updated: fix dependencies groupId for maven 3.8.4
This is an automated email from the ASF dual-hosted git repository. skygo pushed a commit to branch delivery in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/delivery by this push: new 4b74969 fix dependencies groupId for maven 3.8.4 new dd0b0b9 Merge pull request #3496 from ebarboni/maven384depfix 4b74969 is described below commit 4b749694c323986df918236c2c5ad4e22c36496b Author: Eric Barboni AuthorDate: Mon Jan 24 10:57:30 2022 +0100 fix dependencies groupId for maven 3.8.4 --- java/maven.embedder/external/binariesembedded-list | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/java/maven.embedder/external/binariesembedded-list b/java/maven.embedder/external/binariesembedded-list index 054ff74..b51bd76 100644 --- a/java/maven.embedder/external/binariesembedded-list +++ b/java/maven.embedder/external/binariesembedded-list @@ -46,11 +46,11 @@ F87A61ADB1E12A00DCC6CC6005A51E693AA7C4AC;org.apache.maven.shared:maven-shared-ut 5B4DBD3CF0B14038766A6E915D75646C6D396E5B;org.apache.maven:maven-slf4j-provider:3.8.4 D4265DD4F0F1D7A06D80DF5A5F475D5FF9C17140;org.eclipse.sisu:org.eclipse.sisu.inject:0.3.5 D71996BB2E536F966B3B70E647067FFF3B73D32F;org.eclipse.sisu:org.eclipse.sisu.plexus:0.3.5 -425EA8E534716B4BFF1EA90F39BD76BE951D651B;org.sonatype.plexus:plexus-cipher:2.0 +425EA8E534716B4BFF1EA90F39BD76BE951D651B;org.codehaus.plexus:plexus-cipher:2.0 8587E80FCB38E70B70FAE8D5914B6376BFAD6259;org.codehaus.plexus:plexus-classworlds:2.6.0 2F2147A6CC6A119A1B51A96F31D45C557F6244B9;org.codehaus.plexus:plexus-component-annotations:2.1.0 25B919C664B79795CCDE0EDE5CEE0FD68B544197;org.codehaus.plexus:plexus-interpolation:1.26 -F89C5080614FFD0764E49861895DBEDDE1B47237;org.sonatype.plexus:plexus-sec-dispatcher:2.0 +F89C5080614FFD0764E49861895DBEDDE1B47237;org.codehaus.plexus:plexus-sec-dispatcher:2.0 CF43B5391DE623B36FE066A21127BAEF82C64022;org.codehaus.plexus:plexus-utils:3.3.0 CDCFF33940D9F2DE763BC41EA05A0BE5941176C3;org.slf4j:slf4j-api:1.7.32 85876A5672B78AA2E817EEE495239CDDD7B598E7;org.apache.maven.wagon:wagon-file:3.4.3 - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-6415) Support for Java EE 8 Web to server type Tomee 8.0.9 in Ant project setup
[ https://issues.apache.org/jira/browse/NETBEANS-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johan Borchers updated NETBEANS-6415: - Affects Version/s: 12.5 > Support for Java EE 8 Web to server type Tomee 8.0.9 in Ant project setup > - > > Key: NETBEANS-6415 > URL: https://issues.apache.org/jira/browse/NETBEANS-6415 > Project: NetBeans > Issue Type: Bug >Affects Versions: 12.5, 12.6 > Environment: *Product Version:* Apache NetBeans IDE 12.6 > *Java:* 11.0.13; Java HotSpot(TM) 64-Bit Server VM 11.0.13+10-LTS-370 > *Runtime:* Java(TM) SE Runtime Environment 11.0.13+10-LTS-370 > *System:* Mac OS X version 11.1 running on x86_64; UTF-8; en_NL (nb) > *User directory:* /Users/borcj00/Library/Application Support/NetBeans/12.6 > *Cache directory:* /Users/borcj00/Library/Caches/NetBeans/12.6 >Reporter: Johan Borchers >Priority: Major > Attachments: Screenshot 2022-01-25 at 09.09.33.png > > > I like to have Ant web project support for Java EE 8 Web when I select Tomee > 8.0.9 as application server. > Now it sticks to Java EE 7 with whatever you choose om Apache Tomee. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-6415) Support for Java EE 8 Web to server type Tomee 8.0.9 in Ant project setup
Johan Borchers created NETBEANS-6415: Summary: Support for Java EE 8 Web to server type Tomee 8.0.9 in Ant project setup Key: NETBEANS-6415 URL: https://issues.apache.org/jira/browse/NETBEANS-6415 Project: NetBeans Issue Type: Bug Affects Versions: 12.6 Environment: *Product Version:* Apache NetBeans IDE 12.6 *Java:* 11.0.13; Java HotSpot(TM) 64-Bit Server VM 11.0.13+10-LTS-370 *Runtime:* Java(TM) SE Runtime Environment 11.0.13+10-LTS-370 *System:* Mac OS X version 11.1 running on x86_64; UTF-8; en_NL (nb) *User directory:* /Users/borcj00/Library/Application Support/NetBeans/12.6 *Cache directory:* /Users/borcj00/Library/Caches/NetBeans/12.6 Reporter: Johan Borchers Attachments: Screenshot 2022-01-25 at 09.09.33.png I like to have Ant web project support for Java EE 8 Web when I select Tomee 8.0.9 as application server. Now it sticks to Java EE 7 with whatever you choose om Apache Tomee. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
