[jira] [Resolved] (NETBEANS-2652) JaCoCo Maven integration is broken in NB 11.0

2019-06-30 Thread Mark Herkrath (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Herkrath resolved NETBEANS-2652.
-
   Resolution: Fixed
Fix Version/s: 11.1

Validated in 11.1 beta 1

> JaCoCo Maven integration is broken in NB 11.0
> -
>
> Key: NETBEANS-2652
> URL: https://issues.apache.org/jira/browse/NETBEANS-2652
> Project: NetBeans
>  Issue Type: Bug
>  Components: maven - codecoverage
>Affects Versions: 11.0
>Reporter: Mark Herkrath
>Assignee: Mark Herkrath
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.1
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> NETBEANS-1768 caused issues with JaCoCo Maven integration if the 
> outputDirectory isn't configured as part of the jacoco plugin configuration. 
> As a result the JaCoCo report file isn't reliably found.
> Details can be found here: 
> [https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Assigned] (NETBEANS-2652) JaCoCo Maven integration is broken in NB 11.0

2019-06-30 Thread Mark Herkrath (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Herkrath reassigned NETBEANS-2652:
---

Assignee: Mark Herkrath

> JaCoCo Maven integration is broken in NB 11.0
> -
>
> Key: NETBEANS-2652
> URL: https://issues.apache.org/jira/browse/NETBEANS-2652
> Project: NetBeans
>  Issue Type: Bug
>  Components: maven - codecoverage
>Affects Versions: 11.0
>Reporter: Mark Herkrath
>Assignee: Mark Herkrath
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> NETBEANS-1768 caused issues with JaCoCo Maven integration if the 
> outputDirectory isn't configured as part of the jacoco plugin configuration. 
> As a result the JaCoCo report file isn't reliably found.
> Details can be found here: 
> [https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Assigned] (NETBEANS-2652) JaCoCo Maven integration is broken in NB 11.0

2019-06-07 Thread Mark Herkrath (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Herkrath reassigned NETBEANS-2652:
---

Assignee: (was: Mark Herkrath)

> JaCoCo Maven integration is broken in NB 11.0
> -
>
> Key: NETBEANS-2652
> URL: https://issues.apache.org/jira/browse/NETBEANS-2652
> Project: NetBeans
>  Issue Type: Bug
>  Components: maven - codecoverage
>Affects Versions: 11.0
>Reporter: Mark Herkrath
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> NETBEANS-1768 caused issues with JaCoCo Maven integration if the 
> outputDirectory isn't configured as part of the jacoco plugin configuration. 
> As a result the JaCoCo report file isn't reliably found.
> Details can be found here: 
> [https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1997) JaCoCo 0.8.2 breaks code coverage integration

2019-06-07 Thread Mark Herkrath (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859024#comment-16859024
 ] 

Mark Herkrath commented on NETBEANS-1997:
-

I have created NETBEANS-2652 for the issue discovered by me, including a pull 
request. It may or may not be the same John ran into.

> JaCoCo 0.8.2 breaks code coverage integration
> -
>
> Key: NETBEANS-1997
> URL: https://issues.apache.org/jira/browse/NETBEANS-1997
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Philip Durbin
>Assignee: John McDonnell
>Priority: Minor
>
> I asked, "Does JaCoCo 0.8.2 break NetBeans code coverage?" on the users 
> mailing list: 
> [https://lists.apache.org/thread.html/509bfddb9273726a6e8dff1ca419790b40858d6a648b4413142e2abe@%3Cusers.netbeans.apache.org%3E]
> Geertjan Wielenga said to go ahead and open an issue so I believe he agrees 
> that it does.
> The main evidence seems to be in 
> [https://github.com/jacoco/jacoco/issues/772] where a JaCoCo developer, 
> Evgeny Mandrikov, said the following.
> "AFAIK NetBeans integration reads XML Report, which was intentionally changed 
> in version 0.8.2 in a perfectly valid way by addition of new attribute - see 
> https://github.com/jacoco/jacoco/pull/702. NetBeans integration must be fixed 
> accordingly and ideally be less strict to cope with such updates in future. 
> This problem should reported to developers of NetBeans integration, since it 
> is not developed by us - as you can see on page 
> [https://www.jacoco.org/jacoco/trunk/doc/integrations.html] "
> My workaround was to downgrade to JaCoCo 0.8.1, as I explained in 
> [https://github.com/IQSS/dataverse/issues/5483] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-2652) JaCoCo Maven integration is broken in NB 11.0

2019-06-07 Thread Mark Herkrath (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Herkrath updated NETBEANS-2652:

Description: 
NETBEANS-1768 caused issues with JaCoCo Maven integration if the 
outputDirectory isn't configured as part of the jacoco plugin configuration. As 
a result the JaCoCo report file isn't reliably found.

Details can be found here: 
[https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E]

  was:
NETBEANS-1768 caused issues with JaCoCo Maven integration if the 
outputDirectory isn't configured as part of the jacoco plugin report 
configuration. As a result the JaCoCo report file isn't reliably found.

Details can be found here: 
https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E


> JaCoCo Maven integration is broken in NB 11.0
> -
>
> Key: NETBEANS-2652
> URL: https://issues.apache.org/jira/browse/NETBEANS-2652
> Project: NetBeans
>  Issue Type: Bug
>  Components: maven - codecoverage
>Affects Versions: 11.0
>Reporter: Mark Herkrath
>Assignee: Mark Herkrath
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> NETBEANS-1768 caused issues with JaCoCo Maven integration if the 
> outputDirectory isn't configured as part of the jacoco plugin configuration. 
> As a result the JaCoCo report file isn't reliably found.
> Details can be found here: 
> [https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-2652) JaCoCo Maven integration is broken in NB 11.0

2019-06-07 Thread Mark Herkrath (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Herkrath updated NETBEANS-2652:

Description: 
NETBEANS-1768 caused issues with JaCoCo Maven integration if the 
outputDirectory isn't configured as part of the jacoco plugin report 
configuration. As a result the JaCoCo report file isn't reliably found.

Details can be found here: 
https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E

  was:NETBEANS-1768 caused issues with JaCoCo Maven integration if the 
outputDirectory isn't configured as part of the jacoco plugin report 
configuration. As a result the JaCoCo report file isn't reliably found.


> JaCoCo Maven integration is broken in NB 11.0
> -
>
> Key: NETBEANS-2652
> URL: https://issues.apache.org/jira/browse/NETBEANS-2652
> Project: NetBeans
>  Issue Type: Bug
>  Components: maven - codecoverage
>Affects Versions: 11.0
>Reporter: Mark Herkrath
>Assignee: Mark Herkrath
>Priority: Major
>
> NETBEANS-1768 caused issues with JaCoCo Maven integration if the 
> outputDirectory isn't configured as part of the jacoco plugin report 
> configuration. As a result the JaCoCo report file isn't reliably found.
> Details can be found here: 
> https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-2652) JaCoCo Maven integration is broken in NB 11.0

2019-06-07 Thread Mark Herkrath (JIRA)
Mark Herkrath created NETBEANS-2652:
---

 Summary: JaCoCo Maven integration is broken in NB 11.0
 Key: NETBEANS-2652
 URL: https://issues.apache.org/jira/browse/NETBEANS-2652
 Project: NetBeans
  Issue Type: Bug
  Components: maven - codecoverage
Affects Versions: 11.0
Reporter: Mark Herkrath
Assignee: Mark Herkrath


NETBEANS-1768 caused issues with JaCoCo Maven integration if the 
outputDirectory isn't configured as part of the jacoco plugin report 
configuration. As a result the JaCoCo report file isn't reliably found.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1997) JaCoCo 0.8.2 breaks code coverage integration

2019-05-27 Thread Mark Herkrath (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848766#comment-16848766
 ] 

Mark Herkrath commented on NETBEANS-1997:
-

Hi Antonio,

I am using Java 8. Please note that in the link you have sent, they are 
actually moving to JaCoCo 0.8.2 to support Java 11. JaCoCo 0.8.2 has 
experimental support, 0.8.3 has official support for Java 11: 
[https://github.com/jacoco/jacoco/releases/tag/v0.8.3]

However, note that I may have hijacked this issue for another one. The other 
issue made me believe that 0.8.2 doesn't work. Details can be found here: 
[https://lists.apache.org/thread.html/bcfc0d73fc215c8f329033a312c0d3d11f8b370453f76e2c91cc184b@%3Cdev.netbeans.apache.org%3E]

With the fix, at least I can run JaCoCo 0.8.1, 0.8.2, and 0.8.3 successfully. I 
haven't tested Java 11 though.

> JaCoCo 0.8.2 breaks code coverage integration
> -
>
> Key: NETBEANS-1997
> URL: https://issues.apache.org/jira/browse/NETBEANS-1997
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Philip Durbin
>Assignee: John McDonnell
>Priority: Minor
>
> I asked, "Does JaCoCo 0.8.2 break NetBeans code coverage?" on the users 
> mailing list: 
> [https://lists.apache.org/thread.html/509bfddb9273726a6e8dff1ca419790b40858d6a648b4413142e2abe@%3Cusers.netbeans.apache.org%3E]
> Geertjan Wielenga said to go ahead and open an issue so I believe he agrees 
> that it does.
> The main evidence seems to be in 
> [https://github.com/jacoco/jacoco/issues/772] where a JaCoCo developer, 
> Evgeny Mandrikov, said the following.
> "AFAIK NetBeans integration reads XML Report, which was intentionally changed 
> in version 0.8.2 in a perfectly valid way by addition of new attribute - see 
> https://github.com/jacoco/jacoco/pull/702. NetBeans integration must be fixed 
> accordingly and ideally be less strict to cope with such updates in future. 
> This problem should reported to developers of NetBeans integration, since it 
> is not developed by us - as you can see on page 
> [https://www.jacoco.org/jacoco/trunk/doc/integrations.html] "
> My workaround was to downgrade to JaCoCo 0.8.1, as I explained in 
> [https://github.com/IQSS/dataverse/issues/5483] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1997) JaCoCo 0.8.2 breaks code coverage integration

2019-05-23 Thread Mark Herkrath (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846590#comment-16846590
 ] 

Mark Herkrath commented on NETBEANS-1997:
-

It got broken due to NETBEANS-1768 (NB 11). Will discuss at the mailing list 
how to proceed.

> JaCoCo 0.8.2 breaks code coverage integration
> -
>
> Key: NETBEANS-1997
> URL: https://issues.apache.org/jira/browse/NETBEANS-1997
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Philip Durbin
>Assignee: John McDonnell
>Priority: Minor
>
> I asked, "Does JaCoCo 0.8.2 break NetBeans code coverage?" on the users 
> mailing list: 
> [https://lists.apache.org/thread.html/509bfddb9273726a6e8dff1ca419790b40858d6a648b4413142e2abe@%3Cusers.netbeans.apache.org%3E]
> Geertjan Wielenga said to go ahead and open an issue so I believe he agrees 
> that it does.
> The main evidence seems to be in 
> [https://github.com/jacoco/jacoco/issues/772] where a JaCoCo developer, 
> Evgeny Mandrikov, said the following.
> "AFAIK NetBeans integration reads XML Report, which was intentionally changed 
> in version 0.8.2 in a perfectly valid way by addition of new attribute - see 
> https://github.com/jacoco/jacoco/pull/702. NetBeans integration must be fixed 
> accordingly and ideally be less strict to cope with such updates in future. 
> This problem should reported to developers of NetBeans integration, since it 
> is not developed by us - as you can see on page 
> [https://www.jacoco.org/jacoco/trunk/doc/integrations.html] "
> My workaround was to downgrade to JaCoCo 0.8.1, as I explained in 
> [https://github.com/IQSS/dataverse/issues/5483] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-1997) JaCoCo 0.8.2 breaks code coverage integration

2019-05-23 Thread Mark Herkrath (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846066#comment-16846066
 ] 

Mark Herkrath edited comment on NETBEANS-1997 at 5/23/19 7:52 AM:
--

Correction: I got NetBeans 11 and JaCoCo 0.8.2 to work now. However as stated 
before, after "Run All Tests" was being clicked, the Report windows has to be 
closed and re-opened after Maven is done.

This was working before. I have set the logger of 
org.netbeans.modules.maven.coverage.MavenCoverageProvider to 100. The trace is 
showing that the wrong file is being watched via FileChangeAdapter initially.

{{FINE [org.netbeans.modules.maven.coverage.MavenCoverageProvider]: missing 
C:\Program Files\NetBeans 11.0\bin\jacoco.xml}}

If I get some time, I might take a closer look.


was (Author: herkrath):
Correction: I got NetBeans 11 and JaCoCo 0.8.2 to work now. However as stated 
before, after "Run All Tests" was being clicked, the Report windows has to be 
closed and re-opened after Maven is done.

This was working before. I have set the logger of 
org.netbeans.modules.maven.coverage.MavenCoverageProvider to 100. The trace to 
showing that the wrong file is being watched via FileChangeAdapter initially.

{\{FINE [org.netbeans.modules.maven.coverage.MavenCoverageProvider]: missing 
C:\Program Files\NetBeans 11.0\bin\jacoco.xml}}

If I get some time, I might take a closer look.

> JaCoCo 0.8.2 breaks code coverage integration
> -
>
> Key: NETBEANS-1997
> URL: https://issues.apache.org/jira/browse/NETBEANS-1997
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Philip Durbin
>Assignee: John McDonnell
>Priority: Minor
>
> I asked, "Does JaCoCo 0.8.2 break NetBeans code coverage?" on the users 
> mailing list: 
> [https://lists.apache.org/thread.html/509bfddb9273726a6e8dff1ca419790b40858d6a648b4413142e2abe@%3Cusers.netbeans.apache.org%3E]
> Geertjan Wielenga said to go ahead and open an issue so I believe he agrees 
> that it does.
> The main evidence seems to be in 
> [https://github.com/jacoco/jacoco/issues/772] where a JaCoCo developer, 
> Evgeny Mandrikov, said the following.
> "AFAIK NetBeans integration reads XML Report, which was intentionally changed 
> in version 0.8.2 in a perfectly valid way by addition of new attribute - see 
> https://github.com/jacoco/jacoco/pull/702. NetBeans integration must be fixed 
> accordingly and ideally be less strict to cope with such updates in future. 
> This problem should reported to developers of NetBeans integration, since it 
> is not developed by us - as you can see on page 
> [https://www.jacoco.org/jacoco/trunk/doc/integrations.html] "
> My workaround was to downgrade to JaCoCo 0.8.1, as I explained in 
> [https://github.com/IQSS/dataverse/issues/5483] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1997) JaCoCo 0.8.2 breaks code coverage integration

2019-05-22 Thread Mark Herkrath (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846066#comment-16846066
 ] 

Mark Herkrath commented on NETBEANS-1997:
-

Correction: I got NetBeans 11 and JaCoCo 0.8.2 to work now. However as stated 
before, after "Run All Tests" was being clicked, the Report windows has to be 
closed and re-opened after Maven is done.

This was working before. I have set the logger of 
org.netbeans.modules.maven.coverage.MavenCoverageProvider to 100. The trace to 
showing that the wrong file is being watched via FileChangeAdapter initially.

{\{FINE [org.netbeans.modules.maven.coverage.MavenCoverageProvider]: missing 
C:\Program Files\NetBeans 11.0\bin\jacoco.xml}}

If I get some time, I might take a closer look.

> JaCoCo 0.8.2 breaks code coverage integration
> -
>
> Key: NETBEANS-1997
> URL: https://issues.apache.org/jira/browse/NETBEANS-1997
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Philip Durbin
>Assignee: John McDonnell
>Priority: Minor
>
> I asked, "Does JaCoCo 0.8.2 break NetBeans code coverage?" on the users 
> mailing list: 
> [https://lists.apache.org/thread.html/509bfddb9273726a6e8dff1ca419790b40858d6a648b4413142e2abe@%3Cusers.netbeans.apache.org%3E]
> Geertjan Wielenga said to go ahead and open an issue so I believe he agrees 
> that it does.
> The main evidence seems to be in 
> [https://github.com/jacoco/jacoco/issues/772] where a JaCoCo developer, 
> Evgeny Mandrikov, said the following.
> "AFAIK NetBeans integration reads XML Report, which was intentionally changed 
> in version 0.8.2 in a perfectly valid way by addition of new attribute - see 
> https://github.com/jacoco/jacoco/pull/702. NetBeans integration must be fixed 
> accordingly and ideally be less strict to cope with such updates in future. 
> This problem should reported to developers of NetBeans integration, since it 
> is not developed by us - as you can see on page 
> [https://www.jacoco.org/jacoco/trunk/doc/integrations.html] "
> My workaround was to downgrade to JaCoCo 0.8.1, as I explained in 
> [https://github.com/IQSS/dataverse/issues/5483] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-1997) JaCoCo 0.8.2 breaks code coverage integration

2019-05-22 Thread Mark Herkrath (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846027#comment-16846027
 ] 

Mark Herkrath commented on NETBEANS-1997:
-

It's replicating with NetBeans 11 and JaCoCo 0.8.2. Downgrading to 0.8.1 also 
works for me. However, the Report windows has to be closed and re-opened 
thereafter.

> JaCoCo 0.8.2 breaks code coverage integration
> -
>
> Key: NETBEANS-1997
> URL: https://issues.apache.org/jira/browse/NETBEANS-1997
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Philip Durbin
>Assignee: John McDonnell
>Priority: Minor
>
> I asked, "Does JaCoCo 0.8.2 break NetBeans code coverage?" on the users 
> mailing list: 
> [https://lists.apache.org/thread.html/509bfddb9273726a6e8dff1ca419790b40858d6a648b4413142e2abe@%3Cusers.netbeans.apache.org%3E]
> Geertjan Wielenga said to go ahead and open an issue so I believe he agrees 
> that it does.
> The main evidence seems to be in 
> [https://github.com/jacoco/jacoco/issues/772] where a JaCoCo developer, 
> Evgeny Mandrikov, said the following.
> "AFAIK NetBeans integration reads XML Report, which was intentionally changed 
> in version 0.8.2 in a perfectly valid way by addition of new attribute - see 
> https://github.com/jacoco/jacoco/pull/702. NetBeans integration must be fixed 
> accordingly and ideally be less strict to cope with such updates in future. 
> This problem should reported to developers of NetBeans integration, since it 
> is not developed by us - as you can see on page 
> [https://www.jacoco.org/jacoco/trunk/doc/integrations.html] "
> My workaround was to downgrade to JaCoCo 0.8.1, as I explained in 
> [https://github.com/IQSS/dataverse/issues/5483] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-2221) ClassCastException when try to open class from not opened module

2019-05-17 Thread Mark Herkrath (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838628#comment-16838628
 ] 

Mark Herkrath edited comment on NETBEANS-2221 at 5/17/19 8:34 AM:
--

I am running into the same issue all the time and have done some analysis:

Code of {{org.netbeans.modules.java.source.builder.TreeFactory}}, where the 
ClassCastException happens:
{code:java}
public ExpressionTree Type(TypeMirror type) {
Type t = (Type) type;
JCExpression tp;
switch (type.getKind()) {
...
case ERROR:
tp = make.at(NOPOS).Ident(((ErrorType) type).tsym.name);
break;
default:
return make.at(NOPOS).Type((Type)type);
}

return tp.setType(t);
}  {code}
The getKind() implementation of ClassType used to always return DECLARED. 
However since Java 11, the getKind() implementation of ClassType has been 
changed:
{code:java}
   @DefinedBy(Api.LANGUAGE_MODEL)
public TypeKind getKind() {
tsym.apiComplete();
return tsym.kind == TYP ? TypeKind.DECLARED : TypeKind.ERROR;
} {code}
See [http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20] due to 
[https://bugs.openjdk.java.net/browse/JDK-8187950]

The same change was done as part of nb-java here: 
[https://hg.netbeans.org/main/nb-java-x/diff/cc2673fa8c20/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java],
 as part of [https://hg.netbeans.org/main/nb-java-x/rev/cc2673fa8c20].

As a result, the cast to ErrorType for getKind() == ERROR isn't always valid 
anymore, and may throw ClassCastExceptions like this one.

Could it be possible that the nb-java change is part of the nb-java used for 
NetBeans 11, but not yet for the version used for NetBeans 10? It's not clear 
to me which tags are used.


was (Author: herkrath):
I am running into the same issue all the time and have done some analysis:

Code of {{org.netbeans.modules.java.source.builder.TreeFactory}}, where the 
ClassCastException happens:
{code:java}
public ExpressionTree Type(TypeMirror type) {
Type t = (Type) type;
JCExpression tp;
switch (type.getKind()) {
...
case ERROR:
tp = make.at(NOPOS).Ident(((ErrorType) type).tsym.name);
break;
default:
return make.at(NOPOS).Type((Type)type);
}

return tp.setType(t);
}  {code}
The getKind() implementation of ClassType used to always return DECLARED. 
However since Java 11, the getKind() implementation of ClassType has been 
changed:
{code:java}
   @DefinedBy(Api.LANGUAGE_MODEL)
public TypeKind getKind() {
tsym.apiComplete();
return tsym.kind == TYP ? TypeKind.DECLARED : TypeKind.ERROR;
} {code}
See [http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20] due to 
[https://bugs.openjdk.java.net/browse/JDK-8187950]

As a result, the cast to ErrorType for getKind() == ERROR isn't always valid 
anymore. The strange thing is that I get the same error with Java 8u212 by 
Oracle (i.e. NB is running with that version and the Java version of my project 
is also set accordingly). Maybe it was back-ported but it's not clear to me if 
their com.sun.tools sources are publicly accessible somewhere. I don't see that 
change in the Java 8 release notes. Alternatively, NetBeans is using Java 11 
for de-compilation for whatever reason. I have at least added it as a Java 
Platform.

> ClassCastException when try to open class from not opened module
> 
>
> Key: NETBEANS-2221
> URL: https://issues.apache.org/jira/browse/NETBEANS-2221
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 11.0
>Reporter: Tomas Huryn
>Priority: Major
>
> When I try to open a class from project which has not been opened before I 
> get the exception:
> WARNING [org.openide.filesystems.Ordering]: Not all children in / marked with 
> the position attribute: 
> [org-netbeans-modules-lsp-client-bindings-HyperlinkProviderImpl.instance], 
> but some are: [HyperlinkProviderImpl.instance, 
> org-netbeans-modules-editor-url-HyperlinkImpl.instance]
> WARNING [org.netbeans.modules.parsing.impl.TaskProcessor]: 
> ParserManager.parse called in AWT event thread by: 
> org.netbeans.modules.java.classfile.CodeGenerator.generateCode(CodeGenerator.java:152)
> Even though the source level of  is set to: 11, java.util.zip.CRC32C cannot 
> be found on the system module path: 
> Changing source level to 1.8
> SEVERE [global]
> java.lang.ClassCastException: class com.sun.tools.javac.code.Type$ClassType 
> cannot be cast to class com.sun.tools.javac.code.Type$ErrorType 
> (com.sun.tools.javac.code.Type$ClassType and 
> com.sun.too

[jira] [Commented] (NETBEANS-2221) ClassCastException when try to open class from not opened module

2019-05-13 Thread Mark Herkrath (JIRA)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838628#comment-16838628
 ] 

Mark Herkrath commented on NETBEANS-2221:
-

I am running into the same issue all the time and have done some analysis:

Code of {{org.netbeans.modules.java.source.builder.TreeFactory}}, where the 
ClassCastException happens:
{code:java}
public ExpressionTree Type(TypeMirror type) {
Type t = (Type) type;
JCExpression tp;
switch (type.getKind()) {
...
case ERROR:
tp = make.at(NOPOS).Ident(((ErrorType) type).tsym.name);
break;
default:
return make.at(NOPOS).Type((Type)type);
}

return tp.setType(t);
}  {code}
The getKind() implementation of ClassType used to always return DECLARED. 
However since Java 11, the getKind() implementation of ClassType has been 
changed:
{code:java}
   @DefinedBy(Api.LANGUAGE_MODEL)
public TypeKind getKind() {
tsym.apiComplete();
return tsym.kind == TYP ? TypeKind.DECLARED : TypeKind.ERROR;
} {code}
See [http://hg.openjdk.java.net/jdk/jdk/rev/cc2673fa8c20] due to 
[https://bugs.openjdk.java.net/browse/JDK-8187950]

As a result, the cast to ErrorType for getKind() == ERROR isn't always valid 
anymore. The strange thing is that I get the same error with Java 8u212 by 
Oracle (i.e. NB is running with that version and the Java version of my project 
is also set accordingly). Maybe it was back-ported but it's not clear to me if 
their com.sun.tools sources are publicly accessible somewhere. I don't see that 
change in the Java 8 release notes. Alternatively, NetBeans is using Java 11 
for de-compilation for whatever reason. I have at least added it as a Java 
Platform.

> ClassCastException when try to open class from not opened module
> 
>
> Key: NETBEANS-2221
> URL: https://issues.apache.org/jira/browse/NETBEANS-2221
> Project: NetBeans
>  Issue Type: Bug
>Affects Versions: 11.0
>Reporter: Tomas Huryn
>Priority: Major
>
> When I try to open a class from project which has not been opened before I 
> get the exception:
> WARNING [org.openide.filesystems.Ordering]: Not all children in / marked with 
> the position attribute: 
> [org-netbeans-modules-lsp-client-bindings-HyperlinkProviderImpl.instance], 
> but some are: [HyperlinkProviderImpl.instance, 
> org-netbeans-modules-editor-url-HyperlinkImpl.instance]
> WARNING [org.netbeans.modules.parsing.impl.TaskProcessor]: 
> ParserManager.parse called in AWT event thread by: 
> org.netbeans.modules.java.classfile.CodeGenerator.generateCode(CodeGenerator.java:152)
> Even though the source level of  is set to: 11, java.util.zip.CRC32C cannot 
> be found on the system module path: 
> Changing source level to 1.8
> SEVERE [global]
> java.lang.ClassCastException: class com.sun.tools.javac.code.Type$ClassType 
> cannot be cast to class com.sun.tools.javac.code.Type$ErrorType 
> (com.sun.tools.javac.code.Type$ClassType and 
> com.sun.tools.javac.code.Type$ErrorType are in unnamed module of loader 
> org.netbeans.StandardModule$OneModuleClassLoader @4f09236a)
>     at 
> org.netbeans.modules.java.source.builder.TreeFactory.Type(TreeFactory.java:863)
>     at org.netbeans.api.java.source.TreeMaker.Type(TreeMaker.java:1119)
>     at 
> org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.computeAnnotationTree(CodeGenerator.java:449)
>     at 
> org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.computeMods(CodeGenerator.java:411)
>     at 
> org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.visitType(CodeGenerator.java:373)
>     at 
> org.netbeans.modules.java.classfile.CodeGenerator$TreeBuilder.visitType(CodeGenerator.java:285)
>     at com.sun.tools.javac.code.Symbol$ClassSymbol.accept(Symbol.java:1473)
>     at 
> javax.lang.model.util.AbstractElementVisitor6.visit(AbstractElementVisitor6.java:106)
>     at 
> org.netbeans.modules.java.classfile.CodeGenerator.generateCode(CodeGenerator.java:275)
>     at 
> org.netbeans.modules.java.classfile.CodeGenerator$1.run(CodeGenerator.java:232)
>     at 
> org.netbeans.modules.java.classfile.CodeGenerator$1.run(CodeGenerator.java:152)
>     at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:672)
>     at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:662)
>     at 
> org.netbeans.api.java.source.JavaSource$MultiTask.run(JavaSource.java:501)
>     at 
> org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
>     at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
>     at 
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManage

[jira] [Updated] (NETBEANS-2148) Maven dependency Check Out action is failing with "The goal you specified requires a project to execute ..."

2019-02-27 Thread Mark Herkrath (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Herkrath updated NETBEANS-2148:

Fix Version/s: 11.0

> Maven dependency Check Out action is failing with "The goal you specified 
> requires a project to execute ..."
> 
>
> Key: NETBEANS-2148
> URL: https://issues.apache.org/jira/browse/NETBEANS-2148
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Maven
>Affects Versions: 9.0, 10.0
> Environment: Windows 10, Maven 3.5.4
>Reporter: Mark Herkrath
>Assignee: Mark Herkrath
>Priority: Major
>  Labels: pull-request-available
> Fix For: 11.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> At least under Windows 10 and Maven 3.5.4, the handy Check Out... feature at 
> _[Maven project]_ > Dependencies > _[artifact]_ > View Artifact Details > 
> Project > Source Control Management > Check Out... is broken.
> After filling the dialog and clicking _Check Out_, the Maven error "The goal 
> you specified requires a project to execute but there is no POM in this 
> directory ..." is occurring every time.
> It is caused by a space after -Dpassword in the Maven command line:
> {code:java}
> ...\mvn.cmd -DcheckoutDirectory=... -DconnectionUrl=... -Dusername= 
> -Dpassword = ... scm:checkout{code}
> Instead, it should be "{{... -Dpassword= ...}}".
> I have already sent a mail including additional details with the subject "Bug 
> and solution with Maven Dependency Check Out" to d...@netbeans.apache.org and 
> will provide an according PR for the fix on GitHub next.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-2148) Maven dependency Check Out action is failing with "The goal you specified requires a project to execute ..."

2019-02-25 Thread Mark Herkrath (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Herkrath resolved NETBEANS-2148.
-
Resolution: Fixed
  Assignee: Mark Herkrath  (was: Matthias Bläsing)

> Maven dependency Check Out action is failing with "The goal you specified 
> requires a project to execute ..."
> 
>
> Key: NETBEANS-2148
> URL: https://issues.apache.org/jira/browse/NETBEANS-2148
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Maven
>Affects Versions: 9.0, 10.0
> Environment: Windows 10, Maven 3.5.4
>Reporter: Mark Herkrath
>Assignee: Mark Herkrath
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> At least under Windows 10 and Maven 3.5.4, the handy Check Out... feature at 
> _[Maven project]_ > Dependencies > _[artifact]_ > View Artifact Details > 
> Project > Source Control Management > Check Out... is broken.
> After filling the dialog and clicking _Check Out_, the Maven error "The goal 
> you specified requires a project to execute but there is no POM in this 
> directory ..." is occurring every time.
> It is caused by a space after -Dpassword in the Maven command line:
> {code:java}
> ...\mvn.cmd -DcheckoutDirectory=... -DconnectionUrl=... -Dusername= 
> -Dpassword = ... scm:checkout{code}
> Instead, it should be "{{... -Dpassword= ...}}".
> I have already sent a mail including additional details with the subject "Bug 
> and solution with Maven Dependency Check Out" to d...@netbeans.apache.org and 
> will provide an according PR for the fix on GitHub next.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Assigned] (NETBEANS-2148) Maven dependency Check Out action is failing with "The goal you specified requires a project to execute ..."

2019-02-20 Thread Mark Herkrath (JIRA)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Herkrath reassigned NETBEANS-2148:
---

Assignee: Matthias Bläsing  (was: Mark Herkrath)

PR available at https://github.com/apache/incubator-netbeans/pull/1142
Assigning to Matthias as he agreed to pull at d...@netbeans.apache.org
Sorry if this doesn't comply with the official procedures, which are unclear to 
me.

> Maven dependency Check Out action is failing with "The goal you specified 
> requires a project to execute ..."
> 
>
> Key: NETBEANS-2148
> URL: https://issues.apache.org/jira/browse/NETBEANS-2148
> Project: NetBeans
>  Issue Type: Bug
>  Components: projects - Maven
>Affects Versions: 9.0, 10.0
> Environment: Windows 10, Maven 3.5.4
>Reporter: Mark Herkrath
>Assignee: Matthias Bläsing
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> At least under Windows 10 and Maven 3.5.4, the handy Check Out... feature at 
> _[Maven project]_ > Dependencies > _[artifact]_ > View Artifact Details > 
> Project > Source Control Management > Check Out... is broken.
> After filling the dialog and clicking _Check Out_, the Maven error "The goal 
> you specified requires a project to execute but there is no POM in this 
> directory ..." is occurring every time.
> It is caused by a space after -Dpassword in the Maven command line:
> {code:java}
> ...\mvn.cmd -DcheckoutDirectory=... -DconnectionUrl=... -Dusername= 
> -Dpassword = ... scm:checkout{code}
> Instead, it should be "{{... -Dpassword= ...}}".
> I have already sent a mail including additional details with the subject "Bug 
> and solution with Maven Dependency Check Out" to d...@netbeans.apache.org and 
> will provide an according PR for the fix on GitHub next.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-2148) Maven dependency Check Out action is failing with "The goal you specified requires a project to execute ..."

2019-02-20 Thread Mark Herkrath (JIRA)
Mark Herkrath created NETBEANS-2148:
---

 Summary: Maven dependency Check Out action is failing with "The 
goal you specified requires a project to execute ..."
 Key: NETBEANS-2148
 URL: https://issues.apache.org/jira/browse/NETBEANS-2148
 Project: NetBeans
  Issue Type: Bug
  Components: projects - Maven
Affects Versions: 9.0, 10.0
 Environment: Windows 10, Maven 3.5.4
Reporter: Mark Herkrath
Assignee: Mark Herkrath


At least under Windows 10 and Maven 3.5.4, the handy Check Out... feature at 
_[Maven project]_ > Dependencies > _[artifact]_ > View Artifact Details > 
Project > Source Control Management > Check Out... is broken.

After filling the dialog and clicking _Check Out_, the Maven error "The goal 
you specified requires a project to execute but there is no POM in this 
directory ..." is occurring every time.

It is caused by a space after -Dpassword in the Maven command line:
{code:java}
...\mvn.cmd -DcheckoutDirectory=... -DconnectionUrl=... -Dusername= 
-Dpassword = ... scm:checkout{code}
Instead, it should be "{{... -Dpassword= ...}}".

I have already sent a mail including additional details with the subject "Bug 
and solution with Maven Dependency Check Out" to d...@netbeans.apache.org and 
will provide an according PR for the fix on GitHub next.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists