[jira] [Created] (NETBEANS-918) JavaFX support for NetBeans platform
Thierry Danard created NETBEANS-918: --- Summary: JavaFX support for NetBeans platform Key: NETBEANS-918 URL: https://issues.apache.org/jira/browse/NETBEANS-918 Project: NetBeans Issue Type: Bug Components: javafx - Deployment Affects Versions: 9.0 Reporter: Thierry Danard Fix For: 9.0 I use JavaFX to display HTML content (the javafx.scene.web.WebView component). With NetBeans 8.1 and Java 8, I had this dependency to make sure JavaFX gets loaded at startup. org.netbeans.libs.javafx 2.6.1 My app would work OK without it when running from the NetBeans IDE, but was unable to capture link events when running outside of the NetBeans IDE. Adding org.netbeans.libs.javafx fixed the issue in NetBeans 8.1 and Java 8. When compiling the same code with NetBeans 9-rc1 and Java 9, I get this message from the NetBeans IDE: The JARs [D:\Users\thierry.danard\Downloads\incubating-netbeans-java-9.0-rc1-bin\netbeans\platform\modules\org-netbeans-libs-javafx.jar, C:\Program Files\Java\jdk-9.0.1\lib\ext\jfxrt.jar] contain no classes in the supposed public packages javafx.animation.*, javafx.application.*, javafx.beans.*, javafx.beans.binding.*, javafx.beans.property.*, javafx.beans.property.adapter.*, javafx.beans.value.*, javafx.collections.*, javafx.concurrent.*, javafx.css.*, javafx.embed.swing.*, javafx.event.*, javafx.fxml.*, javafx.geometry.*, javafx.scene.*, javafx.scene.canvas.*, javafx.scene.chart.*, javafx.scene.control.*, javafx.scene.control.cell.*, javafx.scene.effect.*, javafx.scene.image.*, javafx.scene.input.*, javafx.scene.layout.*, javafx.scene.media.*, javafx.scene.paint.*, javafx.scene.shape.*, javafx.scene.text.*, javafx.scene.transform.*, javafx.scene.web.*, javafx.stage.*, javafx.util.*, javafx.util.converter.*, netscape.javascript.*, com.sun.javafx.scene.web.* and so cannot be compiled against This message goes away If I remove org.netbeans.libs.javafx from the dependencies. But then running outside of the NetBeans IDE, I get this error: java.lang.NullPointerException at javafx.graphics/com.sun.prism.d3d.D3DPipeline.getAdapterOrdinal(D3DPipeline.java:205) at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.assignScreensAdapters(QuantumToolkit.java:685) at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.runToolkit(QuantumToolkit.java:312) at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$startup$10(QuantumToolkit.java:257) [catch] at javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:155) at javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native Method) at javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:175) at java.base/java.lang.Thread.run(Thread.java:844) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-798) Netbeans crashes after closing snipping tools
[ https://issues.apache.org/jira/browse/NETBEANS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504914#comment-16504914 ] Thierry Danard commented on NETBEANS-798: - We use the NetBeans platform and we have the same issue on our app. > Netbeans crashes after closing snipping tools > - > > Key: NETBEANS-798 > URL: https://issues.apache.org/jira/browse/NETBEANS-798 > Project: NetBeans > Issue Type: Bug >Reporter: Eduard Fekete >Priority: Critical > Attachments: b0.PNG > > > I opened the dialog to create a new project because I wanted to take a > screenshot of it for a bug report, by using snipping tools. Ironically I > found another bug, after taking the screenshot and closing snipping tools, > NetBeans crashed. I was able to reproduce this many times. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-934) A lock is kept on window settings file
Thierry Danard created NETBEANS-934:
---
Summary: A lock is kept on window settings file
Key: NETBEANS-934
URL: https://issues.apache.org/jira/browse/NETBEANS-934
Project: NetBeans
Issue Type: Bug
Components: platform - Window System
Affects Versions: 9.0
Reporter: Thierry Danard
Fix For: 9.0
I have an application that is based upon the NetBeans platform. In this
application, we have a session mechanism where users can save and restore the
state of the windows. The way this session mechanism works is:
To save:
* force a serialization of the window state (calling
org.netbeans.core.WindowSystem.save)
* save the content of all files in Windows2Local in a "session" file
* save the content of the tracker.properties file in the same "session" file
To restore:
* wipe out the content of the Windows2Local directory and replace it with the
saved content, then
* replace the content of the tracker.properties file
* force a clear/reload using reflection:
// load netbeans state from disk
System.gc();
System.gc();
FileUtil.refreshAll(); // needed to discard any caches copy of the setting
files
Class windowSystemClass =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.WindowSystem");
Class windowManagerClass =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.windows.WindowManagerImpl");
Class persistenceHandlerClass =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.windows.PersistenceHandler");
Class persistenceManagerClass =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.windows.persistence.PersistenceManager");
Object windowSystem = Lookup.getDefault().lookup(windowSystemClass);
Method method = windowSystemClass.getMethod("hide");
method.invoke(windowSystem);
method = windowManagerClass.getMethod("getInstance");
Object windowManager = method.invoke(windowManagerClass);
windowManager.getClass().getMethod("resetModel").invoke(windowManager);
windowManagerClass.getMethod("setRecentViewList",
String[].class).invoke(windowManager, new Object[]\{new String[0]});
method = persistenceManagerClass.getMethod("getDefault");
Object persistenceManager = method.invoke(persistenceManagerClass);
persistenceManager.getClass().getMethod("clear").invoke(persistenceManager);
method = persistenceHandlerClass.getMethod("getDefault");
Object persistenceHandler = method.invoke(persistenceHandlerClass);
persistenceHandler.getClass().getMethod("clear").invoke(persistenceHandler);
method = windowSystemClass.getMethod("load");
method.invoke(windowSystem);
method = windowSystemClass.getMethod("show");
method.invoke(windowSystem);
This used to work in versions 8.x, but no longer. Some ".settings" files are
locked. The files that stay locked vary, which points to a garbage collection
issue. File.canWrite() actually returns false for some files, which also makes
me think that the Data Objects underlying these objects are opening streams but
don't close them? Running from source, I can't find the issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-934) A lock is kept on window settings file
[
https://issues.apache.org/jira/browse/NETBEANS-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thierry Danard updated NETBEANS-934:
Description:
I have an application that is based upon the NetBeans platform. In this
application, we have a session mechanism where users can save and restore the
state of the windows. The way this session mechanism works is:
To save:
* force a serialization of the window state (calling
org.netbeans.core.WindowSystem.save)
* save the content of all files in Windows2Local in a "session" file
* save the content of the tracker.properties file in the same "session" file
To restore:
* wipe out the content of the Windows2Local directory and replace it with the
saved content, then
* replace the content of the tracker.properties file
* force a clear/reload using reflection:
// load netbeans state from disk
System.gc();
System.gc();
FileUtil.refreshAll(); // needed to discard any caches copy of the setting
files
Class windowSystemClass =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.WindowSystem");
Class windowManagerClass =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.windows.WindowManagerImpl");
Class persistenceHandlerClass =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.windows.PersistenceHandler");
Class persistenceManagerClass =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.windows.persistence.PersistenceManager");
Object windowSystem = Lookup.getDefault().lookup(windowSystemClass);
Method method = windowSystemClass.getMethod("hide");
method.invoke(windowSystem);
method = windowManagerClass.getMethod("getInstance");
Object windowManager = method.invoke(windowManagerClass);
windowManager.getClass().getMethod("resetModel").invoke(windowManager);
windowManagerClass.getMethod("setRecentViewList",
String[].class).invoke(windowManager, new Object[]{new String[0]});
method = persistenceManagerClass.getMethod("getDefault");
Object persistenceManager = method.invoke(persistenceManagerClass);
persistenceManager.getClass().getMethod("clear").invoke(persistenceManager);
method = persistenceHandlerClass.getMethod("getDefault");
Object persistenceHandler = method.invoke(persistenceHandlerClass);
persistenceHandler.getClass().getMethod("clear").invoke(persistenceHandler);
method = windowSystemClass.getMethod("load");
method.invoke(windowSystem);
method = windowSystemClass.getMethod("show");
method.invoke(windowSystem);
This used to work in versions 8.x, but no longer. Some ".settings" files are
locked. The files that stay locked vary, which points to something related to
garbage collection. File.canWrite() actually returns false for some files.
After some investigation, I found that the lock issue is probably a permission
issue (I am on Windows). It looks like that some process is removing the
ownership/permissions of the .settings files that are being created. Some
.settings files have no owner and no permissions. This explains why
File.canWrite returns false for these files.
What is this mechanism in NetBeans that changes the ownership or permissions of
the settings files?
was:
I have an application that is based upon the NetBeans platform. In this
application, we have a session mechanism where users can save and restore the
state of the windows. The way this session mechanism works is:
To save:
* force a serialization of the window state (calling
org.netbeans.core.WindowSystem.save)
* save the content of all files in Windows2Local in a "session" file
* save the content of the tracker.properties file in the same "session" file
To restore:
* wipe out the content of the Windows2Local directory and replace it with the
saved content, then
* replace the content of the tracker.properties file
* force a clear/reload using reflection:
// load netbeans state from disk
System.gc();
System.gc();
FileUtil.refreshAll(); // needed to discard any caches copy of the setting
files
Class windowSystemClass =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.WindowSystem");
Class windowManagerClass =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.windows.WindowManagerImpl");
Class persistenceHandlerClass =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.windows.PersistenceHandler");
Class persistenceManagerClass =
Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.windows.persistence.PersistenceManager");
Object windowSystem = Lookup.getDefault().lookup(windowSystemClass);
Method method = windowSystemClass.getMethod("hide");
method.invoke(windowSystem);
method = windowManagerClass.getMethod("getInstance");
Object windowManager = method.invoke(windowManagerClass);
windowManager.getClass().getMethod("resetModel").invoke(
[jira] [Commented] (NETBEANS-934) A lock is kept on window settings file
[
https://issues.apache.org/jira/browse/NETBEANS-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512715#comment-16512715
]
Thierry Danard commented on NETBEANS-934:
-
Running from code, we found that calling Mode.getTopComponents() prior to
clearing the .settings files was the culprit. Hard to tell, but it seems
NetBeans keeps input streams open for a while when Mode.getTopComponents() is
called
> A lock is kept on window settings file
> --
>
> Key: NETBEANS-934
> URL: https://issues.apache.org/jira/browse/NETBEANS-934
> Project: NetBeans
> Issue Type: Bug
> Components: platform - Window System
>Affects Versions: 9.0
>Reporter: Thierry Danard
>Priority: Minor
> Fix For: 9.0
>
>
> I have an application that is based upon the NetBeans platform. In this
> application, we have a session mechanism where users can save and restore the
> state of the windows. The way this session mechanism works is:
> To save:
> * force a serialization of the window state (calling
> org.netbeans.core.WindowSystem.save)
> * save the content of all files in Windows2Local in a "session" file
> * save the content of the tracker.properties file in the same "session" file
> To restore:
> * wipe out the content of the Windows2Local directory and replace it with
> the saved content, then
> * replace the content of the tracker.properties file
> * force a clear/reload using reflection:
> // load netbeans state from disk
> System.gc();
> System.gc();
> FileUtil.refreshAll(); // needed to discard any caches copy of the setting
> files
> Class windowSystemClass =
> Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.WindowSystem");
> Class windowManagerClass =
> Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.windows.WindowManagerImpl");
> Class persistenceHandlerClass =
> Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.windows.PersistenceHandler");
> Class persistenceManagerClass =
> Thread.currentThread().getContextClassLoader().loadClass("org.netbeans.core.windows.persistence.PersistenceManager");
> Object windowSystem = Lookup.getDefault().lookup(windowSystemClass);
> Method method = windowSystemClass.getMethod("hide");
> method.invoke(windowSystem);
> method = windowManagerClass.getMethod("getInstance");
> Object windowManager = method.invoke(windowManagerClass);
> windowManager.getClass().getMethod("resetModel").invoke(windowManager);
> windowManagerClass.getMethod("setRecentViewList",
> String[].class).invoke(windowManager, new Object[]{new String[0]});
> method = persistenceManagerClass.getMethod("getDefault");
> Object persistenceManager = method.invoke(persistenceManagerClass);
> persistenceManager.getClass().getMethod("clear").invoke(persistenceManager);
> method = persistenceHandlerClass.getMethod("getDefault");
> Object persistenceHandler = method.invoke(persistenceHandlerClass);
> persistenceHandler.getClass().getMethod("clear").invoke(persistenceHandler);
> method = windowSystemClass.getMethod("load");
> method.invoke(windowSystem);
> method = windowSystemClass.getMethod("show");
> method.invoke(windowSystem);
> This used to work in versions 8.x, but no longer. Some ".settings" files are
> locked. The files that stay locked vary, which points to something related to
> garbage collection. File.canWrite() actually returns false for some files.
> After some investigation, I found that the lock issue is probably a
> permission issue (I am on Windows). It looks like that some process is
> removing the ownership/permissions of the .settings files that are being
> created. Some .settings files have no owner and no permissions. This explains
> why File.canWrite returns false for these files.
> What is this mechanism in NetBeans that changes the ownership or permissions
> of the settings files?
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-798) Netbeans crashes after closing snipping tools
[ https://issues.apache.org/jira/browse/NETBEANS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521521#comment-16521521 ] Thierry Danard commented on NETBEANS-798: - I was able to reproduce this with the Windows 10 snipping tool https://support.microsoft.com/en-us/help/4027213/windows-10-open-snipping-tool-and-take-a-screenshot > Netbeans crashes after closing snipping tools > - > > Key: NETBEANS-798 > URL: https://issues.apache.org/jira/browse/NETBEANS-798 > Project: NetBeans > Issue Type: Bug >Affects Versions: 8.2 >Reporter: Eduard Fekete >Priority: Critical > Attachments: b0.PNG > > > I opened the dialog to create a new project because I wanted to take a > screenshot of it for a bug report, by using snipping tools. Ironically I > found another bug, after taking the screenshot and closing snipping tools, > NetBeans crashed. I was able to reproduce this many times. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-798) Netbeans crashes after closing snipping tools
[ https://issues.apache.org/jira/browse/NETBEANS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry Danard updated NETBEANS-798: Attachment: hs_err_pid7492.log > Netbeans crashes after closing snipping tools > - > > Key: NETBEANS-798 > URL: https://issues.apache.org/jira/browse/NETBEANS-798 > Project: NetBeans > Issue Type: Bug >Affects Versions: 8.2 >Reporter: Eduard Fekete >Priority: Critical > Labels: Windows10 > Attachments: b0.PNG, hs_err_pid7492.log > > > I opened the dialog to create a new project because I wanted to take a > screenshot of it for a bug report, by using snipping tools. Ironically I > found another bug, after taking the screenshot and closing snipping tools, > NetBeans crashed. I was able to reproduce this many times. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-798) Netbeans crashes after closing snipping tools
[ https://issues.apache.org/jira/browse/NETBEANS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522405#comment-16522405 ] Thierry Danard commented on NETBEANS-798: - I have attached the crash logs on Java 8. I am working on getting the same error logs on Java 9 and 10 > Netbeans crashes after closing snipping tools > - > > Key: NETBEANS-798 > URL: https://issues.apache.org/jira/browse/NETBEANS-798 > Project: NetBeans > Issue Type: Bug >Affects Versions: 8.2 >Reporter: Eduard Fekete >Priority: Critical > Labels: Windows10 > Attachments: b0.PNG, hs_err_pid7492.log > > > I opened the dialog to create a new project because I wanted to take a > screenshot of it for a bug report, by using snipping tools. Ironically I > found another bug, after taking the screenshot and closing snipping tools, > NetBeans crashed. I was able to reproduce this many times. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-798) Netbeans crashes after closing snipping tools
[ https://issues.apache.org/jira/browse/NETBEANS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry Danard updated NETBEANS-798: Attachment: hs_err_pid10608.log > Netbeans crashes after closing snipping tools > - > > Key: NETBEANS-798 > URL: https://issues.apache.org/jira/browse/NETBEANS-798 > Project: NetBeans > Issue Type: Bug >Affects Versions: 8.2 >Reporter: Eduard Fekete >Priority: Critical > Labels: Windows10 > Attachments: b0.PNG, hs_err_pid10608.log, hs_err_pid7492.log > > > I opened the dialog to create a new project because I wanted to take a > screenshot of it for a bug report, by using snipping tools. Ironically I > found another bug, after taking the screenshot and closing snipping tools, > NetBeans crashed. I was able to reproduce this many times. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-798) Netbeans crashes after closing snipping tools
[ https://issues.apache.org/jira/browse/NETBEANS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry Danard updated NETBEANS-798: Attachment: hs_err_pid7920.log > Netbeans crashes after closing snipping tools > - > > Key: NETBEANS-798 > URL: https://issues.apache.org/jira/browse/NETBEANS-798 > Project: NetBeans > Issue Type: Bug >Affects Versions: 8.2 >Reporter: Eduard Fekete >Priority: Critical > Labels: Windows10 > Attachments: b0.PNG, hs_err_pid10608.log, hs_err_pid7492.log, > hs_err_pid7920.log > > > I opened the dialog to create a new project because I wanted to take a > screenshot of it for a bug report, by using snipping tools. Ironically I > found another bug, after taking the screenshot and closing snipping tools, > NetBeans crashed. I was able to reproduce this many times. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-798) Netbeans crashes after closing snipping tools
[ https://issues.apache.org/jira/browse/NETBEANS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522452#comment-16522452 ] Thierry Danard commented on NETBEANS-798: - hs_err_pid7920.log is the log with Java 10. So far, we could only reproduce this issue with the snipping tool, but we'll try with other tools. > Netbeans crashes after closing snipping tools > - > > Key: NETBEANS-798 > URL: https://issues.apache.org/jira/browse/NETBEANS-798 > Project: NetBeans > Issue Type: Bug >Affects Versions: 8.2 >Reporter: Eduard Fekete >Priority: Critical > Labels: Windows10 > Attachments: b0.PNG, hs_err_pid10608.log, hs_err_pid7492.log, > hs_err_pid7920.log > > > I opened the dialog to create a new project because I wanted to take a > screenshot of it for a bug report, by using snipping tools. Ironically I > found another bug, after taking the screenshot and closing snipping tools, > NetBeans crashed. I was able to reproduce this many times. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-798) Netbeans crashes after closing snipping tools
[ https://issues.apache.org/jira/browse/NETBEANS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry Danard updated NETBEANS-798: Attachment: Snipping tool issue.mov > Netbeans crashes after closing snipping tools > - > > Key: NETBEANS-798 > URL: https://issues.apache.org/jira/browse/NETBEANS-798 > Project: NetBeans > Issue Type: Bug >Affects Versions: 8.2 >Reporter: Eduard Fekete >Priority: Critical > Labels: Windows10 > Attachments: Snipping tool issue.mov, b0.PNG, hs_err_pid10608.log, > hs_err_pid7492.log, hs_err_pid7920.log > > > I opened the dialog to create a new project because I wanted to take a > screenshot of it for a bug report, by using snipping tools. Ironically I > found another bug, after taking the screenshot and closing snipping tools, > NetBeans crashed. I was able to reproduce this many times. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-798) Netbeans crashes after closing snipping tools
[ https://issues.apache.org/jira/browse/NETBEANS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522710#comment-16522710 ] Thierry Danard commented on NETBEANS-798: - There are no messages.log created when the JVM crashes, just the JVM logs. I have attached a video of the crash to explain how it is reproduced. I doesn't happen each time. > Netbeans crashes after closing snipping tools > - > > Key: NETBEANS-798 > URL: https://issues.apache.org/jira/browse/NETBEANS-798 > Project: NetBeans > Issue Type: Bug >Affects Versions: 8.2 >Reporter: Eduard Fekete >Priority: Critical > Labels: Windows10 > Attachments: Snipping tool issue.mov, b0.PNG, hs_err_pid10608.log, > hs_err_pid7492.log, hs_err_pid7920.log > > > I opened the dialog to create a new project because I wanted to take a > screenshot of it for a bug report, by using snipping tools. Ironically I > found another bug, after taking the screenshot and closing snipping tools, > NetBeans crashed. I was able to reproduce this many times. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-798) Netbeans crashes after closing snipping tools
[ https://issues.apache.org/jira/browse/NETBEANS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522770#comment-16522770 ] Thierry Danard commented on NETBEANS-798: - I am not the original poster, others might have a different use case. For my particular example, it's all lighweight/swing components. I agree this is not a critical issue from a NetBeans release point of view. > Netbeans crashes after closing snipping tools > - > > Key: NETBEANS-798 > URL: https://issues.apache.org/jira/browse/NETBEANS-798 > Project: NetBeans > Issue Type: Bug > Components: platform - JDK Problems >Affects Versions: 8.2 >Reporter: Eduard Fekete >Priority: Critical > Labels: Windows10 > Attachments: Snipping tool issue.mov, b0.PNG, hs_err_pid10608.log, > hs_err_pid7492.log, hs_err_pid7920.log > > > I opened the dialog to create a new project because I wanted to take a > screenshot of it for a bug report, by using snipping tools. Ironically I > found another bug, after taking the screenshot and closing snipping tools, > NetBeans crashed. I was able to reproduce this many times. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838863#comment-16838863 ] Thierry Danard commented on NETBEANS-1792: -- This issue is also present in NetBeans 11 > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Assignee: Svatopluk Dedic >Priority: Major > Fix For: Next > > Attachments: DemoNetBeans1792.zip, image-2018-12-10-19-26-40-055.png, > image-2018-12-11-09-23-24-408.png, image-2018-12-11-09-47-54-474.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry Danard updated NETBEANS-1792: - Affects Version/s: 11.0 > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0, 11.0 >Reporter: Thierry Danard >Assignee: Svatopluk Dedic >Priority: Major > Fix For: Next > > Attachments: DemoNetBeans1792.zip, image-2018-12-10-19-26-40-055.png, > image-2018-12-11-09-23-24-408.png, image-2018-12-11-09-47-54-474.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838890#comment-16838890 ] Thierry Danard commented on NETBEANS-1792: -- I can provide a patch. > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0, 11.0 >Reporter: Thierry Danard >Assignee: Svatopluk Dedic >Priority: Major > Fix For: Next > > Attachments: DemoNetBeans1792.zip, image-2018-12-10-19-26-40-055.png, > image-2018-12-11-09-23-24-408.png, image-2018-12-11-09-47-54-474.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838923#comment-16838923 ] Thierry Danard commented on NETBEANS-1792: -- Pull request is [https://github.com/apache/netbeans/pull/1250] > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0, 11.0 >Reporter: Thierry Danard >Assignee: Svatopluk Dedic >Priority: Major > Labels: pull-request-available > Fix For: Next > > Attachments: DemoNetBeans1792.zip, image-2018-12-10-19-26-40-055.png, > image-2018-12-11-09-23-24-408.png, image-2018-12-11-09-47-54-474.png > > Time Spent: 10m > Remaining Estimate: 0h > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[
https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738766#comment-16738766
]
Thierry Danard commented on NETBEANS-1792:
--
I confirm that changing org.openide.awt.Actions.java to
if (action instanceof BooleanStateAction) {
b = new BooleanButtonBridge(button, (BooleanStateAction)action);
} *else if* (action.getValue(Actions.ACTION_VALUE_TOGGLE) != null) {
b = new BooleanButtonBridge(button, action);
} else {
b = new ButtonBridge(button, action);
}
fixed the issue.
For any developer who encounters the same issue, this is what I did to patch my
own copy of the NetBeans 10 platform:
* download the NetBeans 10 source code
* download the NetBeans 10 binaries
* make the change above to the org.openide.awt.Actions.java class in the
source code
* build (I typed "ant" from the command line and waited about 20 minutes)
* in the org-openide-awt.jar from the binaries, substitute the Action.class
with yours
* calculate the crc of your new org-openide-awt.jar file (I used
https://emn178.github.io/online-tools/crc32_checksum.html)
* in the platform\update_tracking\org-openide-awt.xml file, change the crc of
modules/org-openide-awt.jar to this new value
If you apply these changes to the binaries and NetBeans doesn't start, check
the logs for errors
(C:\Users\yourusername\AppData\Roaming\NetBeans\10.0\var\log\messages.log on
Windows)
> Behavior of BooleanStateAction has changed
> --
>
> Key: NETBEANS-1792
> URL: https://issues.apache.org/jira/browse/NETBEANS-1792
> Project: NetBeans
> Issue Type: Bug
> Components: platform - Actions
>Affects Versions: 10.0
>Reporter: Thierry Danard
>Assignee: Svatopluk Dedic
>Priority: Major
> Fix For: 10.0
>
> Attachments: DemoNetBeans1792.zip, image-2018-12-10-19-26-40-055.png,
> image-2018-12-11-09-23-24-408.png, image-2018-12-11-09-47-54-474.png
>
>
> I used the latest release candidate of NetBeans 10 (vc4), and found that
> BooleanStateAction fires two "booleanState" events instead of one when a
> button backed by a BooleanStateAction is pressed, the first event reporting
> that the state is changing to "true", the second event reporting that the
> state is changing back to "false" (even though the button is still showing as
> "pressed")
> In my case, this BooleanStateAction is inside a JToolbar.
> javax.swing.JToolBar toolbar = new JToolBar();
> toolbar.setFloatable(false);
> toolbar.setRollover(true);
> Component tp1 =
> SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter();
> Component tp2 =
> SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter();
> Component tp3 =
> SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter();
> tp1.setFocusable(false);
> tp2.setFocusable(false);
> tp3.setFocusable(false);
> toolbar.add(tp1);
> toolbar.add(tp2);
> toolbar.add(tp3);
> JPanel toolbarPanel = new JPanel(new BorderLayout());
> toolbarPanel.add(toolbar, BorderLayout.WEST);
>
> This is a breaking change, it was working just fine in NetBeans 9. It breaks
> a lot of code in my app as I rely on the booleanState event to enable to
> disable behaviors: right now, when a user clicks a button, it shows as
> "pressed", but the associated function gets disabled right after it gets
> enabled.
> I wasn't able to find a root cause after running from NetBeans source.
> I did note that the BooleanStateAction is deprecated.
> I'll try to provide a sample code to reproduce.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-1792) Behavior of BooleanStateAction has changed
Thierry Danard created NETBEANS-1792: Summary: Behavior of BooleanStateAction has changed Key: NETBEANS-1792 URL: https://issues.apache.org/jira/browse/NETBEANS-1792 Project: NetBeans Issue Type: Bug Components: platform - Actions Affects Versions: 10.0 Reporter: Thierry Danard Fix For: 10.0 I used the latest release candidate of NetBeans 10 (vc4), and found that BooleanStateAction fires two "booleanState" events instead of one when a button backed by a BooleanStateAction is pressed, the first event reporting that the state is changing to "true", the second event reporting that the state is changing back to "false" (even though the button is still showing as "pressed") In my case, this BooleanStateAction is inside a JToolbar. javax.swing.JToolBar toolbar = new JToolBar(); toolbar.setFloatable(false); toolbar.setRollover(true); Component tp1 = SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); Component tp2 = SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); Component tp3 = SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); tp1.setFocusable(false); tp2.setFocusable(false); tp3.setFocusable(false); toolbar.add(tp1); toolbar.add(tp2); toolbar.add(tp3); JPanel toolbarPanel = new JPanel(new BorderLayout()); toolbarPanel.add(toolbar, BorderLayout.WEST); This is a breaking change, it was working just fine in NetBeans 9. It breaks a lot of code in my app as I rely on the booleanState event to enable to disable behaviors: right now, when a user clicks a button, it shows as "pressed", but the associated function gets disabled right after it gets enabled. I wasn't able to find a root cause after running from NetBeans source. I did note that the BooleanStateAction is deprecated. I'll try to provide a sample code to reproduce. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715904#comment-16715904 ] Thierry Danard commented on NETBEANS-1792: -- AbstractButton.listenerList.getListenerList() has twice the same boolean state action listed when DefaultButtonModel.fireActionPerformed is called. As a result, AbstractButton$Handler.actionPerformed(e) is called twice. > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry Danard updated NETBEANS-1792: - Attachment: image-2018-12-10-19-26-09-728.png > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > Attachments: image-2018-12-10-19-26-40-055.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry Danard updated NETBEANS-1792: - Attachment: image-2018-12-10-19-26-40-055.png > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > Attachments: image-2018-12-10-19-26-40-055.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715919#comment-16715919 ] Thierry Danard commented on NETBEANS-1792: -- !image-2018-12-10-19-26-40-055.png! > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > Attachments: image-2018-12-10-19-26-40-055.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry Danard updated NETBEANS-1792: - Attachment: (was: image-2018-12-10-19-26-09-728.png) > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > Attachments: image-2018-12-10-19-26-40-055.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry Danard updated NETBEANS-1792: - Attachment: image-2018-12-11-09-23-24-408.png > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > Attachments: image-2018-12-10-19-26-40-055.png, > image-2018-12-11-09-23-24-408.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717369#comment-16717369 ] Thierry Danard commented on NETBEANS-1792: -- I downloaded the latest version from GitHib (https://github.com/apache/incubator-netbeans). This is the code I retrieved for BooleanStateAction: !image-2018-12-11-09-23-24-408.png! This issue is present when I run NetBeans from code or from from the vc4 binaries. I'll create a small module to reproduce. > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > Attachments: image-2018-12-10-19-26-40-055.png, > image-2018-12-11-09-23-24-408.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry Danard updated NETBEANS-1792: - Attachment: DemoNetBeans1792.zip > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > Attachments: DemoNetBeans1792.zip, image-2018-12-10-19-26-40-055.png, > image-2018-12-11-09-23-24-408.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry Danard updated NETBEANS-1792: - Attachment: image-2018-12-11-09-47-54-474.png > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > Attachments: DemoNetBeans1792.zip, image-2018-12-10-19-26-40-055.png, > image-2018-12-11-09-23-24-408.png, image-2018-12-11-09-47-54-474.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717415#comment-16717415 ] Thierry Danard edited comment on NETBEANS-1792 at 12/11/18 3:48 PM: I have attached a sample project to reproduce Go to the Window->Demo menu item Click the "Demo" button on the "Demo" window With NetBeans 9, the console shows: state is false With NetBeans 10, the console shows: State is false State is true !image-2018-12-11-09-47-54-474.png! was (Author: tdanard): I have attached a sample project to reproduce Go to the Window->Demo menu item Click the "Demo" button on the "Demo" button With NetBeans 9, the console shows: state is false With NetBeans 10, the console shows: State is false State is true !image-2018-12-11-09-47-54-474.png! > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > Attachments: DemoNetBeans1792.zip, image-2018-12-10-19-26-40-055.png, > image-2018-12-11-09-23-24-408.png, image-2018-12-11-09-47-54-474.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717416#comment-16717416 ] Thierry Danard commented on NETBEANS-1792: -- I'll create a thread on the dev mailing list > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > Attachments: DemoNetBeans1792.zip, image-2018-12-10-19-26-40-055.png, > image-2018-12-11-09-23-24-408.png, image-2018-12-11-09-47-54-474.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717415#comment-16717415 ] Thierry Danard commented on NETBEANS-1792: -- I have attached a sample project to reproduce Go to the Window->Demo menu item Click the "Demo" button on the "Demo" button With NetBeans 9, the console shows: state is false With NetBeans 10, the console shows: State is false State is true !image-2018-12-11-09-47-54-474.png! > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > Attachments: DemoNetBeans1792.zip, image-2018-12-10-19-26-40-055.png, > image-2018-12-11-09-23-24-408.png, image-2018-12-11-09-47-54-474.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-1792) Behavior of BooleanStateAction has changed
[ https://issues.apache.org/jira/browse/NETBEANS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717436#comment-16717436 ] Thierry Danard commented on NETBEANS-1792: -- I used Oracle JDK 8 to reproduce I just sent an email [to d...@netbeans.incubator.apache.org|mailto:to%c2%a0...@netbeans.incubator.apache.org] with the subject "Behavior of BooleanStateAction has changed (issue NETBEANS-1792)" > Behavior of BooleanStateAction has changed > -- > > Key: NETBEANS-1792 > URL: https://issues.apache.org/jira/browse/NETBEANS-1792 > Project: NetBeans > Issue Type: Bug > Components: platform - Actions >Affects Versions: 10.0 >Reporter: Thierry Danard >Priority: Major > Fix For: 10.0 > > Attachments: DemoNetBeans1792.zip, image-2018-12-10-19-26-40-055.png, > image-2018-12-11-09-23-24-408.png, image-2018-12-11-09-47-54-474.png > > > I used the latest release candidate of NetBeans 10 (vc4), and found that > BooleanStateAction fires two "booleanState" events instead of one when a > button backed by a BooleanStateAction is pressed, the first event reporting > that the state is changing to "true", the second event reporting that the > state is changing back to "false" (even though the button is still showing as > "pressed") > In my case, this BooleanStateAction is inside a JToolbar. > javax.swing.JToolBar toolbar = new JToolBar(); > toolbar.setFloatable(false); > toolbar.setRollover(true); > Component tp1 = > SystemAction.get(MyBooleanStateAction1.class).getToolbarPresenter(); > Component tp2 = > SystemAction.get(MyBooleanStateAction2.class).getToolbarPresenter(); > Component tp3 = > SystemAction.get(MyBooleanStateAction3.class).getToolbarPresenter(); > tp1.setFocusable(false); > tp2.setFocusable(false); > tp3.setFocusable(false); > toolbar.add(tp1); > toolbar.add(tp2); > toolbar.add(tp3); > JPanel toolbarPanel = new JPanel(new BorderLayout()); > toolbarPanel.add(toolbar, BorderLayout.WEST); > > This is a breaking change, it was working just fine in NetBeans 9. It breaks > a lot of code in my app as I rely on the booleanState event to enable to > disable behaviors: right now, when a user clicks a button, it shows as > "pressed", but the associated function gets disabled right after it gets > enabled. > I wasn't able to find a root cause after running from NetBeans source. > I did note that the BooleanStateAction is deprecated. > I'll try to provide a sample code to reproduce. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
