[jira] [Comment Edited] (NETBEANS-6349) Recent builds of the module responsible for java source parsing break BC to JDK 8

2022-01-05 Thread Jaroslav Tulach (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-6349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469742#comment-17469742
 ] 

Jaroslav Tulach edited comment on NETBEANS-6349 at 1/6/22, 7:23 AM:


The problem with CharBuffer.flip() can easily be fixed by downcasting to 
{{Buffer}} first like:
{code:java}
netbeans$ git diff
diff --git 
a/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
 
b/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
index dcc5c286ad24..1208cf76dbb5 100644
--- 
a/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
+++ 
b/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
@@ -44,6 +44,7 @@ import java.net.URI;
 import java.net.URISyntaxException;
 import java.net.URL;
 import java.net.URLEncoder;
+import java.nio.Buffer;
 import java.nio.CharBuffer;
 import java.nio.channels.CompletionHandler;
 import java.nio.charset.Charset;
@@ -513,7 +514,9 @@ public class FileObjects {
             return new MemoryFileObject(pkgStr, nameStr, uri, lastModified, 
CharBuffer.wrap( content ) );
         }
         else {
-            return new MemoryFileObject(pkgStr, nameStr, uri, lastModified, 
(CharBuffer)CharBuffer.allocate( length + 1 ).append( content ).append( ' ' 
).flip() );
+            Buffer buf = CharBuffer.allocate( length + 1 ).append( content 
).append( ' ' );
+            CharBuffer flipped = (CharBuffer) buf.flip();
+            return new MemoryFileObject(pkgStr, nameStr, uri, lastModified, 
flipped);
         }
     }
 {code}
feel free to apply the fix where needed. Thank you.


was (Author: jtulach):
The problem with {{CharBuffer.flip() }}can easily be fixed with:
{code:java}
netbeans$ git diff
diff --git 
a/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
 
b/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
index dcc5c286ad24..1208cf76dbb5 100644
--- 
a/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
+++ 
b/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
@@ -44,6 +44,7 @@ import java.net.URI;
 import java.net.URISyntaxException;
 import java.net.URL;
 import java.net.URLEncoder;
+import java.nio.Buffer;
 import java.nio.CharBuffer;
 import java.nio.channels.CompletionHandler;
 import java.nio.charset.Charset;
@@ -513,7 +514,9 @@ public class FileObjects {
             return new MemoryFileObject(pkgStr, nameStr, uri, lastModified, 
CharBuffer.wrap( content ) );
         }
         else {
-            return new MemoryFileObject(pkgStr, nameStr, uri, lastModified, 
(CharBuffer)CharBuffer.allocate( length + 1 ).append( content ).append( ' ' 
).flip() );
+            Buffer buf = CharBuffer.allocate( length + 1 ).append( content 
).append( ' ' );
+            CharBuffer flipped = (CharBuffer) buf.flip();
+            return new MemoryFileObject(pkgStr, nameStr, uri, lastModified, 
flipped);
         }
     }
 {code}
feel free to apply the fix where needed. Thank you.

> Recent builds of the module responsible for java source parsing break BC to 
> JDK 8
> -
>
> Key: NETBEANS-6349
> URL: https://issues.apache.org/jira/browse/NETBEANS-6349
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Parsing  Indexing
>Affects Versions: 12.5, 12.6
>Reporter: Thomas Schapitz
>Assignee: Jaroslav Tulach
>Priority: Critical
>
> There are 6 linked Issues, that all follow a common pattern, pointing to a 
> common cause:
>  * They are accompanied by an java.lang.NoSuchMethodError: 
> java.nio.CharBuffer.flip()Ljava/nio/CharBuffer;
>  * The users indicate, they are running NB 12.5+ with JDK8
>  * The errors occur during parsing.
> Sure enough, JDK 8 hasn't 
> java.nio.CharBuffer.flip()Ljava/nio/{*}+CharBuffer+{*},
> it has only java.nio.CharBuffer.flip()Ljava/nio/{+}*Buffer,*{+} which it 
> inherits from Buffer.
> Which means: the Module in question has obviously been compiled against a 
> library more recent then JDK8, at least JDK9, which has this method.
>  
> Consequences:
> This and the 6 linked issues will automatically be fixed with the rollout of 
> NB 13, which will require JDK 11 as prerequisite anyway.
> In the mean time, users may work around the problem, by immediately switching 
> to JDK 9+ when executing Netbeans. Note that they should still be able to 
> develop and build for JDKs 8 an prior.  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: 

[jira] [Comment Edited] (NETBEANS-6349) Recent builds of the module responsible for java source parsing break BC to JDK 8

2022-01-05 Thread Jaroslav Tulach (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-6349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469742#comment-17469742
 ] 

Jaroslav Tulach edited comment on NETBEANS-6349 at 1/6/22, 7:22 AM:


The problem with {{CharBuffer.flip() }}can easily be fixed with:
{code:java}
netbeans$ git diff
diff --git 
a/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
 
b/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
index dcc5c286ad24..1208cf76dbb5 100644
--- 
a/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
+++ 
b/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
@@ -44,6 +44,7 @@ import java.net.URI;
 import java.net.URISyntaxException;
 import java.net.URL;
 import java.net.URLEncoder;
+import java.nio.Buffer;
 import java.nio.CharBuffer;
 import java.nio.channels.CompletionHandler;
 import java.nio.charset.Charset;
@@ -513,7 +514,9 @@ public class FileObjects {
             return new MemoryFileObject(pkgStr, nameStr, uri, lastModified, 
CharBuffer.wrap( content ) );
         }
         else {
-            return new MemoryFileObject(pkgStr, nameStr, uri, lastModified, 
(CharBuffer)CharBuffer.allocate( length + 1 ).append( content ).append( ' ' 
).flip() );
+            Buffer buf = CharBuffer.allocate( length + 1 ).append( content 
).append( ' ' );
+            CharBuffer flipped = (CharBuffer) buf.flip();
+            return new MemoryFileObject(pkgStr, nameStr, uri, lastModified, 
flipped);
         }
     }
 {code}
feel free to apply the fix where needed. Thank you.


was (Author: jtulach):
The problem with \{{CharBuffer.flip()} can easily be fixed with:
{code:java}
netbeans$ git diff
diff --git 
a/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
 
b/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
index dcc5c286ad24..1208cf76dbb5 100644
--- 
a/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
+++ 
b/java/java.source.base/src/org/netbeans/modules/java/source/parsing/FileObjects.java
@@ -44,6 +44,7 @@ import java.net.URI;
 import java.net.URISyntaxException;
 import java.net.URL;
 import java.net.URLEncoder;
+import java.nio.Buffer;
 import java.nio.CharBuffer;
 import java.nio.channels.CompletionHandler;
 import java.nio.charset.Charset;
@@ -513,7 +514,9 @@ public class FileObjects {
             return new MemoryFileObject(pkgStr, nameStr, uri, lastModified, 
CharBuffer.wrap( content ) );
         }
         else {
-            return new MemoryFileObject(pkgStr, nameStr, uri, lastModified, 
(CharBuffer)CharBuffer.allocate( length + 1 ).append( content ).append( ' ' 
).flip() );
+            Buffer buf = CharBuffer.allocate( length + 1 ).append( content 
).append( ' ' );
+            CharBuffer flipped = (CharBuffer) buf.flip();
+            return new MemoryFileObject(pkgStr, nameStr, uri, lastModified, 
flipped);
         }
     }
 {code}
feel free to apply the fix where needed. Thank you.

> Recent builds of the module responsible for java source parsing break BC to 
> JDK 8
> -
>
> Key: NETBEANS-6349
> URL: https://issues.apache.org/jira/browse/NETBEANS-6349
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Parsing  Indexing
>Affects Versions: 12.5, 12.6
>Reporter: Thomas Schapitz
>Assignee: Jaroslav Tulach
>Priority: Critical
>
> There are 6 linked Issues, that all follow a common pattern, pointing to a 
> common cause:
>  * They are accompanied by an java.lang.NoSuchMethodError: 
> java.nio.CharBuffer.flip()Ljava/nio/CharBuffer;
>  * The users indicate, they are running NB 12.5+ with JDK8
>  * The errors occur during parsing.
> Sure enough, JDK 8 hasn't 
> java.nio.CharBuffer.flip()Ljava/nio/{*}+CharBuffer+{*},
> it has only java.nio.CharBuffer.flip()Ljava/nio/{+}*Buffer,*{+} which it 
> inherits from Buffer.
> Which means: the Module in question has obviously been compiled against a 
> library more recent then JDK8, at least JDK9, which has this method.
>  
> Consequences:
> This and the 6 linked issues will automatically be fixed with the rollout of 
> NB 13, which will require JDK 11 as prerequisite anyway.
> In the mean time, users may work around the problem, by immediately switching 
> to JDK 9+ when executing Netbeans. Note that they should still be able to 
> develop and build for JDKs 8 an prior.  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For 

[jira] [Comment Edited] (NETBEANS-6349) Recent builds of the module responsible for java source parsing break BC to JDK 8

2022-01-05 Thread Blocked (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-6349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469686#comment-17469686
 ] 

Blocked edited comment on NETBEANS-6349 at 1/6/22, 6:21 AM:


[~taps] i downloaded  
[netbeans-12.5-bin.zip|https://archive.apache.org/dist/netbeans/netbeans/12.5/netbeans-12.5-bin.zip]
 (JAVA_HOME=JDK8) and i don't get any errors(just a little test).

With Netbeans 12.6 ,in netbeans.conf i changed to this: netbeans_jdkhome=JDK9, 
and i don't have errors but netbeans set JDK9 for Gradle and i don't want this.



what is the difference with installing Netbeans from .zip or from .exe ?

I want to help but i can only on 7-9 Jan. Give more detail about how i can find 
the problem. i will download nb 12.6 sources and build with ant my netbeans?


was (Author: JIRAUSER283089):
[~taps] i downloaded  
[netbeans-12.5-bin.zip|https://archive.apache.org/dist/netbeans/netbeans/12.5/netbeans-12.5-bin.zip]
 (JAVA_HOME=JDK8) and i don't get any errors(just a little test).

With Netbeans 12.6 ,in netbeans.conf i changed to this: netbeans_jdkhome=JDK9, 
and i have the same errors like with JDK8.

what is the difference with installing Netbeans from .zip or from .exe ?

I want to help but i can only on 7-9 Jan. Give more detail about how i can find 
the problem. i will download nb 12.6 sources and build with ant my netbeans?

> Recent builds of the module responsible for java source parsing break BC to 
> JDK 8
> -
>
> Key: NETBEANS-6349
> URL: https://issues.apache.org/jira/browse/NETBEANS-6349
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Parsing  Indexing
>Affects Versions: 12.5, 12.6
>Reporter: Thomas Schapitz
>Assignee: Jaroslav Tulach
>Priority: Critical
>
> There are 6 linked Issues, that all follow a common pattern, pointing to a 
> common cause:
>  * They are accompanied by an java.lang.NoSuchMethodError: 
> java.nio.CharBuffer.flip()Ljava/nio/CharBuffer;
>  * The users indicate, they are running NB 12.5+ with JDK8
>  * The errors occur during parsing.
> Sure enough, JDK 8 hasn't 
> java.nio.CharBuffer.flip()Ljava/nio/{*}+CharBuffer+{*},
> it has only java.nio.CharBuffer.flip()Ljava/nio/{+}*Buffer,*{+} which it 
> inherits from Buffer.
> Which means: the Module in question has obviously been compiled against a 
> library more recent then JDK8, at least JDK9, which has this method.
>  
> Consequences:
> This and the 6 linked issues will automatically be fixed with the rollout of 
> NB 13, which will require JDK 11 as prerequisite anyway.
> In the mean time, users may work around the problem, by immediately switching 
> to JDK 9+ when executing Netbeans. Note that they should still be able to 
> develop and build for JDKs 8 an prior.  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-6349) Recent builds of the module responsible for java source parsing break BC to JDK 8

2022-01-05 Thread Neil C Smith (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-6349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469258#comment-17469258
 ] 

Neil C Smith edited comment on NETBEANS-6349 at 1/5/22, 12:18 PM:
--

[~blocked] this is the people responsible taking action!  That text should be 
updated, as well to say that JDK 17 is fully supported (it's been copied over 
from 12.5 release).  JDK 8 support is legacy and will be dropped - NetBeans 13 
release candidate will be available in a couple of weeks.  If you _really_ need 
to run the IDE on JDK 8, then I would stick to 12.5 for now.

[~geertjan] what do you think we should do with this on the website - make JDK 
11 a requirement for the 12.6 convenience binaries at this point in time?  
Source release should still work with JDK 8.

[~taps] just tried with 12.5 and 12.6.  Can reproduce only on 12.6.  Does show 
we don't have enough people testing on JDK 8 that this didn't actually get 
picked up in a release candidate!


was (Author: neilcsmith):
[~blocked] this is the people responsible taking action!  That text should be 
updated, as well to say that JDK 17 is fully supported (it's been copied over 
from 12.5 release).  JDK 8 support is legacy and will be dropped - NetBeans 13 
release candidate will be available in a couple of weeks.  If you _really_ need 
to run the IDE on JDK 8, then I would stick to 12.5 for now.

[~geertjan] what do you think we should do with this on the website - make JDK 
11 a requirement for the 12.6 convenience binaries at this point in time?  
Source release should still work with JDK 8.

> Recent builds of the module responsible for java source parsing break BC to 
> JDK 8
> -
>
> Key: NETBEANS-6349
> URL: https://issues.apache.org/jira/browse/NETBEANS-6349
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Parsing  Indexing
>Affects Versions: 12.5, 12.6
>Reporter: Thomas Schapitz
>Priority: Critical
>
> There are 6 linked Issues, that all follow a common pattern, pointing to a 
> common cause:
>  * They are accompanied by an java.lang.NoSuchMethodError: 
> java.nio.CharBuffer.flip()Ljava/nio/CharBuffer;
>  * The users indicate, they are running NB 12.5+ with JDK8
>  * The errors occur during parsing.
> Sure enough, JDK 8 hasn't 
> java.nio.CharBuffer.flip()Ljava/nio/{*}+CharBuffer+{*},
> it has only java.nio.CharBuffer.flip()Ljava/nio/{+}*Buffer,*{+} which it 
> inherits from Buffer.
> Which means: the Module in question has obviously been compiled against a 
> library more recent then JDK8, at least JDK9, which has this method.
>  
> Consequences:
> This and the 6 linked issues will automatically be fixed with the rollout of 
> NB 13, which will require JDK 11 as prerequisite anyway.
> In the mean time, users may work around the problem, by immediately switching 
> to JDK 9+ when executing Netbeans. Note that they should still be able to 
> develop and build for JDKs 8 an prior.  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-6349) Recent builds of the module responsible for java source parsing break BC to JDK 8

2022-01-05 Thread Nutzu Nutzu (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-6349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469229#comment-17469229
 ] 

Nutzu Nutzu edited comment on NETBEANS-6349 at 1/5/22, 11:37 AM:
-

[https://netbeans.apache.org/download/nb126/nb126.html]
"{*}Apache NetBeans 12.6 runs on JDK LTS releases 8 and 11, with experimental 
support for JDK 17, i.e., the current JDK release at the time of this NetBeans 
release.{*}"
I spended a lot o time to figure out what's the problem with this new Netbeans 
version (12.6).

I installed it because on 
[https://netbeans.apache.org/download/nb126/nb126.html] writes that Netbeans 
12.6 works with JDK 8. 
The people responsible for this: why don't takes any action? Remove the text 
from site (that say it's working with JDK 8) *or* make a Netbeans 12.6 with JDK 
8.

Same question for Netbeans 12.5.


was (Author: JIRAUSER283089):
[https://netbeans.apache.org/download/nb126/nb126.html]
"{*}Apache NetBeans 12.6 runs on JDK LTS releases 8 and 11, with experimental 
support for JDK 17, i.e., the current JDK release at the time of this NetBeans 
release.{*}"
I spended a lot o time to figure out what's the problem with this new Netbeans 
version (12.6).

I installed it because on https://netbeans.apache.org/download/nb126/nb126.html 
writes that Netbeans 12.6 works with JDK 8. 
The people responsible for this: why don't takes any action? Remove the text 
from site (that say it's working with JDK 8) *or* make a Netbeans 12.6 with JDK 
8.

 

> Recent builds of the module responsible for java source parsing break BC to 
> JDK 8
> -
>
> Key: NETBEANS-6349
> URL: https://issues.apache.org/jira/browse/NETBEANS-6349
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Parsing  Indexing
>Affects Versions: 12.5, 12.6
>Reporter: Thomas Schapitz
>Priority: Critical
>
> There are 6 linked Issues, that all follow a common pattern, pointing to a 
> common cause:
>  * They are accompanied by an java.lang.NoSuchMethodError: 
> java.nio.CharBuffer.flip()Ljava/nio/CharBuffer;
>  * The users indicate, they are running NB 12.5+ with JDK8
>  * The errors occur during parsing.
> Sure enough, JDK 8 hasn't 
> java.nio.CharBuffer.flip()Ljava/nio/{*}+CharBuffer+{*},
> it has only java.nio.CharBuffer.flip()Ljava/nio/{+}*Buffer,*{+} which it 
> inherits from Buffer.
> Which means: the Module in question has obviously been compiled against a 
> library more recent then JDK8, at least JDK9, which has this method.
>  
> Consequences:
> This and the 6 linked issues will automatically be fixed with the rollout of 
> NB 13, which will require JDK 11 as prerequisite anyway.
> In the mean time, users may work around the problem, by immediately switching 
> to JDK 9+ when executing Netbeans. Note that they should still be able to 
> develop and build for JDKs 8 an prior.  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-6349) Recent builds of the module responsible for java source parsing break BC to JDK 8

2022-01-05 Thread Neil C Smith (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-6349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469171#comment-17469171
 ] 

Neil C Smith edited comment on NETBEANS-6349 at 1/5/22, 10:22 AM:
--

{quote}I didn't check for 12.5 explicitly, I simply concluded that from the 
linked NETBEANS-6064{quote}

OK, that's an interesting one, because it does seem to imply 12.5, but our 12.5 
binaries were built on JDK 8.

{quote}From a personal as well a resources point of view I simply would wait 
that out until 13.0 becomes available, which would remedy problem as described 
in the workaround section.{quote}

That doesn't change anything. The workaround will be identical, except that 
we'll be more explicit that the IDE doesn't support JDK 8.  That module still 
has to support JDK 8 for now.

{quote}But it might indeed be sensible to spawn a discussion on dev, on whether 
and how to proof our builds with respect to cross JDK compilation.{quote}

It would, because that is meant to have happened already. Everything should be 
being built with release 8 for a start.


was (Author: neilcsmith):
bq. I didn't check for 12.5 explicitly, I simply concluded that from the linked 
NETBEANS-6064

OK, that's an interesting one, because it does seem to imply 12.5, but our 12.5 
binaries were built on JDK 8.

bq. From a personal as well a resources point of view I simply would wait that 
out until 13.0 becomes available, which would remedy problem as described in 
the workaround section.

That doesn't change anything. The workaround will be identical, except that 
we'll be more explicit that the IDE doesn't support JDK 8.  That module still 
has to support JDK 8 for now.

bq. But it might indeed be sensible to spawn a discussion on dev, on whether 
and how to proof our builds with respect to cross JDK compilation.

It would, because that is meant to have happened already. Everything should be 
being built with release 8 for a start.

> Recent builds of the module responsible for java source parsing break BC to 
> JDK 8
> -
>
> Key: NETBEANS-6349
> URL: https://issues.apache.org/jira/browse/NETBEANS-6349
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Parsing  Indexing
>Affects Versions: 12.5, 12.6
>Reporter: Thomas Schapitz
>Priority: Critical
>
> There are 6 linked Issues, that all follow a common pattern, pointing to a 
> common cause:
>  * They are accompanied by an java.lang.NoSuchMethodError: 
> java.nio.CharBuffer.flip()Ljava/nio/CharBuffer;
>  * The users indicate, they are running NB 12.5+ with JDK8
>  * The errors occur during parsing.
> Sure enough, JDK 8 hasn't 
> java.nio.CharBuffer.flip()Ljava/nio/{*}+CharBuffer+{*},
> it has only java.nio.CharBuffer.flip()Ljava/nio/{+}*Buffer,*{+} which it 
> inherits from Buffer.
> Which means: the Module in question has obviously been compiled against a 
> library more recent then JDK8, at least JDK9, which has this method.
>  
> Consequences:
> This and the 6 linked issues will automatically be fixed with the rollout of 
> NB 13, which will require JDK 11 as prerequisite anyway.
> In the mean time, users may work around the problem, by immediately switching 
> to JDK 9+ when executing Netbeans. Note that they should still be able to 
> develop and build for JDKs 8 an prior.  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-6349) Recent builds of the module responsible for java source parsing break BC to JDK 8

2022-01-04 Thread Thomas Schapitz (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-6349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468907#comment-17468907
 ] 

Thomas Schapitz edited comment on NETBEANS-6349 at 1/4/22, 10:58 PM:
-

I didn't check for 12.5 explicitly, I simply concluded that from the linked 
NETBEANS-6064, which was stated to have occurred on 12.5. That said, and as 
I've mentioned on the DEV list, I'm currently trying to be of some help, by 
working my path through the open issues. In the process, I found the 7 linked 
Issues, that are all connected by the cause explained here.

>From a personal as well a resources point of view I simply would wait that out 
>until 13.0 becomes available, which would remedy problem as described in the 
>workaround section.

But it might indeed be sensible to spawn a discussion on dev, on whether and 
how to proof our builds with respect to cross JDK compilation. The problem we 
look at here is, that this sort of build compromises the compilers guarantees 
for static link checking, namely, that the statically compiled code will 
execute without causing NoSuchMethodErrors, or similar. Problems like this are 
always likely to slip through, when using an earlier JDK during execution, then 
where used during compile and test. This might happen too when using a later 
JDK, but is much less likely then.

Personally, I'm not affected by this, because I usually try to switch as early 
as possible, especially within the IDE. Having been prompted by these issues to 
look into the prerequisites, I was indeed surprised, that JDK 8 is still deemed 
sufficient there, else I would have closed those Issues as 'invalid' outright. 
So yet another way to fix this, would be to retrofit the release notes for NB 
12.5+. This again, would be something for the dev list to discuss.

At the very least, this issue may now serve as an temporary anchor for all 
similar ones, that might still hide in the issues not yet reviewed.


was (Author: taps):
I didn't check for 12.5 explicitly, I simply concluded that from the linked 
NETBEANS-6064, which was stated to have occurred on 12.5. That said, and as 
I've mentioned on the DEV list, I'm currently trying to be of some help, by 
working my path through the open issues. In the process, I found the 7 linked 
Issues, that are all connected by the cause explained here.

>From a personal as well a resources point of view I simply would wait that out 
>until 13.0 becomes available, which would remedy problem as described in the 
>workaround section.

But it might indeed be sensible to spawn a discussion on dev, on whether an how 
to proof our builds with respect to cross JDK compilation. The problem we look 
at here is, that this sort of build throwing out the compilers guarantees for 
static link checking, namely, that the statically compiled code will execute 
without causing NoSuchMethodErrors, or similar. Problems like this are always 
likely to slip through, when using an earlier JDK during execution, then where 
used during compile and test.

Personally, I'm not affected by this, because I usually try to switch as early 
as possible, especially within the IDE. Having been prompted by these issues to 
look into the prerequisites, I was indeed surprised, that JDK 8 is still deemed 
sufficient there, else I would have closed those Issues as 'invalid' outright. 
So yet another way to fix this, would be to retrofit the release notes for NB 
12.5+. This again, would be something for the dev list to discuss.

At the very least, this issue may now serve as an temporary anchor for all 
similar ones, that might still hide in the issues not yet reviewed.

> Recent builds of the module responsible for java source parsing break BC to 
> JDK 8
> -
>
> Key: NETBEANS-6349
> URL: https://issues.apache.org/jira/browse/NETBEANS-6349
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Parsing  Indexing
>Affects Versions: 12.5, 12.6
>Reporter: Thomas Schapitz
>Priority: Critical
>
> There are 6 linked Issues, that all follow a common pattern, pointing to a 
> common cause:
>  * They are accompanied by an java.lang.NoSuchMethodError: 
> java.nio.CharBuffer.flip()Ljava/nio/CharBuffer;
>  * The users indicate, they are running NB 12.5+ with JDK8
>  * The errors occur during parsing.
> Sure enough, JDK 8 hasn't 
> java.nio.CharBuffer.flip()Ljava/nio/{*}+CharBuffer+{*},
> it has only java.nio.CharBuffer.flip()Ljava/nio/{+}*Buffer,*{+} which it 
> inherits from Buffer.
> Which means: the Module in question has obviously been compiled against a 
> library more recent then JDK8, at least JDK9, which has this method.
>  
> Consequences:
> This and the 6 linked issues will automatically be fixed with the rollout of 
> NB 

[jira] [Comment Edited] (NETBEANS-6349) Recent builds of the module responsible for java source parsing break BC to JDK 8

2022-01-04 Thread Neil C Smith (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-6349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468801#comment-17468801
 ] 

Neil C Smith edited comment on NETBEANS-6349 at 1/4/22, 7:29 PM:
-

Are you sure this affects 12.5? We switched the convenience binary builds to 
JDK 11 for 12.6 in preparation for NB13. That seems the likely cause. JDK 9+ 
(well 11+ really) has been strongly recommended for the IDE for some time now.  
If you _really_ need to run the IDE on JDK 8, then building the source release 
on JDK 8 should work around this.


was (Author: neilcsmith):
Are you sure this affects 12.5? We switched the convenience binary builds to 
JDK 11 for 12.6 in preparation for NB13. That seems the likely cause. JDK 9+ 
(well 11+ really) has been strongly recommended for the IDE for some time now.  
If you _really_ need to run the IDE on JDK 8, then a building the source 
release on JDK 8 should work around this.

> Recent builds of the module responsible for java source parsing break BC to 
> JDK 8
> -
>
> Key: NETBEANS-6349
> URL: https://issues.apache.org/jira/browse/NETBEANS-6349
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Parsing  Indexing
>Affects Versions: 12.5, 12.6
>Reporter: Thomas Schapitz
>Priority: Critical
>
> There are 6 linked Issues, that all follow a common pattern, pointing to a 
> common cause:
>  * They are accompanied by an java.lang.NoSuchMethodError: 
> java.nio.CharBuffer.flip()Ljava/nio/CharBuffer;
>  * The users indicate, they are running NB 12.5+ with JDK8
>  * The errors occur during parsing.
> Sure enough, JDK 8 hasn't 
> java.nio.CharBuffer.flip()Ljava/nio/{*}+CharBuffer+{*},
> it has only java.nio.CharBuffer.flip()Ljava/nio/{+}*Buffer,*{+} which it 
> inherits from Buffer.
> Which means: the Module in question has obviously been compiled against a 
> library more recent then JDK8, at least JDK9, which has this method.
>  
> Consequences:
> This and the 6 linked issues will automatically be fixed with the rollout of 
> NB 13, which will require JDK 11 as prerequisite anyway.
> In the mean time, users may work around the problem, by immediately switching 
> to JDK 9+ when executing Netbeans. Note that they should still be able to 
> develop and build for JDKs 8 an prior.  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists