[jira] [Comment Edited] (NETBEANSINFRA-187) nbmBuildDir conflict between targets nbm and cluster because of wrong usage
[ https://issues.apache.org/jira/browse/NETBEANSINFRA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092651#comment-17092651 ] Jean-Marc Borer edited comment on NETBEANSINFRA-187 at 4/26/20, 10:40 AM: -- Hi. I have cloned the code and am working on fix. It is almost ready, but I'll do a PR when it is completely finished. was (Author: jmborer): Hi. I have cloned the code and am working on fix. It is almost ready, but I'll do a PR when it is completely finished. > nbmBuildDir conflict between targets nbm and cluster because of wrong usage > --- > > Key: NETBEANSINFRA-187 > URL: https://issues.apache.org/jira/browse/NETBEANSINFRA-187 > Project: Apache NetBeans Infra > Issue Type: Bug > Components: MU - Apache NetBeans NBM maven plugin >Reporter: Jean-Marc Borer >Priority: Major > > The nbmBuildIDir parameter is used both in nbm and cluster targets. However > the meaning in those two contexts are different: > 1) nbm: output directory where the NBMs will be created from the Jars and > other meta data > 2) cluster: directory where to copy the NBMS to from the hardcoded > $(based}/nbm/netbeans > This is usually not a problem as long a you work with netbeans, but it > becomes if you want to use the targets with other projects such as VisualVM. > By looking at the code, this seems more a like bug. What the cluster target > should actually do is look for the NBMs, not in the hard coded location, but > in the one provided by nbmBuildDir and use clusterBuildDir instead to define > the target cluster location build. This very same parameter will be reused by > the run-ide target. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANSINFRA-187) nbmBuildDir conflict between targets nbm and cluster because of wrong usage
[ https://issues.apache.org/jira/browse/NETBEANSINFRA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092651#comment-17092651 ] Jean-Marc Borer edited comment on NETBEANSINFRA-187 at 4/26/20, 10:41 AM: -- Hi. I have cloned the code and am working on fix. It is almost ready, but I'll do a PR when it is completely finished. FYI, I am a Netbeans PMC. You can assign this issue to me, if you'd like. Best regards, JM was (Author: jmborer): Hi. I have cloned the code and am working on fix. It is almost ready, but I'll do a PR when it is completely finished. > nbmBuildDir conflict between targets nbm and cluster because of wrong usage > --- > > Key: NETBEANSINFRA-187 > URL: https://issues.apache.org/jira/browse/NETBEANSINFRA-187 > Project: Apache NetBeans Infra > Issue Type: Bug > Components: MU - Apache NetBeans NBM maven plugin >Reporter: Jean-Marc Borer >Priority: Major > > The nbmBuildIDir parameter is used both in nbm and cluster targets. However > the meaning in those two contexts are different: > 1) nbm: output directory where the NBMs will be created from the Jars and > other meta data > 2) cluster: directory where to copy the NBMS to from the hardcoded > $(based}/nbm/netbeans > This is usually not a problem as long a you work with netbeans, but it > becomes if you want to use the targets with other projects such as VisualVM. > By looking at the code, this seems more a like bug. What the cluster target > should actually do is look for the NBMs, not in the hard coded location, but > in the one provided by nbmBuildDir and use clusterBuildDir instead to define > the target cluster location build. This very same parameter will be reused by > the run-ide target. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANSINFRA-187) nbmBuildDir conflict between targets nbm and cluster because of wrong usage
[ https://issues.apache.org/jira/browse/NETBEANSINFRA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092651#comment-17092651 ] Jean-Marc Borer edited comment on NETBEANSINFRA-187 at 4/26/20, 12:08 PM: -- Hi. I have cloned the code and am working on a fix. It is almost ready, but I'll do a PR when it is completely finished. FYI, I am a Netbeans PMC. You can assign this issue to me, if you'd like. Best regards, JM was (Author: jmborer): Hi. I have cloned the code and am working on fix. It is almost ready, but I'll do a PR when it is completely finished. FYI, I am a Netbeans PMC. You can assign this issue to me, if you'd like. Best regards, JM > nbmBuildDir conflict between targets nbm and cluster because of wrong usage > --- > > Key: NETBEANSINFRA-187 > URL: https://issues.apache.org/jira/browse/NETBEANSINFRA-187 > Project: Apache NetBeans Infra > Issue Type: Bug > Components: MU - Apache NetBeans NBM maven plugin >Reporter: Jean-Marc Borer >Priority: Major > > The nbmBuildIDir parameter is used both in nbm and cluster targets. However > the meaning in those two contexts are different: > 1) nbm: output directory where the NBMs will be created from the Jars and > other meta data > 2) cluster: directory where to copy the NBMS to from the hardcoded > $(based}/nbm/netbeans > This is usually not a problem as long a you work with netbeans, but it > becomes if you want to use the targets with other projects such as VisualVM. > By looking at the code, this seems more a like bug. What the cluster target > should actually do is look for the NBMs, not in the hard coded location, but > in the one provided by nbmBuildDir and use clusterBuildDir instead to define > the target cluster location build. This very same parameter will be reused by > the run-ide target. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
