[jira] [Commented] (NETBEANS-3727) Probably a darker color of the desktop background would be good for FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061274#comment-17061274 ] Eirik Bakke commented on NETBEANS-3727: --- Looks good to me, too! > Probably a darker color of the desktop background would be good for FlatLaf > --- > > Key: NETBEANS-3727 > URL: https://issues.apache.org/jira/browse/NETBEANS-3727 > Project: NetBeans > Issue Type: Improvement >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Minor > Labels: pull-request-available > Fix For: 11.3 > > Attachments: image-2020-01-21-16-30-56-282.png, > image-2020-01-23-11-58-16-141.png, image-2020-02-04-19-25-05-570.png, > image-2020-02-04-19-27-10-325.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > Well, I'm not entirely convinced that this is an issue at all. > Those rare times when we do not have an editor window open, the IDE might > look strange not having upper/left/right border on the opened tabs. I'd not > put border there, but probably mark the desktop color different (like the > editor default background on FlatLafDark). > [~ebakke] [~DevCharly] what do you think. Of course you are free to drop this > one. > !image-2020-01-21-16-30-56-282.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3727) Probably a darker color of the desktop background would be good for FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030073#comment-17030073 ] Laszlo Kishalmi commented on NETBEANS-3727: --- I like it! I'm really curious of the PR! > Probably a darker color of the desktop background would be good for FlatLaf > --- > > Key: NETBEANS-3727 > URL: https://issues.apache.org/jira/browse/NETBEANS-3727 > Project: NetBeans > Issue Type: Improvement >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Minor > Attachments: image-2020-01-21-16-30-56-282.png, > image-2020-01-23-11-58-16-141.png, image-2020-02-04-19-25-05-570.png, > image-2020-02-04-19-27-10-325.png > > > Well, I'm not entirely convinced that this is an issue at all. > Those rare times when we do not have an editor window open, the IDE might > look strange not having upper/left/right border on the opened tabs. I'd not > put border there, but probably mark the desktop color different (like the > editor default background on FlatLafDark). > [~ebakke] [~DevCharly] what do you think. Of course you are free to drop this > one. > !image-2020-01-21-16-30-56-282.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3727) Probably a darker color of the desktop background would be good for FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030045#comment-17030045 ] Karl Tauber commented on NETBEANS-3727: --- Here is a screenshot with background same as menubar background. LGTM. !image-2020-02-04-19-25-05-570.png! FlatLaf Light with darker background: !image-2020-02-04-19-27-10-325.png! What do you think? > Probably a darker color of the desktop background would be good for FlatLaf > --- > > Key: NETBEANS-3727 > URL: https://issues.apache.org/jira/browse/NETBEANS-3727 > Project: NetBeans > Issue Type: Improvement >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Minor > Attachments: image-2020-01-21-16-30-56-282.png, > image-2020-01-23-11-58-16-141.png, image-2020-02-04-19-25-05-570.png, > image-2020-02-04-19-27-10-325.png > > > Well, I'm not entirely convinced that this is an issue at all. > Those rare times when we do not have an editor window open, the IDE might > look strange not having upper/left/right border on the opened tabs. I'd not > put border there, but probably mark the desktop color different (like the > editor default background on FlatLafDark). > [~ebakke] [~DevCharly] what do you think. Of course you are free to drop this > one. > !image-2020-01-21-16-30-56-282.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3727) Probably a darker color of the desktop background would be good for FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027884#comment-17027884 ] Laszlo Kishalmi commented on NETBEANS-3727: --- Initially I though it would be just setting the "Nb.Desktop.background" property, so I did that, with no visible use. I've checked the code and it seems that property is not even supported any more... > Probably a darker color of the desktop background would be good for FlatLaf > --- > > Key: NETBEANS-3727 > URL: https://issues.apache.org/jira/browse/NETBEANS-3727 > Project: NetBeans > Issue Type: Improvement >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Minor > Attachments: image-2020-01-21-16-30-56-282.png, > image-2020-01-23-11-58-16-141.png > > > Well, I'm not entirely convinced that this is an issue at all. > Those rare times when we do not have an editor window open, the IDE might > look strange not having upper/left/right border on the opened tabs. I'd not > put border there, but probably mark the desktop color different (like the > editor default background on FlatLafDark). > [~ebakke] [~DevCharly] what do you think. Of course you are free to drop this > one. > !image-2020-01-21-16-30-56-282.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3727) Probably a darker color of the desktop background would be good for FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027849#comment-17027849 ] Laszlo Kishalmi commented on NETBEANS-3727: --- As of me, I like the "black hole", what about to have the background same as menu background? > Probably a darker color of the desktop background would be good for FlatLaf > --- > > Key: NETBEANS-3727 > URL: https://issues.apache.org/jira/browse/NETBEANS-3727 > Project: NetBeans > Issue Type: Improvement >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Minor > Attachments: image-2020-01-21-16-30-56-282.png, > image-2020-01-23-11-58-16-141.png > > > Well, I'm not entirely convinced that this is an issue at all. > Those rare times when we do not have an editor window open, the IDE might > look strange not having upper/left/right border on the opened tabs. I'd not > put border there, but probably mark the desktop color different (like the > editor default background on FlatLafDark). > [~ebakke] [~DevCharly] what do you think. Of course you are free to drop this > one. > !image-2020-01-21-16-30-56-282.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3727) Probably a darker color of the desktop background would be good for FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025177#comment-17025177 ] Eirik Bakke commented on NETBEANS-3727: --- I think it would be good to make the background color a bit darker, yes. I think the "black hole" screenshot looks good... but if you think it's too intense, we could use a brightness somewhere in between. > Probably a darker color of the desktop background would be good for FlatLaf > --- > > Key: NETBEANS-3727 > URL: https://issues.apache.org/jira/browse/NETBEANS-3727 > Project: NetBeans > Issue Type: Improvement >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Minor > Attachments: image-2020-01-21-16-30-56-282.png, > image-2020-01-23-11-58-16-141.png > > > Well, I'm not entirely convinced that this is an issue at all. > Those rare times when we do not have an editor window open, the IDE might > look strange not having upper/left/right border on the opened tabs. I'd not > put border there, but probably mark the desktop color different (like the > editor default background on FlatLafDark). > [~ebakke] [~DevCharly] what do you think. Of course you are free to drop this > one. > !image-2020-01-21-16-30-56-282.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-3727) Probably a darker color of the desktop background would be good for FlatLaf
[ https://issues.apache.org/jira/browse/NETBEANS-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021969#comment-17021969 ] Karl Tauber commented on NETBEANS-3727: --- I've modified your screenshot using editor background. Looks not that good IMHO. Like a "black hole". Better leave it as it is. !image-2020-01-23-11-58-16-141.png! > Probably a darker color of the desktop background would be good for FlatLaf > --- > > Key: NETBEANS-3727 > URL: https://issues.apache.org/jira/browse/NETBEANS-3727 > Project: NetBeans > Issue Type: Improvement >Reporter: Laszlo Kishalmi >Assignee: Karl Tauber >Priority: Minor > Attachments: image-2020-01-21-16-30-56-282.png, > image-2020-01-23-11-58-16-141.png > > > Well, I'm not entirely convinced that this is an issue at all. > Those rare times when we do not have an editor window open, the IDE might > look strange not having upper/left/right border on the opened tabs. I'd not > put border there, but probably mark the desktop color different (like the > editor default background on FlatLafDark). > [~ebakke] [~DevCharly] what do you think. Of course you are free to drop this > one. > !image-2020-01-21-16-30-56-282.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
