[jira] [Commented] (NETBEANS-5608) Comments in JSON

2021-04-22 Thread Christian Lenz (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327152#comment-17327152
 ] 

Christian Lenz commented on NETBEANS-5608:
--

Yes, they are treated differently. Maybe the comments is only allowed for plain 
text/x-json but the package.json file and also package-lock have a mixed 
mimeType which is text/package+x-json. It is first for the different icon, yes 
and second for later maybe code completion for package.json specific stuff. So 
I can check whether the comments are just allowed for text/x-json. Will have a 
look later.

> Comments in JSON
> 
>
> Key: NETBEANS-5608
> URL: https://issues.apache.org/jira/browse/NETBEANS-5608
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Ghader Arkani
>Priority: Minor
>
> Since JSON files may be used for configuration. It's a good idea that we 
> could add comments in those files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-5608) Comments in JSON

2021-04-21 Thread Ghader Arkani (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327044#comment-17327044
 ] 

Ghader Arkani commented on NETBEANS-5608:
-

Weird! you are right, it's working in tsconfig.json and I have created a 
test.json and it worked too. 
It appears it only doesn't work in package.json. Package.json and 
package-lock.json have different icon from other JSON files maybe they're 
treated differently.
In cases where they work, I should add // manually, keyboard shortcut doesn't 
work.

> Comments in JSON
> 
>
> Key: NETBEANS-5608
> URL: https://issues.apache.org/jira/browse/NETBEANS-5608
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Ghader Arkani
>Priority: Minor
>
> Since JSON files may be used for configuration. It's a good idea that we 
> could add comments in those files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-5608) Comments in JSON

2021-04-21 Thread Christian Lenz (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326679#comment-17326679
 ] 

Christian Lenz commented on NETBEANS-5608:
--

In which file did you try this? It is not working in my package.json file but 
in a tsconfig.json file.

> Comments in JSON
> 
>
> Key: NETBEANS-5608
> URL: https://issues.apache.org/jira/browse/NETBEANS-5608
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Ghader Arkani
>Priority: Minor
>
> Since JSON files may be used for configuration. It's a good idea that we 
> could add comments in those files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-5608) Comments in JSON

2021-04-21 Thread Ghader Arkani (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326374#comment-17326374
 ] 

Ghader Arkani commented on NETBEANS-5608:
-

I go to project properties, javascript section and check the "Allow comments in 
JSON files" checkbox then return to my JSON file try to add some comments with 
Ctrl + / or manually add // to the file but red line appears under // and it 
doesn't allow comments.

> Comments in JSON
> 
>
> Key: NETBEANS-5608
> URL: https://issues.apache.org/jira/browse/NETBEANS-5608
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Ghader Arkani
>Priority: Minor
>
> Since JSON files may be used for configuration. It's a good idea that we 
> could add comments in those files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-5608) Comments in JSON

2021-04-21 Thread Christian Lenz (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326366#comment-17326366
 ] 

Christian Lenz commented on NETBEANS-5608:
--

What exactly doesn't work? DO you see errors, what is not working?

> Comments in JSON
> 
>
> Key: NETBEANS-5608
> URL: https://issues.apache.org/jira/browse/NETBEANS-5608
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Ghader Arkani
>Priority: Minor
>
> Since JSON files may be used for configuration. It's a good idea that we 
> could add comments in those files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-5608) Comments in JSON

2021-04-21 Thread Ghader Arkani (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326363#comment-17326363
 ] 

Ghader Arkani commented on NETBEANS-5608:
-

Hi Christian,
Thank you for your help. I fond it, but it doesn't work.

> Comments in JSON
> 
>
> Key: NETBEANS-5608
> URL: https://issues.apache.org/jira/browse/NETBEANS-5608
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Ghader Arkani
>Priority: Minor
>
> Since JSON files may be used for configuration. It's a good idea that we 
> could add comments in those files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-5608) Comments in JSON

2021-04-21 Thread Christian Lenz (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326331#comment-17326331
 ] 

Christian Lenz commented on NETBEANS-5608:
--

It is already possible in the project configuration

> Comments in JSON
> 
>
> Key: NETBEANS-5608
> URL: https://issues.apache.org/jira/browse/NETBEANS-5608
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Ghader Arkani
>Priority: Minor
>
> Since JSON files may be used for configuration. It's a good idea that we 
> could add comments in those files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-5608) Comments in JSON

2021-04-20 Thread Ghader Arkani (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326166#comment-17326166
 ] 

Ghader Arkani commented on NETBEANS-5608:
-

Yes, but we can do this on other IDEs like VScode.

> Comments in JSON
> 
>
> Key: NETBEANS-5608
> URL: https://issues.apache.org/jira/browse/NETBEANS-5608
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Ghader Arkani
>Priority: Minor
>
> Since JSON files may be used for configuration. It's a good idea that we 
> could add comments in those files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-5608) Comments in JSON

2021-04-20 Thread Jira


[ 
https://issues.apache.org/jira/browse/NETBEANS-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326108#comment-17326108
 ] 

Tomáš Procházka commented on NETBEANS-5608:
---

Unfortunately JSON files don't support comments.

> Comments in JSON
> 
>
> Key: NETBEANS-5608
> URL: https://issues.apache.org/jira/browse/NETBEANS-5608
> Project: NetBeans
>  Issue Type: Improvement
>Reporter: Ghader Arkani
>Priority: Minor
>
> Since JSON files may be used for configuration. It's a good idea that we 
> could add comments in those files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists