[jira] [Commented] (MINIFI-282) Fix build issue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989511#comment-15989511
 ] 

ASF GitHub Bot commented on MINIFI-282:
---

GitHub user phrocker opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/86

MINIFI-282: Move Socket tests and remove includes

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-282

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #86


commit 28bb5b36d6866d29da658f25e7545a9c05b4577e
Author: Marc 
Date:   2017-04-28T21:56:38Z

MINIFI-282: Move Socket tests and remove includes




> Fix build issue
> ---
>
> Key: MINIFI-282
> URL: https://issues.apache.org/jira/browse/MINIFI-282
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>  Components: C++
>Reporter: marco polo
>Assignee: marco polo
>Priority: Blocker
> Fix For: cpp-0.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-275) Configuration without IDs for components causes exceptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989507#comment-15989507
 ] 

ASF GitHub Bot commented on MINIFI-275:
---

GitHub user kevdoran opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/85

MINIFI-275 Bugfix for YAML Configs without Component IDs

This commit fixes a bug in which loading config YAML that did not
specify IDs (UUIDs) for components caused an exception. The logic
previously treated component IDs as required fields by loading them
without checking for existence. This commit updates the logic to
generate IDs when they are not specified in the YAML config. As part
of this fix, the logic for loading connections from YAML config was
modified to search by name or remote port id in the absence of source
id or remote id in the YAML config.

For fields that are required, useful error messages were added when
those fields are missing to assist users in self-diagnosing issues
related to invalid config files.

Some minor tweaks to the top level .gitignore are included with this
commit.

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kevdoran/nifi-minifi-cpp 
bugfix/MINIFI-275-configs-without-component-ids

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #85


commit eb7b992872a71b8c01444ef24eeae48121559a5e
Author: Kevin Doran 
Date:   2017-04-28T21:43:37Z

MINIFI-275 Bugfix for YAML Configs without Component IDs

This commit fixes a bug in which loading config YAML that did not
specify IDs (UUIDs) for components caused an exception. The logic
previously treated component IDs as required fields by loading them
without checking for existence. This commit updates the logic to
generate IDs when they are not specified in the YAML config. As part
of this fix, the logic for loading connections from YAML config was
modified to search by name or remote port id in the absence of source
id or remote id in the YAML config.

For fields that are required, useful error messages were added when
those fields are missing to assist users in self-diagnosing issues
related to invalid config files.

Some minor tweaks to the top level .gitignore are included with this
commit.




> Configuration without IDs for components causes exceptions
> --
>
> Key: MINIFI-275
> URL: https://issues.apache.org/jira/browse/MINIFI-275
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>  Components: C++, Processing Configuration
>Reporter: Aldrin Piri
>Assignee: Kevin Doran
>Priority: Blocker
> Fix For: cpp-0.2.0
>
> Attachments: config.yml
>
>
> One of the changes to how components are handled in C++ introduced a defect 
> into the original construct over the version 1 schema of the YAML.  
> The absence of this ID causes a YAML exception.  
> We should provide handling to support configurations how they were created 
> originally, possibly providing a default/generated ID where one isn't 
> specified, and start laying the foundation for versioned schemas as provided 
> 

[jira] [Created] (MINIFI-282) Fix build issue

[marco polo (JIRA)]

marco polo created MINIFI-282:
-

 Summary: Fix build issue
 Key: MINIFI-282
 URL: https://issues.apache.org/jira/browse/MINIFI-282
 Project: Apache NiFi MiNiFi
  Issue Type: Bug
  Components: C++
Reporter: marco polo
Assignee: marco polo
Priority: Blocker
 Fix For: cpp-0.2.0






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-274) Build failures in Debian based environments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989386#comment-15989386
 ] 

ASF GitHub Bot commented on MINIFI-274:
---

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/84
  
@brosander Okay, rebased on latest master and have pushed to update.  
Thanks for scoping out.


> Build failures in Debian based environments
> ---
>
> Key: MINIFI-274
> URL: https://issues.apache.org/jira/browse/MINIFI-274
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>  Components: Build, C++
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
> Fix For: cpp-0.2.0
>
>
> As seen on Travis and replicated locally in Ubuntu 16.04 there are issues 
> with building in Debian based environments.  These are not seen in RHEL based 
> distributions.
> This was caused by commit 
> https://github.com/apache/nifi-minifi-cpp/commit/f3f8f5319037f56b267927e2e43ca9bee8040505
> The associated job log on Travis is 
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/223274984/log.txt
> The error locally is as follows:
> {code}
> lto1: all warnings being treated as errors
> lto-wrapper: fatal error: /usr/bin/cc returned 1 exit status
> compilation terminated.
> /usr/bin/ld: error: lto-wrapper failed
> collect2: error: ld returned 1 exit status
> thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/build.make:96: 
> recipe for target 'thirdparty/civetweb-1.9.1/src/civetweb' failed
> make[2]: *** [thirdparty/civetweb-1.9.1/src/civetweb] Error 1
> CMakeFiles/Makefile2:722: recipe for target 
> 'thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/all' failed
> make[1]: *** 
> [thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/all]Error 2
> Makefile:160: recipe for target 'all' failed
> make: *** [all] Error 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-273) make docs sometimes doesn't work and fails travis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989370#comment-15989370
 ] 

ASF GitHub Bot commented on MINIFI-273:
---

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/82


> make docs sometimes doesn't work and fails travis
> -
>
> Key: MINIFI-273
> URL: https://issues.apache.org/jira/browse/MINIFI-273
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
> Fix For: cpp-0.2.0
>
>
> FindDoxygen doesn't always correctly identify that the doxygen path is 
> non-existent. In these cases, we will check if the executable exists and 
> print an error message indicating that Doxygen needs to be installed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

nifi-minifi-cpp git commit: MINIFI-273 Update README to include doxygen dependencies for build.

[brosander]

Repository: nifi-minifi-cpp
Updated Branches:
  refs/heads/master 41a5e62d8 -> ab3cf9770


MINIFI-273 Update README to include doxygen dependencies for build.

This closes #82.

Signed-off-by: Bryan Rosander 


Project: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/commit/ab3cf977
Tree: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/tree/ab3cf977
Diff: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/diff/ab3cf977

Branch: refs/heads/master
Commit: ab3cf977001293c8779d229ce9f9f2d09fd410ad
Parents: 41a5e62
Author: Aldrin Piri 
Authored: Tue Apr 25 13:28:13 2017 -0400
Committer: Bryan Rosander 
Committed: Fri Apr 28 15:55:05 2017 -0400

--
 README.md | 11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/blob/ab3cf977/README.md
--
diff --git a/README.md b/README.md
index 2a83a9a..7baefbc 100644
--- a/README.md
+++ b/README.md
@@ -93,7 +93,9 @@ $ yum install cmake \
   libcurl-devel \
   leveldb-devel leveldb \
   libuuid libuuid-devel \
-  boost-devel \ libssl-dev
+  boost-devel \
+  libssl-dev \
+  doxygen
 ```
 
 Aptitude based Linux Distributions
@@ -104,7 +106,8 @@ $ apt-get install cmake \
   libcurl-dev \
   libleveldb-dev libleveldb1v5 \
   uuid-dev uuid \
-  libboost-all-dev libssl-dev
+  libboost-all-dev libssl-dev \
+  doxygen
 ```
 
 OS X Using Homebrew (with XCode Command Line Tools installed)
@@ -114,7 +117,9 @@ $ brew install cmake \
   curl \
   leveldb \
   ossp-uuid \
-  boost \ openssl
+  boost \
+  openssl \
+  doxygen
 ```
 
 

[jira] [Commented] (MINIFI-273) make docs sometimes doesn't work and fails travis

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989368#comment-15989368
 ] 

ASF subversion and git services commented on MINIFI-273:


Commit ab3cf977001293c8779d229ce9f9f2d09fd410ad in nifi-minifi-cpp's branch 
refs/heads/master from [~aldrin]
[ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=ab3cf97 ]

MINIFI-273 Update README to include doxygen dependencies for build.

This closes #82.

Signed-off-by: Bryan Rosander 


> make docs sometimes doesn't work and fails travis
> -
>
> Key: MINIFI-273
> URL: https://issues.apache.org/jira/browse/MINIFI-273
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
> Fix For: cpp-0.2.0
>
>
> FindDoxygen doesn't always correctly identify that the doxygen path is 
> non-existent. In these cases, we will check if the executable exists and 
> print an error message indicating that Doxygen needs to be installed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-274) Build failures in Debian based environments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989362#comment-15989362
 ] 

ASF GitHub Bot commented on MINIFI-274:
---

Github user brosander commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/84
  
+1 merging


> Build failures in Debian based environments
> ---
>
> Key: MINIFI-274
> URL: https://issues.apache.org/jira/browse/MINIFI-274
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>  Components: Build, C++
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
> Fix For: cpp-0.2.0
>
>
> As seen on Travis and replicated locally in Ubuntu 16.04 there are issues 
> with building in Debian based environments.  These are not seen in RHEL based 
> distributions.
> This was caused by commit 
> https://github.com/apache/nifi-minifi-cpp/commit/f3f8f5319037f56b267927e2e43ca9bee8040505
> The associated job log on Travis is 
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/223274984/log.txt
> The error locally is as follows:
> {code}
> lto1: all warnings being treated as errors
> lto-wrapper: fatal error: /usr/bin/cc returned 1 exit status
> compilation terminated.
> /usr/bin/ld: error: lto-wrapper failed
> collect2: error: ld returned 1 exit status
> thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/build.make:96: 
> recipe for target 'thirdparty/civetweb-1.9.1/src/civetweb' failed
> make[2]: *** [thirdparty/civetweb-1.9.1/src/civetweb] Error 1
> CMakeFiles/Makefile2:722: recipe for target 
> 'thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/all' failed
> make[1]: *** 
> [thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/all]Error 2
> Makefile:160: recipe for target 'all' failed
> make: *** [all] Error 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-274) Build failures in Debian based environments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989360#comment-15989360
 ] 

ASF GitHub Bot commented on MINIFI-274:
---

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/84
  
@brosander just noticed there was a merge conflict from one of the prior 
merges I performed.  will fix up quickly.


> Build failures in Debian based environments
> ---
>
> Key: MINIFI-274
> URL: https://issues.apache.org/jira/browse/MINIFI-274
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>  Components: Build, C++
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
> Fix For: cpp-0.2.0
>
>
> As seen on Travis and replicated locally in Ubuntu 16.04 there are issues 
> with building in Debian based environments.  These are not seen in RHEL based 
> distributions.
> This was caused by commit 
> https://github.com/apache/nifi-minifi-cpp/commit/f3f8f5319037f56b267927e2e43ca9bee8040505
> The associated job log on Travis is 
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/223274984/log.txt
> The error locally is as follows:
> {code}
> lto1: all warnings being treated as errors
> lto-wrapper: fatal error: /usr/bin/cc returned 1 exit status
> compilation terminated.
> /usr/bin/ld: error: lto-wrapper failed
> collect2: error: ld returned 1 exit status
> thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/build.make:96: 
> recipe for target 'thirdparty/civetweb-1.9.1/src/civetweb' failed
> make[2]: *** [thirdparty/civetweb-1.9.1/src/civetweb] Error 1
> CMakeFiles/Makefile2:722: recipe for target 
> 'thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/all' failed
> make[1]: *** 
> [thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/all]Error 2
> Makefile:160: recipe for target 'all' failed
> make: *** [all] Error 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-273) make docs sometimes doesn't work and fails travis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989357#comment-15989357
 ] 

ASF GitHub Bot commented on MINIFI-273:
---

Github user benqiu2016 commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/82
  
+1


> make docs sometimes doesn't work and fails travis
> -
>
> Key: MINIFI-273
> URL: https://issues.apache.org/jira/browse/MINIFI-273
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
> Fix For: cpp-0.2.0
>
>
> FindDoxygen doesn't always correctly identify that the doxygen path is 
> non-existent. In these cases, we will check if the executable exists and 
> print an error message indicating that Doxygen needs to be installed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-274) Build failures in Debian based environments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989355#comment-15989355
 ] 

ASF GitHub Bot commented on MINIFI-274:
---

Github user brosander commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/84
  
Reviewing


> Build failures in Debian based environments
> ---
>
> Key: MINIFI-274
> URL: https://issues.apache.org/jira/browse/MINIFI-274
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>  Components: Build, C++
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
> Fix For: cpp-0.2.0
>
>
> As seen on Travis and replicated locally in Ubuntu 16.04 there are issues 
> with building in Debian based environments.  These are not seen in RHEL based 
> distributions.
> This was caused by commit 
> https://github.com/apache/nifi-minifi-cpp/commit/f3f8f5319037f56b267927e2e43ca9bee8040505
> The associated job log on Travis is 
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/223274984/log.txt
> The error locally is as follows:
> {code}
> lto1: all warnings being treated as errors
> lto-wrapper: fatal error: /usr/bin/cc returned 1 exit status
> compilation terminated.
> /usr/bin/ld: error: lto-wrapper failed
> collect2: error: ld returned 1 exit status
> thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/build.make:96: 
> recipe for target 'thirdparty/civetweb-1.9.1/src/civetweb' failed
> make[2]: *** [thirdparty/civetweb-1.9.1/src/civetweb] Error 1
> CMakeFiles/Makefile2:722: recipe for target 
> 'thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/all' failed
> make[1]: *** 
> [thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/all]Error 2
> Makefile:160: recipe for target 'all' failed
> make: *** [all] Error 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-273) make docs sometimes doesn't work and fails travis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989353#comment-15989353
 ] 

ASF GitHub Bot commented on MINIFI-273:
---

Github user brosander commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/82
  
+1 merging


> make docs sometimes doesn't work and fails travis
> -
>
> Key: MINIFI-273
> URL: https://issues.apache.org/jira/browse/MINIFI-273
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
> Fix For: cpp-0.2.0
>
>
> FindDoxygen doesn't always correctly identify that the doxygen path is 
> non-existent. In these cases, we will check if the executable exists and 
> print an error message indicating that Doxygen needs to be installed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-269) Support Site2Site Server Protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989281#comment-15989281
 ] 

ASF GitHub Bot commented on MINIFI-269:
---

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/81


> Support Site2Site Server Protocol
> -
>
> Key: MINIFI-269
> URL: https://issues.apache.org/jira/browse/MINIFI-269
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: C++
>Affects Versions: cpp-0.1.0
>Reporter: bqiu
>Assignee: bqiu
> Fix For: cpp-0.2.0
>
>
> Support Site2Site Server Protocol
> Now CPP site2Site only support client side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-269) Support Site2Site Server Protocol

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989280#comment-15989280
 ] 

ASF subversion and git services commented on MINIFI-269:


Commit 41a5e62d877d422462a75238e6e5d148890ef2a1 in nifi-minifi-cpp's branch 
refs/heads/master from [~bqiu]
[ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=41a5e62 ]

MINIFI-269: Add Site2Site Test case

This closes #81.

Signed-off-by: Aldrin Piri 


> Support Site2Site Server Protocol
> -
>
> Key: MINIFI-269
> URL: https://issues.apache.org/jira/browse/MINIFI-269
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: C++
>Affects Versions: cpp-0.1.0
>Reporter: bqiu
>Assignee: bqiu
> Fix For: cpp-0.2.0
>
>
> Support Site2Site Server Protocol
> Now CPP site2Site only support client side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

nifi-minifi-cpp git commit: MINIFI-269: Add Site2Site Test case

[aldrin]

Repository: nifi-minifi-cpp
Updated Branches:
  refs/heads/master 071ac1e98 -> 41a5e62d8


MINIFI-269: Add Site2Site Test case

This closes #81.

Signed-off-by: Aldrin Piri 


Project: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/commit/41a5e62d
Tree: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/tree/41a5e62d
Diff: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/diff/41a5e62d

Branch: refs/heads/master
Commit: 41a5e62d877d422462a75238e6e5d148890ef2a1
Parents: 071ac1e
Author: Bin Qiu 
Authored: Mon Apr 24 15:07:25 2017 -0700
Committer: Aldrin Piri 
Committed: Fri Apr 28 14:33:58 2017 -0400

--
 libminifi/src/core/yaml/YamlConfiguration.cpp |   2 +-
 libminifi/test/unit/SerializationTests.cpp|  89 ++---
 libminifi/test/unit/Site2SiteTests.cpp| 202 +
 libminifi/test/unit/SiteToSiteHelper.h| 156 
 4 files changed, 372 insertions(+), 77 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/blob/41a5e62d/libminifi/src/core/yaml/YamlConfiguration.cpp
--
diff --git a/libminifi/src/core/yaml/YamlConfiguration.cpp 
b/libminifi/src/core/yaml/YamlConfiguration.cpp
index d76b9f3..5484e36 100644
--- a/libminifi/src/core/yaml/YamlConfiguration.cpp
+++ b/libminifi/src/core/yaml/YamlConfiguration.cpp
@@ -339,7 +339,7 @@ void YamlConfiguration::parseProvenanceReportingYaml(
 return;
   }
 
-  if (!reportNode || !(reportNode->IsSequence())) {
+  if (!reportNode || !reportNode->IsDefined() || reportNode->IsNull()) {
 logger_->log_debug("no provenance reporting task specified");
 return;
   }

http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/blob/41a5e62d/libminifi/test/unit/SerializationTests.cpp
--
diff --git a/libminifi/test/unit/SerializationTests.cpp 
b/libminifi/test/unit/SerializationTests.cpp
index c6ada33..0841fbd 100644
--- a/libminifi/test/unit/SerializationTests.cpp
+++ b/libminifi/test/unit/SerializationTests.cpp
@@ -16,69 +16,21 @@
  * limitations under the License.
  */
 
-
 #include "io/BaseStream.h"
 #include "Site2SitePeer.h"
 #include "Site2SiteClientProtocol.h"
 #include 
+#include "core/logging/LogAppenders.h"
+#include "core/logging/BaseLogger.h"
+#include "SiteToSiteHelper.h"
 #include 
 #include 
 #include 
 #include "../TestBase.h"
 #define FMT_DEFAULT fmt_lower
 
-
 using namespace org::apache::nifi::minifi::io;
-TEST_CASE("TestSetPortId", "[S2S1]"){
-
-
-   std::unique_ptr peer = 
std::unique_ptr( new 
minifi::Site2SitePeer(std::unique_ptr(new 
DataStream()),"fake_host",65433));
-
-   minifi::Site2SiteClientProtocol protocol(std::move(peer));
-
-
-   std::string uuid_str = "c56a4180-65aa-42ec-a945-5fd21dec0538";
-
-   uuid_t fakeUUID;
-
-   uuid_parse(uuid_str.c_str(),fakeUUID);
-
-   protocol.setPortId(fakeUUID);
-
-   REQUIRE( uuid_str == protocol.getPortId() );
-
-
-
-}
-
-TEST_CASE("TestSetPortIdUppercase", "[S2S2]"){
-
-
-  std::unique_ptr peer = 
std::unique_ptr( new 
minifi::Site2SitePeer(std::unique_ptr(new 
DataStream()),"fake_host",65433));
-
-  minifi::Site2SiteClientProtocol protocol(std::move(peer));
-
-
-   std::string uuid_str = "C56A4180-65AA-42EC-A945-5FD21DEC0538";
-
-   uuid_t fakeUUID;
-
-   uuid_parse(uuid_str.c_str(),fakeUUID);
-
-   protocol.setPortId(fakeUUID);
-
-   REQUIRE( uuid_str != protocol.getPortId() );
-
-   
std::transform(uuid_str.begin(),uuid_str.end(),uuid_str.begin(),::tolower);
-
-   REQUIRE( uuid_str == protocol.getPortId() );
-
-
-
-}
-
-
-TEST_CASE("TestWriteUTF", "[MINIFI193]"){
+TEST_CASE("TestWriteUTF", "[MINIFI193]") {
 
   DataStream baseStream;
 
@@ -86,22 +38,15 @@ TEST_CASE("TestWriteUTF", "[MINIFI193]"){
 
   std::string stringOne = "helo world"; // yes, this has a typo.
   std::string verifyString;
-  ser.writeUTF(stringOne,,false);
-
+  ser.writeUTF(stringOne, , false);
 
-  ser.readUTF(verifyString,,false);
+  ser.readUTF(verifyString, , false);
 
   REQUIRE(verifyString == stringOne);
 
-
-
-
 }
 
-
-
-
-TEST_CASE("TestWriteUTF2", "[MINIFI193]"){
+TEST_CASE("TestWriteUTF2", "[MINIFI193]") {
 
   DataStream baseStream;
 
@@ -110,20 +55,15 @@ TEST_CASE("TestWriteUTF2", "[MINIFI193]"){
   std::string stringOne = "hel\xa1o world";
   REQUIRE(11 == stringOne.length());
   std::string verifyString;
-  ser.writeUTF(stringOne,,false);
-
+  ser.writeUTF(stringOne, , false);
 
-  ser.readUTF(verifyString,,false);
+  ser.readUTF(verifyString, , false);
 
   REQUIRE(verifyString == stringOne);
 
-
-
-
 }
 
-
-TEST_CASE("TestWriteUTF3", "[MINIFI193]"){
+TEST_CASE("TestWriteUTF3", 

[jira] [Updated] (MINIFI-269) Support Site2Site Server Protocol

[Aldrin Piri (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MINIFI-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aldrin Piri updated MINIFI-269:
---
Fix Version/s: cpp-0.2.0

> Support Site2Site Server Protocol
> -
>
> Key: MINIFI-269
> URL: https://issues.apache.org/jira/browse/MINIFI-269
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: C++
>Affects Versions: cpp-0.1.0
>Reporter: bqiu
>Assignee: bqiu
> Fix For: cpp-0.2.0
>
>
> Support Site2Site Server Protocol
> Now CPP site2Site only support client side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-280) Implement ExtractText processor

[Andrew Christianson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989267#comment-15989267
 ] 

Andrew Christianson commented on MINIFI-280:


Dynamic properties are required to map attrs to regexs.

> Implement ExtractText processor
> ---
>
> Key: MINIFI-280
> URL: https://issues.apache.org/jira/browse/MINIFI-280
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: C++, Extensions
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>
> Implement the ExtractText processor as it has clearly utility in simple 
> endpoint flows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-269) Support Site2Site Server Protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989259#comment-15989259
 ] 

ASF GitHub Bot commented on MINIFI-269:
---

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/81
  
@benqiu2016 great, looks good.  will get merged, thanks!


> Support Site2Site Server Protocol
> -
>
> Key: MINIFI-269
> URL: https://issues.apache.org/jira/browse/MINIFI-269
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: C++
>Affects Versions: cpp-0.1.0
>Reporter: bqiu
>Assignee: bqiu
>
> Support Site2Site Server Protocol
> Now CPP site2Site only support client side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-269) Support Site2Site Server Protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989227#comment-15989227
 ] 

ASF GitHub Bot commented on MINIFI-269:
---

Github user benqiu2016 commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/81
  
@apiri fix the provenance report not defined case. Thanks for the review.



> Support Site2Site Server Protocol
> -
>
> Key: MINIFI-269
> URL: https://issues.apache.org/jira/browse/MINIFI-269
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: C++
>Affects Versions: cpp-0.1.0
>Reporter: bqiu
>Assignee: bqiu
>
> Support Site2Site Server Protocol
> Now CPP site2Site only support client side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-269) Support Site2Site Server Protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989145#comment-15989145
 ] 

ASF GitHub Bot commented on MINIFI-269:
---

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/81
  
@benqiu2016 We need to handle those cases where the Provenance Reporting 
node is not provided, otherwise the changes look good.  Thanks!


> Support Site2Site Server Protocol
> -
>
> Key: MINIFI-269
> URL: https://issues.apache.org/jira/browse/MINIFI-269
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: C++
>Affects Versions: cpp-0.1.0
>Reporter: bqiu
>Assignee: bqiu
>
> Support Site2Site Server Protocol
> Now CPP site2Site only support client side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-269) Support Site2Site Server Protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989142#comment-15989142
 ] 

ASF GitHub Bot commented on MINIFI-269:
---

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/81#discussion_r113974309
  
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -339,7 +339,7 @@ void YamlConfiguration::parseProvenanceReportingYaml(
 return;
   }
 
-  if (!reportNode || !(reportNode->IsSequence())) {
--- End diff --

The main case of interest is for those scenarios were Provenance Reporting 
is not desired.  As a result, this will throw an exception for those scenarios 
where provenance reporting is not one of the included yaml components.


> Support Site2Site Server Protocol
> -
>
> Key: MINIFI-269
> URL: https://issues.apache.org/jira/browse/MINIFI-269
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: C++
>Affects Versions: cpp-0.1.0
>Reporter: bqiu
>Assignee: bqiu
>
> Support Site2Site Server Protocol
> Now CPP site2Site only support client side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-269) Support Site2Site Server Protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989128#comment-15989128
 ] 

ASF GitHub Bot commented on MINIFI-269:
---

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/81#discussion_r113971134
  
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -339,7 +339,7 @@ void YamlConfiguration::parseProvenanceReportingYaml(
 return;
   }
 
-  if (!reportNode || !(reportNode->IsSequence())) {
--- End diff --

Sorry, confused this with remote processing groups.  Regardless, another 
check is needed for Node typing.  In this case, we are looking for a map, or 
perhaps, more generically we need to just check for defined 


> Support Site2Site Server Protocol
> -
>
> Key: MINIFI-269
> URL: https://issues.apache.org/jira/browse/MINIFI-269
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: C++
>Affects Versions: cpp-0.1.0
>Reporter: bqiu
>Assignee: bqiu
>
> Support Site2Site Server Protocol
> Now CPP site2Site only support client side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

nifi git commit: NIFI-3755 - Restoring Hive exception handling behavior

[bbende]

Repository: nifi
Updated Branches:
  refs/heads/master aa4efb43c -> 0054a9e35


NIFI-3755 - Restoring Hive exception handling behavior

This closes #1711.

Signed-off-by: Bryan Bende 


Project: http://git-wip-us.apache.org/repos/asf/nifi/repo
Commit: http://git-wip-us.apache.org/repos/asf/nifi/commit/0054a9e3
Tree: http://git-wip-us.apache.org/repos/asf/nifi/tree/0054a9e3
Diff: http://git-wip-us.apache.org/repos/asf/nifi/diff/0054a9e3

Branch: refs/heads/master
Commit: 0054a9e35fb06b749c4ef2253c918e74c3899ef9
Parents: aa4efb4
Author: Bryan Rosander 
Authored: Thu Apr 27 15:37:27 2017 -0400
Committer: Bryan Bende 
Committed: Fri Apr 28 11:45:43 2017 -0400

--
 .../nifi/dbcp/hive/HiveConnectionPool.java  |  16 ++-
 .../org/apache/nifi/util/hive/HiveWriter.java   |  23 ++-
 .../nifi/dbcp/hive/HiveConnectionPoolTest.java  |  90 
 .../apache/nifi/util/hive/HiveWriterTest.java   | 144 +++
 4 files changed, 265 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/nifi/blob/0054a9e3/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
--
diff --git 
a/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
 
b/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
index 5d80610..64f3027 100644
--- 
a/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
+++ 
b/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
@@ -44,6 +44,7 @@ import org.apache.nifi.util.hive.HiveUtils;
 import org.apache.nifi.util.hive.ValidationResources;
 
 import java.io.IOException;
+import java.lang.reflect.UndeclaredThrowableException;
 import java.security.PrivilegedExceptionAction;
 import java.sql.Connection;
 import java.sql.SQLException;
@@ -278,13 +279,16 @@ public class HiveConnectionPool extends 
AbstractControllerService implements Hiv
 public Connection getConnection() throws ProcessException {
 try {
 if (ugi != null) {
-return ugi.doAs(new PrivilegedExceptionAction() {
-@Override
-public Connection run() throws Exception {
-return dataSource.getConnection();
+try {
+return ugi.doAs((PrivilegedExceptionAction) () 
-> dataSource.getConnection());
+} catch (UndeclaredThrowableException e) {
+Throwable cause = e.getCause();
+if (cause instanceof SQLException) {
+throw (SQLException) cause;
+} else {
+throw e;
 }
-});
-
+}
 } else {
 getLogger().info("Simple Authentication");
 return dataSource.getConnection();

http://git-wip-us.apache.org/repos/asf/nifi/blob/0054a9e3/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveWriter.java
--
diff --git 
a/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveWriter.java
 
b/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveWriter.java
index 1cf77a8..0c121e0 100644
--- 
a/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveWriter.java
+++ 
b/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveWriter.java
@@ -19,6 +19,7 @@
 package org.apache.nifi.util.hive;
 
 import java.io.IOException;
+import java.lang.reflect.UndeclaredThrowableException;
 import java.security.PrivilegedExceptionAction;
 import java.util.List;
 import java.util.concurrent.ExecutionException;
@@ -83,7 +84,16 @@ public class HiveWriter {
 if (ugi == null) {
 return new StrictJsonWriter(endPoint, hiveConf);
 } else {
-return ugi.doAs((PrivilegedExceptionAction) () 
-> new StrictJsonWriter(endPoint, hiveConf));
+try {
+return ugi.doAs((PrivilegedExceptionAction) 
() -> new StrictJsonWriter(endPoint, hiveConf));
+} catch (UndeclaredThrowableException e) {
+Throwable cause = e.getCause();
+if (cause instanceof StreamingException) {
+throw (StreamingException) cause;
+} else {
+

[jira] [Commented] (MINIFI-269) Support Site2Site Server Protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988976#comment-15988976
 ] 

ASF GitHub Bot commented on MINIFI-269:
---

Github user benqiu2016 commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/81
  
@apiri refactor based on your above comments. Thanks.


> Support Site2Site Server Protocol
> -
>
> Key: MINIFI-269
> URL: https://issues.apache.org/jira/browse/MINIFI-269
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: C++
>Affects Versions: cpp-0.1.0
>Reporter: bqiu
>Assignee: bqiu
>
> Support Site2Site Server Protocol
> Now CPP site2Site only support client side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-239) Create a C++ HTTP client processor to match the InvokeHTTP processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988969#comment-15988969
 ] 

ASF GitHub Bot commented on MINIFI-239:
---

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/80


> Create a C++ HTTP client processor to match the InvokeHTTP processor
> 
>
> Key: MINIFI-239
> URL: https://issues.apache.org/jira/browse/MINIFI-239
> Project: Apache NiFi MiNiFi
>  Issue Type: Task
>  Components: C++, Extensions
>Reporter: Andrew Grande
>Assignee: marco polo
>
> There is a ListenHTTP processor, but nothing for the client side (e.g. to 
> invoke REST APIs). The civetweb library is already being used, can be 
> leveraged to implement the InvokeHTTP parity.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-239) Create a C++ HTTP client processor to match the InvokeHTTP processor

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988968#comment-15988968
 ] 

ASF subversion and git services commented on MINIFI-239:


Commit 071ac1e9884d0335f33098cfcf313f396cdd6276 in nifi-minifi-cpp's branch 
refs/heads/master from Marc Parisi
[ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=071ac1e ]

MINIFI-239: Add InvokeHTTP Processor and corresponding tests

This closes #80.

Signed-off-by: Aldrin Piri 


> Create a C++ HTTP client processor to match the InvokeHTTP processor
> 
>
> Key: MINIFI-239
> URL: https://issues.apache.org/jira/browse/MINIFI-239
> Project: Apache NiFi MiNiFi
>  Issue Type: Task
>  Components: C++, Extensions
>Reporter: Andrew Grande
>Assignee: marco polo
>
> There is a ListenHTTP processor, but nothing for the client side (e.g. to 
> invoke REST APIs). The civetweb library is already being used, can be 
> leveraged to implement the InvokeHTTP parity.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

nifi-minifi-cpp git commit: MINIFI-239: Add InvokeHTTP Processor and corresponding tests

[aldrin]

Repository: nifi-minifi-cpp
Updated Branches:
  refs/heads/master 573c511f7 -> 071ac1e98


MINIFI-239: Add InvokeHTTP Processor and corresponding tests

This closes #80.

Signed-off-by: Aldrin Piri 


Project: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/commit/071ac1e9
Tree: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/tree/071ac1e9
Diff: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/diff/071ac1e9

Branch: refs/heads/master
Commit: 071ac1e9884d0335f33098cfcf313f396cdd6276
Parents: 573c511
Author: Marc Parisi 
Authored: Fri Apr 21 19:55:56 2017 -0400
Committer: Aldrin Piri 
Committed: Fri Apr 28 11:06:23 2017 -0400

--
 CMakeLists.txt|  55 ++-
 README.md |   5 +
 libminifi/CMakeLists.txt  |   6 +
 libminifi/include/core/FlowConfiguration.h|   2 +-
 libminifi/include/processors/InvokeHTTP.h | 228 +
 libminifi/include/utils/ByteInputCallBack.h   |  74 +++
 libminifi/src/core/FlowConfiguration.cpp  |   4 +
 libminifi/src/processors/InvokeHTTP.cpp   | 537 +
 libminifi/test/HttpGetIntegrationTest.cpp | 118 +
 libminifi/test/HttpPostIntegrationTest.cpp| 117 +
 libminifi/test/unit/InvokeHTTPTests.cpp   | 471 ++
 libminifi/test/unit/ProvenanceTestHelper.h|  67 +++
 libminifi/test/unit/resource/TestHTTPGet.yml  |  73 +++
 libminifi/test/unit/resource/TestHTTPPost.yml |  87 
 main/MiNiFiMain.cpp   |   6 +
 15 files changed, 1848 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/blob/071ac1e9/CMakeLists.txt
--
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 519dae9..42c86d7 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -72,6 +72,7 @@ list(APPEND CMAKE_MODULE_PATH 
"${CMAKE_CURRENT_SOURCE_DIR}/cmake")
 
 # Include LevelDB
 find_package (Leveldb REQUIRED)
+find_package(CURL REQUIRED)
 if (LEVELDB_FOUND)
 include_directories(${LEVELDB_INCLUDE_DIRS})
 else ()
@@ -137,8 +138,56 @@ enable_testing(test)
 target_include_directories(tests PRIVATE BEFORE 
"libminifi/include/processors")
 target_include_directories(tests PRIVATE BEFORE 
"libminifi/include/provenance")
 target_link_libraries(tests ${CMAKE_THREAD_LIBS_INIT} ${UUID_LIBRARIES} 
${LEVELDB_LIBRARIES} ${OPENSSL_LIBRARIES} minifi yaml-cpp c-library 
civetweb-cpp jsoncpp_lib_static)
+if (CURL_FOUND)
+target_include_directories(tests PRIVATE BEFORE ${CURL_INCLUDE_DIRS})
+target_link_libraries(tests ${CURL_LIBRARIES})
+endif(CURL_FOUND)
 add_test(NAME LibMinifiTests COMMAND tests)
 
+ 
+file(GLOB LIBMINIFI_TEST_CS "libminifi/test/HttpGetIntegrationTest.cpp")
+add_executable(testHttpGet ${LIBMINIFI_TEST_CS} ${SPD_SOURCES})
+target_include_directories(testHttpGet PRIVATE BEFORE "thirdparty/catch")
+target_include_directories(testHttpGet PRIVATE BEFORE 
"thirdparty/yaml-cpp-yaml-cpp-0.5.3/include")
+target_include_directories(testHttpGet PRIVATE BEFORE 
${LEVELDB_INCLUDE_DIRS})
+target_include_directories(testHttpGet PRIVATE BEFORE "include")
+target_include_directories(testHttpGet PRIVATE BEFORE "libminifi/include/")
+target_include_directories(testHttpGet PRIVATE BEFORE 
"libminifi/include/core")
+target_include_directories(testHttpGet PRIVATE BEFORE 
"libminifi/include/core/controller")
+target_include_directories(testHttpGet PRIVATE BEFORE 
"libminifi/include/core/repository")
+target_include_directories(testHttpGet PRIVATE BEFORE 
"libminifi/include/io")
+target_include_directories(testHttpGet PRIVATE BEFORE 
"libminifi/include/utils")
+target_include_directories(testHttpGet PRIVATE BEFORE 
"libminifi/include/processors")
+target_include_directories(testHttpGet PRIVATE BEFORE 
"libminifi/include/provenance")
+target_link_libraries(testHttpGet ${CMAKE_THREAD_LIBS_INIT} 
${UUID_LIBRARIES} ${LEVELDB_LIBRARIES} ${OPENSSL_LIBRARIES} minifi yaml-cpp 
c-library civetweb-cpp jsoncpp_lib_static)
+if (CURL_FOUND)
+target_include_directories(testHttpGet PRIVATE BEFORE 
${CURL_INCLUDE_DIRS})
+target_link_libraries(testHttpGet ${CURL_LIBRARIES})
+endif(CURL_FOUND)
+add_test(NAME testHttpGet COMMAND testHttpGet 
"${CMAKE_SOURCE_DIR}/libminifi/test/unit/resource/TestHTTPGet.yml")
+
+file(GLOB LIBMINIFI_TEST_CS "libminifi/test/HttpPostIntegrationTest.cpp")
+add_executable(testHttpPost ${LIBMINIFI_TEST_CS} ${SPD_SOURCES})
+target_include_directories(testHttpPost PRIVATE BEFORE "thirdparty/catch")
+

[jira] [Commented] (MINIFI-239) Create a C++ HTTP client processor to match the InvokeHTTP processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988956#comment-15988956
 ] 

ASF GitHub Bot commented on MINIFI-239:
---

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/80
  
got caught up with some other things, but this looks good.  will get 
merged, thanks for the fixes


> Create a C++ HTTP client processor to match the InvokeHTTP processor
> 
>
> Key: MINIFI-239
> URL: https://issues.apache.org/jira/browse/MINIFI-239
> Project: Apache NiFi MiNiFi
>  Issue Type: Task
>  Components: C++, Extensions
>Reporter: Andrew Grande
>Assignee: marco polo
>
> There is a ListenHTTP processor, but nothing for the client side (e.g. to 
> invoke REST APIs). The civetweb library is already being used, can be 
> leveraged to implement the InvokeHTTP parity.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-281) RemoteProcessGroupSchemaV2 not actually used

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988948#comment-15988948
 ] 

ASF GitHub Bot commented on MINIFI-281:
---

GitHub user brosander opened a pull request:

https://github.com/apache/nifi-minifi/pull/83

MINIFI-281 - Using RemoteProcessGroupSchemaV2

Thank you for submitting a contribution to Apache NiFi - MiNiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi-minifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] - N/A - If adding new dependencies to the code, are these 
dependencies licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [X] - N/A - If applicable, have you updated the LICENSE file, including 
the main LICENSE file under minifi-assembly?
- [X] - N/A - If applicable, have you updated the NOTICE file, including 
the main NOTICE file found under minifi-assembly?

### For documentation related changes:
- [X] - N/A - Have you ensured that format looks appropriate for the output 
in which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/brosander/nifi-minifi MINIFI-281

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit 3d6a9fea23c1de8dab0730a3b5de2ff34b7695c2
Author: Bryan Rosander 
Date:   2017-04-28T14:48:31Z

MINIFI-281 - Using RemoteProcessGroupSchemaV2




> RemoteProcessGroupSchemaV2 not actually used
> 
>
> Key: MINIFI-281
> URL: https://issues.apache.org/jira/browse/MINIFI-281
> Project: Apache NiFi MiNiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
>Priority: Minor
>
> ProcessGroupSchemaV2 should use RemoteProcessGroupSchemaV2 for proper 
> backwards compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (MINIFI-281) RemoteProcessGroupSchemaV2 not actually used

[Bryan Rosander (JIRA)]

Bryan Rosander created MINIFI-281:
-

 Summary: RemoteProcessGroupSchemaV2 not actually used
 Key: MINIFI-281
 URL: https://issues.apache.org/jira/browse/MINIFI-281
 Project: Apache NiFi MiNiFi
  Issue Type: Bug
Reporter: Bryan Rosander
Assignee: Bryan Rosander
Priority: Minor


ProcessGroupSchemaV2 should use RemoteProcessGroupSchemaV2 for proper backwards 
compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-277) Write nifi.variable.registry.properties to nifi.properties

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988873#comment-15988873
 ] 

ASF GitHub Bot commented on MINIFI-277:
---

Github user brosander commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/80#discussion_r113939300
  
--- Diff: 
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v2/CorePropertiesSchemaV2.java
 ---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.minifi.commons.schema.v2;
+
+import static 
org.apache.nifi.minifi.commons.schema.common.CommonPropertyKeys.CORE_PROPS_KEY;
+import static 
org.apache.nifi.minifi.commons.schema.common.CommonPropertyKeys.MAX_CONCURRENT_THREADS_KEY;
+
+import java.util.Map;
+
+import org.apache.nifi.minifi.commons.schema.common.BaseSchema;
+import org.apache.nifi.minifi.commons.schema.common.WritableSchema;
+
+/**
+ *
+ */
+public class CorePropertiesSchemaV2 extends BaseSchema implements 
WritableSchema {
+
+public static final String FLOW_CONTROLLER_SHUTDOWN_PERIOD_KEY = "flow 
controller graceful shutdown period";
+public static final String FLOW_SERVICE_WRITE_DELAY_INTERVAL_KEY = 
"flow service write delay interval";
+public static final String ADMINISTRATIVE_YIELD_DURATION_KEY = 
"administrative yield duration";
+public static final String BORED_YIELD_DURATION_KEY = "bored yield 
duration";
+
+public static final String 
DEFAULT_FLOW_CONTROLLER_GRACEFUL_SHUTDOWN_PERIOD = "10 sec";
+public static final String DEFAULT_FLOW_SERVICE_WRITE_DELAY_INTERVAL = 
"500 ms";
+public static final String DEFAULT_ADMINISTRATIVE_YIELD_DURATION = "30 
sec";
+public static final String DEFAULT_BORED_YIELD_DURATION = "10 millis";
+public static final int DEFAULT_MAX_CONCURRENT_THREADS = 1;
+
+private String flowControllerGracefulShutdownPeriod = 
DEFAULT_FLOW_CONTROLLER_GRACEFUL_SHUTDOWN_PERIOD;
+private String flowServiceWriteDelayInterval = 
DEFAULT_FLOW_SERVICE_WRITE_DELAY_INTERVAL;
+private String administrativeYieldDuration = 
DEFAULT_ADMINISTRATIVE_YIELD_DURATION;
+private String boredYieldDuration = DEFAULT_BORED_YIELD_DURATION;
+private Number maxConcurrentThreads = DEFAULT_MAX_CONCURRENT_THREADS;
+
+public CorePropertiesSchemaV2() {
+}
+
+public CorePropertiesSchemaV2(Map map) {
+flowControllerGracefulShutdownPeriod = getOptionalKeyAsType(map, 
FLOW_CONTROLLER_SHUTDOWN_PERIOD_KEY, String.class,
+CORE_PROPS_KEY, 
DEFAULT_FLOW_CONTROLLER_GRACEFUL_SHUTDOWN_PERIOD);
+flowServiceWriteDelayInterval = getOptionalKeyAsType(map, 
FLOW_SERVICE_WRITE_DELAY_INTERVAL_KEY, String.class,
+CORE_PROPS_KEY, DEFAULT_FLOW_SERVICE_WRITE_DELAY_INTERVAL);
+administrativeYieldDuration = getOptionalKeyAsType(map, 
ADMINISTRATIVE_YIELD_DURATION_KEY, String.class,
+CORE_PROPS_KEY, DEFAULT_ADMINISTRATIVE_YIELD_DURATION);
+boredYieldDuration = getOptionalKeyAsType(map, 
BORED_YIELD_DURATION_KEY, String.class, CORE_PROPS_KEY, 
DEFAULT_BORED_YIELD_DURATION);
+maxConcurrentThreads = getOptionalKeyAsType(map, 
MAX_CONCURRENT_THREADS_KEY, Number.class,
+CORE_PROPS_KEY, DEFAULT_MAX_CONCURRENT_THREADS);
+}
+
+@Override
+public Map toMap() {
--- End diff --

Then in ConfigSchemaV2, you'd want something like 
```
putIfNotNull(result, CORE_PROPS_KEY, coreProperties.convert());
```


> Write nifi.variable.registry.properties to nifi.properties
> --
>
> Key: MINIFI-277
> URL: https://issues.apache.org/jira/browse/MINIFI-277
> Project: Apache NiFi MiNiFi
>  Issue Type: Task
>Affects Versions: 0.1.0
>Reporter: 

[jira] [Commented] (MINIFI-277) Write nifi.variable.registry.properties to nifi.properties

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988860#comment-15988860
 ] 

ASF GitHub Bot commented on MINIFI-277:
---

Github user brosander commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/80#discussion_r113938266
  
--- Diff: 
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v2/CorePropertiesSchemaV2.java
 ---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.minifi.commons.schema.v2;
+
+import static 
org.apache.nifi.minifi.commons.schema.common.CommonPropertyKeys.CORE_PROPS_KEY;
+import static 
org.apache.nifi.minifi.commons.schema.common.CommonPropertyKeys.MAX_CONCURRENT_THREADS_KEY;
+
+import java.util.Map;
+
+import org.apache.nifi.minifi.commons.schema.common.BaseSchema;
+import org.apache.nifi.minifi.commons.schema.common.WritableSchema;
+
+/**
+ *
+ */
+public class CorePropertiesSchemaV2 extends BaseSchema implements 
WritableSchema {
+
+public static final String FLOW_CONTROLLER_SHUTDOWN_PERIOD_KEY = "flow 
controller graceful shutdown period";
+public static final String FLOW_SERVICE_WRITE_DELAY_INTERVAL_KEY = 
"flow service write delay interval";
+public static final String ADMINISTRATIVE_YIELD_DURATION_KEY = 
"administrative yield duration";
+public static final String BORED_YIELD_DURATION_KEY = "bored yield 
duration";
+
+public static final String 
DEFAULT_FLOW_CONTROLLER_GRACEFUL_SHUTDOWN_PERIOD = "10 sec";
+public static final String DEFAULT_FLOW_SERVICE_WRITE_DELAY_INTERVAL = 
"500 ms";
+public static final String DEFAULT_ADMINISTRATIVE_YIELD_DURATION = "30 
sec";
+public static final String DEFAULT_BORED_YIELD_DURATION = "10 millis";
+public static final int DEFAULT_MAX_CONCURRENT_THREADS = 1;
+
+private String flowControllerGracefulShutdownPeriod = 
DEFAULT_FLOW_CONTROLLER_GRACEFUL_SHUTDOWN_PERIOD;
+private String flowServiceWriteDelayInterval = 
DEFAULT_FLOW_SERVICE_WRITE_DELAY_INTERVAL;
+private String administrativeYieldDuration = 
DEFAULT_ADMINISTRATIVE_YIELD_DURATION;
+private String boredYieldDuration = DEFAULT_BORED_YIELD_DURATION;
+private Number maxConcurrentThreads = DEFAULT_MAX_CONCURRENT_THREADS;
+
+public CorePropertiesSchemaV2() {
+}
+
+public CorePropertiesSchemaV2(Map map) {
+flowControllerGracefulShutdownPeriod = getOptionalKeyAsType(map, 
FLOW_CONTROLLER_SHUTDOWN_PERIOD_KEY, String.class,
+CORE_PROPS_KEY, 
DEFAULT_FLOW_CONTROLLER_GRACEFUL_SHUTDOWN_PERIOD);
+flowServiceWriteDelayInterval = getOptionalKeyAsType(map, 
FLOW_SERVICE_WRITE_DELAY_INTERVAL_KEY, String.class,
+CORE_PROPS_KEY, DEFAULT_FLOW_SERVICE_WRITE_DELAY_INTERVAL);
+administrativeYieldDuration = getOptionalKeyAsType(map, 
ADMINISTRATIVE_YIELD_DURATION_KEY, String.class,
+CORE_PROPS_KEY, DEFAULT_ADMINISTRATIVE_YIELD_DURATION);
+boredYieldDuration = getOptionalKeyAsType(map, 
BORED_YIELD_DURATION_KEY, String.class, CORE_PROPS_KEY, 
DEFAULT_BORED_YIELD_DURATION);
+maxConcurrentThreads = getOptionalKeyAsType(map, 
MAX_CONCURRENT_THREADS_KEY, Number.class,
+CORE_PROPS_KEY, DEFAULT_MAX_CONCURRENT_THREADS);
+}
+
+@Override
+public Map toMap() {
--- End diff --

When changing WritableSchema -> ConvertableSchema, this method should be 
able to be turned into the convert() method (much like 
[RemoteProcessGroupSchemaV2](https://github.com/apache/nifi-minifi/blob/master/minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v2/RemoteProcessGroupSchemaV2.java#L75))


> Write nifi.variable.registry.properties to nifi.properties
> --
>
> Key: 

[jira] [Commented] (MINIFI-277) Write nifi.variable.registry.properties to nifi.properties

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988855#comment-15988855
 ] 

ASF GitHub Bot commented on MINIFI-277:
---

Github user brosander commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/80#discussion_r113937684
  
--- Diff: 
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v2/CorePropertiesSchemaV2.java
 ---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.minifi.commons.schema.v2;
+
+import static 
org.apache.nifi.minifi.commons.schema.common.CommonPropertyKeys.CORE_PROPS_KEY;
+import static 
org.apache.nifi.minifi.commons.schema.common.CommonPropertyKeys.MAX_CONCURRENT_THREADS_KEY;
+
+import java.util.Map;
+
+import org.apache.nifi.minifi.commons.schema.common.BaseSchema;
+import org.apache.nifi.minifi.commons.schema.common.WritableSchema;
+
+/**
+ *
+ */
+public class CorePropertiesSchemaV2 extends BaseSchema implements 
WritableSchema {
+
+public static final String FLOW_CONTROLLER_SHUTDOWN_PERIOD_KEY = "flow 
controller graceful shutdown period";
+public static final String FLOW_SERVICE_WRITE_DELAY_INTERVAL_KEY = 
"flow service write delay interval";
+public static final String ADMINISTRATIVE_YIELD_DURATION_KEY = 
"administrative yield duration";
+public static final String BORED_YIELD_DURATION_KEY = "bored yield 
duration";
+
+public static final String 
DEFAULT_FLOW_CONTROLLER_GRACEFUL_SHUTDOWN_PERIOD = "10 sec";
+public static final String DEFAULT_FLOW_SERVICE_WRITE_DELAY_INTERVAL = 
"500 ms";
+public static final String DEFAULT_ADMINISTRATIVE_YIELD_DURATION = "30 
sec";
+public static final String DEFAULT_BORED_YIELD_DURATION = "10 millis";
+public static final int DEFAULT_MAX_CONCURRENT_THREADS = 1;
+
+private String flowControllerGracefulShutdownPeriod = 
DEFAULT_FLOW_CONTROLLER_GRACEFUL_SHUTDOWN_PERIOD;
+private String flowServiceWriteDelayInterval = 
DEFAULT_FLOW_SERVICE_WRITE_DELAY_INTERVAL;
+private String administrativeYieldDuration = 
DEFAULT_ADMINISTRATIVE_YIELD_DURATION;
+private String boredYieldDuration = DEFAULT_BORED_YIELD_DURATION;
+private Number maxConcurrentThreads = DEFAULT_MAX_CONCURRENT_THREADS;
+
+public CorePropertiesSchemaV2() {
+}
+
+public CorePropertiesSchemaV2(Map map) {
+flowControllerGracefulShutdownPeriod = getOptionalKeyAsType(map, 
FLOW_CONTROLLER_SHUTDOWN_PERIOD_KEY, String.class,
+CORE_PROPS_KEY, 
DEFAULT_FLOW_CONTROLLER_GRACEFUL_SHUTDOWN_PERIOD);
+flowServiceWriteDelayInterval = getOptionalKeyAsType(map, 
FLOW_SERVICE_WRITE_DELAY_INTERVAL_KEY, String.class,
+CORE_PROPS_KEY, DEFAULT_FLOW_SERVICE_WRITE_DELAY_INTERVAL);
+administrativeYieldDuration = getOptionalKeyAsType(map, 
ADMINISTRATIVE_YIELD_DURATION_KEY, String.class,
+CORE_PROPS_KEY, DEFAULT_ADMINISTRATIVE_YIELD_DURATION);
+boredYieldDuration = getOptionalKeyAsType(map, 
BORED_YIELD_DURATION_KEY, String.class, CORE_PROPS_KEY, 
DEFAULT_BORED_YIELD_DURATION);
+maxConcurrentThreads = getOptionalKeyAsType(map, 
MAX_CONCURRENT_THREADS_KEY, Number.class,
+CORE_PROPS_KEY, DEFAULT_MAX_CONCURRENT_THREADS);
+}
+
+@Override
+public Map toMap() {
+Map result = mapSupplier.get();
+result.put(FLOW_CONTROLLER_SHUTDOWN_PERIOD_KEY, 
flowControllerGracefulShutdownPeriod);
+result.put(FLOW_SERVICE_WRITE_DELAY_INTERVAL_KEY, 
flowServiceWriteDelayInterval);
+result.put(ADMINISTRATIVE_YIELD_DURATION_KEY, 
administrativeYieldDuration);
+result.put(BORED_YIELD_DURATION_KEY, boredYieldDuration);
+result.put(MAX_CONCURRENT_THREADS_KEY, maxConcurrentThreads);
+return result;

[jira] [Commented] (MINIFI-277) Write nifi.variable.registry.properties to nifi.properties

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988854#comment-15988854
 ] 

ASF GitHub Bot commented on MINIFI-277:
---

Github user brosander commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/80#discussion_r113937508
  
--- Diff: 
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v2/CorePropertiesSchemaV2.java
 ---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.minifi.commons.schema.v2;
+
+import static 
org.apache.nifi.minifi.commons.schema.common.CommonPropertyKeys.CORE_PROPS_KEY;
+import static 
org.apache.nifi.minifi.commons.schema.common.CommonPropertyKeys.MAX_CONCURRENT_THREADS_KEY;
+
+import java.util.Map;
+
+import org.apache.nifi.minifi.commons.schema.common.BaseSchema;
+import org.apache.nifi.minifi.commons.schema.common.WritableSchema;
+
+/**
+ *
+ */
+public class CorePropertiesSchemaV2 extends BaseSchema implements 
WritableSchema {
+
+public static final String FLOW_CONTROLLER_SHUTDOWN_PERIOD_KEY = "flow 
controller graceful shutdown period";
+public static final String FLOW_SERVICE_WRITE_DELAY_INTERVAL_KEY = 
"flow service write delay interval";
+public static final String ADMINISTRATIVE_YIELD_DURATION_KEY = 
"administrative yield duration";
+public static final String BORED_YIELD_DURATION_KEY = "bored yield 
duration";
+
+public static final String 
DEFAULT_FLOW_CONTROLLER_GRACEFUL_SHUTDOWN_PERIOD = "10 sec";
+public static final String DEFAULT_FLOW_SERVICE_WRITE_DELAY_INTERVAL = 
"500 ms";
+public static final String DEFAULT_ADMINISTRATIVE_YIELD_DURATION = "30 
sec";
+public static final String DEFAULT_BORED_YIELD_DURATION = "10 millis";
+public static final int DEFAULT_MAX_CONCURRENT_THREADS = 1;
--- End diff --

The above constants can probably be deleted and statically imported from 
CorePropertiesSchema


> Write nifi.variable.registry.properties to nifi.properties
> --
>
> Key: MINIFI-277
> URL: https://issues.apache.org/jira/browse/MINIFI-277
> Project: Apache NiFi MiNiFi
>  Issue Type: Task
>Affects Versions: 0.1.0
>Reporter: Jeff Zemerick
>Assignee: Jeff Zemerick
>
> When MiNiFi writes the nifi.properties the 
> "nifi.variable.registry.properties" is not written to the file.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-277) Write nifi.variable.registry.properties to nifi.properties

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988853#comment-15988853
 ] 

ASF GitHub Bot commented on MINIFI-277:
---

Github user brosander commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/80#discussion_r113937276
  
--- Diff: 
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v2/CorePropertiesSchemaV2.java
 ---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.minifi.commons.schema.v2;
+
+import static 
org.apache.nifi.minifi.commons.schema.common.CommonPropertyKeys.CORE_PROPS_KEY;
+import static 
org.apache.nifi.minifi.commons.schema.common.CommonPropertyKeys.MAX_CONCURRENT_THREADS_KEY;
+
+import java.util.Map;
+
+import org.apache.nifi.minifi.commons.schema.common.BaseSchema;
+import org.apache.nifi.minifi.commons.schema.common.WritableSchema;
+
+/**
+ *
+ */
+public class CorePropertiesSchemaV2 extends BaseSchema implements 
WritableSchema {
--- End diff --

Can this implement ConvertableSchema instead of 
WritableSchema?


> Write nifi.variable.registry.properties to nifi.properties
> --
>
> Key: MINIFI-277
> URL: https://issues.apache.org/jira/browse/MINIFI-277
> Project: Apache NiFi MiNiFi
>  Issue Type: Task
>Affects Versions: 0.1.0
>Reporter: Jeff Zemerick
>Assignee: Jeff Zemerick
>
> When MiNiFi writes the nifi.properties the 
> "nifi.variable.registry.properties" is not written to the file.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (MINIFI-280) Implement ExtractText processor

[Andrew Christianson (JIRA)]

Andrew Christianson created MINIFI-280:
--

 Summary: Implement ExtractText processor
 Key: MINIFI-280
 URL: https://issues.apache.org/jira/browse/MINIFI-280
 Project: Apache NiFi MiNiFi
  Issue Type: Improvement
  Components: C++, Extensions
Reporter: Andrew Christianson
Assignee: Andrew Christianson


Implement the ExtractText processor as it has clearly utility in simple 
endpoint flows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINIFI-244) Create FocusArchive processor

[Andrew Christianson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988715#comment-15988715
 ] 

Andrew Christianson commented on MINIFI-244:


Just a quick update on this. The processors are developed and pushed to 
https://github.com/achristianson/nifi-minifi-cpp/tree/MINIFI-244, but there is 
going to be merging work and ideally work on unit tests before I can turn it 
into a proper pull request. Feel free to take an early look.

> Create FocusArchive processor
> -
>
> Key: MINIFI-244
> URL: https://issues.apache.org/jira/browse/MINIFI-244
> Project: Apache NiFi MiNiFi
>  Issue Type: Task
>  Components: C++, Extensions
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>Priority: Minor
>
> Create an FocusArchive processor which implements a lens over an archive 
> (tar, etc.). A concise, though informal, definition of a lens is as follows:
> "Essentially, they represent the act of “peering into” or “focusing in on” 
> some particular piece/path of a complex data object such that you can more 
> precisely target particular operations without losing the context or 
> structure of the overall data you’re working with." 
> https://medium.com/@dtipson/functional-lenses-d1aba9e52254#.hdgsvbraq
> Why an FocusArchive in MiNiFi? Simply put, it will enable us to "focus in on" 
> an entry in the archive, perform processing *in-context* of that entry, then 
> re-focus on the overall archive. This allows for transformation or other 
> processing of an entry in the archive without losing the overall context of 
> the archive.
> Initial format support is tar, due to its simplicity and ubiquity.
> Attributes:
> - Path (the path in the archive to focus; "/" to re-focus the overall archive)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)