[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111051#comment-16111051 ] ASF subversion and git services commented on MINIFI-311: Commit 8389c8aa827118e5a8d605f0def6b1e4727efa90 in nifi-minifi-cpp's branch refs/heads/master from [~achristianson] [ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=8389c8a ] MINIFI-311 upgraded spdlog to snapshot of master MINIFI-311 ported dockerfile to alpine MINIFI-311 allow warnings on Linux for compatibility with Alpine MINIFI-311 fixed spdlog path in BuildTests cmake file MINIFI-349 moved to multi-stage docker build MINIFI-311 removed unneeded dirs from spdlog snapshot MINIFI-312 Handle spdlog compilation failures in Alpine Linux This closes #118. Signed-off-by: Aldrin Piri> Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > Fix For: cpp-0.3.0 > > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111055#comment-16111055 ] ASF GitHub Bot commented on MINIFI-311: --- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/118 > Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > Fix For: cpp-0.3.0 > > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111056#comment-16111056 ] ASF subversion and git services commented on MINIFI-311: Commit 8389c8aa827118e5a8d605f0def6b1e4727efa90 in nifi-minifi-cpp's branch refs/heads/master from [~achristianson] [ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=8389c8a ] MINIFI-311 upgraded spdlog to snapshot of master MINIFI-311 ported dockerfile to alpine MINIFI-311 allow warnings on Linux for compatibility with Alpine MINIFI-311 fixed spdlog path in BuildTests cmake file MINIFI-349 moved to multi-stage docker build MINIFI-311 removed unneeded dirs from spdlog snapshot MINIFI-312 Handle spdlog compilation failures in Alpine Linux This closes #118. Signed-off-by: Aldrin Piri> Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > Fix For: cpp-0.3.0 > > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111050#comment-16111050 ] ASF subversion and git services commented on MINIFI-311: Commit 8389c8aa827118e5a8d605f0def6b1e4727efa90 in nifi-minifi-cpp's branch refs/heads/master from [~achristianson] [ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=8389c8a ] MINIFI-311 upgraded spdlog to snapshot of master MINIFI-311 ported dockerfile to alpine MINIFI-311 allow warnings on Linux for compatibility with Alpine MINIFI-311 fixed spdlog path in BuildTests cmake file MINIFI-349 moved to multi-stage docker build MINIFI-311 removed unneeded dirs from spdlog snapshot MINIFI-312 Handle spdlog compilation failures in Alpine Linux This closes #118. Signed-off-by: Aldrin Piri> Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > Fix For: cpp-0.3.0 > > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111052#comment-16111052 ] ASF subversion and git services commented on MINIFI-311: Commit 8389c8aa827118e5a8d605f0def6b1e4727efa90 in nifi-minifi-cpp's branch refs/heads/master from [~achristianson] [ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=8389c8a ] MINIFI-311 upgraded spdlog to snapshot of master MINIFI-311 ported dockerfile to alpine MINIFI-311 allow warnings on Linux for compatibility with Alpine MINIFI-311 fixed spdlog path in BuildTests cmake file MINIFI-349 moved to multi-stage docker build MINIFI-311 removed unneeded dirs from spdlog snapshot MINIFI-312 Handle spdlog compilation failures in Alpine Linux This closes #118. Signed-off-by: Aldrin Piri> Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > Fix For: cpp-0.3.0 > > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111053#comment-16111053 ] ASF subversion and git services commented on MINIFI-311: Commit 8389c8aa827118e5a8d605f0def6b1e4727efa90 in nifi-minifi-cpp's branch refs/heads/master from [~achristianson] [ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=8389c8a ] MINIFI-311 upgraded spdlog to snapshot of master MINIFI-311 ported dockerfile to alpine MINIFI-311 allow warnings on Linux for compatibility with Alpine MINIFI-311 fixed spdlog path in BuildTests cmake file MINIFI-349 moved to multi-stage docker build MINIFI-311 removed unneeded dirs from spdlog snapshot MINIFI-312 Handle spdlog compilation failures in Alpine Linux This closes #118. Signed-off-by: Aldrin Piri> Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > Fix For: cpp-0.3.0 > > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111035#comment-16111035 ] ASF GitHub Bot commented on MINIFI-311: --- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/118 hey @achristianson, everything looks good here. will get this merged in. thanks for your adjustments! > Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > Fix For: cpp-0.3.0 > > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110967#comment-16110967 ] ASF GitHub Bot commented on MINIFI-311: --- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/118 reviewing changes > Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109047#comment-16109047 ] ASF GitHub Bot commented on MINIFI-311: --- Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/118 @apiri removed those dirs & rebased. Should be good to go now. > Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109014#comment-16109014 ] ASF GitHub Bot commented on MINIFI-311: --- Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/118 Thanks for the feedback. I will make the required changes and update the PR. > Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103591#comment-16103591 ] ASF GitHub Bot commented on MINIFI-311: --- Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/118#discussion_r129905012 --- Diff: thirdparty/spdlog-20170710/example/CMakeLists.txt --- @@ -0,0 +1,49 @@ +# */ --- End diff -- Should remove the entirety of the example directory > Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103590#comment-16103590 ] ASF GitHub Bot commented on MINIFI-311: --- Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/118#discussion_r129909967 --- Diff: thirdparty/spdlog-20170710/tests/CMakeLists.txt --- @@ -0,0 +1,19 @@ +# --- End diff -- Should remove the tests subdirectory and skip this part of the build for the lib > Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103588#comment-16103588 ] ASF GitHub Bot commented on MINIFI-311: --- Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/118#discussion_r129904610 --- Diff: thirdparty/spdlog-20170710/.travis.yml --- @@ -0,0 +1,90 @@ +# Adapted from various sources, including: --- End diff -- We should remove this from the source inclusion. Anything beyond the actual source should get stripped out to minimize LICENSE/NOTICE concerns. > Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103589#comment-16103589 ] ASF GitHub Bot commented on MINIFI-311: --- Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/118#discussion_r129904782 --- Diff: thirdparty/spdlog-20170710/bench/boost-bench-mt.cpp --- @@ -0,0 +1,84 @@ +// --- End diff -- Should remove the entirety of the bench subdirectory. > Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103503#comment-16103503 ] ASF GitHub Bot commented on MINIFI-311: --- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/118 reviewing > Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084273#comment-16084273 ] ASF GitHub Bot commented on MINIFI-311: --- GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/118 MINIFI-311 Move to alpine base for docker image. This change takes the 1.5G ubuntu minifi image and reduces it to a 39MB image by using a multi-stage alpine build. MINIFI-311 ported dockerfile to alpine MINIFI-311 allow warnings on Linux for compatibility with Alpine MINIFI-311 fixed spdlog path in BuildTests cmake file MINIFI-349 moved to multi-stage docker build You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFI-311 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/118.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #118 commit 95e58d0fba850f9643bf13774863124fc4b0659c Author: Andrew ChristiansonDate: 2017-07-11T16:05:33Z MINIFI-311 upgraded spdlog to snapshot of master MINIFI-311 ported dockerfile to alpine MINIFI-311 allow warnings on Linux for compatibility with Alpine MINIFI-311 fixed spdlog path in BuildTests cmake file MINIFI-349 moved to multi-stage docker build > Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-311) Alpine Linux for MiNiFi CPP Docker images
[ https://issues.apache.org/jira/browse/MINIFI-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080281#comment-16080281 ] Andrew Christianson commented on MINIFI-311: I'll take a look at this one. > Alpine Linux for MiNiFi CPP Docker images > - > > Key: MINIFI-311 > URL: https://issues.apache.org/jira/browse/MINIFI-311 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Reporter: Bryan Rosander >Assignee: Andrew Christianson >Priority: Minor > > With MiNiFi's goals including being lightweight, it seems logical to try to > keep its Docker images as small as feasible. Moving to alpine-based images > is an easy step that reduces the image size quite a bit. > Another thing that would make the images smaller would be to use an image > with build dependencies to perform the build and one without them for the > runnable image. -- This message was sent by Atlassian JIRA (v6.4.14#64029)