[jira] [Commented] (MINIFI-375) Site To Site connection code doesn't work with just host and port because of forward slash
[ https://issues.apache.org/jira/browse/MINIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163357#comment-16163357 ] ASF subversion and git services commented on MINIFI-375: Commit 953432038acbef807789ad7bbcc01240b16fc90d in nifi-minifi-cpp's branch refs/heads/master from Marc Parisi [ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=9534320 ] MINIFI-375: Remove forward slash from urls This closes #127. Signed-off-by: Aldrin Piri > Site To Site connection code doesn't work with just host and port because of > forward slash > -- > > Key: MINIFI-375 > URL: https://issues.apache.org/jira/browse/MINIFI-375 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++ >Reporter: marco polo >Assignee: marco polo >Priority: Critical > Fix For: cpp-0.3.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-375) Site To Site connection code doesn't work with just host and port because of forward slash
[ https://issues.apache.org/jira/browse/MINIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163360#comment-16163360 ] ASF subversion and git services commented on MINIFI-375: Commit a426b8d2d1764f0b9033013dbca609ade7d3c3d2 in nifi-minifi-cpp's branch refs/heads/master from Marc Parisi [ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=a426b8d ] MINIFI-375: Update integration test This closes #129. Signed-off-by: Aldrin Piri > Site To Site connection code doesn't work with just host and port because of > forward slash > -- > > Key: MINIFI-375 > URL: https://issues.apache.org/jira/browse/MINIFI-375 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++ >Reporter: marco polo >Assignee: marco polo >Priority: Critical > Fix For: cpp-0.3.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-375) Site To Site connection code doesn't work with just host and port because of forward slash
[ https://issues.apache.org/jira/browse/MINIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147384#comment-16147384 ] ASF GitHub Bot commented on MINIFI-375: --- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/129 > Site To Site connection code doesn't work with just host and port because of > forward slash > -- > > Key: MINIFI-375 > URL: https://issues.apache.org/jira/browse/MINIFI-375 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++ >Reporter: marco polo >Assignee: marco polo >Priority: Critical > Fix For: cpp-0.3.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-375) Site To Site connection code doesn't work with just host and port because of forward slash
[ https://issues.apache.org/jira/browse/MINIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147383#comment-16147383 ] ASF subversion and git services commented on MINIFI-375: Commit 2efac2da55afca6ffd889b6a08827cc657b9c781 in nifi-minifi-cpp's branch refs/heads/master from Marc Parisi [ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=2efac2d ] MINIFI-375: Update integration test This closes #129. Signed-off-by: Aldrin Piri > Site To Site connection code doesn't work with just host and port because of > forward slash > -- > > Key: MINIFI-375 > URL: https://issues.apache.org/jira/browse/MINIFI-375 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++ >Reporter: marco polo >Assignee: marco polo >Priority: Critical > Fix For: cpp-0.3.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-375) Site To Site connection code doesn't work with just host and port because of forward slash
[ https://issues.apache.org/jira/browse/MINIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147378#comment-16147378 ] ASF GitHub Bot commented on MINIFI-375: --- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/129 Looks good. Thanks for catching this. Will get this merged. > Site To Site connection code doesn't work with just host and port because of > forward slash > -- > > Key: MINIFI-375 > URL: https://issues.apache.org/jira/browse/MINIFI-375 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++ >Reporter: marco polo >Assignee: marco polo >Priority: Critical > Fix For: cpp-0.3.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-375) Site To Site connection code doesn't work with just host and port because of forward slash
[ https://issues.apache.org/jira/browse/MINIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147377#comment-16147377 ] ASF GitHub Bot commented on MINIFI-375: --- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/129 reviewing > Site To Site connection code doesn't work with just host and port because of > forward slash > -- > > Key: MINIFI-375 > URL: https://issues.apache.org/jira/browse/MINIFI-375 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++ >Reporter: marco polo >Assignee: marco polo >Priority: Critical > Fix For: cpp-0.3.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-375) Site To Site connection code doesn't work with just host and port because of forward slash
[ https://issues.apache.org/jira/browse/MINIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135379#comment-16135379 ] ASF GitHub Bot commented on MINIFI-375: --- GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/129 MINIFI-375: Update integration test Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-375 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #129 commit f75a94ca2bd7ef6422043ed1720d78005e5f872c Author: Marc Parisi Date: 2017-08-21T16:20:15Z MINIFI-375: Update integration test > Site To Site connection code doesn't work with just host and port because of > forward slash > -- > > Key: MINIFI-375 > URL: https://issues.apache.org/jira/browse/MINIFI-375 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++ >Reporter: marco polo >Assignee: marco polo >Priority: Critical > Fix For: cpp-0.3.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-375) Site To Site connection code doesn't work with just host and port because of forward slash
[ https://issues.apache.org/jira/browse/MINIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127780#comment-16127780 ] ASF GitHub Bot commented on MINIFI-375: --- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/127 > Site To Site connection code doesn't work with just host and port because of > forward slash > -- > > Key: MINIFI-375 > URL: https://issues.apache.org/jira/browse/MINIFI-375 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++ >Reporter: marco polo >Assignee: marco polo >Priority: Critical > Fix For: cpp-0.3.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-375) Site To Site connection code doesn't work with just host and port because of forward slash
[ https://issues.apache.org/jira/browse/MINIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1612#comment-1612 ] ASF GitHub Bot commented on MINIFI-375: --- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/127 Was able to recreate the issue and verify that this resolved it. This makes sense as to why it was not working given the resource paths for the NiFi endpoints. Will merge. > Site To Site connection code doesn't work with just host and port because of > forward slash > -- > > Key: MINIFI-375 > URL: https://issues.apache.org/jira/browse/MINIFI-375 > Project: Apache NiFi MiNiFi > Issue Type: Bug >Reporter: marco polo >Assignee: marco polo >Priority: Critical > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-375) Site To Site connection code doesn't work with just host and port because of forward slash
[ https://issues.apache.org/jira/browse/MINIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127778#comment-16127778 ] ASF GitHub Bot commented on MINIFI-375: --- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/127 reviewing > Site To Site connection code doesn't work with just host and port because of > forward slash > -- > > Key: MINIFI-375 > URL: https://issues.apache.org/jira/browse/MINIFI-375 > Project: Apache NiFi MiNiFi > Issue Type: Bug >Reporter: marco polo >Assignee: marco polo >Priority: Critical > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-375) Site To Site connection code doesn't work with just host and port because of forward slash
[ https://issues.apache.org/jira/browse/MINIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127772#comment-16127772 ] ASF subversion and git services commented on MINIFI-375: Commit 058bb84ba18be6e3da26573849d05bde8ce8fdb0 in nifi-minifi-cpp's branch refs/heads/master from Marc Parisi [ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=058bb84 ] MINIFI-375: Remove forward slash from urls This closes #127. Signed-off-by: Aldrin Piri > Site To Site connection code doesn't work with just host and port because of > forward slash > -- > > Key: MINIFI-375 > URL: https://issues.apache.org/jira/browse/MINIFI-375 > Project: Apache NiFi MiNiFi > Issue Type: Bug >Reporter: marco polo >Assignee: marco polo >Priority: Critical > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-375) Site To Site connection code doesn't work with just host and port because of forward slash
[ https://issues.apache.org/jira/browse/MINIFI-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127742#comment-16127742 ] ASF GitHub Bot commented on MINIFI-375: --- GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/127 MINIFI-375: Remove forward slash from urls Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-375 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/127.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #127 commit 01cc006be5926e680b7089d6a9c8f016008dc773 Author: Marc Parisi Date: 2017-08-15T19:05:41Z MINIFI-375: Remove forward slash from urls > Site To Site connection code doesn't work with just host and port because of > forward slash > -- > > Key: MINIFI-375 > URL: https://issues.apache.org/jira/browse/MINIFI-375 > Project: Apache NiFi MiNiFi > Issue Type: Bug >Reporter: marco polo >Assignee: marco polo >Priority: Critical > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
