[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135385#comment-16135385 ] ASF GitHub Bot commented on MINIFI-388: --- Github user achristianson closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/130 > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135384#comment-16135384 ] ASF GitHub Bot commented on MINIFI-388: --- GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/130 MINIFI-388 symlink versioned libcrypto/libssl to non-versioned path so that civet can find them when TLS is used Added symlink cmds to dockerfile to allow civet to find the libraries in the expected locations. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFI-388 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/130.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #130 commit 83e748ba6c3af5c3467f470e0fb462e204de55e8 Author: Andrew Christianson Date: 2017-07-13T14:42:35Z MINIFI-350 added pytest-based system integration test framework and initial test cases commit 62f44f3bfaea08bce1f04991b8b693b5bd629d45 Author: Andrew I. Christianson Date: 2017-08-18T15:13:35Z MINIFI-374 WIP commit 1d550ed2da31dbeaf9b73b5a40184f871e0da4ab Author: Andrew I. Christianson Date: 2017-08-18T15:24:58Z MINIFI-374 WIP commit bab47cc8fbe6be6618dbe0a95202d78c0b706295 Author: Andrew I. Christianson Date: 2017-08-18T16:19:49Z MINIFI-374 WIP commit bd89c08030f0fcc03509bb3177331978b11205f5 Author: Andrew I. Christianson Date: 2017-08-21T16:19:06Z MINIFI-374 WIP commit bfc842531e130896b0f96b08db4241840ed67ae5 Author: Andrew I. Christianson Date: 2017-08-21T16:19:54Z MINIFI-388 symlink versioned libcrypto/libssl to non-versioned path so that civet can find them when TLS is used > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135389#comment-16135389 ] ASF GitHub Bot commented on MINIFI-388: --- GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/131 MINIFI-388 symlink versioned libcrypto/libssl to non-versioned path s… …o that civet can find them when TLS is used ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFI-388 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/131.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #131 commit 6683974e1352e03a0c6861ef058ffa9bf71e9967 Author: Andrew I. Christianson Date: 2017-08-21T16:19:54Z MINIFI-388 symlink versioned libcrypto/libssl to non-versioned path so that civet can find them when TLS is used > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135399#comment-16135399 ] ASF GitHub Bot commented on MINIFI-388: --- Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/130 Disregard this one. Was based on MINIFI-374 instead of master. > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[
https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135401#comment-16135401
]
ASF GitHub Bot commented on MINIFI-388:
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r134278103
--- Diff: docker/Dockerfile ---
@@ -100,6 +100,10 @@ RUN mkdir -p $MINIFI_BASE_DIR
COPY --from=builder ${MINIFI_HOME} ${MINIFI_HOME}
RUN chown -R ${USER}:${USER} /opt/minifi
+# Link crypto libs to known locations for civet
+RUN ln -s /usr/lib/libcrypto.so.1.0.0 /usr/lib/libcrypto.so
--- End diff --
why not set the make option with CIVET? It seems like a bandaid that could
come apart if something within the container changed. Could it be such that our
make CRYPTO_LIB was determined via an embedded command?
> MiNiFi core on startup if TLS is used with ListenHTTP (civet)
> -
>
> Key: MINIFI-388
> URL: https://issues.apache.org/jira/browse/MINIFI-388
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++, Docker
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>
> MiNiFi cpp core dumps on startup because civet attempts to load
> libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so,
> /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib
> paths to the non-versioned paths.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[
https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135404#comment-16135404
]
ASF GitHub Bot commented on MINIFI-388:
---
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r134278520
--- Diff: docker/Dockerfile ---
@@ -100,6 +100,10 @@ RUN mkdir -p $MINIFI_BASE_DIR
COPY --from=builder ${MINIFI_HOME} ${MINIFI_HOME}
RUN chown -R ${USER}:${USER} /opt/minifi
+# Link crypto libs to known locations for civet
+RUN ln -s /usr/lib/libcrypto.so.1.0.0 /usr/lib/libcrypto.so
--- End diff --
Looking into it... that would be a better fix if it works out.
> MiNiFi core on startup if TLS is used with ListenHTTP (civet)
> -
>
> Key: MINIFI-388
> URL: https://issues.apache.org/jira/browse/MINIFI-388
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++, Docker
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>
> MiNiFi cpp core dumps on startup because civet attempts to load
> libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so,
> /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib
> paths to the non-versioned paths.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135979#comment-16135979 ] ASF GitHub Bot commented on MINIFI-388: --- Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/131 Updated to disable dynamic loading of TLS libs in civet, install libressl instead of openssl to resolve conflict with libcurl deps, and backport fix for civetweb which fixes compatibility with libressl. Basically, libcurl and civet were using conflicting TLS versions. This worked due to dynamic loading of openssl libs, but turning that off and having both depend on libressl removes the duplication while also solving MINIFI-388. This should be more of a "proper"/lasting fix. The civet patch backport will go away on the next version of civet. > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136821#comment-16136821 ] ASF GitHub Bot commented on MINIFI-388: --- Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/131 Looks like we have an issue now with civet/TLS in travis. Looking into it. > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138595#comment-16138595 ] ASF GitHub Bot commented on MINIFI-388: --- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r134802972 --- Diff: thirdparty/civetweb-1.9.1/src/civetweb.c --- @@ -11856,7 +11859,24 @@ ssl_get_client_cert_info(struct mg_connection *conn) /* Calculate SHA1 fingerprint and store as a hex string */ ulen = 0; - ASN1_digest((int (*)())i2d_X509, digest, (char *)cert, buf, &ulen); + + /* ASN1_digest is deprecated. Do the calculation manually, --- End diff -- is this also a backport? > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138594#comment-16138594 ] ASF GitHub Bot commented on MINIFI-388: --- Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/131 Issue was addressed by an upstream commit in civetweb: https://github.com/civetweb/civetweb/commit/e849ce4b54c09d5b4441e371f17cf13368ac2234. Backported that commit which should fix the travis/ubuntu trusty issue. > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138599#comment-16138599 ] ASF GitHub Bot commented on MINIFI-388: --- Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r134803190 --- Diff: thirdparty/civetweb-1.9.1/src/civetweb.c --- @@ -11856,7 +11859,24 @@ ssl_get_client_cert_info(struct mg_connection *conn) /* Calculate SHA1 fingerprint and store as a hex string */ ulen = 0; - ASN1_digest((int (*)())i2d_X509, digest, (char *)cert, buf, &ulen); + + /* ASN1_digest is deprecated. Do the calculation manually, --- End diff -- Yes. > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138601#comment-16138601 ] ASF GitHub Bot commented on MINIFI-388: --- Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r134803404 --- Diff: thirdparty/civetweb-1.9.1/src/civetweb.c --- @@ -11856,7 +11859,24 @@ ssl_get_client_cert_info(struct mg_connection *conn) /* Calculate SHA1 fingerprint and store as a hex string */ ulen = 0; - ASN1_digest((int (*)())i2d_X509, digest, (char *)cert, buf, &ulen); + + /* ASN1_digest is deprecated. Do the calculation manually, --- End diff -- https://github.com/civetweb/civetweb/commit/fb9ef36bb295cf489aecd79c8bb9c6eac11e896e is where it comes from. > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150534#comment-16150534 ] ASF GitHub Bot commented on MINIFI-388: --- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r136576120 --- Diff: thirdparty/civetweb-1.9.1/src/civetweb.c --- @@ -11856,7 +11859,24 @@ ssl_get_client_cert_info(struct mg_connection *conn) /* Calculate SHA1 fingerprint and store as a hex string */ ulen = 0; - ASN1_digest((int (*)())i2d_X509, digest, (char *)cert, buf, &ulen); + + /* ASN1_digest is deprecated. Do the calculation manually, --- End diff -- Sorry I missed this response. I was concerned about using custom code in the third party dir, but with that knowledge, with that knowledge it's a non issue. I'll +1 and merge, thanks! > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150612#comment-16150612 ] ASF subversion and git services commented on MINIFI-388: Commit d422e725cb0afb44a38c1062e832c1db284fd57b in nifi-minifi-cpp's branch refs/heads/master from Andrew I. Christianson [ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=d422e72 ] MINIFI-388 Disable dynamic loading of TLS libs in civet, install libressl instead of openssl to resolve conflict with libcurl deps, and backport fix for civetweb which fixes compatibility with libressl This closes #131. Signed-off-by: Marc Parisi > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150613#comment-16150613 ] ASF GitHub Bot commented on MINIFI-388: --- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/131 > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163362#comment-16163362 ] ASF subversion and git services commented on MINIFI-388: Commit 35a47c7f42916c5c942824d35e252b7d51409f90 in nifi-minifi-cpp's branch refs/heads/master from Andrew I. Christianson [ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=35a47c7 ] MINIFI-388 Disable dynamic loading of TLS libs in civet, install libressl instead of openssl to resolve conflict with libcurl deps, and backport fix for civetweb which fixes compatibility with libressl This closes #131. Signed-off-by: Marc Parisi > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184036#comment-16184036 ] ASF GitHub Bot commented on MINIFI-388: --- Github user calebj commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/131 This doesn't build for me without backporting the `#define` for EVP_Digest and the matching entry in `crypto_sw`. I added these in 66dc8f039ca0fa1af362c11a5bcc43475456bc74; should I create another PR? > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184038#comment-16184038 ] ASF GitHub Bot commented on MINIFI-388: --- Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/131 @calebj sure! Can you tell me what distro you are building on? > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184047#comment-16184047 ] ASF GitHub Bot commented on MINIFI-388: --- Github user calebj commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/131 I'm building on Cloud9, which has Ubuntu 14.04 with GCC 4.8.4, against OpenSSL version is 1.0.1f-1ubuntu2.22 if it helps. The specific error was: ``` [ 45%] Building C object thirdparty/civetweb-1.9.1/src/CMakeFiles/c-library.dir/civetweb.c.o /home/ubuntu/workspace/thirdparty/civetweb-1.9.1/src/civetweb.c: In function ‘ssl_get_client_cert_info’: /home/ubuntu/workspace/thirdparty/civetweb-1.9.1/src/civetweb.c:11873:4: error: implicit declaration of function ‘EVP_Digest’ [-Wimplicit-function-declaration] if (!EVP_Digest( ^ make[2]: *** [thirdparty/civetweb-1.9.1/src/CMakeFiles/c-library.dir/civetweb.c.o] Error 1 ``` > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184049#comment-16184049 ] ASF GitHub Bot commented on MINIFI-388: --- Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/131 @calebj Thanks. I know some of us build with Ubuntu 14 and have run into similar issues. If you submit a PR I'll spin up an instance, verify, and can merge. Thanks! > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184055#comment-16184055 ] ASF GitHub Bot commented on MINIFI-388: --- GitHub user calebj opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/139 MINIFI-388 Backport the rest of EVP_Digest for civetweb As per the discussion in apache/nifi-minifi-cpp#131. This is a backport of the `#define` declaration of `EVP_Digest()` and the matching entry in `crypto_sw` from civetweb/civetweb@fb9ef36. Without this patch, minifi fails to build on Ubuntu 14.04 with GCC 4.8.4, against OpenSSL version is 1.0.1f-1ubuntu2.22, with: ``` [ 45%] Building C object thirdparty/civetweb-1.9.1/src/CMakeFiles/c-library.dir/civetweb.c.o /home/ubuntu/workspace/thirdparty/civetweb-1.9.1/src/civetweb.c: In function ‘ssl_get_client_cert_info’: /home/ubuntu/workspace/thirdparty/civetweb-1.9.1/src/civetweb.c:11873:4: error: implicit declaration of function ‘EVP_Digest’ [-Wimplicit-function-declaration] if (!EVP_Digest( ^ make[2]: *** [thirdparty/civetweb-1.9.1/src/CMakeFiles/c-library.dir/civetweb.c.o] Error 1 ``` Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/NiFiLocal/nifi-minifi-cpp civet_evp_digest_backport Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/139.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #139 commit 66dc8f039ca0fa1af362c11a5bcc43475456bc74 Author: Caleb Johnson Date: 2017-09-28T11:25:18Z MINIFI-388 Backport the rest of EVP_Digest for civetweb > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184251#comment-16184251 ] ASF subversion and git services commented on MINIFI-388: Commit aaeb929b289f5c5f9a10811c37a183f2783e93e1 in nifi-minifi-cpp's branch refs/heads/master from [~calebj] [ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=aaeb929 ] MINIFI-388 Backport the rest of EVP_Digest for civetweb This closes #139. Signed-off-by: Marc Parisi > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)
[ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184253#comment-16184253 ] ASF GitHub Bot commented on MINIFI-388: --- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/139 > MiNiFi core on startup if TLS is used with ListenHTTP (civet) > - > > Key: MINIFI-388 > URL: https://issues.apache.org/jira/browse/MINIFI-388 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Docker >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > MiNiFi cpp core dumps on startup because civet attempts to load > libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, > /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib > paths to the non-versioned paths. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
