[jira] [Commented] (MINIFI-60) Remove clean up default minifi-resources

2016-10-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/MINIFI-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602178#comment-15602178
 ] 

ASF GitHub Bot commented on MINIFI-60:
--

GitHub user apiri opened a pull request:

https://github.com/apache/nifi-minifi/pull/48

MINIFI-60 Removing unused configuration files in minifi-resources.

Thank you for submitting a contribution to Apache NiFi - MiNiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ x] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [x ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x ] Is your initial contribution a single, squashed commit?

### For code changes:
- [x ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi-minifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under minifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under minifi-assembly?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apiri/nifi-minifi MINIFI-60

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #48


commit e4d91c8d5c55e2501a32ca83a4b5d581e736e248
Author: Aldrin Piri 
Date:   2016-10-24T14:32:08Z

MINIFI-60 Removing unused configuration files in minifi-resources.




> Remove clean up default minifi-resources 
> -
>
> Key: MINIFI-60
> URL: https://issues.apache.org/jira/browse/MINIFI-60
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>Affects Versions: 0.0.1
>Reporter: Joseph Percivall
>Assignee: Aldrin Piri
>Priority: Minor
> Fix For: 0.1.0
>
>
> In the minifi-resources module there are a number of files that are either 
> not used at all or replaced when the service starts (nifi.properties and 
> flow.xml.gz). The erroneous files should be removed.
> https://github.com/apache/nifi-minifi/tree/master/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/conf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MINIFI-60) Remove clean up default minifi-resources

2016-10-24 Thread Aldrin Piri (JIRA) 

[ 
https://issues.apache.org/jira/browse/MINIFI-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602165#comment-15602165
 ] 

Aldrin Piri commented on MINIFI-60:
---

5 files were eligible to be removed.
authority-providers.xml, authorized-users.xml, login-identity-providers.xml, 
nifi.properties, & zookeeper.properties

state-management.xml is also a target eventually but depends upon refactoring 
of the FlowController.

> Remove clean up default minifi-resources 
> -
>
> Key: MINIFI-60
> URL: https://issues.apache.org/jira/browse/MINIFI-60
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>Affects Versions: 0.0.1
>Reporter: Joseph Percivall
>Assignee: Aldrin Piri
>Priority: Minor
> Fix For: 0.1.0
>
>
> In the minifi-resources module there are a number of files that are either 
> not used at all or replaced when the service starts (nifi.properties and 
> flow.xml.gz). The erroneous files should be removed.
> https://github.com/apache/nifi-minifi/tree/master/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/conf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)