[jira] [Commented] (MINIFI-81) Adjust usage information for minifi-toolkit executable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523369#comment-15523369
 ] 

ASF GitHub Bot commented on MINIFI-81:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi/pull/39


> Adjust usage information for minifi-toolkit executable
> --
>
> Key: MINIFI-81
> URL: https://issues.apache.org/jira/browse/MINIFI-81
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: utilities
>Affects Versions: 0.0.1
>Reporter: Aldrin Piri
>Assignee: Joseph Percivall
>Priority: Minor
> Fix For: 0.1.0
>
>
> Currently the usage information is derived from the underlying Java class.  
> This is more verbose than needed and should be handled by the wrapping script 
> invoking that command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MINIFI-81) Adjust usage information for minifi-toolkit executable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523362#comment-15523362
 ] 

ASF GitHub Bot commented on MINIFI-81:
--

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/39#discussion_r80500315
  
--- Diff: 
minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java
 ---
@@ -85,8 +85,6 @@ public static void main(String[] args) {
 public static void printValidateUsage() {
 System.out.println("Validate Usage:");
 System.out.println();
-System.out.print("java ");
--- End diff --

fair enough, will merge 


> Adjust usage information for minifi-toolkit executable
> --
>
> Key: MINIFI-81
> URL: https://issues.apache.org/jira/browse/MINIFI-81
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: utilities
>Affects Versions: 0.0.1
>Reporter: Aldrin Piri
>Assignee: Joseph Percivall
>Priority: Minor
> Fix For: 0.1.0
>
>
> Currently the usage information is derived from the underlying Java class.  
> This is more verbose than needed and should be handled by the wrapping script 
> invoking that command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MINIFI-81) Adjust usage information for minifi-toolkit executable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523236#comment-15523236
 ] 

ASF GitHub Bot commented on MINIFI-81:
--

Github user JPercivall commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/39#discussion_r80488336
  
--- Diff: 
minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java
 ---
@@ -85,8 +85,6 @@ public static void main(String[] args) {
 public static void printValidateUsage() {
 System.out.println("Validate Usage:");
 System.out.println();
-System.out.print("java ");
--- End diff --

Hey @apiri, I chose to remove them because they can lead to very confusing 
errors messages for user who ran it using the scripts. If they happen to 
mis-type a file location not only would they see the error saying the file 
doesn't exist but also this "java  ..." line that was quite 
confusing.

Also, I see this being run using the script in >99% of the cases.


> Adjust usage information for minifi-toolkit executable
> --
>
> Key: MINIFI-81
> URL: https://issues.apache.org/jira/browse/MINIFI-81
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: utilities
>Affects Versions: 0.0.1
>Reporter: Aldrin Piri
>Assignee: Joseph Percivall
>Priority: Minor
> Fix For: 0.1.0
>
>
> Currently the usage information is derived from the underlying Java class.  
> This is more verbose than needed and should be handled by the wrapping script 
> invoking that command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MINIFI-81) Adjust usage information for minifi-toolkit executable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517672#comment-15517672
 ] 

ASF GitHub Bot commented on MINIFI-81:
--

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/39#discussion_r80333632
  
--- Diff: 
minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java
 ---
@@ -85,8 +85,6 @@ public static void main(String[] args) {
 public static void printValidateUsage() {
 System.out.println("Validate Usage:");
 System.out.println();
-System.out.print("java ");
--- End diff --

Should this and the other java invocation remain given that the 
interpretation of arguments is handled by the script when invoked from the 
script?  This is valid in the context the class is run by itself.


> Adjust usage information for minifi-toolkit executable
> --
>
> Key: MINIFI-81
> URL: https://issues.apache.org/jira/browse/MINIFI-81
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: utilities
>Affects Versions: 0.0.1
>Reporter: Aldrin Piri
>Assignee: Joseph Percivall
>Priority: Minor
> Fix For: 0.1.0
>
>
> Currently the usage information is derived from the underlying Java class.  
> This is more verbose than needed and should be handled by the wrapping script 
> invoking that command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MINIFI-81) Adjust usage information for minifi-toolkit executable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFI-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516721#comment-15516721
 ] 

ASF GitHub Bot commented on MINIFI-81:
--

GitHub user JPercivall opened a pull request:

https://github.com/apache/nifi-minifi/pull/39

MINIFI-81 Adding a check for a valid command to the config.sh toolkit…

… script

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JPercivall/nifi-minifi MINIFI-81

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #39


commit 189a5ee21012a5b0c67ecc6a29dd91df6615a1d9
Author: Joseph Percivall 
Date:   2016-09-23T15:11:41Z

MINIFI-81 Adding a check for a valid command to the config.sh toolkit script




> Adjust usage information for minifi-toolkit executable
> --
>
> Key: MINIFI-81
> URL: https://issues.apache.org/jira/browse/MINIFI-81
> Project: Apache NiFi MiNiFi
>  Issue Type: Improvement
>  Components: utilities
>Affects Versions: 0.0.1
>Reporter: Aldrin Piri
>Assignee: Joseph Percivall
>Priority: Minor
> Fix For: 0.1.0
>
>
> Currently the usage information is derived from the underlying Java class.  
> This is more verbose than needed and should be handled by the wrapping script 
> invoking that command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)