[jira] [Commented] (NIFI-1984) Deleting processor with incoming flow causes NiFi to stop responding
[ https://issues.apache.org/jira/browse/NIFI-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320450#comment-15320450 ] Mark Payne commented on NIFI-1984: -- I logged into JIRA just to create this ticket and then saw you beat me to it! Looking at this now. > Deleting processor with incoming flow causes NiFi to stop responding > > > Key: NIFI-1984 > URL: https://issues.apache.org/jira/browse/NIFI-1984 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Cole Mackenzie >Assignee: Mark Payne > Fix For: 1.0.0 > > > Attempting to delete a processor with an incoming flow produces a warning > stating it is not possible, then causes the webui to hang, requiring restart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-1984) Deleting processor with incoming flow causes NiFi to stop responding
[ https://issues.apache.org/jira/browse/NIFI-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320501#comment-15320501 ] ASF GitHub Bot commented on NIFI-1984: -- GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/510 NIFI-1984: Ensure that locks are always cleaned up by NaiveRevisionManager Ensure that if an Exception is thrown by the 'Deletion Task' when calling NaiveRevisionManager.deleteRevision() that the locking is appropriately cleaned up. Looking through the code, there do not appear to be any other places where we invoke callbacks without handling appropriate with a try/finally or try/catch block. You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi NIFI-1984 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/510.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #510 commit 1d46b5431bf2eca0298d2f2fdc9854ef3f9fedfa Author: Mark Payne Date: 2016-06-08T12:57:37Z NIFI-1984: Ensure that if an Exception is thrown by the 'Deletion Task' when calling NaiveRevisionManager.deleteRevision() that the locking is appropriately cleaned up > Deleting processor with incoming flow causes NiFi to stop responding > > > Key: NIFI-1984 > URL: https://issues.apache.org/jira/browse/NIFI-1984 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Cole Mackenzie >Assignee: Mark Payne >Priority: Blocker > Fix For: 1.0.0 > > > Attempting to delete a processor with an incoming flow produces a warning > stating it is not possible, then causes the webui to hang, requiring restart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-1984) Deleting processor with incoming flow causes NiFi to stop responding
[ https://issues.apache.org/jira/browse/NIFI-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320636#comment-15320636 ] ASF GitHub Bot commented on NIFI-1984: -- Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/510 +1 LGTM, built and ran tests, also started NiFi and tried various delete operations including an attempt to delete a processor that had an incoming connection. All behavior was as expected > Deleting processor with incoming flow causes NiFi to stop responding > > > Key: NIFI-1984 > URL: https://issues.apache.org/jira/browse/NIFI-1984 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Cole Mackenzie >Assignee: Mark Payne >Priority: Blocker > Fix For: 1.0.0 > > > Attempting to delete a processor with an incoming flow produces a warning > stating it is not possible, then causes the webui to hang, requiring restart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-1984) Deleting processor with incoming flow causes NiFi to stop responding
[ https://issues.apache.org/jira/browse/NIFI-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320640#comment-15320640 ] ASF subversion and git services commented on NIFI-1984: --- Commit 18133988a02d80180ee55b91bc5b80807ec9f3de in nifi's branch refs/heads/master from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=1813398 ] NIFI-1984: Ensure that if an Exception is thrown by the 'Deletion Task' when calling NaiveRevisionManager.deleteRevision() that the locking is appropriately cleaned up This closes #510 > Deleting processor with incoming flow causes NiFi to stop responding > > > Key: NIFI-1984 > URL: https://issues.apache.org/jira/browse/NIFI-1984 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Cole Mackenzie >Assignee: Mark Payne >Priority: Blocker > Fix For: 1.0.0 > > > Attempting to delete a processor with an incoming flow produces a warning > stating it is not possible, then causes the webui to hang, requiring restart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-1984) Deleting processor with incoming flow causes NiFi to stop responding
[ https://issues.apache.org/jira/browse/NIFI-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320642#comment-15320642 ] ASF GitHub Bot commented on NIFI-1984: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/510 > Deleting processor with incoming flow causes NiFi to stop responding > > > Key: NIFI-1984 > URL: https://issues.apache.org/jira/browse/NIFI-1984 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Cole Mackenzie >Assignee: Mark Payne >Priority: Blocker > Fix For: 1.0.0 > > > Attempting to delete a processor with an incoming flow produces a warning > stating it is not possible, then causes the webui to hang, requiring restart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
