[jira] [Commented] (NIFI-2006) Null attribute values causing NPEs in provenance repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330261#comment-15330261
 ] 

ASF GitHub Bot commented on NIFI-2006:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/528


> Null attribute values causing NPEs in provenance repo
> -
>
> Key: NIFI-2006
> URL: https://issues.apache.org/jira/browse/NIFI-2006
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Brandon DeVries
>Assignee: Oleg Zhurakousky
>Priority: Critical
> Fix For: 1.0.0, 0.7.0
>
>
> A null attribute value (as you would see for a removed attribute) causes the 
> provenance repo to thrown an NPE here:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1789
> (as "entry.getValue()" is null...)
> suggested fix is to change:
> {code}
> if (entry.getValue().length() > maxAttributeChars) {
> {code}
> to:
> {code}
> if (entry.getValue() != null && entry.getValue().length() > 
> maxAttributeChars) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2006) Null attribute values causing NPEs in provenance repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330207#comment-15330207
 ] 

ASF GitHub Bot commented on NIFI-2006:
--

Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/528
  
+1

Fixes problem and adds unit test check (which properly fails without the 
fix). I will merge it into 0.x and master. Thanks @olegz 


> Null attribute values causing NPEs in provenance repo
> -
>
> Key: NIFI-2006
> URL: https://issues.apache.org/jira/browse/NIFI-2006
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Brandon DeVries
>Assignee: Oleg Zhurakousky
>Priority: Critical
> Fix For: 1.0.0, 0.7.0
>
>
> A null attribute value (as you would see for a removed attribute) causes the 
> provenance repo to thrown an NPE here:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1789
> (as "entry.getValue()" is null...)
> suggested fix is to change:
> {code}
> if (entry.getValue().length() > maxAttributeChars) {
> {code}
> to:
> {code}
> if (entry.getValue() != null && entry.getValue().length() > 
> maxAttributeChars) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2006) Null attribute values causing NPEs in provenance repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329677#comment-15329677
 ] 

ASF GitHub Bot commented on NIFI-2006:
--

GitHub user olegz opened a pull request:

https://github.com/apache/nifi/pull/528

NIFI-2006 fixed NPE in PersistentProvenanceRepository

Fixed NPE in PersistentProvenanceRepository caused by attribute value being 
null
added test

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/olegz/nifi NIFI-2006

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #528


commit ae20d6831af0db886e2e9bce7249b04729152594
Author: Oleg Zhurakousky 
Date:   2016-06-14T15:35:25Z

NIFI-2006 fixed NPE in PersistentProvenanceRepository
Fixed NPE in PersistentProvenanceRepository caused by attribute value being 
null
added test




> Null attribute values causing NPEs in provenance repo
> -
>
> Key: NIFI-2006
> URL: https://issues.apache.org/jira/browse/NIFI-2006
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Brandon DeVries
>Assignee: Oleg Zhurakousky
>Priority: Critical
> Fix For: 1.0.0, 0.7.0
>
>
> A null attribute value (as you would see for a removed attribute) causes the 
> provenance repo to thrown an NPE here:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1789
> (as "entry.getValue()" is null...)
> suggested fix is to change:
> {code}
> if (entry.getValue().length() > maxAttributeChars) {
> {code}
> to:
> {code}
> if (entry.getValue() != null && entry.getValue().length() > 
> maxAttributeChars) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2006) Null attribute values causing NPEs in provenance repo

[Oleg Zhurakousky (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329668#comment-15329668
 ] 

Oleg Zhurakousky commented on NIFI-2006:


Yeah, somehow I've mixed two things in my head. I just can't remember why I was 
looking a the same code snippet as in Brandon's JIRA while I was investigating 
yours. Anyway, I'll re-open NIFI-2015

> Null attribute values causing NPEs in provenance repo
> -
>
> Key: NIFI-2006
> URL: https://issues.apache.org/jira/browse/NIFI-2006
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Brandon DeVries
>Assignee: Oleg Zhurakousky
>Priority: Critical
> Fix For: 1.0.0, 0.7.0
>
>
> A null attribute value (as you would see for a removed attribute) causes the 
> provenance repo to thrown an NPE here:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1789
> (as "entry.getValue()" is null...)
> suggested fix is to change:
> {code}
> if (entry.getValue().length() > maxAttributeChars) {
> {code}
> to:
> {code}
> if (entry.getValue() != null && entry.getValue().length() > 
> maxAttributeChars) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2006) Null attribute values causing NPEs in provenance repo

[Brandon DeVries (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329661#comment-15329661
 ] 

Brandon DeVries commented on NIFI-2006:
---

I agree if this turns out to be the same issue, fantastic.  But I don't see 
any reason to assume that is the case.  I'm going to reopen NIFI-2015.  If this 
fix covers that as well we'll count it as a twofer, but we don't want to lose 
track of the issue if that's not the case.

> Null attribute values causing NPEs in provenance repo
> -
>
> Key: NIFI-2006
> URL: https://issues.apache.org/jira/browse/NIFI-2006
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Brandon DeVries
>Assignee: Oleg Zhurakousky
>Priority: Critical
> Fix For: 1.0.0, 0.7.0
>
>
> A null attribute value (as you would see for a removed attribute) causes the 
> provenance repo to thrown an NPE here:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1789
> (as "entry.getValue()" is null...)
> suggested fix is to change:
> {code}
> if (entry.getValue().length() > maxAttributeChars) {
> {code}
> to:
> {code}
> if (entry.getValue() != null && entry.getValue().length() > 
> maxAttributeChars) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2006) Null attribute values causing NPEs in provenance repo

[Oleg Zhurakousky (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329659#comment-15329659
 ] 

Oleg Zhurakousky commented on NIFI-2006:


I am now coming to this realization myself ;), stay tuned

> Null attribute values causing NPEs in provenance repo
> -
>
> Key: NIFI-2006
> URL: https://issues.apache.org/jira/browse/NIFI-2006
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Brandon DeVries
>Assignee: Oleg Zhurakousky
>Priority: Critical
> Fix For: 1.0.0, 0.7.0
>
>
> A null attribute value (as you would see for a removed attribute) causes the 
> provenance repo to thrown an NPE here:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1789
> (as "entry.getValue()" is null...)
> suggested fix is to change:
> {code}
> if (entry.getValue().length() > maxAttributeChars) {
> {code}
> to:
> {code}
> if (entry.getValue() != null && entry.getValue().length() > 
> maxAttributeChars) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2006) Null attribute values causing NPEs in provenance repo

[Christopher McDermott (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329633#comment-15329633
 ] 

Christopher McDermott commented on NIFI-2006:
-

[~ozhurakousky], I don't believe that this is the same issue as NIFI-2015.  
There is no NPE in that case rather it raises an ISE when checking for the 
FlowFile UUID.  Maybe the fix is the same but on the surface it seems quite 
different.

> Null attribute values causing NPEs in provenance repo
> -
>
> Key: NIFI-2006
> URL: https://issues.apache.org/jira/browse/NIFI-2006
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Brandon DeVries
>Assignee: Oleg Zhurakousky
>Priority: Critical
> Fix For: 1.0.0, 0.7.0
>
>
> A null attribute value (as you would see for a removed attribute) causes the 
> provenance repo to thrown an NPE here:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1789
> (as "entry.getValue()" is null...)
> suggested fix is to change:
> {code}
> if (entry.getValue().length() > maxAttributeChars) {
> {code}
> to:
> {code}
> if (entry.getValue() != null && entry.getValue().length() > 
> maxAttributeChars) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2006) Null attribute values causing NPEs in provenance repo

[Oleg Zhurakousky (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329602#comment-15329602
 ] 

Oleg Zhurakousky commented on NIFI-2006:


The issue was originally reported by a community member 
([~ch...@mcdermott.net]) on the dev list yesterday with me suggesting to raise 
a JIRA which he did as NIFI-2015 albeit a bit late. So I am addressing it now 
and will mark NIFI-2015 as duplicate.

> Null attribute values causing NPEs in provenance repo
> -
>
> Key: NIFI-2006
> URL: https://issues.apache.org/jira/browse/NIFI-2006
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Brandon DeVries
>Priority: Critical
> Fix For: 1.0.0, 0.7.0
>
>
> A null attribute value (as you would see for a removed attribute) causes the 
> provenance repo to thrown an NPE here:
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1789
> (as "entry.getValue()" is null...)
> suggested fix is to change:
> {code}
> if (entry.getValue().length() > maxAttributeChars) {
> {code}
> to:
> {code}
> if (entry.getValue() != null && entry.getValue().length() > 
> maxAttributeChars) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)