[jira] [Updated] (NIFI-604) ExecuteStreamCommand does not support arguments with semicolons
[
https://issues.apache.org/jira/browse/NIFI-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-604:
Fix Version/s: (was: 0.2.0)
0.3.0
ExecuteStreamCommand does not support arguments with semicolons
Key: NIFI-604
URL: https://issues.apache.org/jira/browse/NIFI-604
Project: Apache NiFi
Issue Type: Bug
Affects Versions: 0.1.0
Reporter: Ricky Saltzer
Assignee: Mark Payne
Fix For: 0.3.0
Attachments: NIFI-604.1.patch, NIFI-604.2.patch
The following code in ExecuteStreamCommand assumes you're not passing
semicolons within your argument. This is a problem for people who need to
pass semicolons to the executing program as part of the argument.
{code}
224for (String arg : commandArguments.split(;)) {
{code}
To allow for escaped semicolons, I propose we change this to the following
regex.
{code}
224for (String arg : commandArguments.split([^\\];)) {
{code}
*or*... could we just change the way arguments are passed to make it more
similar to how ExecuteCommand works? The whole semicolon per argument took
some getting used to, and doesn't seem very intuitive.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (NIFI-732) GetKafka if stopped then started doesn't resume pulling messages
[ https://issues.apache.org/jira/browse/NIFI-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-732: Fix Version/s: (was: 0.2.0) 0.3.0 GetKafka if stopped then started doesn't resume pulling messages Key: NIFI-732 URL: https://issues.apache.org/jira/browse/NIFI-732 Project: Apache NiFi Issue Type: Bug Components: Extensions Environment: linux Reporter: Joseph Witt Assignee: Mark Payne Fix For: 0.3.0 A nifi user reported that they had to restart nifi to get the GetKafka processor to resume pulling data once they had stopped the processor. Upon restarting it showed that it was started but did not resume pulling data. Need to attempt to reproduce and resolve. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-740) StandardFlowServiceTest need to be updated.
[
https://issues.apache.org/jira/browse/NIFI-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615566#comment-14615566
]
Mark Payne commented on NIFI-740:
-
Toivo,
I agree, it makes sense to remove the header in this case. You may need to
update the module's pom.xml in order to add it to the RAT exclusions. Please
verify that things work by running mvn clean install -Pcontrib-check on that
module.
Thanks
-Mark
StandardFlowServiceTest need to be updated.
---
Key: NIFI-740
URL: https://issues.apache.org/jira/browse/NIFI-740
Project: Apache NiFi
Issue Type: Bug
Components: Core Framework
Reporter: Toivo Adams
Assignee: Toivo Adams
Priority: Minor
Fix For: 0.3.0
Currently
/nifi-framework-core/src/test/java/org/apache/nifi/controller/StandardFlowServiceTest.java
:
[Error] :22:16: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{comment}' is expected.
[Error] :28:20: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{styles}' is expected.
[Error] :46:20: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{styles}' is expected.
[Error] :69:20: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{comments}' is expected.
[Error] :75:20: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{comments}' is expected.
[Error] :80:20: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{size}' is expected.
[Error] :87:20: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{comment}' is expected.
[Error] :93:24: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{styles}' is expected.
[Error] :112:24: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{comments}' is expected.
[Error] :118:24: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{comments}' is expected.
[Error] :126:25: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{sourceId}' is expected.
[Error] :142:20: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{comment}' is expected.
[Error] :152:21: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{sourceId}' is expected.
[Error] :169:21: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{sourceId}' is expected.
[Error] :186:21: cvc-complex-type.2.4.a: Invalid content was found starting
with element 'style'. One of '{sourceId}' is expected.
And finally public void testLoadExistingFlow() test fails:
org.apache.nifi.controller.FlowSynchronizationException:
java.lang.NullPointerException: Name is null
at
org.apache.nifi.controller.StandardFlowSynchronizer.sync(StandardFlowSynchronizer.java:317)
at
org.apache.nifi.controller.FlowController.synchronize(FlowController.java:1154)
at
org.apache.nifi.persistence.StandardXMLFlowConfigurationDAO.load(StandardXMLFlowConfigurationDAO.java:72)
at
org.apache.nifi.controller.StandardFlowService.loadFromBytes(StandardFlowService.java:608)
at
org.apache.nifi.controller.StandardFlowService.load(StandardFlowService.java:458)
at
org.apache.nifi.controller.StandardFlowServiceTest.testLoadExistingFlow(StandardFlowServiceTest.java:98)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at
[jira] [Commented] (NIFI-679) InvokeHTTP - Add support for basic authentication
[ https://issues.apache.org/jira/browse/NIFI-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615496#comment-14615496 ] Matt Gilman commented on NIFI-679: -- There is no existing guide for source format outside of checkstyle which is configured in the parent pom [1]. You can verify your contribution is compliant by running the contrib-check profile [2]. This however does not do anything for verifying local mutability. That is something we try to do, but there are certainly cases where that is missing throughout the codebase. Generally, we would suggest creating a new ticket if focusing on cleaning up a portion of code. What likely happened in this instance is that an IDE was configured to automatically format and make checkstyle-type modifications and those were included into a patch with another functional change. [1] https://github.com/apache/incubator-nifi/blob/develop/nifi-parent/pom.xml#L260 [2] https://github.com/apache/incubator-nifi/blob/develop/nifi-parent/pom.xml#L380 InvokeHTTP - Add support for basic authentication - Key: NIFI-679 URL: https://issues.apache.org/jira/browse/NIFI-679 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: Matt Gilman Priority: Minor Fix For: 0.2.0 Attachments: nifi-679.patch InvokeHTTP should optionally support username/password for web services that do not employ certificate based authentication. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[1/4] incubator-nifi git commit: NIFI-735: DocGenerator should on @OnUnscheduled and @OnStopped after its done generating the docs
Repository: incubator-nifi
Updated Branches:
refs/heads/develop 0d2842e4f - 9fa03b432
NIFI-735: DocGenerator should on @OnUnscheduled and @OnStopped after its done
generating the docs
Project: http://git-wip-us.apache.org/repos/asf/incubator-nifi/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-nifi/commit/bd9782cb
Tree: http://git-wip-us.apache.org/repos/asf/incubator-nifi/tree/bd9782cb
Diff: http://git-wip-us.apache.org/repos/asf/incubator-nifi/diff/bd9782cb
Branch: refs/heads/develop
Commit: bd9782cb43ece682c853d9a75279ebe76f968044
Parents: e35f348
Author: danbress dbr...@onyxconsults.com
Authored: Sat Jun 27 14:38:45 2015 -0400
Committer: danbress dbr...@onyxconsults.com
Committed: Sat Jun 27 14:38:45 2015 -0400
--
.../documentation/ConfigurableComponentInitializer.java | 9 -
.../java/org/apache/nifi/documentation/DocGenerator.java | 2 ++
.../documentation/init/ControllerServiceInitializer.java | 11 +--
.../nifi/documentation/init/ProcessorInitializer.java| 11 +--
.../documentation/init/ReportingTaskingInitializer.java | 11 +--
.../documentation/html/HtmlDocumentationWriterTest.java | 2 ++
.../html/ProcessorDocumentationWriterTest.java | 3 +++
7 files changed, 42 insertions(+), 7 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/incubator-nifi/blob/bd9782cb/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/ConfigurableComponentInitializer.java
--
diff --git
a/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/ConfigurableComponentInitializer.java
b/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/ConfigurableComponentInitializer.java
index bd07ab5..ad21f21 100644
---
a/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/ConfigurableComponentInitializer.java
+++
b/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/ConfigurableComponentInitializer.java
@@ -20,7 +20,7 @@ import org.apache.nifi.components.ConfigurableComponent;
import org.apache.nifi.reporting.InitializationException;
/**
- * An interface for initializing a ConfigurableComponent. It is up to the
+ * An interface for initializing and tearing down a ConfigurableComponent. It
is up to the
* implementer to call init so that you can call
* ConfigurableComponent.getPropertyDescriptors()
*
@@ -35,4 +35,11 @@ public interface ConfigurableComponentInitializer {
* @throws InitializationException if the component could not be
initialized
*/
void initialize(ConfigurableComponent component) throws
InitializationException;
+
+/**
+ * Calls the lifecycle methods that should be called when a flow is
shutdown.
+ *
+ * @param component the component to initialize
+ */
+void teardown(ConfigurableComponent component);
}
http://git-wip-us.apache.org/repos/asf/incubator-nifi/blob/bd9782cb/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/DocGenerator.java
--
diff --git
a/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/DocGenerator.java
b/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/DocGenerator.java
index 7c32bf8..327da04 100644
---
a/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/DocGenerator.java
+++
b/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/DocGenerator.java
@@ -114,6 +114,8 @@ public class DocGenerator {
try (final OutputStream output = new BufferedOutputStream(new
FileOutputStream(baseDocumenationFile))) {
writer.write(component, output, hasAdditionalInfo(directory));
}
+
+initializer.teardown(component);
}
/**
http://git-wip-us.apache.org/repos/asf/incubator-nifi/blob/bd9782cb/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/init/ControllerServiceInitializer.java
--
diff --git
[3/4] incubator-nifi git commit: NIFI-735: removing call to OnRemoved and updating unit tests
NIFI-735: removing call to OnRemoved and updating unit tests
Project: http://git-wip-us.apache.org/repos/asf/incubator-nifi/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-nifi/commit/c769742d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-nifi/tree/c769742d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-nifi/diff/c769742d
Branch: refs/heads/develop
Commit: c769742d9b10145c26a0b6cd75b9ae75bbdc9589
Parents: 9354676
Author: danbress dbr...@onyxconsults.com
Authored: Sun Jun 28 16:42:52 2015 -0400
Committer: danbress dbr...@onyxconsults.com
Committed: Sun Jun 28 16:42:52 2015 -0400
--
.../documentation/init/ControllerServiceInitializer.java | 2 --
.../apache/nifi/documentation/init/ProcessorInitializer.java | 2 --
.../nifi/documentation/init/ReportingTaskingInitializer.java | 2 --
.../nifi/documentation/html/HtmlDocumentationWriterTest.java | 8
.../documentation/html/ProcessorDocumentationWriterTest.java | 4 ++--
5 files changed, 6 insertions(+), 12 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/incubator-nifi/blob/c769742d/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/init/ControllerServiceInitializer.java
--
diff --git
a/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/init/ControllerServiceInitializer.java
b/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/init/ControllerServiceInitializer.java
index 7839254..441033c 100644
---
a/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/init/ControllerServiceInitializer.java
+++
b/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/init/ControllerServiceInitializer.java
@@ -16,7 +16,6 @@
*/
package org.apache.nifi.documentation.init;
-import org.apache.nifi.annotation.lifecycle.OnRemoved;
import org.apache.nifi.annotation.lifecycle.OnShutdown;
import org.apache.nifi.components.ConfigurableComponent;
import org.apache.nifi.controller.ControllerService;
@@ -52,7 +51,6 @@ public class ControllerServiceInitializer implements
ConfigurableComponentInitia
final ProcessorLog logger = new MockProcessorLogger();
final MockConfigurationContext context = new
MockConfigurationContext();
-
ReflectionUtils.quietlyInvokeMethodsWithAnnotations(OnRemoved.class,
org.apache.nifi.processor.annotation.OnRemoved.class, controllerService,
logger, context);
ReflectionUtils.quietlyInvokeMethodsWithAnnotations(OnShutdown.class,
org.apache.nifi.processor.annotation.OnShutdown.class, controllerService,
logger, context);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-nifi/blob/c769742d/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/init/ProcessorInitializer.java
--
diff --git
a/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/init/ProcessorInitializer.java
b/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/init/ProcessorInitializer.java
index 5808c35..7a0752d 100644
---
a/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/init/ProcessorInitializer.java
+++
b/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/init/ProcessorInitializer.java
@@ -16,7 +16,6 @@
*/
package org.apache.nifi.documentation.init;
-import org.apache.nifi.annotation.lifecycle.OnRemoved;
import org.apache.nifi.annotation.lifecycle.OnShutdown;
import org.apache.nifi.components.ConfigurableComponent;
import org.apache.nifi.documentation.ConfigurableComponentInitializer;
@@ -50,7 +49,6 @@ public class ProcessorInitializer implements
ConfigurableComponentInitializer {
final ProcessorLog logger = new MockProcessorLogger();
final MockProcessContext context = new MockProcessContext();
-
ReflectionUtils.quietlyInvokeMethodsWithAnnotations(OnRemoved.class,
org.apache.nifi.processor.annotation.OnRemoved.class, processor, logger,
context);
ReflectionUtils.quietlyInvokeMethodsWithAnnotations(OnShutdown.class,
org.apache.nifi.processor.annotation.OnShutdown.class, processor, logger,
context);
}
}
[jira] [Commented] (NIFI-735) DocGenerator should call @OnShutdown after its done generating the docs
[ https://issues.apache.org/jira/browse/NIFI-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616088#comment-14616088 ] ASF subversion and git services commented on NIFI-735: -- Commit bd9782cb43ece682c853d9a75279ebe76f968044 in incubator-nifi's branch refs/heads/develop from [~danbress] [ https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;h=bd9782c ] NIFI-735: DocGenerator should on @OnUnscheduled and @OnStopped after its done generating the docs DocGenerator should call @OnShutdown after its done generating the docs --- Key: NIFI-735 URL: https://issues.apache.org/jira/browse/NIFI-735 Project: Apache NiFi Issue Type: Bug Components: Core Framework Affects Versions: 0.1.0 Reporter: Dan Bress Assignee: Dan Bress Fix For: 0.2.0 Attachments: 0001-Squashed-commit-of-the-following.patch Per [~mcgilman] +0 for triggering OnRemoved and OnShutdown after initialization and before being done with instance +0 for triggering OnRemoved and OnShutdown and not their deprecated counterparts Change code to call annotations *after* the documentation has been generated for that component. Also invoke both the new annotations and the deprecated annotations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-735) DocGenerator should call @OnShutdown after its done generating the docs
[ https://issues.apache.org/jira/browse/NIFI-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616089#comment-14616089 ] ASF subversion and git services commented on NIFI-735: -- Commit 93546760be2223f40215a0aeb9614dbb9bdb148f in incubator-nifi's branch refs/heads/develop from [~danbress] [ https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;h=9354676 ] Merge branch 'develop' into NIFI-735 DocGenerator should call @OnShutdown after its done generating the docs --- Key: NIFI-735 URL: https://issues.apache.org/jira/browse/NIFI-735 Project: Apache NiFi Issue Type: Bug Components: Core Framework Affects Versions: 0.1.0 Reporter: Dan Bress Assignee: Dan Bress Fix For: 0.2.0 Attachments: 0001-Squashed-commit-of-the-following.patch Per [~mcgilman] +0 for triggering OnRemoved and OnShutdown after initialization and before being done with instance +0 for triggering OnRemoved and OnShutdown and not their deprecated counterparts Change code to call annotations *after* the documentation has been generated for that component. Also invoke both the new annotations and the deprecated annotations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-735) DocGenerator should call @OnShutdown after its done generating the docs
[ https://issues.apache.org/jira/browse/NIFI-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616090#comment-14616090 ] ASF subversion and git services commented on NIFI-735: -- Commit c769742d9b10145c26a0b6cd75b9ae75bbdc9589 in incubator-nifi's branch refs/heads/develop from [~danbress] [ https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;h=c769742 ] NIFI-735: removing call to OnRemoved and updating unit tests DocGenerator should call @OnShutdown after its done generating the docs --- Key: NIFI-735 URL: https://issues.apache.org/jira/browse/NIFI-735 Project: Apache NiFi Issue Type: Bug Components: Core Framework Affects Versions: 0.1.0 Reporter: Dan Bress Assignee: Dan Bress Fix For: 0.2.0 Attachments: 0001-Squashed-commit-of-the-following.patch Per [~mcgilman] +0 for triggering OnRemoved and OnShutdown after initialization and before being done with instance +0 for triggering OnRemoved and OnShutdown and not their deprecated counterparts Change code to call annotations *after* the documentation has been generated for that component. Also invoke both the new annotations and the deprecated annotations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-735) DocGenerator should call @OnShutdown after its done generating the docs
[ https://issues.apache.org/jira/browse/NIFI-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616091#comment-14616091 ] ASF subversion and git services commented on NIFI-735: -- Commit 9fa03b43245cfba27fe084ac46b44f39856dbcbb in incubator-nifi's branch refs/heads/develop from [~danbress] [ https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;h=9fa03b4 ] Merge branch 'NIFI-735' into develop DocGenerator should call @OnShutdown after its done generating the docs --- Key: NIFI-735 URL: https://issues.apache.org/jira/browse/NIFI-735 Project: Apache NiFi Issue Type: Bug Components: Core Framework Affects Versions: 0.1.0 Reporter: Dan Bress Assignee: Dan Bress Fix For: 0.2.0 Attachments: 0001-Squashed-commit-of-the-following.patch Per [~mcgilman] +0 for triggering OnRemoved and OnShutdown after initialization and before being done with instance +0 for triggering OnRemoved and OnShutdown and not their deprecated counterparts Change code to call annotations *after* the documentation has been generated for that component. Also invoke both the new annotations and the deprecated annotations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[2/4] incubator-nifi git commit: Merge branch 'develop' into NIFI-735
Merge branch 'develop' into NIFI-735 Project: http://git-wip-us.apache.org/repos/asf/incubator-nifi/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-nifi/commit/93546760 Tree: http://git-wip-us.apache.org/repos/asf/incubator-nifi/tree/93546760 Diff: http://git-wip-us.apache.org/repos/asf/incubator-nifi/diff/93546760 Branch: refs/heads/develop Commit: 93546760be2223f40215a0aeb9614dbb9bdb148f Parents: bd9782c 4dc2ea6 Author: danbress dbr...@onyxconsults.com Authored: Sun Jun 28 16:03:32 2015 -0400 Committer: danbress dbr...@onyxconsults.com Committed: Sun Jun 28 16:03:32 2015 -0400 -- nifi/nifi-docs/src/main/asciidoc/developer-guide.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --
[jira] [Comment Edited] (NIFI-679) InvokeHTTP - Add support for basic authentication
[ https://issues.apache.org/jira/browse/NIFI-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615071#comment-14615071 ] Joe Skora edited comment on NIFI-679 at 7/6/15 2:39 PM: I noticed that the patch ([-NIFI-749-|https://issues.apache.org/jira/browse/NIFI-749]) for the unit test EOL issue included additional changes to finalize variables in some of the tests. In the interest of getting it more right next time... 1. Are the preferred patterns for source format, patterns like local mutability, etc. documented anywhere? (Apologies if I missed it.) 2. Is it ok to include unrelated code cleanup in a patch or is it preferred for those types of edits to be separated into a separate cleanup commit? was (Author: jskora): I noticed that the patch for the unit test EOL issue included additional changes to finalize variables in some of the tests. In the interest of getting it more right next time... 1. Are the preferred patterns for source format, patterns like local mutability, etc. documented anywhere? (Apologies if I missed it.) 2. Is it ok to include unrelated code cleanup in a patch or is it preferred for those types of edits to be separated into a separate cleanup commit? InvokeHTTP - Add support for basic authentication - Key: NIFI-679 URL: https://issues.apache.org/jira/browse/NIFI-679 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: Matt Gilman Priority: Minor Fix For: 0.2.0 Attachments: nifi-679.patch InvokeHTTP should optionally support username/password for web services that do not employ certificate based authentication. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
