[GitHub] [incubator-nuttx] patacongo commented on issue #270: Small I2C fixups
patacongo commented on issue #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#issuecomment-585854407 I will close this PR now. If you remove the offending commit, it may be reopened. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #270: Small I2C fixups
patacongo commented on issue #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#issuecomment-585859504 That does not matter because that option is not visual in the menus. It is a hidden option that can only be selected by architecture code. Certainly that is not an excuse to introduce errors into the configuration. Configuration options that have no prompt string do not appear in the menus. This is internal implementation of configuration system and not part of the UI menus. Everything is correct as it is. Please do not change anything. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #270: Small I2C fixups
patacongo commented on issue #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#issuecomment-585866363 Yes, there is a problem. But your solution is not correct. It is worse. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #270: Small I2C fixups
patacongo commented on issue #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#issuecomment-586591898 @NicholasChin Please not that I have reviewed the driver configurations and found several other occurrences of the error that you reported here. The driver configuration got pretty well screwed up. I have submitted #286 that should should fix the case you note in drivers/i2c/Kconfig and the other places where the same error occurs. It should also help to prevent this kind of error from occurring again in the future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
