[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #210: Reimplement sim uart on top of serial driver framework

2020-02-06 Thread GitBox
xiaoxiang781216 commented on issue #210: Reimplement sim uart on top of serial 
driver framework
URL: https://github.com/apache/incubator-nuttx/pull/210#issuecomment-582971070
 
 
   > I don't think Ctrl-C functionality should be enabled unless cancelation 
points are also enabled.
   > 
   > I wonder also if deferred cancellation mode should not also be enabled by 
default when enabled?
   
   Yes, user need enable CONFIG_TTY_SIGINT to activate Ctrl+C functionality. It 
is disabled by default.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #210: Reimplement sim uart on top of serial driver framework

2020-02-08 Thread GitBox
xiaoxiang781216 commented on issue #210: Reimplement sim uart on top of serial 
driver framework
URL: https://github.com/apache/incubator-nuttx/pull/210#issuecomment-583739986
 
 
   > Has everything discussed been resolved? Is this PR ready to be merged?
   
   Yes, I have fixed all comment from @yamt.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #210: Reimplement sim uart on top of serial driver framework

2020-02-12 Thread GitBox
xiaoxiang781216 commented on issue #210: Reimplement sim uart on top of serial 
driver framework
URL: https://github.com/apache/incubator-nuttx/pull/210#issuecomment-585293963
 
 
   I don't meet this issue before, @yamt could you share your config? or try on 
Ubuntu, so we can identify where is a common issue or MacOS specific.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #210: Reimplement sim uart on top of serial driver framework

2020-02-12 Thread GitBox
xiaoxiang781216 commented on issue #210: Reimplement sim uart on top of serial 
driver framework
URL: https://github.com/apache/incubator-nuttx/pull/210#issuecomment-585312812
 
 
   I can run to nsh as normal with your config on Ubuntu, macOS specific issue?
   ramdisk_register: buffer: 0x556e73d89be0 nsectors: 16 sectsize: 64
   nsh_romfsetc: Mounting ROMFS filesystem at target=/etc with source=/dev/ram1
   romfs_bind: Entry
   rd_open: rd_crefs: 1
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   rd_ioctl: Entry
   rd_ioctl: ppv: 0x556e73d89be0
   binfs_bind: Entry
   romfs_open: Open 'init.d/rcS'
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_seek: Seek to offset: 0 whence: 1
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_seek: New file position: 0
   romfs_read: Read 1 bytes from offset 0
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_read: Read sector 3
   romfs_filecacheread: sector: 3 cached: 0 sectorsize: 64 XIP base: 
0x556e73d89be0 buffer: 0x556e73d89be0
   romfs_filecacheread: XIP buffer: 0x556e73d89ca0
   romfs_read: Return 1 bytes from sector offset 0
   romfs_read: Read 1 bytes from offset 1
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_read: Read sector 3
   romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 
0x556e73d89be0 buffer: 0x556e73d89ca0
   romfs_read: Return 1 bytes from sector offset 1
   romfs_read: Read 1 bytes from offset 2
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_read: Read sector 3
   romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 
0x556e73d89be0 buffer: 0x556e73d89ca0
   romfs_read: Return 1 bytes from sector offset 2
   romfs_read: Read 1 bytes from offset 3
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_read: Read sector 3
   romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 
0x556e73d89be0 buffer: 0x556e73d89ca0
   romfs_read: Return 1 bytes from sector offset 3
   romfs_read: Read 1 bytes from offset 4
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_read: Read sector 3
   romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 
0x556e73d89be0 buffer: 0x556e73d89ca0
   romfs_read: Return 1 bytes from sector offset 4
   romfs_read: Read 1 bytes from offset 5
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_read: Read sector 3
   romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 
0x556e73d89be0 buffer: 0x556e73d89ca0
   romfs_read: Return 1 bytes from sector offset 5
   romfs_read: Read 1 bytes from offset 6
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_read: Read sector 3
   romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 
0x556e73d89be0 buffer: 0x556e73d89ca0
   romfs_read: Return 1 bytes from sector offset 6
   romfs_read: Read 1 bytes from offset 7
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_read: Read sector 3
   romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 
0x556e73d89be0 buffer: 0x556e73d89ca0
   romfs_read: Return 1 bytes from sector offset 7
   romfs_read: Read 1 bytes from offset 8
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_read: Read sector 3
   romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 
0x556e73d89be0 buffer: 0x556e73d89ca0
   romfs_read: Return 1 bytes from sector offset 8
   romfs_read: Read 1 bytes from offset 9
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_read: Read sector 3
   romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 
0x556e73d89be0 buffer: 0x556e73d89ca0
   romfs_read: Return 1 bytes from sector offset 9
   romfs_read: Read 1 bytes from offset 10
   rd_geometry: Entry
   rd_geometry: available: true mediachanged: false writeenabled: false
   rd_geometry: nsectors: 16 sectorsize: 64
   romfs_read: Read sector 3
   r