[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593322676 @jerpelea it's about BOARD_XTAL_FREQUENCY, isn't it? this 80MHz is hardcoded in the bootloader. see the code referenced by the code comment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593372759 @jerpelea CONFIG_ESP32CORE_XTAL_40MZ is about BOARD_XTAL_FREQUENCY. this change is about BOARD_CLOCK_FREQUENCY. the reason to hardcode is explained in the comment in this patch. are you going to investigate CONFIG_ESP32CORE_RUN_IRAM? i don't have OpenOCD environment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593377800 @jerpelea sorry, i don't understand your comments. do you mean that, for some reasons, BOARD_CLOCK_FREQUENCY should be same as BOARD_XTAL_FREQUENCY? why? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593413057 my thinking is that * the current code is broken at least if you run nuttx with esp-idf bootloader on qemu * the bootloader configures it 80MHz (hardcoded) and nuttx relies on the configuration * the "Don't ask me for an explanation" comment made me think the current code didn't have a good rationale anyway https://github.com/apache/incubator-nuttx/commit/89c33e97991e47918c345fecfd82ca632509656b * i left the CONFIG_ESP32CORE_RUN_IRAM=y case unchanged because i can't test or understand This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593733806 do you mean non-CONFIG_SUPPRESS_CLOCK_CONFIG code can work? i don't think it even compile. i agree it's better to fix it though. i don't know how it was. but at this point the source code of the bootloader and hal are available. and they seem to hardcode 80MHz. TizenRT just uses "#define BOARD_CLOCK_FREQUENCY (2 * BOARD_XTAL_FREQUENCY)" unconditionally. which is 80MHz in case of CONFIG_ESP32CORE_XTAL_40MZ. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593819103 @jerpelea why do you think it should be 2 * BOARD_XTAL_FREQUENCY? my understanding is that it should match the bootloader, which seems to hardcode 80MHz. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593887228 @jerpelea there seems to be multiple clock sources available for CPU clock. see esp32_technical_reference_manual_en.pdf 3.2.3 "CPU Clock" for 80MHz, "PLL" clock, which is 320MHz, is used. https://github.com/espressif/esp-idf/blob/master/components/soc/src/esp32/rtc_clk.c#L581-L585 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-594288758 @jerpelea i won't until i understand why it should be (2 * BOARD_XTAL_FREQUENCY). maybe i will try to ask espressif. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
