[GitHub] [incubator-nuttx] yamt opened a new pull request #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt opened a new pull request #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413 Tested on qemu. I left CONFIG_ESP32CORE_RUN_IRAM case and the "Don't ask me" comment as it is because I don't understand it or can test it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593322676 @jerpelea it's about BOARD_XTAL_FREQUENCY, isn't it? this 80MHz is hardcoded in the bootloader. see the code referenced by the code comment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593352351 This means that if there is another bootloader version it may have the other frequency This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593353012 By default it is set to 40MHZ and I do not see the reason for this change This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea removed a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
jerpelea removed a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593352351 This means that if there is another bootloader version it may have the other frequency This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
jerpelea edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593353012 By default it is set to 40MHZ and I do not see the reason to hardcode it https://bitbucket.org/alinjerpelea/nuttx/src/ce7a0b390c7c983fbf3811734c8d0a4274b9c3bf/boards/xtensa/esp32/esp32-core/Kconfig#lines-10 I would investigate why CONFIG_ESP32CORE_RUN_IRAM is setting it to 80MhZ https://github.com/apache/incubator-nuttx/pull/413/commits/386bde43cdc0da24c37dbd7b9091eede0b97a35e#diff-f166ac60a5b51d6d6c90be26a4e4145bR76 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
jerpelea edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593353012 here is the explanation https://github.com/apache/incubator-nuttx/blob/386bde43cdc0da24c37dbd7b9091eede0b97a35e/boards/xtensa/esp32/esp32-core/include/board.h#L45 By default it is set to 40MHZ and I do not see the reason to hardcode the frequency https://bitbucket.org/alinjerpelea/nuttx/src/ce7a0b390c7c983fbf3811734c8d0a4274b9c3bf/boards/xtensa/esp32/esp32-core/Kconfig#lines-10 I would investigate why CONFIG_ESP32CORE_RUN_IRAM is setting it to 80MhZ https://github.com/apache/incubator-nuttx/pull/413/commits/386bde43cdc0da24c37dbd7b9091eede0b97a35e#diff-f166ac60a5b51d6d6c90be26a4e4145bR76 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593372759 @jerpelea CONFIG_ESP32CORE_XTAL_40MZ is about BOARD_XTAL_FREQUENCY. this change is about BOARD_CLOCK_FREQUENCY. the reason to hardcode is explained in the comment in this patch. are you going to investigate CONFIG_ESP32CORE_RUN_IRAM? i don't have OpenOCD environment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593374264 -# define BOARD_CLOCK_FREQUENCY BOARD_XTAL_FREQUENCY +# define BOARD_CLOCK_FREQUENCY 8000 this is your change This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593374479 I do not have OpenOCD This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] RB-tel opened a new pull request #414: RX65N RTC Driver added
RB-tel opened a new pull request #414: RX65N RTC Driver added URL: https://github.com/apache/incubator-nuttx/pull/414 RTC Driver files and related modifications added to the rx65n. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593377800 @jerpelea sorry, i don't understand your comments. do you mean that, for some reasons, BOARD_CLOCK_FREQUENCY should be same as BOARD_XTAL_FREQUENCY? why? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593380150 In your change you replace this line with a hardcoded value I am trying to understand your thinking since nither you or me have the actual HW This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #414: RX65N RTC Driver added
patacongo commented on a change in pull request #414: RX65N RTC Driver added URL: https://github.com/apache/incubator-nuttx/pull/414#discussion_r386395546 ## File path: arch/renesas/src/rx65n/rx65n_rtc.h ## @@ -0,0 +1,261 @@ +/ + * arch/renesas/src/rx65n/rx65n_rtc.h + * + * Copyright (C) 2008-2019 Gregory Nutt. All rights reserved. + * Authors: Anjana + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + ***/ Review comment: All new files added to the Apache repositories must have an Apache 2.0 license header with no copyright or author. You can copy-paste the header from sched/sched/sched_getcpu.c. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #414: RX65N RTC Driver added
patacongo commented on a change in pull request #414: RX65N RTC Driver added URL: https://github.com/apache/incubator-nuttx/pull/414#discussion_r386395999 ## File path: boards/renesas/rx65n/rx65n-grrose/src/rx65n_appinit.c ## @@ -0,0 +1,96 @@ +/ + * boards/renesas/rx65n/rx65n-grrose/src/rx65n.appinit.c + * + * Copyright (C) 2008-2019 Gregory Nutt. All rights reserved. + * Author: Anjana + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files added to the Apache repositories must have an Apache 2.0 license header with no copyright or author. You can copy-paste the header from sched/sched/sched_getcpu.c. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #414: RX65N RTC Driver added
patacongo commented on a change in pull request #414: RX65N RTC Driver added URL: https://github.com/apache/incubator-nuttx/pull/414#discussion_r386396204 ## File path: boards/renesas/rx65n/rx65n-rsk2mb/src/rx65n_appinit.c ## @@ -0,0 +1,96 @@ +/ + * boards/renesas/rx65n/rx65n-grrose/src/rx65n.appinit.c + * + * Copyright (C) 2008-2019 Gregory Nutt. All rights reserved. + * Author: Anjana + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files added to the Apache repositories must have an Apache 2.0 license header with no copyright or author. You can copy-paste the header from sched/sched/sched_getcpu.c. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #414: RX65N RTC Driver added
patacongo commented on issue #414: RX65N RTC Driver added URL: https://github.com/apache/incubator-nuttx/pull/414#issuecomment-593408229 When you change the headers on all of the new files to the new Apache 2.0 license I will be happy to merge the code. Sorry to trouble you with this, but these are the rules for new files since NuttX in an Apache project (We will eventually get all of the older, existing file headers changed too). In general the code looks good. Thanks! It is, however, difficult to review large chanages online. Did you run the code through tools/nxstyle to assure that it meets the coding standard? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593413057 my thinking is that * the current code is broken at least if you run nuttx with esp-idf bootloader on qemu * the bootloader configures it 80MHz (hardcoded) and nuttx relies on the configuration * the "Don't ask me for an explanation" comment made me think the current code didn't have a good rationale anyway https://github.com/apache/incubator-nuttx/commit/89c33e97991e47918c345fecfd82ca632509656b * i left the CONFIG_ESP32CORE_RUN_IRAM=y case unchanged because i can't test or understand This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] bjbrandt edited a comment on issue #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping.
bjbrandt edited a comment on issue #391:
arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping.
URL: https://github.com/apache/incubator-nuttx/pull/391#issuecomment-592500639
@davids5
> I think we need to step back and look at the API. It seems to have become
very corrupted.
Blocks, pages and Sectors have been muddled. The only thing that matters in
the STM32 Soc is the Sector size and sizes.
I think the use of terms like 'pages' and ' erase blocks' is just a try of
generalization. Regarding the STM32 family an 'erase block' is just an alias
for 'sector' while 'page' means the smaller r/w hunks (that do not have a name
in the STM32 Reference manual). It is defined that an erase block is always a
multiple of a single r/w page.
> Consider the use case of a bootloader: How does one implement a simple
Erase From Sector 2 to N (23 on the F4) and program from Sector 2 - n?
>
> With the changes in
[29164c5](https://github.com/apache/incubator-nuttx/commit/29164c5706490b74a84d44ba0f79cd588fd3e910)
and herein what are the calls to do this? Can it even be done?
If I got the API right, it should be done like this:
```
/* erase sector 2 - N */
for (int block = 1; block < N; ++i)
{
up_progmem_eraseblock(block);
}
/* get the first write page */
size_t page = up_progmem_erasesize(0) / up_progmem_pagesize(0);
/* get the address off the desired page */
size_t addr = up_progmem_getaddress(page);
/* finally write the hunk */
up_progmem_write(addr, buf, count);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping.
davids5 commented on issue #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping. URL: https://github.com/apache/incubator-nuttx/pull/391#issuecomment-593449454 @bjbrandt - when I have a chance I will have to walk thought this and verify it.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
patacongo commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593465989 The frequency is only hardcoded if CONFIG_SUPPRESS_CLOCK_CONFIG is selected. That is because the actual clock configuration logic is (or at least was) proprietary and Expressif never released this in source form, only as a binary library. If that library is downloaded and included in the build, then you can select any of the supported frequencies. I don't follow ESP32 closely, but this change does not look correct and I do not think that it should be incorporated. You should also look at TizenRT. Expressif took the NuttX ESP32 port and extended it in Tizen RT. You can bring those improvements in as you see fit, provided that we make sure that the Apache licensing is correct. See https://github.com/Samsung/TizenRT/tree/master/os/arch/xtensa. Since that code is supported by Expressif, that should be considered an authoritative source. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #415: boards/z80/ez80/z20x/: Add W25 bootloader
patacongo opened a new pull request #415: boards/z80/ez80/z20x/: Add W25 bootloader URL: https://github.com/apache/incubator-nuttx/pull/415 The SD boot loader was not satisfactory because 1) the SD slot is on an optional board and, hence, cannot be part of a fundamental solution. And 2) it is too big. The only storage on borard is the Winbond W25 SPI-bsed FLASH. This commit adds support for a bootload to 1) read code in HEX format from a serial port and write it to the W25 FLASH, or 2) read code in binary form from the W25 FLASH into SRAM and execute the loaded program. boards/z80/ez80/z20x/configs: Added w25boot configuration boards/z80/ez80/z20x/src: Add bootloader logic, w25_main.c. Add logic to manage shared SRAM memory map so that the loaded program does not clobber the bootloader memory. Add logic to recover the bootloader memory into the heap after the loaded program as started. boards/z80/ez80/z20x/scripts: Rework scripts and configuration to support a bootloader and program build. The boolloader cannot use all of SRAM; the program must not clobber the SRAM region used by the bootloader. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch pr415 updated: boards/z80/ez80/z20x/: Add W25 bootloader
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch pr415
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/pr415 by this push:
new e814977 boards/z80/ez80/z20x/: Add W25 bootloader
e814977 is described below
commit e814977c0fffd504fa47579fd000e6fb4143beb5
Author: Gregory Nutt
AuthorDate: Sun Mar 1 11:30:08 2020 -0600
boards/z80/ez80/z20x/: Add W25 bootloader
The SD boot loader was not satisfactory because 1) the SD slot is on an
optional board and, hence, cannot be part of a fundamental solution. And 2) it
is too big.
The only storage on borard is the Winbond W25 SPI-bsed FLASH. This commit
adds support for a bootload to 1) read code in HEX format from a serial port
and write it to the W25 FLASH, or 2) read code in binary form from the W25
FLASH into SRAM and execute the loaded program.
boards/z80/ez80/z20x/configs: Added w25boot configuration
boards/z80/ez80/z20x/src: Add bootloader logic, w25_main.c. Add logic to
manage shared SRAM memory map so that the loaded program does not clobber the
bootloader memory. Add logic to recover the bootloader memory into the heap
after the loaded program as started.
boards/z80/ez80/z20x/scripts: Rework scripts and configuration to support
a bootloader and program build. The boolloader cannot use all of SRAM; the
program must not clobber the SRAM region used by the bootloader.
---
arch/z80/src/ez80/ez80_spi.c | 12 +-
arch/z80/src/ez80/{ez80f91_spi.h => ez80_spi.h}| 15 +-
arch/z80/src/ez80/ez80_startup.asm | 1 +
boards/z80/ez80/makerlisp/src/ez80_spi.c | 12 +-
boards/z80/ez80/makerlisp/src/ez80_spimmcsd.c | 12 +-
boards/z80/ez80/z20x/Kconfig | 71 ++-
boards/z80/ez80/z20x/configs/w25boot/.gitignore| 6 +
boards/z80/ez80/z20x/configs/w25boot/README.txt| 13 +
boards/z80/ez80/z20x/configs/w25boot/defconfig | 40 ++
.../z80/ez80/z20x/configs/w25boot/sdboot.zdsproj | 261 +++
.../z80/ez80/z20x/configs/w25boot/sdboot.zfpproj | 315 +
.../ez80/z20x/configs/w25boot/sdboot_flash.ztgt| 69 +++
.../z80/ez80/z20x/configs/w25boot/sdboot_ram.ztgt | 69 +++
boards/z80/ez80/z20x/scripts/Make.defs | 17 +-
.../{z20x_ram.linkcmd => z20x_loader.linkcmd} | 25 +-
.../{z20x_ram.linkcmd => z20x_program.linkcmd} | 10 +-
boards/z80/ez80/z20x/src/Makefile | 2 +
boards/z80/ez80/z20x/src/ez80_boot.c | 7 +
boards/z80/ez80/z20x/src/ez80_bringup.c| 6 +-
boards/z80/ez80/z20x/src/ez80_spi.c| 12 +-
boards/z80/ez80/z20x/src/ez80_spimmcsd.c | 12 +-
boards/z80/ez80/z20x/src/ez80_w25.c| 17 +-
boards/z80/ez80/z20x/src/sd_main.c | 9 +-
boards/z80/ez80/z20x/src/w25_main.c| 492 +
boards/z80/ez80/z20x/src/z20x.h| 55 ++-
25 files changed, 1474 insertions(+), 86 deletions(-)
diff --git a/arch/z80/src/ez80/ez80_spi.c b/arch/z80/src/ez80/ez80_spi.c
index 60d56f2..559da04 100644
--- a/arch/z80/src/ez80/ez80_spi.c
+++ b/arch/z80/src/ez80/ez80_spi.c
@@ -57,19 +57,17 @@
#include "chip.h"
-#if defined(CONFIG_ARCH_CHIP_EZ80F91) || defined(CONFIG_ARCH_CHIP_EZ80F92)
-# include "ez80f91_spi.h"
-#endif
+#include "ez80_spi.h"
/
* Pre-processor Definitions
/
#if defined(CONFIG_ARCH_CHIP_EZ80F91) || defined(CONFIG_ARCH_CHIP_EZ80F92)
-# define GPIOB_SPI_SS (1 << 2) /* Pin 2: /SS (not used by driver) */
-# define GPIOB_SPI_SCK (1 << 3) /* Pin 3: SCK */
-# define GPIOB_SPI_MISO(1 << 6) /* Pin 6: MISO */
-# define GPIOB_SPI_MOSI(1 << 7) /* Pin 7: MOSI */
+# define GPIOB_SPI_SS (1 << 2) /* PB2: /SS (not used by driver) */
+# define GPIOB_SPI_SCK (1 << 3) /* PB3: SCK */
+# define GPIOB_SPI_MISO(1 << 6) /* PB6: MISO */
+# define GPIOB_SPI_MOSI(1 << 7) /* PB7: MOSI */
# define GPIOB_SPI_PINSET (GPIOB_SPI_SS | GPIOB_SPI_SCK | GPIOB_SPI_MISO | \
GPIOB_SPI_MOSI)
diff --git a/arch/z80/src/ez80/ez80f91_spi.h b/arch/z80/src/ez80/ez80_spi.h
similarity index 94%
rename from arch/z80/src/ez80/ez80f91_spi.h
rename to arch/z80/src/ez80/ez80_spi.h
index 97911d1..39809f2 100644
--- a/arch/z80/src/ez80/ez80f91_spi.h
+++ b/arch/z80/src/ez80/ez80_spi.h
@@ -1,7 +1,7 @@
/
- * arch/z80/src/ez80/ez80f91_spi.h
+ * arch/z80/src/ez80/ez80_spi.h
*
- * Copyright (C) 2009-2010, 2015 Gregory Nutt. All rights reserved.
+ * Copyright (C) 2009-2010, 2015, 2020 Gregory Nutt. All rights reserved.
* Aut
[incubator-nuttx] branch pr415 created (now 915f094)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch pr415 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 915f094 NFS bug fix and improvement (#412) No new revisions were added by this update.
[GitHub] [incubator-nuttx] acassis merged pull request #415: boards/z80/ez80/z20x/: Add W25 bootloader
acassis merged pull request #415: boards/z80/ez80/z20x/: Add W25 bootloader URL: https://github.com/apache/incubator-nuttx/pull/415 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (915f094 -> e814977)
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 915f094 NFS bug fix and improvement (#412)
add e814977 boards/z80/ez80/z20x/: Add W25 bootloader
No new revisions were added by this update.
Summary of changes:
arch/z80/src/ez80/ez80_spi.c | 12 +-
arch/z80/src/ez80/{ez80f91_spi.h => ez80_spi.h}| 15 +-
arch/z80/src/ez80/ez80_startup.asm | 1 +
boards/z80/ez80/makerlisp/src/ez80_spi.c | 12 +-
boards/z80/ez80/makerlisp/src/ez80_spimmcsd.c | 12 +-
boards/z80/ez80/z20x/Kconfig | 71 ++-
.../z20x/configs/{sdboot => w25boot}/.gitignore| 0
.../z20x/configs/{nsh_ram => w25boot}/README.txt | 8 +-
.../z20x/configs/{sdboot => w25boot}/defconfig | 20 +-
.../configs/{sdboot => w25boot}/sdboot.zdsproj | 4 +-
.../configs/{sdboot => w25boot}/sdboot.zfpproj | 8 +-
.../configs/{sdboot => w25boot}/sdboot_flash.ztgt | 0
.../configs/{sdboot => w25boot}/sdboot_ram.ztgt| 0
boards/z80/ez80/z20x/scripts/Make.defs | 17 +-
.../{z20x_flash.linkcmd => z20x_loader.linkcmd}| 18 +-
.../{z20x_ram.linkcmd => z20x_program.linkcmd} | 10 +-
boards/z80/ez80/z20x/src/Makefile | 2 +
boards/z80/ez80/z20x/src/ez80_boot.c | 7 +
boards/z80/ez80/z20x/src/ez80_bringup.c| 6 +-
boards/z80/ez80/z20x/src/ez80_spi.c| 12 +-
boards/z80/ez80/z20x/src/ez80_spimmcsd.c | 12 +-
boards/z80/ez80/z20x/src/ez80_w25.c| 17 +-
boards/z80/ez80/z20x/src/sd_main.c | 9 +-
boards/z80/ez80/z20x/src/w25_main.c| 492 +
boards/z80/ez80/z20x/src/z20x.h| 55 ++-
25 files changed, 714 insertions(+), 106 deletions(-)
rename arch/z80/src/ez80/{ez80f91_spi.h => ez80_spi.h} (94%)
copy boards/z80/ez80/z20x/configs/{sdboot => w25boot}/.gitignore (100%)
copy boards/z80/ez80/z20x/configs/{nsh_ram => w25boot}/README.txt (53%)
copy boards/z80/ez80/z20x/configs/{sdboot => w25boot}/defconfig (70%)
copy boards/z80/ez80/z20x/configs/{sdboot => w25boot}/sdboot.zdsproj (97%)
copy boards/z80/ez80/z20x/configs/{sdboot => w25boot}/sdboot.zfpproj (96%)
copy boards/z80/ez80/z20x/configs/{sdboot => w25boot}/sdboot_flash.ztgt (100%)
copy boards/z80/ez80/z20x/configs/{sdboot => w25boot}/sdboot_ram.ztgt (100%)
copy boards/z80/ez80/z20x/scripts/{z20x_flash.linkcmd => z20x_loader.linkcmd}
(88%)
rename boards/z80/ez80/z20x/scripts/{z20x_ram.linkcmd => z20x_program.linkcmd}
(93%)
create mode 100644 boards/z80/ez80/z20x/src/w25_main.c
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #416: NFS: Support IPv4 and TCP
xiaoxiang781216 opened a new pull request #416: NFS: Support IPv4 and TCP URL: https://github.com/apache/incubator-nuttx/pull/416 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #417: boards/z80/ez80/z20x/: Correct naming of project files.
patacongo opened a new pull request #417: boards/z80/ez80/z20x/: Correct naming of project files. URL: https://github.com/apache/incubator-nuttx/pull/417 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (e814977 -> 2524837)
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from e814977 boards/z80/ez80/z20x/: Add W25 bootloader
add 2524837 boards/z80/ez80/z20x/: Correct naming of project files.
No new revisions were added by this update.
Summary of changes:
boards/z80/ez80/z20x/configs/w25boot/{sdboot.zdsproj => w25boot.zdsproj} | 0
boards/z80/ez80/z20x/configs/w25boot/{sdboot.zfpproj => w25boot.zfpproj} | 0
.../ez80/z20x/configs/w25boot/{sdboot_flash.ztgt => w25boot_flash.ztgt} | 0
.../z80/ez80/z20x/configs/w25boot/{sdboot_ram.ztgt => w25boot_ram.ztgt} | 0
4 files changed, 0 insertions(+), 0 deletions(-)
rename boards/z80/ez80/z20x/configs/w25boot/{sdboot.zdsproj =>
w25boot.zdsproj} (100%)
rename boards/z80/ez80/z20x/configs/w25boot/{sdboot.zfpproj =>
w25boot.zfpproj} (100%)
rename boards/z80/ez80/z20x/configs/w25boot/{sdboot_flash.ztgt =>
w25boot_flash.ztgt} (100%)
rename boards/z80/ez80/z20x/configs/w25boot/{sdboot_ram.ztgt =>
w25boot_ram.ztgt} (100%)
[GitHub] [incubator-nuttx] Ouss4 merged pull request #417: boards/z80/ez80/z20x/: Correct naming of project files.
Ouss4 merged pull request #417: boards/z80/ez80/z20x/: Correct naming of project files. URL: https://github.com/apache/incubator-nuttx/pull/417 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #418: include/nuttx: Fix improper use of inline
patacongo opened a new pull request #418: include/nuttx: Fix improper use of inline URL: https://github.com/apache/incubator-nuttx/pull/418 I finally figured out why the ez80 code has gotten so big. It is because people have been put putting big inline functions in header files. That is a violation of the coding standard, since only c89 compatibility is required in all common code. But we have been tolerating inline function it because include/nuttx/compiler.h defines 'inline' to be nothing for C89 compilers. As a result, static inline functions declared within a C file not so bad; the inline qualifier is ignored, if not supported, but otherwise all is well. But it is catastrophic in header files. Those static inline functions are included as static functions and implemented in EVERY file that includes those header files, even if the functions are never called. That makes the code base huge!So there is another PR coming to fix some of the worst offenders. This commit fixes two of the worst offenders I have encountered so far: include/nuttx/sempahore.h and cache.h. But there may be a few other changes needed. Under include/nuttx there are still inline functions thread.h, inclue/nuttx/list.h, mutex.h, tree.h, and include/nuttx/crypto/blake2s.h with no protection for compilers that do not handler the inline qualifier. Otherwise we are clean. With the changes to these two header files, the size of the z20x build is reduced by about 40%. And incredible size savings. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] 03/03: fs/nfs: Add the simplest RPCAUTH_UNIX support
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch pr416
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 4d97290b754111cfa0ad9f97fe48b573d6c8483c
Author: Xiang Xiao
AuthorDate: Mon Mar 2 20:07:09 2020 +0800
fs/nfs: Add the simplest RPCAUTH_UNIX support
since most NFS server disable RPCAUTH_NULL to improve the security
Signed-off-by: Xiang Xiao
Change-Id: Iee1ddc199707fdad52bb1e4d79817b838930c17d
---
fs/nfs/nfs_vfsops.c | 4 ++--
fs/nfs/rpc.h| 3 ++-
fs/nfs/rpc_clnt.c | 14 +++---
3 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/fs/nfs/nfs_vfsops.c b/fs/nfs/nfs_vfsops.c
index 7d74670..f3f0eed 100644
--- a/fs/nfs/nfs_vfsops.c
+++ b/fs/nfs/nfs_vfsops.c
@@ -302,7 +302,7 @@ static int nfs_filecreate(FAR struct nfsmount *nmp, FAR
struct nfsnode *np,
/* Set the group ID to one */
*ptr++ = nfs_true;/* True: Gid value follows */
- *ptr++ = HTONL(1);/* GID = 1 (nogroup) */
+ *ptr++ = 0; /* GID = 0 (nogroup) */
reqlen += 2*sizeof(uint32_t);
/* Set the size to zero */
@@ -2287,7 +2287,7 @@ static int nfs_mkdir(FAR struct inode *mountpt, FAR const
char *relpath, mode_t
/* Set the group ID to one */
*ptr++ = nfs_true;/* True: Gid value follows */
- *ptr++ = HTONL(1);/* GID = 1 (nogroup) */
+ *ptr++ = 0; /* GID = 0 (nogroup) */
reqlen += 2*sizeof(uint32_t);
/* No size */
diff --git a/fs/nfs/rpc.h b/fs/nfs/rpc.h
index 06daa96..c97b668 100644
--- a/fs/nfs/rpc.h
+++ b/fs/nfs/rpc.h
@@ -218,7 +218,7 @@ struct rpc_auth_info
uint32_t authlen; /* auth length */
};
-struct auth_unix
+struct rpc_auth_unix
{
uint32_t stamp;
uint32_t hostname; /* null */
@@ -236,6 +236,7 @@ struct rpc_call_header
uint32_t rp_vers; /* version */
uint32_t rp_proc; /* procedure */
struct rpc_auth_info rpc_auth;
+ struct rpc_auth_unix rpc_unix;
struct rpc_auth_info rpc_verf;
};
diff --git a/fs/nfs/rpc_clnt.c b/fs/nfs/rpc_clnt.c
index 43f847f..b219732 100644
--- a/fs/nfs/rpc_clnt.c
+++ b/fs/nfs/rpc_clnt.c
@@ -129,6 +129,7 @@ static uint32_t rpc_reply;
static uint32_t rpc_call;
static uint32_t rpc_vers;
static uint32_t rpc_auth_null;
+static uint32_t rpc_auth_unix;
/* Global statics for all client instances. Cleared by NuttX on boot-up. */
@@ -444,10 +445,16 @@ static void rpcclnt_fmtheader(FAR struct rpc_call_header
*ch,
ch->rp_vers = txdr_unsigned(vers);
ch->rp_proc = txdr_unsigned(procid);
- /* rpc_auth part (auth_null) */
+ /* rpc_auth part (auth_unix) */
- ch->rpc_auth.authtype = rpc_auth_null;
- ch->rpc_auth.authlen = 0;
+ ch->rpc_auth.authtype = rpc_auth_unix;
+ ch->rpc_auth.authlen = txdr_unsigned(sizeof(ch->rpc_unix));
+
+ ch->rpc_unix.stamp= 0;
+ ch->rpc_unix.hostname = 0;
+ ch->rpc_unix.uid = 0;
+ ch->rpc_unix.gid = 0;
+ ch->rpc_unix.gidlist = 0;
/* rpc_verf part (auth_null) */
@@ -475,6 +482,7 @@ void rpcclnt_init(void)
rpc_vers = txdr_unsigned(RPC_VER2);
rpc_call = txdr_unsigned(RPC_CALL);
rpc_auth_null = txdr_unsigned(RPCAUTH_NULL);
+ rpc_auth_unix = txdr_unsigned(RPCAUTH_UNIX);
finfo("RPC initialized\n");
}
[incubator-nuttx] 02/03: fs/nfs: Support both IPv6 and TCP
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch pr416
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 9ec8471ca7fde7cb6b2f8a6c5ab4d0e243522cdf
Author: Xiang Xiao
AuthorDate: Sun Mar 1 17:24:29 2020 +0800
fs/nfs: Support both IPv6 and TCP
and correctly handle the retransmission
Signed-off-by: Xiang Xiao
Change-Id: I4862dc84d036020784e72953ba788bcd3c1e0397
---
fs/nfs/Kconfig| 2 +-
fs/nfs/nfs.h | 2 +-
fs/nfs/nfs_mount.h| 4 +-
fs/nfs/nfs_util.c | 13 +-
fs/nfs/nfs_vfsops.c | 112 +---
fs/nfs/rpc.h | 5 +-
fs/nfs/rpc_clnt.c | 394 +++---
include/nuttx/net/netconfig.h | 1 +
8 files changed, 271 insertions(+), 262 deletions(-)
diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
index 4a9effc..a25b3b5 100644
--- a/fs/nfs/Kconfig
+++ b/fs/nfs/Kconfig
@@ -6,7 +6,7 @@
config NFS
bool "NFS client file system"
default n
- depends on NET_UDP && NET_IPv4 && !DISABLE_MOUNTPOINT
+ depends on !DISABLE_MOUNTPOINT
select FS_READABLE
select FS_WRITABLE
---help---
diff --git a/fs/nfs/nfs.h b/fs/nfs/nfs.h
index a17750c..3f17e2e 100644
--- a/fs/nfs/nfs.h
+++ b/fs/nfs/nfs.h
@@ -61,7 +61,7 @@
#define NFS_RETRANS10 /* Num of retrans for soft mounts */
#define NFS_WSIZE 8192 /* Def. write data size <= 8192 */
#define NFS_RSIZE 8192 /* Def. read data size <= 8192 */
-#define NFS_READDIRSIZE8192 /* Def. readdir size */
+#define NFS_READDIRSIZE1024 /* Def. readdir size */
/* Ideally, NFS_DIRBLKSIZ should be bigger, but I've seen servers with
* broken NFS/ethernet drivers that won't work with anything bigger (Linux..)
diff --git a/fs/nfs/nfs_mount.h b/fs/nfs/nfs_mount.h
index 4bab615..4c9cf54 100644
--- a/fs/nfs/nfs_mount.h
+++ b/fs/nfs/nfs_mount.h
@@ -73,7 +73,7 @@ struct nfsmount
char nm_path[90]; /* server's path of the
directory being mounted */
struct nfs_fattr nm_fattr; /* nfs file attribute cache */
FAR struct rpcclnt *nm_rpcclnt; /* RPC state */
- struct sockaddr nm_nam; /* Addr of server */
+ struct sockaddr_storage nm_nam; /* Addr of server */
uint8_t nm_fhsize;/* Size of root file handle
(host order) */
uint16_t nm_rsize; /* Max size of read RPC */
uint16_t nm_wsize; /* Max size of write RPC */
@@ -87,8 +87,6 @@ struct nfsmount
union
{
-struct rpc_call_pmappmap;
-struct rpc_call_mount mountd;
struct rpc_call_create create;
struct rpc_call_lookup lookup;
struct rpc_call_readread;
diff --git a/fs/nfs/nfs_util.c b/fs/nfs/nfs_util.c
index abfa796..166b661 100644
--- a/fs/nfs/nfs_util.c
+++ b/fs/nfs/nfs_util.c
@@ -149,18 +149,9 @@ int nfs_request(FAR struct nfsmount *nmp, int procnum,
if (replyh.nfs_status != 0)
{
- if (fxdr_unsigned(uint32_t, replyh.nfs_status) > 32)
-{
- error = -EOPNOTSUPP;
-}
- else
-{
- /* NFS_ERRORS are the same as NuttX errno values */
+ /* NFS_ERRORS are the same as NuttX errno values */
- error = -fxdr_unsigned(uint32_t, replyh.nfs_status);
-}
-
- return error;
+ return -fxdr_unsigned(uint32_t, replyh.nfs_status);
}
if (replyh.rh.rpc_verfi.authtype != 0)
diff --git a/fs/nfs/nfs_vfsops.c b/fs/nfs/nfs_vfsops.c
index fe5cbbe..7d74670 100644
--- a/fs/nfs/nfs_vfsops.c
+++ b/fs/nfs/nfs_vfsops.c
@@ -66,8 +66,6 @@
#include
#include
#include
-#include
-#include
#include
#include
@@ -1634,16 +1632,20 @@ static void nfs_decode_args(FAR struct
nfs_mount_parameters *nprmt,
/* Get the maximum amount of data that can be transferred in one packet */
- if ((argp->sotype == SOCK_DGRAM) != 0)
+ if (argp->sotype == SOCK_DGRAM)
{
maxio = NFS_MAXDGRAMDATA;
}
else
{
- ferr("ERROR: Only SOCK_DRAM is supported\n");
maxio = NFS_MAXDATA;
}
+ if (maxio > MAXBSIZE)
+{
+ maxio = MAXBSIZE;
+}
+
/* Get the maximum amount of data that can be transferred in one write
transfer */
if ((argp->flags & NFSMNT_WSIZE) != 0 && argp->wsize > 0)
@@ -1664,11 +1666,6 @@ static void nfs_decode_args(FAR struct
nfs_mount_parameters *nprmt,
nprmt->wsize = maxio;
}
- if (nprmt->wsize > MAXBSIZE)
-{
- nprmt->wsize = MAXBSIZE;
-}
-
/* Get the maximum amount of data that can be transferred in one read
transfer */
if ((argp->flags & NFSMNT_RSIZE) != 0 && argp->rsize > 0)
@@ -1689,11 +1686,6 @@ static void nfs_decode_args(FAR struct
nfs_mount_parameters *nprmt,
nprmt->rsize = maxio;
}
- if
[incubator-nuttx] 01/03: fs/nfs: Should return the partial transfer bytes in nfs_read/nfs_write
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch pr416
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 1b736b2551701d7e27713baaa713bf1596592d20
Author: Xiang Xiao
AuthorDate: Mon Mar 2 16:50:12 2020 +0800
fs/nfs: Should return the partial transfer bytes in nfs_read/nfs_write
Signed-off-by: Xiang Xiao
Change-Id: I2843a371dd4d8991705c473a61c0985aadc9201e
---
fs/nfs/nfs_vfsops.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/fs/nfs/nfs_vfsops.c b/fs/nfs/nfs_vfsops.c
index 59670c4..fe5cbbe 100644
--- a/fs/nfs/nfs_vfsops.c
+++ b/fs/nfs/nfs_vfsops.c
@@ -920,13 +920,9 @@ static ssize_t nfs_read(FAR struct file *filep, FAR char
*buffer, size_t buflen)
}
}
- finfo("Read %d bytes\n", bytesread);
- nfs_semgive(nmp);
- return bytesread;
-
errout_with_semaphore:
nfs_semgive(nmp);
- return error;
+ return bytesread > 0 ? bytesread : error;
}
/
@@ -1108,12 +1104,9 @@ static ssize_t nfs_write(FAR struct file *filep, FAR
const char *buffer,
buffer += writesize;
}
- nfs_semgive(nmp);
- return byteswritten;
-
errout_with_semaphore:
nfs_semgive(nmp);
- return error;
+ return byteswritten > 0 ? byteswritten : error;
}
/
@@ -1301,7 +1294,6 @@ static int nfs_opendir(FAR struct inode *mountpt, FAR
const char *relpath,
DEBUGASSERT(fhandle.length <= DIRENT_NFS_MAXHANDLE);
memcpy(dir->u.nfs.nfs_fhandle, &fhandle.handle, fhandle.length);
- error = OK;
errout_with_semaphore:
nfs_semgive(nmp);
[incubator-nuttx] branch pr416 updated (2524837 -> 4d97290)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch pr416 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 2524837 boards/z80/ez80/z20x/: Correct naming of project files. new 1b736b2 fs/nfs: Should return the partial transfer bytes in nfs_read/nfs_write new 9ec8471 fs/nfs: Support both IPv6 and TCP new 4d97290 fs/nfs: Add the simplest RPCAUTH_UNIX support The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: fs/nfs/Kconfig| 2 +- fs/nfs/nfs.h | 2 +- fs/nfs/nfs_mount.h| 4 +- fs/nfs/nfs_util.c | 13 +- fs/nfs/nfs_vfsops.c | 128 ++--- fs/nfs/rpc.h | 8 +- fs/nfs/rpc_clnt.c | 408 +++--- include/nuttx/net/netconfig.h | 1 + 8 files changed, 288 insertions(+), 278 deletions(-)
[incubator-nuttx] branch pr416 created (now 2524837)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch pr416 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 2524837 boards/z80/ez80/z20x/: Correct naming of project files. No new revisions were added by this update.
[GitHub] [incubator-nuttx] patacongo merged pull request #416: NFS: Support IPv4 and TCP
patacongo merged pull request #416: NFS: Support IPv4 and TCP URL: https://github.com/apache/incubator-nuttx/pull/416 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] 01/03: fs/nfs: Should return the partial transfer bytes in nfs_read/nfs_write
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 6c77829940d52e7c16e9bb452fac63dd25add066
Author: Xiang Xiao
AuthorDate: Mon Mar 2 16:50:12 2020 +0800
fs/nfs: Should return the partial transfer bytes in nfs_read/nfs_write
---
fs/nfs/nfs_vfsops.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/fs/nfs/nfs_vfsops.c b/fs/nfs/nfs_vfsops.c
index 59670c4..fe5cbbe 100644
--- a/fs/nfs/nfs_vfsops.c
+++ b/fs/nfs/nfs_vfsops.c
@@ -920,13 +920,9 @@ static ssize_t nfs_read(FAR struct file *filep, FAR char
*buffer, size_t buflen)
}
}
- finfo("Read %d bytes\n", bytesread);
- nfs_semgive(nmp);
- return bytesread;
-
errout_with_semaphore:
nfs_semgive(nmp);
- return error;
+ return bytesread > 0 ? bytesread : error;
}
/
@@ -1108,12 +1104,9 @@ static ssize_t nfs_write(FAR struct file *filep, FAR
const char *buffer,
buffer += writesize;
}
- nfs_semgive(nmp);
- return byteswritten;
-
errout_with_semaphore:
nfs_semgive(nmp);
- return error;
+ return byteswritten > 0 ? byteswritten : error;
}
/
@@ -1301,7 +1294,6 @@ static int nfs_opendir(FAR struct inode *mountpt, FAR
const char *relpath,
DEBUGASSERT(fhandle.length <= DIRENT_NFS_MAXHANDLE);
memcpy(dir->u.nfs.nfs_fhandle, &fhandle.handle, fhandle.length);
- error = OK;
errout_with_semaphore:
nfs_semgive(nmp);
[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #419: arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop
hartmannathan opened a new pull request #419: arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop URL: https://github.com/apache/incubator-nuttx/pull/419 This PR is from two patches sent by Augusto Fraga Giachero to d...@nuttx.apache.org. See the archived email here: https://lists.apache.org/thread.html/r3653bc90affec0ba4d004eeb30bd41a5fb18e0b3ac837db10ba1f8ec%40%3Cdev.nuttx.apache.org%3E Not canceling the I2C timeout watch dog immediately after finishing all I2C transactions in interrupt context can lead to a race condition due to nxsem_wait(&priv->wait) in lpc17_40_i2c_start() not resuming execution fast enough (this can be easily triggered if another task / thread is using a lot of cpu time). Falling to cancel the watchdog up to time will cause the priv->wait semaphore to be incremented twice (first by lpc17_40_i2c_stop() then by lpc17_40_i2c_timeout()), so all I2C transactions after that will return immediately and priv->msgs will hold pointers to memory it doesn't own anymore. Canceling the priv->timeout watch dog in lpc17_40_i2c_stop() prevents this as it is executed from the I2C interrupt handler. arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Fix timeout calculation For each byte received / transmitted, an acknowledge bit is also transmitted / received, requiring effectively 9 bits for each byte. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (2524837 -> de480b0)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 2524837 boards/z80/ez80/z20x/: Correct naming of project files. new 6c77829 fs/nfs: Should return the partial transfer bytes in nfs_read/nfs_write new 7794214 fs/nfs: Support both IPv6 and TCP new de480b0 fs/nfs: Add the simplest RPCAUTH_UNIX support The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: fs/nfs/Kconfig| 2 +- fs/nfs/nfs.h | 2 +- fs/nfs/nfs_mount.h| 4 +- fs/nfs/nfs_util.c | 13 +- fs/nfs/nfs_vfsops.c | 128 ++--- fs/nfs/rpc.h | 8 +- fs/nfs/rpc_clnt.c | 408 +++--- include/nuttx/net/netconfig.h | 1 + 8 files changed, 288 insertions(+), 278 deletions(-)
[incubator-nuttx] 02/03: fs/nfs: Support both IPv6 and TCP
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 7794214a7dd93ecfae02bc1b7eca94b26f7e2786
Author: Xiang Xiao
AuthorDate: Sun Mar 1 17:24:29 2020 +0800
fs/nfs: Support both IPv6 and TCP
And correctly handle the retransmission
---
fs/nfs/Kconfig| 2 +-
fs/nfs/nfs.h | 2 +-
fs/nfs/nfs_mount.h| 4 +-
fs/nfs/nfs_util.c | 13 +-
fs/nfs/nfs_vfsops.c | 112 +---
fs/nfs/rpc.h | 5 +-
fs/nfs/rpc_clnt.c | 394 +++---
include/nuttx/net/netconfig.h | 1 +
8 files changed, 271 insertions(+), 262 deletions(-)
diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
index 4a9effc..a25b3b5 100644
--- a/fs/nfs/Kconfig
+++ b/fs/nfs/Kconfig
@@ -6,7 +6,7 @@
config NFS
bool "NFS client file system"
default n
- depends on NET_UDP && NET_IPv4 && !DISABLE_MOUNTPOINT
+ depends on !DISABLE_MOUNTPOINT
select FS_READABLE
select FS_WRITABLE
---help---
diff --git a/fs/nfs/nfs.h b/fs/nfs/nfs.h
index a17750c..3f17e2e 100644
--- a/fs/nfs/nfs.h
+++ b/fs/nfs/nfs.h
@@ -61,7 +61,7 @@
#define NFS_RETRANS10 /* Num of retrans for soft mounts */
#define NFS_WSIZE 8192 /* Def. write data size <= 8192 */
#define NFS_RSIZE 8192 /* Def. read data size <= 8192 */
-#define NFS_READDIRSIZE8192 /* Def. readdir size */
+#define NFS_READDIRSIZE1024 /* Def. readdir size */
/* Ideally, NFS_DIRBLKSIZ should be bigger, but I've seen servers with
* broken NFS/ethernet drivers that won't work with anything bigger (Linux..)
diff --git a/fs/nfs/nfs_mount.h b/fs/nfs/nfs_mount.h
index 4bab615..4c9cf54 100644
--- a/fs/nfs/nfs_mount.h
+++ b/fs/nfs/nfs_mount.h
@@ -73,7 +73,7 @@ struct nfsmount
char nm_path[90]; /* server's path of the
directory being mounted */
struct nfs_fattr nm_fattr; /* nfs file attribute cache */
FAR struct rpcclnt *nm_rpcclnt; /* RPC state */
- struct sockaddr nm_nam; /* Addr of server */
+ struct sockaddr_storage nm_nam; /* Addr of server */
uint8_t nm_fhsize;/* Size of root file handle
(host order) */
uint16_t nm_rsize; /* Max size of read RPC */
uint16_t nm_wsize; /* Max size of write RPC */
@@ -87,8 +87,6 @@ struct nfsmount
union
{
-struct rpc_call_pmappmap;
-struct rpc_call_mount mountd;
struct rpc_call_create create;
struct rpc_call_lookup lookup;
struct rpc_call_readread;
diff --git a/fs/nfs/nfs_util.c b/fs/nfs/nfs_util.c
index abfa796..166b661 100644
--- a/fs/nfs/nfs_util.c
+++ b/fs/nfs/nfs_util.c
@@ -149,18 +149,9 @@ int nfs_request(FAR struct nfsmount *nmp, int procnum,
if (replyh.nfs_status != 0)
{
- if (fxdr_unsigned(uint32_t, replyh.nfs_status) > 32)
-{
- error = -EOPNOTSUPP;
-}
- else
-{
- /* NFS_ERRORS are the same as NuttX errno values */
+ /* NFS_ERRORS are the same as NuttX errno values */
- error = -fxdr_unsigned(uint32_t, replyh.nfs_status);
-}
-
- return error;
+ return -fxdr_unsigned(uint32_t, replyh.nfs_status);
}
if (replyh.rh.rpc_verfi.authtype != 0)
diff --git a/fs/nfs/nfs_vfsops.c b/fs/nfs/nfs_vfsops.c
index fe5cbbe..7d74670 100644
--- a/fs/nfs/nfs_vfsops.c
+++ b/fs/nfs/nfs_vfsops.c
@@ -66,8 +66,6 @@
#include
#include
#include
-#include
-#include
#include
#include
@@ -1634,16 +1632,20 @@ static void nfs_decode_args(FAR struct
nfs_mount_parameters *nprmt,
/* Get the maximum amount of data that can be transferred in one packet */
- if ((argp->sotype == SOCK_DGRAM) != 0)
+ if (argp->sotype == SOCK_DGRAM)
{
maxio = NFS_MAXDGRAMDATA;
}
else
{
- ferr("ERROR: Only SOCK_DRAM is supported\n");
maxio = NFS_MAXDATA;
}
+ if (maxio > MAXBSIZE)
+{
+ maxio = MAXBSIZE;
+}
+
/* Get the maximum amount of data that can be transferred in one write
transfer */
if ((argp->flags & NFSMNT_WSIZE) != 0 && argp->wsize > 0)
@@ -1664,11 +1666,6 @@ static void nfs_decode_args(FAR struct
nfs_mount_parameters *nprmt,
nprmt->wsize = maxio;
}
- if (nprmt->wsize > MAXBSIZE)
-{
- nprmt->wsize = MAXBSIZE;
-}
-
/* Get the maximum amount of data that can be transferred in one read
transfer */
if ((argp->flags & NFSMNT_RSIZE) != 0 && argp->rsize > 0)
@@ -1689,11 +1686,6 @@ static void nfs_decode_args(FAR struct
nfs_mount_parameters *nprmt,
nprmt->rsize = maxio;
}
- if (nprmt->rsize > MAXBSIZE)
-{
- nprmt->rsize = MAXBSIZE;
-}
-
/* Get the maxi
[incubator-nuttx] 03/03: fs/nfs: Add the simplest RPCAUTH_UNIX support
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit de480b01b69cc409b19ff14847bbdbcd0150c8e3
Author: Xiang Xiao
AuthorDate: Mon Mar 2 20:07:09 2020 +0800
fs/nfs: Add the simplest RPCAUTH_UNIX support
Since most NFS server disable RPCAUTH_NULL to improve the security
---
fs/nfs/nfs_vfsops.c | 4 ++--
fs/nfs/rpc.h| 3 ++-
fs/nfs/rpc_clnt.c | 14 +++---
3 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/fs/nfs/nfs_vfsops.c b/fs/nfs/nfs_vfsops.c
index 7d74670..f3f0eed 100644
--- a/fs/nfs/nfs_vfsops.c
+++ b/fs/nfs/nfs_vfsops.c
@@ -302,7 +302,7 @@ static int nfs_filecreate(FAR struct nfsmount *nmp, FAR
struct nfsnode *np,
/* Set the group ID to one */
*ptr++ = nfs_true;/* True: Gid value follows */
- *ptr++ = HTONL(1);/* GID = 1 (nogroup) */
+ *ptr++ = 0; /* GID = 0 (nogroup) */
reqlen += 2*sizeof(uint32_t);
/* Set the size to zero */
@@ -2287,7 +2287,7 @@ static int nfs_mkdir(FAR struct inode *mountpt, FAR const
char *relpath, mode_t
/* Set the group ID to one */
*ptr++ = nfs_true;/* True: Gid value follows */
- *ptr++ = HTONL(1);/* GID = 1 (nogroup) */
+ *ptr++ = 0; /* GID = 0 (nogroup) */
reqlen += 2*sizeof(uint32_t);
/* No size */
diff --git a/fs/nfs/rpc.h b/fs/nfs/rpc.h
index 06daa96..c97b668 100644
--- a/fs/nfs/rpc.h
+++ b/fs/nfs/rpc.h
@@ -218,7 +218,7 @@ struct rpc_auth_info
uint32_t authlen; /* auth length */
};
-struct auth_unix
+struct rpc_auth_unix
{
uint32_t stamp;
uint32_t hostname; /* null */
@@ -236,6 +236,7 @@ struct rpc_call_header
uint32_t rp_vers; /* version */
uint32_t rp_proc; /* procedure */
struct rpc_auth_info rpc_auth;
+ struct rpc_auth_unix rpc_unix;
struct rpc_auth_info rpc_verf;
};
diff --git a/fs/nfs/rpc_clnt.c b/fs/nfs/rpc_clnt.c
index 43f847f..b219732 100644
--- a/fs/nfs/rpc_clnt.c
+++ b/fs/nfs/rpc_clnt.c
@@ -129,6 +129,7 @@ static uint32_t rpc_reply;
static uint32_t rpc_call;
static uint32_t rpc_vers;
static uint32_t rpc_auth_null;
+static uint32_t rpc_auth_unix;
/* Global statics for all client instances. Cleared by NuttX on boot-up. */
@@ -444,10 +445,16 @@ static void rpcclnt_fmtheader(FAR struct rpc_call_header
*ch,
ch->rp_vers = txdr_unsigned(vers);
ch->rp_proc = txdr_unsigned(procid);
- /* rpc_auth part (auth_null) */
+ /* rpc_auth part (auth_unix) */
- ch->rpc_auth.authtype = rpc_auth_null;
- ch->rpc_auth.authlen = 0;
+ ch->rpc_auth.authtype = rpc_auth_unix;
+ ch->rpc_auth.authlen = txdr_unsigned(sizeof(ch->rpc_unix));
+
+ ch->rpc_unix.stamp= 0;
+ ch->rpc_unix.hostname = 0;
+ ch->rpc_unix.uid = 0;
+ ch->rpc_unix.gid = 0;
+ ch->rpc_unix.gidlist = 0;
/* rpc_verf part (auth_null) */
@@ -475,6 +482,7 @@ void rpcclnt_init(void)
rpc_vers = txdr_unsigned(RPC_VER2);
rpc_call = txdr_unsigned(RPC_CALL);
rpc_auth_null = txdr_unsigned(RPCAUTH_NULL);
+ rpc_auth_unix = txdr_unsigned(RPCAUTH_UNIX);
finfo("RPC initialized\n");
}
[incubator-nuttx] branch master updated (de480b0 -> 3b53cd1)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from de480b0 fs/nfs: Add the simplest RPCAUTH_UNIX support add 3b53cd1 include/nuttx: Fix improper use of inline No new revisions were added by this update. Summary of changes: include/nuttx/cache.h | 20 +-- include/nuttx/semaphore.h | 23 ++ sched/semaphore/sem_tickwait.c | 43 - sched/semaphore/sem_timedwait.c | 42 +++- sched/semaphore/sem_wait.c | 35 - 5 files changed, 141 insertions(+), 22 deletions(-)
[GitHub] [incubator-nuttx] Ouss4 merged pull request #418: include/nuttx: Fix improper use of inline
Ouss4 merged pull request #418: include/nuttx: Fix improper use of inline URL: https://github.com/apache/incubator-nuttx/pull/418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] hartmannathan commented on issue #418: include/nuttx: Fix improper use of inline
hartmannathan commented on issue #418: include/nuttx: Fix improper use of inline URL: https://github.com/apache/incubator-nuttx/pull/418#issuecomment-593623352 On Mon, Mar 2, 2020 at 3:53 PM patacongo wrote: > I finally figured out why the ez80 code has gotten so big. It is because > people have been put putting big inline functions in header files. That is > a violation of the coding standard, since only c89 compatibility is > required in all common code. But we have been tolerating inline function it > because include/nuttx/compiler.h defines 'inline' to be nothing for C89 > compilers. > > As a result, static inline functions declared within a C file not so bad; > the inline qualifier is ignored, if not supported, but otherwise all is > well. > > But it is catastrophic in header files. Those static inline functions are > included as static functions and implemented in EVERY file that includes > those header files, even if the functions are never called. That makes the > code base huge!So there is another PR coming to fix some of the worst > offenders. > > This commit fixes two of the worst offenders I have encountered so far: > include/nuttx/sempahore.h and cache.h. But there may be a few other changes > needed. Under include/nuttx there are still inline functions thread.h, > inclue/nuttx/list.h, mutex.h, tree.h, and include/nuttx/crypto/blake2s.h > with no protection for compilers that do not handler the inline qualifier. > Otherwise we are clean. > > With the changes to these two header files, the size of the z20x build is > reduced by about 40%. And incredible size savings. > Wow that is significant!! Good catch! Nathan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch pr419 created (now 3b53cd1)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch pr419 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 3b53cd1 include/nuttx: Fix improper use of inline No new revisions were added by this update.
[incubator-nuttx] branch pr419 updated: arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch pr419 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/pr419 by this push: new 0be87af arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop 0be87af is described below commit 0be87af99d4b1bee2110e1378a2fb9767d6bf2c2 Author: Augusto Fraga Giachero AuthorDate: Mon Mar 2 16:34:54 2020 -0300 arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop Not canceling the I2C timeout watch dog immediately after finishing all I2C transactions in interrupt context can lead to a race condition due to nxsem_wait(&priv->wait) in lpc17_40_i2c_start() not resuming execution fast enough (this can be easily triggered if another task / thread is using a lot of cpu time). Falling to cancel the watchdog up to time will cause the priv->wait semaphore to be incremented twice (first by lpc17_40_i2c_stop() then by lpc17_40_i2c_timeout()), so all I2C transactions after that will return immediately and priv->msgs will hold pointers to memory it doesn't own anymore. Canceling the priv->timeout watch dog in lpc17_40_i2c_stop() prevents this as it is executed from the I2C interrupt handler. arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Fix timeout calculation For each byte received / transmitted, an acknowledge bit is also transmitted / received, requiring effectively 9 bits for each byte. --- arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c b/arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c index f6e43d3..2052e7b 100644 --- a/arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c +++ b/arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c @@ -232,7 +232,7 @@ static int lpc17_40_i2c_start(struct lpc17_40_i2cdev_s *priv) /* Calculate the approximate timeout */ - timeout = ((total_len * (800 / CONFIG_USEC_PER_TICK)) / freq) + 1; + timeout = ((total_len * (900 / CONFIG_USEC_PER_TICK)) / freq) + 1; /* Initializes the I2C state machine to a known value */ @@ -242,8 +242,6 @@ static int lpc17_40_i2c_start(struct lpc17_40_i2cdev_s *priv) (uint32_t)priv); nxsem_wait(&priv->wait); - wd_cancel(priv->timeout); - return priv->nmsg; } @@ -263,6 +261,7 @@ static void lpc17_40_i2c_stop(struct lpc17_40_i2cdev_s *priv) priv->base + LPC17_40_I2C_CONSET_OFFSET); } + wd_cancel(priv->timeout); nxsem_post(&priv->wait); }
[GitHub] [incubator-nuttx] Ouss4 merged pull request #419: arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop
Ouss4 merged pull request #419: arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop URL: https://github.com/apache/incubator-nuttx/pull/419 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] dagar opened a new pull request #420: stm32, stm32f7, stm32h7 add SPI DMATHRESHOLD
dagar opened a new pull request #420: stm32, stm32f7, stm32h7 add SPI DMATHRESHOLD URL: https://github.com/apache/incubator-nuttx/pull/420 This adds a SPI DMA threshold for stm32, stm32f7, and stm32h7 similar to what exists for sam34, sama5, samv7, etc. I've also split it out so that it's possible to enable separately from DMACAPABLE which can be problematic for stm32f7/h7 with dcache writeback enabled (transfer buffer mend dcache alignment check). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (3b53cd1 -> 0be87af)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 3b53cd1 include/nuttx: Fix improper use of inline add 0be87af arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop No new revisions were added by this update. Summary of changes: arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
[GitHub] [incubator-nuttx] patacongo commented on issue #418: include/nuttx: Fix improper use of inline
patacongo commented on issue #418: include/nuttx: Fix improper use of inline URL: https://github.com/apache/incubator-nuttx/pull/418#issuecomment-593641243 > Wow that is significant!! Yes... the inline functions are not really large. However, almost every C file in system includes nuttx/semaphore.h, either directly or indirectly. With several hundreds of C files and several hundreds of copies of these functions, it adds up. I expect to see a size improvement, but I as also rather astounded by the magnitude of the savings. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #418: include/nuttx: Fix improper use of inline
patacongo edited a comment on issue #418: include/nuttx: Fix improper use of inline URL: https://github.com/apache/incubator-nuttx/pull/418#issuecomment-593641243 > Wow that is significant!! Yes... the inline functions are not really large. However, almost every C file in system includes nuttx/semaphore.h, either directly or indirectly. And most OS files included cache.h, directly or indirectly. With several hundreds of C files and several hundreds of copies of these functions, it adds up. I expect to see a size improvement, but I was also rather astounded by the magnitude of the savings. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch pr420 created (now 0be87af)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch pr420 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 0be87af arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop No new revisions were added by this update.
[GitHub] [incubator-nuttx] Ouss4 merged pull request #420: stm32, stm32f7, stm32h7 add SPI DMATHRESHOLD
Ouss4 merged pull request #420: stm32, stm32f7, stm32h7 add SPI DMATHRESHOLD URL: https://github.com/apache/incubator-nuttx/pull/420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] 01/04: arm/stm32 add STM32_SPI_DMATHRESHOLD
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch pr420
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit afb2248b7a47ec4ab72f10fe21100d538af67934
Author: Daniel Agar
AuthorDate: Mon Mar 2 16:02:54 2020 -0500
arm/stm32 add STM32_SPI_DMATHRESHOLD
---
arch/arm/src/stm32/Kconfig | 9 +
arch/arm/src/stm32/stm32_spi.c | 31 +++
2 files changed, 36 insertions(+), 4 deletions(-)
diff --git a/arch/arm/src/stm32/Kconfig b/arch/arm/src/stm32/Kconfig
index 4b5be6e..e6851a5 100644
--- a/arch/arm/src/stm32/Kconfig
+++ b/arch/arm/src/stm32/Kconfig
@@ -8820,6 +8820,15 @@ config STM32_SPI1_DMA
---help---
Use DMA to improve SPI1 transfer performance.
+config STM32_SPI_DMATHRESHOLD
+ int "SPI DMA threshold"
+ default 4
+ depends on STM32_SPI_DMA
+ ---help---
+ When SPI DMA is enabled, small DMA transfers will still be
performed
+ by polling logic. But we need a threshold value to determine
what
+ is small.
+
config STM32_SPI2_DMA
bool "SPI2 DMA"
default n
diff --git a/arch/arm/src/stm32/stm32_spi.c b/arch/arm/src/stm32/stm32_spi.c
index 5c651a6..293b45e 100644
--- a/arch/arm/src/stm32/stm32_spi.c
+++ b/arch/arm/src/stm32/stm32_spi.c
@@ -1677,17 +1677,40 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR
const void *txbuffer,
{
FAR struct stm32_spidev_s *priv = (FAR struct stm32_spidev_s *)dev;
-#ifdef CONFIG_STM32_DMACAPABLE
+ DEBUGASSERT(priv != NULL);
+
+#ifdef CONFIG_STM32_SPI_DMATHRESHOLD
+ /* Convert the number of word to a number of bytes */
+
+ size_t nbytes = (priv->nbits > 8) ? nwords << 1 : nwords;
+
+ /* If this is a small SPI transfer, then let spi_exchange_nodma() do the
work. */
+
+ if (nbytes <= CONFIG_STM32_SPI_DMATHRESHOLD)
+{
+ spi_exchange_nodma(dev, txbuffer, rxbuffer, nwords);
+ return;
+}
+#endif
+
if ((priv->rxdma == NULL) || (priv->txdma == NULL) ||
- (txbuffer && !stm32_dmacapable((uint32_t)txbuffer, nwords, priv->txccr))
||
- (rxbuffer && !stm32_dmacapable((uint32_t)rxbuffer, nwords, priv->rxccr))
||
up_interrupt_context())
{
- /* Invalid DMA channels, unsupported memory region, or interrupt
context, fall
+ /* Invalid DMA channels, or interrupt context, fall
* back to non-DMA method.
*/
spi_exchange_nodma(dev, txbuffer, rxbuffer, nwords);
+ return;
+}
+
+#ifdef CONFIG_STM32_DMACAPABLE
+ if ((txbuffer && !stm32_dmacapable((uint32_t)txbuffer, nwords, priv->txccr))
||
+ (rxbuffer && !stm32_dmacapable((uint32_t)rxbuffer, nwords, priv->rxccr)))
+{
+ /* Unsupported memory region fall back to non-DMA method. */
+
+ spi_exchange_nodma(dev, txbuffer, rxbuffer, nwords);
}
else
#endif
[incubator-nuttx] 02/04: arm/stm32f7 add STM32F7_SPI_DMATHRESHOLD
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch pr420
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 608b59792e4b1c1d8aa85f4016d3fdc831409796
Author: Daniel Agar
AuthorDate: Mon Mar 2 16:03:15 2020 -0500
arm/stm32f7 add STM32F7_SPI_DMATHRESHOLD
---
arch/arm/src/stm32f7/Kconfig | 9 +
arch/arm/src/stm32f7/stm32_spi.c | 33 -
2 files changed, 37 insertions(+), 5 deletions(-)
diff --git a/arch/arm/src/stm32f7/Kconfig b/arch/arm/src/stm32f7/Kconfig
index d6a5e57..806022b 100644
--- a/arch/arm/src/stm32f7/Kconfig
+++ b/arch/arm/src/stm32f7/Kconfig
@@ -2287,6 +2287,15 @@ config STM32F7_SPI_DMA
---help---
Use DMA to improve SPI transfer performance. Cannot be used
with STM32F7_SPI_INTERRUPT.
+config STM32F7_SPI_DMATHRESHOLD
+ int "SPI DMA threshold"
+ default 4
+ depends on STM32F7_SPI_DMA
+ ---help---
+ When SPI DMA is enabled, small DMA transfers will still be
performed
+ by polling logic. But we need a threshold value to determine
what
+ is small.
+
config STM32F7_SPI1_DMA
bool "SPI1 DMA"
default n
diff --git a/arch/arm/src/stm32f7/stm32_spi.c b/arch/arm/src/stm32f7/stm32_spi.c
index 2a3cc782..402f119 100644
--- a/arch/arm/src/stm32f7/stm32_spi.c
+++ b/arch/arm/src/stm32f7/stm32_spi.c
@@ -1646,13 +1646,36 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR
const void *txbuffer,
DEBUGASSERT(priv != NULL);
-#ifdef CONFIG_STM32F7_DMACAPABLE
+#ifdef CONFIG_STM32F7_SPI_DMATHRESHOLD
+ /* Convert the number of word to a number of bytes */
+
+ size_t nbytes = (priv->nbits > 8) ? nwords << 1 : nwords;
+
+ /* If this is a small SPI transfer, then let spi_exchange_nodma() do the
work. */
+
+ if (nbytes <= CONFIG_STM32F7_SPI_DMATHRESHOLD)
+{
+ spi_exchange_nodma(dev, txbuffer, rxbuffer, nwords);
+ return;
+}
+#endif
+
if ((priv->rxdma == NULL) || (priv->txdma == NULL) ||
- (txbuffer && !stm32_dmacapable((uint32_t)txbuffer, nwords, priv->txccr))
||
- (rxbuffer && !stm32_dmacapable((uint32_t)rxbuffer, nwords, priv->rxccr))
||
- up_interrupt_context() || nwords < CONFIG_STM32F7_SPI_DMA_THRESHOLD)
+ up_interrupt_context())
+{
+ /* Invalid DMA channels, or interrupt context, fall
+ * back to non-DMA method.
+ */
+
+ spi_exchange_nodma(dev, txbuffer, rxbuffer, nwords);
+ return;
+}
+
+#ifdef CONFIG_STM32F7_DMACAPABLE
+ if ((txbuffer && !stm32_dmacapable((uint32_t)txbuffer, nwords, priv->txccr))
||
+ (rxbuffer && !stm32_dmacapable((uint32_t)rxbuffer, nwords, priv->rxccr)))
{
- /* Invalid DMA channels, unsupported memory region, or interrupt
context, fall back to non-DMA method. */
+ /* Unsupported memory region fall back to non-DMA method. */
spi_exchange_nodma(dev, txbuffer, rxbuffer, nwords);
}
[incubator-nuttx] 04/04: arm/stm32h7 add STM32H7_SPI_DMATHRESHOLD
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch pr420
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 30a48e4217bb796d199e92cbf99e6c7b67d09ab6
Author: Daniel Agar
AuthorDate: Mon Mar 2 16:08:11 2020 -0500
arm/stm32h7 add STM32H7_SPI_DMATHRESHOLD
---
arch/arm/src/stm32h7/Kconfig | 9 +
arch/arm/src/stm32h7/stm32_spi.c | 27 ++-
2 files changed, 35 insertions(+), 1 deletion(-)
diff --git a/arch/arm/src/stm32h7/Kconfig b/arch/arm/src/stm32h7/Kconfig
index 2b552ce..9c89be3 100644
--- a/arch/arm/src/stm32h7/Kconfig
+++ b/arch/arm/src/stm32h7/Kconfig
@@ -612,6 +612,15 @@ config STM32H7_SPI_DMA
---help---
Use DMA to improve SPI transfer performance. Cannot be used
with STM32H7_SPI_INTERRUPT.
+config STM32H7_SPI_DMATHRESHOLD
+ int "SPI DMA threshold"
+ default 4
+ depends on STM32H7_SPI_DMA
+ ---help---
+ When SPI DMA is enabled, small DMA transfers will still be
performed
+ by polling logic. But we need a threshold value to determine
what
+ is small.
+
endmenu # "SPI Configuration"
menu "U[S]ART Configuration"
diff --git a/arch/arm/src/stm32h7/stm32_spi.c b/arch/arm/src/stm32h7/stm32_spi.c
index df3fc14..b8447c8 100644
--- a/arch/arm/src/stm32h7/stm32_spi.c
+++ b/arch/arm/src/stm32h7/stm32_spi.c
@@ -1716,6 +1716,31 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR
const void *txbuffer,
DEBUGASSERT(priv != NULL);
+#ifdef CONFIG_STM32H7_SPI_DMATHRESHOLD
+ /* Convert the number of word to a number of bytes */
+
+ size_t nbytes = (priv->nbits > 8) ? nwords << 1 : nwords;
+
+ /* If this is a small SPI transfer, then let spi_exchange_nodma() do the
work. */
+
+ if (nbytes <= CONFIG_STM32H7_SPI_DMATHRESHOLD)
+{
+ spi_exchange_nodma(dev, txbuffer, rxbuffer, nwords);
+ return;
+}
+#endif
+
+ if ((priv->rxdma == NULL) || (priv->txdma == NULL) ||
+ up_interrupt_context())
+{
+ /* Invalid DMA channels, or interrupt context, fall
+ * back to non-DMA method.
+ */
+
+ spi_exchange_nodma(dev, txbuffer, rxbuffer, nwords);
+ return;
+}
+
#ifdef CONFIG_STM32H7_DMACAPABLE
stm32_dmacfg_t dmacfg1;
stm32_dmacfg_t dmacfg2;
@@ -1735,7 +1760,7 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR
const void *txbuffer,
if ((txbuffer && !stm32_dmacapable(priv->txdma, &dmacfg1)) ||
(rxbuffer && !stm32_dmacapable(priv->rxdma, &dmacfg2)))
{
- /* Unsupported memory region, fall back to non-DMA method. */
+ /* Unsupported memory region fall back to non-DMA method. */
spi_exchange_nodma(dev, txbuffer, rxbuffer, nwords);
}
[incubator-nuttx] branch pr420 updated (0be87af -> 30a48e4)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch pr420 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 0be87af arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop new afb2248 arm/stm32 add STM32_SPI_DMATHRESHOLD new 608b597 arm/stm32f7 add STM32F7_SPI_DMATHRESHOLD new c10fbbb stm32f76xx77xx_dma.h fix DMAMAP_SPI2_RX_2/DMAMAP_SPI2_TX_2 new 30a48e4 arm/stm32h7 add STM32H7_SPI_DMATHRESHOLD The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: arch/arm/src/stm32/Kconfig | 9 ++ arch/arm/src/stm32/stm32_spi.c | 31 +--- arch/arm/src/stm32f7/Kconfig | 9 ++ arch/arm/src/stm32f7/hardware/stm32f76xx77xx_dma.h | 4 +-- arch/arm/src/stm32f7/stm32_spi.c | 33 ++ arch/arm/src/stm32h7/Kconfig | 9 ++ arch/arm/src/stm32h7/stm32_spi.c | 27 +- 7 files changed, 110 insertions(+), 12 deletions(-)
[incubator-nuttx] 03/04: stm32f76xx77xx_dma.h fix DMAMAP_SPI2_RX_2/DMAMAP_SPI2_TX_2
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch pr420 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit c10f5fd5617690c2509c13939d3291d8f007 Author: Daniel Agar AuthorDate: Mon Mar 2 16:07:49 2020 -0500 stm32f76xx77xx_dma.h fix DMAMAP_SPI2_RX_2/DMAMAP_SPI2_TX_2 --- arch/arm/src/stm32f7/hardware/stm32f76xx77xx_dma.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/src/stm32f7/hardware/stm32f76xx77xx_dma.h b/arch/arm/src/stm32f7/hardware/stm32f76xx77xx_dma.h index f26469c..8e708cc 100644 --- a/arch/arm/src/stm32f7/hardware/stm32f76xx77xx_dma.h +++ b/arch/arm/src/stm32f7/hardware/stm32f76xx77xx_dma.h @@ -415,8 +415,8 @@ #define DMAMAP_SPI3_RX_1 STM32_DMA_MAP(DMA1,DMA_STREAM0,DMA_CHAN0) #define DMAMAP_SPDIFRX_DT STM32_DMA_MAP(DMA1,DMA_STREAM1,DMA_CHAN0) #define DMAMAP_SPI3_RX_2 STM32_DMA_MAP(DMA1,DMA_STREAM2,DMA_CHAN0) -#define DMAMAP_SPI2_RX STM32_DMA_MAP(DMA1,DMA_STREAM3,DMA_CHAN0) -#define DMAMAP_SPI2_TX STM32_DMA_MAP(DMA1,DMA_STREAM4,DMA_CHAN0) +#define DMAMAP_SPI2_RX_2 STM32_DMA_MAP(DMA1,DMA_STREAM3,DMA_CHAN0) +#define DMAMAP_SPI2_TX_2 STM32_DMA_MAP(DMA1,DMA_STREAM4,DMA_CHAN0) #define DMAMAP_SPI3_TX_1 STM32_DMA_MAP(DMA1,DMA_STREAM5,DMA_CHAN0) #define DMAMAP_SPDIFRX_CS STM32_DMA_MAP(DMA1,DMA_STREAM6,DMA_CHAN0) #define DMAMAP_SPI3_TX_2 STM32_DMA_MAP(DMA1,DMA_STREAM7,DMA_CHAN0)
[incubator-nuttx] branch master updated (0be87af -> 30a48e4)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 0be87af arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop add afb2248 arm/stm32 add STM32_SPI_DMATHRESHOLD add 608b597 arm/stm32f7 add STM32F7_SPI_DMATHRESHOLD add c10fbbb stm32f76xx77xx_dma.h fix DMAMAP_SPI2_RX_2/DMAMAP_SPI2_TX_2 add 30a48e4 arm/stm32h7 add STM32H7_SPI_DMATHRESHOLD No new revisions were added by this update. Summary of changes: arch/arm/src/stm32/Kconfig | 9 ++ arch/arm/src/stm32/stm32_spi.c | 31 +--- arch/arm/src/stm32f7/Kconfig | 9 ++ arch/arm/src/stm32f7/hardware/stm32f76xx77xx_dma.h | 4 +-- arch/arm/src/stm32f7/stm32_spi.c | 33 ++ arch/arm/src/stm32h7/Kconfig | 9 ++ arch/arm/src/stm32h7/stm32_spi.c | 27 +- 7 files changed, 110 insertions(+), 12 deletions(-)
[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593733806 do you mean non-CONFIG_SUPPRESS_CLOCK_CONFIG code can work? i don't think it even compile. i agree it's better to fix it though. i don't know how it was. but at this point the source code of the bootloader and hal are available. and they seem to hardcode 80MHz. TizenRT just uses "#define BOARD_CLOCK_FREQUENCY (2 * BOARD_XTAL_FREQUENCY)" unconditionally. which is 80MHz in case of CONFIG_ESP32CORE_XTAL_40MZ. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #380: arm: Fix "make export" for KERNEL build
xiaoxiang781216 commented on issue #380: arm: Fix "make export" for KERNEL build URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-593754685 @yamt could you review the new change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #380: arm: Fix "make export" for KERNEL build
yamt commented on issue #380: arm: Fix "make export" for KERNEL build URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-593761349 @xiaoxiang781216 my understanding is that it isn't appropriate to add crt0.c to CMN_CSRCS as it's for kernel sources. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #380: arm: Fix "make export" for KERNEL build
xiaoxiang781216 commented on issue #380: arm: Fix "make export" for KERNEL build URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-593762190 > @xiaoxiang781216 my understanding is that it isn't appropriate to add crt0.c to CMN_CSRCS as it's for kernel sources. Good point, I will change to CMN_UCSRCS. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #380: arm: Fix "make export" for KERNEL build
yamt commented on issue #380: arm: Fix "make export" for KERNEL build URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-593767980 @xiaoxiang781216 what ensures UOBJS built before STARTUP_OBJS is being used? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #421: mkexport: Deal with ARCHSCRIPT containing multiple files
yamt opened a new pull request #421: mkexport: Deal with ARCHSCRIPT containing multiple files URL: https://github.com/apache/incubator-nuttx/pull/421 This fixes "make export" for esp32-core. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #380: arm: Fix "make export" for KERNEL build
xiaoxiang781216 commented on issue #380: arm: Fix "make export" for KERNEL build URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-593770744 > @xiaoxiang781216 what ensures UOBJS built before STARTUP_OBJS is being used? export_startup depend on STARTUP_OBJS, so it isn't an issue, but UOBJS will be archived libuarch.a which mayn't what we want. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593815244 in my opion this is the proper fix instead of hardcoding it #define BOARD_CLOCK_FREQUENCY (2 * BOARD_XTAL_FREQUENCY) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
