[jira] [Commented] (OPENMEETINGS-2298) Add KStream to Admin>Connections
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093014#comment-17093014 ] ASF subversion and git services commented on OPENMEETINGS-2298: --- Commit daed6b4e421c92b738889feb1eda4602321e4544 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=daed6b4 ] Merge pull request #67 from apache/feature/OPENMEETINGS-2298-add-kstream-to-connections-panel OPENMEETINGS-2298 add kstream to connections panel > Add KStream to Admin>Connections > > > Key: OPENMEETINGS-2298 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2298 > Project: Openmeetings > Issue Type: New Feature > Components: Admin, Kurento >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: [https://markmail.org/thread/25ym4cqjkz6xntwd] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2298) Add KStream to Admin>Connections
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093009#comment-17093009 ] ASF subversion and git services commented on OPENMEETINGS-2298: --- Commit 7d29a2888958c0ee0f81f4fbb37942f0d3576bc2 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=7d29a28 ] OPENMEETINGS-2298 Add KStream to admin panel. Add methods to create relevant lists > Add KStream to Admin>Connections > > > Key: OPENMEETINGS-2298 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2298 > Project: Openmeetings > Issue Type: New Feature > Components: Admin, Kurento >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: [https://markmail.org/thread/25ym4cqjkz6xntwd] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2298) Add KStream to Admin>Connections
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093011#comment-17093011 ] ASF subversion and git services commented on OPENMEETINGS-2298: --- Commit ea51b99a9a0d89a133f677845e0df4f03b4da81f in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=ea51b99 ] OPENMEETINGS-2298 Fix and remove unused import > Add KStream to Admin>Connections > > > Key: OPENMEETINGS-2298 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2298 > Project: Openmeetings > Issue Type: New Feature > Components: Admin, Kurento >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: [https://markmail.org/thread/25ym4cqjkz6xntwd] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2298) Add KStream to Admin>Connections
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093012#comment-17093012 ] ASF subversion and git services commented on OPENMEETINGS-2298: --- Commit 35816a7cfdbf49e03a6c7c5f0b0da1c231cd88d2 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=35816a7 ] OPENMEETINGS-2298 Remove test since I moved the method out of KurentoHandler since its more a admin/diagnostic method > Add KStream to Admin>Connections > > > Key: OPENMEETINGS-2298 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2298 > Project: Openmeetings > Issue Type: New Feature > Components: Admin, Kurento >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: [https://markmail.org/thread/25ym4cqjkz6xntwd] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2298) Add KStream to Admin>Connections
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093015#comment-17093015 ] ASF subversion and git services commented on OPENMEETINGS-2298: --- Commit daed6b4e421c92b738889feb1eda4602321e4544 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=daed6b4 ] Merge pull request #67 from apache/feature/OPENMEETINGS-2298-add-kstream-to-connections-panel OPENMEETINGS-2298 add kstream to connections panel > Add KStream to Admin>Connections > > > Key: OPENMEETINGS-2298 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2298 > Project: Openmeetings > Issue Type: New Feature > Components: Admin, Kurento >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: [https://markmail.org/thread/25ym4cqjkz6xntwd] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2298) Add KStream to Admin>Connections
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093013#comment-17093013 ] ASF subversion and git services commented on OPENMEETINGS-2298: --- Commit 2e202df525405c8896c6dfaeec3c475a747e5769 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=2e202df ] OPENMEETINGS-2298 Remove kick button untill functionality is there. Create new ticket for Kick functionality on KStream > Add KStream to Admin>Connections > > > Key: OPENMEETINGS-2298 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2298 > Project: Openmeetings > Issue Type: New Feature > Components: Admin, Kurento >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: [https://markmail.org/thread/25ym4cqjkz6xntwd] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2298) Add KStream to Admin>Connections
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093010#comment-17093010 ] ASF subversion and git services commented on OPENMEETINGS-2298: --- Commit 0ea288c3807d67a2356f4a4e7fccf8296e07d83f in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=0ea288c ] OPENMEETINGS-2298 Move method to combine KStream lists into Admin panel. Serialise into common object for Client and KStream. Fix display. > Add KStream to Admin>Connections > > > Key: OPENMEETINGS-2298 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2298 > Project: Openmeetings > Issue Type: New Feature > Components: Admin, Kurento >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: [https://markmail.org/thread/25ym4cqjkz6xntwd] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] 01/01: Merge pull request #67 from apache/feature/OPENMEETINGS-2298-add-kstream-to-connections-panel
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git commit daed6b4e421c92b738889feb1eda4602321e4544 Merge: ec97fd7 2e202df Author: Sebastian Wagner AuthorDate: Mon Apr 27 17:06:11 2020 +1200 Merge pull request #67 from apache/feature/OPENMEETINGS-2298-add-kstream-to-connections-panel OPENMEETINGS-2298 add kstream to connections panel .../apache/openmeetings/core/remote/KStream.java | 35 .../openmeetings/core/remote/KurentoHandler.java | 5 + .../openmeetings/core/remote/StreamProcessor.java | 5 + .../web/admin/connection/ConnectionsPanel.java | 188 + .../admin/connection/dto/ConnectionListItem.java | 70 .../connection/dto/ConnectionListKStreamItem.java | 103 +++ 6 files changed, 374 insertions(+), 32 deletions(-)
[openmeetings] branch master updated (ec97fd7 -> daed6b4)
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git. from ec97fd7 Merge pull request #68 from apache/feature/OPENMEETINGS-2299-add-unit-tests-for-recording-feature add 7d29a28 OPENMEETINGS-2298 Add KStream to admin panel. Add methods to create relevant lists add 0ea288c OPENMEETINGS-2298 Move method to combine KStream lists into Admin panel. Serialise into common object for Client and KStream. Fix display. add ea51b99 OPENMEETINGS-2298 Fix and remove unused import add 35816a7 OPENMEETINGS-2298 Remove test since I moved the method out of KurentoHandler since its more a admin/diagnostic method add 2e202df OPENMEETINGS-2298 Remove kick button untill functionality is there. Create new ticket for Kick functionality on KStream new daed6b4 Merge pull request #67 from apache/feature/OPENMEETINGS-2298-add-kstream-to-connections-panel The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/openmeetings/core/remote/KStream.java | 35 .../openmeetings/core/remote/KurentoHandler.java | 5 + .../openmeetings/core/remote/StreamProcessor.java | 5 + .../web/admin/connection/ConnectionsPanel.java | 188 + .../admin/connection/dto/ConnectionListItem.java | 70 .../connection/dto/ConnectionListKStreamItem.java | 103 +++ 6 files changed, 374 insertions(+), 32 deletions(-) create mode 100644 openmeetings-web/src/main/java/org/apache/openmeetings/web/admin/connection/dto/ConnectionListItem.java create mode 100644 openmeetings-web/src/main/java/org/apache/openmeetings/web/admin/connection/dto/ConnectionListKStreamItem.java
[jira] [Commented] (OPENMEETINGS-2307) Enable Maven-checkstyle-plugin
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092985#comment-17092985 ] ASF subversion and git services commented on OPENMEETINGS-2307: --- Commit c2ed6b9a65159154e56d9bbe38fb380c4473e000 in openmeetings's branch refs/heads/feature/OPENMEETINGS-2307-enable-checkstyle-with-simplest-rule-set from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=c2ed6b9 ] [OPENMEETINGS-2307] checkstyle rules are specified inline, additional rules for identation and trailing spaces are added > Enable Maven-checkstyle-plugin > -- > > Key: OPENMEETINGS-2307 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2307 > Project: Openmeetings > Issue Type: Improvement > Components: Builds >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > I noticed that I don't get any build errors or warnings with unused imports. > I thought there is a checkstyle plugin running as part of Apache reports. > But there isn't. > There is a plugin here: > [http://maven.apache.org/plugins/maven-checkstyle-plugin/index.html] > I think it reveals a lot of useful information. Doesn't mean we fix all of > it. But its very helpful. > It may also generate a nice report: > [http://maven.apache.org/plugins-archives/maven-project-info-reports-plugin-LATEST/checkstyle.html] > Which can be useful once more people work on code, so you don't need to > review syntax and code smells in every PR manually. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch feature/OPENMEETINGS-2307-enable-checkstyle-with-simplest-rule-set updated (fa3110d -> c2ed6b9)
This is an automated email from the ASF dual-hosted git repository. solomax pushed a change to branch feature/OPENMEETINGS-2307-enable-checkstyle-with-simplest-rule-set in repository https://gitbox.apache.org/repos/asf/openmeetings.git. from fa3110d OPENMEETINGS-2307 Add checkstyle check with only checking for unused imports. Remove unused imports. add c2ed6b9 [OPENMEETINGS-2307] checkstyle rules are specified inline, additional rules for identation and trailing spaces are added No new revisions were added by this update. Summary of changes: openmeetings-core/pom.xml | 1 - .../org/apache/openmeetings/core/remote/KRoom.java | 2 +- .../apache/openmeetings/core/remote/KStream.java | 1 - .../openmeetings/core/remote/StreamProcessor.java | 12 +- .../core/remote/TestRecordingFlowMocked.java | 74 - openmeetings-db/pom.xml| 1 - .../openmeetings/db/entity/file/FileItemTest.java | 58 +++ openmeetings-install/pom.xml | 1 - openmeetings-screenshare/pom.xml | 1 - openmeetings-server/pom.xml| 1 - openmeetings-service/pom.xml | 1 - .../caldav/handler/AbstractCalendarHandler.java| 3 +- .../calendar/caldav/handler/CtagHandler.java | 15 +- .../calendar/caldav/handler/MultigetHandler.java | 9 +- .../calendar/caldav/handler/WebDAVSyncHandler.java | 6 +- openmeetings-util/pom.xml | 1 - openmeetings-web/pom.xml | 1 - .../common/confirmation/ConfirmationBehavior.java | 92 ++- .../common/confirmation/ConfirmationConfig.java| 168 ++--- .../openmeetings/web/pages/auth/SignInDialog.java | 2 +- .../web/util/TouchPunchResourceReference.java | 32 ++-- .../calendar/TestDatabaseStructureUsersSearch.java | 43 -- openmeetings-webservice/pom.xml| 1 - pom.xml| 34 - src/config/openmeetings_checkstyle.xml | 33 25 files changed, 266 insertions(+), 327 deletions(-) delete mode 100644 openmeetings-web/src/test/java/org/apache/openmeetings/calendar/TestDatabaseStructureUsersSearch.java delete mode 100644 src/config/openmeetings_checkstyle.xml
[jira] [Commented] (OPENMEETINGS-2308) Android bootstrap touch event doesn't work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092983#comment-17092983 ] Maxim Solodovnik commented on OPENMEETINGS-2308: I believe it worth to share "code" and "stacktrace", not their screen-shots :) This function is defined here https://github.com/sebfz1/wicket-jquery-ui/blob/wicket9.x/wicket-jquery-ui-plugins/src/main/resources/com/googlecode/wicket/jquery/ui/plugins/wysiwyg/resource/js/bootstrap-wysiwyg.js#L181 I'll try to check > Android bootstrap touch event doesn't work > -- > > Key: OPENMEETINGS-2308 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2308 > Project: Openmeetings > Issue Type: Bug >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-51-25-519.png, > image-2020-04-27-15-52-26-864.png, image-2020-04-27-15-53-06-418.png > > > Under Android you get a lot of exceptions like this: > !image-2020-04-27-15-51-25-519.png|width=1302,height=215! > Almost every click event fails. > Clicking in the Android remote debugger you can find this code snippet > referenced that doesn't work: > !image-2020-04-27-15-53-06-418.png|width=644,height=315! > That must be some bootstrap issue. Coming from the Wicket module. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2308) Android bootstrap touch event doesn't work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092981#comment-17092981 ] Sebastian Wagner commented on OPENMEETINGS-2308: It may seem like an issue with the plugin code from apache-wicket jQuery plugin. So I logged an issue here: [https://github.com/sebfz1/wicket-jquery-ui/issues/315] Will see if they have an idea about what the issue is. > Android bootstrap touch event doesn't work > -- > > Key: OPENMEETINGS-2308 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2308 > Project: Openmeetings > Issue Type: Bug >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-51-25-519.png, > image-2020-04-27-15-52-26-864.png, image-2020-04-27-15-53-06-418.png > > > Under Android you get a lot of exceptions like this: > !image-2020-04-27-15-51-25-519.png|width=1302,height=215! > Almost every click event fails. > Clicking in the Android remote debugger you can find this code snippet > referenced that doesn't work: > !image-2020-04-27-15-53-06-418.png|width=644,height=315! > That must be some bootstrap issue. Coming from the Wicket module. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OPENMEETINGS-2308) Android bootstrap touch event doesn't work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092979#comment-17092979 ] Sebastian Wagner edited comment on OPENMEETINGS-2308 at 4/27/20, 3:59 AM: -- Which is this code: [https://github.com/sebfz1/wicket-jquery-ui/blob/wicket9.x/wicket-jquery-ui-plugins/src/main/resources/com/googlecode/wicket/jquery/ui/plugins/wysiwyg/resource/js/bootstrap-wysiwyg.js#L64] this.getCurrentRange() is undefined. was (Author: sebawagner): Which is this code: [https://github.com/sebfz1/wicket-jquery-ui/blob/wicket8.x/wicket-jquery-ui-plugins/src/main/resources/com/googlecode/wicket/jquery/ui/plugins/wysiwyg/resource/js/bootstrap-wysiwyg.js#L64] this.getCurrentRange() is undefined. > Android bootstrap touch event doesn't work > -- > > Key: OPENMEETINGS-2308 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2308 > Project: Openmeetings > Issue Type: Bug >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-51-25-519.png, > image-2020-04-27-15-52-26-864.png, image-2020-04-27-15-53-06-418.png > > > Under Android you get a lot of exceptions like this: > !image-2020-04-27-15-51-25-519.png|width=1302,height=215! > Almost every click event fails. > Clicking in the Android remote debugger you can find this code snippet > referenced that doesn't work: > !image-2020-04-27-15-53-06-418.png|width=644,height=315! > That must be some bootstrap issue. Coming from the Wicket module. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2308) Android bootstrap touch event doesn't work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092979#comment-17092979 ] Sebastian Wagner commented on OPENMEETINGS-2308: Which is this code: [https://github.com/sebfz1/wicket-jquery-ui/blob/wicket8.x/wicket-jquery-ui-plugins/src/main/resources/com/googlecode/wicket/jquery/ui/plugins/wysiwyg/resource/js/bootstrap-wysiwyg.js#L64] this.getCurrentRange() is undefined. > Android bootstrap touch event doesn't work > -- > > Key: OPENMEETINGS-2308 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2308 > Project: Openmeetings > Issue Type: Bug >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-51-25-519.png, > image-2020-04-27-15-52-26-864.png, image-2020-04-27-15-53-06-418.png > > > Under Android you get a lot of exceptions like this: > !image-2020-04-27-15-51-25-519.png|width=1302,height=215! > Almost every click event fails. > Clicking in the Android remote debugger you can find this code snippet > referenced that doesn't work: > !image-2020-04-27-15-53-06-418.png|width=644,height=315! > That must be some bootstrap issue. Coming from the Wicket module. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2308) Android bootstrap touch event doesn't work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2308: --- Issue Type: Bug (was: New Feature) > Android bootstrap touch event doesn't work > -- > > Key: OPENMEETINGS-2308 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2308 > Project: Openmeetings > Issue Type: Bug >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-51-25-519.png, > image-2020-04-27-15-52-26-864.png, image-2020-04-27-15-53-06-418.png > > > Under Android you get a lot of exceptions like this: > !image-2020-04-27-15-51-25-519.png|width=1302,height=215! > Almost every click event fails. > Clicking in the Android remote debugger you can find this code snippet > referenced that doesn't work: > !image-2020-04-27-15-53-06-418.png|width=644,height=315! > That must be some bootstrap issue. Coming from the Wicket module. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2308) Android bootstrap touch event doesn't work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2308: --- Attachment: image-2020-04-27-15-53-06-418.png > Android bootstrap touch event doesn't work > -- > > Key: OPENMEETINGS-2308 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2308 > Project: Openmeetings > Issue Type: New Feature >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-51-25-519.png, > image-2020-04-27-15-52-26-864.png, image-2020-04-27-15-53-06-418.png > > > Under Android you get a lot of exceptions like this: > !image-2020-04-27-15-51-25-519.png|width=1302,height=215! > Almost every click event fails. > Clicking in the Android remote debugger you can find this code snippet > referenced that doesn't work: > !image-2020-04-27-15-52-26-864.png|width=1114,height=184! > > $( window ).bind( "touchend", function( e ) { > var isInside = ( editor.is( e.target ) || editor.has( e.target ).length > 0 > ), > currentRange = this.getCurrentRange(), > clear = currentRange && ( currentRange.startContainer === > currentRange.endContainer && currentRange.startOffset === > currentRange.endOffset ); > if ( !clear || isInside ) { > this.saveSelection(); > this.updateToolbar( editor, toolbarBtnSelector, options ); > } > } ); -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2308) Android bootstrap touch event doesn't work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2308: --- Description: Under Android you get a lot of exceptions like this: !image-2020-04-27-15-51-25-519.png|width=1302,height=215! Almost every click event fails. Clicking in the Android remote debugger you can find this code snippet referenced that doesn't work: !image-2020-04-27-15-53-06-418.png|width=644,height=315! $( window ).bind( "touchend", function( e ) { var isInside = ( editor.is( e.target ) || editor.has( e.target ).length > 0 ), currentRange = this.getCurrentRange(), clear = currentRange && ( currentRange.startContainer === currentRange.endContainer && currentRange.startOffset === currentRange.endOffset ); if ( !clear || isInside ) { this.saveSelection(); this.updateToolbar( editor, toolbarBtnSelector, options ); } } ); was: Under Android you get a lot of exceptions like this: !image-2020-04-27-15-51-25-519.png|width=1302,height=215! Almost every click event fails. Clicking in the Android remote debugger you can find this code snippet referenced that doesn't work: !image-2020-04-27-15-52-26-864.png|width=1114,height=184! $( window ).bind( "touchend", function( e ) { var isInside = ( editor.is( e.target ) || editor.has( e.target ).length > 0 ), currentRange = this.getCurrentRange(), clear = currentRange && ( currentRange.startContainer === currentRange.endContainer && currentRange.startOffset === currentRange.endOffset ); if ( !clear || isInside ) { this.saveSelection(); this.updateToolbar( editor, toolbarBtnSelector, options ); } } ); > Android bootstrap touch event doesn't work > -- > > Key: OPENMEETINGS-2308 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2308 > Project: Openmeetings > Issue Type: New Feature >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-51-25-519.png, > image-2020-04-27-15-52-26-864.png, image-2020-04-27-15-53-06-418.png > > > Under Android you get a lot of exceptions like this: > !image-2020-04-27-15-51-25-519.png|width=1302,height=215! > Almost every click event fails. > Clicking in the Android remote debugger you can find this code snippet > referenced that doesn't work: > !image-2020-04-27-15-53-06-418.png|width=644,height=315! > > $( window ).bind( "touchend", function( e ) { > var isInside = ( editor.is( e.target ) || editor.has( e.target ).length > 0 > ), > currentRange = this.getCurrentRange(), > clear = currentRange && ( currentRange.startContainer === > currentRange.endContainer && currentRange.startOffset === > currentRange.endOffset ); > if ( !clear || isInside ) > { this.saveSelection(); this.updateToolbar( editor, toolbarBtnSelector, > options ); } > } ); -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2308) Android bootstrap touch event doesn't work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2308: --- Description: Under Android you get a lot of exceptions like this: !image-2020-04-27-15-51-25-519.png|width=1302,height=215! Almost every click event fails. Clicking in the Android remote debugger you can find this code snippet referenced that doesn't work: !image-2020-04-27-15-53-06-418.png|width=644,height=315! That must be some bootstrap issue. Coming from the Wicket module. was: Under Android you get a lot of exceptions like this: !image-2020-04-27-15-51-25-519.png|width=1302,height=215! Almost every click event fails. Clicking in the Android remote debugger you can find this code snippet referenced that doesn't work: !image-2020-04-27-15-53-06-418.png|width=644,height=315! $( window ).bind( "touchend", function( e ) { var isInside = ( editor.is( e.target ) || editor.has( e.target ).length > 0 ), currentRange = this.getCurrentRange(), clear = currentRange && ( currentRange.startContainer === currentRange.endContainer && currentRange.startOffset === currentRange.endOffset ); if ( !clear || isInside ) { this.saveSelection(); this.updateToolbar( editor, toolbarBtnSelector, options ); } } ); > Android bootstrap touch event doesn't work > -- > > Key: OPENMEETINGS-2308 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2308 > Project: Openmeetings > Issue Type: New Feature >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-51-25-519.png, > image-2020-04-27-15-52-26-864.png, image-2020-04-27-15-53-06-418.png > > > Under Android you get a lot of exceptions like this: > !image-2020-04-27-15-51-25-519.png|width=1302,height=215! > Almost every click event fails. > Clicking in the Android remote debugger you can find this code snippet > referenced that doesn't work: > !image-2020-04-27-15-53-06-418.png|width=644,height=315! > That must be some bootstrap issue. Coming from the Wicket module. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2308) Android bootstrap touch event doesn't work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2308: --- Fix Version/s: 5.0.0-M5 > Android bootstrap touch event doesn't work > -- > > Key: OPENMEETINGS-2308 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2308 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-51-25-519.png, > image-2020-04-27-15-52-26-864.png > > > Under Android you get a lot of exceptions like this: > !image-2020-04-27-15-51-25-519.png|width=1302,height=215! > Almost every click event fails. > Clicking in the Android remote debugger you can find this code snippet > referenced that doesn't work: > !image-2020-04-27-15-52-26-864.png|width=1114,height=184! > > $( window ).bind( "touchend", function( e ) { > var isInside = ( editor.is( e.target ) || editor.has( e.target ).length > 0 > ), > currentRange = this.getCurrentRange(), > clear = currentRange && ( currentRange.startContainer === > currentRange.endContainer && currentRange.startOffset === > currentRange.endOffset ); > if ( !clear || isInside ) { > this.saveSelection(); > this.updateToolbar( editor, toolbarBtnSelector, options ); > } > } ); -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2308) Android bootstrap touch event doesn't work
Sebastian Wagner created OPENMEETINGS-2308: -- Summary: Android bootstrap touch event doesn't work Key: OPENMEETINGS-2308 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2308 Project: Openmeetings Issue Type: New Feature Reporter: Sebastian Wagner Assignee: Sebastian Wagner Attachments: image-2020-04-27-15-51-25-519.png, image-2020-04-27-15-52-26-864.png Under Android you get a lot of exceptions like this: !image-2020-04-27-15-51-25-519.png|width=1302,height=215! Almost every click event fails. Clicking in the Android remote debugger you can find this code snippet referenced that doesn't work: !image-2020-04-27-15-52-26-864.png|width=1114,height=184! $( window ).bind( "touchend", function( e ) { var isInside = ( editor.is( e.target ) || editor.has( e.target ).length > 0 ), currentRange = this.getCurrentRange(), clear = currentRange && ( currentRange.startContainer === currentRange.endContainer && currentRange.startOffset === currentRange.endOffset ); if ( !clear || isInside ) { this.saveSelection(); this.updateToolbar( editor, toolbarBtnSelector, options ); } } ); -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2308) Android bootstrap touch event doesn't work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2308: --- Affects Version/s: 5.0.0-M4 > Android bootstrap touch event doesn't work > -- > > Key: OPENMEETINGS-2308 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2308 > Project: Openmeetings > Issue Type: New Feature >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-51-25-519.png, > image-2020-04-27-15-52-26-864.png > > > Under Android you get a lot of exceptions like this: > !image-2020-04-27-15-51-25-519.png|width=1302,height=215! > Almost every click event fails. > Clicking in the Android remote debugger you can find this code snippet > referenced that doesn't work: > !image-2020-04-27-15-52-26-864.png|width=1114,height=184! > > $( window ).bind( "touchend", function( e ) { > var isInside = ( editor.is( e.target ) || editor.has( e.target ).length > 0 > ), > currentRange = this.getCurrentRange(), > clear = currentRange && ( currentRange.startContainer === > currentRange.endContainer && currentRange.startOffset === > currentRange.endOffset ); > if ( !clear || isInside ) { > this.saveSelection(); > this.updateToolbar( editor, toolbarBtnSelector, options ); > } > } ); -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2281) Android Media Stream gets interrupted and cannot playback remote audio/video
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092976#comment-17092976 ] Sebastian Wagner commented on OPENMEETINGS-2281: Maybe even delaying the initialisation of the video windows could make it more stable. Keeping in mind that it may be a lot to do for a mobile device to display all those video windows. > Android Media Stream gets interrupted and cannot playback remote audio/video > > > Key: OPENMEETINGS-2281 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2281 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-42-24-953.png > > > In Android+Chrome whenever visiting a room with a video, the video will start > and after 3-5 sec there is an error saying the Media Connection is lost. > I need to somehow capture some log(s). And/or screen capture. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2281) Android Media Stream gets interrupted and cannot playback remote audio/video
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092974#comment-17092974 ] Sebastian Wagner commented on OPENMEETINGS-2281: I can still occasional get a screen like this on the Mobile Device: !image-2020-04-27-15-42-24-953.png|width=477,height=413! No errors related in the console.log though. And it can even happen that after 3-5min the screen will turn up. Annoying is that the refresh icon doesn't seem to work on a touch screen though. It seems impossible to hit the button. Or it just has not click handler that is working on touch surface. > Android Media Stream gets interrupted and cannot playback remote audio/video > > > Key: OPENMEETINGS-2281 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2281 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-42-24-953.png > > > In Android+Chrome whenever visiting a room with a video, the video will start > and after 3-5 sec there is an error saying the Media Connection is lost. > I need to somehow capture some log(s). And/or screen capture. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2281) Android Media Stream gets interrupted and cannot playback remote audio/video
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2281: --- Attachment: image-2020-04-27-15-42-24-953.png > Android Media Stream gets interrupted and cannot playback remote audio/video > > > Key: OPENMEETINGS-2281 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2281 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-42-24-953.png > > > In Android+Chrome whenever visiting a room with a video, the video will start > and after 3-5 sec there is an error saying the Media Connection is lost. > I need to somehow capture some log(s). And/or screen capture. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2281) Android Media Stream gets interrupted and cannot playback remote audio/video
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092973#comment-17092973 ] Sebastian Wagner commented on OPENMEETINGS-2281: It seems more stable now. Not sure what changed in last few releases. > Android Media Stream gets interrupted and cannot playback remote audio/video > > > Key: OPENMEETINGS-2281 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2281 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: image-2020-04-27-15-42-24-953.png > > > In Android+Chrome whenever visiting a room with a video, the video will start > and after 3-5 sec there is an error saying the Media Connection is lost. > I need to somehow capture some log(s). And/or screen capture. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2279) Presentation conference room sometimes in screen recording just captures the video not the screen
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner resolved OPENMEETINGS-2279. Resolution: Cannot Reproduce > Presentation conference room sometimes in screen recording just captures the > video not the screen > - > > Key: OPENMEETINGS-2279 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2279 > Project: Openmeetings > Issue Type: Bug > Components: Recordings >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: rec_12_4462a79c-8711-4177-919d-fcb92aea1783.webm > > > If you enter a presentation style conference room on one occasion it just > recorded the video of the presenter. Not the screen. Similar to an interview > room. > Example webm file: [^rec_12_4462a79c-8711-4177-919d-fcb92aea1783.webm] > The effect is that it won't produce a MP4 from this recording either. > I need to capture the log trace for this one. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2279) Presentation conference room sometimes in screen recording just captures the video not the screen
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092972#comment-17092972 ] Sebastian Wagner commented on OPENMEETINGS-2279: Yeah can't reproduce anymore. > Presentation conference room sometimes in screen recording just captures the > video not the screen > - > > Key: OPENMEETINGS-2279 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2279 > Project: Openmeetings > Issue Type: Bug > Components: Recordings >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > Attachments: rec_12_4462a79c-8711-4177-919d-fcb92aea1783.webm > > > If you enter a presentation style conference room on one occasion it just > recorded the video of the presenter. Not the screen. Similar to an interview > room. > Example webm file: [^rec_12_4462a79c-8711-4177-919d-fcb92aea1783.webm] > The effect is that it won't produce a MP4 from this recording either. > I need to capture the log trace for this one. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2253) Interruption of a video session when the microphone is turned on / off
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092971#comment-17092971 ] Sebastian Wagner commented on OPENMEETINGS-2253: [~jbi] looks like you can simply use the conference room of style "Conference" and everybody will enter with audio/video turned ON by default. Which will do what you are asking for. > Interruption of a video session when the microphone is turned on / off > -- > > Key: OPENMEETINGS-2253 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2253 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.0.0-M3 > Environment: Chrome, FF >Reporter: Evgeny >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > Hello! > 1. The participant turns on the camera - a camera window appears. > 2. The participant turns on / off the microphone - the camera window closes, > after a delay of 2-3 seconds it opens, with a change from its original > position. > Each time the microphone is turned on / off, there is a delay and jerking of > the camera window of the conference participant, with the transition to the > default position. > For other participants, the camera of this participant also disappears on the > screen. > Please make one button to turn on / off together - both the camera and the > microphone. Or a hotkey. So that the participant at the beginning and at the > end of the conversation does not press the camera and microphone separately > on the buttons. > Thanks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OPENMEETINGS-2253) Interruption of a video session when the microphone is turned on / off
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092968#comment-17092968 ] Sebastian Wagner edited comment on OPENMEETINGS-2253 at 4/27/20, 3:30 AM: -- I think the general request is: {quote}Please make one button to turn on / off together - both the camera and the microphone. {quote} I tend to agree. I think they can just use Conference room for this. And people will have audio/video turned on by default. On entering the room. was (Author: sebawagner): I think the general request is: > Please make one button to turn on / off together - both the camera and the >microphone. > Interruption of a video session when the microphone is turned on / off > -- > > Key: OPENMEETINGS-2253 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2253 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.0.0-M3 > Environment: Chrome, FF >Reporter: Evgeny >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > Hello! > 1. The participant turns on the camera - a camera window appears. > 2. The participant turns on / off the microphone - the camera window closes, > after a delay of 2-3 seconds it opens, with a change from its original > position. > Each time the microphone is turned on / off, there is a delay and jerking of > the camera window of the conference participant, with the transition to the > default position. > For other participants, the camera of this participant also disappears on the > screen. > Please make one button to turn on / off together - both the camera and the > microphone. Or a hotkey. So that the participant at the beginning and at the > end of the conversation does not press the camera and microphone separately > on the buttons. > Thanks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2253) Interruption of a video session when the microphone is turned on / off
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092968#comment-17092968 ] Sebastian Wagner commented on OPENMEETINGS-2253: I think the general request is: > Please make one button to turn on / off together - both the camera and the >microphone. > Interruption of a video session when the microphone is turned on / off > -- > > Key: OPENMEETINGS-2253 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2253 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.0.0-M3 > Environment: Chrome, FF >Reporter: Evgeny >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > Hello! > 1. The participant turns on the camera - a camera window appears. > 2. The participant turns on / off the microphone - the camera window closes, > after a delay of 2-3 seconds it opens, with a change from its original > position. > Each time the microphone is turned on / off, there is a delay and jerking of > the camera window of the conference participant, with the transition to the > default position. > For other participants, the camera of this participant also disappears on the > screen. > Please make one button to turn on / off together - both the camera and the > microphone. Or a hotkey. So that the participant at the beginning and at the > end of the conversation does not press the camera and microphone separately > on the buttons. > Thanks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2307) Enable Maven-checkstyle-plugin
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092874#comment-17092874 ] ASF subversion and git services commented on OPENMEETINGS-2307: --- Commit fa3110def03bea60be2bc80271c56e626cbe36d2 in openmeetings's branch refs/heads/feature/OPENMEETINGS-2307-enable-checkstyle-with-simplest-rule-set from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=fa3110d ] OPENMEETINGS-2307 Add checkstyle check with only checking for unused imports. Remove unused imports. > Enable Maven-checkstyle-plugin > -- > > Key: OPENMEETINGS-2307 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2307 > Project: Openmeetings > Issue Type: Improvement > Components: Builds >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > I noticed that I don't get any build errors or warnings with unused imports. > I thought there is a checkstyle plugin running as part of Apache reports. > But there isn't. > There is a plugin here: > [http://maven.apache.org/plugins/maven-checkstyle-plugin/index.html] > I think it reveals a lot of useful information. Doesn't mean we fix all of > it. But its very helpful. > It may also generate a nice report: > [http://maven.apache.org/plugins-archives/maven-project-info-reports-plugin-LATEST/checkstyle.html] > Which can be useful once more people work on code, so you don't need to > review syntax and code smells in every PR manually. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch feature/OPENMEETINGS-2307-enable-checkstyle-with-simplest-rule-set created (now fa3110d)
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a change to branch feature/OPENMEETINGS-2307-enable-checkstyle-with-simplest-rule-set in repository https://gitbox.apache.org/repos/asf/openmeetings.git. at fa3110d OPENMEETINGS-2307 Add checkstyle check with only checking for unused imports. Remove unused imports. This branch includes the following new commits: new fa3110d OPENMEETINGS-2307 Add checkstyle check with only checking for unused imports. Remove unused imports. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[openmeetings] 01/01: OPENMEETINGS-2307 Add checkstyle check with only checking for unused imports. Remove unused imports.
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a commit to branch feature/OPENMEETINGS-2307-enable-checkstyle-with-simplest-rule-set in repository https://gitbox.apache.org/repos/asf/openmeetings.git commit fa3110def03bea60be2bc80271c56e626cbe36d2 Author: Sebastian Wagner AuthorDate: Mon Apr 27 10:08:31 2020 +1200 OPENMEETINGS-2307 Add checkstyle check with only checking for unused imports. Remove unused imports. --- openmeetings-core/pom.xml | 1 + .../org/apache/openmeetings/core/remote/KRoom.java | 1 - .../core/remote/TestRecordingFlowMocked.java | 3 -- .../core/remote/TestRoomFlowMocked.java| 2 -- openmeetings-db/pom.xml| 1 + openmeetings-install/pom.xml | 1 + openmeetings-screenshare/pom.xml | 1 + openmeetings-server/pom.xml| 1 + openmeetings-service/pom.xml | 1 + openmeetings-util/pom.xml | 1 + openmeetings-web/pom.xml | 1 + openmeetings-webservice/pom.xml| 1 + pom.xml| 36 ++ src/config/openmeetings_checkstyle.xml | 33 14 files changed, 78 insertions(+), 6 deletions(-) diff --git a/openmeetings-core/pom.xml b/openmeetings-core/pom.xml index 3e985b6..2c794d6 100644 --- a/openmeetings-core/pom.xml +++ b/openmeetings-core/pom.xml @@ -32,6 +32,7 @@ ${project.parent.basedir} apache.openmeetings.core + ${project.parent.basedir}/src/config/openmeetings_checkstyle.xml diff --git a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java index 7d7a47a..54f0f21 100644 --- a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java +++ b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java @@ -34,7 +34,6 @@ import java.util.concurrent.atomic.AtomicBoolean; import org.apache.openmeetings.core.util.WebSocketHelper; import org.apache.openmeetings.db.dao.record.RecordingChunkDao; -import org.apache.openmeetings.db.dao.record.RecordingDao; import org.apache.openmeetings.db.entity.basic.Client; import org.apache.openmeetings.db.entity.basic.Client.Activity; import org.apache.openmeetings.db.entity.basic.Client.StreamDesc; diff --git a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java index f141dc5..7664645 100644 --- a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java +++ b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java @@ -29,7 +29,6 @@ import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; import java.util.Locale; -import java.util.logging.StreamHandler; import org.apache.openmeetings.db.dao.label.LabelDao; import org.apache.openmeetings.db.dao.record.RecordingDao; @@ -48,8 +47,6 @@ import org.kurento.client.MediaPipeline; import org.kurento.client.Transaction; import org.mockito.BDDMockito; import org.mockito.Mock; -import org.mockito.invocation.InvocationOnMock; -import org.mockito.stubbing.Answer; import org.powermock.api.mockito.PowerMockito; import org.powermock.core.classloader.annotations.PrepareForTest; diff --git a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java index 9c24c67..5f5061d 100644 --- a/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java +++ b/openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRoomFlowMocked.java @@ -43,8 +43,6 @@ import org.kurento.client.MediaPipeline; import org.kurento.client.Transaction; import org.mockito.BDDMockito; import org.mockito.Mock; -import org.mockito.invocation.InvocationOnMock; -import org.mockito.stubbing.Answer; import org.powermock.api.mockito.PowerMockito; import org.powermock.core.classloader.annotations.PrepareForTest; diff --git a/openmeetings-db/pom.xml b/openmeetings-db/pom.xml index 3cf2a4c..da702f1 100644 --- a/openmeetings-db/pom.xml +++ b/openmeetings-db/pom.xml @@ -32,6 +32,7 @@ ${project.parent.basedir} apache.openmeetings.db + ${project.parent.basedir}/src/config/openmeetings_checkstyle.xml diff --git a/openmeetings-install/pom.xml b/openmeetings-install/pom.xml index dc88f9f..c351031 100644 ---
[jira] [Updated] (OPENMEETINGS-2307) Enable Maven-checkstyle-plugin
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner updated OPENMEETINGS-2307: --- Issue Type: Improvement (was: New Feature) > Enable Maven-checkstyle-plugin > -- > > Key: OPENMEETINGS-2307 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2307 > Project: Openmeetings > Issue Type: Improvement > Components: Builds >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > I noticed that I don't get any build errors or warnings with unused imports. > I thought there is a checkstyle plugin running as part of Apache reports. > But there isn't. > There is a plugin here: > [http://maven.apache.org/plugins/maven-checkstyle-plugin/index.html] > I think it reveals a lot of useful information. Doesn't mean we fix all of > it. But its very helpful. > It may also generate a nice report: > [http://maven.apache.org/plugins-archives/maven-project-info-reports-plugin-LATEST/checkstyle.html] > Which can be useful once more people work on code, so you don't need to > review syntax and code smells in every PR manually. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2307) Enable Maven-checkstyle-plugin
Sebastian Wagner created OPENMEETINGS-2307: -- Summary: Enable Maven-checkstyle-plugin Key: OPENMEETINGS-2307 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2307 Project: Openmeetings Issue Type: New Feature Components: Builds Affects Versions: 5.0.0-M4 Reporter: Sebastian Wagner Assignee: Sebastian Wagner Fix For: 5.0.0-M5 I noticed that I don't get any build errors or warnings with unused imports. I thought there is a checkstyle plugin running as part of Apache reports. But there isn't. There is a plugin here: [http://maven.apache.org/plugins/maven-checkstyle-plugin/index.html] I think it reveals a lot of useful information. Doesn't mean we fix all of it. But its very helpful. It may also generate a nice report: [http://maven.apache.org/plugins-archives/maven-project-info-reports-plugin-LATEST/checkstyle.html] Which can be useful once more people work on code, so you don't need to review syntax and code smells in every PR manually. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2306) Kick and terminate KStream from Admin>Connections
Sebastian Wagner created OPENMEETINGS-2306: -- Summary: Kick and terminate KStream from Admin>Connections Key: OPENMEETINGS-2306 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2306 Project: Openmeetings Issue Type: New Feature Affects Versions: 5.0.0-M4 Reporter: Sebastian Wagner Assignee: Sebastian Wagner Fix For: 5.0.0-M5 Depends on OPENMEETINGS-2298 After the list view is done, the button to kick off the KStream would be good to add. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2305) Can't save date of birth
Andreas created OPENMEETINGS-2305: - Summary: Can't save date of birth Key: OPENMEETINGS-2305 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2305 Project: Openmeetings Issue Type: Bug Components: Admin Affects Versions: 5.0.0-M4 Reporter: Andreas Assignee: Maxim Solodovnik When a new user registers, the actual date is inserted as birthday. I am able to change it to the right date of birth but I can not save it. After saving the old value is inserted again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2304) Verify string
Zenon Panoussis created OPENMEETINGS-2304: - Summary: Verify string Key: OPENMEETINGS-2304 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2304 Project: Openmeetings Issue Type: Task Components: Translations Reporter: Zenon Panoussis Assignee: Maxim Solodovnik If network.test.report no longer exists in the UI, it should be removed from poeditor. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2303) String deduplication
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092729#comment-17092729 ] Maxim Solodovnik commented on OPENMEETINGS-2303: install.wizard.params.step3.installation -- install.wizard.install.header install.wizard.params.step1.email -- 510 131 -- 1282 2delete network.test.report label->static text 1577 (client_secret) client_id re-work 1362 (I) -- won't work for all languages > String deduplication > > > Key: OPENMEETINGS-2303 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2303 > Project: Openmeetings > Issue Type: Task > Components: Translations, UI >Reporter: Zenon Panoussis >Assignee: Maxim Solodovnik >Priority: Minor > > Maybe another round is required -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2303) String deduplication
Zenon Panoussis created OPENMEETINGS-2303: - Summary: String deduplication Key: OPENMEETINGS-2303 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2303 Project: Openmeetings Issue Type: Task Components: Translations, UI Reporter: Zenon Panoussis Assignee: Maxim Solodovnik Maybe another round is required -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OPENMEETINGS-2302) Installation of Apache OpenMeetings 5.0.0-M4 on Ubuntu 18.04 lts - Installation error
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yevgenii closed OPENMEETINGS-2302. -- Resolution: Fixed Step 6, Installation and configuration of MariaDB data server: I missed the value entry: MariaDB [(none)]> CREATE DATABASE open504 DEFAULT CHARACTER SET 'utf8'; > Installation of Apache OpenMeetings 5.0.0-M4 on Ubuntu 18.04 lts - > Installation error > -- > > Key: OPENMEETINGS-2302 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2302 > Project: Openmeetings > Issue Type: Bug > Components: Installer >Affects Versions: 5.0.0-M4 >Reporter: Yevgenii >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 5.0.0-M4 > > Attachments: screenshot.jpg > > > Installation old of Apache OpenMeetings 5.0.0-M3 on Ubuntu 18.04 lts - it > work! > [Installation of Apache OpenMeetings 5.0.0-M4 on Ubuntu 18.04 lts > |https://cwiki.apache.org/confluence/download/attachments/27838216/Installation%20OpenMeetings%205.0.0-M4%20on%20Ubuntu%2018.04%20LTS.pdf?version=4=1587568979000=v2]- > the final step of installing Apache OpenMeetings does not work (paragraph > 11, Press “Finish” button ...wait a seconds untill the tables are fill in the > database.) > Step URL /openmeetings/install?197 > Error code: > > org.apache.openjpa.persistence.PersistenceException: The transaction has been > rolled back. See the nested exceptions for details on the errors that > occurred. > FailedObject: org.apache.openmeetings.db.entity.basic.Configuration@d2b3cb3 > at > org.apache.openjpa.kernel.BrokerImpl.newFlushException(BrokerImpl.java:2470) > at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:2308) > at org.apache.openjpa.kernel.BrokerImpl.flushSafe(BrokerImpl.java:2199) > at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:1962) > at org.apache.openjpa.kernel.QueryImpl.isInMemory(QueryImpl.java:1028) > at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:902) > at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:843) > at > org.apache.openjpa.kernel.DelegatingQuery.execute(DelegatingQuery.java:601) > at org.apache.openjpa.persistence.QueryImpl.execute(QueryImpl.java:297) > at org.apache.openjpa.persistence.QueryImpl.getResultList(QueryImpl.java:314) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao.get(ConfigurationDao.java:221) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao.get(ConfigurationDao.java:228) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao.getString(ConfigurationDao.java:278) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao.reloadCrypt(ConfigurationDao.java:451) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao.update(ConfigurationDao.java:349) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao.update(ConfigurationDao.java:316) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao$$FastClassBySpringCGLIB$$2f9526f2.invoke() > at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218) > at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) > at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749) > at > org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:366) > at > org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:118) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186) > at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749) > at > org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao$$EnhancerBySpringCGLIB$$59320516.update() > at > org.apache.openmeetings.installation.ImportInitvalues.loadConfiguration(ImportInitvalues.java:385) > at > org.apache.openmeetings.installation.ImportInitvalues.loadSystem(ImportInitvalues.java:575) > at > org.apache.openmeetings.installation.ImportInitvalues.loadAll(ImportInitvalues.java:585) > at > org.apache.openmeetings.installation.Wicket_Proxy_ImportInitvalues$$FastClassByCGLIB$$14cc0e15.invoke() > at net.sf.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204) > at > org.apache.wicket.proxy.LazyInitProxyFactory$AbstractCGLibInterceptor.intercept(LazyInitProxyFactory.java:364) > at >
[jira] [Commented] (OPENMEETINGS-2302) Installation of Apache OpenMeetings 5.0.0-M4 on Ubuntu 18.04 lts - Installation error
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092571#comment-17092571 ] Maxim Solodovnik commented on OPENMEETINGS-2302: According to the log DB table doesn't exist Have you created DB before using installer? > Installation of Apache OpenMeetings 5.0.0-M4 on Ubuntu 18.04 lts - > Installation error > -- > > Key: OPENMEETINGS-2302 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2302 > Project: Openmeetings > Issue Type: Bug > Components: Installer >Affects Versions: 5.0.0-M4 >Reporter: Yevgenii >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 5.0.0-M4 > > Attachments: screenshot.jpg > > > Installation old of Apache OpenMeetings 5.0.0-M3 on Ubuntu 18.04 lts - it > work! > [Installation of Apache OpenMeetings 5.0.0-M4 on Ubuntu 18.04 lts > |https://cwiki.apache.org/confluence/download/attachments/27838216/Installation%20OpenMeetings%205.0.0-M4%20on%20Ubuntu%2018.04%20LTS.pdf?version=4=1587568979000=v2]- > the final step of installing Apache OpenMeetings does not work (paragraph > 11, Press “Finish” button ...wait a seconds untill the tables are fill in the > database.) > Step URL /openmeetings/install?197 > Error code: > > org.apache.openjpa.persistence.PersistenceException: The transaction has been > rolled back. See the nested exceptions for details on the errors that > occurred. > FailedObject: org.apache.openmeetings.db.entity.basic.Configuration@d2b3cb3 > at > org.apache.openjpa.kernel.BrokerImpl.newFlushException(BrokerImpl.java:2470) > at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:2308) > at org.apache.openjpa.kernel.BrokerImpl.flushSafe(BrokerImpl.java:2199) > at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:1962) > at org.apache.openjpa.kernel.QueryImpl.isInMemory(QueryImpl.java:1028) > at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:902) > at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:843) > at > org.apache.openjpa.kernel.DelegatingQuery.execute(DelegatingQuery.java:601) > at org.apache.openjpa.persistence.QueryImpl.execute(QueryImpl.java:297) > at org.apache.openjpa.persistence.QueryImpl.getResultList(QueryImpl.java:314) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao.get(ConfigurationDao.java:221) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao.get(ConfigurationDao.java:228) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao.getString(ConfigurationDao.java:278) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao.reloadCrypt(ConfigurationDao.java:451) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao.update(ConfigurationDao.java:349) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao.update(ConfigurationDao.java:316) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao$$FastClassBySpringCGLIB$$2f9526f2.invoke() > at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218) > at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) > at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749) > at > org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:366) > at > org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:118) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186) > at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749) > at > org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691) > at > org.apache.openmeetings.db.dao.basic.ConfigurationDao$$EnhancerBySpringCGLIB$$59320516.update() > at > org.apache.openmeetings.installation.ImportInitvalues.loadConfiguration(ImportInitvalues.java:385) > at > org.apache.openmeetings.installation.ImportInitvalues.loadSystem(ImportInitvalues.java:575) > at > org.apache.openmeetings.installation.ImportInitvalues.loadAll(ImportInitvalues.java:585) > at > org.apache.openmeetings.installation.Wicket_Proxy_ImportInitvalues$$FastClassByCGLIB$$14cc0e15.invoke() > at net.sf.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204) > at > org.apache.wicket.proxy.LazyInitProxyFactory$AbstractCGLibInterceptor.intercept(LazyInitProxyFactory.java:364) > at >
[jira] [Created] (OPENMEETINGS-2302) Installation of Apache OpenMeetings 5.0.0-M4 on Ubuntu 18.04 lts - Installation error
Yevgenii created OPENMEETINGS-2302: -- Summary: Installation of Apache OpenMeetings 5.0.0-M4 on Ubuntu 18.04 lts - Installation error Key: OPENMEETINGS-2302 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2302 Project: Openmeetings Issue Type: Bug Components: Installer Affects Versions: 5.0.0-M4 Reporter: Yevgenii Assignee: Maxim Solodovnik Fix For: 5.0.0-M4 Attachments: screenshot.jpg Installation old of Apache OpenMeetings 5.0.0-M3 on Ubuntu 18.04 lts - it work! [Installation of Apache OpenMeetings 5.0.0-M4 on Ubuntu 18.04 lts |https://cwiki.apache.org/confluence/download/attachments/27838216/Installation%20OpenMeetings%205.0.0-M4%20on%20Ubuntu%2018.04%20LTS.pdf?version=4=1587568979000=v2]- the final step of installing Apache OpenMeetings does not work (paragraph 11, Press “Finish” button ...wait a seconds untill the tables are fill in the database.) Step URL /openmeetings/install?197 Error code: org.apache.openjpa.persistence.PersistenceException: The transaction has been rolled back. See the nested exceptions for details on the errors that occurred. FailedObject: org.apache.openmeetings.db.entity.basic.Configuration@d2b3cb3 at org.apache.openjpa.kernel.BrokerImpl.newFlushException(BrokerImpl.java:2470) at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:2308) at org.apache.openjpa.kernel.BrokerImpl.flushSafe(BrokerImpl.java:2199) at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:1962) at org.apache.openjpa.kernel.QueryImpl.isInMemory(QueryImpl.java:1028) at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:902) at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:843) at org.apache.openjpa.kernel.DelegatingQuery.execute(DelegatingQuery.java:601) at org.apache.openjpa.persistence.QueryImpl.execute(QueryImpl.java:297) at org.apache.openjpa.persistence.QueryImpl.getResultList(QueryImpl.java:314) at org.apache.openmeetings.db.dao.basic.ConfigurationDao.get(ConfigurationDao.java:221) at org.apache.openmeetings.db.dao.basic.ConfigurationDao.get(ConfigurationDao.java:228) at org.apache.openmeetings.db.dao.basic.ConfigurationDao.getString(ConfigurationDao.java:278) at org.apache.openmeetings.db.dao.basic.ConfigurationDao.reloadCrypt(ConfigurationDao.java:451) at org.apache.openmeetings.db.dao.basic.ConfigurationDao.update(ConfigurationDao.java:349) at org.apache.openmeetings.db.dao.basic.ConfigurationDao.update(ConfigurationDao.java:316) at org.apache.openmeetings.db.dao.basic.ConfigurationDao$$FastClassBySpringCGLIB$$2f9526f2.invoke() at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218) at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749) at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:366) at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:118) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186) at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749) at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691) at org.apache.openmeetings.db.dao.basic.ConfigurationDao$$EnhancerBySpringCGLIB$$59320516.update() at org.apache.openmeetings.installation.ImportInitvalues.loadConfiguration(ImportInitvalues.java:385) at org.apache.openmeetings.installation.ImportInitvalues.loadSystem(ImportInitvalues.java:575) at org.apache.openmeetings.installation.ImportInitvalues.loadAll(ImportInitvalues.java:585) at org.apache.openmeetings.installation.Wicket_Proxy_ImportInitvalues$$FastClassByCGLIB$$14cc0e15.invoke() at net.sf.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204) at org.apache.wicket.proxy.LazyInitProxyFactory$AbstractCGLibInterceptor.intercept(LazyInitProxyFactory.java:364) at org.apache.openmeetings.installation.Wicket_Proxy_ImportInitvalues$$EnhancerByCGLIB$$49477dc5.loadAll() at org.apache.openmeetings.web.pages.install.InstallWizard$InstallProcess.run(InstallWizard.java:833) at java.base/java.lang.Thread.run(Thread.java:834) Caused by: org.apache.openjpa.persistence.PersistenceException: Table 'open595.configuration' doesn't exist \{prepstmnt 857899025 INSERT INTO configuration (deleted, inserted, updated, comment, fromVersion, om_key, type, value, user_id) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)} [code=1146, state=42S02] FailedObject:
[jira] [Resolved] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Wagner resolved OPENMEETINGS-2299. Resolution: Fixed > Add more functional unit tests for Recording in room > > > Key: OPENMEETINGS-2299 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299 > Project: Openmeetings > Issue Type: Improvement > Components: Recordings >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > Add more functional unit tests for the recording feature -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2298) Add KStream to Admin>Connections
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092538#comment-17092538 ] ASF subversion and git services commented on OPENMEETINGS-2298: --- Commit ffbd251d54c00489c43fb5ed894516d4f157265b in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=ffbd251 ] OPENMEETINGS-2298 Add and resolve review comments > Add KStream to Admin>Connections > > > Key: OPENMEETINGS-2298 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2298 > Project: Openmeetings > Issue Type: New Feature > Components: Admin, Kurento >Affects Versions: 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > See discussion at: [https://markmail.org/thread/25ym4cqjkz6xntwd] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092535#comment-17092535 ] ASF subversion and git services commented on OPENMEETINGS-2299: --- Commit 2671fa6be82b990395f225f6eb7bdee44e2216de in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=2671fa6 ] OPENMEETINGS-2299 Add unit test for recording when sharing wasn't enabled initially > Add more functional unit tests for Recording in room > > > Key: OPENMEETINGS-2299 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299 > Project: Openmeetings > Issue Type: Improvement > Components: Recordings >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > Add more functional unit tests for the recording feature -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092539#comment-17092539 ] ASF subversion and git services commented on OPENMEETINGS-2299: --- Commit ec97fd7e28b1f8039e187d40396c3e9e27c1bdcc in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=ec97fd7 ] Merge pull request #68 from apache/feature/OPENMEETINGS-2299-add-unit-tests-for-recording-feature OPENMEETINGS-2299 Add unit test for recording when sharing wasn't ena… > Add more functional unit tests for Recording in room > > > Key: OPENMEETINGS-2299 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299 > Project: Openmeetings > Issue Type: Improvement > Components: Recordings >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > Add more functional unit tests for the recording feature -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092537#comment-17092537 ] ASF subversion and git services commented on OPENMEETINGS-2299: --- Commit d91441bca1488365421daf6daa276c9aeb6cbaab in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=d91441b ] OPENMEETINGS-2299 Add test part to also simulate and verify stoping of a recording. When sharing wasn't running. > Add more functional unit tests for Recording in room > > > Key: OPENMEETINGS-2299 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299 > Project: Openmeetings > Issue Type: Improvement > Components: Recordings >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > Add more functional unit tests for the recording feature -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] 01/01: Merge pull request #68 from apache/feature/OPENMEETINGS-2299-add-unit-tests-for-recording-feature
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git commit ec97fd7e28b1f8039e187d40396c3e9e27c1bdcc Merge: e8503e1 ffbd251 Author: Sebastian Wagner AuthorDate: Sun Apr 26 18:23:36 2020 +1200 Merge pull request #68 from apache/feature/OPENMEETINGS-2299-add-unit-tests-for-recording-feature OPENMEETINGS-2299 Add unit test for recording when sharing wasn't ena… .../org/apache/openmeetings/core/remote/KRoom.java | 10 +- .../openmeetings/core/remote/StreamProcessor.java | 34 +++- .../core/remote/TestRecordingFlowMocked.java | 219 + .../core/remote/TestRoomFlowMocked.java| 13 +- 4 files changed, 264 insertions(+), 12 deletions(-)
[openmeetings] branch master updated (e8503e1 -> ec97fd7)
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git. from e8503e1 Merge pull request #65 from apache/feature/openmeetings-2278-start-recording-twice-in-one-session add 2671fa6 OPENMEETINGS-2299 Add unit test for recording when sharing wasn't enabled initially add 7dd0153 OPENMEETINGS-2299 Remove commented out code add d91441b OPENMEETINGS-2299 Add test part to also simulate and verify stoping of a recording. When sharing wasn't running. add ffbd251 OPENMEETINGS-2298 Add and resolve review comments new ec97fd7 Merge pull request #68 from apache/feature/OPENMEETINGS-2299-add-unit-tests-for-recording-feature The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../org/apache/openmeetings/core/remote/KRoom.java | 10 +- .../openmeetings/core/remote/StreamProcessor.java | 34 +++- .../core/remote/TestRecordingFlowMocked.java | 219 + .../core/remote/TestRoomFlowMocked.java| 13 +- 4 files changed, 264 insertions(+), 12 deletions(-) create mode 100644 openmeetings-core/src/test/java/org/apache/openmeetings/core/remote/TestRecordingFlowMocked.java
[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092536#comment-17092536 ] ASF subversion and git services commented on OPENMEETINGS-2299: --- Commit 7dd01532f5af3f75188140ec9f25090874485b05 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=7dd0153 ] OPENMEETINGS-2299 Remove commented out code > Add more functional unit tests for Recording in room > > > Key: OPENMEETINGS-2299 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299 > Project: Openmeetings > Issue Type: Improvement > Components: Recordings >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > Add more functional unit tests for the recording feature -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2299) Add more functional unit tests for Recording in room
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092540#comment-17092540 ] ASF subversion and git services commented on OPENMEETINGS-2299: --- Commit ec97fd7e28b1f8039e187d40396c3e9e27c1bdcc in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=ec97fd7 ] Merge pull request #68 from apache/feature/OPENMEETINGS-2299-add-unit-tests-for-recording-feature OPENMEETINGS-2299 Add unit test for recording when sharing wasn't ena… > Add more functional unit tests for Recording in room > > > Key: OPENMEETINGS-2299 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2299 > Project: Openmeetings > Issue Type: Improvement > Components: Recordings >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 5.0.0-M5 > > > Add more functional unit tests for the recording feature -- This message was sent by Atlassian Jira (v8.3.4#803005)