[jira] [Commented] (OPENMEETINGS-2253) Interruption of a video session when the microphone is turned on / off
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648702#comment-17648702 ] ASF subversion and git services commented on OPENMEETINGS-2253: --- Commit 71110ae7ad60b3526b86a6c84267a2975e3fdd4d in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=71110ae7a ] [OPENMEETINGS-2253] self-echo is removed > Interruption of a video session when the microphone is turned on / off > -- > > Key: OPENMEETINGS-2253 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2253 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.0.0-M3 > Environment: Chrome, FF >Reporter: Evgeny >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 7.0.0 > > Attachments: icon_example.png, indication.png, whiteboard.png > > > Hello! > 1. The participant turns on the camera - a camera window appears. > 2. The participant turns on / off the microphone - the camera window closes, > after a delay of 2-3 seconds it opens, with a change from its original > position. > Each time the microphone is turned on / off, there is a delay and jerking of > the camera window of the conference participant, with the transition to the > default position. > For other participants, the camera of this participant also disappears on the > screen. > Please make one button to turn on / off together - both the camera and the > microphone. Or a hotkey. So that the participant at the beginning and at the > end of the conversation does not press the camera and microphone separately > on the buttons. > Thanks. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[openmeetings] branch master updated: [OPENMEETINGS-2253] self-echo is removed
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 71110ae7a [OPENMEETINGS-2253] self-echo is removed
71110ae7a is described below
commit 71110ae7ad60b3526b86a6c84267a2975e3fdd4d
Author: Maxim Solodovnik
AuthorDate: Fri Dec 16 22:45:01 2022 +0700
[OPENMEETINGS-2253] self-echo is removed
---
openmeetings-web/src/main/front/room/src/video.js| 3 +++
openmeetings-web/src/main/front/settings/src/settings.js | 2 ++
2 files changed, 5 insertions(+)
diff --git a/openmeetings-web/src/main/front/room/src/video.js
b/openmeetings-web/src/main/front/room/src/video.js
index 6f0a9582b..5ce436391 100644
--- a/openmeetings-web/src/main/front/room/src/video.js
+++ b/openmeetings-web/src/main/front/room/src/video.js
@@ -442,6 +442,9 @@ module.exports = class Video {
state.video.attr('poster', null);
vc.addClass('audio-only');
}
+ if (self) {
+ state.video[0].muted = true;
+ }
vc.append(state.video);
__updateVideo(state);
}
diff --git a/openmeetings-web/src/main/front/settings/src/settings.js
b/openmeetings-web/src/main/front/settings/src/settings.js
index 795108ff1..8ba9931ad 100644
--- a/openmeetings-web/src/main/front/settings/src/settings.js
+++ b/openmeetings-web/src/main/front/settings/src/settings.js
@@ -209,6 +209,7 @@ function _readValues(msg, func) {
}, msg);
navigator.mediaDevices.getUserMedia(cnts)
.then(stream => {
+ vid[0].muted = true;
VideoUtil.playSrc(vid[0], stream);
options.mediaStream = stream;
@@ -406,6 +407,7 @@ function _onKMessage(m) {
.then(() => {
const stream = rtcPeer.stream;
if (stream) {
+ vid[0].muted = false;
VideoUtil.playSrc(vid[0],
stream);
lm.show();
level = new MicLevel();
[jira] [Commented] (OPENMEETINGS-2732) (7.0.0) Libraries should be updated
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648578#comment-17648578 ] ASF subversion and git services commented on OPENMEETINGS-2732: --- Commit 7be6955cdba9779f50e1db45c03677e4db769a28 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=7be6955cd ] [OPENMEETINGS-2732] jetty > (7.0.0) Libraries should be updated > --- > > Key: OPENMEETINGS-2732 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2732 > Project: Openmeetings > Issue Type: Task > Components: Builds >Affects Versions: 7.0.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 7.0.0 > > > Libraries should be updated -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENMEETINGS-2566) Moderator invitation form
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648577#comment-17648577 ] ASF subversion and git services commented on OPENMEETINGS-2566: --- Commit 478d4dca8cdb82434b81b7f0bfd6412bba156510 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=478d4dca8 ] [OPENMEETINGS-2566] Group admin can send invitations to group > Moderator invitation form > - > > Key: OPENMEETINGS-2566 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2566 > Project: Openmeetings > Issue Type: Bug > Components: Invitation >Affects Versions: 5.1.0 >Reporter: Kden >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 7.0.0 > > Attachments: admin.png, moderator.png > > > Hello! > Can each moderator (teacher) send an invitation to one of their groups? > Now this field is visible only by Administrator - I am attaching photos ... > > ... I translated part of the language file into the translation program while > waiting for a response :) > > With great respect for your work! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[openmeetings] 01/02: [OPENMEETINGS-2566] Group admin can send invitations to group
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
commit 478d4dca8cdb82434b81b7f0bfd6412bba156510
Author: Maxim Solodovnik
AuthorDate: Fri Dec 16 18:03:47 2022 +0700
[OPENMEETINGS-2566] Group admin can send invitations to group
---
.../apache/openmeetings/db/dao/user/GroupDao.java | 8 +++--
.../web/admin/AdminUserChoiceProvider.java | 2 +-
.../web/common/GroupChoiceProvider.java| 21 +++-
.../web/room/menu/RoomInvitationForm.java | 2 +-
.../web/user/calendar/AppointmentDialog.java | 2 +-
.../apache/openmeetings/user/TestUserGroup.java| 38 +-
6 files changed, 57 insertions(+), 16 deletions(-)
diff --git
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/user/GroupDao.java
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/user/GroupDao.java
index 6acb8fd8f..273672f77 100644
---
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/user/GroupDao.java
+++
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/user/GroupDao.java
@@ -43,6 +43,7 @@ import
org.springframework.transaction.annotation.Transactional;
@Transactional
public class GroupDao implements IGroupAdminDataProviderDao {
private static final List searchFields = List.of("name");
+ private static final List guSearchFields =
List.copyOf(searchFields.stream().map(n -> "group." + n).toList());
@PersistenceContext
private EntityManager em;
@@ -82,14 +83,15 @@ public class GroupDao implements
IGroupAdminDataProviderDao {
private Predicate getAdminFilter(Long adminId, CriteriaBuilder builder,
CriteriaQuery query) {
Root root = getRoot(query, GroupUser.class);
- return builder.and(builder.equal(root.get("user").get("id"),
adminId), builder.isTrue(root.get("moderator")));
+ return builder.and(builder.equal(root.get("user").get("id"),
adminId)
+ ,
builder.isTrue(root.get("moderator")));
}
@Override
public List adminGet(String search, Long adminId, long start,
long count, SortParam sort) {
return DaoHelper.get(em, GroupUser.class, Group.class
, (builder, root) -> root.get("group")
- , true, search, searchFields, true
+ , true, search, guSearchFields, true
, (b, q) -> getAdminFilter(adminId, b, q)
, sort, start, count);
}
@@ -108,7 +110,7 @@ public class GroupDao implements
IGroupAdminDataProviderDao {
public long adminCount(String search, Long adminId) {
return DaoHelper.count(em, GroupUser.class
, (builder, root) ->
builder.countDistinct(root.get("group"))
- , search, searchFields, false
+ , search, guSearchFields, false
, (b, q) -> getAdminFilter(adminId, b,
q.distinct(true)));
}
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/admin/AdminUserChoiceProvider.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/admin/AdminUserChoiceProvider.java
index d17449eba..6452dd050 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/admin/AdminUserChoiceProvider.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/admin/AdminUserChoiceProvider.java
@@ -48,7 +48,7 @@ public abstract class AdminUserChoiceProvider extends
ChoiceProvider {
@Override
public void query(String term, int page, Response response) {
response.addAll(userDao.get(term, true, page * PAGE_SIZE,
PAGE_SIZE));
- response.setHasMore(PAGE_SIZE == response.getResults().size());
+ response.setHasMore(page * PAGE_SIZE +
response.getResults().size() < userDao.count(term, true, -1L));
}
@Override
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/GroupChoiceProvider.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/GroupChoiceProvider.java
index d4d4332f7..fb9abd995 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/GroupChoiceProvider.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/GroupChoiceProvider.java
@@ -19,10 +19,10 @@
package org.apache.openmeetings.web.common;
import static org.apache.openmeetings.web.app.WebSession.getUserId;
+import static org.apache.openmeetings.web.app.WebSession.getRights;
import java.util.ArrayList;
import java.util.Collection;
-import java.util.List;
import java.util.Locale;
import org.apache.openmeetings.db.dao.user.GroupDao;
@@ -30,7 +30,7 @
[openmeetings] 02/02: [OPENMEETINGS-2732] jetty
This is an automated email from the ASF dual-hosted git repository. solomax pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git commit 7be6955cdba9779f50e1db45c03677e4db769a28 Author: Maxim Solodovnik AuthorDate: Fri Dec 16 18:06:20 2022 +0700 [OPENMEETINGS-2732] jetty --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 682f0362b..673106d1c 100644 --- a/pom.xml +++ b/pom.xml @@ -118,7 +118,7 @@ 1.10.0 2.0.6 1.4.5 - 9.4.49.v20220914 + 9.4.50.v20221201 test 1.70 4.10.0
[openmeetings] branch master updated (397127453 -> 7be6955cd)
This is an automated email from the ASF dual-hosted git repository. solomax pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git from 397127453 [OPENMEETINGS-2471] messages panel is improved new 478d4dca8 [OPENMEETINGS-2566] Group admin can send invitations to group new 7be6955cd [OPENMEETINGS-2732] jetty The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/openmeetings/db/dao/user/GroupDao.java | 8 +++-- .../web/admin/AdminUserChoiceProvider.java | 2 +- .../web/common/GroupChoiceProvider.java| 21 +++- .../web/room/menu/RoomInvitationForm.java | 2 +- .../web/user/calendar/AppointmentDialog.java | 2 +- .../apache/openmeetings/user/TestUserGroup.java| 38 +- pom.xml| 2 +- 7 files changed, 58 insertions(+), 17 deletions(-)
[jira] [Commented] (OPENMEETINGS-2566) Moderator invitation form
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648576#comment-17648576 ] Maxim Solodovnik commented on OPENMEETINGS-2566: Implemented for "Group Admin" only :)) > Moderator invitation form > - > > Key: OPENMEETINGS-2566 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2566 > Project: Openmeetings > Issue Type: Bug > Components: Invitation >Affects Versions: 5.1.0 >Reporter: Kden >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 7.0.0 > > Attachments: admin.png, moderator.png > > > Hello! > Can each moderator (teacher) send an invitation to one of their groups? > Now this field is visible only by Administrator - I am attaching photos ... > > ... I translated part of the language file into the translation program while > waiting for a response :) > > With great respect for your work! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OPENMEETINGS-2566) Moderator invitation form
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2566. Resolution: Fixed > Moderator invitation form > - > > Key: OPENMEETINGS-2566 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2566 > Project: Openmeetings > Issue Type: Bug > Components: Invitation >Affects Versions: 5.1.0 >Reporter: Kden >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 7.0.0 > > Attachments: admin.png, moderator.png > > > Hello! > Can each moderator (teacher) send an invitation to one of their groups? > Now this field is visible only by Administrator - I am attaching photos ... > > ... I translated part of the language file into the translation program while > waiting for a response :) > > With great respect for your work! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OPENMEETINGS-2744) Users entering conference room are not able to see each other
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2744. Resolution: Abandoned > Users entering conference room are not able to see each other > - > > Key: OPENMEETINGS-2744 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2744 > Project: Openmeetings > Issue Type: Bug > Components: Room >Affects Versions: 7.0.0 >Reporter: Horace Miles >Assignee: Maxim Solodovnik >Priority: Blocker > Attachments: open700-logs.zip > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
