[GitHub] bjustin-ibm commented on issue #174: Ensure trigger payload is within specified size limit

2017-05-25 Thread git
bjustin-ibm commented on issue #174: Ensure trigger payload is within specified 
size limit
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/174#issuecomment-304033801
 
 
   @csantanapr Ok done. Please merge when Travis finishes.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] bjustin-ibm commented on issue #174: Ensure trigger payload is within specified size limit

2017-05-25 Thread git
bjustin-ibm commented on issue #174: Ensure trigger payload is within specified 
size limit
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/174#issuecomment-304033279
 
 
   @csantanapr Actually... give me a minute to manually squash these commits.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] bjustin-ibm commented on issue #174: Ensure trigger payload is within specified size limit

2017-05-25 Thread git
bjustin-ibm commented on issue #174: Ensure trigger payload is within specified 
size limit
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/174#issuecomment-304032801
 
 
   @csantanapr please merge.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] bjustin-ibm commented on issue #174: Ensure trigger payload is within specified size limit

2017-05-24 Thread git
bjustin-ibm commented on issue #174: Ensure trigger payload is within specified 
size limit
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/174#issuecomment-303795904
 
 
   > need test that verifies that messages that exceed the payload limit are 
dropped
   
   @dubeejw Done: 23016b7cd52bdd99d8ec283a8ffeb45c73c44218
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] bjustin-ibm commented on issue #174: Ensure trigger payload is within specified size limit

2017-05-23 Thread git
bjustin-ibm commented on issue #174: Ensure trigger payload is within specified 
size limit
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/174#issuecomment-303518197
 
 
   @dubeejw README updated.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] bjustin-ibm commented on issue #174: Ensure trigger payload is within specified size limit

2017-05-23 Thread git
bjustin-ibm commented on issue #174: Ensure trigger payload is within specified 
size limit
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/174#issuecomment-303515610
 
 
   > Also would be nice to doc the batching behavior
   
   Agreed. I'll update the batching section of the README.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] bjustin-ibm commented on issue #174: Ensure trigger payload is within specified size limit

2017-05-23 Thread git
bjustin-ibm commented on issue #174: Ensure trigger payload is within specified 
size limit
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/174#issuecomment-303514404
 
 
   > possible to test batching
   
   @dubeejw Batch limit is tested here: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/174/files#diff-739f35fdbcde166788378e5daa12611bR194
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] bjustin-ibm commented on issue #174: Ensure trigger payload is within specified size limit

2017-05-11 Thread git
bjustin-ibm commented on issue #174: Ensure trigger payload is within specified 
size limit
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/174#issuecomment-300904546
 
 
   @dubeejw please review
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services