[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5409: Faster bit unpacking (Part 1)
siddharthteotia commented on a change in pull request #5409:
URL: https://github.com/apache/incubator-pinot/pull/5409#discussion_r429077026
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/util/PinotDataBitSetV2.java
##
@@ -0,0 +1,418 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.io.util;
+
+import java.io.Closeable;
+import java.io.IOException;
+import org.apache.pinot.core.plan.DocIdSetPlanNode;
+import org.apache.pinot.core.segment.memory.PinotDataBuffer;
+
+
+public abstract class PinotDataBitSetV2 implements Closeable {
Review comment:
Added several covering all possible cases. Will do another round in a
follow-up
##
File path:
pinot-perf/src/main/java/org/apache/pinot/perf/ForwardIndexBenchmark.java
##
@@ -0,0 +1,269 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.perf;
+
+import com.google.common.base.Stopwatch;
+import java.io.BufferedReader;
+import java.io.BufferedWriter;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
+import java.io.FileReader;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.io.RandomAccessFile;
+import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
+import java.nio.channels.FileChannel;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Random;
+import java.util.concurrent.TimeUnit;
+import me.lemire.integercompression.BitPacking;
+import org.apache.commons.math.util.MathUtils;
+import org.apache.pinot.core.io.reader.impl.v1.FixedBitSingleValueReader;
+import org.apache.pinot.core.io.util.FixedBitIntReaderWriter;
+import org.apache.pinot.core.io.util.FixedBitIntReaderWriterV2;
+import org.apache.pinot.core.io.util.FixedByteValueReaderWriter;
+import org.apache.pinot.core.io.util.PinotDataBitSet;
+import org.apache.pinot.core.io.writer.impl.v1.FixedBitSingleValueWriter;
+import org.apache.pinot.core.segment.memory.PinotDataBuffer;
+
+public class ForwardIndexBenchmark {
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5409: Faster bit unpacking (Part 1)
siddharthteotia commented on a change in pull request #5409:
URL: https://github.com/apache/incubator-pinot/pull/5409#discussion_r429077524
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/util/FixedBitIntReaderWriterV2.java
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.io.util;
+
+import com.google.common.base.Preconditions;
+import java.io.Closeable;
+import java.io.IOException;
+import org.apache.pinot.core.plan.DocIdSetPlanNode;
+import org.apache.pinot.core.segment.memory.PinotDataBuffer;
+
+
+public final class FixedBitIntReaderWriterV2 implements Closeable {
+ private volatile PinotDataBitSetV2 _dataBitSet;
+ private final int _numBitsPerValue;
+
+ public FixedBitIntReaderWriterV2(PinotDataBuffer dataBuffer, int numValues,
int numBitsPerValue) {
Review comment:
Yes, in the follow-up when this code is wired with reader and writer
(FixedBitSingleValueReader and FixedBitSingleValueWriter) and the scan
operator, I will consider if the format has to be changed and bump the version
and write a header. Ri
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch update_website updated (4eac5ab -> 9d62c4a)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch update_website in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 4eac5ab Pinot website: fixing break links and updating installation guide new 9d62c4a Pinot website: fixing break links and updating installation guide This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (4eac5ab) \ N -- N -- N refs/heads/update_website (9d62c4a) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: website/src/pages/index.js | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] 01/01: Pinot website: fixing break links and updating installation guide
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch update_website
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 9d62c4a0e0822e46524faa711db14e0341a1ccdc
Author: Xiang Fu
AuthorDate: Thu May 21 23:51:39 2020 -0700
Pinot website: fixing break links and updating installation guide
---
website/docusaurus.config.js | 6 +++---
website/src/pages/index.js | 26 +++---
2 files changed, 22 insertions(+), 10 deletions(-)
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index ae0fc2d..5ab8938 100755
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -62,10 +62,10 @@ module.exports = {
},
{
label: 'Architecture',
- to: 'https://docs.pinot.apache.org/concepts/architecture',
+ to: 'https://docs.pinot.apache.org/basics/architecture',
},
{
- label: 'PluginsArchitecture',
+ label: 'Plugins Architecture',
to: 'https://docs.pinot.apache.org/plugins/plugin-architecture',
},
],
@@ -100,7 +100,7 @@ module.exports = {
},
{
label: 'User Guide',
- to: 'https://docs.pinot.apache.org/pinot-user-guide',
+ to: 'https://docs.pinot.apache.org/users',
},
{
label: 'Administration',
diff --git a/website/src/pages/index.js b/website/src/pages/index.js
index 21056e8..7ad4752 100755
--- a/website/src/pages/index.js
+++ b/website/src/pages/index.js
@@ -212,20 +212,32 @@ function Installation() {
For
Humans, value: 'humans', },
-{ label: <> For Machines,
value: 'machines', },
+{ label: <> Using
Helm, value: 'helm', },
+{ label: <> Using
Binary, value: 'binary', },
+{ label: <> Build From
Source, value: 'github', },
]
}>
-
+
- wget
https://www.apache.org/dyn/closer.lua/incubator/pinot/apache-pinot-incubating-0.3.0/apache-pinot-incubating-0.3.0-bin.tar.gz
+ {
+`helm repo add pinot
https://raw.githubusercontent.com/apache/incubator-pinot/master/kubernetes/helm\nkubectl
create ns pinot\nhelm install pinot pinot/pinot -n pinot --set
cluster.name=pinot`
+ }
-
+
-wget
https://www.apache.org/dyn/closer.lua/incubator/pinot/apache-pinot-incubating-0.3.0/apache-pinot-incubating-0.3.0-src.tar.gz
-y
+ {
+`VERSION=0.3.0\nwget
https://downloads.apache.org/incubator/pinot/apache-pinot-incubating-$VERSION/apache-pinot-incubating-$VERSION-bin.tar.gz\ntar
vxf apache-pinot-incubating-*-bin.tar.gz\ncd
apache-pinot-incubating-*-bin\nbin/quick-start-batch.sh`
+ }
+
+
+
+
+ {
+`# Clone a repo\ngit clone
https://github.com/apache/incubator-pinot.git\ncd incubator-pinot\n\n# Build
Pinot\nmvn clean install -DskipTests -Pbin-dist\n\n# Run the Quick Demo\ncd
pinot-distribution/target/apache-pinot-incubating-*-SNAPSHOT-bin/apache-pinot-incubating-*-SNAPSHOT-bin\nbin/quick-start-batch.sh`
+ }
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5409: Faster bit unpacking (Part 1)
siddharthteotia commented on a change in pull request #5409:
URL: https://github.com/apache/incubator-pinot/pull/5409#discussion_r429077524
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/util/FixedBitIntReaderWriterV2.java
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.io.util;
+
+import com.google.common.base.Preconditions;
+import java.io.Closeable;
+import java.io.IOException;
+import org.apache.pinot.core.plan.DocIdSetPlanNode;
+import org.apache.pinot.core.segment.memory.PinotDataBuffer;
+
+
+public final class FixedBitIntReaderWriterV2 implements Closeable {
+ private volatile PinotDataBitSetV2 _dataBitSet;
+ private final int _numBitsPerValue;
+
+ public FixedBitIntReaderWriterV2(PinotDataBuffer dataBuffer, int numValues,
int numBitsPerValue) {
Review comment:
Yes, in the follow-up when this code is wired with reader and writer
(FixedBitSingleValueReader and FixedBitSingleValueWriter) and the scan
operator, I will consider if the format has to be changed and bump the version
and write a header.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5431: Pinot website: fixing break links and updating installation guide
fx19880617 opened a new pull request #5431: URL: https://github.com/apache/incubator-pinot/pull/5431 - fixing break links: --architecture --user-guide - Updating installation guide: --helm --binary --github This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5409: Faster bit unpacking (Part 1)
siddharthteotia commented on a change in pull request #5409:
URL: https://github.com/apache/incubator-pinot/pull/5409#discussion_r429084860
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/util/FixedBitIntReaderWriterV2.java
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.io.util;
+
+import com.google.common.base.Preconditions;
+import java.io.Closeable;
+import java.io.IOException;
+import org.apache.pinot.core.plan.DocIdSetPlanNode;
+import org.apache.pinot.core.segment.memory.PinotDataBuffer;
+
+
+public final class FixedBitIntReaderWriterV2 implements Closeable {
+ private volatile PinotDataBitSetV2 _dataBitSet;
+ private final int _numBitsPerValue;
+
+ public FixedBitIntReaderWriterV2(PinotDataBuffer dataBuffer, int numValues,
int numBitsPerValue) {
+Preconditions
+.checkState(dataBuffer.size() == (int) (((long) numValues *
numBitsPerValue + Byte.SIZE - 1) / Byte.SIZE));
+_dataBitSet = PinotDataBitSetV2.createBitSet(dataBuffer, numBitsPerValue);
+_numBitsPerValue = numBitsPerValue;
+ }
+
+ /**
+ * Read dictionaryId for a particular docId
+ * @param index docId to get the dictionaryId for
+ * @return dictionaryId
+ */
+ public int readInt(int index) {
+return _dataBitSet.readInt(index);
+ }
+
+ /**
+ * Array based API to read dictionaryIds for a contiguous
+ * range of docIds starting at startDocId for a given length
+ * @param startDocId docId range start
+ * @param length length of contiguous docId range
+ * @param buffer out buffer to read dictionaryIds into
+ */
+ public void readInt(int startDocId, int length, int[] buffer) {
+_dataBitSet.readInt(startDocId, length, buffer);
+ }
+
+ /**
+ * Array based API to read dictionaryIds for an array of docIds
+ * which are monotonically increasing but not necessarily contiguous
+ * @param docIds array of docIds to read the dictionaryIds for
+ * @param docIdStartIndex start index in docIds array
+ * @param docIdLength length to process in docIds array
+ * @param values out array to store the dictionaryIds into
+ * @param valuesStartIndex start index in values array
+ */
+ public void readValues(int[] docIds, int docIdStartIndex, int docIdLength,
int[] values, int valuesStartIndex) {
+int docIdEndIndex = docIdStartIndex + docIdLength - 1;
+if (shouldBulkRead(docIds, docIdStartIndex, docIdEndIndex)) {
+ _dataBitSet.readInt(docIds, docIdStartIndex, docIdLength, values,
valuesStartIndex);
+} else {
+ for (int i = docIdStartIndex; i <= docIdEndIndex; i++) {
+values[valuesStartIndex++] = _dataBitSet.readInt(docIds[i]);
+ }
+}
+ }
+
+ private boolean shouldBulkRead(int[] docIds, int startIndex, int endIndex) {
+int numDocsToRead = endIndex - startIndex + 1;
+int docIdRange = docIds[endIndex] - docIds[startIndex] + 1;
+if (docIdRange > DocIdSetPlanNode.MAX_DOC_PER_CALL) {
+ return false;
+}
+return numDocsToRead >= ((double)docIdRange * 0.7);
Review comment:
I have provided details in javadoc. Let me know if that is helpful.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components
fx19880617 commented on a change in pull request #5266:
URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r429111007
##
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java
##
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.tools.admin.command;
+
+import java.io.File;
+import java.net.SocketException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import org.apache.commons.configuration.Configuration;
+import org.apache.pinot.common.utils.CommonConstants;
+import org.apache.pinot.controller.ControllerConf;
+import org.apache.pinot.spi.services.ServiceRole;
+import org.apache.pinot.tools.Command;
+import org.apache.pinot.tools.service.PinotServiceManager;
+import org.apache.pinot.tools.utils.PinotConfigUtils;
+import org.kohsuke.args4j.Option;
+import org.kohsuke.args4j.spi.StringArrayOptionHandler;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static
org.apache.pinot.common.utils.CommonConstants.Helix.PINOT_SERVICE_ROLE;
+
+
+/**
+ * Class to implement StartPinotService command.
+ *
+ */
+public class StartServiceManagerCommand extends AbstractBaseAdminCommand
implements Command {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(StartServiceManagerCommand.class);
+ private final List _bootstrapConfigurations = new
ArrayList<>();
+ private final String[] BOOTSTRAP_SERVICES = new String[]{"CONTROLLER",
"BROKER", "SERVER"};
+
+ @Option(name = "-help", required = false, help = true, aliases = {"-h",
"--h", "--help"}, usage = "Print this message.")
+ private boolean _help;
+ @Option(name = "-zkAddress", required = true, metaVar = "", usage =
"Http address of Zookeeper.")
+ private String _zkAddress = DEFAULT_ZK_ADDRESS;
+ @Option(name = "-clusterName", required = true, metaVar = "", usage
= "Pinot cluster name.")
+ private String _clusterName = DEFAULT_CLUSTER_NAME;
+ @Option(name = "-port", required = true, metaVar = "", usage = "Pinot
service manager admin port, -1 means disable, 0 means a random available port.")
Review comment:
it's in `PinotServiceManager`
##
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/EnumArrayOptionHandler.java
##
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.tools.admin.command;
+
+import org.kohsuke.args4j.CmdLineException;
+import org.kohsuke.args4j.CmdLineParser;
+import org.kohsuke.args4j.OptionDef;
+import org.kohsuke.args4j.spi.OptionHandler;
+import org.kohsuke.args4j.spi.Parameters;
+import org.kohsuke.args4j.spi.Setter;
+
+
+public class EnumArrayOptionHandler> extends
OptionHandler {
Review comment:
this is not used. will delete
##
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/service/PinotServiceManagerAdminApiApplication.java
##
@@ -0,0 +1,89 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components
fx19880617 commented on a change in pull request #5266:
URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r429111535
##
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java
##
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.tools.admin.command;
+
+import java.io.File;
+import java.net.SocketException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import org.apache.commons.configuration.Configuration;
+import org.apache.pinot.common.utils.CommonConstants;
+import org.apache.pinot.controller.ControllerConf;
+import org.apache.pinot.spi.services.ServiceRole;
+import org.apache.pinot.tools.Command;
+import org.apache.pinot.tools.service.PinotServiceManager;
+import org.apache.pinot.tools.utils.PinotConfigUtils;
+import org.kohsuke.args4j.Option;
+import org.kohsuke.args4j.spi.StringArrayOptionHandler;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static
org.apache.pinot.common.utils.CommonConstants.Helix.PINOT_SERVICE_ROLE;
+
+
+/**
+ * Class to implement StartPinotService command.
+ *
+ */
+public class StartServiceManagerCommand extends AbstractBaseAdminCommand
implements Command {
Review comment:
added examples
##
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/service/api/resources/PinotServiceManagerInstanceResource.java
##
@@ -0,0 +1,241 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pinot.tools.service.api.resources;
+
+import io.swagger.annotations.Api;
+import io.swagger.annotations.ApiOperation;
+import io.swagger.annotations.ApiParam;
+import io.swagger.annotations.ApiResponse;
+import io.swagger.annotations.ApiResponses;
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import javax.inject.Inject;
+import javax.ws.rs.DELETE;
+import javax.ws.rs.GET;
+import javax.ws.rs.POST;
+import javax.ws.rs.Path;
+import javax.ws.rs.PathParam;
+import javax.ws.rs.Produces;
+import javax.ws.rs.QueryParam;
+import javax.ws.rs.WebApplicationException;
+import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.Response;
+import org.apache.commons.configuration.Configuration;
+import org.apache.commons.configuration.PropertiesConfiguration;
+import org.apache.pinot.common.utils.CommonConstants;
+import org.apache.pinot.common.utils.NetUtil;
+import org.apache.pinot.controller.ControllerConf;
+import org.apache.pinot.spi.services.ServiceRole;
+import org.apache.pinot.spi.utils.JsonUtils;
+import org.apache.pinot.tools.service.PinotServiceManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static
org.apache.pinot.common.utils.CommonConstants.Controller.CONFIG_OF_CONTROLLER_METRICS_PREFIX;
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.a
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components
fx19880617 commented on a change in pull request #5266:
URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r429119690
##
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/service/api/resources/PinotServiceManagerInstanceResource.java
##
@@ -0,0 +1,241 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pinot.tools.service.api.resources;
+
+import io.swagger.annotations.Api;
+import io.swagger.annotations.ApiOperation;
+import io.swagger.annotations.ApiParam;
+import io.swagger.annotations.ApiResponse;
+import io.swagger.annotations.ApiResponses;
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import javax.inject.Inject;
+import javax.ws.rs.DELETE;
+import javax.ws.rs.GET;
+import javax.ws.rs.POST;
+import javax.ws.rs.Path;
+import javax.ws.rs.PathParam;
+import javax.ws.rs.Produces;
+import javax.ws.rs.QueryParam;
+import javax.ws.rs.WebApplicationException;
+import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.Response;
+import org.apache.commons.configuration.Configuration;
+import org.apache.commons.configuration.PropertiesConfiguration;
+import org.apache.pinot.common.utils.CommonConstants;
+import org.apache.pinot.common.utils.NetUtil;
+import org.apache.pinot.controller.ControllerConf;
+import org.apache.pinot.spi.services.ServiceRole;
+import org.apache.pinot.spi.utils.JsonUtils;
+import org.apache.pinot.tools.service.PinotServiceManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static
org.apache.pinot.common.utils.CommonConstants.Controller.CONFIG_OF_CONTROLLER_METRICS_PREFIX;
+import static
org.apache.pinot.common.utils.CommonConstants.Controller.DEFAULT_METRICS_PREFIX;
+import static org.apache.pinot.tools.utils.PinotConfigUtils.TMP_DIR;
+import static org.apache.pinot.tools.utils.PinotConfigUtils.getAvailablePort;
+
+
+@Api(tags = "Startable")
+@Path("/")
+public class PinotServiceManagerInstanceResource {
+
+ private static final Logger LOGGER =
LoggerFactory.getLogger(PinotServiceManagerInstanceResource.class);
+
+ @Inject
+ private PinotServiceManager _pinotServiceManager;
+
+ @GET
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("/instances")
+ @ApiOperation(value = "Get Pinot Instances Status")
+ @ApiResponses(value = {@ApiResponse(code = 200, message = "Instance
Status"), @ApiResponse(code = 500, message = "Internal server error")})
+ public Map getPinotAllInstancesStatus() {
+Map results = new HashMap<>();
+for (String instanceId : _pinotServiceManager.getRunningInstanceIds()) {
+ results.put(instanceId,
_pinotServiceManager.getInstanceStatus(instanceId));
+}
+return results;
+ }
+
+ @GET
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("/instances/{instanceName}")
+ @ApiOperation(value = "Get Pinot Instance Status")
+ @ApiResponses(value = {@ApiResponse(code = 200, message = "Instance
Status"), @ApiResponse(code = 404, message = "Instance Not Found"),
@ApiResponse(code = 500, message = "Internal server error")})
+ public PinotInstanceStatus getPinotInstanceStatus(
+ @ApiParam(value = "Name of the instance") @PathParam("instanceName")
String instanceName) {
+List instanceIds = _pinotServiceManager.getRunningInstanceIds();
+if (instanceIds.contains(instanceName)) {
+ return _pinotServiceManager.getInstanceStatus(instanceName);
+}
+throw new WebApplicationException(String.format("Instance [%s] not
found.", instanceName),
+Response.Status.NOT_FOUND);
+ }
+
+ @DELETE
Review comment:
added `stopAllPinotInstances` and `stopPinotInstancesByRole`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components
fx19880617 commented on a change in pull request #5266:
URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r429120606
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java
##
@@ -43,17 +44,79 @@
*/
@SuppressWarnings("unused")
public class ServiceStatus {
+ public static final String STATUS_DESCRIPTION_NONE = "None";
+ public static final String STATUS_DESCRIPTION_INIT = "Init";
+ public static final String STATUS_DESCRIPTION_STARTED = "Started";
+ public static final String STATUS_DESCRIPTION_NO_HELIX_STATE = "Helix state
does not exist";
private static final Logger LOGGER =
LoggerFactory.getLogger(ServiceStatus.class);
+ private static final int MAX_RESOURCE_NAMES_TO_LOG = 5;
+ private static final Map
serviceStatusCallbackMap = new ConcurrentHashMap<>();
+ private static final ServiceStatusCallback serviceStatusCallback =
+ new
MapBasedMultipleCallbackServiceStatusCallback(serviceStatusCallbackMap);
- public enum Status {
-STARTING, GOOD, BAD
+ public static void setServiceStatusCallback(String name,
ServiceStatusCallback serviceStatusCallback) {
+ServiceStatus.serviceStatusCallbackMap.put(name, serviceStatusCallback);
}
- public static final String STATUS_DESCRIPTION_NONE = "None";
- public static final String STATUS_DESCRIPTION_INIT = "Init";
- public static final String STATUS_DESCRIPTION_NO_HELIX_STATE = "Helix state
does not exist";
+ public static void removeServiceStatusCallback(String name) {
+ServiceStatus.serviceStatusCallbackMap.remove(name);
+ }
- private static final int MAX_RESOURCE_NAMES_TO_LOG = 5;
+ public static Status getServiceStatus() {
+return getServiceStatus(serviceStatusCallback);
+ }
+
+ public static Status getServiceStatus(String name) {
+if (serviceStatusCallbackMap.containsKey(name)) {
+ return getServiceStatus(serviceStatusCallbackMap.get(name));
+} else {
+ return Status.NOT_STARTED;
+}
+ }
+
+ private static Status getServiceStatus(ServiceStatusCallback callback) {
+try {
+ return callback.getServiceStatus();
+} catch (Exception e) {
+ LOGGER.warn("Caught exception while reading the service status", e);
+ return Status.BAD;
+}
+ }
+
+ public static String getStatusDescription() {
+return getStatusDescription(serviceStatusCallback);
+ }
+
+ public static String getStatusDescription(String name) {
+if (serviceStatusCallbackMap.containsKey(name)) {
+ return getStatusDescription(serviceStatusCallbackMap.get(name));
+} else {
+ return STATUS_DESCRIPTION_NONE;
+}
+ }
+
+ private static String getStatusDescription(ServiceStatusCallback callback) {
+try {
+ return callback.getStatusDescription();
+} catch (Exception e) {
+ return "Exception: " + e.getMessage();
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components
fx19880617 commented on a change in pull request #5266:
URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r429123256
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java
##
@@ -43,17 +44,79 @@
*/
@SuppressWarnings("unused")
public class ServiceStatus {
+ public static final String STATUS_DESCRIPTION_NONE = "None";
+ public static final String STATUS_DESCRIPTION_INIT = "Init";
+ public static final String STATUS_DESCRIPTION_STARTED = "Started";
+ public static final String STATUS_DESCRIPTION_NO_HELIX_STATE = "Helix state
does not exist";
private static final Logger LOGGER =
LoggerFactory.getLogger(ServiceStatus.class);
+ private static final int MAX_RESOURCE_NAMES_TO_LOG = 5;
+ private static final Map
serviceStatusCallbackMap = new ConcurrentHashMap<>();
+ private static final ServiceStatusCallback serviceStatusCallback =
+ new
MapBasedMultipleCallbackServiceStatusCallback(serviceStatusCallbackMap);
- public enum Status {
-STARTING, GOOD, BAD
+ public static void setServiceStatusCallback(String name,
ServiceStatusCallback serviceStatusCallback) {
+ServiceStatus.serviceStatusCallbackMap.put(name, serviceStatusCallback);
}
- public static final String STATUS_DESCRIPTION_NONE = "None";
- public static final String STATUS_DESCRIPTION_INIT = "Init";
- public static final String STATUS_DESCRIPTION_NO_HELIX_STATE = "Helix state
does not exist";
+ public static void removeServiceStatusCallback(String name) {
+ServiceStatus.serviceStatusCallbackMap.remove(name);
+ }
- private static final int MAX_RESOURCE_NAMES_TO_LOG = 5;
+ public static Status getServiceStatus() {
+return getServiceStatus(serviceStatusCallback);
+ }
+
+ public static Status getServiceStatus(String name) {
+if (serviceStatusCallbackMap.containsKey(name)) {
+ return getServiceStatus(serviceStatusCallbackMap.get(name));
+} else {
+ return Status.NOT_STARTED;
Review comment:
We have status of `NOT_STARTED`, `STARTING`, `GOOD`, `BAD` for now.
I feel it's ok to say `NOT_STARTED` after we stop an instance, as it's still
possible to start a new instance later on.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on pull request #5422: Complex FieldSpec
siddharthteotia commented on pull request #5422: URL: https://github.com/apache/incubator-pinot/pull/5422#issuecomment-632769152 > LGTM!. I think I can use this for Map now? Yes. I am using it for struct This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia edited a comment on pull request #5422: Complex FieldSpec
siddharthteotia edited a comment on pull request #5422: URL: https://github.com/apache/incubator-pinot/pull/5422#issuecomment-632769152 > LGTM!. I think I can use this for Map now? Yes. I am using it for json This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia merged pull request #5422: Complex FieldSpec
siddharthteotia merged pull request #5422: URL: https://github.com/apache/incubator-pinot/pull/5422 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated: Complex FieldSpec (#5422)
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 66ed883 Complex FieldSpec (#5422)
66ed883 is described below
commit 66ed883627271611bdf36d63177e51ef80a2e53d
Author: Sidd
AuthorDate: Fri May 22 09:27:32 2020 -0700
Complex FieldSpec (#5422)
* new
* Complex field spec
* cleanup
Co-authored-by: Siddharth Teotia
---
.../apache/pinot/spi/data/ComplexFieldSpec.java| 92 ++
.../java/org/apache/pinot/spi/data/FieldSpec.java | 6 +-
.../java/org/apache/pinot/spi/data/Schema.java | 31
3 files changed, 127 insertions(+), 2 deletions(-)
diff --git
a/pinot-spi/src/main/java/org/apache/pinot/spi/data/ComplexFieldSpec.java
b/pinot-spi/src/main/java/org/apache/pinot/spi/data/ComplexFieldSpec.java
new file mode 100644
index 000..3b29fc9
--- /dev/null
+++ b/pinot-spi/src/main/java/org/apache/pinot/spi/data/ComplexFieldSpec.java
@@ -0,0 +1,92 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.data;
+
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import com.google.common.base.Preconditions;
+import java.util.HashMap;
+import java.util.Map;
+import javax.annotation.Nonnull;
+
+
+/**
+ * FieldSpec for complex fields. The {@link
org.apache.pinot.spi.data.FieldSpec.FieldType}
+ * is COMPLEX and the inner data type represents the root data type of the
field.
+ * It could be STRUCT, MAP or LIST. A complex field is composable with a
single root type
+ * and a number of child types. Although we have multi-value primitive
columns, LIST
+ * is for representing lists of both complex and primitives inside a complex
field.
+ *
+ * Consider a person json where the root type is STRUCT and composes of inner
members:
+ * STRUCT(
+ * name: STRING
+ * age: INT
+ * salary: INT
+ * addresses: LIST (STRUCT
+ * apt: INT
+ * street: STRING
+ * city: STRING
+ * zip: INT
+ * )
+ *)
+ *
+ * The fieldspec would be COMPLEX with type as STRUCT and 4 inner members
+ * to model the hierarchy
+ */
+@JsonIgnoreProperties(ignoreUnknown = true)
+public final class ComplexFieldSpec extends FieldSpec {
+
+ private final Map _childFieldSpecs;
+
+ // Default constructor required by JSON de-serializer
+ public ComplexFieldSpec() {
+super();
+_childFieldSpecs = new HashMap<>();
+ }
+
+ public ComplexFieldSpec(@Nonnull String name, DataType dataType, boolean
isSingleValueField) {
+super(name, dataType, isSingleValueField);
+Preconditions.checkArgument(dataType == DataType.STRUCT || dataType ==
DataType.MAP || dataType == DataType.LIST);
+_childFieldSpecs = new HashMap<>();
+ }
+
+ public FieldSpec getChildFieldSpec(String child) {
+return _childFieldSpecs.get(child);
+ }
+
+ public void addChildFieldSpec(String child, FieldSpec fieldSpec) {
+_childFieldSpecs.put(child, fieldSpec);
+ }
+
+ public Map getChildFieldSpecs() {
+return _childFieldSpecs;
+ }
+
+ @JsonIgnore
+ @Nonnull
+ @Override
+ public FieldType getFieldType() {
+return FieldType.COMPLEX;
+ }
+
+ @Override
+ public String toString() {
+return "field type: COMPLEX, field name: " + _name + ", root data type: "
+ _dataType;
+ }
+}
\ No newline at end of file
diff --git a/pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java
b/pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java
index d40a2b4..de3e3ee 100644
--- a/pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java
+++ b/pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java
@@ -318,14 +318,16 @@ public abstract class FieldSpec implements
Comparable {
* segments, otherwise treated the same as DIMENSION field.
*/
public enum FieldType {
-DIMENSION, METRIC, TIME, DATE_TIME
+DIMENS
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components
fx19880617 commented on a change in pull request #5266:
URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r429422165
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/services/ServiceStartable.java
##
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.services;
+
+import org.apache.commons.configuration.Configuration;
+
+
+/**
+ * ServiceStartable is the general interface to manage a Pinot instance
lifecycle for a specific ServiceRole.
+ * E.g. Controller/Broker/Server/Minion.
+ *
+ */
+public interface ServiceStartable {
Review comment:
Changed to StartableService
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh opened a new pull request #5432: [TE] endpoints for alerts page filters
jihaozh opened a new pull request #5432: URL: https://github.com/apache/incubator-pinot/pull/5432 This PR adds the endpoints for the filters in the new alert list page. - Auto-complete for detections, subscription groups, applications, and alert owners. - Search for the alerts that are subscribed by a user. - The endpoints to return a list of all rules in the detection pipeline. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] xiaohui-sun merged pull request #5428: [TE] elr migration
xiaohui-sun merged pull request #5428: URL: https://github.com/apache/incubator-pinot/pull/5428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated (66ed883 -> f8381eb)
This is an automated email from the ASF dual-hosted git repository.
xhsun pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 66ed883 Complex FieldSpec (#5422)
add f8381eb [TE] elr migration (#5428)
No new revisions were added by this update.
Summary of changes:
.travis.yml | 4
.travis/.travis_install.sh | 4 ++--
.travis/.travis_set_deploy_build_opts.sh| 1 +
...vis_nightly_build.sh => .travis_te_nightly_build.sh} | 15 ++-
thirdeye/pom.xml| 12 ++--
thirdeye/thirdeye-frontend/package.json | 7 +++
thirdeye/thirdeye-frontend/pom.xml | 17 ++---
thirdeye/thirdeye-frontend/yarn.lock| 2 +-
thirdeye/thirdeye-hadoop/pom.xml| 2 +-
thirdeye/thirdeye-pinot/pom.xml | 2 +-
10 files changed, 43 insertions(+), 23 deletions(-)
copy .travis/{.travis_nightly_build.sh => .travis_te_nightly_build.sh} (77%)
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #59: fix the NullPointerException in updateTimeBoundaryService()
npawar commented on pull request #59: URL: https://github.com/apache/incubator-pinot/pull/59#issuecomment-632917123 Closing this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #59: fix the NullPointerException in updateTimeBoundaryService()
npawar closed pull request #59: URL: https://github.com/apache/incubator-pinot/pull/59 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #59: fix the NullPointerException in updateTimeBoundaryService()
npawar commented on pull request #59: URL: https://github.com/apache/incubator-pinot/pull/59#issuecomment-632920959 Closing this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #63: fix hadoop MR configuration so hadoop vm will work out of the box
npawar closed pull request #63: URL: https://github.com/apache/incubator-pinot/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #63: fix hadoop MR configuration so hadoop vm will work out of the box
npawar commented on pull request #63: URL: https://github.com/apache/incubator-pinot/pull/63#issuecomment-632921541 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4652: [#4626] Fix a thread race condition during LLC realtime ingestion.
npawar closed pull request #4652: URL: https://github.com/apache/incubator-pinot/pull/4652 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4652: [#4626] Fix a thread race condition during LLC realtime ingestion.
npawar commented on pull request #4652: URL: https://github.com/apache/incubator-pinot/pull/4652#issuecomment-632922492 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #3676: [TE] Fix for anomaly legend values for non_additive daily metrics
npawar commented on pull request #3676: URL: https://github.com/apache/incubator-pinot/pull/3676#issuecomment-632922872 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4469: Add crtl auto complete sql on query-console
npawar commented on pull request #4469: URL: https://github.com/apache/incubator-pinot/pull/4469#issuecomment-632922638 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4382: Fix java client connection close
npawar commented on pull request #4382: URL: https://github.com/apache/incubator-pinot/pull/4382#issuecomment-632922670 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4336: [TE] detection dimensional cache
npawar closed pull request #4336: URL: https://github.com/apache/incubator-pinot/pull/4336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #3850: Aggregation of population standard variance support
npawar commented on pull request #3850: URL: https://github.com/apache/incubator-pinot/pull/3850#issuecomment-632922806 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4244: Add support for custom record-readers in the create-segment tool
npawar commented on pull request #4244: URL: https://github.com/apache/incubator-pinot/pull/4244#issuecomment-632922739 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4472: Use hit counter to track max QPS per minute for broker
npawar commented on pull request #4472: URL: https://github.com/apache/incubator-pinot/pull/4472#issuecomment-632922618 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4348: A template implementation for VarLengthBytesValueReaderWriter
npawar commented on pull request #4348: URL: https://github.com/apache/incubator-pinot/pull/4348#issuecomment-632922697 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4607: Add code for pinot benchmark as a service
npawar closed pull request #4607: URL: https://github.com/apache/incubator-pinot/pull/4607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4244: Add support for custom record-readers in the create-segment tool
npawar closed pull request #4244: URL: https://github.com/apache/incubator-pinot/pull/4244 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4623: [Pinot Bench Service] Implement cluster management component
npawar commented on pull request #4623: URL: https://github.com/apache/incubator-pinot/pull/4623#issuecomment-632922523 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #3676: [TE] Fix for anomaly legend values for non_additive daily metrics
npawar closed pull request #3676: URL: https://github.com/apache/incubator-pinot/pull/3676 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #3808: [PINOT-7] Add Remainder TransformFunction and test
npawar commented on pull request #3808: URL: https://github.com/apache/incubator-pinot/pull/3808#issuecomment-632922827 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4142: Use tr13 for trie based String dictionary
npawar closed pull request #4142: URL: https://github.com/apache/incubator-pinot/pull/4142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4612: Add column types info to the selection and aggregation query results.
npawar commented on pull request #4612: URL: https://github.com/apache/incubator-pinot/pull/4612#issuecomment-632922548 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4607: Add code for pinot benchmark as a service
npawar commented on pull request #4607: URL: https://github.com/apache/incubator-pinot/pull/4607#issuecomment-632922577 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4382: Fix java client connection close
npawar closed pull request #4382: URL: https://github.com/apache/incubator-pinot/pull/4382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4612: Add column types info to the selection and aggregation query results.
npawar closed pull request #4612: URL: https://github.com/apache/incubator-pinot/pull/4612 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4348: A template implementation for VarLengthBytesValueReaderWriter
npawar closed pull request #4348: URL: https://github.com/apache/incubator-pinot/pull/4348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4386: Run cursor selected query in query-console
npawar closed pull request #4386: URL: https://github.com/apache/incubator-pinot/pull/4386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4142: Use tr13 for trie based String dictionary
npawar commented on pull request #4142: URL: https://github.com/apache/incubator-pinot/pull/4142#issuecomment-632922785 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #3731: Ensures that pinot-broker.log logged queries are on single lines
npawar commented on pull request #3731: URL: https://github.com/apache/incubator-pinot/pull/3731#issuecomment-632922853 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4628: [Pinot Bench Service] Implement data preparation component
npawar closed pull request #4628: URL: https://github.com/apache/incubator-pinot/pull/4628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4143: Use patricia trie to OnHeapTrieBasedStringDictionary
npawar commented on pull request #4143: URL: https://github.com/apache/incubator-pinot/pull/4143#issuecomment-632922768 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4294: Fixing some issues docs/getting_started.rst
npawar closed pull request #4294: URL: https://github.com/apache/incubator-pinot/pull/4294 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #3808: [PINOT-7] Add Remainder TransformFunction and test
npawar closed pull request #3808: URL: https://github.com/apache/incubator-pinot/pull/3808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4628: [Pinot Bench Service] Implement data preparation component
npawar commented on pull request #4628: URL: https://github.com/apache/incubator-pinot/pull/4628#issuecomment-632922512 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4386: Run cursor selected query in query-console
npawar commented on pull request #4386: URL: https://github.com/apache/incubator-pinot/pull/4386#issuecomment-632922659 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4336: [TE] detection dimensional cache
npawar commented on pull request #4336: URL: https://github.com/apache/incubator-pinot/pull/4336#issuecomment-632922707 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4143: Use patricia trie to OnHeapTrieBasedStringDictionary
npawar closed pull request #4143: URL: https://github.com/apache/incubator-pinot/pull/4143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4361: Fix to wait until all docs loaded in quick start
npawar closed pull request #4361: URL: https://github.com/apache/incubator-pinot/pull/4361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #3731: Ensures that pinot-broker.log logged queries are on single lines
npawar closed pull request #3731: URL: https://github.com/apache/incubator-pinot/pull/3731 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4168: [TE] Clean up anomalyTimelinesView for anomalies order than 90 days
npawar closed pull request #4168: URL: https://github.com/apache/incubator-pinot/pull/4168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4361: Fix to wait until all docs loaded in quick start
npawar commented on pull request #4361: URL: https://github.com/apache/incubator-pinot/pull/4361#issuecomment-632922680 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4168: [TE] Clean up anomalyTimelinesView for anomalies order than 90 days
npawar commented on pull request #4168: URL: https://github.com/apache/incubator-pinot/pull/4168#issuecomment-632922754 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4526: [TE] Show which rule detected the anomaly in RCA page
npawar closed pull request #4526: URL: https://github.com/apache/incubator-pinot/pull/4526 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4526: [TE] Show which rule detected the anomaly in RCA page
npawar commented on pull request #4526: URL: https://github.com/apache/incubator-pinot/pull/4526#issuecomment-632922592 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #3796: [PINOT-6] Fix Windows compatibility of a batch of pinot-core tests
npawar closed pull request #3796: URL: https://github.com/apache/incubator-pinot/pull/3796 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4472: Use hit counter to track max QPS per minute for broker
npawar closed pull request #4472: URL: https://github.com/apache/incubator-pinot/pull/4472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4623: [Pinot Bench Service] Implement cluster management component
npawar closed pull request #4623: URL: https://github.com/apache/incubator-pinot/pull/4623 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #3796: [PINOT-6] Fix Windows compatibility of a batch of pinot-core tests
npawar commented on pull request #3796: URL: https://github.com/apache/incubator-pinot/pull/3796#issuecomment-632922845 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #4294: Fixing some issues docs/getting_started.rst
npawar commented on pull request #4294: URL: https://github.com/apache/incubator-pinot/pull/4294#issuecomment-632922723 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #3850: Aggregation of population standard variance support
npawar closed pull request #3850: URL: https://github.com/apache/incubator-pinot/pull/3850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #4469: Add crtl auto complete sql on query-console
npawar closed pull request #4469: URL: https://github.com/apache/incubator-pinot/pull/4469 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #2749: Make FixedByteSingleColumnMultiValueReaderWriter and FixedByteSingleColumnSingleValueReaderWriter thread-safe,
npawar commented on pull request #2749: URL: https://github.com/apache/incubator-pinot/pull/2749#issuecomment-632923086 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #2760: Fix Pinot schema REST API documentation
npawar commented on pull request #2760: URL: https://github.com/apache/incubator-pinot/pull/2760#issuecomment-632923079 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #3418: Segment name generator with _postfix
npawar closed pull request #3418: URL: https://github.com/apache/incubator-pinot/pull/3418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #3499: Add table config backup tool
npawar commented on pull request #3499: URL: https://github.com/apache/incubator-pinot/pull/3499#issuecomment-632922969 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #1294: Improve performance of ControllerInstanceToggleTest
npawar closed pull request #1294: URL: https://github.com/apache/incubator-pinot/pull/1294 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #3494: adding StarTreeIndexv1 I/O for hadoop
npawar closed pull request #3494: URL: https://github.com/apache/incubator-pinot/pull/3494 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #1476: Add support for partition pruning for in-clauses.
npawar commented on pull request #1476: URL: https://github.com/apache/incubator-pinot/pull/1476#issuecomment-632923170 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #2936: [PINOT-6513] Initial changes for segment refresh time prefetch
npawar commented on pull request #2936: URL: https://github.com/apache/incubator-pinot/pull/2936#issuecomment-632923047 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #3336: Add metadata info and metric when querying non-existing columns
npawar commented on pull request #3336: URL: https://github.com/apache/incubator-pinot/pull/3336#issuecomment-632923023 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #2847: Yyuen/rootcause share png
npawar commented on pull request #2847: URL: https://github.com/apache/incubator-pinot/pull/2847#issuecomment-632923060 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #3511: [PINOT-7370] Track bytes read per query
npawar commented on pull request #3511: URL: https://github.com/apache/incubator-pinot/pull/3511#issuecomment-632922942 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #1678: Change log level for transient LLC exceptions
npawar commented on pull request #1678: URL: https://github.com/apache/incubator-pinot/pull/1678#issuecomment-632923140 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #1016: Fix tenantName on segment rebalancer
npawar commented on pull request #1016: URL: https://github.com/apache/incubator-pinot/pull/1016#issuecomment-632923193 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #2936: [PINOT-6513] Initial changes for segment refresh time prefetch
npawar closed pull request #2936: URL: https://github.com/apache/incubator-pinot/pull/2936 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #3675: Sslbranch
npawar closed pull request #3675: URL: https://github.com/apache/incubator-pinot/pull/3675 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #3132: [Anomaly Detection] Lib migration tool
npawar closed pull request #3132: URL: https://github.com/apache/incubator-pinot/pull/3132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #3506: Add configuration merging tool
npawar closed pull request #3506: URL: https://github.com/apache/incubator-pinot/pull/3506 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #1486: Add link to Docker in README
npawar closed pull request #1486: URL: https://github.com/apache/incubator-pinot/pull/1486 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #2874: Auto reload segments when schema or table config updated
npawar commented on pull request #2874: URL: https://github.com/apache/incubator-pinot/pull/2874#issuecomment-632923055 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #2847: Yyuen/rootcause share png
npawar closed pull request #2847: URL: https://github.com/apache/incubator-pinot/pull/2847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #2325: Add unit tests for SortedInvertedIndexBasedFilterOperator and SortedIndexReader
npawar closed pull request #2325: URL: https://github.com/apache/incubator-pinot/pull/2325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #3068: [PINOT-6701] Controller API to check storage quota before segment upload
npawar commented on pull request #3068: URL: https://github.com/apache/incubator-pinot/pull/3068#issuecomment-632923038 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #2760: Fix Pinot schema REST API documentation
npawar closed pull request #2760: URL: https://github.com/apache/incubator-pinot/pull/2760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #2685: [TE] frontend = aaronucsd/removed error default state
npawar commented on pull request #2685: URL: https://github.com/apache/incubator-pinot/pull/2685#issuecomment-632923095 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #3661: Add documentation for the new config format
npawar commented on pull request #3661: URL: https://github.com/apache/incubator-pinot/pull/3661#issuecomment-632922896 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #2800: Replace catch Throwable by catch Exception
npawar closed pull request #2800: URL: https://github.com/apache/incubator-pinot/pull/2800 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #1476: Add support for partition pruning for in-clauses.
npawar closed pull request #1476: URL: https://github.com/apache/incubator-pinot/pull/1476 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #3568: Add guava cache to cache table schema in pinot broker
npawar commented on pull request #3568: URL: https://github.com/apache/incubator-pinot/pull/3568#issuecomment-632922927 Closed this PR due to 6 months inactivity. Reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar closed pull request #3624: [PINOT-7370] Return number of bytes read from the reader interfaces/implementations
npawar closed pull request #3624: URL: https://github.com/apache/incubator-pinot/pull/3624 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
