[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…
jackjlli commented on a change in pull request #4399: Moving handling of NULL
values from RecordReaders to NullValueTransfo…
URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r301306848
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/readers/RecordReaderUtils.java
##
@@ -112,8 +112,9 @@ public static Object convert(FieldSpec fieldSpec,
@Nullable Object value) {
public static Object convertSingleValue(FieldSpec fieldSpec, @Nullable
Object value) {
if (value == null) {
// Do not allow default value for time column
Review comment:
Move this comment or add a description to `NullValueTransformer`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…
jackjlli commented on a change in pull request #4399: Moving handling of NULL
values from RecordReaders to NullValueTransfo…
URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r301307017
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/readers/RecordReaderUtils.java
##
@@ -112,8 +112,9 @@ public static Object convert(FieldSpec fieldSpec,
@Nullable Object value) {
public static Object convertSingleValue(FieldSpec fieldSpec, @Nullable
Object value) {
if (value == null) {
// Do not allow default value for time column
- assert fieldSpec.getFieldType() != FieldSpec.FieldType.TIME;
- return fieldSpec.getDefaultNullValue();
+// assert fieldSpec.getFieldType() != FieldSpec.FieldType.TIME;
Review comment:
Clean up these lines. Same for the rest commented statements.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
