kishoreg commented on a change in pull request #4994: Make sql as default query
format.
URL: https://github.com/apache/incubator-pinot/pull/4994#discussion_r368784176
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java
##
@@ -81,37 +83,69 @@ public String post(String requestJsonStr, @Context
HttpHeaders httpHeaders) {
queryOptions = requestJson.get("queryOptions").asText();
}
LOGGER.debug("Trace: {}, Running query: {}", traceEnabled, pqlQuery);
- return getQueryResponse(pqlQuery, traceEnabled, queryOptions,
httpHeaders);
+ return getQueryResponse(pqlQuery, traceEnabled, queryOptions,
httpHeaders, false);
} catch (Exception e) {
LOGGER.error("Caught exception while processing post request", e);
return QueryException.getException(QueryException.INTERNAL_ERROR,
e).toString();
}
}
+ @Deprecated
@GET
@Path("pql")
- public String get(@QueryParam("pql") String pqlQuery, @QueryParam("trace")
String traceEnabled,
+ public String getPql(@QueryParam("pql") String pqlQuery,
@QueryParam("trace") String traceEnabled,
@QueryParam("queryOptions") String queryOptions,
@Context HttpHeaders httpHeaders) {
try {
LOGGER.debug("Trace: {}, Running query: {}", traceEnabled, pqlQuery);
- return getQueryResponse(pqlQuery, traceEnabled, queryOptions,
httpHeaders);
+ return getQueryResponse(pqlQuery, traceEnabled, queryOptions,
httpHeaders, false);
Review comment:
can we use a queryType enum instead of true/false for isSqlQuery
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
