Re: [PR] Update getValidDocIdsMetadataFromServer to make call in batches to servers [pinot]
tibrewalpratik17 commented on code in PR #13314:
URL: https://github.com/apache/pinot/pull/13314#discussion_r1626674964
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java:
##
@@ -61,6 +61,7 @@
*/
public class ServerSegmentMetadataReader {
private static final Logger LOGGER =
LoggerFactory.getLogger(ServerSegmentMetadataReader.class);
+ private static final int DEFAULT_SEGMENT_BATCH_SIZE_FOR_QUERYING_SERVER =
500;
Review Comment:
Discussed offline with @klsince , we want to expose this as a configurable
param in upsert-compaction-task and in the controller GET call API as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] Update getValidDocIdsMetadataFromServer to make call in batches to servers [pinot]
codecov-commenter commented on PR #13314: URL: https://github.com/apache/pinot/pull/13314#issuecomment-2148478178 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13314?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `8 lines` in your changes missing coverage. Please review. > Project coverage is 27.76%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`c7372cd`)](https://app.codecov.io/gh/apache/pinot/commit/c7372cd58965a4d95c2862b90f4235f9b6f4084d?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 553 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/pinot/pull/13314?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...t/controller/util/ServerSegmentMetadataReader.java](https://app.codecov.io/gh/apache/pinot/pull/13314?src=pr=tree=pinot-controller%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcontroller%2Futil%2FServerSegmentMetadataReader.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL1NlcnZlclNlZ21lbnRNZXRhZGF0YVJlYWRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/13314?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #13314 +/- ## = - Coverage 61.75% 27.76% -33.99% + Complexity 207 198-9 = Files 2436 2538 +102 Lines133233 139519 +6286 Branches 2063621594 +958 = - Hits 8227438743-43531 - Misses4491197811+52900 + Partials 6048 2965 -3083 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/13314/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/13314/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `<0.01% <0.00%> (-0.01%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/apache/pinot/pull/13314/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `<0.01% <0.00%> (-0.01%)` | :arrow_down: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/13314/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `<0.01% <0.00%> (-0.01%)` | :arrow_down: | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/13314/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `0.00% <0.00%> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/13314/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `<0.01% <0.00%> (-61.71%)` | :arrow_down: | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/13314/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `27.76% <0.00%> (-33.86%)` | :arrow_down: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/13314/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `<0.01% <0.00%> (-61.75%)` | :arrow_down: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/13314/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `27.76% <0.00%> (+0.04%)` | :arrow_up: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/13314/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `27.76% <0.00%> (-33.99%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/13314/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `27.76% <0.00%> (-33.99%)` | :arrow_down: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/13314/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | |
[PR] Update getValidDocIdsMetadataFromServer to make call in batches to servers [pinot]
tibrewalpratik17 opened a new pull request, #13314: URL: https://github.com/apache/pinot/pull/13314 label: `bugfix` `upsert` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
