Re: [PR] Disabling checkstyle plugin and Spotless plugin for Java version > 21.0 [pinot]
Jackie-Jiang closed pull request #13252: Disabling checkstyle plugin and Spotless plugin for Java version > 21.0 URL: https://github.com/apache/pinot/pull/13252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] Disabling checkstyle plugin and Spotless plugin for Java version > 21.0 [pinot]
Jackie-Jiang commented on PR #13252: URL: https://github.com/apache/pinot/pull/13252#issuecomment-2142792107 We do build java with 21. What failure did you encounter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] Disabling checkstyle plugin and Spotless plugin for Java version > 21.0 [pinot]
xiangfu0 commented on PR #13252: URL: https://github.com/apache/pinot/pull/13252#issuecomment-2136573917 I don't think we should comment the plugin. You can try to detect the jdk version then decide if the plugin should be activated or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
