Re: [PR] Fix Logging Location for CPU-Based Query Killing [pinot]
jasperjiaguo merged PR #13318: URL: https://github.com/apache/pinot/pull/13318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] Fix Logging Location for CPU-Based Query Killing [pinot]
codecov-commenter commented on PR #13318: URL: https://github.com/apache/pinot/pull/13318#issuecomment-2150896993 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13318?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `3 lines` in your changes missing coverage. Please review. > Project coverage is 61.99%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`6d7323b`)](https://app.codecov.io/gh/apache/pinot/commit/6d7323b47bce84ffa4dfe07881af39ac17dabae9?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 556 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/pinot/pull/13318?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...re/accounting/PerQueryCPUMemAccountantFactory.java](https://app.codecov.io/gh/apache/pinot/pull/13318?src=pr=tree=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Faccounting%2FPerQueryCPUMemAccountantFactory.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9hY2NvdW50aW5nL1BlclF1ZXJ5Q1BVTWVtQWNjb3VudGFudEZhY3RvcnkuamF2YQ==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/13318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #13318 +/- ## + Coverage 61.75% 61.99% +0.23% + Complexity 207 198 -9 Files 2436 2540 +104 Lines133233 139591+6358 Branches 2063621597 +961 + Hits 8227486533+4259 - Misses4491146563+1652 - Partials 6048 6495 +447 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/13318/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/13318/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `<0.01% <0.00%> (-0.01%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/apache/pinot/pull/13318/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `<0.01% <0.00%> (-0.01%)` | :arrow_down: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/13318/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `<0.01% <0.00%> (-0.01%)` | :arrow_down: | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/13318/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `0.00% <0.00%> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/13318/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `61.98% <0.00%> (+0.27%)` | :arrow_up: | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/13318/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `27.76% <0.00%> (-33.87%)` | :arrow_down: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/13318/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `61.98% <0.00%> (+0.24%)` | :arrow_up: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/13318/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `27.75% <0.00%> (+0.02%)` | :arrow_up: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/13318/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `61.99% <0.00%> (+0.23%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/13318/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `61.98% <0.00%> (+0.23%)` | :arrow_up: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/13318/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `46.50% <0.00%> (-0.39%)` | :arrow_down: |
