[GitHub] [pulsar] Monica-zy commented on issue #5164: [doc] Improve Pulsar Deployment monitoring
Monica-zy commented on issue #5164: [doc] Improve Pulsar Deployment monitoring URL: https://github.com/apache/pulsar/pull/5164#issuecomment-529779874 @Jennifer88huang Please review~ thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy opened a new pull request #5164: [doc] Improve Pulsar Deployment monitoring
Monica-zy opened a new pull request #5164: [doc] Improve Pulsar Deployment monitoring URL: https://github.com/apache/pulsar/pull/5164 Motivation Improve the language and the overall descriptive style of the Pulsar Security document (deploy-Kubernetes section): http://pulsar.apache.org/docs/en/deploy-monitoring/ Modifications Adjust the tone, personal pronouns, voice also some typo errors of some sentences in the document. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5092: [doc] Improve Pulsar Security Extending
Monica-zy commented on issue #5092: [doc] Improve Pulsar Security Extending URL: https://github.com/apache/pulsar/pull/5092#issuecomment-529778120 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5091: [doc] Improve Pulsar Security Encryption
Monica-zy commented on issue #5091: [doc] Improve Pulsar Security Encryption URL: https://github.com/apache/pulsar/pull/5091#issuecomment-529777941 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5091: [doc] Improve Pulsar Security Encryption
Monica-zy removed a comment on issue #5091: [doc] Improve Pulsar Security Encryption URL: https://github.com/apache/pulsar/pull/5091#issuecomment-529752068 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5140: [doc] Improve Pulsar Deployment DCOS
Monica-zy commented on issue #5140: [doc] Improve Pulsar Deployment DCOS URL: https://github.com/apache/pulsar/pull/5140#issuecomment-529777869 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5102: [doc] Improve Pulsar Deployment Kubernetes
Monica-zy commented on issue #5102: [doc] Improve Pulsar Deployment Kubernetes URL: https://github.com/apache/pulsar/pull/5102#issuecomment-52909 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #5154: [Doc] Add producer configuration description for Java client
yjshen commented on issue #5154: [Doc] Add producer configuration description for Java client URL: https://github.com/apache/pulsar/pull/5154#issuecomment-529764114 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet edited a comment on issue #5163: [Doc] Add reader configuration description for Java client
Anonymitaet edited a comment on issue #5163: [Doc] Add reader configuration description for Java client URL: https://github.com/apache/pulsar/pull/5163#issuecomment-529756228 @yjshen could you please help review? Thank you Should I add `resetIncludeHead` here? If yes, could you please provide a description for it? (I did not find the description in Pulsar project) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5163: [Doc] Add reader configuration description for Java client
Anonymitaet commented on issue #5163: [Doc] Add reader configuration description for Java client URL: https://github.com/apache/pulsar/pull/5163#issuecomment-529756228 @yjshen could you please help review? Thank you Should I add `resetIncludeHead` here? If yes, could you please provide description for it? (I did not find the description in Pulsar project) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet opened a new pull request #5163: [Doc] Add reader configuration description for Java client
Anonymitaet opened a new pull request #5163: [Doc] Add reader configuration description for Java client URL: https://github.com/apache/pulsar/pull/5163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] liketic commented on issue #5147: Deprecate getstatus subcommand for source command
liketic commented on issue #5147: Deprecate getstatus subcommand for source command URL: https://github.com/apache/pulsar/pull/5147#issuecomment-529755778 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5102: [doc] Improve Pulsar Deployment Kubernetes
Monica-zy commented on issue #5102: [doc] Improve Pulsar Deployment Kubernetes URL: https://github.com/apache/pulsar/pull/5102#issuecomment-529752763 run java8 tests run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5092: [doc] Improve Pulsar Security Extending
Monica-zy commented on issue #5092: [doc] Improve Pulsar Security Extending URL: https://github.com/apache/pulsar/pull/5092#issuecomment-529752200 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5091: [doc] Improve Pulsar Security Encryption
Monica-zy commented on issue #5091: [doc] Improve Pulsar Security Encryption URL: https://github.com/apache/pulsar/pull/5091#issuecomment-529752068 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] massakam commented on a change in pull request #5155: [pulsar-broker] Close RateLimiter instance
massakam commented on a change in pull request #5155: [pulsar-broker] Close
RateLimiter instance
URL: https://github.com/apache/pulsar/pull/5155#discussion_r322534421
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentDispatcherSingleActiveConsumer.java
##
@@ -146,4 +147,9 @@ protected void readMoreEntries(Consumer consumer) {
protected void cancelPendingRead() {
// No-op
}
+
+public CompletableFuture close() {
+IS_CLOSED_UPDATER.set(this, TRUE);
+return disconnectAllConsumers();
Review comment:
Restored `AbstractDispatcherSingleActiveConsumer#close()`. Only
`PersistentDispatcherSingleActiveConsumer` overrides it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] k2la commented on issue #4634: Delivery of messages to consumers stops until broker is restarted
k2la commented on issue #4634: Delivery of messages to consumers stops until broker is restarted URL: https://github.com/apache/pulsar/issues/4634#issuecomment-529739924 Delivery of messages to consumers resumes when `unload` executes. So, there might be hints in `unload`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5111: [doc] Improve Pulsar deployment bare metal
aahmed-se commented on issue #5111: [doc] Improve Pulsar deployment bare metal URL: https://github.com/apache/pulsar/pull/5111#issuecomment-529739389 please rebase this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (61c75af -> 505e08a)
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 61c75af Fix quote in README.md (#5149) add 505e08a Capitalize L in SQL (#5125) No new revisions were added by this update. Summary of changes: site2/docs/sql-deployment-configurations.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [pulsar] aahmed-se merged pull request #5125: Capitalize L in SQL
aahmed-se merged pull request #5125: Capitalize L in SQL URL: https://github.com/apache/pulsar/pull/5125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] k2la edited a comment on issue #4634: Delivery of messages to consumers stops until broker is restarted
k2la edited a comment on issue #4634: Delivery of messages to consumers stops until broker is restarted URL: https://github.com/apache/pulsar/issues/4634#issuecomment-529735896 This image is the `PersistentDispatcherMultipleConsumers` instance which has the topic from heap dump.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] k2la commented on issue #4634: Delivery of messages to consumers stops until broker is restarted
k2la commented on issue #4634: Delivery of messages to consumers stops until broker is restarted URL: https://github.com/apache/pulsar/issues/4634#issuecomment-529735896 This image is the `PersistentDispatcherMultipleConsumers` instance which has the topic.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se opened a new pull request #5162: Fix Postgres debezium test
aahmed-se opened a new pull request #5162: Fix Postgres debezium test URL: https://github.com/apache/pulsar/pull/5162 We need to exclude the meta tables from cdc tracking to make the test deterministic and consistently pass. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch postgres4 updated (0cf9a22 -> a99ce46)
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch postgres4 in repository https://gitbox.apache.org/repos/asf/pulsar.git. discard 0cf9a22 Fix Postgres debezium test omit 32a46c4 Add ping util to Docker file new a99ce46 Fix Postgres debezium test This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (0cf9a22) \ N -- N -- N refs/heads/postgres4 (a99ce46) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docker/pulsar/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[pulsar] branch postgres4 created (now 0cf9a22)
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch postgres4 in repository https://gitbox.apache.org/repos/asf/pulsar.git. at 0cf9a22 Fix Postgres debezium test This branch includes the following new commits: new 0cf9a22 Fix Postgres debezium test The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[pulsar] 01/01: Fix Postgres debezium test
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a commit to branch postgres4 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit a99ce46d272c12641aee6fef71b965d37654b6cb Author: Ali Ahmed AuthorDate: Mon Sep 9 18:35:56 2019 -0700 Fix Postgres debezium test Remove meteadata tables for cdc test --- .../pulsar/tests/integration/io/DebeziumPostgresqlSourceTester.java | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgresqlSourceTester.java b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgresqlSourceTester.java index 893eca4..e95db22 100644 --- a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgresqlSourceTester.java +++ b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgresqlSourceTester.java @@ -66,6 +66,7 @@ public class DebeziumPostgresqlSourceTester extends SourceTester
[pulsar] 01/01: Fix Postgres debezium test
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a commit to branch postgres4 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 0cf9a22047978a87822eaece84bea5a3233f2b75 Author: Ali Ahmed AuthorDate: Mon Sep 9 18:35:56 2019 -0700 Fix Postgres debezium test Remove meteadata tables for cdc test --- .../pulsar/tests/integration/io/DebeziumPostgresqlSourceTester.java | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgresqlSourceTester.java b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgresqlSourceTester.java index 893eca4..e95db22 100644 --- a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgresqlSourceTester.java +++ b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgresqlSourceTester.java @@ -66,6 +66,7 @@ public class DebeziumPostgresqlSourceTester extends SourceTester
[GitHub] [pulsar] aahmed-se opened a new pull request #5161: Add ping util to Docker file
aahmed-se opened a new pull request #5161: Add ping util to Docker file URL: https://github.com/apache/pulsar/pull/5161 This adds the ping command to the docker image This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch ping1 created (now 32a46c4)
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch ping1 in repository https://gitbox.apache.org/repos/asf/pulsar.git. at 32a46c4 Add ping util to Docker file This branch includes the following new commits: new 32a46c4 Add ping util to Docker file The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[pulsar] 01/01: Add ping util to Docker file
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a commit to branch ping1 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 32a46c4a50e3a3208cb086789147cc4b91863562 Author: Ali Ahmed AuthorDate: Mon Sep 9 18:21:14 2019 -0700 Add ping util to Docker file --- docker/pulsar/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker/pulsar/Dockerfile b/docker/pulsar/Dockerfile index 4315961..de4470b 100644 --- a/docker/pulsar/Dockerfile +++ b/docker/pulsar/Dockerfile @@ -43,7 +43,7 @@ COPY --from=pulsar /pulsar /pulsar # Install some utilities RUN apt-get update \ - && apt-get install -y netcat dnsutils less procps \ + && apt-get install -y netcat dnsutils less procps iputils-ping \ python2.7 python-setuptools \ python3-setuptools \ libreadline-gplv2-dev libncursesw5-dev libssl-dev libsqlite3-dev tk-dev libgdbm-dev libc6-dev libbz2-dev \
[GitHub] [pulsar] aahmed-se opened a new pull request #5160: Disable postgres debezium integration test
aahmed-se opened a new pull request #5160: Disable postgres debezium integration test URL: https://github.com/apache/pulsar/pull/5160 The test is giving some random deterministic result , disabling it while I debug it further. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch postgres3 created (now c85c8ad)
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch postgres3 in repository https://gitbox.apache.org/repos/asf/pulsar.git. at c85c8ad Disable postgres debezium integration test This branch includes the following new commits: new c85c8ad Disable postgres debezium integration test The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[pulsar] 01/01: Disable postgres debezium integration test
This is an automated email from the ASF dual-hosted git repository.
aahmed pushed a commit to branch postgres3
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit c85c8ad289d0e65901fa308afa38aa9273244857
Author: Ali Ahmed
AuthorDate: Mon Sep 9 17:58:23 2019 -0700
Disable postgres debezium integration test
---
.../apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
index 7fda45b..e9f64ae 100644
---
a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
+++
b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
@@ -118,7 +118,7 @@ public abstract class PulsarFunctionsTest extends
PulsarFunctionsTestBase {
testDebeziumMySqlConnect();
}
-@Test
+@Test(enabled = false)
public void testDebeziumPostgresqlSource() throws Exception {
testDebeziumPostgresqlConnect();
}
[GitHub] [pulsar] liketic commented on issue #5147: Deprecate getstatus subcommand for source command
liketic commented on issue #5147: Deprecate getstatus subcommand for source command URL: https://github.com/apache/pulsar/pull/5147#issuecomment-529722721 @sijie Please review again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5154: [Doc] Add producer configuration description for Java client
Anonymitaet commented on issue #5154: [Doc] Add producer configuration description for Java client URL: https://github.com/apache/pulsar/pull/5154#issuecomment-529720281 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5154: [Doc] Add producer configuration description for Java client
Anonymitaet commented on issue #5154: [Doc] Add producer configuration description for Java client URL: https://github.com/apache/pulsar/pull/5154#issuecomment-529719670 @sijie thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fxbing commented on issue #4963: Add more config for auto-topic-creation
fxbing commented on issue #4963: Add more config for auto-topic-creation URL: https://github.com/apache/pulsar/pull/4963#issuecomment-529718085 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5155: [pulsar-broker] Close RateLimiter instance
aahmed-se commented on issue #5155: [pulsar-broker] Close RateLimiter instance URL: https://github.com/apache/pulsar/pull/5155#issuecomment-529707488 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se opened a new pull request #5159: Change logging for debezium key value pairs
aahmed-se opened a new pull request #5159: Change logging for debezium key value pairs URL: https://github.com/apache/pulsar/pull/5159 Explicitly print out the Key Value pairs for debezium tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch postgres2 created (now fceee7c)
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch postgres2 in repository https://gitbox.apache.org/repos/asf/pulsar.git. at fceee7c Change logging for debezium key value pairs This branch includes the following new commits: new fceee7c Change logging for debezium key value pairs The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[pulsar] 01/01: Change logging for debezium key value pairs
This is an automated email from the ASF dual-hosted git repository.
aahmed pushed a commit to branch postgres2
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit fceee7c96312d4aa8b078aae66e03347d5b98381
Author: Ali Ahmed
AuthorDate: Mon Sep 9 15:55:40 2019 -0700
Change logging for debezium key value pairs
---
.../pulsar/tests/integration/io/DebeziumMySqlSourceTester.java | 6 +++---
.../pulsar/tests/integration/io/DebeziumPostgreSqlSourceTester.java | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git
a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumMySqlSourceTester.java
b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumMySqlSourceTester.java
index 2d1b4b5..580bf2c 100644
---
a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumMySqlSourceTester.java
+++
b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumMySqlSourceTester.java
@@ -91,9 +91,9 @@ public class DebeziumMySqlSourceTester extends
SourceTester> msg = consumer.receive(2,
TimeUnit.SECONDS);
while(msg != null) {
recordsNumber ++;
-log.info("Received message: {}.", msg.getValue());
-String key = new String(msg.getValue().getKey());
-String value = new String(msg.getValue().getValue());
+final String key = new String(msg.getValue().getKey());
+final String value = new String(msg.getValue().getValue());
+log.info("Received message: key = {}, value = {}.", key, value);
Assert.assertTrue(key.contains("dbserver1.inventory.products.Key"));
Assert.assertTrue(value.contains("dbserver1.inventory.products.Value"));
consumer.acknowledge(msg);
diff --git
a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgreSqlSourceTester.java
b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgreSqlSourceTester.java
index 8d445f5..c3b6786 100644
---
a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgreSqlSourceTester.java
+++
b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgreSqlSourceTester.java
@@ -92,9 +92,9 @@ public class DebeziumPostgreSqlSourceTester extends
SourceTester> msg = consumer.receive(2,
TimeUnit.SECONDS);
while(msg != null) {
recordsNumber ++;
-log.info("Received message: {}.", msg.getValue());
-String key = new String(msg.getValue().getKey());
-String value = new String(msg.getValue().getValue());
+final String key = new String(msg.getValue().getKey());
+final String value = new String(msg.getValue().getValue());
+log.info("Received message: key = {}, value = {}.", key, value);
Assert.assertTrue(key.contains("dbserver1.inventory.products.Key"));
Assert.assertTrue(value.contains("dbserver1.inventory.products.Value"));
consumer.acknowledge(msg);
[GitHub] [pulsar] aahmed-se merged pull request #5149: [Doc] Fix quote in README.md
aahmed-se merged pull request #5149: [Doc] Fix quote in README.md URL: https://github.com/apache/pulsar/pull/5149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated: Fix quote in README.md (#5149)
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 61c75af Fix quote in README.md (#5149) 61c75af is described below commit 61c75aff1f08078403f4505241de944951c3a87f Author: Like AuthorDate: Tue Sep 10 06:54:58 2019 +0800 Fix quote in README.md (#5149) --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a7e340d..1945eb9 100644 --- a/README.md +++ b/README.md @@ -100,7 +100,7 @@ To configure annotation processing in IntelliJ: 1. Set "Production sources directory:" to "target/generated-sources/annotations". 2. Set "Test sources directory:" to "target/generated-test-sources/test-annotations". -4. Click “OK”. +4. Click "OK". 5. Install the lombok plugin in intellij.
[GitHub] [pulsar] aahmed-se commented on issue #5156: [Documentation] Add Rust Client Library
aahmed-se commented on issue #5156: [Documentation] Add Rust Client Library URL: https://github.com/apache/pulsar/pull/5156#issuecomment-529681286 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se opened a new pull request #5158: Make naming consistent for Debezium postgreSql
aahmed-se opened a new pull request #5158: Make naming consistent for Debezium postgreSql URL: https://github.com/apache/pulsar/pull/5158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] 01/01: Make naming consistent for Debezium postgreSql
This is an automated email from the ASF dual-hosted git repository.
aahmed pushed a commit to branch postgres1
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 5da44c107709ca9bfe725bee91dcffc6a0f9745a
Author: Ali Ahmed
AuthorDate: Mon Sep 9 14:32:11 2019 -0700
Make naming consistent for Debezium postgreSql
---
...qlContainer.java => DebeziumPostgreSqlContainer.java} | 4 ++--
.../tests/integration/functions/PulsarFunctionsTest.java | 14 +++---
...ceTester.java => DebeziumPostgreSqlSourceTester.java} | 16
3 files changed, 17 insertions(+), 17 deletions(-)
diff --git
a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/DebeziumPostgresqlContainer.java
b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/DebeziumPostgreSqlContainer.java
similarity index 91%
rename from
tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/DebeziumPostgresqlContainer.java
rename to
tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/DebeziumPostgreSqlContainer.java
index e85c27c..8f32c05 100644
---
a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/DebeziumPostgresqlContainer.java
+++
b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/DebeziumPostgreSqlContainer.java
@@ -21,14 +21,14 @@ package org.apache.pulsar.tests.integration.containers;
import org.testcontainers.containers.wait.strategy.HostPortWaitStrategy;
-public class DebeziumPostgresqlContainer extends
ChaosContainer {
+public class DebeziumPostgreSqlContainer extends
ChaosContainer {
public static final String NAME = "debezium-postgresql-example";
static final Integer[] PORTS = { 5432 };
private static final String IMAGE_NAME = "debezium/example-postgres:0.10";
-public DebeziumPostgresqlContainer(String clusterName) {
+public DebeziumPostgreSqlContainer(String clusterName) {
super(clusterName, IMAGE_NAME);
this.withEnv("POSTGRES_USER", "postgres");
this.withEnv("POSTGRES_PASSWORD", "postgres");
diff --git
a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
index 7fda45b..23beec8 100644
---
a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
+++
b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
@@ -45,7 +45,7 @@ import org.apache.pulsar.common.schema.KeyValue;
import org.apache.pulsar.functions.api.examples.AutoSchemaFunction;
import org.apache.pulsar.functions.api.examples.serde.CustomObject;
import org.apache.pulsar.tests.integration.containers.DebeziumMySQLContainer;
-import
org.apache.pulsar.tests.integration.containers.DebeziumPostgresqlContainer;
+import
org.apache.pulsar.tests.integration.containers.DebeziumPostgreSqlContainer;
import org.apache.pulsar.tests.integration.docker.ContainerExecException;
import org.apache.pulsar.tests.integration.docker.ContainerExecResult;
import org.apache.pulsar.tests.integration.functions.utils.CommandGenerator;
@@ -119,8 +119,8 @@ public abstract class PulsarFunctionsTest extends
PulsarFunctionsTestBase {
}
@Test
-public void testDebeziumPostgresqlSource() throws Exception {
-testDebeziumPostgresqlConnect();
+public void testDebeziumPostgreSqlSource() throws Exception {
+testDebeziumPostgreSqlConnect();
}
private void testSink(SinkTester tester, boolean builtin) throws Exception
{
@@ -1966,7 +1966,7 @@ public abstract class PulsarFunctionsTest extends
PulsarFunctionsTestBase {
getSourceInfoNotFound(tenant, namespace, sourceName);
}
-private void testDebeziumPostgresqlConnect() throws Exception {
+private void testDebeziumPostgreSqlConnect() throws Exception {
final String tenant = TopicName.PUBLIC_TENANT;
final String namespace = TopicName.DEFAULT_NAMESPACE;
@@ -1991,11 +1991,11 @@ public abstract class PulsarFunctionsTest extends
PulsarFunctionsTestBase {
.subscribe();
@Cleanup
-DebeziumPostgresqlSourceTester sourceTester = new
DebeziumPostgresqlSourceTester(pulsarCluster);
+DebeziumPostgreSqlSourceTester sourceTester = new
DebeziumPostgreSqlSourceTester(pulsarCluster);
// setup debezium postgresql server
-DebeziumPostgresqlContainer postgresqlContainer = new
DebeziumPostgresqlContainer(pulsarCluster.getClusterName());
-sourceTester.setServiceContainer(postgresqlContainer);
+DebeziumPostgreSqlContainer postgreSqlContainer = new
DebeziumPostgreSqlContainer(pulsarCluster.getClusterName());
+sourceTester.setServiceContainer(postgreSqlContainer);
// prepare the testing
[pulsar] branch postgres1 created (now 5da44c1)
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch postgres1 in repository https://gitbox.apache.org/repos/asf/pulsar.git. at 5da44c1 Make naming consistent for Debezium postgreSql This branch includes the following new commits: new 5da44c1 Make naming consistent for Debezium postgreSql The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [pulsar] sijie commented on issue #5100: [bookkeeper] allow configuring region aware placement related settings
sijie commented on issue #5100: [bookkeeper] allow configuring region aware placement related settings URL: https://github.com/apache/pulsar/pull/5100#issuecomment-529652105 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer
sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer URL: https://github.com/apache/pulsar/pull/5045#issuecomment-529650938 @codelipenghui @jiazhai @merlimat I have addressed all the comments. PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5125: Capitalize L in SQL
sijie commented on issue #5125: Capitalize L in SQL URL: https://github.com/apache/pulsar/pull/5125#issuecomment-529644115 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5146: Remove method testValidateFunctionsConfigs which was abandoned
sijie commented on issue #5146: Remove method testValidateFunctionsConfigs which was abandoned URL: https://github.com/apache/pulsar/pull/5146#issuecomment-529643893 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5130: PIP-41 (part-1): Introduce Protocol Handler API
sijie commented on issue #5130: PIP-41 (part-1): Introduce Protocol Handler API URL: https://github.com/apache/pulsar/pull/5130#issuecomment-529643007 I have added the unit tests for newly introduced classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #4668: Add Debezium Postgresql integration test
sijie commented on issue #4668: Add Debezium Postgresql integration test URL: https://github.com/apache/pulsar/pull/4668#issuecomment-529629507 @aahmed-se before you merging any pull request, can you please double check the whole conversation? This pull request is 2 months old and there are comments that are not addressed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5123: Modify the schema decode method can decode ByteBuf
sijie commented on a change in pull request #5123: Modify the schema decode
method can decode ByteBuf
URL: https://github.com/apache/pulsar/pull/5123#discussion_r322407811
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericJsonReader.java
##
@@ -48,9 +48,9 @@ public GenericJsonReader(byte[] schemaVersion, List
fields){
this.schemaVersion = schemaVersion;
}
@Override
-public GenericJsonRecord read(byte[] bytes) {
+public GenericJsonRecord read(byte[] bytes, int offset, int length) {
try {
-JsonNode jn = objectMapper.readTree(new String(bytes, UTF_8));
+JsonNode jn = objectMapper.readTree(new String(bytes, 0, length,
UTF_8));
Review comment:
```suggestion
JsonNode jn = objectMapper.readTree(new String(bytes, offset,
length, UTF_8));
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5123: Modify the schema decode method can decode ByteBuf
sijie commented on a change in pull request #5123: Modify the schema decode
method can decode ByteBuf
URL: https://github.com/apache/pulsar/pull/5123#discussion_r322405968
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/StringSchema.java
##
@@ -93,6 +102,22 @@ public String decode(byte[] bytes) {
}
}
+public String decode(ByteBuf byteBuf) {
+if (null == byteBuf) {
+return null;
+} else {
+int size = byteBuf.readableBytes();
+byte[] bytes = tmpBuffer.get();
+if (size > bytes.length) {
+bytes = new byte[size * 2];
+tmpBuffer.set(bytes);
+}
+byteBuf.readBytes(bytes, 0, size);
+
+return new String(bytes, 0, size, charset);
Review comment:
I think we should create a new buffer for the `String`. because the pass-in
byte[] will be referenced by the `String` object.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5123: Modify the schema decode method can decode ByteBuf
sijie commented on a change in pull request #5123: Modify the schema decode
method can decode ByteBuf
URL: https://github.com/apache/pulsar/pull/5123#discussion_r322404253
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/ByteBufferSchema.java
##
@@ -68,6 +77,22 @@ public ByteBuffer decode(byte[] data) {
}
}
+@Override
+public ByteBuffer decode(ByteBuf byteBuf) {
+if (null == byteBuf) {
+return null;
+} else {
+int size = byteBuf.readableBytes();
Review comment:
since we are returning a `ByteBuffer` back to the user, we shouldn't use a
shared byte[]. You have to copy the bytes from ByteBuf and create ByteBuffer
from the copied bytes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5123: Modify the schema decode method can decode ByteBuf
sijie commented on a change in pull request #5123: Modify the schema decode
method can decode ByteBuf
URL: https://github.com/apache/pulsar/pull/5123#discussion_r322405151
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/FloatSchema.java
##
@@ -45,6 +45,13 @@ public void validate(byte[] message) {
}
}
+@Override
+public void validate(ByteBuf message) {
+if (message.readableBytes()!= 4) {
Review comment:
```suggestion
if (message.readableBytes() != 4) {
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5123: Modify the schema decode method can decode ByteBuf
sijie commented on a change in pull request #5123: Modify the schema decode
method can decode ByteBuf
URL: https://github.com/apache/pulsar/pull/5123#discussion_r322407669
##
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/SchemaReader.java
##
@@ -26,5 +26,17 @@
* @param bytes the data
* @return the serialized object
*/
-T read(byte[] bytes);
+default T read(byte[] bytes) {
+return read(bytes, 0, bytes.length);
+}
+
+/**
+ * serialize bytes convert pojo
+ *
+ * @param bytes the data
+ * @param offset the byte[] initial position
+ * @param length the byte[] read length
+ * @return the serialized object
+ */
+T read(byte[] bytes, int offset, int length);
Review comment:
Also add a method from read from `InputStream`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5123: Modify the schema decode method can decode ByteBuf
sijie commented on a change in pull request #5123: Modify the schema decode
method can decode ByteBuf
URL: https://github.com/apache/pulsar/pull/5123#discussion_r322406286
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/StructSchema.java
##
@@ -99,6 +108,37 @@ public T decode(byte[] bytes, byte[] schemaVersion) {
}
}
+@Override
+public T decode(ByteBuf byteBuf) {
+int size = getCanReadSize(byteBuf);
+return reader.read(tmpBuffer.get(), 0, size);
+}
+
+@Override
+public T decode(ByteBuf byteBuf, byte[] schemaVersion) {
+int size = getCanReadSize(byteBuf);
+
+try {
+return
readerCache.get(BytesSchemaVersion.of(schemaVersion)).read(tmpBuffer.get(), 0,
size );
+} catch (ExecutionException e) {
+LOG.error("Can't get generic schema for topic {} schema version
{}",
+schemaInfoProvider.getTopicName(),
Hex.encodeHexString(schemaVersion), e);
+throw new RuntimeException("Can't get generic schema for topic " +
schemaInfoProvider.getTopicName());
+}
+}
+
+private int getCanReadSize(ByteBuf byteBuf) {
Review comment:
enlargeReadBufferSize
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5123: Modify the schema decode method can decode ByteBuf
sijie commented on a change in pull request #5123: Modify the schema decode
method can decode ByteBuf
URL: https://github.com/apache/pulsar/pull/5123#discussion_r322407074
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/StructSchema.java
##
@@ -99,6 +108,37 @@ public T decode(byte[] bytes, byte[] schemaVersion) {
}
}
+@Override
+public T decode(ByteBuf byteBuf) {
+int size = getCanReadSize(byteBuf);
+return reader.read(tmpBuffer.get(), 0, size);
Review comment:
I think we should avoid copying the bytes from `ByteBuf` to the tmpBuffer. I
believe AVRO provides mechanism to read from an input stream. You can convert
the ByteBuf into an input stream.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5147: Deprecate getstatus subcommand for source command
sijie commented on issue #5147: Deprecate getstatus subcommand for source command URL: https://github.com/apache/pulsar/pull/5147#issuecomment-529618556 @liketic please rebase this pull request This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (7cdd354 -> ae3e89a)
This is an automated email from the ASF dual-hosted git repository.
aahmed pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 7cdd354 Fix typo in method getMessageDropRate (#5150)
add ae3e89a Add Debezium Postgresql integration test (#4668)
No new revisions were added by this update.
Summary of changes:
...ainer.java => DebeziumPostgresqlContainer.java} | 16 +++--
.../integration/functions/PulsarFunctionsTest.java | 72 +++---
...er.java => DebeziumPostgresqlSourceTester.java} | 55 +
3 files changed, 98 insertions(+), 45 deletions(-)
copy
tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/{DebeziumMySQLContainer.java
=> DebeziumPostgresqlContainer.java} (75%)
copy
tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/{DebeziumMySqlSourceTester.java
=> DebeziumPostgresqlSourceTester.java} (62%)
[GitHub] [pulsar] aahmed-se merged pull request #4668: Add Debezium Postgresql integration test
aahmed-se merged pull request #4668: Add Debezium Postgresql integration test URL: https://github.com/apache/pulsar/pull/4668 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5149: [Doc] Fix quote in README.md
sijie commented on issue #5149: [Doc] Fix quote in README.md URL: https://github.com/apache/pulsar/pull/5149#issuecomment-529617740 run cpp tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5152: Fixed spark receiver to account for all the consumer config options
sijie commented on issue #5152: Fixed spark receiver to account for all the consumer config options URL: https://github.com/apache/pulsar/pull/5152#issuecomment-529617609 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5153: [doc]Add brokerClient authentication configuration
aahmed-se commented on issue #5153: [doc]Add brokerClient authentication configuration URL: https://github.com/apache/pulsar/pull/5153#issuecomment-529617145 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5154: [Doc] Add producer configuration description for Java client
aahmed-se commented on issue #5154: [Doc] Add producer configuration description for Java client URL: https://github.com/apache/pulsar/pull/5154#issuecomment-529617108 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5153: [doc]Add brokerClient authentication configuration
aahmed-se commented on issue #5153: [doc]Add brokerClient authentication configuration URL: https://github.com/apache/pulsar/pull/5153#issuecomment-529617292 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5155: [pulsar-broker] Close RateLimiter instance
aahmed-se commented on issue #5155: [pulsar-broker] Close RateLimiter instance URL: https://github.com/apache/pulsar/pull/5155#issuecomment-529617006 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5154: [Doc] Add producer configuration description for Java client
sijie commented on issue #5154: [Doc] Add producer configuration description for Java client URL: https://github.com/apache/pulsar/pull/5154#issuecomment-529616525 @Anonymitaet pulsar.RoundRobinDistribution This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5156: [Documentation] Add Rust Client Library
sijie commented on issue #5156: [Documentation] Add Rust Client Library URL: https://github.com/apache/pulsar/pull/5156#issuecomment-529616015 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] stupidusername opened a new issue #5157: [docs] How does --processing-guarantees affect source connectors?
stupidusername opened a new issue #5157: [docs] How does --processing-guarantees affect source connectors? URL: https://github.com/apache/pulsar/issues/5157 The command `sources create` accepts a `--processing-guarantees` option. I tried to find out what's the difference between the accepted options but I could not find an answer in the docs. Did I miss something or does the documentation need a little improvement? Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #5075: [pulsar-client] support set read-position based on timestamp
rdhabalia commented on issue #5075: [pulsar-client] support set read-position based on timestamp URL: https://github.com/apache/pulsar/pull/5075#issuecomment-529592559 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] AlJaMa edited a comment on issue #5156: [Documentation] Add Rust Client Library
AlJaMa edited a comment on issue #5156: [Documentation] Add Rust Client Library URL: https://github.com/apache/pulsar/pull/5156#issuecomment-529565782 FYI to primary maintainer @stearnsc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] AlJaMa commented on issue #5156: [Documentation] Add Rust Client Library
AlJaMa commented on issue #5156: [Documentation] Add Rust Client Library URL: https://github.com/apache/pulsar/pull/5156#issuecomment-529565782 FYI: @stearnsc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] AlJaMa opened a new pull request #5156: [Documentation] Add Rust Client Library
AlJaMa opened a new pull request #5156: [Documentation] Add Rust Client Library URL: https://github.com/apache/pulsar/pull/5156 ### Motivation In an effort to expand the Pulsar ecosystem, Wyyerd has written a rust-native pulsar client. It is at a point where we believe other parties may find it useful. ### Modifications Added a link in the `client` documentation page under the `3rd party` section. ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. - Dependencies (does it add or upgrade a dependency): no - The public API: no - The schema: no - The default values of configurations: no - The wire protocol: no - The rest endpoints: no - The admin cli options: no - Anything that affects deployment: no ### Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable - If a feature is not applicable for documentation, explain why? Only changed documentation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5155: [pulsar-broker] Close RateLimiter instance
merlimat commented on a change in pull request #5155: [pulsar-broker] Close
RateLimiter instance
URL: https://github.com/apache/pulsar/pull/5155#discussion_r322334485
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentDispatcherSingleActiveConsumer.java
##
@@ -146,4 +147,9 @@ protected void readMoreEntries(Consumer consumer) {
protected void cancelPendingRead() {
// No-op
}
+
+public CompletableFuture close() {
+IS_CLOSED_UPDATER.set(this, TRUE);
+return disconnectAllConsumers();
Review comment:
Since this part is still common, we could keep in the abstract class and
then call `super.close()` where needed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] massakam commented on issue #5155: [pulsar-broker] Close RateLimiter instance
massakam commented on issue #5155: [pulsar-broker] Close RateLimiter instance URL: https://github.com/apache/pulsar/pull/5155#issuecomment-529546805 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] KannarFr commented on issue #5112: How to Date type -> AVRO -> Presto
KannarFr commented on issue #5112: How to Date type -> AVRO -> Presto URL: https://github.com/apache/pulsar/issues/5112#issuecomment-529481451 poke @codelipenghui @congbobo184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] massakam opened a new pull request #5155: [pulsar-broker] Close RateLimiter instance
massakam opened a new pull request #5155: [pulsar-broker] Close RateLimiter instance URL: https://github.com/apache/pulsar/pull/5155 ### Motivation As a result of analyzing the heap dump of our broker server, we found that the number of `RateLimiter` instances is very large.  `RateLimiter` instances that are no longer used should be closed, but do not seem to be closed, for example, when a subscription is deleted. As a result, I think that `RateLimiter#renewTask` keeps running without being canceled and GC is not performed. https://github.com/apache/pulsar/blob/d9c0a1054310e9428007d016895d4174b0d20f89/pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java#L56 ### Modifications Whenever a topic, subscription or replicator is closed or deleted, RateLimiter is also closed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5154: [Doc] Add producer configuration description for Java client
Anonymitaet commented on issue #5154: [Doc] Add producer configuration description for Java client URL: https://github.com/apache/pulsar/pull/5154#issuecomment-529430608 @yjshen could you please help review? Thank you Double-check: The default value of `messageRoutingMode` is `null` or `pulsar.RoundRobinDistribution`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet opened a new pull request #5154: [Doc] Add producer configuration description for Java client
Anonymitaet opened a new pull request #5154: [Doc] Add producer configuration description for Java client URL: https://github.com/apache/pulsar/pull/5154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5142: [docs] Managing partitioned topics page has odd "Nonpartitioned topics resources" section
Jennifer88huang commented on issue #5142: [docs] Managing partitioned topics page has odd "Nonpartitioned topics resources" section URL: https://github.com/apache/pulsar/issues/5142#issuecomment-529400177 Sure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #5123: Modify the schema decode method can decode ByteBuf
congbobo184 commented on issue #5123: Modify the schema decode method can decode ByteBuf URL: https://github.com/apache/pulsar/pull/5123#issuecomment-529375338 @sijie please take a look at this PR again :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch asf-site updated: Updated site at revision 7cdd354b0b
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 0d50648 Updated site at revision 7cdd354b0b
0d50648 is described below
commit 0d50648f8258daac87665a56c7835761c763a8e1
Author: jenkins
AuthorDate: Mon Sep 9 08:57:45 2019 +
Updated site at revision 7cdd354b0b
---
content/swagger/2.5.0-SNAPSHOT/swagger.json| 22 +++---
.../swagger/2.5.0-SNAPSHOT/swaggerfunctions.json | 22 +++---
content/swagger/master/swagger.json| 22 +++---
content/swagger/master/swaggerfunctions.json | 22 +++---
4 files changed, 44 insertions(+), 44 deletions(-)
diff --git a/content/swagger/2.5.0-SNAPSHOT/swagger.json
b/content/swagger/2.5.0-SNAPSHOT/swagger.json
index 16f1364..a5584df 100644
--- a/content/swagger/2.5.0-SNAPSHOT/swagger.json
+++ b/content/swagger/2.5.0-SNAPSHOT/swagger.json
@@ -4784,7 +4784,7 @@
"200" : {
"description" : "successful operation",
"schema" : {
- "$ref" : "#/definitions/NonPersistentTopicStats"
+ "$ref" : "#/definitions/TopicStats"
}
},
"401" : {
@@ -8866,12 +8866,6 @@
"type" : "number",
"format" : "double"
},
-"cpu" : {
- "$ref" : "#/definitions/ResourceUsage"
-},
-"memory" : {
- "$ref" : "#/definitions/ResourceUsage"
-},
"directMemory" : {
"$ref" : "#/definitions/ResourceUsage"
},
@@ -8885,10 +8879,6 @@
"type" : "integer",
"format" : "int64"
},
-"msgThroughputIn" : {
- "type" : "number",
- "format" : "double"
-},
"underLoaded" : {
"type" : "boolean"
},
@@ -8898,9 +,19 @@
"loadReportType" : {
"type" : "string"
},
+"msgThroughputIn" : {
+ "type" : "number",
+ "format" : "double"
+},
"msgThroughputOut" : {
"type" : "number",
"format" : "double"
+},
+"cpu" : {
+ "$ref" : "#/definitions/ResourceUsage"
+},
+"memory" : {
+ "$ref" : "#/definitions/ResourceUsage"
}
}
},
diff --git a/content/swagger/2.5.0-SNAPSHOT/swaggerfunctions.json
b/content/swagger/2.5.0-SNAPSHOT/swaggerfunctions.json
index 02dfa12..6081fd5 100644
--- a/content/swagger/2.5.0-SNAPSHOT/swaggerfunctions.json
+++ b/content/swagger/2.5.0-SNAPSHOT/swaggerfunctions.json
@@ -1359,15 +1359,8 @@
"type" : "integer",
"format" : "int64"
},
-"keyBytes" : {
- "type" : "array",
- "items" : {
-"type" : "string",
-"format" : "byte"
- }
-},
-"encryptionCtx" : {
- "$ref" : "#/definitions/EncryptionContext"
+"messageId" : {
+ "$ref" : "#/definitions/MessageId"
},
"sequenceId" : {
"type" : "integer",
@@ -1380,8 +1373,8 @@
"format" : "byte"
}
},
-"messageId" : {
- "$ref" : "#/definitions/MessageId"
+"encryptionCtx" : {
+ "$ref" : "#/definitions/EncryptionContext"
},
"redeliveryCount" : {
"type" : "integer",
@@ -1403,6 +1396,13 @@
"producerName" : {
"type" : "string"
},
+"keyBytes" : {
+ "type" : "array",
+ "items" : {
+"type" : "string",
+"format" : "byte"
+ }
+},
"data" : {
"type" : "array",
"items" : {
diff --git a/content/swagger/master/swagger.json
b/content/swagger/master/swagger.json
index 16f1364..a5584df 100644
--- a/content/swagger/master/swagger.json
+++ b/content/swagger/master/swagger.json
@@ -4784,7 +4784,7 @@
"200" : {
"description" : "successful operation",
"schema" : {
- "$ref" : "#/definitions/NonPersistentTopicStats"
+ "$ref" : "#/definitions/TopicStats"
}
},
"401" : {
@@ -8866,12 +8866,6 @@
"type" : "number",
"format" : "double"
},
-"cpu" : {
- "$ref" : "#/definitions/ResourceUsage"
-},
-"memory" : {
- "$ref" : "#/definitions/ResourceUsage"
-},
"directMemory" : {
"$ref" : "#/definitions/ResourceUsage"
},
@@ -8885,10 +8879,6 @@
"type" : "integer",
"format" : "int64"
},
-"msgThroughputIn" : {
- "type" : "number",
- "format" : "double"
-},
"underLoaded" : {
"type" : "boolean"
},
@@ -8898,9 +,19 @@
[GitHub] [pulsar] skyrocknroll commented on issue #5153: [doc]Add brokerClient authentication configuration
skyrocknroll commented on issue #5153: [doc]Add brokerClient authentication configuration URL: https://github.com/apache/pulsar/pull/5153#issuecomment-529351049 Good One! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng opened a new pull request #5153: [doc]Add brokerClient authentication configuration
tuteng opened a new pull request #5153: [doc]Add brokerClient authentication configuration URL: https://github.com/apache/pulsar/pull/5153 Fixes https://github.com/apache/pulsar/issues/4560 Master Issue: https://github.com/apache/pulsar/issues/4560 ### Motivation The current document is not clear about authentication between multiple brokers, and users often encounter 401 errors. ### Modifications * Add document configuration for brokerClient ### Verifying this change After configuring brokerClientAuthenticationPlugin and brokerClientAuthenticationParameters in `broker.conf` locally, start multiple brokers. Run the following command to test, no 401 returns ``` ./bin/pulsar-admin topics create-partitioned-topic test-partitioned -p 4 ./bin/pulsar-admin topics delete-partitioned-topic test-partitioned ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5147: Deprecate getstatus subcommand for source command
sijie commented on issue #5147: Deprecate getstatus subcommand for source command URL: https://github.com/apache/pulsar/pull/5147#issuecomment-529336529 > And further more, I guess we can merge pulsar-client-tool-test into pulsar-client-tool, which only contains serval tests. @sijie WDYT? yes I think these can be merged. they were separated to address shading issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5142: [docs] Managing partitioned topics page has odd "Nonpartitioned topics resources" section
sijie commented on issue #5142: [docs] Managing partitioned topics page has odd "Nonpartitioned topics resources" section URL: https://github.com/apache/pulsar/issues/5142#issuecomment-529335740 @Jennifer88huang can you help check the issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5057: Can't publish messages with schema on Pulsar C++ client
sijie commented on issue #5057: Can't publish messages with schema on Pulsar C++ client URL: https://github.com/apache/pulsar/issues/5057#issuecomment-529322752 closed as the question is answered This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie closed issue #5057: Can't publish messages with schema on Pulsar C++ client
sijie closed issue #5057: Can't publish messages with schema on Pulsar C++ client URL: https://github.com/apache/pulsar/issues/5057 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
