[GitHub] [pulsar] massakam commented on issue #5246: [Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference
massakam commented on issue #5246: [Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference URL: https://github.com/apache/pulsar/pull/5246#issuecomment-534877620 PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5211: [Doc] Add *Kinesis source connector guide*
Anonymitaet commented on issue #5211: [Doc] Add *Kinesis source connector guide* URL: https://github.com/apache/pulsar/pull/5211#issuecomment-534870161 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5214: [Doc] Add *Kinesis sink connector guide*
Anonymitaet commented on issue #5214: [Doc] Add *Kinesis sink connector guide* URL: https://github.com/apache/pulsar/pull/5214#issuecomment-534870118 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5238: [Doc] Add *Flume sink connector guide*
Anonymitaet commented on issue #5238: [Doc] Add *Flume sink connector guide* URL: https://github.com/apache/pulsar/pull/5238#issuecomment-534870083 run java8 tests run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5240: [Doc] Add *File source connector guide*
Anonymitaet commented on issue #5240: [Doc] Add *File source connector guide* URL: https://github.com/apache/pulsar/pull/5240#issuecomment-534870012 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet removed a comment on issue #5240: [Doc] Add *File source connector guide*
Anonymitaet removed a comment on issue #5240: [Doc] Add *File source connector guide* URL: https://github.com/apache/pulsar/pull/5240#issuecomment-534870012 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5251: [Doc] Add *Twitter Firehose source connector guide*
Anonymitaet commented on issue #5251: [Doc] Add *Twitter Firehose source connector guide* URL: https://github.com/apache/pulsar/pull/5251#issuecomment-534869985 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5256: [Doc] Add *Aerospike sink connector guide*
Anonymitaet commented on issue #5256: [Doc] Add *Aerospike sink connector guide* URL: https://github.com/apache/pulsar/pull/5256#issuecomment-534869948 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5250: [Doc] Add configs for broker
Anonymitaet commented on issue #5250: [Doc] Add configs for broker URL: https://github.com/apache/pulsar/pull/5250#issuecomment-534869068 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5258: [Doc] Add *ElasticSearch sink connector guide*
Anonymitaet commented on issue #5258: [Doc] Add *ElasticSearch sink connector guide* URL: https://github.com/apache/pulsar/pull/5258#issuecomment-534868899 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5256: [Doc] Add *Aerospike sink connector guide*
Anonymitaet commented on issue #5256: [Doc] Add *Aerospike sink connector guide* URL: https://github.com/apache/pulsar/pull/5256#issuecomment-534868825 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5256: [Doc] Add *Aerospike sink connector guide*
Anonymitaet commented on issue #5256: [Doc] Add *Aerospike sink connector guide* URL: https://github.com/apache/pulsar/pull/5256#issuecomment-534867986 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5221: [doc] Improve Pulsar Administration Pulsar dashboard
Monica-zy removed a comment on issue #5221: [doc] Improve Pulsar Administration Pulsar dashboard URL: https://github.com/apache/pulsar/pull/5221#issuecomment-534862045 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5221: [doc] Improve Pulsar Administration Pulsar dashboard
Monica-zy commented on issue #5221: [doc] Improve Pulsar Administration Pulsar dashboard URL: https://github.com/apache/pulsar/pull/5221#issuecomment-534862235 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534862115 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534861862 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534852574 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5221: [doc] Improve Pulsar Administration Pulsar dashboard
Monica-zy commented on issue #5221: [doc] Improve Pulsar Administration Pulsar dashboard URL: https://github.com/apache/pulsar/pull/5221#issuecomment-534862045 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534861425 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534861862 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy
Monica-zy removed a comment on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy URL: https://github.com/apache/pulsar/pull/5236#issuecomment-534830549 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5221: [doc] Improve Pulsar Administration Pulsar dashboard
Monica-zy removed a comment on issue #5221: [doc] Improve Pulsar Administration Pulsar dashboard URL: https://github.com/apache/pulsar/pull/5221#issuecomment-534820473 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5221: [doc] Improve Pulsar Administration Pulsar dashboard
Monica-zy commented on issue #5221: [doc] Improve Pulsar Administration Pulsar dashboard URL: https://github.com/apache/pulsar/pull/5221#issuecomment-534861628 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy
Monica-zy commented on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy URL: https://github.com/apache/pulsar/pull/5236#issuecomment-534861778 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534861425 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534861310 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534831789 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] volfco opened a new issue #5274: geo replicated subscribers
volfco opened a new issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274 One of the big things missing in my book, is a way to have multiple subscribers across datacenters consume messages "exactly" once. DC A produces 5 messages. DC A has a consume subscription named TEST. DC B has a consumer with the same name. Ideally, a consumer in DC A process messages 1,2,3 while DC B is able to process 4 and 5. From my admittedly limited research, I don't think this is currently supported. Subscribers cursor is currently per DC, which allows for consumers in each DC to consume the same message. I could implement this on the client side by using the configuration store zookeeper to record a "lock" on a message ID to disallow consumption on other consumers- but this seems like something that could be implemented inside the broker and configurable on a per-namespace level. At the expense of consumption latency and zookeeper I/O, I think this would be an amazing feature. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5263: Fix Cmake to build _pulsar for osx
aahmed-se commented on issue #5263: Fix Cmake to build _pulsar for osx URL: https://github.com/apache/pulsar/pull/5263#issuecomment-534853927 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5219: [doc] Improve Pulsar Administration geo-replication
Monica-zy removed a comment on issue #5219: [doc] Improve Pulsar Administration geo-replication URL: https://github.com/apache/pulsar/pull/5219#issuecomment-534852674 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5219: [doc] Improve Pulsar Administration geo-replication
Monica-zy removed a comment on issue #5219: [doc] Improve Pulsar Administration geo-replication URL: https://github.com/apache/pulsar/pull/5219#issuecomment-534820662 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5219: [doc] Improve Pulsar Administration geo-replication
Monica-zy commented on issue #5219: [doc] Improve Pulsar Administration geo-replication URL: https://github.com/apache/pulsar/pull/5219#issuecomment-534852674 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534852574 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5246: [Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference
merlimat commented on a change in pull request #5246: [Issue
#5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding
object reference
URL: https://github.com/apache/pulsar/pull/5246#discussion_r327924003
##
File path: pulsar-client-cpp/lib/ConnectionPool.h
##
@@ -59,7 +61,7 @@ class PULSAR_PUBLIC ConnectionPool {
ClientConfiguration clientConfiguration_;
ExecutorServiceProviderPtr executorProvider_;
AuthenticationPtr authentication_;
-typedef std::map PoolMap;
+typedef std::map PoolMap;
Review comment:
> While iterating the pool map, I am worried that the iterator would be
broken when ClientConnection is destructed.
The iterator itself is on a map in `ConnectionPool` so that will still be
always safe to use here.
The `ClientConnectionWeakPtr` can, of course, be possibly already destroyed,
though the `lock()` operation will attempt to acquire a ref count on the object
and get a `shared_ptr`. The resulting `shared_ptr` has to be checked if it's
valid, and if it is, it will be kept alive by the shared_ptr.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] massakam commented on a change in pull request #5246: [Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference
massakam commented on a change in pull request #5246: [Issue
#5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding
object reference
URL: https://github.com/apache/pulsar/pull/5246#discussion_r327923422
##
File path: pulsar-client-cpp/lib/ConnectionPool.h
##
@@ -59,7 +61,7 @@ class PULSAR_PUBLIC ConnectionPool {
ClientConfiguration clientConfiguration_;
ExecutorServiceProviderPtr executorProvider_;
AuthenticationPtr authentication_;
-typedef std::map PoolMap;
+typedef std::map PoolMap;
Review comment:
> What is the reason for changing the `weak_ptr` into a `shared_ptr`?
While iterating the pool map, I am worried that the iterator would be broken
when `ClientConnection` is destructed.
> Couldn't we just do the same with the `weak_ptr` and calling `lock()`
while iterating through the map and closing the ptr that are still valid?
I will try to fix it like that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5246: [Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference
merlimat commented on a change in pull request #5246: [Issue
#5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding
object reference
URL: https://github.com/apache/pulsar/pull/5246#discussion_r327918866
##
File path: pulsar-client-cpp/lib/ConnectionPool.cc
##
@@ -42,24 +42,40 @@ ConnectionPool::ConnectionPool(const ClientConfiguration&
conf, ExecutorServiceP
poolConnections_(poolConnections),
mutex_() {}
+ConnectionPool::~ConnectionPool() {
+std::unique_lock lock(mutex_);
+
+if (poolConnections_) {
+for (auto cnxIt = pool_.begin(); cnxIt != pool_.end(); cnxIt++) {
+ClientConnectionPtr cnx = cnxIt->second;
+if (cnx && !cnx->isClosed()) {
+cnx->close();
+}
+}
+pool_.clear();
+}
+
+lock.unlock();
Review comment:
nit: the `unlock()` is automatically done in the lock destructor.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5246: [Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference
merlimat commented on a change in pull request #5246: [Issue
#5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding
object reference
URL: https://github.com/apache/pulsar/pull/5246#discussion_r327920862
##
File path: pulsar-client-cpp/lib/ConnectionPool.h
##
@@ -59,7 +61,7 @@ class PULSAR_PUBLIC ConnectionPool {
ClientConfiguration clientConfiguration_;
ExecutorServiceProviderPtr executorProvider_;
AuthenticationPtr authentication_;
-typedef std::map PoolMap;
+typedef std::map PoolMap;
Review comment:
What is the reason for changing the `weak_ptr` into a `shared_ptr`?
This could also potentially have side effects, like not destructing the
connections (that are already closed) while the pool is active.
As I understand this change, the reason is to iterate through the map in the
`~ConnectionPool` and force calling `ClientConnectionPtr::close()`. Couldn't we
just do the same with the `weak_ptr` and calling `lock()` while iterating
through the map and closing the ptr that are still valid?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-534837006 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] massakam commented on a change in pull request #5246: [Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference
massakam commented on a change in pull request #5246: [Issue
#5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding
object reference
URL: https://github.com/apache/pulsar/pull/5246#discussion_r327918625
##
File path: pulsar-client-cpp/lib/ClientConnection.cc
##
@@ -1382,6 +1385,10 @@ void ClientConnection::close() {
if (tlsSocket_) {
tlsSocket_->lowest_layer().close();
}
+
+if (executor_) {
+executor_.reset();
Review comment:
Removed this in this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5263: Fix Cmake to build _pulsar for osx
aahmed-se commented on issue #5263: Fix Cmake to build _pulsar for osx URL: https://github.com/apache/pulsar/pull/5263#issuecomment-534835306 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] massakam commented on a change in pull request #5246: [WIP][Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference
massakam commented on a change in pull request #5246: [WIP][Issue
#5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding
object reference
URL: https://github.com/apache/pulsar/pull/5246#discussion_r327917970
##
File path: pulsar-client-cpp/lib/ConnectionPool.cc
##
@@ -80,4 +80,20 @@ Future
ConnectionPool::getConnectionAsync(
return future;
}
+void ConnectionPool::close() {
Review comment:
Yes. I added the destructor instead of the `close()` method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide
Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide URL: https://github.com/apache/pulsar/issues/5015#issuecomment-524149120 I've created the following PRs to resolve this issue: ## Overview * https://github.com/apache/pulsar/pull/5183 * https://github.com/apache/pulsar/pull/5224 ## Use * https://github.com/apache/pulsar/pull/5071 ## Built-in connector Connectors come into two types: ### Source * https://github.com/apache/pulsar/pull/5168 * https://github.com/apache/pulsar/pull/5173 * https://github.com/apache/pulsar/pull/5197 * https://github.com/apache/pulsar/pull/5199 * https://github.com/apache/pulsar/pull/5203 * https://github.com/apache/pulsar/pull/5210 * https://github.com/apache/pulsar/pull/5211 * https://github.com/apache/pulsar/pull/5214 * https://github.com/apache/pulsar/pull/5226 ### Sink * Flume sink: https://github.com/apache/pulsar/pull/5238 * HDFS3 sink: https://github.com/apache/pulsar/pull/5239 * File source: https://github.com/apache/pulsar/pull/5240 * Twitter Firehose source: https://github.com/apache/pulsar/pull/5251 * Netty source: https://github.com/apache/pulsar/pull/5253 * Rabbit source: https://github.com/apache/pulsar/pull/5255 * Aerospike sink: https://github.com/apache/pulsar/pull/5256 * Cassandra sink: https://github.com/apache/pulsar/pull/5257 * ElasticSearch sink: https://github.com/apache/pulsar/pull/5258 * InfluxDB sink: https://github.com/apache/pulsar/pull/5273 ## CDC connector * https://github.com/apache/pulsar/pull/5198 ## Debug * https://github.com/apache/pulsar/pull/5041 ## Connector Admin CLI * https://github.com/apache/pulsar/pull/5028 * https://github.com/apache/pulsar/pull/5184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet opened a new pull request #5273: [Doc] Add *InfluxDB sink connector guide*
Anonymitaet opened a new pull request #5273: [Doc] Add *InfluxDB sink connector guide* URL: https://github.com/apache/pulsar/pull/5273 Fix https://github.com/apache/pulsar/issues/5015 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5273: [Doc] Add *InfluxDB sink connector guide*
Anonymitaet commented on issue #5273: [Doc] Add *InfluxDB sink connector guide* URL: https://github.com/apache/pulsar/pull/5273#issuecomment-534834693 @tuteng could you please help review? Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-534834433 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534831730 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534832469 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534832365 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534831789 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534831679 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534831468 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534831613 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534831730 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534831562 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534831388 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534831613 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534831284 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534831468 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534831327 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534831562 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534831199 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534831388 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534831046 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534831327 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534830871 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534831284 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534830949 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534831199 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534831046 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534830591 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534830473 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534830949 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534830387 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534830871 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534830591 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534830270 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy
Monica-zy commented on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy URL: https://github.com/apache/pulsar/pull/5236#issuecomment-534830549 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy
Monica-zy removed a comment on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy URL: https://github.com/apache/pulsar/pull/5236#issuecomment-534830184 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534830122 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534830473 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534830387 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534829595 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534830270 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534830017 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy
Monica-zy removed a comment on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy URL: https://github.com/apache/pulsar/pull/5236#issuecomment-534829860 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy
Monica-zy commented on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy URL: https://github.com/apache/pulsar/pull/5236#issuecomment-534830184 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534830122 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534829544 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy commented on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534830017 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin
Monica-zy removed a comment on issue #5213: [doc] Improve Pulsar Administration ZooKeeper and BookKeeper admin URL: https://github.com/apache/pulsar/pull/5213#issuecomment-534820855 run cpp tests run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy
Monica-zy commented on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy URL: https://github.com/apache/pulsar/pull/5236#issuecomment-534829860 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy
Monica-zy removed a comment on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy URL: https://github.com/apache/pulsar/pull/5236#issuecomment-534829476 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy removed a comment on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534829335 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy removed a comment on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534829267 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade
Monica-zy commented on issue #5237: [doc] Improve Pulsar Administration Upgrade URL: https://github.com/apache/pulsar/pull/5237#issuecomment-534829595 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534829544 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-534829489 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-534473240 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy removed a comment on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy
Monica-zy removed a comment on issue #5236: [doc] Improve Pulsar Administration Pulsar proxy URL: https://github.com/apache/pulsar/pull/5236#issuecomment-534829154 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics
Monica-zy commented on issue #5225: [doc] Improve Pulsar Administration Pulsar Statistics URL: https://github.com/apache/pulsar/pull/5225#issuecomment-534829335 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
